[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765



--- Comment #2 from Jeremy Newton  ---
Some updates:
-Fixed f26+ build (sed patch, upstream pull request included)
-Removed curl patch as it's not unnecessary (also fixed 7.50 typo)
-Clean up spec using macros
-Make use of %license macro

Spec URL: https://dl.dropboxusercontent.com/u/42480493/dolphin-emu.spec
SRPM URL:
https://dl.dropboxusercontent.com/u/42480493/dolphin-emu-5.0-5.fc25.src.rpm

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16767110

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934



--- Comment #9 from Fedora Update System  ---
python3-jinja2-2.8-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-45c1c0b276

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391951] Review Request: php-cs-fixer - A tool to automatically fix PHP code style

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391951



--- Comment #20 from Fedora Update System  ---
php-cs-fixer-2.0.0-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-0f90e4d0d8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
python3-jinja2-2.8-2.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d4293aff8d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397643] Review Request: dapl - Library providing access to the DAT 2.0 API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397643

Honggang LI  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-12-05 23:02:28



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391951] Review Request: php-cs-fixer - A tool to automatically fix PHP code style

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391951

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #19 from Fedora Update System  ---
php-cs-fixer-2.0.0-1.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-eff2120f31

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400489] Review Request: perl-BSON - BSON serialization and deserialization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400489

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
perl-BSON-1.2.2-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-1fac7083e1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382152] Review Request: orpie - scientific calculator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382152



--- Comment #24 from Jared Wallace  ---
F26 has introduced some changes to default compiler flags:
https://fedoraproject.org/wiki/Changes/Fedora26CFlags

which required some more patches.

SPEC:
https://bitbucket.org/jared-wallace/orpie/raw/c06bd4f36d4a8fe023364da5c172d281e9941c74/SPECS/orpie.spec

SRPM:
https://bitbucket.org/jared-wallace/orpie/raw/c06bd4f36d4a8fe023364da5c172d281e9941c74/SRPMS/orpie-1.5.2-4.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380179] Review Request: webvirtmgr - panel for manage virtual machine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380179

Raphael Groner  changed:

   What|Removed |Added

 Blocks||1285816 (PYTHON3)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1285816
[Bug 1285816] Tracking: Python 3 Porting
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378341] Review Request: fedpkg-copr - copr dist-git client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378341



--- Comment #13 from Fedora Update System  ---
fedpkg-copr-0.10-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-ce23de

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378341] Review Request: fedpkg-copr - copr dist-git client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378341



--- Comment #12 from Fedora Update System  ---
fedpkg-copr-0.10-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-b6f89fa8e6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378341] Review Request: fedpkg-copr - copr dist-git client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378341



--- Comment #16 from Fedora Update System  ---
fedpkg-copr-0.10-1.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d894856c70

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378341] Review Request: fedpkg-copr - copr dist-git client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378341



--- Comment #14 from Fedora Update System  ---
fedpkg-copr-0.10-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-7cce295511

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378341] Review Request: fedpkg-copr - copr dist-git client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378341

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378341] Review Request: fedpkg-copr - copr dist-git client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378341



--- Comment #15 from Fedora Update System  ---
fedpkg-copr-0.10-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-72238a350a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1289717] Review Request: viennacl - Linear algebra and solver library using CUDA, OpenCL, and OpenMP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289717

Sandro Mani  changed:

   What|Removed |Added

 CC||manisan...@gmail.com



--- Comment #23 from Sandro Mani  ---
@Ilya Please build for rawhide also

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1289717] Review Request: viennacl - Linear algebra and solver library using CUDA, OpenCL, and OpenMP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289717



--- Comment #22 from Fedora Update System  ---
viennacl-1.7.1-3.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-8fe5ca8d90

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1289717] Review Request: viennacl - Linear algebra and solver library using CUDA, OpenCL, and OpenMP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289717

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1289717] Review Request: viennacl - Linear algebra and solver library using CUDA, OpenCL, and OpenMP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289717



--- Comment #21 from Fedora Update System  ---
viennacl-1.7.1-3.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b231f2b6d4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256104] Review Request: holtz - Abstract strategy board game collection

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256104



--- Comment #3 from Jeremy Newton  ---
(In reply to Ben Boeckel from comment #2)
> Yep, still interested; just need to get old reviews moved over to fp.o (been
> doing it on-demand). I'll hopefully get to moving this over later this week.

If you would like, I can review swap with you. I'm working on getting another
review request ready that I should have ready this week.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1352837] Review Request: vassal - Game engine for building and playing online adaptations of board games and card games

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352837

Jeremy Newton  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|alexjn...@gmail.com



--- Comment #10 from Jeremy Newton  ---
Please add the required bundled provides. Let me know if you need assistance. I
would think that everything printed by "find lib/ -print" would be bundled.

Let me know if you're still alright with review swapping #1379765

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374899] Review Request: quassel-irssi - An irssi plugin to connect to quassel core

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374899

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-05 16:42:29



--- Comment #14 from Fedora Update System  ---
quassel-irssi-0-2.20161120gitcbd9bd7.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397140] Review Request: mrrescue - Arcade-style fire fighting game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397140

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-11-23 09:05:51 |2016-12-05 16:42:19



--- Comment #11 from Fedora Update System  ---
mrrescue-1.02e-2.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394262] Review Request: perl-Net-CardDAVTalk - CardDAV client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394262

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-05 16:41:26



--- Comment #8 from Fedora Update System  ---
perl-Net-CardDAVTalk-0.03-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394252] Review Request: perl-Net-CalDAVTalk - CalDAV client with JSON data interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394252

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-05 16:41:23



--- Comment #8 from Fedora Update System  ---
perl-Net-CalDAVTalk-0.09-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393129] Review Request: python-aexpect - a python library to control interactive applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393129

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-05 16:41:15



--- Comment #12 from Fedora Update System  ---
python-aexpect-1.2.0-3.20161110gitaca459d.fc25, python-avocado-43.0-6.fc25 has
been pushed to the Fedora 25 stable repository. If problems still persist,
please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-05 16:41:18



--- Comment #15 from Fedora Update System  ---
python-aexpect-1.2.0-3.20161110gitaca459d.fc25, python-avocado-43.0-6.fc25 has
been pushed to the Fedora 25 stable repository. If problems still persist,
please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1155793] Review Request: hyperrogue - An SDL roguelike in a non-euclidean world

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155793

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-05 16:40:52



--- Comment #34 from Fedora Update System  ---
hyperrogue-8.3-2.j.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382655] Review Request: pology - CLI tools for PO files processing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382655

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-05 16:40:49



--- Comment #13 from Fedora Update System  ---
pology-0.12-3.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395354] Review Request: python-colorlog - A colored formatter for the python logging module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395354

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-05 16:40:57



--- Comment #9 from Fedora Update System  ---
python-colorlog-2.9.0-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395244] Review Request: python3-zope-event - Zope Event Publication

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395244

Randy Barlow  changed:

   What|Removed |Added

 CC||aurel...@bompard.org
  Flags||needinfo?(aurelien@bompard.
   ||org)



--- Comment #1 from Randy Barlow  ---
I only found one thing we would need to fix to approve this:

* fedora-review thinks that COPYRIGHT.txt should be marked as %license, even
though there's also a LICENSE.txt. I personally think it might be OK as is, but
it also makes some sense for copyright and license to be together so I think it
would be a good thing to fix.


This is an optional suggestion, so you can ignore if you want:

* The package defines srcname and pkgname. It would be cleaner to just use one
or the other of those two instead of both.


Question for my own knowledge:

* What are the python3_other macros? Are those standard macros, or are they
used when doing manual builds? I've not seen them before.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376867] Review Request: python3-pycurl - Python interface to libcurl for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376867



--- Comment #13 from Fedora Update System  ---
python3-pycurl-7.43.0-5.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395244] Review Request: python3-zope-event - Zope Event Publication

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395244

Randy Barlow  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ra...@electronsweatshop.com
   Assignee|nob...@fedoraproject.org|ra...@electronsweatshop.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1309909] Review Request: python3-tornado - Scalable, non-blocking web server and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309909
Bug 1309909 depends on bug 1376867, which changed state.

Bug 1376867 Summary: Review Request: python3-pycurl - Python interface to 
libcurl for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1376867

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376867] Review Request: python3-pycurl - Python interface to libcurl for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376867

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-05 14:19:25



--- Comment #12 from Fedora Update System  ---
python3-pycurl-7.43.0-5.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401414] Review Request: python-neovim - Python client to Neovim

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401414



--- Comment #8 from Filip Szymański  ---
Your spec file rewritten for python2 and python3:
https://fszymanski.fedorapeople.org/python-neovim.spec

A lot of Vim plugins only supports Python 2. It would be good to have both
packages. I will gladly co-maintain this package with you if you need some
help.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1256104] Review Request: holtz - Abstract strategy board game collection

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256104



--- Comment #2 from Ben Boeckel  ---
Yep, still interested; just need to get old reviews moved over to fp.o (been
doing it on-demand). I'll hopefully get to moving this over later this week.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382152] Review Request: orpie - scientific calculator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382152



--- Comment #23 from Randy Barlow  ---
Hello Jared! I see that your e-mail addresses now match, so I have sponsored
you as a packager. Congratulations! You can now proceed with the next step
here:

https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner

If you have any questions about being a Fedora maintainer now or in the future,
feel free to reach out to me by e-mail or IRC (I'm bowlofeggs on Freenode). I'm
happy to help out! Also, you can add me as a co-maintainer on this package if
you like. Go forth and do good with your packager powers!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401276] Review Request: python-grako - Python grammer compiler

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401276

Iryna Shcherbina  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ishch...@redhat.com,
   ||mhron...@redhat.com
   Assignee|nob...@fedoraproject.org|ishch...@redhat.com
  Flags||fedora-review?



--- Comment #1 from Iryna Shcherbina  ---
Hi Eric,

I have looked through the spec file and it looks good in general, but please
consider the following:

* [!]: Package consistently uses macros
Please use %{modname} macro in `Name` and `URL`.

* [!]: Spec file is legible and written in American English.
Spelling error in summary: please change grammer -> grammar

* [!]: %check is present and all tests pass.
The package contains tests, so please run them in %check.

* There is no need to define `summary` macro, it is generated automatically
after you set the first Summary tag. So you should just set the Summary of the
main package and use %{summary} macro in your python3- subpackage. 

* It is better to avoid using wildcards in the %files section to have an idea
what is installed with the package. Doing the following change will make it
more safe:

%{python3_sitelib}/*

change to

%{python3_sitelib}/%{modname}
%{python3_sitelib}/%{modname}-%{version}-py?.?.egg-info

* Regarding shebang change: why would you use a `for` loop to change shebang in
just one file (bootstrap.py)?

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[!]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging 

[Bug 1401596] New: Review Request: python-yamllint - A linter for YAML files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401596

Bug ID: 1401596
   Summary: Review Request: python-yamllint - A linter for YAML
files
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: f...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://fale.fedorapeople.org/rpms/python-yamllint.spec
SRPM URL:
https://fale.fedorapeople.org/rpms/python-yamllint-1.6.0-2.fc25.src.rpm
Description: A linter for YAML files
Fedora Account System Username: fale

WARNING: This is a re-review request for a package rename of yamllint

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934



--- Comment #7 from Fedora Update System  ---
python3-jinja2-2.8-2.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d4293aff8d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934



--- Comment #6 from Fedora Update System  ---
python3-jinja2-2.8-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-45c1c0b276

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1103545] Review Request: granite - GTK extensions for the elementary desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1103545

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 CC||zbys...@in.waw.pl
 Resolution|--- |DUPLICATE
Last Closed||2016-12-05 10:44:55



--- Comment #14 from Zbigniew Jędrzejewski-Szmek  ---


*** This bug has been marked as a duplicate of bug 1398433 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks||1068850 (Pantheon)
 CC||whe...@redhat.com



--- Comment #7 from Zbigniew Jędrzejewski-Szmek  ---
*** Bug 1103545 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1068850
[Bug 1068850] Fedora 22 Change "Pantheon Desktop" tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401414] Review Request: python-neovim - Python client to Neovim

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401414

Andreas Schneider  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |python-neovim - Python 3|python-neovim - Python
   |client to Neovim|client to Neovim



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401414] Review Request: python-neovim - Python 3 client to Neovim

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401414



--- Comment #7 from Andreas Schneider  ---
Spec URL: https://xor.cryptomilk.org/rpm/python-neovim/python-neovim.spec
SRPM URL:
https://xor.cryptomilk.org/rpm/python-neovim/python-neovim-0.1.12-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401582] New: Review Request: python-flufl-testing - Small collection of test tool plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401582

Bug ID: 1401582
   Summary: Review Request: python-flufl-testing - Small
collection of test tool plugins
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: aurel...@bompard.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://abompard.fedorapeople.org/reviews/flufl.testing/python-flufl-testing.spec
SRPM URL:
https://abompard.fedorapeople.org/reviews/flufl.testing/python-flufl-testing-0.4-1.fc25.src.rpm
Description:
This package contains a small collection of test helpers that Barry Warsaw
uses in almost all his packages. Specifically, plugins for the following
test tools are provided:
- nose2
- flake8
Python 3.4 is the minimum supported version.

Fedora Account System Username: abompard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401414] Review Request: python3-neovim - Python 3 client to Neovim

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401414



--- Comment #6 from Andreas Schneider  ---
As the neovim requirements are already pretty high and I only plan to support
rawhide and f25. I would prefer to only build for python3.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401035] Review Request: php-pear-math-biginteger - Pure-PHP arbitrary precision integer arithmetic library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401035

Remi Collet  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-12-05 10:37:15



--- Comment #5 from Remi Collet  ---
@shawn: thanks for the review

Package:php-pear-math-biginteger-1.0.3-1.fc26
Status: complete


No plan to build in other branches.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401414] Review Request: python-neovim - Python 3 client to Neovim

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401414

Andreas Schneider  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |python3-neovim - Python 3   |python-neovim - Python 3
   |client to Neovim|client to Neovim



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396232] Review Request: libkeepalive - Enable TCP keepalive in dynamic binaries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396232



--- Comment #5 from Phil Sutter  ---
Hi Igor,

(In reply to Igor Gnatenko from comment #4)
> * BuildRequires:  git -> BuildRequires:   git-core
> git itself requires a lot of perl which you don't really need to apply
> patches.
> * %autosetup -S git
> probably you just want %autosetup -p1 to not pull git into BuildRequires

Ah yes, that is much easier. When playing around with autosetup options, I got
errors during patch applying, but probably that was just due to missing '-p1'
option.

> * %doc LICENSE README
> LICENSE should be %license, READNE should be %doc
> * Also put comment where you sent patches to upstream (or why you didn't
> sent)...

OK, DONE! Here are updated URLs for review:

Spec URL: https://psutter.fedorapeople.org/libkeepalive.spec
SRPM URL: https://psutter.fedorapeople.org/libkeepalive-0.3-3.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376783] Review Request: python-can - Controller Area Network (CAN) support for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376783



--- Comment #8 from Zbigniew Jędrzejewski-Szmek  ---
(In reply to Peter Robinson from comment #7)
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #6)
> > License and Provides is fixed, but not Requires and the shebang lines.
> 
> The shebang I was going to report upstream and patch once upstream has
> agreement on it.

There are two scripts there:
can_logger.py with "#!/usr/bin/python2 -s",
and
j1939_logger.py without any header.
I don't think there's anything to discuss here, the second one has to be the
same as the first.

> > python2-can (rpmlib, GLIBC filtered):
> > /usr/bin/python3
> 
> No idea where that comes from  unless one of the binaries are some how
> specifying it but they don't look to be. Will need to investigate later when
> I get time.

When building on my F24 machine, the header is as quoted above. When building
in rawhide mock, the header is "#!/usr/bin/python3 -s", and that generates the
bad dependency in python2-can. Either something changed in rawhide, or it's
missing some dependency that influences the header.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401414] Review Request: python3-neovim - Python 3 client to Neovim

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401414



--- Comment #5 from Filip Szymański  ---
See also:
http://copr-dist-git.fedorainfracloud.org/cgit/dperson/neovim/python-neovim.git/tree/python-neovim.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401414] Review Request: python3-neovim - Python 3 client to Neovim

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401414



--- Comment #4 from Filip Szymański  ---
One spec file for python2 and python3.

Example:
https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394789] Review Request: neovim - Vim-fork focused on extensibility and agility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394789



--- Comment #16 from Andreas Schneider  ---
I could swear I've already fixed that before ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392457] Re-review Request for renaming python package to python2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392457



--- Comment #4 from Charalampos Stratakis  ---
Also another addition. Implemented PEP 394[0], at this commit [1] so now all
the binaries are provided in the form of bin2 and bin2.7 


[0] https://www.python.org/dev/peps/pep-0394/

[1]
https://github.com/fedora-python/python2-spec/commit/9e09f0f095c684e3bddfb6ec1ab4e437fc9f467a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394789] Review Request: neovim - Vim-fork focused on extensibility and agility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394789



--- Comment #17 from Andreas Schneider  ---
Spec URL: https://xor.cryptomilk.org/rpm/neovim/neovim.spec
SRPM URL: https://xor.cryptomilk.org/rpm/neovim/neovim-0.1.7-4.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401035] Review Request: php-pear-math-biginteger - Pure-PHP arbitrary precision integer arithmetic library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401035



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/php-pear-math-biginteger

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389971] Review Request: elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389971



--- Comment #44 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/elemental

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401414] Review Request: python3-neovim - Python 3 client to Neovim

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401414



--- Comment #3 from Andreas Schneider  ---
Can you have two specs in one project? We could name the projects python-neovim
and then just drop two spec files to build for python2 and python3.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378526] Review Request: gap-pkg-hapcryst - Integral cohomology computations of Bieberbach groups

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378526



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/gap-pkg-hapcryst

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python3-jinja2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394789] Review Request: neovim - Vim-fork focused on extensibility and agility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394789



--- Comment #15 from Filip Szymański  ---
I noticed something else. The license file is in %doc and should be in
%license:

%files
%license LICENSE
%doc ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394789] Review Request: neovim - Vim-fork focused on extensibility and agility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394789



--- Comment #14 from Filip Szymański  ---
Looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401013] Review Request: git-octopus - Git commands for continuous delivery

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401013



--- Comment #5 from Andrea Baita  ---
Thanks for the feedback. 

The project use a LGPLv3 license as specified in the project licence file
(https://raw.githubusercontent.com/lesfurets/git-octopus/master/LICENSE) and
the spec file.

I will update the BuildRequires section adding the a2x as you suggested.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394789] Review Request: neovim - Vim-fork focused on extensibility and agility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394789



--- Comment #13 from Andreas Schneider  ---
Spec URL: https://xor.cryptomilk.org/rpm/neovim/neovim.spec
SRPM URL: https://xor.cryptomilk.org/rpm/neovim/neovim-0.1.7-3.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394789] Review Request: neovim - Vim-fork focused on extensibility and agility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394789



--- Comment #12 from Andreas Schneider  ---
Well luajit would be better, but luajit assumes lua 5.1:

LuaJIT 2.0.4 -- Copyright (C) 2005-2015 Mike Pall. http://luajit.org/
JIT: ON CMOV SSE2 SSE3 SSE4.1 fold cse dce fwd dse narrow loop abc sink fuse
> require("lpeg")
stdin:1: module 'lpeg' not found:
no field package.preload['lpeg']
no file './lpeg.lua'
no file '/usr/share/luajit-2.0.4/lpeg.lua'
no file '/usr/local/share/lua/5.1/lpeg.lua'
no file '/usr/local/share/lua/5.1/lpeg/init.lua'
no file '/usr/share/lua/5.1/lpeg.lua'
no file '/usr/share/lua/5.1/lpeg/init.lua'
no file './lpeg.so'
no file '/usr/local/lib/lua/5.1/lpeg.so'
no file '/usr/lib64/lua/5.1/lpeg.so'
no file '/usr/local/lib/lua/5.1/loadall.so'


So we need to use lua which is lua 5.3 and luajit seems to be incompatible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #33 from gil cattaneo  ---
(In reply to gil cattaneo from comment #31)
> Issues:
> 
> [!]: License field in the package spec file matches the actual license.
>  Note: Checking patched sources after %prep for licenses. Licenses
>  found: "Apache (v2.0)", "Apache (v2.0) BSD (3 clause)", "Unknown or
>  generated", "*No copyright* Apache (v2.0)". 74 files have unknown
>  license. Detailed output of licensecheck in
>  /home/gil/1324020-cassandra/licensecheck.txt
> 
>  Apache (v2.0) BSD (3 clause)
> cassandra-3.9/src/java/org/apache/cassandra/utils/vint/VIntCoding.java

License fiels should be: ASL 2.0 and BSD
Please,  add also a comment, e.g.:

# Apache (v2.0) BSD (3 clause):
# ./src/java/org/apache/cassandra/utils/vint/VIntCoding.java 
License:ASL 2.0 and BSD

> [!]: Requires correct, justified where necessary.
>  Please, remove useless: %{?scl:Requires: %scl_require rh-maven33}

The "Requires" list is automatically generated. This entry, for me is useless.
What is rh-maven33? why maven? why is necessary? Please, to explain in a
comment in the spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #32 from Tomas Repik  ---
Spec URL: https://trepik.fedorapeople.org/cassandra/v6/cassandra.spec
SRPM URL:
https://trepik.fedorapeople.org/cassandra/v6/cassandra-3.9-1.fc24.src.rpm
Koji Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16756287

- changed the installation of stress sub-package as suggested
- added NOTICE.txt to the javadoc sub-package
- asked upstream to include license headers [1]
- asked upstream to update some cassandra dependencies to fedora versions,
providing them patches updating their sources, all of these are mentioned in
the spec file
- added systemd macros

[1] https://issues.apache.org/jira/browse/CASSANDRA-12993

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394789] Review Request: neovim - Vim-fork focused on extensibility and agility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394789



--- Comment #11 from Filip Szymański  ---
This is simpler

%build
mkdir -p obj

than

%build
if test ! -e "obj"; then
  mkdir obj
fi

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401013] Review Request: git-octopus - Git commands for continuous delivery

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401013



--- Comment #4 from Igor Gnatenko  ---
Unfortunately, I can't sponsor you, but spec looks clean and good apart from
license, license is LGPLv2+, not LGPLv2.

Also you should add BuildRequires: %{_bindir}/a2x since it's used to build
documentation (man pages).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401013] Review Request: git-octopus - Git commands for continuous delivery

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401013

Igor Gnatenko  changed:

   What|Removed |Added

Summary|Review Request: git-octopus |Review Request: git-octopus
   |- git commands for  |- Git commands for
   |continuous delivery |continuous delivery



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401013] Review Request: git-octopus - git commands for continuous delivery

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401013



--- Comment #3 from Andrea Baita  ---
Thanks, I added the git hub url only for reference, the direct link is in the
first message: 
Spec URL:
https://raw.githubusercontent.com/danoliv/git-octopus-spec/master/git-octopus.spec

For the shasum command I think the developers used it because it is available
on mac os. We can add a patch if it is necessary.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394789] Review Request: neovim - Vim-fork focused on extensibility and agility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394789



--- Comment #10 from Filip Szymański  ---
One more thing:

BuildRequires: gcc

C and C++ packaging guidelines:
https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B#BuildRequires_and_Requires

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400489] Review Request: perl-BSON - BSON serialization and deserialization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400489



--- Comment #5 from Fedora Update System  ---
perl-BSON-1.2.2-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-1fac7083e1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401451] Package Review: pcb2gcodeGUI - A GUI for pcb2gcode

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401451



--- Comment #1 from Lubomir Rintel  ---
The package doesn't include a desktop entry & appdata. Upstream doesn't ship
any and the target audience of the tool likely expects to run the tool from the
command line anyway.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401451] New: Package Review: pcb2gcodeGUI - A GUI for pcb2gcode

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401451

Bug ID: 1401451
   Summary: Package Review: pcb2gcodeGUI - A GUI for pcb2gcode
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: lkund...@v3.sk
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Depends On: 1401450



SPEC: http://v3.sk/~lkundrak/SPECS/pcb2gcodeGUI.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/pcb2gcodeGUI-1.3.2-1.fc25.src.rpm

Description:

A GUI for pcb2gcode, a software for the isolation, routing and drilling
of PCBs.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1401450
[Bug 1401450] Review Request: pcb2gcode - Command-line software for the
isolation, routing and drilling of PCBs
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401450] Review Request: pcb2gcode - Command-line software for the isolation, routing and drilling of PCBs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401450

Lubomir Rintel  changed:

   What|Removed |Added

 Blocks||1401451




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1401451
[Bug 1401451] Package Review: pcb2gcodeGUI - A GUI for pcb2gcode
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401450] New: Review Request: pcb2gcode - Command-line software for the isolation, routing and drilling of PCBs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401450

Bug ID: 1401450
   Summary: Review Request: pcb2gcode - Command-line software for
the isolation, routing and drilling of PCBs
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: lkund...@v3.sk
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



SPEC: http://v3.sk/~lkundrak/SPECS/pcb2gcode.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/pcb2gcode-1.3.2-1.fc25.src.rpm

Description:

pcb2gcode is a command-line software for the isolation, routing and drilling of
PCBs. It takes Gerber files as input and it outputs gcode files, suitable for
the milling of PCBs. It also includes an Autoleveller, useful for the automatic
dynamic calibration of the milling depth.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400489] Review Request: perl-BSON - BSON serialization and deserialization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400489



--- Comment #4 from Petr Pisar  ---
Tests fails on i686:

t/legacy/08-string.t . ok
# No tests run!
#   Failed test 'No tests run for subtest "datetime"'
#   at t/legacy/10-bson.t line 434.
During encode_one, Don't know how to encode Math::BigFloat '151109408000' as an
Int64. at /builddir/build/BUILD/BSON-v1.2.2/blib/lib/BSON.pm line 299.
 at t/legacy/10-bson.t line 385.
# Looks like your test exited with 255 just after 11.
t/legacy/10-bson.t ... 
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 7/17 subtests 

.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401414] Review Request: python3-neovim - Python 3 client to Neovim

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401414

Filip Szymański  changed:

   What|Removed |Added

 CC||fszyman...@onet.pl



--- Comment #2 from Filip Szymański  ---
In this case we should have python2 and python3 package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 967782] Review Request: jailkit - A set of utilities to limit Chroot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=967782



--- Comment #9 from Joe Cooper  ---
Is this still being worked on by anyone? None of the links for the most recent
packages under review work, and I'd like to poke at it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394789] Review Request: neovim - Vim-fork focused on extensibility and agility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394789



--- Comment #9 from Filip Szymański  ---
Use gettext instead of gettext-devel.

Quick question. Do we need luajit-devel (we are using the Lua interpreter)?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394789] Review Request: neovim - Vim-fork focused on extensibility and agility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394789



--- Comment #8 from Andreas Schneider  ---
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16754838

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401329] Review Request: beesu - Graphical wrapper for su

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401329

leigh scott  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|leigh123li...@googlemail.co
   ||m
 Whiteboard||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1401329#
  Flags||fedora-review+



--- Comment #2 from leigh scott  ---
Everything looks good and rpmlint is clear of errors.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394789] Review Request: neovim - Vim-fork focused on extensibility and agility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394789



--- Comment #7 from Andreas Schneider  ---
Spec URL: https://xor.cryptomilk.org/rpm/neovim/neovim.spec
SRPM URL: https://xor.cryptomilk.org/rpm/neovim/neovim-0.1.7-2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401414] Review Request: python3-neovim - Python 3 client to Neovim

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401414



--- Comment #1 from Igor Gnatenko  ---
It should be python-neovim. For example, see python-aiohttp spec.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401414] Review Request: python3-neovim - Python 3 client to Neovim

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401414

Andreas Schneider  changed:

   What|Removed |Added

 CC||a...@redhat.com
 Depends On||1394789
   Assignee|nob...@fedoraproject.org|jhro...@redhat.com




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394789
[Bug 1394789] Review Request: neovim - Vim-fork focused on extensibility
and agility
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394789] Review Request: neovim - Vim-fork focused on extensibility and agility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394789

Andreas Schneider  changed:

   What|Removed |Added

 Blocks||1401414




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1401414
[Bug 1401414] Review Request: python3-neovim - Python 3 client to Neovim
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401414] Review Request: python3-neovim - Python 3 client to Neovim

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401414

Andreas Schneider  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401414] New: Review Request: python3-neovim - Python 3 client to Neovim

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401414

Bug ID: 1401414
   Summary: Review Request: python3-neovim - Python 3 client to
Neovim
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: a...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://xor.cryptomilk.org/rpm/python3-neovim/python3-neovim.spec
SRPM URL:
https://xor.cryptomilk.org/rpm/python3-neovim/python3-neovim-0.1.12-1.fc25.src.rpm
Description: Library for scripting Nvim processes through its msgpack-rpc API.
Fedora Account System Username: asn

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org