[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404043



--- Comment #12 from Jarod Wilson  ---
Found the part of the packaging guidelines that says why we need BR: systemd
for Fedora and verified it myself. Holding off on an srpm update until
tomorrow, pending some additional upstream feedback (and sleep).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404043



--- Comment #10 from Jarod Wilson  ---
(In reply to Honggang LI from comment #8)
> (In reply to Jarod Wilson from comment #5)
> > 
> > > honli: systemd and dracut also needed.
> > 
> > These already get pulled in.
> 
> No, you missed systemd. As a result, your new srpm can't be rebuilt.

I built it in mock just fine at one point while working on updates, and just
got a shell in the buildroot, systemd is definitely there.

> > 
> > > honli: You also delete a few necessary "Requires:" tags.
> > > honli:  Please see review-comment.txt for details.
> > 
> > From that doc:
> > 
> > > honli: Please add "Requires:" entries against rsyslog, systemd, kmod,
> > > honli: logrotate, initscripts, and dracut.
> > 
> > None of these need to be listed explicitly, so far as I know. These are all
> > things that are expected to be on the system, thus no need to call them out
> > specifically. Several of them are already requirements of the kernel.
> > 
> 
> I would suggest to list explicitly. Otherwise fedora-review tool will
> complaint.
> [ ]: Package must own all directories that it creates.
>  Note: Directories without known owners: /usr/lib/udev, /usr/share/doc
>  /rdma-core-12, /etc/rsyslog.d, /etc/sysconfig/network-scripts,
>  /etc/udev/rules.d, /etc/udev, /etc/logrotate.d, /usr/lib/udev/rules.d
> [ ]: Package does not own files or directories owned by other packages.
>  Note: Dirs in package are owned also by: /usr/include/infiniband
>  (ibacm-devel, libibverbs-devel),
>  /usr/lib/dracut/modules.d/05rdma(rdma), /usr/include/rdma(kernel-
>  headers), /etc/rdma(rdma, ibacm)

Frankly, fedora-review is wrong, if it's insisting on Requires: for things that
are absolutely going to be there, unless you somehow boot your system without a
kernel installed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404043



--- Comment #11 from Jarod Wilson  ---
(In reply to Honggang LI from comment #9)
> (In reply to Jarod Wilson from comment #6)
> 
> > http://people.redhat.com/~jwilson/pkgreview/rdma-core/rdma-core.spec
> > http://people.redhat.com/~jwilson/pkgreview/rdma-core/rdma-core-12-1.fc26.
> > src.rpm
> 
> Failed to rebuild this srpm.
> 
> Processing files: rdma-core-debuginfo-12-1.fc26.x86_64
> Provides: rdma-core-debuginfo = 12-1.fc26 rdma-core-debuginfo(x86-64) =
> 12-1.fc26
> Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests)
> <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
> Checking for unpackaged file(s): /usr/lib/rpm/check-files
> /builddir/build/BUILDROOT/rdma-core-12-1.fc26.x86_64
> error: Installed (but unpackaged) file(s) found:
>/usr/lib64/rsocket/librspreload.so.1
>/usr/lib64/rsocket/librspreload.so.1.0.0
> 
> This patch works for me.
> srpm-unpacked]$ cat spec-patch1.patch 
> --- rdma-core.spec.old2016-12-21 16:59:20.0 -0500
> +++ rdma-core.spec2016-12-21 21:41:01.750808435 -0500
> @@ -21,6 +21,7 @@ BuildRequires: pkgconfig
>  BuildRequires: pkgconfig(libnl-3.0)
>  BuildRequires: pkgconfig(libnl-route-3.0)
>  BuildRequires: valgrind-devel
> +BuildRequires: systemd

Hm. Maybe this fails on current Fedora mock chroots. I'm building in
something... Older. And it works fine there. I'll take a closer look in the
morning.

>  Requires: dracut
>  # Red Hat/Fedora previously shipped redhat/ as a stand-alone
> @@ -392,6 +393,7 @@ rm -rf %{buildroot}/%{_initrddir}/
>  %{_libdir}/librdmacm*.so.*
>  %dir %{_libdir}/rsocket
>  %{_libdir}/rsocket/*.so
> +%{_libdir}/rsocket/*.so.*
>  %doc %{_docdir}/%{name}-%{version}/librdmacm.md
>  %{_mandir}/man7/rsocket.*

Crap, that was supposed to be %{_libdir}/rsocket/*.so* there. I'll fix that in
the morning as well.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406946] Review Request: python-httpbin - HTTP Request & Response Service, written in Python + Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406946



--- Comment #11 from Adam Williamson  ---
Thanks, try:

Spec URL:
https://www.happyassassin.net/reviews/python-httpbin/python-httpbin.spec
SRPM URL:
https://www.happyassassin.net/reviews/python-httpbin/python-httpbin-0.5.0-3.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765



--- Comment #18 from Fedora Update System  ---
dolphin-emu-5.0-7.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1408105] Review Request: nodejs-p-is-promise - Check if something is a promise

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1408105

Parag Nemade  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1408105] New: Review Request: nodejs-p-is-promise - Check if something is a promise

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1408105

Bug ID: 1408105
   Summary: Review Request: nodejs-p-is-promise - Check if
something is a promise
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: pnem...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://pnemade.fedorapeople.org//nodejs-p-is-promise.spec
SRPM URL:
http://pnemade.fedorapeople.org//nodejs-p-is-promise-1.1.0-1.fc25.src.rpm

Description:
Check if something is a promise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1405708] Review Request: lugaru - Ninja rabbit fighting game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1405708

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-22 00:24:32



--- Comment #10 from Fedora Update System  ---
lugaru-1.1-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-22 00:23:09



--- Comment #17 from Fedora Update System  ---
dolphin-emu-5.0-7.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379798] Review Request: pcsxr - A plugin based PlayStation (PSX) emulator with high compatibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379798



--- Comment #33 from Fedora Update System  ---
pcsxr-1.9.94-6.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392090] Review Request: pychromecast - Python library to communicate with the Google Chromecast

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392090

Peter Robinson  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-12-21 23:23:09



--- Comment #10 from Peter Robinson  ---
Pushed. Global and summary fixed.

Thanks for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423

Jeremy Newton  changed:

   What|Removed |Added

Summary|Review Request: vbam - High |Review Request:
   |compatibility Gameboy   |visualboyadvance-m - High
   |Advance Emulator combining  |compatibility Gameboy
   |VBA builds  |Advance Emulator combining
   ||VBA builds



--- Comment #2 from Jeremy Newton  ---
Update to beta 3, also renaming of the package to the new upstream name:

Spec URL: https://dl.dropboxusercontent.com/u/42480493/visualboyadvance-m.spec
SRPM URL:
https://dl.dropboxusercontent.com/u/42480493/visualboyadvance-m-2.0.0-0.3.Beta3.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373821] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373821

Dan Radez  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2016-12-21 23:12:18



--- Comment #14 from Dan Radez  ---


*** This bug has been marked as a duplicate of bug 1407000 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1327635] Review Request: openstack-congress - OpenStack Congress Service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327635

Dan Radez  changed:

   What|Removed |Added

 Depends On||1407000




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1407000
[Bug 1407000] Review Request: python-pulp - LP modeler written in python
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1327635] Review Request: openstack-congress - OpenStack Congress Service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327635
Bug 1327635 depends on bug 1373821, which changed state.

Bug 1373821 Summary: Review Request: python-pulp - LP modeler written in python
https://bugzilla.redhat.com/show_bug.cgi?id=1373821

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |DUPLICATE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1407000] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1407000

Dan Radez  changed:

   What|Removed |Added

 Blocks||1327635, 1373513
   ||(RDO-OCATA)
 CC||l...@lukos.org



--- Comment #2 from Dan Radez  ---
*** Bug 1373821 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1327635
[Bug 1327635] Review Request: openstack-congress - OpenStack Congress
Service
https://bugzilla.redhat.com/show_bug.cgi?id=1373513
[Bug 1373513] Tracker: Blockers and Review requests for new RDO Ocata
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1407000] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1407000



--- Comment #1 from Dan Radez  ---
Koji Build here: https://koji.fedoraproject.org/koji/taskinfo?taskID=17021666

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1407000] New: Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1407000

Bug ID: 1407000
   Summary: Review Request: python-pulp - LP modeler written in
python
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: dra...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



SPRM: https://radez.fedorapeople.org/python-PuLP-1.6.1-2.fc25.src.rpm
Spec: https://radez.fedorapeople.org/python-pulp.spec
Description: LP modeler written in python. More info
https://pypi.python.org/pypi/PuLP
Fedora Account System Username: radez

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373821] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373821

Dan Radez  changed:

   What|Removed |Added

  Flags|needinfo?(dra...@redhat.com |
   |)   |



--- Comment #13 from Dan Radez  ---
Good to know, thx will do that now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404043



--- Comment #9 from Honggang LI  ---
(In reply to Jarod Wilson from comment #6)

> http://people.redhat.com/~jwilson/pkgreview/rdma-core/rdma-core.spec
> http://people.redhat.com/~jwilson/pkgreview/rdma-core/rdma-core-12-1.fc26.
> src.rpm

Failed to rebuild this srpm.

Processing files: rdma-core-debuginfo-12-1.fc26.x86_64
Provides: rdma-core-debuginfo = 12-1.fc26 rdma-core-debuginfo(x86-64) =
12-1.fc26
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <=
4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Checking for unpackaged file(s): /usr/lib/rpm/check-files
/builddir/build/BUILDROOT/rdma-core-12-1.fc26.x86_64
error: Installed (but unpackaged) file(s) found:
   /usr/lib64/rsocket/librspreload.so.1
   /usr/lib64/rsocket/librspreload.so.1.0.0

This patch works for me.
srpm-unpacked]$ cat spec-patch1.patch 
--- rdma-core.spec.old2016-12-21 16:59:20.0 -0500
+++ rdma-core.spec2016-12-21 21:41:01.750808435 -0500
@@ -21,6 +21,7 @@ BuildRequires: pkgconfig
 BuildRequires: pkgconfig(libnl-3.0)
 BuildRequires: pkgconfig(libnl-route-3.0)
 BuildRequires: valgrind-devel
+BuildRequires: systemd

 Requires: dracut
 # Red Hat/Fedora previously shipped redhat/ as a stand-alone
@@ -392,6 +393,7 @@ rm -rf %{buildroot}/%{_initrddir}/
 %{_libdir}/librdmacm*.so.*
 %dir %{_libdir}/rsocket
 %{_libdir}/rsocket/*.so
+%{_libdir}/rsocket/*.so.*
 %doc %{_docdir}/%{name}-%{version}/librdmacm.md
 %{_mandir}/man7/rsocket.*

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406946] Review Request: python-httpbin - HTTP Request & Response Service, written in Python + Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406946



--- Comment #10 from Neal Gompa  ---
> [!]: Package must own all directories that it creates.
> Note: Directories without known owners: /usr/lib/python2.7/site-
> packages/httpbin, /usr/lib/python3.5/site-packages/httpbin,
> /usr/lib/python3.5/site-packages/httpbin-0.5.0-py3.5.egg-info,
> /usr/lib/python2.7/site-packages/httpbin-0.5.0-py2.7.egg-info

This is the only remaining issue I'm concerned about. Please fix. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406946] Review Request: python-httpbin - HTTP Request & Response Service, written in Python + Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406946



--- Comment #9 from Neal Gompa  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "ISC", "Unknown or generated". 29 files have unknown license.
 Detailed output of licensecheck in /home/makerpm/1406946-python-
 httpbin/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib/python2.7/site-
 packages/httpbin-0.5.0-py2.7.egg-info, /usr/lib/python3.5/site-
 packages/httpbin-0.5.0-py3.5.egg-info, /usr/lib/python3.5/site-
 packages/httpbin, /usr/lib/python2.7/site-packages/httpbin
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python2.7/site-
 packages/httpbin, /usr/lib/python3.5/site-packages/httpbin,
 /usr/lib/python3.5/site-packages/httpbin-0.5.0-py3.5.egg-info,
 /usr/lib/python2.7/site-packages/httpbin-0.5.0-py2.7.egg-info
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-httpbin , python3-httpbin
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: 

[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404043



--- Comment #8 from Honggang LI  ---
(In reply to Jarod Wilson from comment #5)
> 
> > honli: systemd and dracut also needed.
> 
> These already get pulled in.

No, you missed systemd. As a result, your new srpm can't be rebuilt.

> 
> > honli: You also delete a few necessary "Requires:" tags.
> > honli:  Please see review-comment.txt for details.
> 
> From that doc:
> 
> > honli: Please add "Requires:" entries against rsyslog, systemd, kmod,
> > honli: logrotate, initscripts, and dracut.
> 
> None of these need to be listed explicitly, so far as I know. These are all
> things that are expected to be on the system, thus no need to call them out
> specifically. Several of them are already requirements of the kernel.
> 

I would suggest to list explicitly. Otherwise fedora-review tool will
complaint.
[ ]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/udev, /usr/share/doc
 /rdma-core-12, /etc/rsyslog.d, /etc/sysconfig/network-scripts,
 /etc/udev/rules.d, /etc/udev, /etc/logrotate.d, /usr/lib/udev/rules.d
[ ]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/include/infiniband
 (ibacm-devel, libibverbs-devel),
 /usr/lib/dracut/modules.d/05rdma(rdma), /usr/include/rdma(kernel-
 headers), /etc/rdma(rdma, ibacm)

> > honli: %setup -q ???
> > %build
> 
> Why? I prefer verbose myself, so you can see more easily in logs if
> something goes wrong.

OK.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404043



--- Comment #7 from Honggang LI  ---
(In reply to Jarod Wilson from comment #3)
> 
> > Comment 1:
> > /etc/rc.d/init.d/srpd (delete it as RHEL7 and FC26  use systemd.)
> 
> Confused here, I don't see this in the build. Or did you mean "this is
> getting removed from the old version, but it's fine"?

Yes, it is fine.

> 
> > Comment 2: iwpmd no longer start after syslog.target, as it does not write
> > any log files. iwpmd send log message to /var/log/messages.
> > diff -Nurp iwpmd-1.0.6-2.el7/usr/lib/systemd/system/iwpmd.service

> 
> Is this another "this is a change to take note of" thing? Just using the
> upstream .service file here.

Yes, you are right. It is a change to take note of.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406946] Review Request: python-httpbin - HTTP Request & Response Service, written in Python + Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406946



--- Comment #8 from Adam Williamson  ---
Yep it is, thanks.

Spec URL:
https://www.happyassassin.net/reviews/python-httpbin/python-httpbin.spec
SRPM URL:
https://www.happyassassin.net/reviews/python-httpbin/python-httpbin-0.5.0-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406946] Review Request: python-httpbin - HTTP Request & Response Service, written in Python + Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406946



--- Comment #7 from Neal Gompa  ---
Running it through fedora-review indicates that the Python 3 subpackage has no
runtime dependencies. 

I suspect that's in error?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406962] New: Review Request: python-pathlib2 - Object-oriented filesystem paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406962

Bug ID: 1406962
   Summary: Review Request: python-pathlib2 - Object-oriented
filesystem paths
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: paulo.cesar.pereira.de.andr...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://pcpa.fedorapeople.org/python-pathlib2.spec
SRPM URL: https://pcpa.fedorapeople.org/python-pathlib2-2.1.0-1.fc26.src.rpm
Description: The old pathlib module on bitbucket is in bugfix-only mode. The
goal of
pathlib2 is to provide a backport of standard pathlib module which tracks
the standard library module, so all the newest features of the standard
pathlib can be used also on older Python versions.
Fedora Account System Username: pcpa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406958] New: Review Request: python-ipykernel - IPython Kernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406958

Bug ID: 1406958
   Summary: Review Request: python-ipykernel - IPython Kernel for
Jupyter
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: paulo.cesar.pereira.de.andr...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://pcpa.fedorapeople.org/python-ipykernel.spec
SRPM URL: https://pcpa.fedorapeople.org/python-ipykernel-4.5.1-1.fc26.src.rpm
Description: This package provides the IPython kernel for Jupyter.
Fedora Account System Username: pcpa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406946] Review Request: python-httpbin - HTTP Request & Response Service, written in Python + Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406946



--- Comment #6 from Adam Williamson  ---
"Why are you using the GitHub commit to do this?"

The guidelines used to require this, on the basis that tags are mutable; commit
IDs are not. Specifying a commit ID guarantees we will *always* get the same
tarball, even if upstream does something sneaky like ninja-ing the version tag.

The guidelines now allow the use of tags, by the looks of it, but I still kinda
prefer using the commit ID explicitly, I was persuaded by the old logic here.

"Why the LANG? Could you put a comment explaining why that was necessary?"

Sure, I'll add a comment. setup.py has a fairly common bug where it reads
content in from a file without explicitly specifying the codec, and the file
contains non-ASCII characters; in the Koji build environment, we don't default
to a UTF-8 locale, we get C (I think), so Python 3 uses 'ascii' codec and blows
up. I don't recall why this doesn't affect Python 2, but oh well. It's easier
to just specify a LANG for the commands than patch setup.py to specify a
codec...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406946] Review Request: python-httpbin - HTTP Request & Response Service, written in Python + Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406946



--- Comment #5 from Neal Gompa  ---
Actually, as it turns out, you'd still nee the %autosetup -n, but it would be
%{github_name}-%{version} instead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406946] Review Request: python-httpbin - HTTP Request & Response Service, written in Python + Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406946



--- Comment #4 from Neal Gompa  ---
A couple of questions here:

> Source0:
> https://github.com/%{github_owner}/%{github_name}/archive/%{github_commit}/%{github_name}-%{version}.tar.gz

Why are you using the GitHub commit to do this? It forces you to declare a
folder name in %autosetup later on. GitHub does provide
https://github.com/Runscope/httpbin/archive/v0.5.0.tar.gz as an option.

You can use it as a Source0 like so:
https://github.com/%{github_owner}/%{github_name}/archive/v%{version}/%{github_name}-%{version}.tar.gz

> LANG=en_US.UTF-8 %py3_build

Why the LANG? Could you put a comment explaining why that was necessary?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406946] Review Request: python-httpbin - HTTP Request & Response Service, written in Python + Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406946

Adam Williamson  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |python-httplib - HTTP   |python-httpbin - HTTP
   |Request & Response Service, |Request & Response Service,
   |written in Python + Flask   |written in Python + Flask



--- Comment #3 from Adam Williamson  ---
In fact, the entire ticket is named wrong. I am renowned for my attention to
detail!

Spec URL:
https://www.happyassassin.net/reviews/python-httpbin/python-httpbin.spec
SRPM URL:
https://www.happyassassin.net/reviews/python-httpbin/python-httpbin-0.5.0-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406946] Review Request: python-httplib - HTTP Request & Response Service, written in Python + Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406946



--- Comment #2 from Neal Gompa  ---
The Spec and SRPM do not appear to exist. Please upload them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406946] Review Request: python-httplib - HTTP Request & Response Service, written in Python + Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406946



--- Comment #1 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406946] Review Request: python-httplib - HTTP Request & Response Service, written in Python + Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406946

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406946] New: Review Request: python-httplib - HTTP Request & Response Service, written in Python + Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406946

Bug ID: 1406946
   Summary: Review Request: python-httplib - HTTP Request &
Response Service, written in Python + Flask
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: awill...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://www.happyassassin.net/reviews/python-httplib/python-httplib.spec
SRPM URL:
https://www.happyassassin.net/reviews/python-httplib/python-httpbin-0.5.0-1.fc26.src.rpm
Description: Testing an HTTP Library can become difficult sometimes. RequestBin
is fantastic for testing POST requests, but doesn't let you control the
response. This exists to cover all kinds of HTTP scenarios. Additional
endpoints are being considered. All endpoint responses are JSON-encoded.

Fedora Account System Username: adamwill

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373821] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373821

Alan Pevec  changed:

   What|Removed |Added

  Flags||needinfo?(dra...@redhat.com
   ||)



--- Comment #12 from Alan Pevec  ---
Dan, you will need to open a new Fedora review bz, b/c Fedora tooling requires
review bz to be reported by the packager. Please close this one as a duplicate
of your new review bz.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404043



--- Comment #6 from Jarod Wilson  ---
(In reply to Jarod Wilson from comment #3)
...
> > Issue 4: broken soft link (librdmacm-12-1.fc26.x86_64.rpm)?
> > /usr/lib64/rsocket
> > [honli@dhcp47-85 rsocket]$ ll
> > total 0
> > lrwxrwxrwx. 1 honli honli 15 Dec 20 00:37 librspreload.so.1 ->
> > librspreload.so
> > lrwxrwxrwx. 1 honli honli 15 Dec 20 00:37 librspreload.so.1.0.0 ->
> > librspreload.so
> 
> This looks like an upstream problem, just doing a build in a freshly
> unpacked tree sans-rpm has similar results. I'll address it there.

There's a minor issue with the way it's built upstream that does leave it with
a dangling symlink under build/, but when packaged, this was simply a case of
the .so being in rdma-core-devel. I've moved it into librdmacm instead to
resolve this.

Updated package for review w/same version at the moment:

http://people.redhat.com/~jwilson/pkgreview/rdma-core/rdma-core.spec
http://people.redhat.com/~jwilson/pkgreview/rdma-core/rdma-core-12-1.fc26.src.rpm

This should hopefully address just about everything, and I'll ship the patches
that resulted from this work upstream shortly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357677] Review Request: python-rfc3987 - Parsing and validation of URIs (RFC 3986) and IRIs ( RFC 3987)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357677

Eduardo Mayorga  changed:

   What|Removed |Added

  Flags|needinfo?(e...@mayorgalinux.co |
   |m)  |



--- Comment #3 from Eduardo Mayorga  ---
Spec URL: https://fedorapeople.org/~mayorga/python-rfc3987.spec
SRPM URL: https://fedorapeople.org/~mayorga/python-rfc3987-1.3.6-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404043



--- Comment #5 from Jarod Wilson  ---
(In reply to Jarod Wilson from comment #4)
> Spec file comments from honli:
> 
> Url: https://github.com/linux-rdma/rdma-core
> honli:
> https://fedoraproject.org/wiki/Packaging:
> SourceURL#When_Upstream_uses_Prohibited_Code
> honli: Please add comment for the "Source:" tag.
> Source: rdma-core-%{version}.tgz

I could, but this situation is temporary, there will be an upstream release and
a full URL shortly. This was noted in comment #1, but I could add that same
text to the spec until the release is out if need be.

> BuildRequires: binutils
> BuildRequires: cmake >= 2.8.11
> BuildRequires: gcc
> BuildRequires: libudev-devel
> BuildRequires: pkgconfig
> BuildRequires: pkgconfig(libnl-3.0)
> BuildRequires: pkgconfig(libnl-route-3.0)
> BuildRequires: valgrind-devel
> 
> honli: libnl3-devel is required for iwpmd libibverbs

That's what you get from pkgconfig(libnl-3.0).

> honli: systemd and dracut also needed.

These already get pulled in.

> honli: You also delete a few necessary "Requires:" tags.
> honli:  Please see review-comment.txt for details.

From that doc:

> honli: Please add "Requires:" entries against rsyslog, systemd, kmod,
> honli: logrotate, initscripts, and dracut.

None of these need to be listed explicitly, so far as I know. These are all
things that are expected to be on the system, thus no need to call them out
specifically. Several of them are already requirements of the kernel.


> %description
> RDMA core userspace infrastructure and documentation.
> honli: I know this is an upstream issue. This is %description
> honli: section is too simple, in other words, it is meaningless.
> honli: If you do not have good %description section, I suggest
> honli: you copy and paste
> https://bugzilla.redhat.com/show_bug.cgi?id=1404043#c0
> honli: At least, user will know what is the package after read that.

That #c0 text applies to the package as a whole though, including things that
are in libibverbs. I'll expand on the text there a bit though.

Proposed update:

%description
RDMA core userspace infrastructure and documentation, including initscripts,
kernel driver-specific modprobe override configs, IPoIB network scripts,
dracut rules, and the rdma-ndd utility.

> %package -n libibverbs
> Summary: A library and drivers for direct userspace use of RDMA
> (InfiniBand/iWARP) hardware
> Requires(post): /sbin/ldconfig
> Requires(postun): /sbin/ldconfig
> Requires: rdma-core
> honli: Even over 99% files are stext files, rdma-core contains
> /usr/sbin/rdma-ndd,
> honli: which is an ELF file, so rdma-core is not a noarch rpm. Please
> replace all
> honli: "Requires: rdma-core" with "Requires: %{name}%{?_isa} =
> %{version}-%{release}"

Will do.

> %description -n srp_daemon
> In conjunction with the kernel ib_srp driver, srptools allows you to
> honli: should replace srptools with srp_daemon in above line?
> discover and use SCSI devices via the SCSI RDMA Protocol over InfiniBand.

Done.

> %prep
> %setup
> honli: %setup -q ???
> %build

Why? I prefer verbose myself, so you can see more easily in logs if something
goes wrong.

> %postun -n ibacm
> %systemd_postun_with_restart ibacm.service
> 
> honli: Why you only run
> systemd_post/systemd_preun/systemd_postun_with_restart
> honli: against ibacm.service? How about iwpmd.service and srp_daemon.service?

Looks like an oversight, will correct this.

> %post -n libibcm -p /sbin/ldconfig
> %postun -n libibcm -p /sbin/ldconfig
> honli: Why not run ldconfig for other libraries, at least librdmacm has .so
> honli: file in private dir.

Another oversight. And on a related note, the ldconfigs for the base package
serve no purpose, since there are no libs in it. This is probably a remnant of
starting from the one-shot spec in the top level of the source dir. Will fix
this up too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401967] Review Request: qcad - Powerful 2D CAD system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401967



--- Comment #15 from Sandro Mani  ---
I think you can also drop

 QMAKE_CFLAGS_RELEASE="%{_qt4_optflags} -I%{_includedir}/quazip" \
 QMAKE_CXXFLAGS_RELEASE="%{_qt4_optflags} -I%{_includedir}/quazip" \

since -I%{_includedir}/quazip shouldn't be needed anymore with the unbundle
patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404043



--- Comment #4 from Jarod Wilson  ---
Spec file comments from honli:

Url: https://github.com/linux-rdma/rdma-core
honli:
https://fedoraproject.org/wiki/Packaging:SourceURL#When_Upstream_uses_Prohibited_Code
honli: Please add comment for the "Source:" tag.
Source: rdma-core-%{version}.tgz

BuildRequires: binutils
BuildRequires: cmake >= 2.8.11
BuildRequires: gcc
BuildRequires: libudev-devel
BuildRequires: pkgconfig
BuildRequires: pkgconfig(libnl-3.0)
BuildRequires: pkgconfig(libnl-route-3.0)
BuildRequires: valgrind-devel

honli: libnl3-devel is required for iwpmd libibverbs
honli: systemd and dracut also needed.

honli: You also delete a few necessary "Requires:" tags.
honli:  Please see review-comment.txt for details.

%description
RDMA core userspace infrastructure and documentation.
honli: I know this is an upstream issue. This is %description
honli: section is too simple, in other words, it is meaningless.
honli: If you do not have good %description section, I suggest
honli: you copy and paste
https://bugzilla.redhat.com/show_bug.cgi?id=1404043#c0
honli: At least, user will know what is the package after read that.

%package -n libibverbs
Summary: A library and drivers for direct userspace use of RDMA
(InfiniBand/iWARP) hardware
Requires(post): /sbin/ldconfig
Requires(postun): /sbin/ldconfig
Requires: rdma-core
honli: Even over 99% files are stext files, rdma-core contains
/usr/sbin/rdma-ndd,
honli: which is an ELF file, so rdma-core is not a noarch rpm. Please replace
all
honli: "Requires: rdma-core" with "Requires: %{name}%{?_isa} =
%{version}-%{release}"

%description -n srp_daemon
In conjunction with the kernel ib_srp driver, srptools allows you to
honli: should replace srptools with srp_daemon in above line?
discover and use SCSI devices via the SCSI RDMA Protocol over InfiniBand.

%prep
%setup
honli: %setup -q ???
%build

%postun -n ibacm
%systemd_postun_with_restart ibacm.service

honli: Why you only run systemd_post/systemd_preun/systemd_postun_with_restart
honli: against ibacm.service? How about iwpmd.service and srp_daemon.service?

%post -n libibcm -p /sbin/ldconfig
%postun -n libibcm -p /sbin/ldconfig
honli: Why not run ldconfig for other libraries, at least librdmacm has .so
honli: file in private dir.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404043



--- Comment #3 from Jarod Wilson  ---
(In reply to Jarod Wilson from comment #2)
> From honli via email, pasting here for all to see:
> 
> Issue 1: see line 11
> honli@dhcp47-85:~/b1404043/1404043-rdma-core/srpm-unpacked/rdma-core-12$ cat
> -n MAINTAINERS 
>  1List of maintainers
>  2
>  3  Generally patches should be submitted to the main development
> mailing list:
>  4
>  5  linux-r...@vger.kernel.org
>  6
>  7  Descriptions of section entries:
>  8  F: Files and directories with wildcard patterns.
>  9 A trailing slash includes all files and subdirectory
> files.
> 10 F:   providers/mlx4/ all files in and below
> providers/mlx4/
> 11 F:   providers/* all files in drivers/net, but not
> below < drivers/net???

Upstream typo. Will send a patch.


> Issue 2: Why remove the manpage?
> [honli@dhcp47-85 srp]$ diff -Nurp
> ./usr/lib/systemd/system/srp_daemon.service
> /home/honli/rhel-scm/srptools/srptools.service 
> --- ./usr/lib/systemd/system/srp_daemon.service   2016-12-19
> 03:48:07.774866479 -0500
> +++ /home/honli/rhel-scm/srptools/srptools.service2016-04-11
> 21:33:29.905060849 -0400
> @@ -1,6 +1,6 @@
>  [Unit]
>  Description=Start or stop the daemon that attaches to SRP devices
> -Documentation=man:srp_daemon file:/etc/rdma/rdma.conf
> file:/etc/srp_daemon.conf
> +Documentation=file:///etc/rdma/rdma.conf file:///etc/srp_daemon.conf
>  DefaultDependencies=false
>  Conflicts=emergency.target emergency.service
>  Requires=rdma.service

Already since resolved upstream, commit
9317fbb01ac2ef33a4570c66b1e651ab71d07b90.


> Issue 3: please use the new name
> 189 %description -n srp_daemon
> 190 In conjunction with the kernel ib_srp driver, srptools allows you to
> <--- s/srptools/srp_daemon/
> 191 discover and use SCSI devices via the SCSI RDMA Protocol over InfiniBand.

Will send a patch upstream.

> Issue 4: broken soft link (librdmacm-12-1.fc26.x86_64.rpm)?
> /usr/lib64/rsocket
> [honli@dhcp47-85 rsocket]$ ll
> total 0
> lrwxrwxrwx. 1 honli honli 15 Dec 20 00:37 librspreload.so.1 ->
> librspreload.so
> lrwxrwxrwx. 1 honli honli 15 Dec 20 00:37 librspreload.so.1.0.0 ->
> librspreload.so

This looks like an upstream problem, just doing a build in a freshly unpacked
tree sans-rpm has similar results. I'll address it there.

> Issue 5: missing BuildRequires

This was better explained elsewhere, it's really just "don't explicitly list
gcc" here, which I'll send a patch upstream for.

> Issue 6: missing "Requires: tags"
> Please see comment-rdma-core.spec.

Will address this separately shortly.

> Question 1:
> /usr/lib/systemd/system/srpd.service --> 
> /usr/lib/systemd/system/srp_daemon.service
> The service had been named as "srpd" since 2009, should we keep the old name?

I'd stick with following upstream.

> Question 2: why libibacmp.so.* removed for new ibacm-12-1.fc26 pkg?
> (libibcm.f26 keeps libibcm.so.1.0.12)
>14 /usr/lib64/ibacm/libibacmp.so|   14
> /usr/lib64/ibacm/libibacmp.so
>15 /usr/lib64/ibacm/libibacmp.so.1  | 
> -
>16 /usr/lib64/ibacm/libibacmp.so.1.0.0  | 
> -

This is an upstream change as well. I believe libibacmp is only intended for
internal use by ibacm.

> Comment 1:
> /etc/rc.d/init.d/srpd (delete it as RHEL7 and FC26  use systemd.)

Confused here, I don't see this in the build. Or did you mean "this is getting
removed from the old version, but it's fine"?

> Comment 2: iwpmd no longer start after syslog.target, as it does not write
> any log files. iwpmd send log message to /var/log/messages.
> diff -Nurp iwpmd-1.0.6-2.el7/usr/lib/systemd/system/iwpmd.service
> iwpmd-12-1.fc26/usr/lib/systemd/system/iwpmd.service
> --- iwpmd-1.0.6-2.el7/usr/lib/systemd/system/iwpmd.service  2016-12-19
> 20:55:43.38756 -0500
> +++ iwpmd-12-1.fc26/usr/lib/systemd/system/iwpmd.service2016-12-19
> 20:56:55.874779421 -0500
> @@ -1,12 +1,12 @@
>  [Unit]
> -Description=Starts the IWPMD daemon
> -Documentation=file:///usr/share/doc/iwpmd/README
> -After=network.target syslog.target  <---
> +Description=iWarp Port Mapper
> +Documentation=man:iwpmd file:/etc/iwpmd.conf
> +After=network.target

Is this another "this is a change to take note of" thing? Just using the
upstream .service file here.

> Comment 3:
> AUTHORS files had been removed, but we have a new file "MAINTAINERS" for
> such info.

Indeed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to 

[Bug 1362490] Review Request: libphutil - A collection of PHP utility classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362490



--- Comment #31 from Tim Flink  ---
From what I've understood, the problem is mostly with 7.0.x and upstream is
planning to support 7.1+, skipping direct support of the 7.0.x range.

As far as what to do about F25, I think that the code which doesn't work in
7.0.x is relatively small and could probably be patched out but Jeroen is
following the issue more closely than I.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401967] Review Request: qcad - Powerful 2D CAD system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401967



--- Comment #14 from Antonio Trande  ---
Thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401967] Review Request: qcad - Powerful 2D CAD system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401967

Sandro Mani  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #13 from Sandro Mani  ---
Approved, but please fix these on import:

qcad.x86_64: E: non-standard-executable-perm
/usr/lib64/qcad/plugins/script/libqcadqtscript_gui.so
qcad.x86_64: E: non-standard-executable-perm
/usr/lib64/qcad/plugins/script/libqcadqtscript_uitools.so.1.0.0 775
qcad.x86_64: E: non-standard-executable-perm
/usr/lib64/qcad/plugins/script/libqcadqtscript_uitools.so
qcad.x86_64: E: non-standard-executable-perm
/usr/lib64/qcad/plugins/script/libqcadqtscript_xmlpatterns.so.1.0.0 775
qcad.x86_64: E: non-standard-executable-perm
/usr/lib64/qcad/plugins/script/libqcadqtscript_svg.so.1.0.0 775
qcad.x86_64: E: non-standard-executable-perm
/usr/lib64/qcad/plugins/script/libqcadqtscript_xml.so.1.0.0 775
qcad.x86_64: E: non-standard-executable-perm
/usr/lib64/qcad/plugins/script/libqcadqtscript_opengl.so.1.0.0 775
qcad.x86_64: E: non-standard-executable-perm
/usr/lib64/qcad/plugins/script/libqcadqtscript_xml.so
qcad.x86_64: E: non-standard-executable-perm
/usr/lib64/qcad/plugins/script/libqcadqtscript_webkit.so.1.0.0 775
qcad.x86_64: E: non-standard-executable-perm
/usr/lib64/qcad/plugins/script/libqcadqtscript_gui.so.1.0.0 775

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406797] Review Request: python-ansicolor - A library to produce ansi color output, colored highlighting and diffing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406797

Filip Szymański  changed:

   What|Removed |Added

 Blocks||1406881




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1406881
[Bug 1406881] Review Request: vint - Lint tool for Vim script Language
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406881] Review Request: vint - Lint tool for Vim script Language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406881

Filip Szymański  changed:

   What|Removed |Added

 Depends On||1406797




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1406797
[Bug 1406797] Review Request: python-ansicolor - A library to produce ansi
color output, colored highlighting and diffing
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406881] New: Review Request: vint - Lint tool for Vim script Language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406881

Bug ID: 1406881
   Summary: Review Request: vint - Lint tool for Vim script
Language
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fszyman...@onet.pl
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://fszymanski.fedorapeople.org/vint/vint.spec
SRPM URL: https://fszymanski.fedorapeople.org/vint/vint-0.3.9-1.fc25.src.rpm

Description: Lint tool for Vim script Language
Fedora Account System Username: fszymanski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401967] Review Request: qcad - Powerful 2D CAD system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401967



--- Comment #12 from Antonio Trande  ---
Spec URL: https://sagitter.fedorapeople.org/qcad/qcad.spec
SRPM URL: https://sagitter.fedorapeople.org/qcad/qcad-3.16.2.0-2.fc25.src.rpm

- Main directory moved under libdir directory
- Filtering of private libraries

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400278] Review Request: python-os-faults - OpenStack fault-injection library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400278

Mike Burns  changed:

   What|Removed |Added

   Keywords||Triaged
 Target Release|--- |11.0 (Ocata)
   Assignee|l...@redhat.com  |slina...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400278] Review Request: python-os-faults - OpenStack fault-injection library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400278

Mike Burns  changed:

   What|Removed |Added

   Keywords||Triaged
 Target Release|--- |11.0 (Ocata)
   Assignee|l...@redhat.com  |slina...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406728] ansible-pacemaker - Ansible library for tripleo composable upgrade

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406728



--- Comment #3 from mathieu bultel  ---
According to the comment from Emilien on the review on rdoinfo, I renamed the
package name and project to: ansible-pacemaker:
Repo:
https://github.com/redhat-openstack/ansible-pacemaker
Spec
https://github.com/matbu/tripleo-ansible-modules-spec/blob/master/ansible-pacemaker.spec
rdoinfo review:
https://review.rdoproject.org/r/4138

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406728] ansible-pacemaker - Ansible library for tripleo composable upgrade

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406728

mathieu bultel  changed:

   What|Removed |Added

Summary|tripleo-ansible-modules -   |ansible-pacemaker - Ansible
   |Ansible library for tripleo |library for tripleo
   |composable upgrade  |composable upgrade



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1362490] Review Request: libphutil - A collection of PHP utility classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362490



--- Comment #30 from Jared Smith  ---
This requires a version of PHP earlier than 7.x, but Rawhide now has 7.1.0. 
How would you like to proceed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400271] Review Request: python-sphinxcontrib-pecanwsme - Extension to Sphinx for documenting APIs built with Pecan and WSME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400271

Mike Burns  changed:

   What|Removed |Added

   Keywords||Triaged
 Target Release|--- |11.0 (Ocata)
   Assignee|l...@redhat.com  |slina...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934



--- Comment #11 from Fedora Update System  ---
python3-jinja2-2.8-2.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1358741] Review Request: python-msrestazure - AutoRest swagger generator Python client runtime ( Azure-specific module)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358741



--- Comment #3 from Mohamed El Morabity  ---
Update to 0.4.6:

Spec URL:
https://melmorabity.fedorapeople.org/packages/python-msrestazure/python-msrestazure.spec
SRPM URL:
https://melmorabity.fedorapeople.org/packages/python-msrestazure/python-msrestazure-0.4.6-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396296] New OSP11 package from CBS -- python-tenacity

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396296

Mike Burns  changed:

   What|Removed |Added

   Keywords||Triaged
 Target Release|--- |11.0 (Ocata)
 CC||mbu...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393947] Review Request: cinch - A tool for provisioning Jenkins components for CI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393947



--- Comment #14 from Fedora Update System  ---
cinch-0.2.1-3.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-f997abaa82

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1405856] Review Request: python-canonicaljson - Canonical JSON

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1405856

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
python-canonicaljson-1.0.0-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-f4174b0049

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1405857] Review Request: python-signedjson - Sign JSON with Ed25519 signatures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1405857

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
python-signedjson-1.0.0-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-32eeb894f4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393947] Review Request: cinch - A tool for provisioning Jenkins components for CI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393947

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
cinch-0.2.1-3.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d05af72e68

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404043



--- Comment #2 from Jarod Wilson  ---
From honli via email, pasting here for all to see:

Issue 1: see line 11
honli@dhcp47-85:~/b1404043/1404043-rdma-core/srpm-unpacked/rdma-core-12$ cat -n
MAINTAINERS 
 1List of maintainers
 2
 3  Generally patches should be submitted to the main development mailing
list:
 4
 5  linux-r...@vger.kernel.org
 6
 7  Descriptions of section entries:
 8  F: Files and directories with wildcard patterns.
 9 A trailing slash includes all files and subdirectory files.
10 F:   providers/mlx4/ all files in and below providers/mlx4/
11 F:   providers/* all files in drivers/net, but not below
< drivers/net???
12 F:   */net/* all files in "any top level
directory"/net
13 One pattern per line.  Multiple F: lines acceptable.



Issue 2: Why remove the manpage?
[honli@dhcp47-85 srp]$ diff -Nurp ./usr/lib/systemd/system/srp_daemon.service
/home/honli/rhel-scm/srptools/srptools.service 
--- ./usr/lib/systemd/system/srp_daemon.service2016-12-19
03:48:07.774866479 -0500
+++ /home/honli/rhel-scm/srptools/srptools.service2016-04-11
21:33:29.905060849 -0400
@@ -1,6 +1,6 @@
 [Unit]
 Description=Start or stop the daemon that attaches to SRP devices
-Documentation=man:srp_daemon file:/etc/rdma/rdma.conf
file:/etc/srp_daemon.conf
+Documentation=file:///etc/rdma/rdma.conf file:///etc/srp_daemon.conf
 DefaultDependencies=false
 Conflicts=emergency.target emergency.service
 Requires=rdma.service
[honli@dhcp47-85 srp]$ 

Issue 3: please use the new name
189 %description -n srp_daemon
190 In conjunction with the kernel ib_srp driver, srptools allows you to <---
s/srptools/srp_daemon/
191 discover and use SCSI devices via the SCSI RDMA Protocol over InfiniBand.


Issue 4: broken soft link (librdmacm-12-1.fc26.x86_64.rpm)?
/usr/lib64/rsocket
[honli@dhcp47-85 rsocket]$ ll
total 0
lrwxrwxrwx. 1 honli honli 15 Dec 20 00:37 librspreload.so.1 -> librspreload.so
lrwxrwxrwx. 1 honli honli 15 Dec 20 00:37 librspreload.so.1.0.0 ->
librspreload.so



Issue 5: missing BuildRequires
dracut missing  libipathverbs,libmlx4
libnl3-devel, missing iwpmd libibverbs
systemd missing iwpmd, ibacm, srptools
systemd-units missing
valgrind-devel yes

ibacm-devel
libibumad-devel
libibverbs-devel

chrpath missing
autoconf missing
automake, missing
libtool missing
glibc-static  missing  libibumad


Issue 6: missing "Requires: tags"
Please see comment-rdma-core.spec.

Question 1:
/usr/lib/systemd/system/srpd.service --> 
/usr/lib/systemd/system/srp_daemon.service
The service had been named as "srpd" since 2009, should we keep the old name?

Question 2: why libibacmp.so.* removed for new ibacm-12-1.fc26 pkg?
(libibcm.f26 keeps libibcm.so.1.0.12)
   14 /usr/lib64/ibacm/libibacmp.so|   14
/usr/lib64/ibacm/libibacmp.so
   15 /usr/lib64/ibacm/libibacmp.so.1  | 
-
   16 /usr/lib64/ibacm/libibacmp.so.1.0.0  | 
-




Comment 1:
/etc/rc.d/init.d/srpd (delete it as RHEL7 and FC26  use systemd.)

Comment 2: iwpmd no longer start after syslog.target, as it does not write any
log files. iwpmd send log message to /var/log/messages.
diff -Nurp iwpmd-1.0.6-2.el7/usr/lib/systemd/system/iwpmd.service
iwpmd-12-1.fc26/usr/lib/systemd/system/iwpmd.service
--- iwpmd-1.0.6-2.el7/usr/lib/systemd/system/iwpmd.service  2016-12-19
20:55:43.38756 -0500
+++ iwpmd-12-1.fc26/usr/lib/systemd/system/iwpmd.service2016-12-19
20:56:55.874779421 -0500
@@ -1,12 +1,12 @@
 [Unit]
-Description=Starts the IWPMD daemon
-Documentation=file:///usr/share/doc/iwpmd/README
-After=network.target syslog.target  <---
+Description=iWarp Port Mapper
+Documentation=man:iwpmd file:/etc/iwpmd.conf
+After=network.target

Comment 3:
AUTHORS files had been removed, but we have a new file "MAINTAINERS" for such
info.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406728] tripleo-ansible-modules - Ansible library for tripleo composable upgrade

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406728



--- Comment #2 from mathieu bultel  ---
Spec:
https://github.com/matbu/tripleo-ansible-modules-spec/blob/master/tripleo-ansible-modules.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406807] Review Request: perl-RDF-Query - SPARQL 1.1 Query and Update implementation for RDF:: Trine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406807

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406807] Review Request: perl-RDF-Query - SPARQL 1.1 Query and Update implementation for RDF:: Trine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406807

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1406831




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1406831
[Bug 1406831] Review Request: perl-Module-Install-DOAPChangeSets - Write
your distribution change log in RDF
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406831] Review Request: perl-Module-Install-DOAPChangeSets - Write your distribution change log in RDF

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406831

Petr Pisar  changed:

   What|Removed |Added

 Depends On||1406807




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1406807
[Bug 1406807] Review Request: perl-RDF-Query - SPARQL 1.1 Query and Update
implementation for RDF::Trine
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406831] New: Review Request: perl-Module-Install-DOAPChangeSets - Write your distribution change log in RDF

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406831

Bug ID: 1406831
   Summary: Review Request: perl-Module-Install-DOAPChangeSets -
Write your distribution change log in RDF
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ppisar.fedorapeople.org/perl-Module-Install-DOAPChangeSets/perl-Module-Install-DOAPChangeSets.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-Module-Install-DOAPChangeSets/perl-Module-Install-DOAPChangeSets-0.206-1.fc26.src.rpm
Description:
This package allows you to write your Changes file in Turtle or RDF/XML and
autogenerate a human-readable text file.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376934] Review Request: python3-jinja2 - General purpose template engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376934

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-21 09:48:14



--- Comment #10 from Fedora Update System  ---
python3-jinja2-2.8-2.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406807] New: Review Request: perl-RDF-Query - SPARQL 1.1 Query and Update implementation for RDF:: Trine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406807

Bug ID: 1406807
   Summary: Review Request: perl-RDF-Query - SPARQL 1.1 Query and
Update implementation for RDF::Trine
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://ppisar.fedorapeople.org/perl-RDF-Query/perl-RDF-Query.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-RDF-Query/perl-RDF-Query-2.917-1.fc26.src.rpm
Description:
RDF::Query allows SPARQL and RDQL queries to be run against an RDF model,
returning rows of matching results.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406728] tripleo-ansible-modules - Ansible library for tripleo composable upgrade

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406728



--- Comment #1 from mathieu bultel  ---
rdoinfo review:
https://review.rdoproject.org/r/4138

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406797] New: Review Request: python-ansicolor - A library to produce ansi color output, colored highlighting and diffing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406797

Bug ID: 1406797
   Summary: Review Request: python-ansicolor - A library to
produce ansi color output, colored highlighting and
diffing
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fszyman...@onet.pl
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://fszymanski.fedorapeople.org/python-ansicolor/python-ansicolor.spec
SRPM URL:
https://fszymanski.fedorapeople.org/python-ansicolor/python-ansicolor-0.2.4-1.fc25.src.rpm

Scratch: https://koji.fedoraproject.org/koji/taskinfo?taskID=17015736

Description:
ansicolor is a library that makes it easy to use ansi color markup in command
line programs.

Fedora Account System Username: fszymanski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786

Christos Triantafyllidis  changed:

   What|Removed |Added

  Alias||configsnap



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786



--- Comment #1 from Christos Triantafyllidis 
 ---
Fedora 25 scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=17015371

Fedora 24 scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=17015375

EPEL7 scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=17015377

EPEL6 scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=17015384


It is not possible to do a scratch build for rawhide currently as it fails on
dependencies that are not related to that package:
Error: nothing provides libpython3.6m.so.1.0()(64bit) needed by
gdb-headless-7.12-31.fc26.aarch64

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1176273



--- Comment #23 from MartinKG  ---
asgp runs now, new rpm packages:

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/asgp.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/asgp-1.0.18-2.fc25.src.rpm

%changelog
* Tue Dec 13 2016 Martin Gansser  - 1.0.18-2
- Add BR bear-devel
- Add BR cmake option -DBEAR_ROOT_DIRECTORY=%%{_includedir}/bear
- Remove bear Sources
- Add LINK_DIRECTORIES(/usr/lib64/bear/) to CMakeLists.txt
- Delete subdirs bear in CMakeLists.txt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398949] Review Request: bear - Game engine and editors dedicated to creating great 2D games

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398949

MartinKG  changed:

   What|Removed |Added

 Blocks||1406787




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1406787
[Bug 1406787] unbundle bear from plee-the-bear
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387873] Review Request: python2-pyx - Python graphics package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387873



--- Comment #16 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python2-pyx

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392090] Review Request: pychromecast - Python library to communicate with the Google Chromecast

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392090



--- Comment #9 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/pychromecast

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406786] New: Review Request: configsnap - Record and compare system state

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406786

Bug ID: 1406786
   Summary: Review Request: configsnap - Record and compare system
state
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: christos.triantafylli...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://ctria.fedorapeople.org/packaging/configsnap/configsnap.spec
SRPM URL:
https://ctria.fedorapeople.org/packaging/configsnap/configsnap-0.11-1.fc25.src.rpm
Description: Record and compare system state
Fedora Account System Username: ctria

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386774] Review Request: kf5-libktorrent - Library providing torrent downloading code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386774

Rex Dieter  changed:

   What|Removed |Added

  Flags||needinfo?(randy@electronswe
   ||atshop.com)



--- Comment #5 from Rex Dieter  ---
ping, it's been over a week (sorry for my previous delay in responding myself).

was hoping to get this resolved before the end of the year

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387669] Review Request: kio-gdrive - KDE Dolphin Google Drive access

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387669

Rex Dieter  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu
  Flags||fedora-review?



--- Comment #10 from Rex Dieter  ---
I can review this today

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391444] Review Request: boost159 - The free peer-reviewed portable C++ source libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391444



--- Comment #9 from Javier Peña  ---
I have managed to build the package using a plain epel-7-x86_64 buildroot, but
it still fails with the mock configuration used by DLRN. The packages are
co-installable with boost 1.53.0 from the base repo, no issues found.

I found an issue when trying to run bjam159, got the following error message:

# bjam159
Unable to load Boost.Build: could not find "boost-build.jam"
---
Attempted search from /tmp/repo up to the root
at /usr/share/boost-build
and in these directories from BOOST_BUILD_PATH and BOOST_ROOT:
/usr/share/boost-build.
Please consult the documentation at 'http://www.boost.org'.

File boost-build.jam is placed at /usr/share/boost159-build/, so we may need to
patch the default search path for bjam to match it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406728] New: tripleo-ansible-modules - Ansible library for tripleo composable upgrade

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406728

Bug ID: 1406728
   Summary: tripleo-ansible-modules - Ansible library for tripleo
composable upgrade
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: mbul...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Need to add tripleo-ansible-modules package for tripleo composable upgrade with
Ansible:
github repo:
https://github.com/redhat-openstack/tripleo-ansible-modules
Spec:
WIP

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1360482] Review Request: nextcloud - a private, secure way to share and access files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360482



--- Comment #19 from Didier  ---
Any chance of this moving forward in the near future ?

I've been running NC 10.0.1 for the past 2 months without issues (cfr.
comment#17), and recently, both NC versions 10.0.2 and 11.0.0 have been
released.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401337] Review Request: python-zeroconf - Pure Python Multicast DNS Service Discovery Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401337



--- Comment #10 from Peter Robinson  ---
(In reply to Miro Hrončok from comment #9)
> It's there. Sorry about this once more. Peter, please let me know if I can
> do a review for you or something as an apology.

Miro: thanks for the quick fixes/updates it's much appreciated!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368911] Review Request: python-mpd2 - It is a Python library which provides a client interface for MPD

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368911

Ankur Sinha (FranciscoD)  changed:

   What|Removed |Added

 Blocks||1404618




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1404618
[Bug 1404618] mpdris2: Switch to Python 3
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406428] Review Request: perl-Term-Table - Format a header and rows into a table

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406428

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Term-Table-0.004-1.fc2
   ||6
 Resolution|--- |RAWHIDE
Last Closed||2016-12-21 03:51:08



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository. I updated the packages to 0.004.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401337] Review Request: python-zeroconf - Pure Python Multicast DNS Service Discovery Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401337

Miro Hrončok  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed|2016-12-19 09:45:51 |2016-12-21 03:04:44



--- Comment #9 from Miro Hrončok  ---
It's there. Sorry about this once more. Peter, please let me know if I can do a
review for you or something as an apology.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392090] Review Request: pychromecast - Python library to communicate with the Google Chromecast

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392090
Bug 1392090 depends on bug 1401337, which changed state.

Bug 1401337 Summary: Review Request: python-zeroconf - Pure Python Multicast 
DNS Service Discovery Library
https://bugzilla.redhat.com/show_bug.cgi?id=1401337

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #22 from Yunying Sun  ---
Hi Dan, referring to your review comments to tpm2-tss(1369708), to fix most of
the common issues existing in this package, I've updated the spec & srpm:

%changelog
* Wed Dec 21 2016 Sun Yunying  - 1.1.0-2
- Remove pkg_version to avoid dupliate use of version
- Remove redundant BuildRequires for autoconf/automake/pkgconfig
- Add comments for BuildRequires of sapi/tcti-device/tcti-socket
- Use ExclusiveArch instead of ExcludeArch
- Requires tpm2-tss version updated to 1.0-2
- Updated release version and changelog

Updated SPEC: https://github.com/yunyings/share/raw/master/tpm2-tools.spec
Updated SRPM:
https://github.com/yunyings/share/raw/master/tpm2-tools-1.1.0-2.el7.src.rpm

Succeeded Koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=17010843
Succeeded COPR build:
https://copr.fedorainfracloud.org/coprs/yunyings/tpm2-tools/build/491741/

Please help to do a formal review. I will udpate timely if any issues left.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org