[Bug 1412732] Review Request: appcenter - Software Center for the Pantheon desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1412732 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-01-13 22:52:39 --- Comment #7 from Fedora Update System --- appcenter-0.1.3-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1406517] Review Request: container-selinux - Summary: SELinux policies for container runtimes
https://bugzilla.redhat.com/show_bug.cgi?id=1406517 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-01-13 22:51:10 --- Comment #11 from Fedora Update System --- container-selinux-2.2-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1408620] Review Request: rdfind - Program that finds duplicate files
https://bugzilla.redhat.com/show_bug.cgi?id=1408620 --- Comment #15 from Fedora Update System --- rdfind-1.3.5-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1409660] Review Request: lxqt-build-tools - Packaging tools for LXQt
https://bugzilla.redhat.com/show_bug.cgi?id=1409660 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-01-13 22:50:49 --- Comment #14 from Fedora Update System --- lxqt-build-tools-0.3.1-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413203] Review Request: wingpanel-indicator-session - Session Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1413203
Neal Gompa changed:
What|Removed |Added
Flags|fedora-review+ |fedora-review?
--- Comment #4 from Neal Gompa ---
Actually, hold up.
There's an issue here. It provides a generic-looking "libsession.so()(64bit)"
which is not good.
Please add a Provides filter rule to exclude libraries in
"%{_libdir}/wingpanel". More details on this is available at:
https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Preventing_files.2Fdirectories_from_being_scanned_for_deps_.28pre-scan_filtering.29
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413216] Review Request: wingpanel-indicator-sound - Sound Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1413216
--- Comment #2 from Neal Gompa ---
So it seems like it provides a generic-sounding "libsound.so()(64bit)", which
is obviously not good.
Please add a Provides filter rule to exclude libraries in
"%{_libdir}/wingpanel". More details on this is available at:
https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Preventing_files.2Fdirectories_from_being_scanned_for_deps_.28pre-scan_filtering.29
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413203] Review Request: wingpanel-indicator-session - Session Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1413203 Neal Gompa changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Neal Gompa --- Looks good. PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413203] Review Request: wingpanel-indicator-session - Session Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1413203
--- Comment #2 from Neal Gompa ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later) (with incorrect FSF address)", "BSD (2
clause)", "Unknown or generated". 87 files have unknown license.
Detailed output of licensecheck in /home/makerpm/1413203-wingpanel-
indicator-session/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/locale/rue, /usr/share/locale/ckb,
/usr/share/locale/rue/LC_MESSAGES, /usr/share/locale/ckb/LC_MESSAGES
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/locale/ckb,
/usr/share/locale/rue/LC_MESSAGES, /usr/share/locale/rue,
/usr/share/locale/ckb/LC_MESSAGES
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
wingpanel-indicator-session-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English lang
[Bug 1409332] Review Request: pkgconf - A package compiler and linker metadata toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=1409332 --- Comment #14 from Fedora Update System --- pkgconf-1.1.1-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-445209ca81 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1409332] Review Request: pkgconf - A package compiler and linker metadata toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=1409332 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1409332] Review Request: pkgconf - A package compiler and linker metadata toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=1409332 --- Comment #13 from Fedora Update System --- pkgconf-1.1.1-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-bda979856d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1407000] Review Request: python-PuLP - LP modeler written in python
https://bugzilla.redhat.com/show_bug.cgi?id=1407000 Alan Pevec changed: What|Removed |Added Summary|Review Request: python-pulp |Review Request: python-PuLP |- LP modeler written in |- LP modeler written in |python |python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1397621] Review Request: nodejs-qtdatastream - Nodejs lib which can read/ write Qt formatted Datastreams
https://bugzilla.redhat.com/show_bug.cgi?id=1397621 --- Comment #8 from Fedora Update System --- nodejs-qtdatastream-0.6.7-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-853bfbf602 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1397621] Review Request: nodejs-qtdatastream - Nodejs lib which can read/ write Qt formatted Datastreams
https://bugzilla.redhat.com/show_bug.cgi?id=1397621 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1397621] Review Request: nodejs-qtdatastream - Nodejs lib which can read/ write Qt formatted Datastreams
https://bugzilla.redhat.com/show_bug.cgi?id=1397621 --- Comment #7 from Fedora Update System --- nodejs-qtdatastream-0.6.7-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-af3a4b864c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413216] Review Request: wingpanel-indicator-sound - Sound Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1413216 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Flags||fedora-review? --- Comment #1 from Neal Gompa --- Taking this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413203] Review Request: wingpanel-indicator-session - Session Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1413203 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Flags||fedora-review? --- Comment #1 from Neal Gompa --- Taking this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413216] New: Review Request: wingpanel-indicator-sound - Sound Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1413216 Bug ID: 1413216 Summary: Review Request: wingpanel-indicator-sound - Sound Indicator for wingpanel Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: decatho...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://raw.githubusercontent.com/decathorpe/fedora-packaging/25404834620aa161406ed248d69d2d017e1f20f0/specs/wingpanel-indicator-sound/wingpanel-indicator-sound.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/decathorpe/staging/fedora-25-x86_64/00499499-wingpanel-indicator-sound/wingpanel-indicator-sound-2.0.3-2.fc25.src.rpm Description: A sound indicator for wingpanel. Fedora Account System Username: decathorpe koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=17272091 COPR build for f25 and rawhide: https://copr.fedorainfracloud.org/coprs/decathorpe/staging/build/499499/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413203] New: Review Request: wingpanel-indicator-session - Session Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1413203 Bug ID: 1413203 Summary: Review Request: wingpanel-indicator-session - Session Indicator for wingpanel Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: decatho...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://raw.githubusercontent.com/decathorpe/fedora-packaging/2e09c246ad1de6ded3c72d38bfecda10b38347a9/specs/wingpanel-indicator-session/wingpanel-indicator-session.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/decathorpe/staging/fedora-25-x86_64/00499496-wingpanel-indicator-session/wingpanel-indicator-session-2.0.1-2.fc25.src.rpm Description: A session Indicator for wingpanel. Fedora Account System Username: decathorpe koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=17271869 COPR build for f25 and rawhide: https://copr.fedorainfracloud.org/coprs/decathorpe/staging/build/499496/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1114146] Review Request: rubygem-ffi-yajl - Ruby FFI wrapper around YAJL 2.x
https://bugzilla.redhat.com/show_bug.cgi?id=1114146 Michel Alexandre Salim changed: What|Removed |Added CC||mic...@michel-slm.name Flags||needinfo? --- Comment #6 from Michel Alexandre Salim --- Vit, are you interested in continuing the review, and Julian, are you still interested in packaging this? I need to experiment with Chef Zero at work and so would like to have the related Chef Zero upgrade unblocked. If there's still interest in getting this done I'll help do a review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 848423] Review Request: erlang-rtplib - Erlang RTP/RTCP codec library
https://bugzilla.redhat.com/show_bug.cgi?id=848423 Peter Lemenkov changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DEFERRED Last Closed||2017-01-13 16:45:19 --- Comment #5 from Peter Lemenkov --- Unfortunately this library depends on patent-encumbered codecs. So I'm not going to proceed further. Maybe few years later... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1409363] Review Request: llvm3.9 - Versioned LLVM 3.9
https://bugzilla.redhat.com/show_bug.cgi?id=1409363 --- Comment #11 from Milan Bouchet-Valat --- No, it doesn't contain clang. Indeed it's a separate package since 3.7 AFAICT, so somebody will have to package it separately. Note that since the port to CMake, versioned install directories are no longer supported, so that will likely require some work. The patches I use for llvm3.9 are being reviewed at https://reviews.llvm.org/D28234 I'll push the contents of llvm3.9 after that upstream review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413133] Review Request: catimg - Print images in a terminal with 256 colors support
https://bugzilla.redhat.com/show_bug.cgi?id=1413133 --- Comment #3 from Filip Szymański --- Spec URL: https://fszymanski.fedorapeople.org/catimg/catimg.spec SRPM URL: https://fszymanski.fedorapeople.org/catimg/catimg-2.2.1-2.fc25.src.rpm Hi Igor, I know it's a simple package, nevertheless thank you for taking the time. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds
https://bugzilla.redhat.com/show_bug.cgi?id=1403423 --- Comment #12 from Jeremy Newton --- (In reply to Neal Gompa from comment #11) > I am, and I will look over it shortly. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds
https://bugzilla.redhat.com/show_bug.cgi?id=1403423 --- Comment #11 from Neal Gompa --- I am, and I will look over it shortly. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413133] Review Request: catimg - Print images in a terminal with 256 colors support
https://bugzilla.redhat.com/show_bug.cgi?id=1413133
Igor Gnatenko changed:
What|Removed |Added
Status|NEW |POST
Assignee|nob...@fedoraproject.org|ignate...@redhat.com
Flags||fedora-review+
--- Comment #2 from Igor Gnatenko ---
* I would recommend to do out-of-tree build
* Would be nice to keep URL clickable
* You can re-use %{url} in Source0 tag
No other issues spotted.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds
https://bugzilla.redhat.com/show_bug.cgi?id=1403423 Jeremy Newton changed: What|Removed |Added Blocks||1364745 (FE-GAMESIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1364745 [Bug 1364745] Games SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400278] Review Request: python-os-faults - OpenStack fault-injection library
https://bugzilla.redhat.com/show_bug.cgi?id=1400278 errata-xmlrpc changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400271] Review Request: python-sphinxcontrib-pecanwsme - Extension to Sphinx for documenting APIs built with Pecan and WSME
https://bugzilla.redhat.com/show_bug.cgi?id=1400271 errata-xmlrpc changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1409363] Review Request: llvm3.9 - Versioned LLVM 3.9
https://bugzilla.redhat.com/show_bug.cgi?id=1409363 Jeremy Newton changed: What|Removed |Added CC||alexjn...@gmail.com --- Comment #10 from Jeremy Newton --- Will there also be a clang3.9? I believe clang was recently separated from llvm, so a clang counterpart maybe in order, although I'm not sure if this is useful. As well, this could also be branched onto F25 to provide better performance and functionality to mesa but would require a clang3.9 counterpart for building IIRC, see bug #1381109 for details. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome
https://bugzilla.redhat.com/show_bug.cgi?id=1343710 --- Comment #17 from Mark Harfouche --- Jeremy, I'm not too knowledgeable about all of Fedora's packaging guidelines, especially pertaining to licensing. In either case, I could probably take this one over until it gets too complicated to package. How would I go about getting sponsorship? Mark -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave
https://bugzilla.redhat.com/show_bug.cgi?id=1412794 --- Comment #12 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-audiocd-kio -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome
https://bugzilla.redhat.com/show_bug.cgi?id=1343710 --- Comment #16 from Jeremy Newton --- Mark, if you can get sponsorship, you're welcome to take this package as it seems to be abandoned. As well, if anyone is interested in reviewing this, I am willing to take this package from Pete. I would personally like this package in Fedora, so I am open to being either the packager or reviewer. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413133] Review Request: catimg - Print images in a terminal with 256 colors support
https://bugzilla.redhat.com/show_bug.cgi?id=1413133 --- Comment #1 from Filip Szymański --- Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=17269759 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413133] New: Review Request: catimg - Print images in a terminal with 256 colors support
https://bugzilla.redhat.com/show_bug.cgi?id=1413133 Bug ID: 1413133 Summary: Review Request: catimg - Print images in a terminal with 256 colors support Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fszyman...@onet.pl QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://fszymanski.fedorapeople.org/catimg/catimg.spec SRPM URL: https://fszymanski.fedorapeople.org/catimg/catimg-2.2.1-1.fc25.src.rpm Description: catimg is a little program written in C with no dependencies that prints images in terminal. It supports JPEG, PNG and GIF formats. Fedora Account System Username: fszymanski -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave
https://bugzilla.redhat.com/show_bug.cgi?id=1412794
Christian Dersch changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #11 from Christian Dersch ---
Looks fine now, approved :)
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
==> Unversioned one is a plugin => fine
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* BSD (3 clause)", "LGPL (v2 or later)", "GPL (v2
or later)", "GPL (v2 or later) (with Qt exception)", "Unknown or
generated". 7 files have unknown license. Detailed output of
licensecheck in /home/review/1412794-kf5-audiocd-kio/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/doc/HTML/en/kioslave5, /usr/share/doc/HTML,
/usr/share/doc/HTML/en, /usr/share/config.kcfg
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/konqsidebartng
(kio-extras), /usr/share/konqsidebartng/virtual_folders(kio-extras)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items
[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave
https://bugzilla.redhat.com/show_bug.cgi?id=1412794 --- Comment #10 from Rex Dieter --- Spec URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-audiocd-kio.spec SRPM URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-audiocd-kio-16.12.1-5.fc25.src.rpm %changelog * Fri Jan 13 2017 Rex Dieter - 16.12.1-5 - BR: alsa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave
https://bugzilla.redhat.com/show_bug.cgi?id=1412794 --- Comment #9 from Rex Dieter --- Spec URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-audiocd-kio.spec SRPM URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-audiocd-kio-16.12.1-4.fc25.src.rpm %changelog * Fri Jan 13 2017 Rex Dieter - 16.12.1-4 - fix typo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400278] Review Request: python-os-faults - OpenStack fault-injection library
https://bugzilla.redhat.com/show_bug.cgi?id=1400278 Scott Lewis changed: What|Removed |Added Target Milestone|--- |Upstream M3 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400271] Review Request: python-sphinxcontrib-pecanwsme - Extension to Sphinx for documenting APIs built with Pecan and WSME
https://bugzilla.redhat.com/show_bug.cgi?id=1400271 Scott Lewis changed: What|Removed |Added Target Milestone|--- |Upstream M3 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave
https://bugzilla.redhat.com/show_bug.cgi?id=1412794 --- Comment #8 from Christian Dersch --- I get the error: No matching package to install: 'cmake(KDELibs4Support)' In spec it should be BuildRequires: cmake(KF5KDELibs4Support) instead -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1396296] New OSP11 package from CBS -- python-tenacity
https://bugzilla.redhat.com/show_bug.cgi?id=1396296 Scott Lewis changed: What|Removed |Added Target Milestone|--- |Upstream M2 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave
https://bugzilla.redhat.com/show_bug.cgi?id=1412794 --- Comment #7 from Rex Dieter --- Spec URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-audiocd-kio.spec SRPM URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-audiocd-kio-16.12.1-3.fc25.src.rpm %changelog * Fri Jan 13 2017 Rex Dieter - 16.12.1-3 - update build deps -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave
https://bugzilla.redhat.com/show_bug.cgi?id=1412794 --- Comment #6 from Rex Dieter --- , yeah, hard to test fully without the deps first (the other 2 dependant reviews) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave
https://bugzilla.redhat.com/show_bug.cgi?id=1412794 --- Comment #5 from Christian Dersch --- You're missing some BuildRequires, see cmake output I attached. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave
https://bugzilla.redhat.com/show_bug.cgi?id=1412794 --- Comment #4 from Christian Dersch --- Created attachment 1240380 --> https://bugzilla.redhat.com/attachment.cgi?id=1240380&action=edit cmake output with missing dependencies -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1412788] Review Request: kf5-libkcddb - CDDB retrieval library
https://bugzilla.redhat.com/show_bug.cgi?id=1412788 --- Comment #4 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-libkcddb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1412773] Review Request: kf5-libkcompactdisc - A KDE compact disc library
https://bugzilla.redhat.com/show_bug.cgi?id=1412773 --- Comment #4 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-libkcompactdisc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413020] Review Request: konqueror - KDE File Manager and Browser
https://bugzilla.redhat.com/show_bug.cgi?id=1413020 Rex Dieter changed: What|Removed |Added Status|NEW |ASSIGNED CC||rdie...@math.unl.edu Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu Flags||fedora-review? --- Comment #1 from Rex Dieter --- Thanks, I can look into this today. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave
https://bugzilla.redhat.com/show_bug.cgi?id=1412794 --- Comment #2 from Christian Dersch --- There is no subpackage libs, so the scriptlets %post libs -p /sbin/ldconfig %postun libs -p /sbin/ldconfig are not valid, please modify them to run on the main package providing the libs. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave
https://bugzilla.redhat.com/show_bug.cgi?id=1412794 --- Comment #3 from Rex Dieter --- Ah, yes, the previous audiocd-kio had a -libs subpkg that I started from, but I decided to simplify it at the last minute. %changelog * Fri Jan 13 2017 Rex Dieter - 16.12.1-2 - remove -libs reference from scriptlets Spec URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-audiocd-kio.spec SRPM URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-audiocd-kio-16.12.1-2.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1412794] Review Request: kf5-audiocd-kio - KF5 Audiocd kio slave
https://bugzilla.redhat.com/show_bug.cgi?id=1412794 Christian Dersch changed: What|Removed |Added Status|NEW |ASSIGNED CC||lupi...@mailbox.org Assignee|nob...@fedoraproject.org|lupi...@mailbox.org Flags||fedora-review? --- Comment #1 from Christian Dersch --- Taken, will review now -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1412788] Review Request: kf5-libkcddb - CDDB retrieval library
https://bugzilla.redhat.com/show_bug.cgi?id=1412788
Christian Dersch changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #3 from Christian Dersch ---
Looks nice, approved :)
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
===> False positive, is a desktop file for kservices5
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
===> unversioned so-file is a plugin => fine
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* BSD (3 clause)", "LGPL", "LGPL (v2 or later)",
"GPL (v2 or later)", "Unknown or generated". 6 files have unknown
license. Detailed output of licensecheck in
/home/review/1412788-kf5-libkcddb/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib64/cmake,
/usr/lib64/qt5/mkspecs, /usr/share/config.kcfg,
/usr/share/doc/HTML/en/kcontrol, /usr/include/KF5,
/usr/share/doc/HTML, /usr/lib64/qt5, /usr/share/doc/HTML/en,
/usr/lib64/qt5/mkspecs/modules
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large d
[Bug 1407000] Review Request: python-pulp - LP modeler written in python
https://bugzilla.redhat.com/show_bug.cgi?id=1407000 --- Comment #15 from Dan Radez --- I've updated these files according to Haikel's recommendation: https://radez.fedorapeople.org/python-PuLP.spec https://radez.fedorapeople.org/python-PuLP-1.6.1-2.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1407000] Review Request: python-pulp - LP modeler written in python
https://bugzilla.redhat.com/show_bug.cgi?id=1407000 Haïkel Guémar changed: What|Removed |Added Flags|needinfo?(hgue...@redhat.co | |m) | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1411984] Neofetch - a CLI system information tool written in Bash
https://bugzilla.redhat.com/show_bug.cgi?id=1411984
herdians...@openmailbox.org changed:
What|Removed |Added
CC||herdians...@openmailbox.org
--- Comment #3 from herdians...@openmailbox.org ---
Hello, I am one of the contributors of neofetch, and the maintainer for the
third-party package for neofetch in copr.
My only concern will be in
>%install
Since neofetch does have a Makefile, won't it be better to use
%make_install
instead of copying the files manually?
Also, for
> %{_datadir}/%{name}/ascii/distro/*
> %{_datadir}/%{name}/config
We can simplify it to
%{_datadir}/%{name}/*
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413038] Review Request: python3-simpleline - A Python3 library for creating text UI
https://bugzilla.redhat.com/show_bug.cgi?id=1413038
--- Comment #1 from Jiri Konecny ---
I'm attaching output from fedora-review tool:
I want to react on two issues there:
1) Sources used to build the package match the upstream source, as provided
in the spec URL.
- This is because I changed summary in spec file which is in repo already but
it's not tagged as new version.
2) Uses parallel make %{?_smp_mflags} macro.
- No reason for this. Makefile will only start python3 setup.py and do a bunch
of shell commands.
Jirka
===
This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Sources used to build the package match the upstream source, as provided
in the spec URL.
Note: Upstream MD5sum check error, diff is in /tmp/simpleline-build
/review-python3-simpleline/diff.txt
See: http://fedoraproject.org/wiki/Packaging/SourceURL
= MUST items =
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later)", "Unknown or generated". 115 files have
unknown license. Detailed output of licensecheck in /tmp/simpleline-
build/review-python3-simpleline/licensecheck.txt
[ ]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/locale/wba/LC_MESSAGES,
/usr/share/locale/kw@kkcor, /usr/share/locale/kw_GB,
/usr/lib/python3.6, /usr/share/locale/kw_GB/LC_MESSAGES,
/usr/lib/python3.6/site-packages,
/usr/share/locale/kw@kkcor/LC_MESSAGES,
/usr/share/locale/kw@uccor/LC_MESSAGES, /usr/share/locale/kw@uccor,
/usr/share/locale/wba
[ ]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/locale/kw@uccor/LC_MESSAGES,
/usr/share/locale/wba/LC_MESSAGES, /usr/share/locale/kw@uccor,
/usr/share/locale/kw@kkcor, /usr/share/locale/kw_GB/LC_MESSAGES,
/usr/share/locale/kw_GB, /usr/share/locale/wba, /usr/lib/python3.6
/site-packages, /usr/lib/python3.6,
/usr/share/locale/kw@kkcor/LC_MESSAGES
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: The spec file handles locales properly.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[Bug 1413038] New: Review Request: python3-simpleline - A Python3 library for creating text UI
https://bugzilla.redhat.com/show_bug.cgi?id=1413038 Bug ID: 1413038 Summary: Review Request: python3-simpleline - A Python3 library for creating text UI Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jkone...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jkonecny.fedorapeople.org/packages/simpleline/python3-simpleline.spec SRPM URL: https://jkonecny.fedorapeople.org/packages/simpleline/python3-simpleline-0.1-1.fc25.src.rpm Description: Hello, This is text UI framework used inside of Anaconda installer. We want to move it out as a separate package and use it in another projects. This text UI is designed to be used with line-based machines and tools (e.g. serial console) so that every new line is appended to the bottom of the screen. I already made scratch builds on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=17266370 https://koji.fedoraproject.org/koji/taskinfo?taskID=17266542 https://koji.fedoraproject.org/koji/taskinfo?taskID=17266559 Thank you for review, Jirka Fedora Account System Username: jkonecny -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1412788] Review Request: kf5-libkcddb - CDDB retrieval library
https://bugzilla.redhat.com/show_bug.cgi?id=1412788 Christian Dersch changed: What|Removed |Added Status|NEW |ASSIGNED CC||lupi...@mailbox.org Assignee|nob...@fedoraproject.org|lupi...@mailbox.org Flags||fedora-review? --- Comment #2 from Christian Dersch --- Assigned, review will follow soon -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1412773] Review Request: kf5-libkcompactdisc - A KDE compact disc library
https://bugzilla.redhat.com/show_bug.cgi?id=1412773
Christian Dersch changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #3 from Christian Dersch ---
Looks good, approved :)
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "LGPL (v2)", "LGPL (v2 or later)", "GPL (v2 or later)",
"Unknown or generated". 4 files have unknown license. Detailed output
of licensecheck in
/home/review/1412773-kf5-libkcompactdisc/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib64/qt5,
/usr/include/KF5, /usr/lib64/qt5/mkspecs, /usr/lib64/cmake,
/usr/lib64/qt5/mkspecs/modules
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned depende
[Bug 1412773] Review Request: kf5-libkcompactdisc - A KDE compact disc library
https://bugzilla.redhat.com/show_bug.cgi?id=1412773 Christian Dersch changed: What|Removed |Added Status|NEW |ASSIGNED CC||lupi...@mailbox.org Assignee|nob...@fedoraproject.org|lupi...@mailbox.org Flags||fedora-review? --- Comment #2 from Christian Dersch --- Assigned, review will follow soon -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413020] Review Request: konqueror - KDE File Manager and Browser
https://bugzilla.redhat.com/show_bug.cgi?id=1413020 Christian Dersch changed: What|Removed |Added Alias||konqueror -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413020] Review Request: konqueror - KDE File Manager and Browser
https://bugzilla.redhat.com/show_bug.cgi?id=1413020 Christian Dersch changed: What|Removed |Added Blocks||656997 (kde-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413020] New: Review Request: konqueror - KDE File Manager and Browser
https://bugzilla.redhat.com/show_bug.cgi?id=1413020 Bug ID: 1413020 Summary: Review Request: konqueror - KDE File Manager and Browser Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: lupi...@mailbox.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://lupinix.fedorapeople.org/review/konqueror.spec SRPM URL: https://lupinix.fedorapeople.org/review/konqueror-16.12.1-0.1.fc25.src.rpm Description: Konqueror allows you to manage your files and browse the web in a unified interface. Fedora Account System Username: lupinix Koji scratch build (rawhide): https://koji.fedoraproject.org/koji/taskinfo?taskID=17266417 Notes: We already have a konqueror package, it is a subpackage of kde-baseapps. The reason for this new package is a change in upstream packaging, new konqueror releases are now sperate, no longer part of kde-baseapps. So on import the konqueror stuff in kde-baseapps will be removed and the user will get the new package as an update. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1409867] Review Request: python-btchip - 'btchip-python' is a library used to interface with Ledger hardware devices ( Cryptocurrency)
https://bugzilla.redhat.com/show_bug.cgi?id=1409867 --- Comment #17 from Fedora Update System --- python-btchip-0.1.18-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1407000] Review Request: python-pulp - LP modeler written in python
https://bugzilla.redhat.com/show_bug.cgi?id=1407000 Haïkel Guémar changed: What|Removed |Added CC||karlthe...@gmail.com --- Comment #14 from Haïkel Guémar --- Well, among criteria used to untie, we look at upstream activity but both are reasonably maintained and PuLP has reserved name on PyPI. Technical solutions are: 1. rename either of the modules, and fix all software using it. Not very practical as both projects are used. 2. have python-pulp conflict python2-pulp-common (+ comment explaining why) and I'd rename the package to python-PuLP to avoid more confusion. I'd recommend option 2. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1412737] Review Request: slingshot-launcher - Lightweight and stylish app launcher
https://bugzilla.redhat.com/show_bug.cgi?id=1412737 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- slingshot-launcher-2.0.1-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9d3bb89be1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1361891] Review Request: python-windtalker - Super easy-to-use encryption and decryption tool
https://bugzilla.redhat.com/show_bug.cgi?id=1361891 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- python-windtalker-0.0.4-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-019a7d20a4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1412732] Review Request: appcenter - Software Center for the Pantheon desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1412732 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- appcenter-0.1.3-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9684d7eccb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1411502] Review Request: flr - Fedora RelEng python libraries and command line tools
https://bugzilla.redhat.com/show_bug.cgi?id=1411502 --- Comment #8 from Fedora Update System --- flr-0.0.1-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2aded42557 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1100973] Review Request: drupal7-honeypot - Honeypot uses both the honeypot and timestamp methods of deterring spam bots
https://bugzilla.redhat.com/show_bug.cgi?id=1100973 --- Comment #11 from Fedora Update System --- drupal7-honeypot-1.22-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-03d04b1d48 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1410985] Review Request: php-twig2 - The flexible, fast, and secure template engine for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1410985 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- php-twig2-2.1.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-78eea6cf5e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1100973] Review Request: drupal7-honeypot - Honeypot uses both the honeypot and timestamp methods of deterring spam bots
https://bugzilla.redhat.com/show_bug.cgi?id=1100973 --- Comment #10 from Fedora Update System --- drupal7-honeypot-1.22-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6c98374d17 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1411502] Review Request: flr - Fedora RelEng python libraries and command line tools
https://bugzilla.redhat.com/show_bug.cgi?id=1411502 --- Comment #7 from Fedora Update System --- flr-0.0.1-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-eedad33ad3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
