[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS
https://bugzilla.redhat.com/show_bug.cgi?id=1369720 Dan Horák changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #26 from Dan Horák --- formal review is here, see the notes explaining OK* and BAD statuses below: OK source files match upstream: 1d27f0e7564e7bf83b5751e5e9eb3f73c5dc971e tpm2.0-tools-1.1.0.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK license is open source-compatible (BSD). License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. OK* rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - rpmlint complains a bit tpm2-tools.src: W: spelling-error %description -l en_US tss -> ts, toss, ass tpm2-tools.src: W: strange-permission tpm2-tools.spec 775 tpm2-tools.x86_64: W: spelling-error %description -l en_US tss -> ts, toss, ass tpm2-tools.x86_64: W: no-manual-page-for-binary tpm2_* Please fix the spec file permission before committing, the missing man pages are not blocking the review, but would be nice to have at some point. The package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework
https://bugzilla.redhat.com/show_bug.cgi?id=1268380
--- Comment #38 from Björn "besser82" Esser ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Apache (v2.0)", "Unknown or generated".
75 files have unknown license. Detailed output of licensecheck in
/home/besser82/vm_shared/fedora/review/1268380-python-sphinx-
bootstrap-theme/licensecheck.txt
---> License-tag just states MIT. Please add other license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib/python3.6/site-packages,
/usr/lib/python3.6
---> False positive. f-r resolves this query on the host-system
instead inside the mock-chroot.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python3.6/site-
packages, /usr/lib/python3.6
---> Same as above.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
names).
---> See my remarks about rpmlint issues.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[!]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 122880 bytes in 12 files.
---> Since the *.txt-files are the same as the *.rst-files, it would
be enough to package %doc PKG-INFO *.rst.
[!]: Package complies to the Packaging Guidelines
---> Issues are present. ;(
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[!]: Avoid bundling fonts in non-fonts packages.
Note: Package contains font files
---> Those fonts are available in the
`glyphicons-halflings-fonts.noarch`-package.
Try to unbundle them, please.
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upst
[Bug 1405074] Review Request: golang-github-xeipuuv-gojsonschema - An implementation of JSON Schema, draft v4
https://bugzilla.redhat.com/show_bug.cgi?id=1405074 Frantisek Kluknavsky changed: What|Removed |Added CC||fkluk...@redhat.com Assignee|nob...@fedoraproject.org|fkluk...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1405074] Review Request: golang-github-xeipuuv-gojsonschema - An implementation of JSON Schema, draft v4
https://bugzilla.redhat.com/show_bug.cgi?id=1405074 Frantisek Kluknavsky changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413978] New: Review Request: php-sabre-vobject4 - Library to parse and manipulate iCalendar and vCard objects
https://bugzilla.redhat.com/show_bug.cgi?id=1413978 Bug ID: 1413978 Summary: Review Request: php-sabre-vobject4 - Library to parse and manipulate iCalendar and vCard objects Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@famillecollet.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/fb8a6e5c495821e5b210091397f1adc29c06632e/php/sabredav/php-sabre-vobject4/php-sabre-vobject4.spec SRPM URL: http://rpms.remirepo.net/SRPMS/php-sabre-vobject4-4.1.2-1.remi.src.rpm Description: The VObject library allows you to easily parse and manipulate iCalendar and vCard objects using PHP. The goal of the VObject library is to create a very complete library, with an easy to use API. This project is a spin-off from SabreDAV, where it has been used for several years. The VObject library has 100% unittest coverage. Autoloader: /usr/share/php/Sabre/VObject4/autoload.php Fedora Account System Username: remi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1405074] Review Request: golang-github-xeipuuv-gojsonschema - An implementation of JSON Schema, draft v4
https://bugzilla.redhat.com/show_bug.cgi?id=1405074 Frantisek Kluknavsky changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #2 from Frantisek Kluknavsky --- Looks good to me (except dubious https://bugzilla.redhat.com/show_bug.cgi?id=1413669) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413978] Review Request: php-sabre-vobject4 - Library to parse and manipulate iCalendar and vCard objects
https://bugzilla.redhat.com/show_bug.cgi?id=1413978 Remi Collet changed: What|Removed |Added CC||james.hoga...@gmail.com --- Comment #1 from Remi Collet --- @James, from IRC > nextcloud 11.0.1 has bumped the sabre-dav req in composer.json to 3.2.0 sabre/dav requires sabre/vobject 4.1 which have BC break. glpi requires (for now) sabre/vobject 3.5 So yet another candidate for multi-versions. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1405072] Review Request: golang-github-xeipuuv-gojsonreference - JSON Reference implementation in Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1405072 Frantisek Kluknavsky changed: What|Removed |Added CC||fkluk...@redhat.com Assignee|nob...@fedoraproject.org|fkluk...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1360482] Review Request: nextcloud - a private, secure way to share and access files
https://bugzilla.redhat.com/show_bug.cgi?id=1360482 --- Comment #25 from Remi Collet --- See bug #1413978 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413978] Review Request: php-sabre-vobject4 - Library to parse and manipulate iCalendar and vCard objects
https://bugzilla.redhat.com/show_bug.cgi?id=1413978 --- Comment #2 from Remi Collet --- Fix for php-sabre-vobject (command removed) http://pkgs.fedoraproject.org/cgit/php-sabre-vobject.git/commit/?h=master&id=3ad2ba1e456c41ab867006e2f31c7bb7f419fe5f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1405072] Review Request: golang-github-xeipuuv-gojsonreference - JSON Reference implementation in Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1405072 Frantisek Kluknavsky changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #2 from Frantisek Kluknavsky --- Looks good to me (except for dubious https://bugzilla.redhat.com/show_bug.cgi?id=1413669 ) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414001] New: Review Request: rubygem-ruby_engine - Adds the RubyEngine pseudo-constant
https://bugzilla.redhat.com/show_bug.cgi?id=1414001 Bug ID: 1414001 Summary: Review Request: rubygem-ruby_engine - Adds the RubyEngine pseudo-constant Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: val...@civ.zcu.cz QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://scientific.zcu.cz/fedora/rubygem-ruby_engine-1.0.1-1/rubygem-ruby_engine.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-ruby_engine-1.0.1-1/rubygem-ruby_engine-1.0.1-1.fc26.src.rpm Description: Gives you an RubyEngine class that simplifies checking for your Ruby implementation. Fedora Account System Username: valtri COPR build: https://copr.fedorainfracloud.org/coprs/valtri/ruby/build/500696/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1407000] Review Request: python-PuLP - LP modeler written in python
https://bugzilla.redhat.com/show_bug.cgi?id=1407000 --- Comment #16 from Alan Pevec --- This matches 2nd case, name conflict of not compatible libs : https://fedoraproject.org/wiki/Packaging:Conflicts#Library_Name_Conflicts Guideline requires to ask one of the upstreams to rename itself, which is unlikely, so we need FPC ticket, I've opened: https://fedorahosted.org/fpc/ticket/671 and FYI bug 1414000 for current pulp RPM maintainers. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414002] New: Review Request: rubygem-ruby_version - Adds the RubyVersion pseudo-constant
https://bugzilla.redhat.com/show_bug.cgi?id=1414002 Bug ID: 1414002 Summary: Review Request: rubygem-ruby_version - Adds the RubyVersion pseudo-constant Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: val...@civ.zcu.cz QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://scientific.zcu.cz/fedora/rubygem-ruby_version-1.0.1-1/rubygem-ruby_version.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-ruby_version-1.0.1-1/rubygem-ruby_version-1.0.1-1.fc26.src.rpm Description: Provides a RubyVersion class to simplify checking for the right Ruby version in your programs. Fedora Account System Username: valtri COPR build: https://copr.fedorainfracloud.org/coprs/valtri/ruby/build/500697/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414004] New: Review Request: rubygem-rspec-pending_for - Mark specs pending or skipped for specific Ruby engine
https://bugzilla.redhat.com/show_bug.cgi?id=1414004 Bug ID: 1414004 Summary: Review Request: rubygem-rspec-pending_for - Mark specs pending or skipped for specific Ruby engine Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: val...@civ.zcu.cz QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://scientific.zcu.cz/fedora/rubygem-rspec-pending_for-0.1.3-1/rubygem-rspec-pending_for.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-rspec-pending_for-0.1.3-1/rubygem-rspec-pending_for-0.1.3-1.fc26.src.rpm Description: Mark specs pending or skipped for specific Ruby engine (e.g. MRI or JRuby) / version combinations. Fedora Account System Username: valtri COPR build: https://copr.fedorainfracloud.org/coprs/valtri/ruby/build/500704/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414002] Review Request: rubygem-ruby_version - Adds the RubyVersion pseudo-constant
https://bugzilla.redhat.com/show_bug.cgi?id=1414002 František Dvořák changed: What|Removed |Added Depends On||1414004 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1414004 [Bug 1414004] Review Request: rubygem-rspec-pending_for - Mark specs pending or skipped for specific Ruby engine -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414001] Review Request: rubygem-ruby_engine - Adds the RubyEngine pseudo-constant
https://bugzilla.redhat.com/show_bug.cgi?id=1414001 František Dvořák changed: What|Removed |Added Depends On||1414004 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1414004 [Bug 1414004] Review Request: rubygem-rspec-pending_for - Mark specs pending or skipped for specific Ruby engine -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414004] Review Request: rubygem-rspec-pending_for - Mark specs pending or skipped for specific Ruby engine
https://bugzilla.redhat.com/show_bug.cgi?id=1414004 František Dvořák changed: What|Removed |Added Blocks||1414001, 1414002 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1414001 [Bug 1414001] Review Request: rubygem-ruby_engine - Adds the RubyEngine pseudo-constant https://bugzilla.redhat.com/show_bug.cgi?id=1414002 [Bug 1414002] Review Request: rubygem-ruby_version - Adds the RubyVersion pseudo-constant -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414004] Review Request: rubygem-rspec-pending_for - Mark specs pending or skipped for specific Ruby engine
https://bugzilla.redhat.com/show_bug.cgi?id=1414004 František Dvořák changed: What|Removed |Added Blocks|1414001, 1414002| Depends On||1414001, 1414002 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1414001 [Bug 1414001] Review Request: rubygem-ruby_engine - Adds the RubyEngine pseudo-constant https://bugzilla.redhat.com/show_bug.cgi?id=1414002 [Bug 1414002] Review Request: rubygem-ruby_version - Adds the RubyVersion pseudo-constant -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414001] Review Request: rubygem-ruby_engine - Adds the RubyEngine pseudo-constant
https://bugzilla.redhat.com/show_bug.cgi?id=1414001 František Dvořák changed: What|Removed |Added Blocks||1414004 Depends On|1414004 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1414004 [Bug 1414004] Review Request: rubygem-rspec-pending_for - Mark specs pending or skipped for specific Ruby engine -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414002] Review Request: rubygem-ruby_version - Adds the RubyVersion pseudo-constant
https://bugzilla.redhat.com/show_bug.cgi?id=1414002 František Dvořák changed: What|Removed |Added Blocks||1414004 Depends On|1414004 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1414004 [Bug 1414004] Review Request: rubygem-rspec-pending_for - Mark specs pending or skipped for specific Ruby engine -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1360482] Review Request: nextcloud - a private, secure way to share and access files
https://bugzilla.redhat.com/show_bug.cgi?id=1360482 James Hogarth changed: What|Removed |Added Flags|needinfo?(james.hogarth@gma | |il.com) | --- Comment #26 from James Hogarth --- For a quick update: So going through this over the weekend and we've got some library requirements that will need updates or fresh reviews. +BuildRequires: php-composer(sabre/dav) >= 3.2.0 +BuildRequires: php-composer(symfony/console) >= 3.0.0 +BuildRequires: php-composer(symfony/event-dispatcher) >= 3.0.0 +BuildRequires: php-composer(symfony/routing) >= 3.0.0 +BuildRequires: php-composer(symfony/process) >= 3.0.0 +BuildRequires: php-composer(icewind/smb) >= 1.1.0 +BuildRequires: php-aws-sdk >= 2.7.5 +BuildRequires: php-composer(stecman/symfony-console-completion) >= 0.7.0 I'll be working through these in a way that doesn't break the existing owncloud package before we can complete this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1409334] Review Request: kdiagram - Powerful libraries (KChart, KGantt) for creating business diagrams
https://bugzilla.redhat.com/show_bug.cgi?id=1409334 --- Comment #5 from Fedora Update System --- kdiagram-2.6.0-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-72ffe34c75 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1409334] Review Request: kdiagram - Powerful libraries (KChart, KGantt) for creating business diagrams
https://bugzilla.redhat.com/show_bug.cgi?id=1409334 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1409334] Review Request: kdiagram - Powerful libraries (KChart, KGantt) for creating business diagrams
https://bugzilla.redhat.com/show_bug.cgi?id=1409334 --- Comment #6 from Fedora Update System --- kdiagram-2.6.0-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1ab1227718 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392917] Review Request: libvdpau-va-gl - VDPAU driver with OpenGL/ VAAPI back-end
https://bugzilla.redhat.com/show_bug.cgi?id=1392917 --- Comment #4 from Nicolas Chauvet (kwizart) --- Spec URL: http://dl.kwizart.net/review/libvdpau-va-gl.spec SRPM URL: http://dl.kwizart.net/review/libvdpau-va-gl-0.4.2-3.fc26.src.rpm Description: VDPAU driver with OpenGL/VAAPI back-end Changelog: - Drop ExclusiveArch - Add comment about why to drop un-versioned symlink - Add missing BR koji scratch build for f26: https://koji.fedoraproject.org/koji/taskinfo?taskID=17312520 Sorry for the lack of answer. So far Makefile is still the default buildroot. I've added gcc-c++ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414001] Review Request: rubygem-ruby_engine - Adds the RubyEngine pseudo-constant
https://bugzilla.redhat.com/show_bug.cgi?id=1414001 Mamoru TASAKA changed: What|Removed |Added Assignee|nob...@fedoraproject.org|mtas...@fedoraproject.org --- Comment #1 from Mamoru TASAKA --- Taking. I would appreciate it if you would review my review request (bug 1409288) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414002] Review Request: rubygem-ruby_version - Adds the RubyVersion pseudo-constant
https://bugzilla.redhat.com/show_bug.cgi?id=1414002 Mamoru TASAKA changed: What|Removed |Added Assignee|nob...@fedoraproject.org|mtas...@fedoraproject.org --- Comment #1 from Mamoru TASAKA --- Taking. I would appreciate it if you would review my review request (bug 1409355) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1407000] Review Request: python-PuLP - LP modeler written in python
https://bugzilla.redhat.com/show_bug.cgi?id=1407000 --- Comment #17 from Dominik 'Rathann' Mierzejewski --- (In reply to Alan Pevec from comment #16) > This matches 2nd case, name conflict of not compatible libs : > https://fedoraproject.org/wiki/Packaging:Conflicts#Library_Name_Conflicts > > Guideline requires to ask one of the upstreams to rename itself, which is > unlikely, Even if you think it's unlikely, you should still try asking nicely. You never know if they're amenable or not unless there have been previous failed attempts. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414027] New: Review Request: kmail - Mail Client
https://bugzilla.redhat.com/show_bug.cgi?id=1414027 Bug ID: 1414027 Summary: Review Request: kmail - Mail Client Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rdie...@math.unl.edu QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kmail.spec SRPM URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kmail-16.12.1-1.fc25.src.rpm Description: Mail client Fedora Account System Username: rdieter required kde-apps-16.12.1 dependencies are building now for rawhide. Once in, I'll submit a scratch build. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414027] Review Request: kmail - Mail Client
https://bugzilla.redhat.com/show_bug.cgi?id=1414027 Rex Dieter changed: What|Removed |Added Blocks||656997 (kde-reviews) Alias||kmail Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414027] Review Request: kmail - Mail Client
https://bugzilla.redhat.com/show_bug.cgi?id=1414027 Rex Dieter changed: What|Removed |Added Blocks||1414029 ||(kmail-account-wizard) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1414029 [Bug 1414029] Review Request: kmail-account-wizard - KMail Account Wizard -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414029] Review Request: kmail-account-wizard - KMail Account Wizard
https://bugzilla.redhat.com/show_bug.cgi?id=1414029 Rex Dieter changed: What|Removed |Added Blocks||656997 (kde-reviews) Depends On||1414027 (kmail) Alias||kmail-account-wizard Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker https://bugzilla.redhat.com/show_bug.cgi?id=1414027 [Bug 1414027] Review Request: kmail - Mail Client -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414029] New: Review Request: kmail-account-wizard - KMail Account Wizard
https://bugzilla.redhat.com/show_bug.cgi?id=1414029 Bug ID: 1414029 Summary: Review Request: kmail-account-wizard - KMail Account Wizard Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rdie...@math.unl.edu QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kmail-16.12.1-1.fc25.src.rpm SRPM URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kmail-account-wizard-16.12.1-1.fc25.src.rpm Description: KMail Account Wizard Fedora Account System Username: rdieter required kde-apps-16.12 dependencies are building now for rawhide. Once in, I'll submit a scratch build. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414030] New: Review Request: knotes - Popup Notes
https://bugzilla.redhat.com/show_bug.cgi?id=1414030 Bug ID: 1414030 Summary: Review Request: knotes - Popup Notes Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rdie...@math.unl.edu QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://rdieter.fedorapeople.org/rpms/kde-apps/knotes.spec SRPM URL: https://rdieter.fedorapeople.org/rpms/kde-apps/knotes-16.12.1-1.fc25.src.rpm Description: Popup Notes Fedora Account System Username: rdieter -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414030] Review Request: knotes - Popup Notes
https://bugzilla.redhat.com/show_bug.cgi?id=1414030 Rex Dieter changed: What|Removed |Added Blocks||656997 (kde-reviews) Alias||knotes --- Comment #1 from Rex Dieter --- required kde-apps-16.12 dependencies are building now for rawhide. Once in, I'll submit a scratch build. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414031] New: Review Request: kontact - Personal Information Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1414031 Bug ID: 1414031 Summary: Review Request: kontact - Personal Information Manager Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rdie...@math.unl.edu QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kontact.spec SRPM URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kontact-16.12.1-1.fc25.src.rpm Description: Personal Information Manager Fedora Account System Username: rdieter -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414031] Review Request: kontact - Personal Information Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1414031 Rex Dieter changed: What|Removed |Added Blocks||656997 (kde-reviews) Alias||kontact --- Comment #1 from Rex Dieter --- required kde-apps-16.12 dependencies are building now for rawhide. Once in, I'll submit a scratch build. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414032] Review Request: korganizer - Personal Organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1414032 Rex Dieter changed: What|Removed |Added Blocks||656997 (kde-reviews) Alias||korganizer --- Comment #1 from Rex Dieter --- required kde-apps-16.12 dependencies are building now for rawhide. Once in, I'll submit a scratch build. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414032] New: Review Request: korganizer - Personal Organizer
https://bugzilla.redhat.com/show_bug.cgi?id=1414032 Bug ID: 1414032 Summary: Review Request: korganizer - Personal Organizer Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rdie...@math.unl.edu QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://rdieter.fedorapeople.org/rpms/kde-apps/korganizer.spec SRPM URL: https://rdieter.fedorapeople.org/rpms/kde-apps/korganizer-16.12.1-1.fc25.src.rpm Description: Personal Organizer Fedora Account System Username: rdieter -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome
https://bugzilla.redhat.com/show_bug.cgi?id=1343710 --- Comment #18 from Jeremy Newton --- (In reply to Mark Harfouche from comment #17) > Jeremy, > > I'm not too knowledgeable about all of Fedora's packaging guidelines, > especially pertaining to licensing. > > In either case, I could probably take this one over until it gets too > complicated to package. How would I go about getting sponsorship? > > Mark If you would like to become a fedora packager, please read the following wiki: https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group If you don't want to be a packager, I can take the package instead and another sponsored packager can review it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414027] Review Request: kmail - Mail Client
https://bugzilla.redhat.com/show_bug.cgi?id=1414027 Christian Dersch changed: What|Removed |Added Status|NEW |ASSIGNED CC||lupi...@mailbox.org Assignee|nob...@fedoraproject.org|lupi...@mailbox.org Flags||fedora-review? --- Comment #1 from Christian Dersch --- Taken -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1405066] Review Request: golang-github-pkg-errors - Simple error handling primitives
https://bugzilla.redhat.com/show_bug.cgi?id=1405066 Frantisek Kluknavsky changed: What|Removed |Added CC||fkluk...@redhat.com Assignee|nob...@fedoraproject.org|fkluk...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1405066] Review Request: golang-github-pkg-errors - Simple error handling primitives
https://bugzilla.redhat.com/show_bug.cgi?id=1405066 Frantisek Kluknavsky changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1405066] Review Request: golang-github-pkg-errors - Simple error handling primitives
https://bugzilla.redhat.com/show_bug.cgi?id=1405066 Frantisek Kluknavsky changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Frantisek Kluknavsky --- Looks good to me (except for dubious https://bugzilla.redhat.com/show_bug.cgi?id=1413669 ) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays
https://bugzilla.redhat.com/show_bug.cgi?id=769487 Nicolas Chauvet (kwizart) changed: What|Removed |Added Flags||fedora-review+ --- Comment #17 from Nicolas Chauvet (kwizart) --- Okay going forward with this. I still cannot import glumpy , missing triangle: https://pypi.python.org/pypi/triangle -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays
https://bugzilla.redhat.com/show_bug.cgi?id=769487 Nicolas Chauvet (kwizart) changed: What|Removed |Added Flags|fedora-review+ |fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1201176] Review Request: python-pygatt - A Python Module for Bluetooth LE Generic Attribute Profile
https://bugzilla.redhat.com/show_bug.cgi?id=1201176 --- Comment #8 from Fabian Affolter --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #7) > No need to define %sum, just fill in the first Summary, and then use > %summary in subsequent ones. There are several ways to do. > Requries: bluez should apply to both subpackages, no? Updated > The tarball contains some pdf files which don't look like they're > redistributable. You'll have to provide a sanitized tarball without them. Switched to the tarball from PyPI. That one doesn't contain the PDF files. %changelog * Tue Jan 17 2017 Fabian Affolter - 3.0.0-2 - Change source URL - Update requirements Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-pygatt.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-pygatt-3.0.0-2.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1410651] Review Request: minetestmapper - Generates a overview image of a minetest map
https://bugzilla.redhat.com/show_bug.cgi?id=1410651 Daniel Moerner changed: What|Removed |Added CC||dmoer...@gmail.com --- Comment #1 from Daniel Moerner --- Hi, This is a non-official package review. Just trying to get involved :). This looks very good to me. I can't find any particular problems. Note that I wrote a manpage which you can include, see below. Versioning: I worried a bit about the versioning in case upstream decides to issue a proper release, but I see that upstream does have a single git tag with a date, and which they used as the version for a Windows release, and which is the tag you used for this release. So this is probably fine. Relevant fedora-review output: Issues: === - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 ^ As confirmed on IRC with nirik, this is actually seems to be a bug in fedora-review. It is correct to list gcc-c++ as a BR, per https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B#BuildRequires_and_Requires I have filed a bug against fedora-review: https://bugzilla.redhat.com/show_bug.cgi?id=1414065 Rpmlint --- Checking: minetestmapper-20161218-1.fc25.x86_64.rpm minetestmapper-debuginfo-20161218-1.fc25.x86_64.rpm minetestmapper-20161218-1.fc25.src.rpm minetestmapper.x86_64: W: spelling-error %description -l en_US py -> pt, p, y minetestmapper.x86_64: W: no-manual-page-for-binary minetestmapper minetestmapper.src: W: spelling-error Summary(en_US) minetest -> minutest, mine test, mine-test minetestmapper.src: W: spelling-error %description -l en_US minetest -> minutest, mine test, mine-test minetestmapper.src: W: spelling-error %description -l en_US py -> pt, p, y 3 packages and 0 specfiles checked; 0 errors, 5 warnings. ^ The spelling errors are fine. But manpages are good, so I wrote a manpage! I filed a pull request with upstream: https://github.com/minetest/minetestmapper/pull/43 You are of course welcome to include the manpage in the Fedora package itself before upstream releases a new version. Here's a direct link: https://github.com/dmoerner/minetestmapper/blob/master/minetestmapper.6 The manpage does include a reference to postgresql support, which is in upstream master but not in 20161218. So if you want to include it you should remove that. (sed -i 's/\*postgresql\*, //' minetestmapper.6) Daniel -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1409288] Review Request: rubygem-clutter-gdk - Ruby binding of GDK specific API of Clutter
https://bugzilla.redhat.com/show_bug.cgi?id=1409288 František Dvořák changed: What|Removed |Added CC||val...@civ.zcu.cz Assignee|nob...@fedoraproject.org|val...@civ.zcu.cz Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414001] Review Request: rubygem-ruby_engine - Adds the RubyEngine pseudo-constant
https://bugzilla.redhat.com/show_bug.cgi?id=1414001 --- Comment #2 from František Dvořák --- Taken, thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414087] Review Request: Gearboy - Game Boy and Game Boy Color emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1414087 Daniel Moerner changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414087] Review Request: Gearboy - Game Boy and Game Boy Color emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1414087 Daniel Moerner changed: What|Removed |Added Blocks||1364745 (FE-GAMESIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1364745 [Bug 1364745] Games SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414087] Review Request: Gearboy - Game Boy and Game Boy Color emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1414087 Daniel Moerner changed: What|Removed |Added Depends On||1364745 (FE-GAMESIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1364745 [Bug 1364745] Games SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414087] Review Request: Gearboy - Game Boy and Game Boy Color emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1414087 Daniel Moerner changed: What|Removed |Added Depends On|1364745 (FE-GAMESIG)| Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1364745 [Bug 1364745] Games SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413399] Review Request: wcstools - Software utilities to display and manipulate the WCS of a FITS image
https://bugzilla.redhat.com/show_bug.cgi?id=1413399 Mattia Verga changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2017-01-17 12:28:02 --- Comment #4 from Mattia Verga --- Thanks, I've built it in Rawhide; builds for EPEL7 and EL6 are running now, I will try to build it also for F25 if guys at releng will unblock that branch. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414087] New: Review Request: Gearboy - Game Boy and Game Boy Color emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1414087 Bug ID: 1414087 Summary: Review Request: Gearboy - Game Boy and Game Boy Color emulator Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: dmoer...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/dmoerner/Gearboy/Gearboy.git/plain/Gearboy.spec?id=91cac5b448bbdee305b3a040bb2b11108a6537ff SRPM URL: https://copr-be.cloud.fedoraproject.org/results/dmoerner/Gearboy/fedora-25-x86_64/00500763-Gearboy/Gearboy-2.3.1-1.fc25.src.rpm Description: Gearboy is a Nintendo Game Boy and Game Boy Color emulator written in C++. The emulator prioritizes readable, simple source code and high compatibility across a variety of platforms and architectures. Gearboy features highly accurate CPU emulation, instruction timing, and memory timing. It also includes memory bank controllers, accurate LCD controller emulation, mix frames, sound emulation, and compressed ROM support. Fedora Account System Username: dmoerner Successful koji scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=17313799 This is my first package, and I need a sponsor. Gearboy is an emulator compatible with Fedora's new, more relaxed emulator policy.[1] It is GPLv3+ and contains no non-free components. It needs only game ROMS supplied by the user and not included in the package. I chose to name it "Gearboy" rather than "gearboy" because upstreame consistently uses the capitalized form, including in documentation and in the binary name. (The only exception is actually git tagging, as noted in the spec file.) If "gearboy" would be preferred, it would be trivial to rename the files during install. Upstream has been very responsive; they merged a number of pull requests I submitted, including man, desktop, and appdata files that I wrote.[2] I checked the package with mock, rpmlint, and fedora-review many times, and believe it conforms to the package requirements. To potential sponsors: I already introduced myself informally on the games mailing list[3], and I will introduce myself again on the devel list. Here is some relevant information that might help you decide to sponsor me: I have read the packaging guidelines many times. Gearboy is actually the third package I have created while trying to follow the packaging guidelines. (The first, hamlet, an SML interpreter, still requires some patches to satisfy FHS which I have not yet written. I hope to submit a review-request for it when I do that. The second, higan, another emulator, has some licensing issues that I came to believe make it unsuitable for inclusion in Fedora.) I completed a sample review for the minetestmapper package.[4] I thought the package was in very good shape, so it turned out to be very simple. (I'm sure I missed something, though!) But it did give me an opportunity to find what I believe is a small bug in fedora-review[5], and to write and submit a manpage for the package upstream.[6] Finally, back when I was involved in Debian development, they asked you to triage a so-called "release-critical" bug, like a FTBFS. I informally did this for a recent bug in guile found during the rawhide readline-7 rebuild.[7] (It turned out to be non-reproducible.) I also hang out in IRC as dmoerner, you are welcome to quiz me or ask me to do additional things! Thanks! [1] https://fedoraproject.org/wiki/Licensing:SoftwareTypes?rd=Licensing/SoftwareTypes#Emulators [2] https://github.com/drhelius/Gearboy/pull/42 [3] https://lists.fedoraproject.org/archives/list/ga...@lists.fedoraproject.org/thread/LPEW5CCGK6JRGDCV3CTRXGGDTAD2EHO5/ [4] https://bugzilla.redhat.com/show_bug.cgi?id=1410651#c1 [5] https://bugzilla.redhat.com/show_bug.cgi?id=1414065 [6] https://github.com/minetest/minetestmapper/pull/43 [7] https://bugzilla.redhat.com/show_bug.cgi?id=1412931#c1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1201176] Review Request: python-pygatt - A Python Module for Bluetooth LE Generic Attribute Profile
https://bugzilla.redhat.com/show_bug.cgi?id=1201176 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl Flags|fedora-review? |fedora-review+ --- Comment #9 from Zbigniew Jędrzejewski-Szmek --- + package name follows the guidelines + summary and description are legible + license is acceptable (ASL 2.0) + license is specified correctly + latest python packaging template is used + %python_provide are present + provides/requires/br seem correct rpmlint: one bogus spelling error and many bogus python-bytecode-wrong-magic-value errors Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1343710] Review Request: chrome-gnome-shell - GNOME Shell integration for Chrome
https://bugzilla.redhat.com/show_bug.cgi?id=1343710 --- Comment #19 from Mark Harfouche --- Jeremy, The process requires a little reading on my part. I'll look at it this weekend. In the mean time, I have no issue if you want to take this on and publish it. There will always be more packages. It seems eventually I can become a co-maintainer. Mark -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1373641] Review Request: setBfree - A DSP Tonewheel Organ emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1373641 --- Comment #20 from Fedora Update System --- setBfree-0.8.4-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1411154] Review Request: mint-y-theme - The Mint-Y theme
https://bugzilla.redhat.com/show_bug.cgi?id=1411154 Bug 1411154 depends on bug 1411153, which changed state. Bug 1411153 Summary: Review Request: mint-y-icons - The Mint-Y icon theme https://bugzilla.redhat.com/show_bug.cgi?id=1411153 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1411151] Review Request: cinnamon-themes - Collection of the best themes available for Cinnamon
https://bugzilla.redhat.com/show_bug.cgi?id=1411151 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-01-17 14:52:27 --- Comment #8 from Fedora Update System --- cinnamon-themes-2016.12.07-1.fc25, mint-x-icons-1.4.0-1.fc25, mint-y-icons-1.0.4-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1411153] Review Request: mint-y-icons - The Mint-Y icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1411153 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-01-17 14:52:19 --- Comment #8 from Fedora Update System --- cinnamon-themes-2016.12.07-1.fc25, mint-x-icons-1.4.0-1.fc25, mint-y-icons-1.0.4-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1411151] Review Request: cinnamon-themes - Collection of the best themes available for Cinnamon
https://bugzilla.redhat.com/show_bug.cgi?id=1411151 Bug 1411151 depends on bug 1411152, which changed state. Bug 1411152 Summary: Review Request: mint-x-icons - Icon theme for Linux Mint https://bugzilla.redhat.com/show_bug.cgi?id=1411152 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1411152] Review Request: mint-x-icons - Icon theme for Linux Mint
https://bugzilla.redhat.com/show_bug.cgi?id=1411152 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-01-17 14:52:23 --- Comment #8 from Fedora Update System --- cinnamon-themes-2016.12.07-1.fc25, mint-x-icons-1.4.0-1.fc25, mint-y-icons-1.0.4-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1405271] Review Request: python-streamlink - Python library for extracting streams from various websites
https://bugzilla.redhat.com/show_bug.cgi?id=1405271 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-01-17 14:52:39 --- Comment #15 from Fedora Update System --- python-streamlink-0.2.0-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413375] Review Request: lxqt-l10n - Translations for the LXQt desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1413375 Björn "besser82" Esser changed: What|Removed |Added Status|NEW |ASSIGNED CC||besse...@fedoraproject.org Assignee|nob...@fedoraproject.org|besse...@fedoraproject.org Flags||fedora-review? --- Comment #1 from Björn "besser82" Esser --- Starting review… -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1411151] Review Request: cinnamon-themes - Collection of the best themes available for Cinnamon
https://bugzilla.redhat.com/show_bug.cgi?id=1411151 --- Comment #9 from Fedora Update System --- cinnamon-themes-2016.12.07-1.fc24, mint-x-icons-1.4.0-1.fc24, mint-y-icons-1.0.4-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1411153] Review Request: mint-y-icons - The Mint-Y icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1411153 --- Comment #9 from Fedora Update System --- cinnamon-themes-2016.12.07-1.fc24, mint-x-icons-1.4.0-1.fc24, mint-y-icons-1.0.4-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1405271] Review Request: python-streamlink - Python library for extracting streams from various websites
https://bugzilla.redhat.com/show_bug.cgi?id=1405271 --- Comment #16 from Fedora Update System --- python-streamlink-0.2.0-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1411152] Review Request: mint-x-icons - Icon theme for Linux Mint
https://bugzilla.redhat.com/show_bug.cgi?id=1411152 --- Comment #9 from Fedora Update System --- cinnamon-themes-2016.12.07-1.fc24, mint-x-icons-1.4.0-1.fc24, mint-y-icons-1.0.4-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413375] Review Request: lxqt-l10n - Translations for the LXQt desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1413375
Björn "besser82" Esser changed:
What|Removed |Added
Status|ASSIGNED|POST
CC|package-review@lists.fedora |
|project.org |
Blocks|928937 (qt-reviews) |
Flags|fedora-review? |fedora-review+
--- Comment #2 from Björn "besser82" Esser ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
---> Ignored. See explanation in review-request.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later)", "Unknown or generated". 1271 files have
unknown license. Detailed output of licensecheck in
/home/besser82/vm_shared/fedora/review/lxqt-l10n-lxqt-
l10n/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/lxqt/translations/lxqt-panel/dom,
/usr/share/lxqt/translations/lxqt-panel/colorpicker, /usr/share
/pavucontrol-qt, /usr/share/lxqt/translations/lxqt-panel/tray,
/usr/share/lxqt/translations/lxqt-panel/statusnotifier
---> Ignored. See explanation in review-request.
Please make sure, all dirs are owned after import.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/lxqt/translations
/lxqt-panel/tray, /usr/share/lxqt/translations/lxqt-
panel/statusnotifier, /usr/share/lxqt/translations/lxqt-
panel/colorpicker, /usr/share/pavucontrol-qt,
/usr/share/lxqt/translations/lxqt-panel/dom
---> Ignored. See explanation in review-request.
Please make sure, all dirs are owned after import.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/lxqt/translations
/lxqt-panel(lxqt-panel), /usr/share/libfm-qt/translations(libfm-qt),
/usr/share/pcmanfm-qt/translations(pcmanfm-qt), /usr/share/lximage-
qt/translations(lximage-qt), /usr/share/lxqt/translations/lxqt-about
(lxqt-about), /usr/share/obconf-qt/translations(obconf-qt),
/usr/share/lxqt/translations/lxqt-sudo(lxqt-sudo)
---> Ignored. See explanation in review-request.
Please make sure, all dirs are owned after import.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 184320 bytes in 36 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]:
[Bug 1413375] Review Request: lxqt-l10n - Translations for the LXQt desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1413375 --- Comment #3 from Christian Dersch --- Thank you very much! -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414131] New: Review Request: docker2aci - Convert Docker images to ACI
https://bugzilla.redhat.com/show_bug.cgi?id=1414131 Bug ID: 1414131 Summary: Review Request: docker2aci - Convert Docker images to ACI Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: l...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://lsm5.fedorapeople.org/docker2aci/docker2aci.spec SRPM URL: https://lsm5.fedorapeople.org/docker2aci/SRPMS/docker2aci-0.15.0-1.fc25.src.rpm Description: Convert Docker images to ACI Fedora Account System Username: lsm5 Currently uses bundled deps. No matching package to install: 'golang(github.com/coreos/ioprogress)' No matching package to install: 'golang(github.com/klauspost/pgzip)' No matching package to install: 'golang(github.com/opencontainers/image-spec/specs-go/v1)' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414132] New: Review Request: wingpanel-indicator-datetime - Datetime Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1414132 Bug ID: 1414132 Summary: Review Request: wingpanel-indicator-datetime - Datetime Indicator for wingpanel Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: decatho...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://raw.githubusercontent.com/decathorpe/fedora-packaging/51f2c315fa48bd52048e5d651a179b34f139a476/specs/wingpanel-indicator-datetime/wingpanel-indicator-datetime.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/decathorpe/staging/fedora-25-x86_64/00500790-wingpanel-indicator-datetime/wingpanel-indicator-datetime-2.0.1-2.fc25.src.rpm Description: A datetime indicator for wingpanel. Fedora Account System Username: decathorpe koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=17315703 COPR build for f25 and rawhide: https://copr.fedorainfracloud.org/coprs/decathorpe/staging/build/500790/ Comment on the occurring "incorrect-fsf-address" rpmlint errors: I already informed upstream about this error / oversight. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414131] Review Request: docker2aci - Convert Docker images to ACI
https://bugzilla.redhat.com/show_bug.cgi?id=1414131 Lokesh Mandvekar changed: What|Removed |Added Status|NEW |ASSIGNED CC||fkluk...@redhat.com Assignee|nob...@fedoraproject.org|jchal...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1412801] Review Request: python-networkmanager - Easy communication with NetworkManager
https://bugzilla.redhat.com/show_bug.cgi?id=1412801 --- Comment #2 from John Dulaney --- Spec URL: https://jdulaney.fedorapeople.org/python-networkmanager.spec SRPM URL: https://jdulaney.fedorapeople.org/python-networkmanager-1.2.1-2.fc25.src.rpm Went through and took care of things; I prefer to use pypi as that feels like a more official release than github; I shall ask the maintainers to see which they prefer. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414141] New: Review Request: wingpanel-indicator-bluetooth - Bluetooth Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1414141 Bug ID: 1414141 Summary: Review Request: wingpanel-indicator-bluetooth - Bluetooth Indicator for wingpanel Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: decatho...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://raw.githubusercontent.com/decathorpe/fedora-packaging/1c55131df73ba429f003bfe5291ecfdfd05b87d9/specs/wingpanel-indicator-bluetooth/wingpanel-indicator-bluetooth.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/decathorpe/staging/fedora-25-x86_64/00500791-wingpanel-indicator-bluetooth/wingpanel-indicator-bluetooth-2.0-4.fc25.src.rpm Description: A bluetooth indicator for wingpanel. Fedora Account System Username: decathorpe koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=17315812 COPR build for f25 and rawhide: https://copr.fedorainfracloud.org/coprs/decathorpe/staging/build/500791/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414147] New: Review Request: wingpanel-indicator-ayatana - Ayatana Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1414147 Bug ID: 1414147 Summary: Review Request: wingpanel-indicator-ayatana - Ayatana Indicator for wingpanel Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: decatho...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://raw.githubusercontent.com/decathorpe/fedora-packaging/123d7ea66ab127969ce0ed365a33471c38018de4/specs/wingpanel-indicator-ayatana/wingpanel-indicator-ayatana.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/decathorpe/staging/fedora-25-x86_64/00500794-wingpanel-indicator-ayatana/wingpanel-indicator-ayatana-2.0.2-2.fc25.src.rpm Description: An ayatana indicator for wingpanel. Fedora Account System Username: decathorpe koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=17315985 COPR build for f25 and rawhide: https://copr.fedorainfracloud.org/coprs/decathorpe/staging/build/500794/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1341099] Review Request: taskotron-trigger - Triggering Taskotron jobs on fedmsgs
https://bugzilla.redhat.com/show_bug.cgi?id=1341099 --- Comment #22 from Fedora Update System --- taskotron-trigger-0.4.3-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b175c3dd22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1341099] Review Request: taskotron-trigger - Triggering Taskotron jobs on fedmsgs
https://bugzilla.redhat.com/show_bug.cgi?id=1341099 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #21 from Fedora Update System --- taskotron-trigger-0.4.3-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-3eab8acf22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1412128] Review Request: libpreludedb - Prelude DB Library
https://bugzilla.redhat.com/show_bug.cgi?id=1412128 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- libpreludedb-3.1.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-7751501934 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1409334] Review Request: kdiagram - Powerful libraries (KChart, KGantt) for creating business diagrams
https://bugzilla.redhat.com/show_bug.cgi?id=1409334 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- kdiagram-2.6.0-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-72ffe34c75 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1409334] Review Request: kdiagram - Powerful libraries (KChart, KGantt) for creating business diagrams
https://bugzilla.redhat.com/show_bug.cgi?id=1409334 --- Comment #8 from Fedora Update System --- kdiagram-2.6.0-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1ab1227718 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413375] Review Request: lxqt-l10n - Translations for the LXQt desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1413375 --- Comment #4 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/lxqt-l10n -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1381935] Review Request: python-distro - Linux Distribution - a Linux OS platform information API
https://bugzilla.redhat.com/show_bug.cgi?id=1381935 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2016-10-18 07:31:20 |2017-01-17 17:51:18 --- Comment #22 from Fedora Update System --- python-distro-1.0.1-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1268380] Review Request: python-sphinx-bootstrap-theme - A sphinx theme that integrates the Bootstrap framework
https://bugzilla.redhat.com/show_bug.cgi?id=1268380 --- Comment #39 from Stuart Campbell --- Spec URL:https://raw.githubusercontent.com/stuartcampbell/rpm-packages/master/sphinx-theme-bootstrap/python-sphinx-bootstrap-theme.spec SRPM URL:https://copr-be.cloud.fedoraproject.org/results/sic/packages/fedora-26-x86_64/00500847-python-sphinx-bootstrap-theme/python-sphinx-bootstrap-theme-0.4.13-2.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414132] Review Request: wingpanel-indicator-datetime - Datetime Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1414132 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Flags||fedora-review? --- Comment #1 from Neal Gompa --- Taking this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414141] Review Request: wingpanel-indicator-bluetooth - Bluetooth Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1414141 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Flags||fedora-review? --- Comment #1 from Neal Gompa --- Taking this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414147] Review Request: wingpanel-indicator-ayatana - Ayatana Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1414147 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Flags||fedora-review? --- Comment #1 from Neal Gompa --- Taking this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414132] Review Request: wingpanel-indicator-datetime - Datetime Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1414132 Neal Gompa changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Neal Gompa --- APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414132] Review Request: wingpanel-indicator-datetime - Datetime Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1414132
--- Comment #2 from Neal Gompa ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[-]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later) (with incorrect FSF address)", "BSD (2
clause)", "LGPL (v3)", "Unknown or generated", "GPL (v3 or later)". 97
files have unknown license. Detailed output of licensecheck in
/home/makerpm/1414132-wingpanel-indicator-datetime/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/locale/rue, /usr/share/locale/ckb,
/usr/share/locale/rue/LC_MESSAGES, /usr/share/locale/ckb/LC_MESSAGES
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/locale/ckb,
/usr/share/locale/rue/LC_MESSAGES, /usr/share/locale/rue,
/usr/share/locale/ckb/LC_MESSAGES
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
wingpanel-indicator-datetime-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translati
[Bug 1414141] Review Request: wingpanel-indicator-bluetooth - Bluetooth Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1414141
--- Comment #2 from Neal Gompa ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[-]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (2 clause)", "LGPL (v2.1 or later)", "Unknown or
generated". 86 files have unknown license. Detailed output of
licensecheck in /home/makerpm/1414141-wingpanel-indicator-
bluetooth/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/locale/rue, /usr/share/locale/ckb,
/usr/share/locale/rue/LC_MESSAGES, /usr/share/locale/ckb/LC_MESSAGES
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/locale/ckb,
/usr/share/locale/rue/LC_MESSAGES, /usr/share/locale/rue,
/usr/share/locale/ckb/LC_MESSAGES
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
wingpanel-indicator-bluetooth-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x
[Bug 1414141] Review Request: wingpanel-indicator-bluetooth - Bluetooth Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1414141 Neal Gompa changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Neal Gompa --- APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414147] Review Request: wingpanel-indicator-ayatana - Ayatana Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1414147
--- Comment #2 from Neal Gompa ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[-]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later) (with incorrect FSF address)", "BSD (2
clause)", "LGPL (v2.1 or later)", "Unknown or generated". 12 files
have unknown license. Detailed output of licensecheck in
/home/makerpm/1414147-wingpanel-indicator-ayatana/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
wingpanel-indicator-ayatana-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package h
[Bug 1414147] Review Request: wingpanel-indicator-ayatana - Ayatana Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1414147 Neal Gompa changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Neal Gompa --- APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds
https://bugzilla.redhat.com/show_bug.cgi?id=1403423
--- Comment #13 from Neal Gompa ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL", "GPL (v2) (with incorrect FSF address)", "GPL (v3 or
later)", "Unknown or generated", "GPL (v2 or later)", "BSL (v1.0)",
"zlib/libpng", "BSD (3 clause)", "MIT/X11 (BSD like)", "GPL (v2 or
later) (with incorrect FSF address)", "BSD (2 clause)", "LGPL (v2.1 or
later)". 571 files have unknown license. Detailed output of
licensecheck in
/home/makerpm/1403423-visualboyadvance-m/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/vbam(vbam-gtk)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in visualboyadvance-m
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No
[Bug 1403423] Review Request: visualboyadvance-m - High compatibility Gameboy Advance Emulator combining VBA builds
https://bugzilla.redhat.com/show_bug.cgi?id=1403423 Neal Gompa changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #14 from Neal Gompa --- Looks good to me. PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1413434] Review Request: php-gettext-languages - Generate gettext language lists with plural rules
https://bugzilla.redhat.com/show_bug.cgi?id=1413434 Randy Barlow changed: What|Removed |Added Blocks||1414216 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1414216 [Bug 1414216] Review Request: php-gettext-gettext - PHP gettext manager -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1414216] Review Request: php-gettext-gettext - PHP gettext manager
https://bugzilla.redhat.com/show_bug.cgi?id=1414216 Randy Barlow changed: What|Removed |Added Depends On||1413434 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1413434 [Bug 1413434] Review Request: php-gettext-languages - Generate gettext language lists with plural rules -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
