[Bug 1431298] Review Request: php-symfony3 - Symfony PHP framework ( version 3)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431298

James Hogarth  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431298] Review Request: php-symfony3 - Symfony PHP framework ( version 3)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431298

James Hogarth  changed:

   What|Removed |Added

 CC||james.hoga...@gmail.com
   Assignee|nob...@fedoraproject.org|james.hoga...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - Mock Object library for PHPUnit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420378



--- Comment #9 from Remi Collet  ---
Thanks for the review.

New packages requested.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420381] Review Request: phpunit6 - The PHP Unit Testing framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420381



--- Comment #7 from Remi Collet  ---
Thanks for the review.

New packages requested.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - Support for managing GNOME Shell Extensions through web browsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #34 from Yuri Konotopov  ---
(In reply to Pete Walter from comment #31)
> > >Does the FF plugin have to be placed in /usr/lib64/mozilla for a 64bit 
> > >system? or will it work just as fine in /usr/lib/mozilla? If it needs the 
> > >arched folder, you can ignore this error, if it doesn't, please change 
> > >this to a noarch package.
> 
> Yes, it needs to be in /usr/lib64/mozilla.
> 

64 bit Firefox should work fine with manifest file placed in /usr/lib/mozilla

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429804] Review Request: parfait - Java libraries for Performance Co-Pilot (PCP)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429804

gil cattaneo  changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429804] Review Request: parfait - Java libraries for Performance Co-Pilot (PCP)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429804

gil cattaneo  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429803] Review Request: unitsofmeasurement - Java APIs and services for handling units and quantities (JSR 363)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429803

gil cattaneo  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429804] Review Request: parfait - Java libraries for Performance Co-Pilot (PCP)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429804

gil cattaneo  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429803] Review Request: unitsofmeasurement - Java APIs and services for handling units and quantities (JSR 363)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429803

gil cattaneo  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429804] Review Request: parfait - Java libraries for Performance Co-Pilot (PCP)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429804

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it



--- Comment #1 from gil cattaneo  ---
These ifile are not admitted in Fedora. Please, remove

BuildRequires: maven-shade-plugin

%pom_remove_plugin -r :maven-shade-plugin

pushd parfait-agent/target
install -m 644 parfait-agent-jar-with-dependencies.jar \
%{buildroot}%{_javadir}/parfait/parfait.jar
popd
# special install of with-all-dependencies sample jar files
for example in acme sleep counter
do
pushd examples/${example}/target
install -m 644 example-${example}-jar-with-dependencies.jar \
%{buildroot}%{_javadir}/parfait/${example}.jar
popd
done

Please, remove also:
"Requires: java-headless >= 1.8" already listed as requirement by our java
tools by default
"%dir %{_javadir}/parfait" already listed in 

"Group: ..." not MORE necessary

Please, change "%global disable_dropwizard 1" with "%bcond_with metrics". and
%if !%{disable_dropwizard}
BuildRequires: mvn(com.codahale.metrics:metrics-core)
%endif

with

%if %{with metrics}
BuildRequires: mvn(com.codahale.metrics:metrics-core)
%endif

and

%if %{disable_dropwizard}
%pom_disable_module parfait-dropwizard
%endif

with

%if %{without metrics}
%pom_disable_module parfait-dropwizard
%endif

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 923669] Review Request: tex-prerex-bin - Interactive editor for prerequisite charts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=923669

Orion Poplawski  changed:

   What|Removed |Added

 CC||jn...@redhat.com,
   ||or...@cora.nwra.com
  Flags||needinfo?(jn...@redhat.com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 769958] Review Request: eqp - Automated theorem prover for first-order equational logic

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=769958

Orion Poplawski  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||or...@cora.nwra.com
   Assignee|nob...@fedoraproject.org|or...@cora.nwra.com
  Flags||fedora-review?



--- Comment #14 from Orion Poplawski  ---
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18312354

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
- Perhaps an example could be run in %check as a test?

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 48 files have unknown license. Detailed
 output of licensecheck in
 /export/home/orion/redhat/769958-eqp/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 71680 bytes in 27 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not 

[Bug 1429803] Review Request: unitsofmeasurement - Java APIs and services for handling units and quantities (JSR 363)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429803

gil cattaneo  changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429803] Review Request: unitsofmeasurement - Java APIs and services for handling units and quantities (JSR 363)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429803

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it



--- Comment #1 from gil cattaneo  ---
unitsofmeasurement-unit-api package is already available in our repositories
https://admin.fedoraproject.org/pkgdb/package/rpms/unit-api
Please, simplifies the name of the packages without "unitsofmeasurement-" and
OPEN for each of your packages a new bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 808097] Review Request: ima-tests - IMA Linux Test Project(LTP) test programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=808097

Orion Poplawski  changed:

   What|Removed |Added

 CC||or...@cora.nwra.com,
   ||pwout...@redhat.com
  Flags||needinfo?(pwouters@redhat.c
   ||om)



--- Comment #5 from Orion Poplawski  ---
This is quite stale - many aspects could be cleaned up (no %clean, %defattr,
etc).  Please update if you wish to continue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 807432] Review Request: python-tate-bilinear-pairing - A Python 2/ 3 library for calculating Tate bilinear pairing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=807432

Orion Poplawski  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 CC||or...@cora.nwra.com
 Resolution|--- |NOTABUG
Last Closed|2015-07-21 09:28:21 |2017-03-10 22:48:14



--- Comment #17 from Orion Poplawski  ---
Reopen if you wish to continue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431139] Review Request: perl-Mango - Pure-Perl non-blocking I/ O MongoDB driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431139

Orion Poplawski  changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #1 from Orion Poplawski  ---
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18311944

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

- ExcludeArch is justified and documented

- Looks like requires/provides are not being generated due to the lack of
  BR: perl-generators

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 20 files have unknown license. Detailed
 output of licensecheck in /export/home/orion/redhat/1431139-perl-
 Mango/licensecheck.txt
[x]: Package must own all directories that it creates.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Perl:
[x]: Package contains the mandatory BuildRequires and Requires:.
[x]: CPAN urls should be non-versioned.

= SHOULD items =

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the 

[Bug 1343710] Review Request: chrome-gnome-shell - Support for managing GNOME Shell Extensions through web browsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #33 from Jeremy Newton  ---
More inline comments:

(In reply to Pete Walter from comment #31)
> Thanks Jeremy! I've put my replies inline.
> 
> 
> (In reply to Jeremy Newton from comment #29)
> > Package Review
> > ==
> > 
> > Legend:
> > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> > [ ] = Manual review needed
> > 
> > 
> > Issues:
> > ===
> > - gtk-update-icon-cache is invoked in %postun and %posttrans if package
> >   contains icons.
> >   Note: icons in chrome-gnome-shell
> >   See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
> > 
> > >Please add the following (explained in the wiki):
> > 
> > %post
> > /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
> > 
> > %postun
> > if [ $1 -eq 0 ] ; then
> > /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null
> > /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || 
> > :
> > fi
> > 
> > %posttrans
> > /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
> 
> This is not needed these days. gtk3 includes a file trigger that does it
> automatically.

Are you not including epel packages? Firefox and chromium should be provided
for all branches.

> 
> 
> > - Package installs a %{name}.desktop using desktop-file-install or desktop-
> >   file-validate if there is such a file.
> > 
> > >You need to add this:
> > 
> > %check
> > desktop-file-validate
> > %{_datadir}/applications/org.gnome.ChromeGnomeShell.desktop
> 
> Done.
> 
> 
> > = MUST items =
> > 
> > Generic:
> > [x]: Package is licensed with an open-source compatible license and meets
> >  other legal requirements as defined in the legal section of Packaging
> >  Guidelines.
> > [x]: License field in the package spec file matches the actual license.
> >  Note: Checking patched sources after %prep for licenses. Licenses
> >  found: "GPL (v3 or later)", "Unknown or generated". 73 files have
> >  unknown license.
> > [!]: Package requires other packages for directories it uses.
> >  Note: No known owner of /usr/share/icons/gnome/128x128,
> >  /usr/share/icons/gnome/128x128/apps
> > [!]: Package must own all directories that it creates.
> >  Note: Directories without known owners:
> >  /usr/share/icons/gnome/128x128/apps, /usr/share/icons/gnome,
> >  /usr/share/icons/gnome/16x16/apps, /usr/share/dbus-1,
> >  /usr/share/icons/gnome/128x128, /usr/share/dbus-1/services,
> >  /usr/share/icons/gnome/48x48, /usr/share/icons/gnome/16x16,
> >  /usr/share/icons/gnome/48x48/apps
> > 
> > >This is due to a missing requires, please add:
> > BuildRequires:  hicolor-icon-theme
> > BuildRequires:  gnome-icon-theme
> > BuildRequires:  dbus
> > Requires:   dbus
> > Requires:   gnome-icon-theme
> > Requires:   hicolor-icon-theme
> 
> Thanks. I added the Requires. The BuildRequires aren't needed here.

Fair enough.

> 
> 
> > [!]: Package does not own files or directories owned by other packages.
> >  Note: Dirs in package are owned also by: /usr/lib64/mozilla(mozilla-
> >  filesystem), /etc/opt(filesystem)
> > 
> > >Please remove the following line, this dir should not be owned by this 
> > >package:
> > %dir %{_sysconfdir}/opt
> 
> Done.
> 
> 
> > >And change the following:
> > %{_sysconfdir}/chromium/
> > %{_libdir}/mozilla/
> > %{_sysconfdir}/opt/chrome/
> > >to:
> > %{_sysconfdir}/chromium/*
> > %{_libdir}/mozilla/*
> > %{_sysconfdir}/opt/chrome/*
> 
> Sorry, the suggested chrome and chromium directory changes are wrong and
> would result in unowned directories. Fixed the %{_libdir}/mozilla issue and
> added a dep on mozilla-filesystem instead.

Since %{_sysconfdir}/opt/chrome/ is from a thirdparty package, that's probably
fine, but %{_sysconfdir}/chromium/ is owned by the fedora chromium package...
perhaps we should bug the maintainer to add a "chromium-filesystem" subpackage:

$ dnf whatprovides /etc/chromium
Last metadata expiration check: 5 days, 1:48:38 ago on Sun Mar  5 20:02:08
2017.
chrome-gnome-shell-8.2-1.fc25.x86_64 : Support for managing GNOME Shell
 : Extensions through web browsers
Repo: @System

chromium-56.0.2924.87-3.fc25.x86_64 : A WebKit (Blink) powered web browser
Repo: updates

chromium-53.0.2785.116-1.fc25.x86_64 : A WebKit (Blink) powered web browser
Repo: fedora

> 
> 
> > [x]: %build honors applicable compiler flags or justifies otherwise.
> > [x]: Package contains no bundled libraries without FPC exception.
> > [x]: Changelog in prescribed format.
> > [x]: Sources contain only permissible code or content.
> > [-]: Development files must be in a -devel package
> > [-]: Package uses nothing in %doc for runtime.
> > [x]: Package consistently uses macros (instead of hard-coded directory
> >  names).
> > [x]: Package is named according to the 

[Bug 1431139] Review Request: perl-Mango - Pure-Perl non-blocking I/ O MongoDB driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431139

Orion Poplawski  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||or...@cora.nwra.com
   Assignee|nob...@fedoraproject.org|or...@cora.nwra.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420100] Review Request: perl-Mail-Transport - Email message exchange code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420100

Tom "spot" Callaway  changed:

   What|Removed |Added

  Flags|needinfo?(tcallawa@redhat.c |
   |om) |



--- Comment #6 from Tom "spot" Callaway  ---
Sorry. Been traveling.

All non-EPEL items fixed. 

New SRPM:
https://spot.fedorapeople.org/perl-Mail-Transport-3.000-2.fc26.src.rpm
New SPEC: https://spot.fedorapeople.org/perl-Mail-Transport.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430132] Review Request: golang-github-google-go-github - Go library for accessing the GitHub API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430132



--- Comment #5 from Ed Marshall  ---
Spec URL:
https://fedorapeople.org/cgit/logic/public_git/golang-github-google-go-github.git/plain/golang-github-google-go-github.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/860/18310860/golang-github-google-go-github-0-0.1.git553fda4.fc27.src.rpm

You know what, lets just go with the latest version; it's arguably more
correct, and I'll just open blockers elsewhere as I go if needed. I also
figured out what was causing the test failure (mailcap buildreq; part of me
wonders if golang itself shouldn't have a requires for mailcap), so unit tests
are enabled in this build.

Scratch build is at:
https://koji.fedoraproject.org/koji/taskinfo?taskID=18310859

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431195] Review Request: rakudo - Perl 6 compiler implementation that runs on MoarVM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431195

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #3 from Fedora Update System  ---
rakudo-0.2017.01-5.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-cdf8ace085

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430814] Review Request: capnet-assist - Captive Portal Assistant for Pantheon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430814

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
capnet-assist-0.2.1-1.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f0fb2e7269

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430131] Review Request: python-pamela - Python PAM interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430131

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
python-pamela-0.3.0-1.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-7e02be336e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426994] Review Request: rhythmbox-alternative-toolbar - Rhythmbox plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426994

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
rhythmbox-alternative-toolbar-0.17.3-4.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f2479ef43b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431300] New: Review Request: python-dodgy - Searches for dodgy looking lines in Python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431300

Bug ID: 1431300
   Summary: Review Request: python-dodgy - Searches for dodgy
looking lines in Python code
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: or...@cora.nwra.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://www.cora.nwra.com/~orion/fedora/python-dodgy.spec
SRPM URL:
https://www.cora.nwra.com/~orion/fedora/python-dodgy-0.1.9-1.el7.src.rpm
Description:
Dodgy is a very basic tool to run against your codebase to search for "dodgy"
looking values. It is a series of simple regular expressions designed to
detect things such as accidental SCM diff checkins, or passwords or secret
keys hard coded into files.

While this is primarily aimed at open source projects (for whom a publicly
available secret key is pretty dangerous), it can also be used in private
projects, with the caveat that it will point out things which are not a
problem for private projects and is not configurable enough currently to
change that.

Another note - this tool is probably best run pre-commit, since it will
hopefully prevent dodgy things being checked in.

Fedora Account System Username: orion

https://koji.fedoraproject.org/koji/taskinfo?taskID=18309627

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430481] Review Request: python-testpath - Test utilities for code working with files and commands

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430481

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
python-testpath-0.3-1.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-3b352cd9d8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1344936] Review Request: golang-github-kyokomi-emoji - Emoji terminal output for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344936

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
golang-github-kyokomi-emoji-1.5-3.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-afc97ed3c7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386625] Review Request: gotun - Tool to run tests on OpenStack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386625

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
gotun-0-0.1.gitccf43e2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-96e4cc8115

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429272] Re-Review Request: zanata-platform - Zanata the web-based translation platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429272



--- Comment #8 from Fedora Update System  ---
zanata-platform-4.1.1-2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-91b890323f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424839] Review Request: php-rmccue-requests - Requests for PHP is a humble HTTP request library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424839



--- Comment #13 from Fedora Update System  ---
php-rmccue-requests-1.7.0-2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-3144a999c7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426851] Review Request: golang-github-bep-inflect - Go library to perform word transformations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426851

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
golang-github-bep-inflect-0-0.2.gitb896c45.fc26 has been pushed to the Fedora
26 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b90d6ec013

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426954] Review Request: golang-github-chaseadamsio-goorgeous - Org to HTML Parser written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426954

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
golang-github-chaseadamsio-goorgeous-0-0.3.git054aba6.fc26 has been pushed to
the Fedora 26 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-43ef32dfe3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427990] Review Request: kf5-kirigami2 - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427990

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---
   Keywords||Reopened



--- Comment #10 from Fedora Update System  ---
kf5-kirigami2-2.0.0-2.fc26, plasma-discover-5.9.3-2.fc26 has been pushed to the
Fedora 26 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1156554295

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426949] Review Request: golang-github-fsnotify-fsnotify - Cross-platform file system notifications for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426949

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
golang-github-fsnotify-fsnotify-1.4.2-1.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-be13ea67cf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426987] Review Request: golang-github-bep-gitmap - Create map from filename to info object from revision of a repo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426987

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
golang-github-bep-gitmap-0-0.1.gitdcb907b.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-eeef8a4567

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426964] Review Request: golang-github-miekg-mmark - A powerful markdown processor in Go geared towards the IETF

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426964

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
golang-github-miekg-mmark-1.3.4-1.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-52e6fc64e0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426885] Review Request: golang-github-spf13-fsync - fsync keeps files and directories in sync, golang library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426885

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
golang-github-spf13-fsync-0-0.1.gitcb2da33.fc26 has been pushed to the Fedora
26 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6197309524

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410408] Review Request: golang-github-circonus-labs-circonus-gometrics - A go implementation of metrics reporting for Circonus

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410408



--- Comment #9 from Fedora Update System  ---
golang-github-circonus-labs-circonus-gometrics-0-0.1.gitd17a842.fc26 has been
pushed to the Fedora 26 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-42161b7ba6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1425960] Review Request: intel-mpi-benchmarks - Intel MPI benchmarks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1425960

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
intel-mpi-benchmarks-2017-2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2b4cc51db3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428912] Review Request: php-sebastian-exporter3 - Export PHP variables for visualization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428912

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
php-sebastian-exporter3-3.0.0-1.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-3112332061

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428565] Review Request: golang-github-sasha-s-go-deadlock - Online deadlock detection in go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428565

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
golang-github-sasha-s-go-deadlock-0.1.0-0.1.git3410008.fc26 has been pushed to
the Fedora 26 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9a17d53c03

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1206883] Review Request: golang-github-PuerkitoBio-urlesc - Package urlesc implements query escaping as per RFC 3986.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1206883

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
golang-github-PuerkitoBio-urlesc-0-0.3.git5bd2802.fc26 has been pushed to the
Fedora 26 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-410c063af1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1206877] Review Request: golang-github-dchest-cssmin - Go port of Ryan Grove's cssmin.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1206877

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
golang-github-dchest-cssmin-0-0.3.gitfb8d9b4.fc26 has been pushed to the Fedora
26 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6411360055

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428908] Review Request: php-sebastian-recursion-context3 - Recursively process PHP variables

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428908

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
php-sebastian-recursion-context3-3.0.0-1.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b42c0f5321

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410392] Review Request: golang-github-hashicorp-go-retryablehttp - Retryable HTTP client in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410392



--- Comment #8 from Fedora Update System  ---
golang-github-hashicorp-go-retryablehttp-0-0.1.git6e85be8.fc26 has been pushed
to the Fedora 26 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f5f1f732ae

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410378] Review Request: golang-github-hashicorp-hil - HIL is a small embedded language for string interpolations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410378



--- Comment #11 from Fedora Update System  ---
golang-github-hashicorp-hil-0-0.1.git1e86c6b.fc26 has been pushed to the Fedora
26 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b18c66de30

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428437] Review Request: golang-github-bkaradzic-go-lz4 - Port of LZ4 lossless compression algorithm to Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428437



--- Comment #13 from Fedora Update System  ---
golang-github-bkaradzic-go-lz4-1.0.0-1.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-99747f14b8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410394] Review Request: golang-github-mitchellh-go-wordwrap - A Go library for wrapping words in a string

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410394



--- Comment #12 from Fedora Update System  ---
golang-github-mitchellh-go-wordwrap-0-0.1.gitad45545.fc26 has been pushed to
the Fedora 26 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-3376ec0f81

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410393] Review Request: golang-github-hashicorp-go-sockaddr - IP Address/ UNIX Socket convenience functions for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410393



--- Comment #13 from Fedora Update System  ---
golang-github-hashicorp-go-sockaddr-0-0.1.gitaf174a6.fc26 has been pushed to
the Fedora 26 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-8e2afb78dd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410356] Review Request: golang-github-circonus-labs-circonusllhist - A go implementation of Circonus log-linear histograms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410356



--- Comment #12 from Fedora Update System  ---
golang-github-circonus-labs-circonusllhist-0-0.1.git365d370.fc26 has been
pushed to the Fedora 26 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5ad922e474

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410401] Review Request: golang-github-mitchellh-copystructure - Go library for deep copying values in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410401



--- Comment #15 from Fedora Update System  ---
golang-github-mitchellh-copystructure-0-0.1.gitcdac825.fc26 has been pushed to
the Fedora 26 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-902ba45a7d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431298] Review Request: php-symfony3 - Symfony PHP framework ( version 3)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431298

Shawn Iwinski  changed:

   What|Removed |Added

 CC||fed...@famillecollet.com
  Alias||php-symfony3



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431298] New: Review Request: php-symfony3 - Symfony PHP framework ( version 3)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431298

Bug ID: 1431298
   Summary: Review Request: php-symfony3 - Symfony PHP framework
(version 3)
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sh...@iwin.ski
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/ddc275ca89d888fdc7e7f54b2117b498c6cd2b1e/php-symfony3/php-symfony3.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-symfony3-3.2.6-1.fc25.src.rpm

Description: Symfony PHP framework (version 3)

Fedora Account System Username: siwinski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - Support for managing GNOME Shell Extensions through web browsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #31 from Pete Walter  ---
Thanks Jeremy! I've put my replies inline.


(In reply to Jeremy Newton from comment #29)
> Package Review
> ==
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
> 
> 
> Issues:
> ===
> - gtk-update-icon-cache is invoked in %postun and %posttrans if package
>   contains icons.
>   Note: icons in chrome-gnome-shell
>   See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
> 
> >Please add the following (explained in the wiki):
> 
> %post
> /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
> 
> %postun
> if [ $1 -eq 0 ] ; then
> /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null
> /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
> fi
> 
> %posttrans
> /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :

This is not needed these days. gtk3 includes a file trigger that does it
automatically.


> - Package installs a %{name}.desktop using desktop-file-install or desktop-
>   file-validate if there is such a file.
> 
> >You need to add this:
> 
> %check
> desktop-file-validate
> %{_datadir}/applications/org.gnome.ChromeGnomeShell.desktop

Done.


> = MUST items =
> 
> Generic:
> [x]: Package is licensed with an open-source compatible license and meets
>  other legal requirements as defined in the legal section of Packaging
>  Guidelines.
> [x]: License field in the package spec file matches the actual license.
>  Note: Checking patched sources after %prep for licenses. Licenses
>  found: "GPL (v3 or later)", "Unknown or generated". 73 files have
>  unknown license.
> [!]: Package requires other packages for directories it uses.
>  Note: No known owner of /usr/share/icons/gnome/128x128,
>  /usr/share/icons/gnome/128x128/apps
> [!]: Package must own all directories that it creates.
>  Note: Directories without known owners:
>  /usr/share/icons/gnome/128x128/apps, /usr/share/icons/gnome,
>  /usr/share/icons/gnome/16x16/apps, /usr/share/dbus-1,
>  /usr/share/icons/gnome/128x128, /usr/share/dbus-1/services,
>  /usr/share/icons/gnome/48x48, /usr/share/icons/gnome/16x16,
>  /usr/share/icons/gnome/48x48/apps
> 
> >This is due to a missing requires, please add:
> BuildRequires:  hicolor-icon-theme
> BuildRequires:  gnome-icon-theme
> BuildRequires:  dbus
> Requires:   dbus
> Requires:   gnome-icon-theme
> Requires:   hicolor-icon-theme

Thanks. I added the Requires. The BuildRequires aren't needed here.


> [!]: Package does not own files or directories owned by other packages.
>  Note: Dirs in package are owned also by: /usr/lib64/mozilla(mozilla-
>  filesystem), /etc/opt(filesystem)
> 
> >Please remove the following line, this dir should not be owned by this 
> >package:
> %dir %{_sysconfdir}/opt

Done.


> >And change the following:
> %{_sysconfdir}/chromium/
> %{_libdir}/mozilla/
> %{_sysconfdir}/opt/chrome/
> >to:
> %{_sysconfdir}/chromium/*
> %{_libdir}/mozilla/*
> %{_sysconfdir}/opt/chrome/*

Sorry, the suggested chrome and chromium directory changes are wrong and would
result in unowned directories. Fixed the %{_libdir}/mozilla issue and added a
dep on mozilla-filesystem instead.


> [x]: %build honors applicable compiler flags or justifies otherwise.
> [x]: Package contains no bundled libraries without FPC exception.
> [x]: Changelog in prescribed format.
> [x]: Sources contain only permissible code or content.
> [-]: Development files must be in a -devel package
> [-]: Package uses nothing in %doc for runtime.
> [x]: Package consistently uses macros (instead of hard-coded directory
>  names).
> [x]: Package is named according to the Package Naming Guidelines.
> [-]: Package does not generate any conflict.
> [x]: Package obeys FHS, except libexecdir and /usr/target.
> [x]: If the package is a rename of another package, proper Obsoletes and
>  Provides are present.
> [!]: Requires correct, justified where necessary.
> 
> >See above, some requires are missing.
> 
> [x]: Spec file is legible and written in American English.
> [-]: Package contains systemd file(s) if in need.
> [-]: Useful -debuginfo package or justification otherwise.
> [-]: Package is not known to require an ExcludeArch tag.
> [x]: Package complies to the Packaging Guidelines
> [x]: Package successfully compiles and builds into binary rpms on at least
>  one supported primary architecture.
> [x]: Package installs properly.
> [x]: Rpmlint is run on all rpms the build produces.
>  Note: There are rpmlint messages (see attachment).
> [x]: If (and only if) the source package includes the text of the
>  license(s) in its own file, then that file, containing the text of the
>  license(s) for the package is included in %license.
> [x]: All build dependencies are 

[Bug 1343710] Review Request: chrome-gnome-shell - Support for managing GNOME Shell Extensions through web browsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #32 from Pete Walter  ---
* Fri Mar 10 2017 Pete Walter  - 8.2-2
- Package review fixes (#1343710)
- Validate the desktop file
- Don't own /etc/opt directory
- Depend on mozilla-filesystem instead of co-owning mozilla directories
- Depend on dbus and gnome-icon-theme/hicolor-icon-theme for directory
  ownership

Spec URL: https://pwalter.fedorapeople.org/chrome-gnome-shell.spec
SRPM URL:
https://pwalter.fedorapeople.org/chrome-gnome-shell-8.2-2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389985] Review Request: http-builder - HTTP client framework for Groovy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389985
Bug 1389985 depends on bug 1389981, which changed state.

Bug 1389981 Summary: signpost-core: enable signpost-commonshttp4 sub module
https://bugzilla.redhat.com/show_bug.cgi?id=1389981

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420381] Review Request: phpunit6 - The PHP Unit Testing framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420381

Shawn Iwinski  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Shawn Iwinski  ---
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required
[!]: Buildroot is not present
 Note: Buildroot: present but not needed

Remove EPEL 5 bits after initial import



[!]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/php/PHPUnit6/Framework(php-phpunit-mock-objects4),
 /usr/share/php/PHPUnit6(php-phpunit-mock-objects4)

Fix after initial import



No blockers

= APPROVED =

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420381] Review Request: phpunit6 - The PHP Unit Testing framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420381



--- Comment #5 from Shawn Iwinski  ---
Created attachment 1262083
  --> https://bugzilla.redhat.com/attachment.cgi?id=1262083=edit
fedora-review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug
1420381
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 498390] Review Request: rakudo - Perl 6 compiler implementation that runs on MoarVM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=498390

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420381] Review Request: phpunit6 - The PHP Unit Testing framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420381



--- Comment #4 from Shawn Iwinski  ---
Created attachment 1262082
  --> https://bugzilla.redhat.com/attachment.cgi?id=1262082=edit
phpcompatinfo-lib.log

phpCompatInfo version 5.0.4 DB version 1.17.0 built Jan 24 2017 10:56:54 CET

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 498390] Review Request: rakudo - Perl 6 compiler implementation that runs on MoarVM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=498390



--- Comment #59 from Fedora Update System  ---
rakudo-0.2017.01-5.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5476a3b710

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420381] Review Request: phpunit6 - The PHP Unit Testing framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420381



--- Comment #3 from Shawn Iwinski  ---
Created attachment 1262081
  --> https://bugzilla.redhat.com/attachment.cgi?id=1262081=edit
phpcompatinfo-full.log

phpCompatInfo version 5.0.4 DB version 1.17.0 built Jan 24 2017 10:56:54 CET

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420381] Review Request: phpunit6 - The PHP Unit Testing framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420381

Shawn Iwinski  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||sh...@iwin.ski
   Assignee|nob...@fedoraproject.org|sh...@iwin.ski
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431195] Review Request: rakudo - Perl 6 compiler implementation that runs on MoarVM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431195

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431195] Review Request: rakudo - Perl 6 compiler implementation that runs on MoarVM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431195



--- Comment #2 from Fedora Update System  ---
rakudo-0.2017.01-5.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-cdf8ace085

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - Mock Object library for PHPUnit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420378

Shawn Iwinski  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Shawn Iwinski  ---
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required

Remove EPEL 5 bits after initial import



[!]: Spec file according to URL is the same as in SRPM.
 Note: Spec file as given by url is not the same as in SRPM (see
 attached diff).

Diffs just turning on bootstrap.



No blockers

= APPROVED =

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - Mock Object library for PHPUnit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420378

Shawn Iwinski  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |php-phpunit-mock-objects4 - |php-phpunit-mock-objects4 -
   |ock Object library for  |Mock Object library for
   |PHPUnit |PHPUnit



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - ock Object library for PHPUnit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420378



--- Comment #7 from Shawn Iwinski  ---
Created attachment 1262078
  --> https://bugzilla.redhat.com/attachment.cgi?id=1262078=edit
fedora-review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug
1420378
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - ock Object library for PHPUnit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420378



--- Comment #6 from Shawn Iwinski  ---
Created attachment 1262077
  --> https://bugzilla.redhat.com/attachment.cgi?id=1262077=edit
phpcompatinfo-lib.log

phpCompatInfo version 5.0.4 DB version 1.17.0 built Jan 24 2017 10:56:54 CET

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - ock Object library for PHPUnit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420378



--- Comment #5 from Shawn Iwinski  ---
Created attachment 1262076
  --> https://bugzilla.redhat.com/attachment.cgi?id=1262076=edit
phpcompatinfo-full.log

phpCompatInfo version 5.0.4 DB version 1.17.0 built Jan 24 2017 10:56:54 CET

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1420378] Review Request: php-phpunit-mock-objects4 - ock Object library for PHPUnit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1420378

Shawn Iwinski  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|sh...@iwin.ski
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427634] Review Request: syncthing - Continuous File Synchronization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427634



--- Comment #9 from Fabio Valentini  ---
Since some of the build dependencies for the syncthing server tools require
further investigation (build failures for some architectures) - and ~10 more
package reviews, if/once everything works out - I decided *not* to build the
server tools if not using the bundled sources.

At the moment, fedora builds use the system golang libraries, whereas EPEL
builds use the bundled / vendored sources (and the server tools are built too).
With this approach, I got syncthing to build on both fedora rawhide (all
arches) and EPEL 7 (on x86_64 and aarch64; only those have golang).

koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=18307514

koji scratch build for EPEL7:  
https://koji.fedoraproject.org/koji/taskinfo?taskID=18307609

The .spec and .src.rpm file links from Comment 8 now point to the working
version. I also needed to do some cleanup of empty files and stuff after the
tests to make rpmlint happy - I suspect this might break some tests in the
installed -unit-test-devel package, though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419366] Review Request: pybind11 - Seamless operability between C++11 and Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419366



--- Comment #20 from Fedora Update System  ---
psi4-1.0-2.2118f2fgit.fc25 pybind11-2.0.1-5.fc25 has been submitted as an
update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-096890604d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419366] Review Request: pybind11 - Seamless operability between C++11 and Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419366

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419366] Review Request: pybind11 - Seamless operability between C++11 and Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419366



--- Comment #21 from Fedora Update System  ---
psi4-1.0-2.2118f2fgit.fc24 pybind11-2.0.1-5.fc24 has been submitted as an
update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-31ced2cf47

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426961] Review Request: nodejs-bufferutil - WebSocket buffer utils

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426961



--- Comment #3 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-bufferutil

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426961] Review Request: nodejs-bufferutil - WebSocket buffer utils

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426961



--- Comment #2 from Ben Rosser  ---
Thanks for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1412264] Re-Review request: python2-docs - Documentation for the Python 2 programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1412264

Charalampos Stratakis  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||python2-docs-2.7.13-1.fc26
 Resolution|--- |RAWHIDE
Last Closed||2017-03-10 12:37:40



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427634] Review Request: syncthing - Continuous File Synchronization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427634
Bug 1427634 depends on bug 1431054, which changed state.

Bug 1431054 Summary: Review Request: golang-github-AudriusButkevicius-cli - 
Small package for building command line apps in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1431054

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DEFERRED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431054] Review Request: golang-github-AudriusButkevicius-cli - Small package for building command line apps in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431054

Fabio Valentini  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DEFERRED
Last Closed||2017-03-10 12:00:18



--- Comment #1 from Fabio Valentini  ---
Nevermind, one of the other dependencies of the discovery server fails to build
on most arches, so I'll just not build stdiscosrv, strelaysrv and
strelaypoolsrv right now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1323128] Review Request: python-virtualenv-api - An API for virtualenv/pip

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323128

Orion Poplawski  changed:

   What|Removed |Added

 CC||or...@cora.nwra.com



--- Comment #11 from Orion Poplawski  ---
Michal - would you be interested in maintaining this in EPEL7?  With the
addition of https://bugzilla.redhat.com/show_bug.cgi?id=1431235 all that is
needed is:

s/python3-/python%{python3_pkgversion}-/
s/python2-virtualenv/python-virtualenv/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1345887] Review Request: golang-github-yosssi-ace - HTML template engine for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1345887



--- Comment #10 from Olivier Lemasle  ---
Here is the new package spec and SRPM:

Spec URL: https://olem.fedorapeople.org/reviews/golang-github-yosssi-ace.spec
SRPM URL:
https://olem.fedorapeople.org/reviews/golang-github-yosssi-ace-0.0.5-2.fc25.src.rpm

Note that it depends on golang-github-yosssi-gohtml.

Rpmlint (installed packages)

golang-github-yosssi-ace.x86_64: W: ldd-failed /usr/bin/ace
golang-github-yosssi-ace.x86_64: E: statically-linked-binary /usr/bin/ace
golang-github-yosssi-ace.x86_64: W: no-manual-page-for-binary ace
4 packages and 0 specfiles checked; 1 errors, 2 warnings.

There's a Rpmlint error, as the binary is statically linked, but the Packaging
Go Guidelines include this exception
(https://fedoraproject.org/wiki/PackagingDrafts/Go#Packaging_Binaries)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431235] New: Review Request: python3-virtualenv - Tool to create isolated Python environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431235

Bug ID: 1431235
   Summary: Review Request: python3-virtualenv - Tool to create
isolated Python environments
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: or...@cora.nwra.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://www.cora.nwra.com/~orion/fedora/python3-virtualenv.spec
SRPM URL:
https://www.cora.nwra.com/~orion/fedora/python3-virtualenv-15.0.3-1.el7.src.rpm
Description:
virtualenv is a tool to create isolated Python environments. virtualenv
is a successor to workingenv, and an extension of virtual-python. It is
written by Ian Bicking, and sponsored by the Open Planning Project. It is
licensed under an MIT-style permissive license.

Fedora Account System Username: orion

https://koji.fedoraproject.org/koji/taskinfo?taskID=18305367

This in an EPEL only package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1422203] Review Request: python-persist-queue - persistent queue for python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1422203

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1422203] Review Request: python-persist-queue - persistent queue for python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1422203



--- Comment #5 from Fedora Update System  ---
python-persist-queue-0.1.6-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1a702b2998

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426516] Review Request: takari-smart-builder - A replacement scheduling projects builds in a Maven multi-module build

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426516

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-10 10:20:34



--- Comment #5 from Fedora Update System  ---
takari-smart-builder-0.5.0-2.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431195] Review Request: rakudo - Perl 6 compiler implementation that runs on MoarVM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431195

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com
   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=498390
   Assignee|nob...@fedoraproject.org|ppi...@redhat.com
  Flags||fedora-review+



--- Comment #1 from Petr Pisar  ---
This package was already approved
. This is a new bug
report to satisfy release engineering tools.

Resolution: Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1425073] Review Request: php-zendframework-zendservice-recaptcha - Zend Framework ReCaptcha component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1425073



--- Comment #10 from Fedora Update System  ---
php-zendframework-zendservice-recaptcha-3.0.0-3.fc25 has been pushed to the
Fedora 25 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1360482] Review Request: nextcloud - a private, secure way to share and access files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360482



--- Comment #54 from Fedora Update System  ---
nextcloud-10.0.4-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 498390] Review Request: rakudo - Perl 6 compiler implementation that runs on MoarVM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=498390

Petr Pisar  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1431195



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1425658] Review Request: python-lit - Tool for running LLVM test suites

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1425658



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-lit

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430170] Review Request: python-matrix-synapse-ldap3 - Allows synapse to use LDAP as a password provider

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430170



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-matrix-synapse-ldap3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431020] Review Request: perl-Alien-pkgconf - Discover pkgconf and libpkgconf

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431020

Jitka Plesnikova  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|jples...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431020] Review Request: perl-Alien-pkgconf - Discover pkgconf and libpkgconf

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431020

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431195] New: Review Request: rakudo - Perl 6 compiler implementation that runs on MoarVM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431195

Bug ID: 1431195
   Summary: Review Request: rakudo -  Perl 6 compiler
implementation that runs on MoarVM
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: g...@zimt.uni-siegen.de
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: ftp://ftp.uni-siegen.de/pub/review/rakudo/spec/rakudo.spec
SRPM URL:
ftp://ftp.uni-siegen.de/pub/review/rakudo/srpm/rakudo-0.2017.01-5.fc25.src.rpm
Description:
Rakudo Perl 6, or just Rakudo, is an implementation of the
Perl 6 language specification. More information about Perl 6 is available
from . This package provides a Perl 6 compiler built for
MoarVM virtual machine.
Fedora Account System Username: gerd

This is a re-review. See the history at:
https://bugzilla.redhat.com/show_bug.cgi?id=498390

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1425073] Review Request: php-zendframework-zendservice-recaptcha - Zend Framework ReCaptcha component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1425073

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-10 09:50:38



--- Comment #9 from Fedora Update System  ---
php-zendframework-zendservice-recaptcha-3.0.0-3.fc24 has been pushed to the
Fedora 24 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1360482] Review Request: nextcloud - a private, secure way to share and access files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360482



--- Comment #53 from Fedora Update System  ---
nextcloud-10.0.4-1.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404305] Review Request: bcc - BPF Compiler Collection

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404305

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org