[Bug 1427185] Review Request: zypper - Command line package manager from SUSE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427185



--- Comment #2 from Neal Gompa  ---
I think I've fixed up this...

Spec URL: http://kinginuyasha.enanocms.org/downloads/zypper.spec
SRPM URL:
http://kinginuyasha.enanocms.org/downloads/zypper-1.13.21-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427182] Review Request: libzypp - A package management library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427182



--- Comment #3 from Neal Gompa  ---
I think I've fixed up this:

Spec URL: http://kinginuyasha.enanocms.org/downloads/libzypp.spec
SRPM URL:
http://kinginuyasha.enanocms.org/downloads/libzypp-16.6.1-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437036] Review Request: apache-logging-parent - Parent pom for Apache Logging Services projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437036

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags|fedora-review?  |fedora-review+



--- Comment #1 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
  Note: No javadoc subpackage present
  See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
 IGNORE
- Javadoc documentation files are generated and included in -javadoc
  subpackage
  Note: No javadoc subpackage present. Note: Javadocs are optional for
  Fedora versions >= 21
  See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
 IGNORE


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "*No copyright* Apache (v2.0)". 2 files
 have unknown license. Detailed output of licensecheck in
 /home/gil/1437036-apache-logging-parent/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
 Note: Maven packages do not need to (Build)Require jpackage-utils. It
 is pulled in by maven-local

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
 when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
 utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: 

[Bug 1437036] Review Request: apache-logging-parent - Parent pom for Apache Logging Services projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437036

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it
   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445



--- Comment #19 from Fedora Update System  ---
myman-0.7.0-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428926] Review Request: php-justinrainbow-json-schema5 - A library to validate a json schema

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428926



--- Comment #13 from Fedora Update System  ---
php-justinrainbow-json-schema5-5.2.0-1.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402445] Review Request: myman - text mode videogame

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402445



--- Comment #18 from Fedora Update System  ---
myman-0.7.0-1.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428926] Review Request: php-justinrainbow-json-schema5 - A library to validate a json schema

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428926

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-31 19:47:50



--- Comment #12 from Fedora Update System  ---
php-justinrainbow-json-schema5-5.2.0-1.fc24 has been pushed to the Fedora 24
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438090] Review Request: GetIt - Application to send HTTP requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438090

Bart Kessels  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438090] New: Review Request: GetIt - Application to send HTTP requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438090

Bug ID: 1438090
   Summary: Review Request: GetIt - Application to send HTTP
requests
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: bartkess...@outlook.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://raw.githubusercontent.com/bartkessels/getit/master/getit.spec
SRPM URL:
https://github.com/bartkessels/getit/blob/master/GetIt-1.1-1.fc25.src.rpm?raw=true
SRPM URL:
https://github.com/bartkessels/getit/blob/master/GetIt-1.1-1.fc26.src.rpm?raw=true
Description: Application to send HTTP requests to API's. Has the ability to
send form-data, files, headers and authentication (basic auth and digest auth)
Fedora Account System Username: bartkessels

This the first package I've ever created, so if anyone wants to help improve
please feel free to do so! Since I'm also the developer of the application the
bugs reported will be fixed as fast as possible.

The source of the application:
https://github.com/bartkessels/getit

The application has been tested on the koji build system (for both Fedora 25
and Fedora 26) and the results can be found here:
Fedora 25: https://koji.fedoraproject.org/koji/taskinfo?taskID=18703853
Fedora 26: https://koji.fedoraproject.org/koji/taskinfo?taskID=18703954

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437471] Review Request: golang-github-klauspost-reedsolomon - Reed-Solomon Erasure Coding in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437471

Fabio Valentini  changed:

   What|Removed |Added

 Blocks||1438089




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1438089
[Bug 1438089] Review Request: golang-github-xtaci-kcp-go - Production-Grade
Reliable-UDP Library for golang
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438089] Review Request: golang-github-xtaci-kcp-go - Production-Grade Reliable-UDP Library for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438089

Fabio Valentini  changed:

   What|Removed |Added

 Blocks||1427634
 Depends On||1437471




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1427634
[Bug 1427634] Review Request: syncthing - Continuous File Synchronization
https://bugzilla.redhat.com/show_bug.cgi?id=1437471
[Bug 1437471] Review Request: golang-github-klauspost-reedsolomon -
Reed-Solomon Erasure Coding in Go
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427634] Review Request: syncthing - Continuous File Synchronization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427634

Fabio Valentini  changed:

   What|Removed |Added

 Depends On||1438089




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1438089
[Bug 1438089] Review Request: golang-github-xtaci-kcp-go - Production-Grade
Reliable-UDP Library for golang
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438089] New: Review Request: golang-github-xtaci-kcp-go - Production-Grade Reliable-UDP Library for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438089

Bug ID: 1438089
   Summary: Review Request: golang-github-xtaci-kcp-go -
Production-Grade Reliable-UDP Library for golang
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: decatho...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://decathorpe.fedorapeople.org/packages/golang-github-xtaci-kcp-go.spec

SRPM URL:
https://decathorpe.fedorapeople.org/packages/golang-github-xtaci-kcp-go-3.13-1.fc25.src.rpm

Description: Production-Grade Reliable-UDP Library for golang

Fedora Account System Username: decathorpe


I can't provide a koji scratch build yet, since some dependencies are not yet
available on fedora (marked as blocker bugs). With local builds (present
dependencies) I had to disable tests, since they hit "too many open files"
errors in mock chroots, where I can't set "ulimit -n 102400" - or something
like that.

This go package is one of the new dependencies of syncthing 0.14.25.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432955] Review Request: lld - The LLVM linker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432955

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags||fedora-review+



--- Comment #3 from Igor Gnatenko  ---
> %{_libdir}/*.so
> %{_libdir}/*.so.*

Be more precise :)

Anyway, nothing I can complain about ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #27 from Fedora Update System  ---
snapd-glib-1.9-2.fc24 snapd-2.23.6-1.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ce0fdd87a4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390616] Review Request: snapd-glib - Library providing a GLib interface to snapd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390616



--- Comment #11 from Fedora Update System  ---
snapd-glib-1.9-2.fc24 snapd-2.23.6-1.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ce0fdd87a4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390616] Review Request: snapd-glib - Library providing a GLib interface to snapd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390616



--- Comment #10 from Fedora Update System  ---
snapd-glib-1.9-2.fc25 snapd-2.23.6-1.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-37a7331620

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=878188

Kevin Kofler  changed:

   What|Removed |Added

  Alias||qt5-qtbase



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1051152] Review Request: python-qt5 - Python bindings for Qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1051152

Kevin Kofler  changed:

   What|Removed |Added

  Alias||python-qt5



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #26 from Fedora Update System  ---
snapd-glib-1.9-2.fc25 snapd-2.23.6-1.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-37a7331620

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #25 from Fedora Update System  ---
snapd-2.23.6-1.fc26 snapd-glib-1.9-2.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-261aa8c9f4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390616] Review Request: snapd-glib - Library providing a GLib interface to snapd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390616



--- Comment #9 from Fedora Update System  ---
snapd-2.23.6-1.fc26 snapd-glib-1.9-2.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-261aa8c9f4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369560] Review Request: snapd-xdg-open - Bridge allowing (untrusted) snap applications to use xdg-open

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369560



--- Comment #5 from Neal Gompa  ---
@Simon:

Please open a new review request and close this one as a duplicate of it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=878188

Rex Dieter  changed:

   What|Removed |Added

  Alias||qt5-qtbase-review



--- Comment #62 from Rex Dieter  ---
It is possible, but not in some circumstances.

That said, I prefer for the packages I maintain to keep these aliases in place,
it is how *I* find their original reviews.  I'll consider a different workflow
in the future, maybe adopting something like alias "pkg_review" (assuming alias
length limits allow).

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 878188] Review Request: qt5-qtbase - Qt5 - QtBase components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=878188

Raphael Groner  changed:

   What|Removed |Added

 CC||projects...@smart.ms
  Alias|qt5-qtbase  |



--- Comment #61 from Raphael Groner  ---
Removing alias, otherwise it's not possible to search for bugs related to this
component.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1051152] Review Request: python-qt5 - Python bindings for Qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1051152

Raphael Groner  changed:

   What|Removed |Added

 CC||projects...@smart.ms
  Alias|python-qt5  |



--- Comment #20 from Raphael Groner  ---
Removing alias, otherwise it's not possible to search for bugs related to this
component.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369560] Review Request: snapd-xdg-open - Bridge allowing (untrusted) snap applications to use xdg-open

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369560

Simon Fels  changed:

   What|Removed |Added

 CC||morp...@gravedo.de



--- Comment #4 from Simon Fels  ---
I've updated the spec file and produced a new SRPM with all necessary changes
to fit Neals review comments.

You can find the new files at

 * https://mm.gravedo.de/files/snapd-xdg-open.spec
 * https://mm.gravedo.de/files/snapd-xdg-open-0.0.0-0.1.git6fed357.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369560] Review Request: snapd-xdg-open - Bridge allowing (untrusted) snap applications to use xdg-open

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369560

Neal Gompa  changed:

   What|Removed |Added

 Blocks||201449 (FE-DEADREVIEW)
   Assignee|ngomp...@gmail.com  |nob...@fedoraproject.org



--- Comment #3 from Neal Gompa  ---
No response in months, marking as DEADREVIEW.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437986] New: Review Request: python-pyaes - Pure-Python implementation of AES block-cipher and common modes of operation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437986

Bug ID: 1437986
   Summary: Review Request: python-pyaes - Pure-Python
implementation of AES block-cipher and common modes of
operation
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: lemen...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://peter.fedorapeople.org/packages/python-pyaes.spec
SRPM URL:
https://peter.fedorapeople.org/packages/python-pyaes-1.6.0-1.fc25.src.rpm
Description: A pure-Python implmentation of the AES block cipher algorithm and
the common modes of operation (CBC, CFB, CTR, ECB and OFB).
Fedora Account System Username: peter

Koji scratch build:

https://koji.fedoraproject.org/koji/taskinfo?taskID=18698657

This package is a requirement for Electrum 2.8.0 and later and Electrum-LTC
(not yet packaged).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437937] Review Request: libva-utils - Tools for VAAPI ( including vainfo)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437937

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

 Blocks||1437885




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1437885
[Bug 1437885] libva-1.8.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437937] Review Request: libva-utils - Tools for VAAPI ( including vainfo)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437937



--- Comment #1 from Nicolas Chauvet (kwizart)  ---
This package is a split from upstream libva source archive.
The matching libva version is already commited in git, but not built.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437937] New: Review Request: libva-utils - Tools for VAAPI ( including vainfo)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437937

Bug ID: 1437937
   Summary: Review Request: libva-utils - Tools for VAAPI
(including vainfo)
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: kwiz...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://dl.kwizart.net/review/libva-utils.spec
SRPM URL: http://dl.kwizart.net/review/libva-utils-1.8.0-1.fc24.src.rpm
Description: Tools for VAAPI (including vainfo)
Fedora Account System Username: kwizart


Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=18697594

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411239] Review Request: python-sphinx-issues - Sphinx extension for linking to your project' s issue tracker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411239

Pavel Cahyna  changed:

   What|Removed |Added

  Flags||fedora-review?
   ||needinfo?(ignatenko@redhat.
   ||com)



--- Comment #1 from Pavel Cahyna  ---
List of issues
==
Minor issues only.

- According to
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios
:
"In addition, the package must contain a comment explaining the
multiple licensing breakdown. The actual implementation of this is
left to the maintainer. (...)"

NOTICE says "sphinx-issues includes code adapted from other
libraries. Their licenses are included here." but does not say
to which code it applies. Please document it.

- There is already a 0.3.1 release available.

- In my understanding, the %{py2_dist} and %{py3_dist} macros could be
optionally used for dependencies, see
https://fedoraproject.org/wiki/Packaging:Python#Requires_and_BuildRequires_with_standardized_names



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "BSD (2 clause)", "Unknown or generated".
 10 files have unknown license. Detailed output of licensecheck in
 /home/pcahyna/fedora-packaging/reviews/1411239-python-sphinx-
 issues/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[!]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A 

[Bug 1437851] Review Request: modularity-testing-framework - Framework for writing tests for modules and containers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437851



--- Comment #2 from Petr Hracek  ---
Spec URL: https://phracek.fedorapeople.org/modularity-testing-framework.spec
SRPM URL:
https://phracek.fedorapeople.org/modularity-testing-framework-0.2.3-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437851] Review Request: modularity-testing-framework - Framework for writing tests for modules and containers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437851

Jan Ščotka  changed:

   What|Removed |Added

  Flags||fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437851] Review Request: modularity-testing-framework - Framework for writing tests for modules and containers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437851



--- Comment #1 from Jan Ščotka  ---

This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later)", "Unknown or generated". 72 files have
 unknown license. Detailed output of licensecheck in
 /home/jscotka/review/1437851-modularity-testing-
 framework/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[?]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[-]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[-]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[!]: Sources can be downloaded from URI in Source: tag
 Note: Could not download Source0: https://pagure.io/modularity-
 testing-framework/modularity-testing-framework/0.2.1.tar.gz
 See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[x]: If the source package does not include license text(s) as a separate
 file 

[Bug 1375986] Review Request: golang-github-klauspost-cpuid - CPU feature identification for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375986



--- Comment #8 from Fabio Valentini  ---
Additionally, a koji scratch build for rawhide would be nice.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375986] Review Request: golang-github-klauspost-cpuid - CPU feature identification for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375986



--- Comment #7 from Fabio Valentini  ---
It works now, thanks. Suggestions for improvements:

1) Since you are packaging version 1.0, you should set
> Version: 1.0
> Release: 1%{?dist}
and correct it the changelog entry too (1.0-1).

2) You can drop the empty %if-endif blocks at lines 94, 86 and 68.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437851] Review Request: modularity-testing-framework - Framework for writing tests for modules and containers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437851

Jan Ščotka  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|jsco...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437851] New: Review Request: modularity-testing-framework - Framework for writing tests for modules and containers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437851

Bug ID: 1437851
   Summary: Review Request: modularity-testing-framework -
Framework for writing tests for modules and containers
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: phra...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://phracek.fedorapeople.org/modularity-testing-framework.spec
SRPM URL:
https://phracek.fedorapeople.org/modularity-testing-framework-0.2.1-1.fc25.src.rpm
Description: Framework for writing tests for modules and containers.
Fedora Account System Username: phracek

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424851] Review Request: xplayer-plparser - Xplayer playlist parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424851

leigh scott  changed:

   What|Removed |Added

 Blocks|1424871 (xplayer)   |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1424871
[Bug 1424871] Review Request: xplayer - A generic Media Player
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424871] Review Request: xplayer - A generic Media Player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424871

leigh scott  changed:

   What|Removed |Added

 Depends On|1424851 (xplayer-plparser)  |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1424851
[Bug 1424851] Review Request: xplayer-plparser - Xplayer playlist parser
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375986] Review Request: golang-github-klauspost-cpuid - CPU feature identification for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375986



--- Comment #6 from Matthias Runge  ---
The revision is the same created from the spec file. But apparently I had to
modify the spec to fill in the summary and license.

The commit fits together with the last commit on
https://github.com/klauspost/cpuid

I updated the linked files.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1132661] Review Request: atom - Atom editor from github

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1132661



--- Comment #41 from Paulo Fidalgo  ---
More info about Atom is present on this wiki page:
https://fedoraproject.org/wiki/Atom

Also don't use helber copr, use the mosquito one. I've been using it and so far
so good!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375986] Review Request: golang-github-klauspost-cpuid - CPU feature identification for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375986



--- Comment #5 from Fabio Valentini  ---
It looks like you made a copy-paste error, because this link is now pointing at
the old version again.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375986] Review Request: golang-github-klauspost-cpuid - CPU feature identification for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375986



--- Comment #4 from Matthias Runge  ---
Fabio, thanks for looking at this:

SPEC: http://www.matthias-runge.de/fedora/golang-github-klauspost-cpuid.spec
SRPM:
http://www.matthias-runge.de/fedora/golang-github-klauspost-cpuid-0-0.1.git09cded8.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org