[Bug 1437262] Review Request: nodejs-jsonm - JSON compressor for packing messages with memoization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437262

Eduardo Mayorga  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Eduardo Mayorga  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 16 files have
 unknown license. Detailed output of licensecheck in
 /home/mayorga/reviews/1437262-nodejs-jsonm/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: Spec use %global instead of %define unless justified.

= EXTRA 

[Bug 1428914] Review Request: php-sebastian-object-enumerator3 - Traverses array and object to enumerate all referenced objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428914



--- Comment #5 from Remi Collet  ---
Thanks for the review.

New package requested on pkgdb.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1436852] Review Request: pidgin-save-conv-order - Save and restore conversation order in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436852

Eduardo Mayorga  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||e...@mayorgalinux.com
   Assignee|nob...@fedoraproject.org|e...@mayorgalinux.com
  Flags||fedora-review?



--- Comment #1 from Eduardo Mayorga  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- Locales are not being handled properly. Usage of %find_lang in packages
containing locales is a MUST.
  See: https://fedoraproject.org/wiki/Packaging:Guidelines
- License field in the spec file does not match the actual license. It's
actually GPLv2+.
- Summary(de): and
  %description -l de
  could be used to provide translations for non-English languages. The same for
fr and sr.
- rpmlint output is not clean.
  W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 1)


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "GPL (v2 or later)", "CC0 GPL (v2 or
 later)", "Unknown or generated". 38 files have unknown license.
 Detailed output of licensecheck in /home/mayorga/reviews/1436852
 -pidgin-save-conv-order/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 3 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec 

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424890



--- Comment #14 from Per Bothner  ---
Oops, that should have been 0.74. not 0.75.  Hence:

Spec URL: http://per.bothner.com/DomTerm/domterm.spec
SRPM URL: http://per.bothner.com/DomTerm/domterm-0.74-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424890



--- Comment #13 from Andrew Toskin  ---
I can see the spec, but trying to download the SRPM returns Error 404.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394576



--- Comment #10 from Fedora Update System  ---
golang-github-PuerkitoBio-purell-1.1.0-5.fc26 has been submitted as an update
to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-4ebaa73819

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Tiny Go library to normalize URLs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394576

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - Support for managing GNOME Shell Extensions through web browsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #42 from Pete Walter  ---
Not sure what to do with the transaction check error. In chrome-remote-desktop
/etc/opt/chrome/native-messaging-hosts is a symlink to
../../chromium/native-messaging-hosts which of course breaks this package here
that expects it to be a directory.

I would say it's an issue in chrome-remote-desktop that shouldn't be replacing
a valid directory with a symlink.

Jeremy, what is the other blocking issue you are talking about?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #15 from Fedora Update System  ---
lldpd-0.9.7-5.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-fe76c20831

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #12 from Fedora Update System  ---
lldpd-0.9.7-5.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-8363c4e8ec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #11 from Fedora Update System  ---
lldpd-0.9.7-5.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-77fac90af3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #14 from Fedora Update System  ---
lldpd-0.9.7-5.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-7356de7a31

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #13 from Fedora Update System  ---
lldpd-0.9.7-5.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-6ab500b6b5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #8 from Fedora Update System  ---
lldpd-0.9.7-4.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-676f5655d9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #10 from Fedora Update System  ---
lldpd-0.9.7-4.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-8741526fc3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #9 from Fedora Update System  ---
lldpd-0.9.7-4.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-cedacd0aaf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438913] Review Request: python-nbsphinx - Jupyter Notebook Tools for Sphinx

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438913

Sanqui (David Labský)  changed:

   What|Removed |Added

 CC||dlab...@redhat.com



--- Comment #1 from Sanqui (David Labský)  ---
This is an informal review as I am not sponsored yet.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

= Primary issues =

In the package description:
>Unevaluated notebooks i.e. notebooks without stored output cells will be 
>automatically executed during the Sphinx build process.

Personally, I would put commas in this sentence like so:

>Unevaluated notebooks, i.e. notebooks without stored output cells, will be 
>automatically executed during the Sphinx build process.

The description also seems to differ between the linked spec file and the one
in the SRPM, see below.

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: There is no build directory. Running licensecheck on vanilla
 upstream sources. No licenses found. Please check the source files for
 licenses manually.
LICENSE can be found in the source directory.
[?]: License file installed when any subpackage combination is installed.
Not sure how to test yet
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python3.6/site-
 packages, /usr/lib/python3.6/site-packages/__pycache__,
 /usr/lib/python3.6
Package definitely did not create these directories
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Binary eggs must be removed in %prep
 Note: Cannot find any build in BUILD directory (--prebuilt option?)
No binary egg present.
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package 

[Bug 1389955] Review Request: gnome-shell-extension-no-topleft-hot-corner - Disable the "hot corner" in GNOME Shell

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389955



--- Comment #27 from Fedora Update System  ---
gnome-shell-extension-no-topleft-hot-corner-14.0-2.el7 has been pushed to the
Fedora EPEL 7 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421304] Review Request: python-aiohttp-cors - CORS ( Cross Origin Resource Sharing) support for aiohttp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421304



--- Comment #9 from Fedora Update System  ---
python-aiohttp-cors-0.5.0-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c03e9626ed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421304] Review Request: python-aiohttp-cors - CORS ( Cross Origin Resource Sharing) support for aiohttp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421304

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444



--- Comment #12 from Fedora Update System  ---
molequeue-0.8.0-2.20161222giteb397e.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c1b32a53bd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431426] Review Request: python-dbfread - Read DBF Files with Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431426



--- Comment #13 from Fedora Update System  ---
python-dbfread-2.0.7-3.git300b2d7.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-26e7b2980b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431735



--- Comment #10 from Fedora Update System  ---
golang-github-cznic-sortutil-0-0.1.git4c73428.fc26 has been pushed to the
Fedora 26 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-759be82f1b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431736] Review Request: golang-github-cznic-strutil - Supplemental utilities for Go' s strings package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431736



--- Comment #11 from Fedora Update System  ---
golang-github-cznic-strutil-0-0.1.git43a8959.fc26 has been pushed to the Fedora
26 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9296c118c1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431732] Review Request: golang-github-cznic-fileutil - File utility functions for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431732



--- Comment #9 from Fedora Update System  ---
golang-github-cznic-fileutil-0-0.2.git90cf820.fc26 has been pushed to the
Fedora 26 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-7f69f09429

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437036] Review Request: apache-logging-parent - Parent pom for Apache Logging Services projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437036

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
apache-logging-parent-1-1.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f1a758779b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390616] Review Request: snapd-glib - Library providing a GLib interface to snapd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390616



--- Comment #26 from Fedora Update System  ---
snapd-2.23.6-4.fc26, snapd-glib-1.10-1.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-261aa8c9f4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #41 from Fedora Update System  ---
snapd-2.23.6-4.fc26, snapd-glib-1.10-1.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-261aa8c9f4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438673] Review Request: openjfx - Rich client application platform for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438673



--- Comment #2 from Jonny Heggheim  ---
Updated to only build for x86 and x86_64, since the build will fail on other
platforms. Would be nice to work with upstream to test on other platforms.

Spec URL: https://jonny.fedorapeople.org/openjfx.spec
SRPM URL: https://jonny.fedorapeople.org/openjfx-8.0.152-4.b00.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421304] Review Request: python-aiohttp-cors - CORS ( Cross Origin Resource Sharing) support for aiohttp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421304



--- Comment #8 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-aiohttp-cors

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427341] Review Request: python-gamera - Gamera is a framework for building document analysis applications.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427341



--- Comment #23 from VincentS  ---
I followed your advises Charalampos and Miro and I will discuss with upstream
about executable right on README file.

Spec URL: https://dl.casperlefantom.net/pub/review/python-gamera.spec
SRPM URL:
https://dl.casperlefantom.net/pub/review/python-gamera-3.4.3-4.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
molequeue-0.8.0-2.20161222giteb397e.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-833b73f0b0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431426] Review Request: python-dbfread - Read DBF Files with Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431426

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
python-dbfread-2.0.7-3.git300b2d7.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9996b7466a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431732] Review Request: golang-github-cznic-fileutil - File utility functions for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431732

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
golang-github-cznic-fileutil-0-0.2.git90cf820.fc25 has been pushed to the
Fedora 25 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-471057d7ad

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431732] Review Request: golang-github-cznic-fileutil - File utility functions for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431732

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
golang-github-cznic-fileutil-0-0.2.git90cf820.fc25 has been pushed to the
Fedora 25 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-471057d7ad

--- Comment #8 from Fedora Update System  ---
golang-github-cznic-fileutil-0-0.2.git90cf820.fc24 has been pushed to the
Fedora 24 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-67ad50afb4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431735



--- Comment #9 from Fedora Update System  ---
golang-github-cznic-sortutil-0-0.1.git4c73428.fc24 has been pushed to the
Fedora 24 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b7696240e0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431736] Review Request: golang-github-cznic-strutil - Supplemental utilities for Go' s strings package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431736



--- Comment #10 from Fedora Update System  ---
golang-github-cznic-strutil-0-0.1.git43a8959.fc25 has been pushed to the Fedora
25 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ba8291615d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390616] Review Request: snapd-glib - Library providing a GLib interface to snapd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390616

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #24 from Fedora Update System  ---
snapd-2.23.6-3.fc24, snapd-glib-1.10-1.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ce0fdd87a4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431736] Review Request: golang-github-cznic-strutil - Supplemental utilities for Go' s strings package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431736

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
golang-github-cznic-strutil-0-0.1.git43a8959.fc24 has been pushed to the Fedora
24 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-4365f9f0c6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431735] Review Request: golang-github-cznic-sortutil - Supplemental utilities for Go' s sort package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431735

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
golang-github-cznic-sortutil-0-0.1.git4c73428.fc25 has been pushed to the
Fedora 25 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ee335a33cd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #40 from Fedora Update System  ---
snapd-2.23.6-4.fc25, snapd-glib-1.10-1.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-37a7331620

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390616] Review Request: snapd-glib - Library providing a GLib interface to snapd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390616

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #24 from Fedora Update System  ---
snapd-2.23.6-3.fc24, snapd-glib-1.10-1.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ce0fdd87a4

--- Comment #25 from Fedora Update System  ---
snapd-2.23.6-4.fc25, snapd-glib-1.10-1.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-37a7331620

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1439342] New: Review Request: adapt - Mycroft's Adapt Intent Parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1439342

Bug ID: 1439342
   Summary: Review Request: adapt - Mycroft's Adapt Intent Parser
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: pbrobin...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Blocks: 1269538 (IoT)



SPEC: https://pbrobinson.fedorapeople.org/adapt.spec
SRPM: https://pbrobinson.fedorapeople.org/adapt-0.3.0-1.fc26.src.rpm

Description:
The Adapt Intent Parser is a flexible and extensible intent definition and 
determination framework. It is intended to parse natural language text into a 
structured intent that can then be invoked programatically.

koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=18802527


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1269538
[Bug 1269538] Tracker for IoT on Fedora
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428914] Review Request: php-sebastian-object-enumerator3 - Traverses array and object to enumerate all referenced objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428914



--- Comment #4 from Randy Barlow  ---
Created attachment 1269044
  --> https://bugzilla.redhat.com/attachment.cgi?id=1269044=edit
review.txt

Approved!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428914] Review Request: php-sebastian-object-enumerator3 - Traverses array and object to enumerate all referenced objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428914

Randy Barlow  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424890



--- Comment #12 from Per Bothner  ---
I've updated DomTerm to take into account your comments

Spec URL: http://per.bothner.com/DomTerm/domterm.spec
SRPM URL: http://per.bothner.com/DomTerm/domterm-0.75-1.fc25.src.rpm

* It no longer uses RPM_BUILD_ROOT.
* It uses %make_install.
* I split up BuildRequires into one per dependency.
* I removed %{_bindir} in a comment.
* I added:
  Recommends: java
See the comment in the spec file.
* I added .desktop and .appdata.xml files.
* I added some more features in the %description.

You reported that the following didn't work for you:
$ ldomterm
I noticed that starting google-chome in '-app' mode doesn't
work if google-chome (as a regular browser) isn't already running.
Could you try:
$ ldomterm --firefox
and/or
$ ldomterm --browser
It might be reasonable to change the default to --firefox,
which is a "XUL" wrapper.  The big problem is that Mozilla
intends to remove XUL support this year, and I haven't found
a good replacement yet.  So perhaps --browser (uses the user's
default desktop browser) is the safest default.

There is a new dt-util script, which is meant to be used when
running in a DomTerm terminal:
http://domterm.org/dt-util.html

Note I recently implemented a major new feature, paging:
http://domterm.org/Paging.html
However, this only works with the ldomterm server, and only with
libwebsockets 2.2.  Plus the UI (including key-bindings) needs work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 821406] Review Request: eiskaltdcpp - QT Direct Connect client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821406



--- Comment #40 from Raphael Groner  ---
Thanks for the fixes and your quick response. I hope to find some free time
slot and can continue the review later in this week.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1439178] Review Request: quazip-qt5 - Qt5 wrapper for the minizip library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1439178

James Hogarth  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||james.hoga...@gmail.com
   Assignee|nob...@fedoraproject.org|james.hoga...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401451] Package Review: pcb2gcodeGUI - A GUI for pcb2gcode

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401451

Richard Marko  changed:

   What|Removed |Added

 Status|NEW |MODIFIED
 CC||rma...@base48.cz
   Assignee|nob...@fedoraproject.org|rma...@base48.cz
  Flags||fedora-review+



--- Comment #2 from Richard Marko  ---
- URL points to pcb2gcode instead of pcb2gcodeGUI
- rpmlint complaints about few files in -debuginfo subpackage
- maybe also require pcb2gcode, it's looking for it at start
- won't launch window

Otherwise looks good to me.

fedora-review log for the reference:

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[-]: Package does not contain kernel modules.
[-]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3 or later)", "Unknown or generated". 8 files have
 unknown license. Detailed output of licensecheck in /home/rmarko
 /review-pcb2gcodeGUI/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[!]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #7 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/lldpd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #6 from James Hogarth  ---
Thanks Dan ... and good news is it only required a minor maintainer patch to
get it built against EPEL6 as well :)

Letting the developer know the changes I made in the patch to see if he's
willing to upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428914] Review Request: php-sebastian-object-enumerator3 - Traverses array and object to enumerate all referenced objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428914

Randy Barlow  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ra...@electronsweatshop.com
   Assignee|nob...@fedoraproject.org|ra...@electronsweatshop.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881

Miroslav Lichvar  changed:

   What|Removed |Added

 CC||jdula...@fedoraproject.org
  Flags||needinfo?(jdulaney@fedorapr
   ||oject.org)



--- Comment #1 from Miroslav Lichvar  ---
Thanks for preparing the package. My review follows.

Issues:
===
- I think it would be better for the names of the executables in /usr/bin to
  not include dash, similarly to the compat-guile18 and python3 packages
- The package should probably not include the /usr/bin/guile2{,-tools} symlinks
- Missing Provides: bundled(gnulib)
  See:
http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Requirement_if_you_bundle
- Package contains a libtool archive
/usr/lib64/guile/2.2/extensions/guile-readline.la
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries
- Package has obsolete/wrong scriptlets:
  %triggerin -- guile and %postrans should be removed
  %triggerin -- slib needs to be updated, or removed if slib doesn't work with
guile2.2 yet
- Macro %define mver should be replaced with %global mver

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
[x]: Header files in -devel subpackage, if present.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[-]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/share/guile/site(compat-
 guile18, guile), /usr/lib64/guile(guile), /usr/include/guile(guile-
 devel), /usr/share/guile(compat-guile18, guile)
 This looks ok.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Texinfo files are installed using install-info in %post and %preun if
 package has .info files.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid 

[Bug 1439261] Review Request: python-nose_warnings_filters - Allow to inject warning filters during nosetest

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1439261

Miro Hrončok  changed:

   What|Removed |Added

 Blocks||1438917




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1438917
[Bug 1438917] python-notebook-5.0.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853

Dan Horák  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Dan Horák  ---
Looks good now, package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1439261] New: Review Request: python-nose_warnings_filters - Allow to inject warning filters during nosetest

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1439261

Bug ID: 1439261
   Summary: Review Request: python-nose_warnings_filters - Allow
to inject warning filters during nosetest
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mhron...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://churchyard.fedorapeople.org/SRPMS/python-nose_warnings_filters.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/python-nose_warnings_filters-0.1.5-1.fc25.src.rpm

Description:

If you run your test suite with nosetest, you can use this package to filter
the warnings by setting rules in your setup.cfg.

Fedora Account System Username: churchyard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421601] Container Review Request: ruby - Platform for building and running Ruby applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421601

Pavel Raiskup  changed:

   What|Removed |Added

 CC||prais...@redhat.com



--- Comment #8 from Pavel Raiskup  ---
* Docker docs say 'MAINTAINER (deprecated)'.  And claims we should rather
  use LABEL maintainer ...

* All the examples in guidelines tell about 'FROM: fedora:25', not 'FROM: 25'

* guidelines tell us to install software from RPMs provided by RPMs, but
  that statement should be probably relaxed:  The Fedora Layered Image Build
  Service will reject images that are found to be built from sets of software
  not provided by Koji 

Vít Ondruch wrote:
> Isn't this something what should be supported by OSBS or whatever is building
> the images?

That sounds like political question.  Dockerfiles have poor design (e.g.
we can not use docker build --build-arg for this), so when we decided that
Dockerfiles are equivalent to "what spec file is in rpm world", we need to
make sure that 'docker build' support such features ...

IOW, doing some nasty 'sed -i s/FROM.*/.../ Dockerfile' in osbs would make
the builds non-reproducible.  The other option is to invent some
well-known templating system and start "generating" Dockerfiles.  That's
what was rejected many times when I proposed that.  So the simple answer is
that, based on the political rules, we need to hard-wire.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1439253] New: Review Request: python-pydispatcher - Multi-producer-multi-consumer signal dispatching mechanism

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1439253

Bug ID: 1439253
   Summary: Review Request: python-pydispatcher -
Multi-producer-multi-consumer signal dispatching
mechanism
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ishch...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://ishcherb.fedorapeople.org/python-pydispatcher.spec
SRPM URL:
https://ishcherb.fedorapeople.org/python-pydispatcher-2.0.5-1.fc25.src.rpm
Description: Dispatcher mechanism for creating event models.
PyDispatcher is an enhanced version of Patrick K. O'Brien's original
dispatcher.py module. It provides the Python programmer with a robust mechanism
for event routing within various application contexts.
Included in the package are the `robustapply` and `saferef` modules, which
provide the ability to selectively apply arguments to callable objects and to
reference instance methods using weak-references.

Fedora Account System Username: ishcherb
Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=18797811

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1439253] Review Request: python-pydispatcher - Multi-producer-multi-consumer signal dispatching mechanism

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1439253

Iryna Shcherbina  changed:

   What|Removed |Added

 Blocks||1087355




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1087355
[Bug 1087355] python-sqlobject-3.2.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401450] Review Request: pcb2gcode - Command-line software for the isolation, routing and drilling of PCBs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401450

Richard Marko  changed:

   What|Removed |Added

 Status|NEW |MODIFIED
 CC||rma...@base48.cz
   Assignee|nob...@fedoraproject.org|rma...@base48.cz
  Flags||fedora-review+



--- Comment #4 from Richard Marko  ---
Guido thanks for the review. I've double checked this and it seems good to go. 

Lubko please consider updating spec with minor issues from start of comment #3
although group seems appropriate.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433626] Review Request: python-defcon - A set of flexible objects for representing UFO data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433626

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433626] Review Request: python-defcon - A set of flexible objects for representing UFO data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433626



--- Comment #5 from Fedora Update System  ---
python-defcon-0.3.2-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-cdf3a8ca0d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390616] Review Request: snapd-glib - Library providing a GLib interface to snapd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390616



--- Comment #23 from Fedora Update System  ---
snapd-2.23.6-3.fc24 snapd-glib-1.10-1.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ce0fdd87a4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #39 from Fedora Update System  ---
snapd-2.23.6-3.fc24 snapd-glib-1.10-1.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ce0fdd87a4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #38 from Fedora Update System  ---
snapd-2.23.6-4.fc25 snapd-glib-1.10-1.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-37a7331620

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390616] Review Request: snapd-glib - Library providing a GLib interface to snapd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390616



--- Comment #22 from Fedora Update System  ---
snapd-2.23.6-4.fc25 snapd-glib-1.10-1.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-37a7331620

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367825] Review Request: snapd - The snapd and snap tools enable systems to work with .snap files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #37 from Fedora Update System  ---
snapd-2.23.6-4.fc26 snapd-glib-1.10-1.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-261aa8c9f4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390616] Review Request: snapd-glib - Library providing a GLib interface to snapd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390616

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390616] Review Request: snapd-glib - Library providing a GLib interface to snapd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390616



--- Comment #21 from Fedora Update System  ---
snapd-2.23.6-4.fc26 snapd-glib-1.10-1.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-261aa8c9f4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #4 from James Hogarth  ---
Thanks for the feedback, both of you.

  * Source0 line updated
  * Summary changed to suggestion
  * configure option updated
  * requires added to subpackage on main package
  * looking at more detail it wanted not just doxygen but the pdf part as well
to produce pdf docs... that feels silly so I've pulled the BR

Koji builds:

F25: https://koji.fedoraproject.org/koji/taskinfo?taskID=18796508
F26: https://koji.fedoraproject.org/koji/taskinfo?taskID=18796713
RAW: https://koji.fedoraproject.org/koji/taskinfo?taskID=18796875
EL7: https://koji.fedoraproject.org/koji/taskinfo?taskID=18797292

Spec URL: https://fedorapeople.org/~jhogarth/lldpd/lldpd.spec
SRPM URL: https://fedorapeople.org/~jhogarth/lldpd/lldpd-0.9.7-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1370451] Review Request: nodejs-grunt-contrib-copy - Copy files and folders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370451



--- Comment #4 from Piotr Popieluch  ---
requested unblocking:
https://pagure.io/releng/issue/6745

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853



--- Comment #3 from Dan Horák  ---
formal review is here, see the notes explaining OK* and BAD statuses below:

OKsource files match upstream:
f3ed143ba16fb4232a237f51cddaee276af896c8  0.9.7.tar.gz
OKpackage meets naming and versioning guidelines.
OKspecfile is properly named, is cleanly written and uses macros
consistently.
OKdist tag is present.
OKlicense field matches the actual license.
OKlicense is open source-compatible (ISC). License text included in
package.
OKlatest version is being packaged.
OK*BuildRequires are proper.
OKcompiler flags are appropriate.
OKpackage builds in mock (Rawhide/x86_64).
OKdebuginfo package looks complete.
BADrpmlint is silent.
OKfinal provides and requires look sane.
N/A%check is present and all tests pass.
OKshared libraries are added to the regular linker search paths with
ldconfig call.
OKowns the directories it creates.
OKdoesn't own any directories it shouldn't.
OKno duplicates in %files.
OKfile permissions are appropriate.
OKcorrect scriptlets present.
OKcode, not content.
OKdocumentation is small, so no -docs subpackage is necessary.
OK%docs are not necessary for the proper functioning of the package.
OKheaders in devel subpackage
OKpkgconfig files in devel subpackage
OKno libtool .la droppings.
OKnot a GUI app.

- please do the 2 changes Ralf proposed, use %{name}-%{version}.tar.gz style
for the source and use a verbose build (easier to read the build log than
inspect *.o files for used compiler flags)
- doxygen is present in BR, but there are no docs generated
- rpmlint complains a bit
lldpd.x86_64: W: summary-not-capitalized C lldpd is an ISC-licensed
implementation of LLDP
lldpd.x86_64: W: name-repeated-in-summary C lldpd
lldpd.src: W: summary-not-capitalized C lldpd is an ISC-licensed implementation
of LLDP
lldpd.src: W: name-repeated-in-summary C lldpd
lldpd-devel.x86_64: W: summary-not-capitalized C lldpd is an ISC-licensed
implementation of LLDP
  -> Summary: ISC-licensed implementation of LLDP

lldpd.x86_64: W: non-standard-uid /var/lib/lldpd lldpd
lldpd.x86_64: W: non-standard-gid /var/lib/lldpd lldpd
lldpd-devel.x86_64: W: no-documentation
lldpd-devel.x86_64: W: only-non-binary-in-usr-lib
lldpd.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
lldpd.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
lldpd.x86_64: W: conffile-without-noreplace-flag /etc/lldpd.d/README.conf
  -> OK, can be ignored

lldpd.x86_64: E: zero-length /usr/share/doc/lldpd/ChangeLog
  -> drop the file from %doc, needs git tree and NEWS is sufficient,
Contribute.md can dropped too

lldpd.src:9: W: mixed-use-of-spaces-and-tabs (spaces: line 8, tab: line 9)
lldpd.x86_64: E: missing-call-to-chdir-with-chroot /usr/sbin/lldpd
lldpd.x86_64: W: shared-lib-calls-exit /usr/lib64/liblldpctl.so.4.8.0
exit@GLIBC_2.2.5
lldpd.x86_64: W: non-ghost-in-run /run/lldpd/chroot
lldpd.x86_64: W: non-ghost-in-run /run/lldpd
lldpd-devel.x86_64: W: no-dependency-on lldpd/lldpd-libs/liblldpd
  -> need fix or comment

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881

Miroslav Lichvar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jsyna...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438853] Review Request: lldpd - an ISC-licensed implementation of LLDP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438853

Dan Horák  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||d...@danny.cz
   Assignee|nob...@fedoraproject.org|d...@danny.cz
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438927] Review Request: nanomsg - A fast, scalable, and easy to use socket library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438927

Michael Schwendt  changed:

   What|Removed |Added

 Blocks|201449 (FE-DEADREVIEW)  |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1123511] Review Request: nanomsg - A fast, scalable, and easy to use socket library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123511

Michael Schwendt  changed:

   What|Removed |Added

 Resolution|DEFERRED|DUPLICATE



--- Comment #20 from Michael Schwendt  ---


*** This bug has been marked as a duplicate of bug 1438927 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438927] Review Request: nanomsg - A fast, scalable, and easy to use socket library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438927

Michael Schwendt  changed:

   What|Removed |Added

 Blocks||201449 (FE-DEADREVIEW)
 CC||cleaver-redhat@terabithia.o
   ||rg



--- Comment #1 from Michael Schwendt  ---
*** Bug 1123511 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1439178] New: Review Request: quazip-qt5 - Qt5 wrapper for the minizip library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1439178

Bug ID: 1439178
   Summary: Review Request: quazip-qt5 - Qt5 wrapper for the
minizip library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: d...@danny.cz
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://fedora.danny.cz/quazip-qt5.spec
SRPM URL: http://fedora.danny.cz/quazip-qt5-0.7.3-1.el7.src.rpm

Description:
QuaZIP is a simple C++ wrapper over Gilles Vollant's ZIP/UNZIP package that
can be used to access ZIP archives. It uses Trolltech's Qt toolkit.

QuaZIP allows you to access files inside ZIP archives using QIODevice API,
and - yes! - that means that you can also use QTextStream, QDataStream or
whatever you would like to use on your zipped files.

QuaZIP provides complete abstraction of the ZIP/UNZIP API, for both reading
from and writing to ZIP archives.


Fedora Account System Username: sharkcz

Note: this is EPEL-7 only package adding Qt5 support, cloned from the Fedora
quazip package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437851] Review Request: modularity-testing-framework - Framework for writing tests for modules and containers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437851

Petr Hracek  changed:

   What|Removed |Added

 CC||jsco...@redhat.com
  Flags||needinfo?(jsco...@redhat.co
   ||m)



--- Comment #3 from Petr Hracek  ---
Here is new version

Spec URL: https://phracek.fedorapeople.org/modularity-testing-framework.spec
SRPM URL:
https://phracek.fedorapeople.org/modularity-testing-framework-0.2.5-1.fc25.src.rpm

Please check it again and let me know.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444



--- Comment #9 from Fedora Update System  ---
molequeue-0.8.0-2.20161222giteb397e.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-833b73f0b0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444



--- Comment #10 from Fedora Update System  ---
molequeue-0.8.0-2.20161222giteb397e.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c1b32a53bd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431444] Review Request: molequeue - Desktop integration of high performance computing resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431444

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421245] Review Request: libcrush - C library to control placement in a hierarchy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421245



--- Comment #25 from Loic Dachary  ---
@karlthe...@gmail.com I forgot to thank you for your review. Thank you :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 821406] Review Request: eiskaltdcpp - QT Direct Connect client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821406



--- Comment #39 from Vasiliy Glazov  ---
About /usr/lib/.build-id - it is rpmlint bug in rawhide:

https://bugzilla.redhat.com/show_bug.cgi?id=1431408

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 822465] Review Request: gnome-shell-extension-weather - A Gnome shell weather extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=822465

Matthias Runge  changed:

   What|Removed |Added

  Group|private |
 CC||mru...@redhat.com



--- Comment #1 from Matthias Runge  ---
there is no reason for review requests to be private. I assume this happened by
accident.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 821406] Review Request: eiskaltdcpp - QT Direct Connect client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821406



--- Comment #38 from Vasiliy Glazov  ---
Spec URL:
https://raw.github.com/RussianFedora/eiskaltdcpp/master/eiskaltdcpp.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/1079/18791079/eiskaltdcpp-2.2.11-2.20170207git3b9c502.fc27.src.rpm

Corrected other issues except:
- Split a data subpackage for the huge noarch stuff.

rpm file not so big to split it.

- Please drop useless /usr/lib/.build-id file, see rpmlint warnings below.

I don't see this file. It is not listed in %files section and packacge not
contain it.


Now all issues corrected?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org