[Bug 1427185] Review Request: zypper - Command line package manager from SUSE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427185



--- Comment #7 from Fedora Update System  ---
zypper-1.13.22-1.fc26 libzypp-16.6.1-1.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ba82706aa3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427182] Review Request: libzypp - A package management library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427182



--- Comment #6 from Fedora Update System  ---
zypper-1.13.22-1.fc26 libzypp-16.6.1-1.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ba82706aa3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427182] Review Request: libzypp - A package management library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427182

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427185] Review Request: zypper - Command line package manager from SUSE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427185

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375986] Review Request: golang-github-klauspost-cpuid - CPU feature identification for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375986



--- Comment #10 from Matthias Runge  ---
sorry for the delay, and thank you for your patience

SPEC: http://www.matthias-runge.de/fedora/golang-github-klauspost-cpuid.spec
SRPM:
http://www.matthias-runge.de/fedora/golang-github-klauspost-cpuid-1.0-1.src.rpm


scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19055443

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=615669

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #30 from Fedora Update System  ---
perl-Crypt-Cracklib-1.7-19.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-56b4c757c7

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431761] Review Request: golang-github-AudriusButkevicius-cli - Small library for building CLI apps in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431761



--- Comment #13 from Fedora Update System  ---
golang-github-AudriusButkevicius-cli-1.0.0-1.20140727.git7f561c7.fc26 has been
pushed to the Fedora 26 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-067b202929

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434421] Review Request: golang-github-AudriusButkevicius-pfilter - Simple Packet Filtering package written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434421



--- Comment #9 from Fedora Update System  ---
golang-github-AudriusButkevicius-pfilter-0-0.1.20170209.git09b3cfd.fc26 has
been pushed to the Fedora 26 testing repository. If problems still persist,
please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0b67dfff19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442853] Review Request: libgsignon-glib - GLib API for the SSO framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442853



--- Comment #8 from Fedora Update System  ---
libgsignon-glib-2.4.1-1.20161228.git03d9c64.fc25 has been submitted as an
update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-28e7fc0b45

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442853] Review Request: libgsignon-glib - GLib API for the SSO framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442853

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442853] Review Request: libgsignon-glib - GLib API for the SSO framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442853



--- Comment #7 from Fedora Update System  ---
libgsignon-glib-2.4.1-1.20161228.git03d9c64.fc26 has been submitted as an
update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-7da348eda5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431761] Review Request: golang-github-AudriusButkevicius-cli - Small library for building CLI apps in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431761



--- Comment #12 from Fedora Update System  ---
golang-github-AudriusButkevicius-cli-1.0.0-1.20140727.git7f561c7.fc25 has been
pushed to the Fedora 25 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c4080d8884

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434421] Review Request: golang-github-AudriusButkevicius-pfilter - Simple Packet Filtering package written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434421

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
golang-github-AudriusButkevicius-pfilter-0-0.1.20170209.git09b3cfd.fc25 has
been pushed to the Fedora 25 testing repository. If problems still persist,
please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5cea2dc37b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442853] Review Request: libgsignon-glib - GLib API for the SSO framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442853



--- Comment #6 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/libgsignon-glib

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431761] Review Request: golang-github-AudriusButkevicius-cli - Small library for building CLI apps in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431761

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
golang-github-AudriusButkevicius-cli-1.0.0-1.20140727.git7f561c7.fc24 has been
pushed to the Fedora 24 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-de3fe47b79

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427185] Review Request: zypper - Command line package manager from SUSE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427185



--- Comment #6 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/zypper

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427182] Review Request: libzypp - A package management library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427182



--- Comment #5 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/libzypp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442853] Review Request: libgsignon-glib - GLib API for the SSO framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442853



--- Comment #4 from Neal Gompa  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "*No copyright* LGPL (v2.1)", "LGPL (v2.1 or later)", "LGPL
 (v2.1)", "Unknown or generated". 52 files have unknown license.
 Detailed output of licensecheck in /home/makerpm/1442853-libgsignon-
 glib/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib64/girepository-1.0,
 /usr/share/vala/vapi, /usr/share/gir-1.0, /usr/share/vala
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 libgsignon-glib-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: 

[Bug 1442853] Review Request: libgsignon-glib - GLib API for the SSO framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442853

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Neal Gompa  ---
Looks good to me.

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442853] Review Request: libgsignon-glib - GLib API for the SSO framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442853



--- Comment #3 from Fabio Valentini  ---
Issues are fixed, same links.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432230] Review Request: ampy - Command line tool to interact with a MicroPython board over a serial connection

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432230

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2017-03-22 15:21:34 |2017-04-17 16:51:53



--- Comment #12 from Fedora Update System  ---
ampy-1.0.1-1.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442853] Review Request: libgsignon-glib - GLib API for the SSO framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442853



--- Comment #2 from Neal Gompa  ---
A few issues:

> Requires:   dbus%{?isa}
> Requires:   gsignond%{?isa}

The macro should be "%{?_isa}".

> %packagedevel
> Summary:GSignOn daemon development files

The summary is wrong for this library.

> %files devel
> %{_bindir}/gsso-example

Move this into its own subpackage, as it doesn't depend on the devel content at
all, and isn't needed for devel stuff.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442853] Review Request: libgsignon-glib - GLib API for the SSO framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442853

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377762] Review Request: opendht - A lightweight C++11 Distributed Hash Table implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377762



--- Comment #7 from Benjamin Lefoul  ---
Thanks Adrien. I'll update the spec directly to 1.3.1 then.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442853] New: Review Request: libgsignon-glib - GLib API for the SSO framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442853

Bug ID: 1442853
   Summary: Review Request: libgsignon-glib - GLib API for the SSO
framework
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: decatho...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://decathorpe.fedorapeople.org/packages/libgsignon-glib.spec

SRPM URL:
https://decathorpe.fedorapeople.org/packages/libgsignon-glib-2.4.1-1.20161228.git03d9c64.fc26.src.rpm

Description: This project is a library for managing single signon credentials
which can be used from GLib applications. It is effectively a GLib binding for
the D-Bus API provided by gsignond.

Fedora Account System Username: decathorpe


koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=19048060


PS: The additional support for python is not enabled on purpose, since it only
supports python2.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442547] Review Request: gsignond - GSignOn daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442547



--- Comment #12 from Fedora Update System  ---
gsignond-1.0.6-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-85a6084eee

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442547] Review Request: gsignond - GSignOn daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442547



--- Comment #11 from Fedora Update System  ---
gsignond-1.0.6-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-4cfec99e64

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442547] Review Request: gsignond - GSignOn daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442547

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431763] Review Request: golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431763



--- Comment #9 from Fedora Update System  ---
golang-github-oschwald-geoip2-golang-1.0.0-1.20170314.git0fd242d.fc24 has been
submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6261d56f95

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442547] Review Request: gsignond - GSignOn daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442547



--- Comment #10 from Fabio Valentini  ---
I've reported a bug about the setgroups / setuid usage upstream at:
https://gitlab.com/accounts-sso/gsignond/issues/11

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431763] Review Request: golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431763



--- Comment #8 from Fedora Update System  ---
golang-github-oschwald-geoip2-golang-1.0.0-1.20170314.git0fd242d.fc25 has been
submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-55388bed37

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431763] Review Request: golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431763

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431763] Review Request: golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431763



--- Comment #7 from Fedora Update System  ---
golang-github-oschwald-geoip2-golang-1.0.0-1.20170314.git0fd242d.fc26 has been
submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-43dcb207fa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398400] Review Request: superlu_dist - Solution of large, sparse, nonsymmetric systems of linear equations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398400



--- Comment #30 from Fedora Update System  ---
superlu_dist-5.1.3-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-ba85d2bc21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398400] Review Request: superlu_dist - Solution of large, sparse, nonsymmetric systems of linear equations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398400



--- Comment #29 from Fedora Update System  ---
superlu_dist-5.1.3-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5a231b6b8b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398400] Review Request: superlu_dist - Solution of large, sparse, nonsymmetric systems of linear equations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398400



--- Comment #28 from Fedora Update System  ---
superlu_dist-5.1.3-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-cbc1eb72fc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398400] Review Request: superlu_dist - Solution of large, sparse, nonsymmetric systems of linear equations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398400



--- Comment #27 from Fedora Update System  ---
superlu_dist-5.1.3-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e2b96ce208

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398400] Review Request: superlu_dist - Solution of large, sparse, nonsymmetric systems of linear equations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398400

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398400] Review Request: superlu_dist - Solution of large, sparse, nonsymmetric systems of linear equations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398400



--- Comment #26 from Fedora Update System  ---
superlu_dist-5.1.3-2.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-4b1f4593ad

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424482] Review Request: sge - Son of Grid Engine - Distributed Computing Management software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424482

Dave Love  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|dave.l...@manchester.ac.uk



--- Comment #2 from Dave Love  ---
Sorry, I'd missed this.  I should take it, but I probably can't be very
responsive in the near future.

Why is this a separate project from gridengine?  I'd have thought that should
just be based on newer sources, and I think an old installation could be
upgraded.

I need to try to get a release out with accumulated changes, but there's at
least on regression in 8.1.9 which probably deserves patching in the packaging.
 I've long been meaning to merge the Fedora spec with the /opt-based one too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442547] Review Request: gsignond - GSignOn daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442547



--- Comment #9 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/gsignond

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431763] Review Request: golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431763



--- Comment #6 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-oschwald-geoip2-golang

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437389] Review Request: golang-github-ccding-go-stun - STUN client ( RFC 3489 and RFC 5389) implementation in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437389



--- Comment #6 from Fedora Update System  ---
golang-github-ccding-go-stun-0-0.1.20170323.git04a4eed.fc24 has been submitted
as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f8fc1bd3f5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437389] Review Request: golang-github-ccding-go-stun - STUN client ( RFC 3489 and RFC 5389) implementation in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437389

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437389] Review Request: golang-github-ccding-go-stun - STUN client ( RFC 3489 and RFC 5389) implementation in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437389



--- Comment #5 from Fedora Update System  ---
golang-github-ccding-go-stun-0-0.1.20170323.git04a4eed.fc25 has been submitted
as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-cc5bb1bc3a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437389] Review Request: golang-github-ccding-go-stun - STUN client ( RFC 3489 and RFC 5389) implementation in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437389



--- Comment #4 from Fedora Update System  ---
golang-github-ccding-go-stun-0-0.1.20170323.git04a4eed.fc26 has been submitted
as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-685af345e5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431741] Review Request: golang-github-cznic-b - B+ Tree implementation in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431741



--- Comment #7 from Fedora Update System  ---
golang-github-cznic-b-0-0.1.20170413.git6955404.fc24 has been submitted as an
update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-900cdba78a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431741] Review Request: golang-github-cznic-b - B+ Tree implementation in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431741

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431741] Review Request: golang-github-cznic-b - B+ Tree implementation in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431741



--- Comment #5 from Fedora Update System  ---
golang-github-cznic-b-0-0.1.20170413.git6955404.fc26 has been submitted as an
update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e740cb75e8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431741] Review Request: golang-github-cznic-b - B+ Tree implementation in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431741



--- Comment #6 from Fedora Update System  ---
golang-github-cznic-b-0-0.1.20170413.git6955404.fc25 has been submitted as an
update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d0f8f446c6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1414216] Review Request: php-gettext-gettext - PHP gettext manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1414216

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-04-17 11:54:29



--- Comment #21 from Fedora Update System  ---
php-gettext-gettext-3.5.9-5.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434421] Review Request: golang-github-AudriusButkevicius-pfilter - Simple Packet Filtering package written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434421



--- Comment #7 from Fedora Update System  ---
golang-github-AudriusButkevicius-pfilter-0-0.1.20170209.git09b3cfd.fc24 has
been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a0940eda30

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434421] Review Request: golang-github-AudriusButkevicius-pfilter - Simple Packet Filtering package written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434421



--- Comment #6 from Fedora Update System  ---
golang-github-AudriusButkevicius-pfilter-0-0.1.20170209.git09b3cfd.fc25 has
been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5cea2dc37b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434421] Review Request: golang-github-AudriusButkevicius-pfilter - Simple Packet Filtering package written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434421



--- Comment #5 from Fedora Update System  ---
golang-github-AudriusButkevicius-pfilter-0-0.1.20170209.git09b3cfd.fc26 has
been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0b67dfff19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434421] Review Request: golang-github-AudriusButkevicius-pfilter - Simple Packet Filtering package written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434421

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442547] Review Request: gsignond - GSignOn daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442547

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Neal Gompa  ---
Aside from the already known issues, fedora-review is happy with it.

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431763] Review Request: golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431763



--- Comment #5 from Fabio Valentini  ---
Thanks for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442804] New: Review Request: nodejs-to-regex-range - Returns a regex-compatible range from two numbers , min and max

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442804

Bug ID: 1442804
   Summary: Review Request: nodejs-to-regex-range - Returns a
regex-compatible range from two numbers, min and max
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Blocks: 956806 (nodejs-reviews), 1387531 (Node-RED)



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-to-regex-range/nodejs-to-regex-range.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-to-regex-range/nodejs-to-regex-range-1.0.2-1.fc27.src.rpm
Description: Returns a regex-compatible range from two numbers, min and max
Fedora Account System Username: jsmith


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1387531
[Bug 1387531] Package tracker for supporting Node-RED
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431763] Review Request: golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431763

Athos Ribeiro  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Athos Ribeiro  ---
Package looks good now!

Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431763] Review Request: golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431763



--- Comment #3 from Fabio Valentini  ---
Spec URL:
https://decathorpe.fedorapeople.org/packages/golang-github-oschwald-geoip2-golang.spec

SRPM URL:
https://decathorpe.fedorapeople.org/packages/golang-github-oschwald-geoip2-golang-1.0.0-1.20170314.git0fd242d.fc26.src.rpm

- Redundant conditional removed
- Release: tag fixed
- updated to newer snapshot

For now I would rather not include another git repository snapshot tarball for
the test data. Maybe I'll add it in the future, if there is demand for enabling
the tests.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437389] Review Request: golang-github-ccding-go-stun - STUN client ( RFC 3489 and RFC 5389) implementation in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437389



--- Comment #3 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-ccding-go-stun

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431741] Review Request: golang-github-cznic-b - B+ Tree implementation in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431741



--- Comment #4 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-cznic-b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434421] Review Request: golang-github-AudriusButkevicius-pfilter - Simple Packet Filtering package written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434421



--- Comment #4 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-AudriusButkevicius-pfilter

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437389] Review Request: golang-github-ccding-go-stun - STUN client ( RFC 3489 and RFC 5389) implementation in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437389



--- Comment #2 from Fabio Valentini  ---
Thanks for the review, I've already incorporated fixes for the issues you've
pointed out in the linked .spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431763] Review Request: golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431763



--- Comment #2 from Athos Ribeiro  ---
Hi Fabio,

I am taking this one.

- Conditional clauses on line 144 are duplicated.

- The guidelines for post releases have changed [1], in special, the release
tag for post release should not be in X.Y format (use just the X) and the date
the snapshot was taken must be included there.

- The test data could be included as a separate source file, but that's not a
blocker here.

[1] https://fedoraproject.org/wiki/Packaging:Versioning

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431761] Review Request: golang-github-AudriusButkevicius-cli - Small library for building CLI apps in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431761



--- Comment #10 from Fedora Update System  ---
golang-github-AudriusButkevicius-cli-1.0.0-1.20140727.git7f561c7.fc24 has been
submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-de3fe47b79

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433617] Review Request: python-proselint - A linter for prose

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433617



--- Comment #2 from Peter Oliver  ---
Spec URL: https://pagure.io/python-proselint/raw/master/f/python-proselint.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431761] Review Request: golang-github-AudriusButkevicius-cli - Small library for building CLI apps in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431761



--- Comment #9 from Fedora Update System  ---
golang-github-AudriusButkevicius-cli-1.0.0-1.20140727.git7f561c7.fc25 has been
submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c4080d8884

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431761] Review Request: golang-github-AudriusButkevicius-cli - Small library for building CLI apps in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431761



--- Comment #8 from Fedora Update System  ---
golang-github-AudriusButkevicius-cli-1.0.0-1.20140727.git7f561c7.fc26 has been
submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-067b202929

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431761] Review Request: golang-github-AudriusButkevicius-cli - Small library for building CLI apps in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431761

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431741] Review Request: golang-github-cznic-b - B+ Tree implementation in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431741



--- Comment #3 from Fabio Valentini  ---
Thanks for the review, I've already incorporated fixes for the issues you've
pointed out in the linked .spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1364170] Review Request: nodejs-expand-range - Fast, bash-like range expansion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364170



--- Comment #2 from Jared Smith  ---
*** Bug 1433775 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433776] Review Request: nodejs-expand-range - Expand a range of numbers or letters, uppercase or lowercase

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433776

Jared Smith  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||jsmith.fed...@gmail.com
 Resolution|--- |DUPLICATE
Last Closed||2017-04-17 10:21:17



--- Comment #1 from Jared Smith  ---


*** This bug has been marked as a duplicate of bug 1364170 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433775] Review Request: nodejs-expand-range - Expand a range of numbers or letters, uppercase or lowercase

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433775

Jared Smith  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||jsmith.fed...@gmail.com
 Resolution|--- |DUPLICATE
Last Closed||2017-04-17 10:21:49



--- Comment #1 from Jared Smith  ---


*** This bug has been marked as a duplicate of bug 1364170 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1364170] Review Request: nodejs-expand-range - Fast, bash-like range expansion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364170

Jared Smith  changed:

   What|Removed |Added

 Blocks||1433764
 CC||hho...@redhat.com



--- Comment #1 from Jared Smith  ---
*** Bug 1433776 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1433764
[Bug 1433764] Tracker for packaging nodemon and dependencies
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434421] Review Request: golang-github-AudriusButkevicius-pfilter - Simple Packet Filtering package written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434421



--- Comment #3 from Fabio Valentini  ---
Thanks for the review, I've already incorporated fixes for the issues you've
pointed out in the linked .spec file.

I will leave the unit test-specific parts of the .spec file (even though they
are disabled), since it's easier to enable unit tests that way if upstream
decides to add some in the future.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437389] Review Request: golang-github-ccding-go-stun - STUN client ( RFC 3489 and RFC 5389) implementation in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437389

Athos Ribeiro  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Athos Ribeiro  ---
Hello Fabio,

I am taking this one.

Conditionals on line 130 are duplicated. This could be fixed to clean up the
spec file.

The Release tag must be updated to comply with the guidelines. Note that this
is a must item [1]

Other than that, the package looks good. I will approve the package and trust
you will perform the necessary changes.

Approved.

[1] https://fedoraproject.org/wiki/Packaging:Versioning

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.

[Bug 986550] Review Request: python-xmp-toolkit - Python toolkit for working with XMP metadata

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=986550

Parag AN(पराग)  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |201449 (FE-DEADREVIEW)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431741] Review Request: golang-github-cznic-b - B+ Tree implementation in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431741

Athos Ribeiro  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Athos Ribeiro  ---
Hello Fabio,

I am taking this review.

- The Revision shuld be updated to reflect new guidelines. For pre-releases
packages, the date MUST be included in the tag.

- The conditional in line 142 seems to be duplicated, that could be fixed to
clean up the spec file.

Other than that, the package looks good. I will trust you will perform the
necessary changes before uploading the package.

Approved.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: 

[Bug 1442547] Review Request: gsignond - GSignOn daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442547



--- Comment #7 from Fabio Valentini  ---
- added: Requires: dbus%{?isa}
- removed asterisk from doc directory
- filed bug about setuid / file caps upstream at [1]

[1]: https://gitlab.com/accounts-sso/gsignond/issues/10

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 615669] Review Request: perl-Crypt-Cracklib - perl module to interact with libcrack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=615669



--- Comment #29 from Fedora Update System  ---
perl-Crypt-Cracklib-1.7-19.el7 has been submitted as an update to Fedora EPEL
7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-56b4c757c7

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434421] Review Request: golang-github-AudriusButkevicius-pfilter - Simple Packet Filtering package written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434421



--- Comment #2 from Athos Ribeiro  ---
Also, consider changing the revision tag with the new guidelines, including the
date the snapshot was taken.


Sorry for the spam :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434421] Review Request: golang-github-AudriusButkevicius-pfilter - Simple Packet Filtering package written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434421

Athos Ribeiro  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Athos Ribeiro  ---
Hello Fabio,

I am taking this one.

- The conditional statement on line 29 seems to be duplicated.

- There's no test suite available for the package. The macro with all the
unit-tests subpackage entries is disabled.

You may want to consider cleaning the duplications.

The package looks good. Approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all 

[Bug 1367033] Review Request: dumb-init - entrypoint wrapper for docker that pass signal and handle zombies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367033

Jonny Heggheim  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2017-04-17 09:17:37



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 986550] Review Request: python-xmp-toolkit - Python toolkit for working with XMP metadata

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=986550

Lars Kiesow  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
  Flags|needinfo?(lkie...@uos.de)   |
Last Closed||2017-04-17 09:15:19



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442547] Review Request: gsignond - GSignOn daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442547



--- Comment #6 from Neal Gompa  ---
Issues:


>[!]: Package must own all directories that it creates.
> Note: Directories without known owners: /usr/share/gir-1.0, /usr/share
> /gtk-doc, /usr/share/dbus-1, /usr/share/vala/vapi,
> /usr/share/dbus-1/services, /usr/share/gtk-doc/html/gsignond,
> /usr/share/gtk-doc/html, /usr/lib64/girepository-1.0,
> /usr/share/dbus-1/interfaces, /usr/share/vala

Some of the ownership issues can be ignored (like /usr/share/vala,
/usr/share/vala/vapi, /usr/share/gtk-doc, /usr/share/gtk-doc/html,
/usr/lib64/girepository-1.0).

However, gsignond needs a runtime requires for dbus%{?_isa}, as it is necessary
for its functionality to be useful.

The doc subpackage file entry needs the asterisk removed, because it's
preventing RPM from considering that it should own
/usr/share/gtk-doc/html/gsignond too.

>Rpmlint: 
> gsignond.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/gsignond

Apparently, gsignond was a setuid binary on purpose. In the code, it uses
seteuid() in daemon/main.c and common/gsignond-storage-manager.c.

However, it seems to gracefully fail when it does that. That said, apparently
it's not doing setegid() before using seteuid() in
common/gsignond-storage-manager.c (or in the ostro/tizen code, but I don't care
much about them). From what I can tell, it's setuid so that it can drop
privileges as a daemon and set storage directories to be individually owned by
specific users.

In Fedora, we prefer if this can function with file capabilities, as they are
more granular and when used well, can limit the damage caused by
vulnerabilities to privileged applications. Please file a bug upstream to see
if this can be appropriately resolved.

Action items:

* Fix the directory ownership issues
* File a bug upstream about the rpmlint error and to request gsignond to work
with file caps instead.
- https://fedoraproject.org/wiki/Features/RemoveSETUID
- https://www.mankier.com/7/capabilities

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441222] Review Request: qtermwidget-qt4 - Qt4 terminal widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441222



--- Comment #6 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/qtermwidget-qt4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431761] Review Request: golang-github-AudriusButkevicius-cli - Small library for building CLI apps in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431761



--- Comment #7 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-AudriusButkevicius-cli

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442743] Review Request: python-bz2file - Read and write bzip2-compressed files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442743

Björn "besser82" Esser  changed:

   What|Removed |Added

 Blocks||1124239




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1124239
[Bug 1124239] python-gensim-2.0.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442743] New: Review Request: python-bz2file - Read and write bzip2-compressed files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442743

Bug ID: 1442743
   Summary: Review Request: python-bz2file - Read and write
bzip2-compressed files
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: besse...@fedoraproject.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Description:

  bz2file is a Python library for reading and writing bzip2-compressed files.

  It contains a drop-in replacement for the file interface in the standard
  library’s bz2 module, including features from the latest development
  version of CPython that are not available in older releases.


Koji Build:

  https://koji.fedoraproject.org/koji/taskinfo?taskID=19040607


Issues:

  No known issues.  Rpmlint has some false positive complaints.


FAS-User:

  besser82


Urls:

  Spec URL: 
https://pagure.io/besser82/package-review/raw/master/f/python-bz2file.spec
  SRPM URL: 
https://pagure.io/besser82/package-review/raw/master/f/python-bz2file-0.98-0.1.fc27.src.rpm


Thanks for review in advance!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409647] Review Request: libimagequant - Palette quantization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409647



--- Comment #11 from Sergio Monteiro Basto  ---
(In reply to Sandro Mani from comment #10)
> Ah indeed, looks like libimagequant isn't an integral part of pngquant, but
> simply bundled.

just since 2.8.x

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442547] Review Request: gsignond - GSignOn daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442547



--- Comment #5 from Fabio Valentini  ---
I think I have incorporated fixes for all the issues you pointed out. Also, I
have disabled the Ostro OS and Tizen extensions. Links are the same.

New scratch build, with noarch -doc and -defautl-config subpackages:
https://koji.fedoraproject.org/koji/taskinfo?taskID=19040060

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409647] Review Request: libimagequant - Palette quantization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409647



--- Comment #10 from Sandro Mani  ---
Ah indeed, looks like libimagequant isn't an integral part of pngquant, but
simply bundled.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368911] Review Request: python-mpd2 - It is a Python library which provides a client interface for MPD

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368911



--- Comment #3 from Parag AN(पराग)  ---
any updates here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381430] Review Request: python3-prctl - Python(ic) interface to the linux prctl syscall

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381430



--- Comment #7 from Parag AN(पराग)  ---
any updates here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1294216] Review Request: xcape - Use a modifier key as a different key when quickly pressed and released

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294216

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|panem...@gmail.com  |nob...@fedoraproject.org
  Flags|fedora-review?  |



--- Comment #4 from Parag AN(पराग)  ---
Sorry I am just clearing bug tracker to give preference to priority bugs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1317286] Review Request: hunspell-ie - Interlingue hunspell dictionary

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1317286

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Blocks|177841 (FE-NEEDSPONSOR) |201449 (FE-DEADREVIEW)
 Resolution|--- |NOTABUG
  Flags|needinfo?(mistresssilvara@h |
   |otmail.com) |
Last Closed||2017-04-17 03:32:47



--- Comment #8 from Parag AN(पराग)  ---
No updates here, Closing this review. If needed please reopen this review.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428693] Review Request: netpgp - Freely licensed PGP implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428693



--- Comment #9 from Parag AN(पराग)  ---
Any updates here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org