[Bug 1450633] Review request: keepassxc - Cross-platform password manager
https://bugzilla.redhat.com/show_bug.cgi?id=1450633 Germano Massullo changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1440780] Review Request: mod_http2 - module implementing HTTP/ 2 for Apache 2
https://bugzilla.redhat.com/show_bug.cgi?id=1440780 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System --- mod_http2-1.10.1-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8f2df0e3f2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1450482] Review Request: pix - Image management application
https://bugzilla.redhat.com/show_bug.cgi?id=1450482 --- Comment #12 from Fedora Update System --- pix-1.4.1-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1450477] Review Request: ratbagd - the libratbag daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1450477 Peter Hutterer changed: What|Removed |Added Assignee|nob...@fedoraproject.org|peter.hutte...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1451138] Review Request: libomp - default OpenMP runtime used by clang
https://bugzilla.redhat.com/show_bug.cgi?id=1451138 Satish Balay changed: What|Removed |Added CC||ba...@fastmail.fm --- Comment #1 from Satish Balay --- [this is not a review - but feedback] balay@asterix /home/balay/rpmbuild/RPMS/x86_64 $ rpm -qlp libomp-4.0.0-1.fc26.x86_64.rpm /usr/lib64/libomp.so balay@asterix /home/balay/rpmbuild/RPMS/x86_64 $ rpm -qlp libomp-devel-4.0.0-1.fc26.x86_64.rpm /usr/include/omp.h balay@asterix /home/balay/rpmbuild/RPMS/x86_64 $ The location of these files does not look correct. I would think /usr/include/omp.h would conflict with omp.h from gomp Looking at gomp organization I see: balay@asterix /home/balay $ locate libgomp.so /usr/lib/gcc/x86_64-redhat-linux/7/libgomp.so /usr/lib/gcc/x86_64-redhat-linux/7/32/libgomp.so /usr/lib64/libgomp.so.1 /usr/lib64/libgomp.so.1.0.0 balay@asterix /home/balay $ locate /omp.h /usr/lib/gcc/x86_64-redhat-linux/7/include/omp.h balay@asterix /home/balay $ So presumably clang omp include/libraries should be installed in clang include/library locations? Here is how llvm binary distribution is packaged balay@asterix /home/balay/soft $ find clang+llvm-4.0.0-x86_64-linux-gnu-debian8 -type f -name omp.h clang+llvm-4.0.0-x86_64-linux-gnu-debian8/lib/clang/4.0.0/include/omp.h balay@asterix /home/balay/soft $ find clang+llvm-4.0.0-x86_64-linux-gnu-debian8 -type f -name "libomp*" clang+llvm-4.0.0-x86_64-linux-gnu-debian8/lib/libomp.so balay@asterix /home/balay/soft $ And perhaps the package should have a llvm prefix - say llvm-libomp? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1368855] Review Request: radare2 - The reverse engineering framework
https://bugzilla.redhat.com/show_bug.cgi?id=1368855
--- Comment #12 from Michael Scherer ---
> No it should not be dropped, otherwise the files, which are installed there
> by
> the radare2 during the installation would be treated as installed, but
> unpackaged.
I know that some upstream do that, but that mean this will be broken (or
rather, not coherent) if %_docdir_fmt is changed, like on EL, where the value
is %{NAME}-%{VERSION} while on Fedora, that's %{NAME}.
Hardcoding "%{_datadir}/doc/%{name}" is not correct (even if in practice, it
would likely work).
> I have tried to list the original licenses, but anyway due to theviral nature
> of GPL I believe that as the original project released all those with GPL-ed
> project, these are probably GPL-ed as well.
That's not my understanding of the guidelines, as it clearly say all licenses
must be listed in the tag, and I am sure that we should stick to it when it
come to licensing. The comments can't be queried in case of problem with one
license or anything, and I think that's the main use of that tag.
Or it can be used to verify that all licenses text that requires to be included
are included in the rpm, as that's a requirement from both the GPL, the LGPL
and the Apache License 2.0.
Speaking of that, the text of the Apache 2 license is missing from the package,
since there is only GPL v3 and LGPL. That's a issue upstream, but technically,
that's a license violation (as that's one of the few requirements of the Apache
2.0 license)
Also, there is a few small error in the spec:
# shlr/zip/zlib - 3 clause BSD (system installed sared zlib is used instead)
=> shared ?
# shlr/www/enyo/vendors/jquery.min.js - Aplache License version 2.0
Apache ?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1447213] Review Request: gimp-wavelet-decompose - Decomposing image plug-in for Gimp
https://bugzilla.redhat.com/show_bug.cgi?id=1447213 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-05-15 20:54:29 --- Comment #10 from Fedora Update System --- gimp-wavelet-decompose-0-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1451156] New: Review Request: ipv6gen - IPv6 prefix generator
https://bugzilla.redhat.com/show_bug.cgi?id=1451156 Bug ID: 1451156 Summary: Review Request: ipv6gen - IPv6 prefix generator Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: gho...@fedoraproject.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://fedorapeople.org/~gholms/review/ipv6gen-1.0-1.spec SRPM URL: https://fedorapeople.org/~gholms/review/ipv6gen-1.0-1.src.rpm Description: ipv6gen is a tool which generates list of IPv6 prefixes using the process described by RFC 3531. Fedora Account System Username: gholms rpmlint output: ipv6gen.noarch: E: incorrect-fsf-address /usr/share/licenses/ipv6gen/LICENSE ipv6gen.noarch: W: manual-page-warning /usr/share/man/man1/ipv6gen.1.gz 48: warning: macro `Ed' not defined ipv6gen.noarch: W: no-manual-page-for-binary check-overlap ipv6gen.src: W: no-%build-section -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1451134] Review Request: lightdm-autologin-greeter - Autologin greeter using LightDM
https://bugzilla.redhat.com/show_bug.cgi?id=1451134
Garrett Holmstrom changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #5 from Garrett Holmstrom ---
Eh, as long as I'm here I might as well finish the review off. Sorry, Fabio.
Mandatory review guidelines:
ok - rpmlint output:
W: spelling-error %description -l en_US nodm -> nod, node, nods
W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log
out
W: spelling-error %description -l en_US startup -> start up, start-up,
upstart
W: no-manual-page-for-binary lightdm-autologin-greeter
ok - Spec file name matches base package name
ok - License is acceptable (MIT)
ok - License field in spec is correct
The upstream project is a derivative of a GPLv3+ project
ok - License files included in package if included in source package
ok - License files installed when any subpackage combination is installed
ok - Spec written in American English
ok - Spec is legible
ok - Sources match upstream SHA256 unless altered to fix permissibility issues
Theirs: c0b0be8d5d59cd44f7f4e52ab1bd27c985a8263bc6b2bcd1510e9a100a113214
Yours: c0b0be8d5d59cd44f7f4e52ab1bd27c985a8263bc6b2bcd1510e9a100a113214
ok - Build succeeds on at least one primary arch
ok - Build succeeds on all primary arches or has ExcludeArch + justification
ok - BuildRequires correct, justified where necessary
-- - Locales handled with %find_lang, not %_datadir/locale/*
-- - %post, %postun call ldconfig if package contains shared .so files
ok - No bundled libs
-- - Relocatability is justified
-- - Package owns all directories it creates
ok - No duplication in %files unless necessary for license files
ok - File permissions are sane
ok - Package contains permissible code or content
-- - Large docs go in -doc subpackage
-- - %doc files not required at runtime
-- - Static libs go in -static package or virtual Provides
-- - Development files go in -devel package
-- - -devel packages Require base with fully-versioned dependency, %_isa
ok - No .la files
-- - GUI app uses .desktop file, installs it with desktop-file-install
-- - File list does not conflict with other packages' without justification
ok - File names are valid UTF-8
Optional review guidelines:
-- - Query upstream about including missing license files
-- - Translations of description, summary
ok - Builds in mock
ok - Builds on all arches
-- - Scriptlets are sane
-- - Subpackages require base with fully-versioned dependency if sensible
-- - .pc file subpackage placement is sensible
ok - No file deps outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin
-- - Include man pages if available
Naming guidelines:
ok - Package names use only a-zA-Z0-9-._+ subject to restrictions on -._+
ok - Package names are sane
ok - No naming conflicts
ok - Version is sane
ok - Version does not contain ~
ok - Release is sane
ok - %dist tag
ok - Case used only when necessary
-- - Package names follow applicable language/addon rules
Packaging guidelines:
ok - Useful without external bits
ok - No kmods
-- - Pre-built binaries, libs removed in %prep
ok - Sources contain only redistributable code or content
-- - Pre-generated code contains original sources
ok - Spec format is sane
-- - noarch package with unported deps has correct ExclusiveArch
-- - Arch-specific sources/patches are applied, not included, conditionally
ok - Package obeys FHS, except libexecdir, /run, /usr/target
-- - %{_prefix}/lib only used for multilib-exempt packages
-- - Programs run before FS mounting use /run instead of /var/run
ok - No files under /srv, /usr/local, /home
-- - Files under /opt constrained to an approved /opt/fedora subdir
-- - File dependencies not broken by /usr move
ok - No BuildRoot, Group, %clean, Packager, Vendor, Copyright, Prereq
ok - Summary does not end in a period
ok - Requires correct, justified where necessary
-- - Recommends, Suggests, Supplements, Enhances are sane
ok - No boolean dependencies
ok - Automatic Requires, Provides filtered if necessary
ok - BuildRequires lack %{_isa}
-- - BuildRequires: pkgconfig(foo) where necessary
ok - Summary, description do not use trademarks incorrectly
ok - All relevant documentation is packaged, appropriately marked with %doc
ok - Relative path %doc files and %_pkgdocdir not mixed
ok - Doc files do not drag in extra dependencies (e.g. due to +x)
ok - Changelog in a prescribed format
-- - Code compilable with gcc is compiled with gcc
-- - Build honors applicable compiler flags or justifies otherwise
-- - PIE used for long-running/root daemons, setuid/filecap programs
-- - Useful -debuginfo package or disabled and justified
-- - Shared libs are versioned
ok - No static executables (except OCaml)
ok - System libraries used when supported by upstream
-- - Bundled libraries have Provides, link to upstream refusal to unbundle
ok - No bund
[Bug 1451134] Review Request: lightdm-autologin-greeter - Autologin greeter using LightDM
https://bugzilla.redhat.com/show_bug.cgi?id=1451134 --- Comment #4 from Neal Gompa --- Gah, I thought I had gotten all the "behaviours"... Fixed that and rewrapped the description accordingly. Same links as earlier, reposted... Spec URL: http://kinginuyasha.enanocms.org/downloads/lightdm-autologin-greeter.spec SRPM URL: http://kinginuyasha.enanocms.org/downloads/lightdm-autologin-greeter-1.0-1.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1451134] Review Request: lightdm-autologin-greeter - Autologin greeter using LightDM
https://bugzilla.redhat.com/show_bug.cgi?id=1451134 Garrett Holmstrom changed: What|Removed |Added Assignee|gho...@fedoraproject.org|decatho...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1451134] Review Request: lightdm-autologin-greeter - Autologin greeter using LightDM
https://bugzilla.redhat.com/show_bug.cgi?id=1451134
Garrett Holmstrom changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||gho...@fedoraproject.org
Assignee|decatho...@gmail.com|gho...@fedoraproject.org
--- Comment #3 from Garrett Holmstrom ---
I had already completed the review at the time you took this bug, so here it is
to save everyone the time. All that needs fixing is the spelling of
"behaviour".
The package's description exceeds the 80-character line length limit, but only
once %{name} is expanded. The packaging guidelines are unclear as to whether
that limit applies only to the spec file or to the description that people will
see, so while we shouldn't block the review on this, I recommend rewrapping it
anyway so people on text consoles don't wind up with ragged text.
Mandatory review guidelines:
NO - rpmlint output:
W: spelling-error %description -l en_US nodm -> nod, node, nods
W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log
out
W: spelling-error %description -l en_US startup -> start up, start-up,
upstart
W: spelling-error %description -l en_US behaviour -> behavior
E: description-line-too-long C lightdm-autologin-greeter is a minimal
greeter for LightDM that has the same autologin
W: no-manual-page-for-binary lightdm-autologin-greeter
ok - Spec file name matches base package name
ok - License is acceptable (MIT)
ok - License field in spec is correct
The upstream project is a derivative of a GPLv3+ project
ok - License files included in package if included in source package
ok - License files installed when any subpackage combination is installed
NO - Spec written in American English
"behaviour" in description should be "behavior"
ok - Spec is legible
ok - Sources match upstream SHA256 unless altered to fix permissibility issues
Theirs: c0b0be8d5d59cd44f7f4e52ab1bd27c985a8263bc6b2bcd1510e9a100a113214
Yours: c0b0be8d5d59cd44f7f4e52ab1bd27c985a8263bc6b2bcd1510e9a100a113214
ok - Build succeeds on at least one primary arch
ok - Build succeeds on all primary arches or has ExcludeArch + justification
ok - BuildRequires correct, justified where necessary
-- - Locales handled with %find_lang, not %_datadir/locale/*
-- - %post, %postun call ldconfig if package contains shared .so files
ok - No bundled libs
-- - Relocatability is justified
-- - Package owns all directories it creates
ok - No duplication in %files unless necessary for license files
ok - File permissions are sane
ok - Package contains permissible code or content
-- - Large docs go in -doc subpackage
-- - %doc files not required at runtime
-- - Static libs go in -static package or virtual Provides
-- - Development files go in -devel package
-- - -devel packages Require base with fully-versioned dependency, %_isa
ok - No .la files
-- - GUI app uses .desktop file, installs it with desktop-file-install
-- - File list does not conflict with other packages' without justification
ok - File names are valid UTF-8
Optional review guidelines:
-- - Query upstream about including missing license files
-- - Translations of description, summary
ok - Builds in mock
ok - Builds on all arches
-- - Scriptlets are sane
-- - Subpackages require base with fully-versioned dependency if sensible
-- - .pc file subpackage placement is sensible
ok - No file deps outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin
-- - Include man pages if available
Naming guidelines:
ok - Package names use only a-zA-Z0-9-._+ subject to restrictions on -._+
ok - Package names are sane
ok - No naming conflicts
ok - Version is sane
ok - Version does not contain ~
ok - Release is sane
ok - %dist tag
ok - Case used only when necessary
-- - Package names follow applicable language/addon rules
Packaging guidelines:
ok - Useful without external bits
ok - No kmods
-- - Pre-built binaries, libs removed in %prep
ok - Sources contain only redistributable code or content
-- - Pre-generated code contains original sources
ok - Spec format is sane
-- - noarch package with unported deps has correct ExclusiveArch
-- - Arch-specific sources/patches are applied, not included, conditionally
ok - Package obeys FHS, except libexecdir, /run, /usr/target
-- - %{_prefix}/lib only used for multilib-exempt packages
-- - Programs run before FS mounting use /run instead of /var/run
ok - No files under /srv, /usr/local, /home
-- - Files under /opt constrained to an approved /opt/fedora subdir
-- - File dependencies not broken by /usr move
ok - No BuildRoot, Group, %clean, Packager, Vendor, Copyright, Prereq
ok - Summary does not end in a period
ok - Requires correct, justified where necessary
-- - Recommends, Suggests, Supplements, Enhances are sane
ok - No boolean dependencies
ok - Automatic Requires, Provides filter
[Bug 1448997] Review Request: lua-bit32 - Backport of Lua bit manipulation library introduced in 5.2
https://bugzilla.redhat.com/show_bug.cgi?id=1448997 --- Comment #9 from Fedora Update System --- neovim-0.2.0-2.el7 lua-bit32-5.3.0-2.el7 lua-mpack-1.0.4-2.el7 libtermkey-0.18-3.el7 libvterm-0-0.2.bzr681.el7 unibilium-1.2.0-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-e55d6f7a83 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1448997] Review Request: lua-bit32 - Backport of Lua bit manipulation library introduced in 5.2
https://bugzilla.redhat.com/show_bug.cgi?id=1448997 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1445506] Review Request: python-fedmsg-rabbitmq-serializer - fedmsg consumer to serialize bus messages into a rabbitmq worker queue
https://bugzilla.redhat.com/show_bug.cgi?id=1445506
--- Comment #3 from Athos Ribeiro ---
Hi Adam,
Thanks for the changes!
> I've fixed all but the last comment, I don't know what you meant by "It
> would be nice to have the python2- subpackage Requires: under the python2
> subpackage itself"
The "Requires:" lines should be after "%package -n python2-%{srcname}", so
whoever is maintaining the package by the time upstream provides a python3
package won't make the mistake to have the python3 package requiring the
python2 dependencies as well. This is not a MUST item for now though. I will
proceed with the review asap :)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1451075] Review Request: python-pankoclient Pyton API client for Openstack Panko Events Service
https://bugzilla.redhat.com/show_bug.cgi?id=1451075 Haïkel Guémar changed: What|Removed |Added Status|NEW |ASSIGNED CC||karlthe...@gmail.com Assignee|nob...@fedoraproject.org|karlthe...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1445506] Review Request: python-fedmsg-rabbitmq-serializer - fedmsg consumer to serialize bus messages into a rabbitmq worker queue
https://bugzilla.redhat.com/show_bug.cgi?id=1445506 --- Comment #2 from Adam Miller --- I've fixed all but the last comment, I don't know what you meant by "It would be nice to have the python2- subpackage Requires: under the python2 subpackage itself" Spec URL: https://maxamillion.fedorapeople.org/python-fedmsg-rabbitmq-serializer.spec SRPM URL: https://maxamillion.fedorapeople.org/python-fedmsg-rabbitmq-serializer-0.0.5-1.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431740] Review Request: golang-github-cznic-internal - Shared dependencies for other cznic Go libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1431740 --- Comment #5 from Fabio Valentini --- The initial build for rawhide failed due to a test failure on s390. I suspect the issue is a race condition in the code (or in one of the tests). I reported the issue upstream at [1] and will try again to build the package once this has been resolved. [1]: https://github.com/cznic/internal/issues/4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1451138] Review Request: libomp - default OpenMP runtime used by clang
https://bugzilla.redhat.com/show_bug.cgi?id=1451138 Tom Stellard changed: What|Removed |Added Blocks||1409871 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1409871 [Bug 1409871] [RFE] enable openmp support -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1451138] New: Review Request: libomp - default OpenMP runtime used by clang
https://bugzilla.redhat.com/show_bug.cgi?id=1451138 Bug ID: 1451138 Summary: Review Request: libomp - default OpenMP runtime used by clang Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: tstel...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/tstellar/llvm/libomp.git/tree/libomp.spec?h=f26 SRPM URL: https://copr-be.cloud.fedoraproject.org/results/tstellar/llvm/fedora-26-x86_64/00552163-libomp/libomp-4.0.0-1.fc26.src.rpm Description: libomp is the default OpenMP runtime used by clang. Fedora Account System Username:tstellar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1451134] Review Request: lightdm-autologin-greeter - Autologin greeter using LightDM
https://bugzilla.redhat.com/show_bug.cgi?id=1451134 Fabio Valentini changed: What|Removed |Added CC||decatho...@gmail.com Assignee|nob...@fedoraproject.org|decatho...@gmail.com Flags||fedora-review? --- Comment #2 from Fabio Valentini --- Taken. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1450691] Review Request: python-pyrpmmd - Python module for reading rpm-md repo data
https://bugzilla.redhat.com/show_bug.cgi?id=1450691 Fabio Valentini changed: What|Removed |Added CC||decatho...@gmail.com Assignee|nob...@fedoraproject.org|decatho...@gmail.com Flags||fedora-review? --- Comment #1 from Fabio Valentini --- Taken. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1451134] Review Request: lightdm-autologin-greeter - Autologin greeter using LightDM
https://bugzilla.redhat.com/show_bug.cgi?id=1451134 --- Comment #1 from Neal Gompa --- Updated to 1.0 release: Spec URL: http://kinginuyasha.enanocms.org/downloads/lightdm-autologin-greeter.spec SRPM URL: http://kinginuyasha.enanocms.org/downloads/lightdm-autologin-greeter-1.0-1.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1449882] Review Request: python-lcms2 - Simplified Python binding to LittleCMS2 library
https://bugzilla.redhat.com/show_bug.cgi?id=1449882 Luya Tshimbalanga changed: What|Removed |Added Summary|Review Request: python-lcm2 |Review Request: |- Simplified Python|python-lcms2 - Simplified |binding to LittleCMS2 |Python binding to |library |LittleCMS2 library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1451134] New: Review Request: lightdm-autologin-greeter - Autologin greeter using LightDM
https://bugzilla.redhat.com/show_bug.cgi?id=1451134 Bug ID: 1451134 Summary: Review Request: lightdm-autologin-greeter - Autologin greeter using LightDM Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ngomp...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://kinginuyasha.enanocms.org/downloads/lightdm-autologin-greeter.spec SRPM URL: http://kinginuyasha.enanocms.org/downloads/lightdm-autologin-greeter-0-0.git20170515.22021f3.1.fc25.src.rpm Description: lightd-autologin-greeter is a minimal greeter for LightDM that has the same autologin behavior as nodm, but being based on LightDM it stays on top of modern display manager requirements. Fedora Account System Username: ngompa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1451124] (cni) Review Request: containernetworking - CNI Plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1451124 Timothy St. Clair changed: What|Removed |Added Priority|unspecified |medium -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1450633] Review request: keepassxc - Cross-platform password manager
https://bugzilla.redhat.com/show_bug.cgi?id=1450633 Mukundan Ragavan changed: What|Removed |Added Status|NEW |ASSIGNED CC||nonamed...@gmail.com Assignee|nob...@fedoraproject.org|nonamed...@gmail.com --- Comment #2 from Mukundan Ragavan --- I am taking this package for review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1451124] (cni) Review Request: containernetworking - CNI Plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1451124 Timothy St. Clair changed: What|Removed |Added CC||jchal...@redhat.com, ||tstcl...@heptio.com Assignee|nob...@fedoraproject.org|jchal...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431740] Review Request: golang-github-cznic-internal - Shared dependencies for other cznic Go libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1431740 --- Comment #4 from Gwyn Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-cznic-internal -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1451124] New: (cni) Review Request: containernetworking - CNI Plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1451124 Bug ID: 1451124 Summary: (cni) Review Request: containernetworking - CNI Plugins Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: tstcl...@heptio.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://github.com/timothysc/containernetworking/blob/master/containernetworking.spec SRPM URL: https://github.com/timothysc/containernetworking/raw/master/containernetworking-0.5.1-1.fc27.src.rpm Description: The CNI (Container Network Interface) project consists of a specification and libraries for writing plugins to configure network interfaces in Linux containers, along with a number of supported plugins. CNI concerns itself only with network connectivity of containers and removing allocated resources when the container is deleted. Fedora Account System Username: tstclair -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431546] Container Review Request: python3 - Platform for building and running Python 3.5 applications
https://bugzilla.redhat.com/show_bug.cgi?id=1431546 --- Comment #9 from Gwyn Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/container/python3 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1440780] Review Request: mod_http2 - module implementing HTTP/ 2 for Apache 2
https://bugzilla.redhat.com/show_bug.cgi?id=1440780 --- Comment #12 from Fedora Update System --- mod_http2-1.10.1-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8f2df0e3f2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1440780] Review Request: mod_http2 - module implementing HTTP/ 2 for Apache 2
https://bugzilla.redhat.com/show_bug.cgi?id=1440780 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1438089] Review Request: golang-github-xtaci-kcp-go - Production-Grade Reliable-UDP Library for golang
https://bugzilla.redhat.com/show_bug.cgi?id=1438089 Fabio Valentini changed: What|Removed |Added Blocks||182235 (FE-Legal) --- Comment #4 from Fabio Valentini --- All pictures are only referenced and used by the README.md file. They aren't part of the produced binary RPMs, only of the upstream source tarball. I found the original image source (Photo by Alfred Eisenstaedt/The LIFE Picture Collection/Getty Images), and the picture was taken in 1963. I'm not sure how to proceed here, since the pictures aren't used by my packaging at all - do I have to produce a "special" tarball that differs from upstream's sources, just because of a file that I don't use anyway? Blocking FE-Legal to get a definitive answer (because I'd rather not create a downstream tarball for no good reason). Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431740] Review Request: golang-github-cznic-internal - Shared dependencies for other cznic Go libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1431740 --- Comment #3 from Fabio Valentini --- Thanks for the review! I've fixed the issues you pointed out. Final versions for importing: Spec URL: https://decathorpe.fedorapeople.org/packages/golang-github-cznic-internal.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/golang-github-cznic-internal-1.0.0-1.20170124.gite5e1c3e.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1448557] Review Request: hidviz - A tool for in-depth analysis of USB HID devices communication
https://bugzilla.redhat.com/show_bug.cgi?id=1448557 --- Comment #7 from Jaroslav Škarvada --- Please try new version: Spec URL: https://jskarvad.fedorapeople.org/hidviz/hidviz.spec SRPM URL: https://jskarvad.fedorapeople.org/hidviz/hidviz-0.1.4-1.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1448557] Review Request: hidviz - A tool for in-depth analysis of USB HID devices communication
https://bugzilla.redhat.com/show_bug.cgi?id=1448557 Jaroslav Škarvada changed: What|Removed |Added Flags|needinfo?(jskarvad@redhat.c | |om) | --- Comment #6 from Jaroslav Škarvada --- (In reply to Zdenek Dohnal from comment #5) > I encountered FTBFS errors (srpm needs to be built in rawhide): Thanks for catching. > Jarda, would you mind fixing it or should I look further into it? https://github.com/ondrejbudai/libhidx/pull/8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1450482] Review Request: pix - Image management application
https://bugzilla.redhat.com/show_bug.cgi?id=1450482 --- Comment #11 from Fedora Update System --- pix-1.4.1-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1448557] Review Request: hidviz - A tool for in-depth analysis of USB HID devices communication
https://bugzilla.redhat.com/show_bug.cgi?id=1448557 Zdenek Dohnal changed: What|Removed |Added Whiteboard||NotReady -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1448557] Review Request: hidviz - A tool for in-depth analysis of USB HID devices communication
https://bugzilla.redhat.com/show_bug.cgi?id=1448557
Zdenek Dohnal changed:
What|Removed |Added
CC||jskar...@redhat.com
Flags||needinfo?(jskarvad@redhat.c
||om)
--- Comment #5 from Zdenek Dohnal ---
I encountered FTBFS errors (srpm needs to be built in rawhide):
/builddir/build/BUILD/hidviz-0.1.3/libhidx/libhidx_server/src/Server.cc: In
function 'void libhidx::server::run(std::__cxx11::string, bool)':
/builddir/build/BUILD/hidviz-0.1.3/libhidx/libhidx_server/src/Server.cc:386:14:
error: 'function' is not a member of 'std'
std::function timerHandler;
^~~~
/builddir/build/BUILD/hidviz-0.1.3/libhidx/libhidx_server/src/Server.cc:386:14:
note: suggested alternative: 'is_function'
std::function timerHandler;
^~~~
is_function
/builddir/build/BUILD/hidviz-0.1.3/libhidx/libhidx_server/src/Server.cc:386:23:
error: expected primary-expression before 'void'
std::function timerHandler;
^~~~
/builddir/build/BUILD/hidviz-0.1.3/libhidx/libhidx_server/src/Server.cc:388:9:
error: 'timerHandler' was not declared in this scope
timerHandler = [&](const asio::error_code&) {
^~~~
/builddir/build/BUILD/hidviz-0.1.3/libhidx/libhidx_server/src/Server.cc:388:9:
note: suggested alternative: 'file_handle'
timerHandler = [&](const asio::error_code&) {
^~~~
file_handle
make[2]: *** [libhidx/libhidx_server/CMakeFiles/hidx_server.dir/build.make:74:
libhidx/libhidx_server/CMakeFiles/hidx_server.dir/src/Server.cc.o] Error 1
Jarda, would you mind fixing it or should I look further into it?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1451075] New: Review Request: python-pankoclient Pyton API client for Openstack Panko Events Service
https://bugzilla.redhat.com/show_bug.cgi?id=1451075 Bug ID: 1451075 Summary: Review Request: python-pankoclient Pyton API client for Openstack Panko Events Service Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: pkila...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Description of problem: Spec URL: https://pkilambi.fedorapeople.org/python-pankoclient/python-pankoclient.spec SRPM URL: https://pkilambi.fedorapeople.org/python-pankoclient/python-pankoclient-0.3.0-1.fc25.src.rpm Description: Python API and CLI for Openstack Panko service Fedora Account System Username: pkilambi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1449882] Review Request: python-lcm2 - Simplified Python binding to LittleCMS2 library
https://bugzilla.redhat.com/show_bug.cgi?id=1449882 --- Comment #15 from Gwyn Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-lcm2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks
https://bugzilla.redhat.com/show_bug.cgi?id=1451066 Terje Røsten changed: What|Removed |Added Blocks||1450637 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1450637 [Bug 1450637] new mycli needs python-cli-helpers -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1449882] Review Request: python-lcm2 - Simplified Python binding to LittleCMS2 library
https://bugzilla.redhat.com/show_bug.cgi?id=1449882 --- Comment #14 from Luya Tshimbalanga --- Thank you for the detailed review and suggestion, Athos! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1451054] Review Request: python-terminaltables - Generate tables in terminals from list of strings
https://bugzilla.redhat.com/show_bug.cgi?id=1451054 Terje Røsten changed: What|Removed |Added Blocks||1451066 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1451066 [Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks
https://bugzilla.redhat.com/show_bug.cgi?id=1451066 Terje Røsten changed: What|Removed |Added Depends On||1451054 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1451054 [Bug 1451054] Review Request: python-terminaltables - Generate tables in terminals from list of strings -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1451066] New: Review Request: python-cli-helpers - Python helpers for common CLI tasks
https://bugzilla.redhat.com/show_bug.cgi?id=1451066 Bug ID: 1451066 Summary: Review Request: python-cli-helpers - Python helpers for common CLI tasks Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: terje...@phys.ntnu.no QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org spec: https://terjeros.fedorapeople.org/python-cli-helpers/python-cli-helpers.spec srpm: https://terjeros.fedorapeople.org/python-cli-helpers/python-cli-helpers-0.1.0-2.fc25.src.rpm koji: n/a - terminaltables not in rawhide yet desc: Python helpers for common CLI tasks user: terjeros -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1415686] Review Request: php-phpmyadmin-sql-parser - A validating SQL lexer and parser with a focus on MySQL dialect
https://bugzilla.redhat.com/show_bug.cgi?id=1415686 --- Comment #30 from Fedora Update System --- php-phpmyadmin-sql-parser-4.1.5-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-2246580be3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1451054] Review Request: python-terminaltables - Generate tables in terminals from list of strings
https://bugzilla.redhat.com/show_bug.cgi?id=1451054 Terje Røsten changed: What|Removed |Added Blocks||1444610 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1444610 [Bug 1444610] new package python-terminaltables -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1451054] New: Review Request: python-terminaltables - Generate tables in terminals from list of strings
https://bugzilla.redhat.com/show_bug.cgi?id=1451054 Bug ID: 1451054 Summary: Review Request: python-terminaltables - Generate tables in terminals from list of strings Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: terje...@phys.ntnu.no QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org spec: https://terjeros.fedorapeople.org/python-terminaltables/python-terminaltables.spec srpm: https://terjeros.fedorapeople.org/python-terminaltables/python-terminaltables-3.1.0-2.fc25.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=19572520 desc: Generate tables in terminals from list of strings user: terjeros -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1444925] Review Request: python-rpm-generators - Requires and Provides generators for Python RPMs
https://bugzilla.redhat.com/show_bug.cgi?id=1444925 --- Comment #16 from Tomas Orsava --- Build in rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=19570035 Will close the issue when the python2, python3 and rpm packages are updated as well. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1404305] Review Request: bcc - BPF Compiler Collection
https://bugzilla.redhat.com/show_bug.cgi?id=1404305 Stanislav Kozina changed: What|Removed |Added Blocks||1451004 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1440780] Review Request: mod_http2 - module implementing HTTP/ 2 for Apache 2
https://bugzilla.redhat.com/show_bug.cgi?id=1440780 --- Comment #11 from Gwyn Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/mod_http2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1438089] Review Request: golang-github-xtaci-kcp-go - Production-Grade Reliable-UDP Library for golang
https://bugzilla.redhat.com/show_bug.cgi?id=1438089
--- Comment #3 from Athos Ribeiro ---
Hi Fabio,
The package looks good!
Before approving it, do you have any comments on the images provided by
upstream? In special, shannon.jpg. I did not find a license tag nor the
original file.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[?]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
github-xtaci-kcp-go-devel , golang-github-xtaci-kcp-go-unit-test-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
= EXTRA items
[Bug 1438089] Review Request: golang-github-xtaci-kcp-go - Production-Grade Reliable-UDP Library for golang
https://bugzilla.redhat.com/show_bug.cgi?id=1438089 Athos Ribeiro changed: What|Removed |Added Status|NEW |ASSIGNED CC||athoscribe...@gmail.com Assignee|nob...@fedoraproject.org|athoscribe...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1438673] Review Request: openjfx - Rich client application platform for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1438673 --- Comment #35 from Michal Vala --- I can build it in mock. So I guess it's ok. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1450688] Review Request: kf5-kdav - A DAV protocol implementation with KJobs
https://bugzilla.redhat.com/show_bug.cgi?id=1450688 Rex Dieter changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-05-15 09:28:40 --- Comment #4 from Rex Dieter --- imported, fixed license, thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431740] Review Request: golang-github-cznic-internal - Shared dependencies for other cznic Go libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1431740
Athos Ribeiro changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #2 from Athos Ribeiro ---
Hi Fabio,
I am taking this one!
- The release tag MUST include the date the snapshot was taken. Also, note that
post-releases should not use x.y format in the tag. Please, refer to [1] and
[2] when changing the tag.
I will not block this review trusting you will perform necessary changes before
uploading the package.
Package looks good. Approved!
[1] https://fedoraproject.org/wiki/Packaging:Versioning
[2] https://fedoraproject.org/wiki/Package_Versioning_Examples
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bi
[Bug 1431740] Review Request: golang-github-cznic-internal - Shared dependencies for other cznic Go libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1431740 Athos Ribeiro changed: What|Removed |Added Status|NEW |ASSIGNED CC||athoscribe...@gmail.com Assignee|nob...@fedoraproject.org|athoscribe...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1444925] Review Request: python-rpm-generators - Requires and Provides generators for Python RPMs
https://bugzilla.redhat.com/show_bug.cgi?id=1444925 --- Comment #15 from Gwyn Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-rpm-generators -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1450688] Review Request: kf5-kdav - A DAV protocol implementation with KJobs
https://bugzilla.redhat.com/show_bug.cgi?id=1450688 --- Comment #3 from Gwyn Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-kdav -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1448997] Review Request: lua-bit32 - Backport of Lua bit manipulation library introduced in 5.2
https://bugzilla.redhat.com/show_bug.cgi?id=1448997 --- Comment #8 from Gwyn Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/lua-bit32 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1447741] Review Request: sedutil - Tools to manage the activation and use of self encrypting drives
https://bugzilla.redhat.com/show_bug.cgi?id=1447741 --- Comment #8 from Gwyn Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/sedutil -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1450482] Review Request: pix - Image management application
https://bugzilla.redhat.com/show_bug.cgi?id=1450482 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-05-15 08:53:33 --- Comment #10 from Fedora Update System --- pix-1.4.1-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1445366] Review Request: unicode-emoji - Unicode Emoji Data Files
https://bugzilla.redhat.com/show_bug.cgi?id=1445366 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-05-15 08:52:31 --- Comment #16 from Fedora Update System --- unicode-emoji-4.0-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1444925] Review Request: python-rpm-generators - The RPM python dependency generators
https://bugzilla.redhat.com/show_bug.cgi?id=1444925 --- Comment #14 from Tomas Orsava --- (In reply to Igor Gnatenko from comment #13) > > One RPM/subpackage can contain only Python 2 or Python 3 compiled files, > > not both at the same time. There was a discussion about providing both > > Python 2 and Python 3 subpackages, but with Python 2 EOL in sight we > > decided it wasn't necessary. > > it was more about naming rather than content... if you would name > `python-rpm-generators`, it would be still containing python3 compiled > files.. Oh I see! I agree with you that the python- prefix would be better in this particular case, it would break the Fedora Packaging Guidelines for Python which mandate that the `python-` prefix is reserved only for Python 2 packages until the default is switched to Python 3 sometime in the future (likely 2020). > > > So, approving. Please, coordinate with RPM packaging this. Thanks! When the package gets to the repos, I'll follow up with a BZ and a patch for the `rpm` package as well as the Python 2 and 3 packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1444925] Review Request: python-rpm-generators - The RPM python dependency generators
https://bugzilla.redhat.com/show_bug.cgi?id=1444925 Igor Gnatenko changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #13 from Igor Gnatenko --- > One RPM/subpackage can contain only Python 2 or Python 3 compiled files, not > both at the same time. There was a discussion about providing both Python 2 > and Python 3 subpackages, but with Python 2 EOL in sight we decided it wasn't > necessary. it was more about naming rather than content... if you would name `python-rpm-generators`, it would be still containing python3 compiled files.. Anyhow, naming is not something which could block review... So, approving. Please, coordinate with RPM packaging this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1438673] Review Request: openjfx - Rich client application platform for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1438673 --- Comment #34 from Jonny Heggheim --- Do you have some more information? It builds on koji https://koji.fedoraproject.org/koji/taskinfo?taskID=19564638 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1449882] Review Request: python-lcm2 - Simplified Python binding to LittleCMS2 library
https://bugzilla.redhat.com/show_bug.cgi?id=1449882
Athos Ribeiro changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #13 from Athos Ribeiro ---
Package looks good now!
There are still a few rpmlint warnings for the spec file, but I will trust you
will fix the following ones before uploading the package:
python-lcms2.src:10: W: macro-in-comment %{name}
python-lcms2.src:10: W: macro-in-comment %{version}
python-lcms2.src:10: W: macro-in-comment %{name}
python-lcms2.src:10: W: macro-in-comment %{version}
python-lcms2.src:31: W: mixed-use-of-spaces-and-tabs (spaces: line 31, tab:
line 3)
- For the macros, just add an extra % before the first %.
- For the tabs you can run something like
sed -i 's/\t/ /g' python-lcms2.spec
The other warnings are false positives, so you should not worry about them.
Package approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1446005] Review Request: tikzit - Diagram editor for pgf/TikZ
https://bugzilla.redhat.com/show_bug.cgi?id=1446005 --- Comment #2 from Antonio Trande --- + ./configure --build=x86_64-redhat-linux-gnu --host=x86_64-redhat-linux-gnu --program-prefix= --disable-dependency-tracking --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info checking for a BSD-compatible install... /usr/bin/install -c checking whether build environment is sane... yes checking for a thread-safe mkdir -p... /usr/bin/mkdir -p checking for gawk... gawk checking whether make sets $(MAKE)... yes checking whether make supports nested variables... yes checking whether make supports nested variables... (cached) yes checking that generated files are newer than configure... done configure: creating ./config.status config.status: creating Makefile config.status: creating src/Makefile config.status: creating share/Makefile checking for x86_64-redhat-linux-gnu-gcc... no checking for x86_64-redhat-linux-gnu-clang... no checking for x86_64-redhat-linux-gnu-objc... no checking for x86_64-redhat-linux-gnu-objcc... no checking for gcc... gcc checking whether the Objective C compiler works... yes checking for Objective C compiler default output file name... a.out checking for suffix of executables... checking whether we are cross compiling... no checking for suffix of object files... o checking whether we are using the GNU Objective C compiler... yes checking whether gcc accepts -g... yes checking for style of include used by make... GNU checking dependency style of gcc... none checking for flex... no checking for lex... no checking for bison... no checking for byacc... no ./configure: line 5095: gnustep-config: command not found configure: error: GNUstep not found error: Bad exit status from /var/tmp/rpm-tmp.Vk5sMo (%build) RPM build errors: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1446005] Review Request: tikzit - Diagram editor for pgf/TikZ
https://bugzilla.redhat.com/show_bug.cgi?id=1446005 Antonio Trande changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1448661] Review Request: brotli - Lossless compression algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1448661
Antonio Trande changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #5 from Antonio Trande ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 226 files have
unknown license. Detailed output of licensecheck in
/home/sagitter/1448661-brotli/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/.build-id/9d
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib64/python3.6/site-
packages/__pycache__(python36)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[Bug 1438673] Review Request: openjfx - Rich client application platform for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1438673 Michal Vala changed: What|Removed |Added CC||mv...@redhat.com --- Comment #33 from Michal Vala --- (In reply to Jonny Heggheim from comment #32) > (In reply to jiri vanek from comment #31) > > Done: https://bugzilla.redhat.com/show_bug.cgi?id=1145303#c93 > > Thanks. > > > Btw.. I can see there was already several various commentators, but no one > > took the bug. As I myself participate in decisions and java-1.8.0-openjdk I > > dont wont to take it unless there are other options > > I updated the .spec and srpm file with a -devel sub package, let me know how > it fits. > > Spec URL: https://jonny.fedorapeople.org/openjfx.spec > SRPM URL: https://jonny.fedorapeople.org/openjfx-8.0.152-7.b03.fc25.src.rpm Hi, I'm unable to build. Got this error: + /usr/lib/rpm/find-debuginfo.sh --strict-build-id -m --run-dwz --dwz-low-mem-die-limit 1000 --dwz-max-die-limit 11000 /home/mvala/rpmbuild/BUILD/rt-8u152-b03 extracting debug info from /home/mvala/rpmbuild/BUILDROOT/openjfx-8.0.152-7.b03.fc26.x86_64/usr/lib/jvm/openjfx/rt/lib/amd64/libglass.so *** ERROR: No build ID note found in /home/mvala/rpmbuild/BUILDROOT/openjfx-8.0.152-7.b03.fc26.x86_64/usr/lib/jvm/openjfx/rt/lib/amd64/libglass.so error: Bad exit status from /var/tmp/rpm-tmp.waBuNH (%install) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1448557] Review Request: hidviz - A tool for in-depth analysis of USB HID devices communication
https://bugzilla.redhat.com/show_bug.cgi?id=1448557 Zdenek Dohnal changed: What|Removed |Added CC||zdoh...@redhat.com Assignee|nob...@fedoraproject.org|zdoh...@redhat.com Flags||fedora-review? --- Comment #4 from Zdenek Dohnal --- I'll take it Jarda. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1450482] Review Request: pix - Image management application
https://bugzilla.redhat.com/show_bug.cgi?id=1450482 --- Comment #9 from Fedora Update System --- pix-1.4.1-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0ff6f459a9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1372866] Review Request: hyperscan - Hyperscan is a high-performance multiple regex matching library
https://bugzilla.redhat.com/show_bug.cgi?id=1372866 --- Comment #41 from Fedora Update System --- hyperscan-4.4.1-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1170ddbee5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1450149] Review Request: python-minidb - Simple python object store
https://bugzilla.redhat.com/show_bug.cgi?id=1450149 --- Comment #8 from Fedora Update System --- python-minidb-2.0.2-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ea428d7f3f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1450440] Review Request: perl-Ref-Util-XS - Utility functions for checking references
https://bugzilla.redhat.com/show_bug.cgi?id=1450440 --- Comment #1 from Paul Howarth --- Upstream update to 0.116 (spec URL unchanged): http://www.city-fan.org/~paul/extras/perl-Ref-Util/perl-Ref-Util-XS-0.116-1.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1450633] Review request: keepassxc - Cross-platform password manager
https://bugzilla.redhat.com/show_bug.cgi?id=1450633 Germano Massullo changed: What|Removed |Added Summary|keepassxc - Cross-platform |Review request: keepassxc - |password manager|Cross-platform password ||manager -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
