[Bug 1446916] Review Request: x509viewer - Simple tool to decode X.509 certificates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1446916



--- Comment #18 from Fedora Update System  ---
x509viewer-0.1.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1446916] Review Request: x509viewer - Simple tool to decode X.509 certificates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1446916



--- Comment #17 from Fedora Update System  ---
x509viewer-0.1.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445506] Review Request: python-fedmsg-rabbitmq-serializer - fedmsg consumer to serialize bus messages into a rabbitmq worker queue

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445506



--- Comment #6 from Athos Ribeiro  ---
Created attachment 1279834
  --> https://bugzilla.redhat.com/attachment.cgi?id=1279834=edit
Fix python2 subpackage Requires

> - Actually, you do need to include the requires under the python2 subpackage
> (the ones you do not need to move there are the BRs):
> 
>   $ rpm -qp --requires
> python2-fedmsg-rabbitmq-serializer-0.0.5-1.fc27.noarch.rpm
>   python(abi) = 2.7
>   rpmlib(CompressedFileNames) <= 3.0.4-1
>   rpmlib(FileDigests) <= 4.6.0-1
>   rpmlib(PartialHardlinkSets) <= 4.0.4-1
>   rpmlib(PayloadFilesHavePrefix) <= 4.0-1
>   rpmlib(PayloadIsXz) <= 5.2-1

Your Requires: are not in the python2 subpackage. If you try installing and
using this package, you get:

>>> from fedmsg_rabbitmq_serializer import consumer
Traceback (most recent call last):
  File "", line 1, in 
  File
"/usr/lib/python2.7/site-packages/fedmsg_rabbitmq_serializer/consumer.py", line
7, in 
import fedmsg.consumers
ImportError: No module named fedmsg.consumers

Answering the question: yes, the "Requires:" lines should be moved into the
python2 subpackage.

This patch should fix it. You can either apply it or just move the Requires
into the python2 subpackage so we can approve this :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451134] Review Request: lightdm-autologin-greeter - Autologin greeter using LightDM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451134



--- Comment #14 from Fedora Update System  ---
lightdm-autologin-greeter-1.0-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0d0ec741d4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431740] Review Request: golang-github-cznic-internal - Shared dependencies for other cznic Go libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431740



--- Comment #11 from Fedora Update System  ---
golang-github-cznic-internal-1.0.0-1.20170516.git6c349f9.fc25 has been pushed
to the Fedora 25 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-4a99112bea

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447741] Review Request: sedutil - Tools to manage the activation and use of self encrypting drives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447741



--- Comment #12 from Fedora Update System  ---
sedutil-1.12-3.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-79d63f9b64

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451134] Review Request: lightdm-autologin-greeter - Autologin greeter using LightDM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451134



--- Comment #13 from Fedora Update System  ---
lightdm-autologin-greeter-1.0-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0b7393a69e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431740] Review Request: golang-github-cznic-internal - Shared dependencies for other cznic Go libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431740



--- Comment #10 from Fedora Update System  ---
golang-github-cznic-internal-1.0.0-1.20170516.git6c349f9.fc24 has been pushed
to the Fedora 24 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-16d772ae1b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451134] Review Request: lightdm-autologin-greeter - Autologin greeter using LightDM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451134



--- Comment #12 from Fedora Update System  ---
lightdm-autologin-greeter-1.0-1.el7 has been pushed to the Fedora EPEL 7
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-ef27585979

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1309703] Review Request: libratbag - a library to configure programmable mice

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309703

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-05-17 17:03:07



--- Comment #17 from Fedora Update System  ---
libratbag-0.8-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679

Sandro Bonazzola  changed:

   What|Removed |Added

  Flags||needinfo?(rjo...@redhat.com
   ||)



--- Comment #6 from Sandro Bonazzola  ---
Thanks for the review, I'll try to address all your comments.

(In reply to Richard W.M. Jones from comment #4)
> Fedora-review finds the following issues:
> 
> - Header files in -devel subpackage, if present.
>   Note: laby : /usr/share/laby/mods/c/lib/robot.h laby :
>   /usr/share/laby/mods/cpp/lib/robot.h
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages

This one is intentional. The game teach you also how to program in C and in
order to move the ant, you'll need the robot.h header file. It isn't the use
case addressed by -devel subpackages. Should I add a comment in the spec file
about this?

> - Package contains BR: python2-devel or python3-devel

What's BR?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451156] Review Request: ipv6gen - IPv6 prefix generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451156



--- Comment #5 from Fedora Update System  ---
ipv6gen-1.0-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-14909ae6b3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451156] Review Request: ipv6gen - IPv6 prefix generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451156



--- Comment #3 from Fedora Update System  ---
ipv6gen-1.0-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-58aa0ec7e7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451156] Review Request: ipv6gen - IPv6 prefix generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451156



--- Comment #6 from Fedora Update System  ---
ipv6gen-1.0-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9b9a6a61d1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451156] Review Request: ipv6gen - IPv6 prefix generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451156



--- Comment #7 from Fedora Update System  ---
ipv6gen-1.0-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-ea6db27503

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451156] Review Request: ipv6gen - IPv6 prefix generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451156

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451156] Review Request: ipv6gen - IPv6 prefix generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451156



--- Comment #4 from Fedora Update System  ---
ipv6gen-1.0-1.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-62983b7898

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445506] Review Request: python-fedmsg-rabbitmq-serializer - fedmsg consumer to serialize bus messages into a rabbitmq worker queue

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445506



--- Comment #5 from Adam Miller  ---
Just to be clear, are you waiting on anything or is this approved? I wasn't
certain. 

Thanks! :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400278] Review Request: python-os-faults - OpenStack fault-injection library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400278

errata-xmlrpc  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-05-17 15:49:27



--- Comment #3 from errata-xmlrpc  ---
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1245

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400271] Review Request: python-sphinxcontrib-pecanwsme - Extension to Sphinx for documenting APIs built with Pecan and WSME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400271

errata-xmlrpc  changed:

   What|Removed |Added

 Status|VERIFIED|CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-05-17 15:49:21



--- Comment #4 from errata-xmlrpc  ---
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1245

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396296] New OSP11 package from CBS -- python-tenacity

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396296

errata-xmlrpc  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-05-17 15:47:15



--- Comment #3 from errata-xmlrpc  ---
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1245

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1415777] Review Request: python-tinyrpc - A modular RPC library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1415777

errata-xmlrpc  changed:

   What|Removed |Added

 Status|RELEASE_PENDING |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-05-17 15:42:04



--- Comment #4 from errata-xmlrpc  ---
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1245

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1414530] Review Request: python-statsd - Python client for the statsd daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1414530

errata-xmlrpc  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-05-17 15:40:43



--- Comment #2 from errata-xmlrpc  ---
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1245

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451134] Review Request: lightdm-autologin-greeter - Autologin greeter using LightDM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451134

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
lightdm-autologin-greeter-1.0-1.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-34b2988430

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447741] Review Request: sedutil - Tools to manage the activation and use of self encrypting drives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447741

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
sedutil-1.12-3.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-16408468c4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431740] Review Request: golang-github-cznic-internal - Shared dependencies for other cznic Go libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431740

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
golang-github-cznic-internal-1.0.0-1.20170516.git6c349f9.fc26 has been pushed
to the Fedora 26 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e9dc7f81fa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1415777] Review Request: python-tinyrpc - A modular RPC library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1415777

errata-xmlrpc  changed:

   What|Removed |Added

 Status|ON_QA   |RELEASE_PENDING



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450590] Review Request: watchman - a file watching service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450590



--- Comment #2 from Matthew Smith  ---
Sorry for making so many changes but I found that the build was broken on
Fedora 26 because of the upgrade to GCC 7.

The source needed a small patch to work again, I wasn't sure where I should
upload it during the package review so I have just uploaded it with the spec
and SRPM. Hopefully that's okay.

Spec URL: https://mattysmith.co.uk/watchman/watchman-2.spec
SRPM URL: https://mattysmith.co.uk/watchman/watchman-4.7.0-3.fc26.src.rpm
Patch0 URL: https://mattysmith.co.uk/watchman/watchman-4.7.0-fallthrough.patch
Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19598470

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431743] Review Request: golang-github-cznic-zappy - Block-based compression format implementation in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431743



--- Comment #2 from Fabio Valentini  ---
Updated .spec and .src.rpm files for new guidelines (snapshot date included in
"Release" tag):

Spec URL:
https://decathorpe.fedorapeople.org/packages/golang-github-cznic-zappy.spec

SRPM URL:
https://decathorpe.fedorapeople.org/packages/golang-github-cznic-zappy-0-0.1.20160723.git2533cb5.fc26.src.rpm


I've also included a more verbose comment as to why I have disabled tests and
the unit-test subpackage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440704] Review Request: cpprest - C++ REST SDK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440704

c72...@yahoo.de changed:

   What|Removed |Added

 Depends On||1449163




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1449163
[Bug 1449163] tls.hpp, SSL_R_SHORT_READ undefined in openssl-1.1
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448778] Review Request: cockatrice - A cross-platform virtual tabletop for multiplayer card games

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448778

Tom "spot" Callaway  changed:

   What|Removed |Added

 CC||tcall...@redhat.com
 Blocks|182235 (FE-Legal)   |



--- Comment #1 from Tom "spot" Callaway  ---
I'm not sure why you flagged this against FE-Legal, but I took a quick look at
it nevertheless.

License wise, this has:

*

* Public Domain (cockatrice/resources/countries/*.svg)
* GPLv2+ (most of the code)
* BSD (cockatrice/src/qt-json/, common/sfmt/, 
* GPLv2 (oracle/src/zip/)
* CPL or LGPLv2 (servatrice/src/smtp/)
# Webclient code (not included?)
* ASL 2.0 (webclient/js/protobuf.js, webclient/js/long.js,
webclient/js/bytebuffer.js)
* MIT (webclient/js/jquery-*.js)

*

I feel like I should stop and point out here that these versions of
jquery/jquery-ui are VERY VERY OLD. They are vulnerable to at least
https://www.cvedetails.com/cve/CVE-2016-7103/. I strongly strongly recommend
that you update them to the "final" releases of the v1 code for both, and have
upstream make that change as well.

Back to the licensing, CPL is GPLv2 incompatible, so we choose the LGPLv2
option there. ASL 2.0 is also GPLv2 incompatible, but that code is not being
compiled into or linked with GPLv2 code, so it is not a compatibility concern. 

In fact, it does not look like any of the code in webclient is packaged up or
used. Unsure if this is intentional (aka, this code is not useful anymore) or
accidental (forgot to make a -webclient subpackage). If you do end up including
the webclient bits, add this to the end of the license tag:

ASL 2.0 and MIT

However, I'm going to assume for now that you do not plan to include the
webclient bits.

You can choose to update the license tag in two ways:

* The long and absolutely correct way:
License: GPLv2+ and GPLv2 and BSD and (CPL or LGPLv2) and Public Domain

* The simplified way
License: GPLv2 and Public Domain

The reason you can do this is because:
1) We choose LGPLv2 for the smtp code.
2) GPLv2+ + GPLv2 = GPLv2
3) LGPLv2 + GPLv2 = GPLv2
4) BSD + GPLv2 = GPLv2
5) Need to call out Public Domain because that license applies to distinct and
separate works (the SVG files)

Either way, please include the above license analysis (the bits between the
*) as a comment above the License tag in the spec file.

If any of that is unclear, please let me know. Lifting FE-Legal.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438089] Review Request: golang-github-xtaci-kcp-go - Production-Grade Reliable-UDP Library for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438089



--- Comment #13 from Fedora Update System  ---
golang-github-xtaci-kcp-go-3.15-1.20170517.git2fd1e3d.fc24 has been submitted
as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2141376bf0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438089] Review Request: golang-github-xtaci-kcp-go - Production-Grade Reliable-UDP Library for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438089



--- Comment #12 from Fedora Update System  ---
golang-github-xtaci-kcp-go-3.15-1.20170517.git2fd1e3d.fc25 has been submitted
as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-55a467330b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438089] Review Request: golang-github-xtaci-kcp-go - Production-Grade Reliable-UDP Library for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438089

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438089] Review Request: golang-github-xtaci-kcp-go - Production-Grade Reliable-UDP Library for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438089



--- Comment #11 from Fedora Update System  ---
golang-github-xtaci-kcp-go-3.15-1.20170517.git2fd1e3d.fc26 has been submitted
as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-bbbfd7ca0f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451138] Review Request: libomp - default OpenMP runtime used by clang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451138



--- Comment #3 from Satish Balay  ---
Thanks!

One more issue:

I have:

clang-3.9.1-2.fc26.x86_64

However I'm able to install libomp-4.0.0 with it. [so the include dirs between
the 2 packages don't match]

/usr/lib64/clang/3.9.1/include/ vs /usr/lib64/clang/4.0.0/include/omp.h

[I can grab and install llvm-4.0 and clang-4.0 packages manually but] perhaps
there should be some rpm dependency info that should prevent these versions
from being out-of-sync?

Also should libomp package be built with clang - and not gcc?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #13 from Mukundan Ragavan  ---
(In reply to Toni Spets from comment #11)
> (In reply to Mukundan Ragavan from comment #10)
> > 
> > Even if we build the package with the protocol on, it can be disabled in the
> > settings screen(see screenshot attached).
> > 
> 
> To be more precise, even when enabled at compile time it is *disabled* by
> default at runtime and you need to explicitly enable it for use.

Yes indeed. That's what I intended to say .. 


(In reply to Germano Massullo from comment #8)
> (In reply to Mukundan Ragavan from comment #5)
> > ---> Some of these bogus warnings. For example,
> > 
> > /usr/share/mime, /usr/share/mime/packages are owned by shared-mime-info
> > /usr/share/icons/hicolor - hicolor-icon-theme
> > 
> > others are provided by several other packages (kde-filesystem, for 
> > example)
> > 
> > /usr/lib64/keepassxc fix is above.
> 
> Could you rephrase such piece of the review? I think I have not got it
> 
My apologies. I meant to say nothing needs to be addressed here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679



--- Comment #5 from Richard W.M. Jones  ---
The build system is pretty crazy.  I couldn't work out if it was
installing the bytecode or native code version of the binary.  I
*think* it's the native code version, which would be correct.
You might consider using ‘make native’ so it only builds the
native code version, since building the bytecode version is a
waste of time on all architectures that recent Fedora supports.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679



--- Comment #4 from Richard W.M. Jones  ---
Fedora-review finds the following issues:

- Header files in -devel subpackage, if present.
  Note: laby : /usr/share/laby/mods/c/lib/robot.h laby :
  /usr/share/laby/mods/cpp/lib/robot.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- Package contains BR: python2-devel or python3-devel
- gtk-update-icon-cache is invoked in %postun and %posttrans if package
  contains icons.
  Note: icons in laby
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438089] Review Request: golang-github-xtaci-kcp-go - Production-Grade Reliable-UDP Library for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438089



--- Comment #10 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-xtaci-kcp-go

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679



--- Comment #3 from Richard W.M. Jones  ---
You shouldn't use any of the following:

%global opt %(test -x %{_bindir}/ocamlopt && echo 1 || echo 0)

- This has been replaced by either %ocaml_native_compiler or
  %ocaml_natdynlink.  Please see /usr/lib/rpm/macros.d/macros.ocaml-srpm

%global debug_package %{nil}

- Debuginfo should work these days.  You may need to modify the build
  so it passes -g option to ocamlopt.

%global _use_internal_dependency_generator 0
%global __find_requires /usr/lib/rpm/ocaml-find-requires.sh
%global __find_provides /usr/lib/rpm/ocaml-find-provides.sh

- This is plain wrong nowadays.  The RPM dependency generator
  just does the right thing.

And yes I'm aware that the OCaml packaging guidelines aren't up to date
on some of these issues.  Also that OCaml packages don't consistently
do this -- I've been fixing those over time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679



--- Comment #2 from Richard W.M. Jones  ---
FWIW I'm testing this with OCaml 4.04.1 in Rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679

Richard W.M. Jones  changed:

   What|Removed |Added

 CC||rjo...@redhat.com
   Assignee|nob...@fedoraproject.org|rjo...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433749] Review Request: vrms-rpm - report of installed nonfree software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433749

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #6 from Neal Gompa  ---
I'll take this review formally.

I've also seen you do at least one informal review[1], showing that you
understand the guidelines, so I'll be happy to sponsor you as well (since no
one else has said they'll sponsor you).

[1]: https://bugzilla.redhat.com/1444518

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438089] Review Request: golang-github-xtaci-kcp-go - Production-Grade Reliable-UDP Library for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438089



--- Comment #9 from Fabio Valentini  ---
Thank you for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447517] Review Request: ddcutil - control monitor settings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447517



--- Comment #1 from Michael Schwendt  ---
> The spec file will likely require cleanup.  It's grown into a complex mess 

Indeed.

It will be very hard to find a reviewer for such a package, less a reviewer who
would approve the package.

Please focus on building a small and easy to maintain Fedora package that
attempts at following Fedora's packaging guidelines. Avoid all the superfluous
"complex mess". Use Mock for doing local test-builds. No need to worry about
Koji yet, which also uses Mock under the hood.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406881] Review Request: vint - Lint tool for Vim script Language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406881



--- Comment #2 from Filip Szymański  ---
Koji scratch: https://koji.fedoraproject.org/koji/taskinfo?taskID=19595107

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406881] Review Request: vint - Lint tool for Vim script Language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406881

Filip Szymański  changed:

   What|Removed |Added

 Status|CLOSED  |NEW
 CC||filip.szyman...@zoho.eu
 Resolution|WONTFIX |---
   Keywords||Reopened



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448557] Review Request: hidviz - A tool for in-depth analysis of USB HID devices communication

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448557



--- Comment #18 from Jaroslav Škarvada  ---
New version:
Spec URL: https://jskarvad.fedorapeople.org/hidviz/hidviz.spec
SRPM URL: https://jskarvad.fedorapeople.org/hidviz/hidviz-0.1.4-2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #12 from Germano Massullo  ---
Ok I will re-enable it again on next spec file release

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451134] Review Request: lightdm-autologin-greeter - Autologin greeter using LightDM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451134



--- Comment #9 from Fedora Update System  ---
lightdm-autologin-greeter-1.0-1.fc25 has been submitted as an update to Fedora
25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0d0ec741d4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451134] Review Request: lightdm-autologin-greeter - Autologin greeter using LightDM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451134



--- Comment #10 from Fedora Update System  ---
lightdm-autologin-greeter-1.0-1.fc26 has been submitted as an update to Fedora
26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-34b2988430

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451134] Review Request: lightdm-autologin-greeter - Autologin greeter using LightDM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451134



--- Comment #8 from Fedora Update System  ---
lightdm-autologin-greeter-1.0-1.fc24 has been submitted as an update to Fedora
24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0b7393a69e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451134] Review Request: lightdm-autologin-greeter - Autologin greeter using LightDM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451134



--- Comment #7 from Fedora Update System  ---
lightdm-autologin-greeter-1.0-1.el7 has been submitted as an update to Fedora
EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-ef27585979

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451134] Review Request: lightdm-autologin-greeter - Autologin greeter using LightDM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451134

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400271] Review Request: python-sphinxcontrib-pecanwsme - Extension to Sphinx for documenting APIs built with Pecan and WSME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400271

Jon Schlueter  changed:

   What|Removed |Added

 Status|ON_QA   |VERIFIED
 CC||jschl...@redhat.com



--- Comment #3 from Jon Schlueter  ---
Verified build is in -overrides and not on advisory

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #11 from Toni Spets  ---
(In reply to Mukundan Ragavan from comment #10)
> 
> Even if we build the package with the protocol on, it can be disabled in the
> settings screen(see screenshot attached).
> 

To be more precise, even when enabled at compile time it is *disabled* by
default at runtime and you need to explicitly enable it for use.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #10 from Mukundan Ragavan  ---
Created attachment 1279646
  --> https://bugzilla.redhat.com/attachment.cgi?id=1279646=edit
keepass http screen

Germano, I wonder if it would be alright to leave keepassHTTP on in the builds
and let the users decide if they want to use it. Even if we build the package
with the protocol on, it can be disabled in the settings screen(see screenshot
attached).

Also, From here - https://github.com/keepassxreboot/keepassxc

KeePassXC therefore strictly limits communication between itself and the
browser plugin to your local computer.



What do you think?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438089] Review Request: golang-github-xtaci-kcp-go - Production-Grade Reliable-UDP Library for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438089

Athos Ribeiro  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Athos Ribeiro  ---
Package looks good now.

Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1448557] Review Request: hidviz - A tool for in-depth analysis of USB HID devices communication

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1448557

Jaroslav Škarvada  changed:

   What|Removed |Added

  Flags|needinfo?(jskarvad@redhat.c |
   |om) |



--- Comment #17 from Jaroslav Škarvada  ---
(In reply to Zdenek Dohnal from comment #16)
Thanks for the review, comments follow inline.

> Issues:
> ===
> - All build dependencies are listed in BuildRequires, except for any that
>   are listed in the exceptions section of Packaging Guidelines.
>   Note: These BR are not needed: gcc-c++
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

Incorrect, this was changed, all deps have to be explicitly listed, there are
no exceptions.
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_2

> - .so files must be either versioned and then be in -libs subpackage and
> that subpackage must have %post+%postun scriplets with '/sbin/ldconfig' and
> . Or unversioned .so files must be in -devel subpackage.

This is non public library, it doesn't need to be versioned, but versioning
would be nice.

https://fedoraproject.org/wiki/Packaging:Guidelines#Downstream_.so_name_versioning

> - missing licenses in spec - there must be all licenses used in package

IMHO there is no license conflict, the resulting package can be released under
GPLv3+ as upstream states.

> - package must own directories - /usr/share/icons/hicolor/128x128/apps,
>   /usr/share/icons/hicolor/128x128

I think it should be owned by filesystem, but I am going to fix it.

> - libhidx_server_daemon must be in %{_libexecdir}/%{name} directory - if
> daemon is meant to run by system rather than by user

This is not mandatory:
"Packagers are highly encouraged to store libexecdir files in a
package-specific subdirectory..."

https://fedoraproject.org/wiki/Packaging:Guidelines#Libexecdir

It will be nice to have it in subdir, please file RFE upstream (or I can do
it).

> - you should use %{name} instead hidviz in paths

Really minor and depends on personal taste.

> - package contains *daemon executable - could it run as service in systemd?

It is not meant to to be run as a system service.

> - convert function can be in %install scriptlet - I think it makes more sense
>   to have it in same place with 'install' command

It depends on the point of view, it's creating source file which is not
currently present in the tarball. But it's minor, I can change it.

> 
> 
> = MUST items =
> 
> C/C++:
> [x]: Package does not contain kernel modules.
> [x]: Package contains no static executables.
> [!]: Development (unversioned) .so files in -devel subpackage, if present.
>  Note: Unversioned so-files in private %_libdir subdirectory (see
>  attachment). Verify they are not in ld path.
> - .so files must be either versioned and then package must have %post+%postun
>   scriplets with '/sbin/ldconfig'. Or .so files must be in -devel subpackage.
>

Comment above.

> [x]: Header files in -devel subpackage, if present.
> [x]: Package does not contain any libtool archives (.la)
> [x]: Rpath absent or only used for internal libs.
> 
> Generic:
> [!]: Package is licensed with an open-source compatible license and meets
>  other legal requirements as defined in the legal section of Packaging
>  Guidelines.
> - missing licenses in spec - there must be all licenses used in package
> 
> [!]: License field in the package spec file matches the actual license.
>  Note: Checking patched sources after %prep for licenses. Licenses
>  found: "BSD (3 clause)", "MIT/X11 (BSD like)", "Apache (v2.0) GPL (v3
>  or later)", "GPL (v3 or later)", "Unknown or generated". 30 files have
>  unknown license. Detailed output of licensecheck in
>  /home/zdohnal/repo_upstream/hidviz/review-hidviz/licensecheck.txt
> - missing licenses in spec - there must be all licenses used in package
> 

Comment above.

> [x]: License file installed when any subpackage combination is installed.
> [!]: Package must own all directories that it creates.
>  Note: Directories without known owners: /usr/share/icons/hicolor,
>  /usr/share/icons/hicolor/128x128/apps,
>  /usr/share/icons/hicolor/128x128

Comment above, but I am goint to change it.

> [x]: %build honors applicable compiler flags or justifies otherwise.
> [x]: Package contains no bundled libraries without FPC exception.
> [x]: Changelog in prescribed format.
> [x]: Sources contain only permissible code or content.
> [!]: Development files must be in a -devel package
> - it can be false positive - it depends on purpose of *.so files

Yup, false positive, comment above.

> 
> [x]: Package uses nothing in %doc for runtime.
> [!]: Package consistently uses macros (instead of hard-coded directory
>  names).
> - you should use %{name} instead hidviz in paths
>
This check 

[Bug 1398922] Review Request: uftrace - User-space function call tracer for C and C++ programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398922

Dridi Boukelmoune  changed:

   What|Removed |Added

 CC||dridi.boukelmo...@gmail.com



--- Comment #17 from Dridi Boukelmoune  ---
The next release should work fine with the %configure macro [1] so that should
soon not be a problem. If you think that the shared object should be in a
private directory because they're not directly linked to but rather pre-loaded
you should discuss this upstream and point them to the relevant Fedora
guidelines.

You can however do that in your spec like this:

%configure --libdir=%{_libdir}/%{name}

Until the next release, you can patch [2,3] the configure script in your spec.

As upstream mentioned on github, I was about to recommend verbose building to

1) verify that the flags are properly passed and
2) make it easier to troubleshoot remote builds in general:

%make_build V=1

There are other issues with the spec, have a look at the rpmlint output for
starters. I found one in the changelog that I'm sure rpmlint will report, I'll
keep the others for later.

[1] https://github.com/namhyung/uftrace/pull/98
[2] https://patch-diff.githubusercontent.com/raw/namhyung/uftrace/pull/98.patch
[3] https://patch-diff.githubusercontent.com/raw/namhyung/uftrace/pull/98.diff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398922] Review Request: uftrace - User-space function call tracer for C and C++ programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398922



--- Comment #16 from Benjamin Kircher  ---
FYI, some changes related to ./configure script and Fedora packaging happened
in upstream here:
https://github.com/namhyung/uftrace/pull/98

Not in a release yet, though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438089] Review Request: golang-github-xtaci-kcp-go - Production-Grade Reliable-UDP Library for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438089

Fabio Valentini  changed:

   What|Removed |Added

 Blocks|182235 (FE-Legal)   |



--- Comment #7 from Fabio Valentini  ---
Upstream has removed the picture in question, unblocking FE-Legal.

Spec URL:
https://decathorpe.fedorapeople.org/packages/golang-github-xtaci-kcp-go.spec

SRPM URL:
https://decathorpe.fedorapeople.org/packages/golang-github-xtaci-kcp-go-3.15-1.20170517.git2fd1e3d.fc26.src.rpm


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #9 from Toni Spets  ---
(In reply to Germano Massullo from comment #8)
> What kind of feature is favicon download?

When you create an entry with URL set up, you can use the favicon download
feature in the icon selection dialog to automatically download the icon that
would be shown in the browser tab.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #8 from Germano Massullo  ---
(In reply to Mukundan Ragavan from comment #5)
> ---> Some of these bogus warnings. For example,
> 
>   /usr/share/mime, /usr/share/mime/packages are owned by shared-mime-info
>   /usr/share/icons/hicolor - hicolor-icon-theme
>   
>   others are provided by several other packages (kde-filesystem, for 
> example)
>   
>   /usr/lib64/keepassxc fix is above.

Could you rephrase such piece of the review? I think I have not got it

(In reply to Toni Spets from comment #7)
> Disabling WITH_XC_HTTP also unintentionally disables favicon downloading
> which is  very useful feature of KeePassXC.

What kind of feature is favicon download?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1449467] Review Request: lame - MP3 encoder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1449467



--- Comment #18 from Fedora Update System  ---
gstreamer1-plugins-ugly-free-1.10.4-3.fc25, lame-3.99.5-8.fc25 has been pushed
to the Fedora 25 stable repository. If problems still persist, please make note
of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397261] Review Request: gstreamer1-plugins-ugly-free - GStreamer ugly plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397261



--- Comment #37 from Fedora Update System  ---
gstreamer1-plugins-ugly-free-1.10.4-3.fc25, lame-3.99.5-8.fc25 has been pushed
to the Fedora 25 stable repository. If problems still persist, please make note
of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org