[Bug 1460917] Review Request: rpkg - Command-line client tool to DistGit
https://bugzilla.redhat.com/show_bug.cgi?id=1460917 --- Comment #15 from cl...@redhat.com --- *directories (that is fedora-rawhide-x86_64 e.g.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1460917] Review Request: rpkg - Command-line client tool to DistGit
https://bugzilla.redhat.com/show_bug.cgi?id=1460917 --- Comment #14 from cl...@redhat.com --- Successful COPR build: https://copr.fedorainfracloud.org/coprs/clime/rpkg-client/build/576706/ You can find the up-to-date srpm and .spec in the linked COPR directory. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467418] Review Request: python-plaster-pastedeploy - A PasteDeploy binding to the plaster configuration loader
https://bugzilla.redhat.com/show_bug.cgi?id=1467418
Dan Callaghan changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #5 from Dan Callaghan ---
APPROVED but please remove the trailing period from Summary, as indicated by
rpmlint.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
Note: only tested python -c 'import plaster_pastedeploy'
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_RO
[Bug 1467418] Review Request: python-plaster-pastedeploy - A PasteDeploy binding to the plaster configuration loader
https://bugzilla.redhat.com/show_bug.cgi?id=1467418 Dan Callaghan changed: What|Removed |Added Summary|Review Request: |Review Request: |python-plaster_pastedeploy |python-plaster-pastedeploy |- A PasteDeploy binding to |- A PasteDeploy binding to |the plaster configuration |the plaster configuration |loader |loader --- Comment #4 from Dan Callaghan --- Fixed the bug summary for the new name. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467322] Review Request: manifest-tool - A command line tool used for creating manifest list objects
https://bugzilla.redhat.com/show_bug.cgi?id=1467322 --- Comment #9 from Zbigniew Jędrzejewski-Szmek --- I wouldn't sweat it. In decreasing order of compliance with the guidelines: - just use a date: Provides: bundled(golang(golang.org/x/net)) = 20170305 (where the date is the date where the vendorization was done or something) - just use unversioned provides: Provides: bundled(golang(golang.org/x/net)) (The latter is pretty common, try "rpm -q -a --provides|grep bundled"... The guidelines are well-intentioned, but if it's so hard to find which version exactly is bundled, *and* this is something you'd have to do after every update, I just don't think it's worth your time.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467322] Review Request: manifest-tool - A command line tool used for creating manifest list objects
https://bugzilla.redhat.com/show_bug.cgi?id=1467322 --- Comment #8 from Josh Boyer --- (In reply to Adam Miller from comment #7) > (In reply to Josh Boyer from comment #6) > > (In reply to Adam Miller from comment #5) > > > > Thanks for picking up the review! > > > > > ITEMS TO FIX > > > > > > > > > - All bundled golang libraries need to be listed as 'Provides: > > > bundled() = ' directives as per > > > https://fedoraproject.org/wiki/Packaging: > > > Guidelines#Bundling_and_Duplication_of_system_libraries > > > > > > Other than that, the package looks good. > > > > OK, so I have two questions: > > > > 1) Why do e.g. runc, docker, etc not Provide anything they bundle? Confused > > there. I see stuff in -devel, but not in the main packages. > > > > runc and docker should and if they aren't, they are in violation of the > Guidelines, should have bugs filed against them, and should be fixed. > > > > 2) An example of a Provide for this package would be: > > > > Provides: bundled(golang(github.com/codegangsta/cli/)) = v1.2.0 > > Provides: bundled(golang(golang.org/x/net)) = master > > > > correct? > > The first one looks good pending that is a git tag that can be checked out, > the latter however needs to correlate to a commit id or tag. Erm... any tips on how to determine what commit has been vendored? The vendor.conf file literally lists "master". > For an examples, check the OpenShift Origin and/or reg specs: > > http://pkgs.fedoraproject.org/cgit/rpms/reg.git/tree/reg.spec > http://pkgs.fedoraproject.org/cgit/rpms/origin.git/tree/origin.spec Yeah, I looked at those to come up with my examples above. I'll be away from keyboard for a few days, but I'll see what I can come up with and submit a new spec Monday. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1465874] Review Request: RetroArch-xmb-assets - Official XMB menu assets
https://bugzilla.redhat.com/show_bug.cgi?id=1465874 Michael Schwendt changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467322] Review Request: manifest-tool - A command line tool used for creating manifest list objects
https://bugzilla.redhat.com/show_bug.cgi?id=1467322 --- Comment #7 from Adam Miller --- (In reply to Josh Boyer from comment #6) > (In reply to Adam Miller from comment #5) > > Thanks for picking up the review! > > > ITEMS TO FIX > > > > > > - All bundled golang libraries need to be listed as 'Provides: > > bundled() = ' directives as per > > https://fedoraproject.org/wiki/Packaging: > > Guidelines#Bundling_and_Duplication_of_system_libraries > > > > Other than that, the package looks good. > > OK, so I have two questions: > > 1) Why do e.g. runc, docker, etc not Provide anything they bundle? Confused > there. I see stuff in -devel, but not in the main packages. > runc and docker should and if they aren't, they are in violation of the Guidelines, should have bugs filed against them, and should be fixed. > 2) An example of a Provide for this package would be: > > Provides: bundled(golang(github.com/codegangsta/cli/)) = v1.2.0 > Provides: bundled(golang(golang.org/x/net)) = master > > correct? The first one looks good pending that is a git tag that can be checked out, the latter however needs to correlate to a commit id or tag. For an examples, check the OpenShift Origin and/or reg specs: http://pkgs.fedoraproject.org/cgit/rpms/reg.git/tree/reg.spec http://pkgs.fedoraproject.org/cgit/rpms/origin.git/tree/origin.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1465954] Review Request: python-pathspec - Utility library for gitignore style pattern matching of file paths
https://bugzilla.redhat.com/show_bug.cgi?id=1465954
--- Comment #1 from Adam Miller ---
This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MPL (v2.0)", "Unknown or generated", "*No copyright* MPL
(v2.0)". 13 files have unknown license. Detailed output of
licensecheck in /home/admiller/reviews/1465954-python-
pathspec/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python3.6/site-
packages, /usr/lib/python3.6
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides an
[Bug 1465954] Review Request: python-pathspec - Utility library for gitignore style pattern matching of file paths
https://bugzilla.redhat.com/show_bug.cgi?id=1465954 Adam Miller changed: What|Removed |Added Status|NEW |ASSIGNED CC||admil...@redhat.com Assignee|nob...@fedoraproject.org|admil...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468383] New: Review Request: python-easyargs - Making argument parsing easy
https://bugzilla.redhat.com/show_bug.cgi?id=1468383 Bug ID: 1468383 Summary: Review Request: python-easyargs - Making argument parsing easy Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: carl@george.computer QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://carl.george.computer/review/python-easyargs.spec SRPM URL: https://carl.george.computer/review/python-easyargs-0.9.4-1.fc27.src.rpm Description: A project designed to make command line argument parsing easy. There are many ways to create a command line parser in python: argparse, docopt, click. These are all great options, but require quite a lot of configuration and sometimes you just need a function to be called. Enter easyargs. Define the function that you want to be called, decorate it and let easyargs work out the command line. Fedora Account System Username: carlwgeorge Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20370080 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421480] Review Request: js-jquery-prettyphoto - PrettyPhoto is a jQuery based lightbox clone
https://bugzilla.redhat.com/show_bug.cgi?id=1421480 --- Comment #3 from Fedora Update System --- js-jquery-prettyphoto-3.1.6-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0decc8affd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421480] Review Request: js-jquery-prettyphoto - PrettyPhoto is a jQuery based lightbox clone
https://bugzilla.redhat.com/show_bug.cgi?id=1421480 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467129] Review Request: python-pdir2 - Pretty dir() printing with joy
https://bugzilla.redhat.com/show_bug.cgi?id=1467129 Carl George changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NEXTRELEASE Last Closed||2017-07-06 17:50:47 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421480] Review Request: js-jquery-prettyphoto - PrettyPhoto is a jQuery based lightbox clone
https://bugzilla.redhat.com/show_bug.cgi?id=1421480 Randy Barlow changed: What|Removed |Added Fixed In Version||js-jquery-prettyphoto-3.1.6 ||-1.fc27 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467052] Review Request: gnome-password-generator - Graphical secure password generator
https://bugzilla.redhat.com/show_bug.cgi?id=1467052 --- Comment #15 from Fedora Update System --- gnome-password-generator-2.0.4-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-58751e422c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467052] Review Request: gnome-password-generator - Graphical secure password generator
https://bugzilla.redhat.com/show_bug.cgi?id=1467052 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431855] Review Request: python-debrepo - Inspect and compare Debian repositories
https://bugzilla.redhat.com/show_bug.cgi?id=1431855 --- Comment #4 from Ken Dreyer --- Thank you Julien, good catches. Here's the latest version. * Thu Jul 06 2017 Ken Dreyer - 0.0.3-2 - Drop duplicate BuildRequires: python2-devel - Use %%global macro instead of %%define Exact changes in Git: https://github.com/ktdreyer/python-debrepo/commit/fbb7d4b9076790a369fba937c0e6a6243133fa0f Spec: https://raw.githubusercontent.com/ktdreyer/python-debrepo/master/python-debrepo.spec SRPM: https://ktdreyer.fedorapeople.org/reviews/python-debrepo-0.0.3-2.fc27.src.rpm F27 scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20368654 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1460246] Review Request: wordgrinder - A minimal word processor
https://bugzilla.redhat.com/show_bug.cgi?id=1460246 Ben Cotton changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-07-06 16:02:10 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1459693] Review Request: recap - Generates reports of various system information
https://bugzilla.redhat.com/show_bug.cgi?id=1459693 --- Comment #6 from Carl George --- Upstream has decided to stick with the 750 permissions on /var/log/recap. Can we proceed with the review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421480] Review Request: js-jquery-prettyphoto - PrettyPhoto is a jQuery based lightbox clone
https://bugzilla.redhat.com/show_bug.cgi?id=1421480 --- Comment #2 from Gwyn Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/js-jquery-prettyphoto -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1460246] Review Request: wordgrinder - A minimal word processor
https://bugzilla.redhat.com/show_bug.cgi?id=1460246 --- Comment #9 from Gwyn Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/wordgrinder -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431855] Review Request: python-debrepo - Inspect and compare Debian repositories
https://bugzilla.redhat.com/show_bug.cgi?id=1431855 --- Comment #3 from Julien Enselme --- - BuildRequires: python2-devel is present twice. - I didn't catch it during initial review: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define srcname debrepo Can you use %global or justify the %define? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1466961] Review Request: datamash - A statistical, numerical and textual operations tool
https://bugzilla.redhat.com/show_bug.cgi?id=1466961
--- Comment #5 from Hannes Frederic Sowa ---
I updated the files in place.
I changed:
* removed info from BR
* added perl(Digest::MD5) perl(Digest::SHA) perl(Data::Dumper) to BR
* added Provides: bundled(gnulib) [do I need to include a version here? -
rpmlint complains]
* added Requires(preun): info
* consistently using %{buildroot} instead of $RPM_BUILD_ROOT
* added %check make check
* bash_completion is not a %config file
* added license and doc files
Do I need to add a version to bundled(gnulib)? rpmlint complains right now.
rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=20366919
F25: https://koji.fedoraproject.org/koji/taskinfo?taskID=20366933
Could you have another look?
Dave, I would love to make this package compatible to EPEL. I am going to read
into that but feel free to dump any links on me. :)
Thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1460246] Review Request: wordgrinder - A minimal word processor
https://bugzilla.redhat.com/show_bug.cgi?id=1460246 Gwyn Ciesla changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #8 from Gwyn Ciesla --- Excellent. There's also: wordgrinder.src:15: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 15) but you can finish that at import. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467417] Review Request: python-plaster - Application configuration settings abstraction layer
https://bugzilla.redhat.com/show_bug.cgi?id=1467417 --- Comment #4 from Fedora Update System --- python-plaster-0.5-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9790f68a4a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467417] Review Request: python-plaster - Application configuration settings abstraction layer
https://bugzilla.redhat.com/show_bug.cgi?id=1467417 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1432983] Review Request: camotics - Open-Source Simulation & Computer Aided Machining - A 3-axis CNC GCode simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1432983 --- Comment #13 from Fedora Update System --- camotics-1.1.1-6.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-8e5487b2e9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467417] Review Request: python-plaster - Application configuration settings abstraction layer
https://bugzilla.redhat.com/show_bug.cgi?id=1467417 Randy Barlow changed: What|Removed |Added Fixed In Version||python-plaster-0.5-1.fc27 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1432983] Review Request: camotics - Open-Source Simulation & Computer Aided Machining - A 3-axis CNC GCode simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1432983 --- Comment #12 from Fedora Update System --- camotics-1.1.1-7.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-045ae0bbc9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1432983] Review Request: camotics - Open-Source Simulation & Computer Aided Machining - A 3-axis CNC GCode simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1432983 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467995] Review Request: python-slackclient - Slack Developer Kit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1467995 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- python-slackclient-1.0.6-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-eb2f5d9307 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467417] Review Request: python-plaster - Application configuration settings abstraction layer
https://bugzilla.redhat.com/show_bug.cgi?id=1467417 --- Comment #3 from Randy Barlow --- Thanks for the review! I've addressed your suggestions in this commit: http://pkgs.fedoraproject.org/cgit/rpms/python-plaster.git/commit/?id=51ece743fc76b371fff75ca4e5eeabed518e1a44 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1460246] Review Request: wordgrinder - A minimal word processor
https://bugzilla.redhat.com/show_bug.cgi?id=1460246 --- Comment #7 from Ben Cotton --- I broke up the BuildRequires as suggested and modified my patch to correct the debuginfo issues. rpmlint now returns: wordgrinder-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/wordgrinder-wordgrinder-0.6/.obj wordgrinder-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/wordgrinder-wordgrinder-0.6/.obj 1 packages and 0 specfiles checked; 0 errors, 2 warnings. The hidden file is expected. Updated SRPM/spec: Spec: https://bcotton.fedorapeople.org/wordgrinder/wordgrinder.spec SRPM: https://bcotton.fedorapeople.org/wordgrinder/wordgrinder-0.6-4.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467322] Review Request: manifest-tool - A command line tool used for creating manifest list objects
https://bugzilla.redhat.com/show_bug.cgi?id=1467322 --- Comment #6 from Josh Boyer --- (In reply to Adam Miller from comment #5) Thanks for picking up the review! > ITEMS TO FIX > > > - All bundled golang libraries need to be listed as 'Provides: > bundled() = ' directives as per > https://fedoraproject.org/wiki/Packaging: > Guidelines#Bundling_and_Duplication_of_system_libraries > > Other than that, the package looks good. OK, so I have two questions: 1) Why do e.g. runc, docker, etc not Provide anything they bundle? Confused there. I see stuff in -devel, but not in the main packages. 2) An example of a Provide for this package would be: Provides: bundled(golang(github.com/codegangsta/cli/)) = v1.2.0 Provides: bundled(golang(golang.org/x/net)) = master correct? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467052] Review Request: gnome-password-generator - Graphical secure password generator
https://bugzilla.redhat.com/show_bug.cgi?id=1467052 --- Comment #14 from Julien Enselme --- > you forgot to remove the `mkdir` in %install, but that doesn't hurt, it's > just superfluous, since %make_install would create them anyways… ;) I really thought I did it. Really fixed for import. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1466961] Review Request: datamash - A statistical, numerical and textual operations tool
https://bugzilla.redhat.com/show_bug.cgi?id=1466961
--- Comment #4 from Hannes Frederic Sowa ---
(In reply to José Matos from comment #2)
> Taking care of the review.
>
> According to fedora-review the package has the following issues:
>
> - Provides: bundled(gnulib) in place as required.
> Note: Bundled gnulib but no Provides: bundled(gnulib)
> See:
>
> http://fedoraproject.org/wiki/Packaging:
> No_Bundled_Libraries#Requirement_if_you_bundle
> - All build dependencies are listed in BuildRequires, except for any that
> are listed in the exceptions section of Packaging Guidelines.
> Note: These BR are not needed: info
> See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
> - Package uses either %{buildroot} or $RPM_BUILD_ROOT
> Note: Using both %{buildroot} and $RPM_BUILD_ROOT
> See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros
>
> Could you comment/take care of this, please?
I will. Thanks for the review. I upload a new specs and srpm new.
I also should mention that this my first RPM in fedora, but I already found a
sponsor (lrintel).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1460246] Review Request: wordgrinder - A minimal word processor
https://bugzilla.redhat.com/show_bug.cgi?id=1460246 Gwyn Ciesla changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #6 from Gwyn Ciesla --- Much better. - rpmlint checks return: wordgrinder-debuginfo.x86_64: E: debuginfo-without-sources This debuginfo package appears to contain debug symbols but no source files. This is often a sign of binaries being unexpectedly stripped too early during the build, or being compiled without compiler debug flags (which again often is a sign of distro's default compiler flags ignored which might have security consequences), or other compiler flags which result in rpmbuild's debuginfo extraction not working as expected. Verify that the binaries are not unexpectedly stripped and that the intended compiler flags are used. - package meets naming guidelines - package meets packaging guidelines - license ( MIT ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file It would be good to break up the BuildRequires into multiple lines, for readability. So at the moment the debuginfo is the only fix needed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467322] Review Request: manifest-tool - A command line tool used for creating manifest list objects
https://bugzilla.redhat.com/show_bug.cgi?id=1467322
Adam Miller changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|admil...@redhat.com
--- Comment #5 from Adam Miller ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Apache (v2.0)", "Unknown or
generated", "MIT/X11 (BSD like)", "BSD (3 clause)", "BSD (2 clause)",
"*No copyright* Apache (v2.0)". 795 files have unknown license.
Detailed output of licensecheck in /home/admiller/reviews/1467322
-manifest-tool/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: Uses parallel make %{?_smp_mflags} macro.
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
manifest-tool-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to
[Bug 1460246] Review Request: wordgrinder - A minimal word processor
https://bugzilla.redhat.com/show_bug.cgi?id=1460246 --- Comment #5 from Ben Cotton --- Ah! Looks like luajit changed versions. I've reworked it a little bit and it now builds in f25 and f26 mocks: Spec: https://bcotton.fedorapeople.org/wordgrinder/wordgrinder.spec SRPM: https://bcotton.fedorapeople.org/wordgrinder/wordgrinder-0.6-3.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467322] Review Request: manifest-tool - A command line tool used for creating manifest list objects
https://bugzilla.redhat.com/show_bug.cgi?id=1467322 Adam Miller changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467322] Review Request: manifest-tool - A command line tool used for creating manifest list objects
https://bugzilla.redhat.com/show_bug.cgi?id=1467322 Adam Miller changed: What|Removed |Added CC||admil...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1466961] Review Request: datamash - A statistical, numerical and textual operations tool
https://bugzilla.redhat.com/show_bug.cgi?id=1466961 Dave Love changed: What|Removed |Added CC||dave.l...@manchester.ac.uk --- Comment #3 from Dave Love --- Some comments, as I intended to get round to re-submitting this: It needs Requires(preun): info The licence isn't installed, and there's an empty %doc. It should run make check (and BR perl(Digest::MD5) perl(Digest::SHA) perl(Data::Dumper)). I don't think the completion file should be %config. [The packaging guide could use instructions for completions.] Can I interest you in changes for completion installation on EPEL? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1434410] Review Request: python-compreffor - CFF table subroutinizer for FontTools
https://bugzilla.redhat.com/show_bug.cgi?id=1434410 --- Comment #4 from Fedora Update System --- python-compreffor-0.4.4-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c325ea8aa9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1434410] Review Request: python-compreffor - CFF table subroutinizer for FontTools
https://bugzilla.redhat.com/show_bug.cgi?id=1434410 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467417] Review Request: python-plaster - Application configuration settings abstraction layer
https://bugzilla.redhat.com/show_bug.cgi?id=1467417 --- Comment #2 from Gwyn Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-plaster -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421480] Review Request: js-jquery-prettyphoto - PrettyPhoto is a jQuery based lightbox clone
https://bugzilla.redhat.com/show_bug.cgi?id=1421480 Gwyn Ciesla changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Gwyn Ciesla --- - rpmlint checks return: W: no-%build-section Not needed. Some spelling errors as well, ignorable. - package meets naming guidelines - package meets packaging guidelines - license ( GPLv2 ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Looks great, APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421480] Review Request: js-jquery-prettyphoto - PrettyPhoto is a jQuery based lightbox clone
https://bugzilla.redhat.com/show_bug.cgi?id=1421480 Gwyn Ciesla changed: What|Removed |Added Status|NEW |ASSIGNED CC||limburg...@gmail.com Assignee|nob...@fedoraproject.org|limburg...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467418] Review Request: python-plaster_pastedeploy - A PasteDeploy binding to the plaster configuration loader
https://bugzilla.redhat.com/show_bug.cgi?id=1467418 --- Comment #3 from Randy Barlow --- I've renamed it to use the dash and I've added the BuildRequires. Thanks! Spec URL: https://bowlofeggs.fedorapeople.org/python-plaster-pastedeploy.spec SRPM URL: https://bowlofeggs.fedorapeople.org/python-plaster-pastedeploy-0.3.2-1.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467995] Review Request: python-slackclient - Slack Developer Kit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1467995 --- Comment #7 from Gwyn Ciesla --- I'll give it a go. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1301219 David Benoit changed: What|Removed |Added CC||dben...@redhat.com Flags||needinfo? --- Comment #14 from David Benoit --- Has there been any progress on this? I'd love to see Racket in the Fedora repositories. Is there anything I can do do help move this along? I've never submitted a package for review before. If I start a new rpm build with updated sources, should I open a new Bugzilla report, or post here? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467995] Review Request: python-slackclient - Slack Developer Kit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1467995 --- Comment #6 from Randy Barlow --- Thanks for the offer! I don't have any more Python packages waiting for review right now. If you are comfortable with a JavaScript package I've got this one: https://bugzilla.redhat.com/show_bug.cgi?id=1421480 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421358] Review Request: js-jquery-noty - A jQuery notification plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1421358 Randy Barlow changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-07-06 10:04:27 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1419361] Review Request: js-jquery-datetimepicker - jQuery Plugin Date and Time Picker
https://bugzilla.redhat.com/show_bug.cgi?id=1419361 Randy Barlow changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-07-06 10:04:05 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1410901] Review Request: python-fmn - A system for generic fedmsg-driven notifications for end users
https://bugzilla.redhat.com/show_bug.cgi?id=1410901 Randy Barlow changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2017-02-15 15:51:05 |2017-07-06 10:02:36 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1424839] Review Request: php-rmccue-requests - Requests for PHP is a humble HTTP request library
https://bugzilla.redhat.com/show_bug.cgi?id=1424839 Randy Barlow changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-07-06 10:00:54 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1429152] Review Request: php-mikealmond-musicbrainz - A PHP library to access MusicBrainz' s Web Service v2
https://bugzilla.redhat.com/show_bug.cgi?id=1429152 Randy Barlow changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-07-06 10:00:45 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467132] Review Request: json-c12 - JSON implementation in C
https://bugzilla.redhat.com/show_bug.cgi?id=1467132 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467132] Review Request: json-c12 - JSON implementation in C
https://bugzilla.redhat.com/show_bug.cgi?id=1467132 --- Comment #10 from Fedora Update System --- json-c12-0.12.1-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-99ae3cbbfb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467995] Review Request: python-slackclient - Slack Developer Kit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1467995 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467995] Review Request: python-slackclient - Slack Developer Kit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1467995 --- Comment #5 from Fedora Update System --- python-slackclient-1.0.6-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-eb2f5d9307 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1460246] Review Request: wordgrinder - A minimal word processor
https://bugzilla.redhat.com/show_bug.cgi?id=1460246 --- Comment #4 from Gwyn Ciesla --- Created attachment 1294931 --> https://bugzilla.redhat.com/attachment.cgi?id=1294931&action=edit Build log Fails to build on f26. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467995] Review Request: python-slackclient - Slack Developer Kit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1467995 --- Comment #4 from Gwyn Ciesla --- Thank you! Looks like Dan beat me to 1467417, I can do another if you have one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467995] Review Request: python-slackclient - Slack Developer Kit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1467995 --- Comment #3 from Gwyn Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-slackclient -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1460246] Review Request: wordgrinder - A minimal word processor
https://bugzilla.redhat.com/show_bug.cgi?id=1460246 Gwyn Ciesla changed: What|Removed |Added CC||limburg...@gmail.com Assignee|nob...@fedoraproject.org|limburg...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467132] Review Request: json-c12 - JSON implementation in C
https://bugzilla.redhat.com/show_bug.cgi?id=1467132 --- Comment #9 from Gwyn Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/json-c12 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1467129] Review Request: python-pdir2 - Pretty dir() printing with joy
https://bugzilla.redhat.com/show_bug.cgi?id=1467129 --- Comment #9 from Gwyn Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-pdir2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462412] Review Request: tworld - a puzzle game
https://bugzilla.redhat.com/show_bug.cgi?id=1462412 --- Comment #15 from Fedora Update System --- tworld-1.3.2-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1452649] Review Request: python-exabgp - Package review request for ExaBGP spec
https://bugzilla.redhat.com/show_bug.cgi?id=1452649 Luke Hinds changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |UPSTREAM Last Closed||2017-07-06 04:31:48 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
