[Bug 1428202] Review Request: sirikali - GUI front end to encfs,cryfs, gocryptfs and securefs
https://bugzilla.redhat.com/show_bug.cgi?id=1428202 Raphael Groner changed: What|Removed |Added Flags|fedora-review? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1428202] Review Request: sirikali - GUI front end to encfs,cryfs, gocryptfs and securefs
https://bugzilla.redhat.com/show_bug.cgi?id=1428202 Raphael Groner changed: What|Removed |Added Flags||fedora-review? --- Comment #14 from Raphael Groner --- (In reply to Damian Wrobel from comment #13) > (In reply to Raphael Groner from comment #12) > Yes, I'm interested - (just after my holiday). Please follow the policy: https://fedoraproject.org/wiki/Package_Review_Process#Reviewer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1426193] Review Request: ara - Ansible Run Analysis, Record and visualize Ansible Playbook runs
https://bugzilla.redhat.com/show_bug.cgi?id=1426193 --- Comment #36 from Gwyn Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/ara -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1433757] Review Request: python-glyphsLib - A bridge from Glyphs source files to UFOs
https://bugzilla.redhat.com/show_bug.cgi?id=1433757 --- Comment #10 from Athos Ribeiro --- Thank you for the review, Fabio and Elliott! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462412] Review Request: tworld - a puzzle game
https://bugzilla.redhat.com/show_bug.cgi?id=1462412 --- Comment #18 from Fedora Update System --- tworld-1.3.2-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462412] Review Request: tworld - a puzzle game
https://bugzilla.redhat.com/show_bug.cgi?id=1462412 --- Comment #17 from Fedora Update System --- tworld-1.3.2-3.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431745] Review Request: golang-github-cznic-lldb - Low-level database engine implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1431745 --- Comment #7 from Fedora Update System --- golang-github-cznic-lldb-1.1.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-876d19bc9c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1465881] Review Request: golang-github-cznic-lexer - Run time generator of action less scanners written in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1465881 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System --- golang-github-cznic-lexer-0-0.1.20141211.git52ae786.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-13eebc05f9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431745] Review Request: golang-github-cznic-lldb - Low-level database engine implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1431745 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|RAWHIDE |--- Keywords||Reopened --- Comment #6 from Fedora Update System --- golang-github-cznic-lldb-1.1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1e6526c32d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431748] Review Request: golang-github-cznic-ql - Embedded SQL database written in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1431748 Bug 1431748 depends on bug 1431745, which changed state. Bug 1431745 Summary: Review Request: golang-github-cznic-lldb - Low-level database engine implementation in Go https://bugzilla.redhat.com/show_bug.cgi?id=1431745 What|Removed |Added Status|CLOSED |ON_QA Resolution|RAWHIDE |--- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 756780] Review Request: xosd - On-screen display library for X
https://bugzilla.redhat.com/show_bug.cgi?id=756780 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|ERRATA |--- Keywords||Reopened --- Comment #13 from Fedora Update System --- xosd-2.2.14-24.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-203bf9e58e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1432214] Review Request: reg - Docker registry v2 command line client.
https://bugzilla.redhat.com/show_bug.cgi?id=1432214 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-07-15 15:52:52 --- Comment #26 from Fedora Update System --- reg-0.4.1-5.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1432983] Review Request: camotics - Open-Source Simulation & Computer Aided Machining - A 3-axis CNC GCode simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1432983 --- Comment #19 from Fedora Update System --- camotics-1.1.1-7.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1428202] Review Request: sirikali - GUI front end to encfs,cryfs, gocryptfs and securefs
https://bugzilla.redhat.com/show_bug.cgi?id=1428202 Damian Wrobel changed: What|Removed |Added Status|NEW |ASSIGNED Flags|needinfo?(dwrobel@ertelnet. | |rybnik.pl) | --- Comment #13 from Damian Wrobel --- (In reply to Raphael Groner from comment #12) Yes, I'm interested - (just after my holiday). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1432983] Review Request: camotics - Open-Source Simulation & Computer Aided Machining - A 3-axis CNC GCode simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1432983 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-07-15 14:49:48 --- Comment #18 from Fedora Update System --- camotics-1.1.1-7.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468830] Review Request: abbayedesmorts-gpl - Platform game set in 13th century
https://bugzilla.redhat.com/show_bug.cgi?id=1468830 --- Comment #12 from Andrea Musuruane --- Spec URL: https://musuruan.fedorapeople.org/abbayedesmorts-gpl.spec SRPM URL: https://musuruan.fedorapeople.org/abbayedesmorts-gpl-2.0.1-3.20170709git.fc25.src.rpm Changelog: - Fixed AppData file - Fixed LDFLAGS usage -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468665] Review Request: gsettings-qt - QML bindings for GSettings
https://bugzilla.redhat.com/show_bug.cgi?id=1468665
--- Comment #8 from Robin Lee ---
[!]: Macros in comment:
# %global _qt5_qmldir %{_qt5_archdatadir}/qml
[!]: The Release: tag is still bad, follow:
https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots
https://fedoraproject.org/wiki/Packaging:Versioning#More_complex_versioning
It should really be something like: 0.0.20170714bzr83%{?dist}
The first '0' will be always there until upstream really make a versioned
release.
https://fedoraproject.org/wiki/Packaging:Versioning#Upstream_has_never_chosen_a_version
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1426193] Review Request: ara - Ansible Run Analysis, Record and visualize Ansible Playbook runs
https://bugzilla.redhat.com/show_bug.cgi?id=1426193 --- Comment #35 from David Moreau Simard --- @Dusty, this is correct. I've been super busy recently, I hope to be able to get this going soon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468665] Review Request: gsettings-qt - QML bindings for GSettings
https://bugzilla.redhat.com/show_bug.cgi?id=1468665 --- Comment #7 from Zamir SUN --- I happened to add a exra . in the version of comment 6. Updated SPEC URL: https://zsun.fedorapeople.org/pub/pkgs/gsettings-qt/gsettings-qt.spec SRPM URL: https://zsun.fedorapeople.org/pub/pkgs/gsettings-qt/gsettings-qt-0-0.20170715bzr83.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468665] Review Request: gsettings-qt - QML bindings for GSettings
https://bugzilla.redhat.com/show_bug.cgi?id=1468665 --- Comment #6 from Zamir SUN --- SPEC URL: https://zsun.fedorapeople.org/pub/pkgs/gsettings-qt/gsettings-qt.spec SRPM URL: https://zsun.fedorapeople.org/pub/pkgs/gsettings-qt/gsettings-qt-0-0.20170715.bzr83.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468665] Review Request: gsettings-qt - QML bindings for GSettings
https://bugzilla.redhat.com/show_bug.cgi?id=1468665
--- Comment #5 from Zamir SUN ---
(In reply to Robin Lee from comment #4)
> [!]: The Release: tag is still bad, follow:
> https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots
>
> https://fedoraproject.org/wiki/Packaging:Versioning#More_complex_versioning
> It should be something like: 0.0.20170714bzr83%{?dist}
Thanks.
I think you mean
Version:0
Release:0.MMDD.bzr%{_revision}%{?dist}
I'll upload the updated version soon.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1470842] Review Request: bazel - A fast, scalable, multi-language and extensible build system
https://bugzilla.redhat.com/show_bug.cgi?id=1470842
--- Comment #1 from Zamir SUN ---
Hi,
I think you need major fix for this package. IMO we do not allow binary file in
package but there are many JAR files in source.
Besides, if you want to use ./compile.sh to build, you need to write clear
justification why in the SPEC file.
Some files is with bad permission (555 while it is not actually for execute).
See rpmlint details below.
This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Permissions on files are set properly.
Note: See rpmlint output
See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
- All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: These BR are not needed: gcc unzip gcc-c++
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
= MUST items =
C/C++:
[ ]: Provides: bundled(gnulib) in place as required.
Note: Sources not installed
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Apache (v2.0)", "Apache (v2.0) NTP", "Unknown or generated".
364 files have unknown license.
[!]: %build honors applicable compiler flags or justifies otherwise.
[!]: Package contains no bundled libraries without FPC exception.
Note: Especially check following dirs for bundled code: third_party
[x]: Changelog in prescribed format.
[!]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 81920 bytes in 5 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream
[Bug 1308488] Review Request: mediaconch - Most relevant technical and tag data for video and audio files
https://bugzilla.redhat.com/show_bug.cgi?id=1308488 --- Comment #11 from Jérôme Martinez --- Vitaly, thank you for your review, appreciated. > This should be moved into -kde subpackage with dependency on KDE. I see that other Fedora .rpms have the .desktop file included in their main .rpm (no -kde subpackage), just with a different path. Is it OK if we move (after checking all is up to date) the .desktop file to /usr/share/applications instead of having just this .desktop file in a -kde subpackage? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1308488] Review Request: mediaconch - Most relevant technical and tag data for video and audio files
https://bugzilla.redhat.com/show_bug.cgi?id=1308488
--- Comment #10 from Vitaly Zaitsev ---
> %if 0%{?fedora} || 0%{?rhel} > 7
Can be replaced to:
%if 0%{?rhel} < 7
BuildRequires: pkgconfig(Qt5WebKit)
%else
BuildRequires: pkgconfig(Qt5WebEngine)
%endif
Group should be removed from main package and all it's subpackages.
> Requires: libzen%{?_isa} >= %{libzen_version}
> Requires: libmediainfo%{?_isa} >= %{libmediainfo_version}
Rpmlint will throw an error on this rows. Library dependencies should be
resolved automatically via rpmbuild.
> make install-strip DESTDIR=%{buildroot}
You don't need to strip binaries manually. Rpmbuild will do it for you and
generate -debuginfo subpackage.
> install -dm 755 %{buildroot}%{_datadir}/kde4/services/ServiceMenus/
> install -m 644 -p Project/GNU/GUI/mediaconch-gui.kde4.desktop
> %{buildroot}%{_datadir}/kde4/services/ServiceMenus/mediaconch-gui.desktop
This should be moved into -kde subpackage with dependency on KDE.
> install -dm 755 %{buildroot}%{_datadir}/apps/konqueror/servicemenus
> install -m 644 -p Project/GNU/GUI/mediaconch-gui.kde3.desktop
> %{buildroot}%{_datadir}/apps/konqueror/servicemenus/mediaconch-gui.desktop
This should be removed as KDE3 already reached it's EOL and dropped from Fedora
repositories.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1308488] Review Request: mediaconch - Most relevant technical and tag data for video and audio files
https://bugzilla.redhat.com/show_bug.cgi?id=1308488 Vitaly Zaitsev changed: What|Removed |Added Status|NEW |ASSIGNED CC||vit...@easycoding.org Assignee|nob...@fedoraproject.org|vit...@easycoding.org --- Comment #9 from Vitaly Zaitsev --- I will review this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1433757] Review Request: python-glyphsLib - A bridge from Glyphs source files to UFOs
https://bugzilla.redhat.com/show_bug.cgi?id=1433757 Fabio Valentini changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #9 from Fabio Valentini --- I don't particularly care whether you use the github or pypi sources, but since there's no reason to use the pypi ones, "official" github sources are the way to go IMO. Only issue I had with this package (shebangs) has been resolved, so approving. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat
https://bugzilla.redhat.com/show_bug.cgi?id=1421413 --- Comment #11 from Frank Crawford --- Okay, I believe I've updated the spec file for all the issues raised, and here is the new spec file and updated SRPM. Spec URL: https://fedorapeople.org/~frankcrawford/sysusage.spec SRPM URL: https://fedorapeople.org/~frankcrawford/sysusage-5.5-2.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
