[Bug 1268745] Review Request: rubygem-parser - A Ruby parser written in pure Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268745

Roman Joost  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268745] Review Request: rubygem-parser - A Ruby parser written in pure Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268745

Roman Joost  changed:

   What|Removed |Added

 CC||rjo...@redhat.com
   Assignee|nob...@fedoraproject.org|rjo...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268744] Review Request: rubygem-ast - A library for working with Abstract Syntax Trees

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268744

Roman Joost  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Roman Joost  ---
Looks good - approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268744] Review Request: rubygem-ast - A library for working with Abstract Syntax Trees

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268744



--- Comment #2 from Roman Joost  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 15 files have
 unknown license. Detailed output of licensecheck in
 /home/rjoost/tmp/1268744-rubygem-ast/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gems,
 /usr/share/gems/doc
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ruby:
[-]: Platform dependent files must all go under %{gem_extdir_mri}, platform
 independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).

= SHOULD items =

Generic:
[x]: Avoid bundling fonts in non-fonts packages.
 Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rubygem-
 ast-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
 

[Bug 1426193] Review Request: ara - Ansible Run Analysis, Record and visualize Ansible Playbook runs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426193
Bug 1426193 depends on bug 1447089, which changed state.

Bug 1447089 Summary: Review Request: 
python-XStatic-Patternfly-Bootstrap-Treeview - Patternfly Bootstrap Treeview 
CSS/JS framework (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1447089

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447089] Review Request: python-XStatic-Patternfly-Bootstrap-Treeview - Patternfly Bootstrap Treeview CSS /JS framework (XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447089

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2017-06-09 14:52:29 |2017-08-06 22:20:49



--- Comment #8 from Fedora Update System  ---
python-XStatic-Patternfly-Bootstrap-Treeview-2.1.3.2-1.fc25 has been pushed to
the Fedora 25 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444682] Review Request: python-XStatic-DataTables - DataTables jquery javascript framework ( XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444682



--- Comment #13 from Fedora Update System  ---
python-XStatic-DataTables-1.10.15.1-1.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881



--- Comment #16 from Fedora Update System  ---
guile22-2.2.1-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476560] Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476560



--- Comment #4 from Zbigniew Jędrzejewski-Szmek  ---
Oops, sorry. My comment about glib-compile-schemas was wrong. I trusted
fedora-review without checking the guidelines, but
/usr/bin/glib-compile-schemas should not be called since F24 (#1409315). So
please remove those calls again.

Looks good otherwise, I'll re-review when deepin-artwork-themes review is done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421058



--- Comment #6 from Zbigniew Jędrzejewski-Szmek  ---
Oops, sorry. My comment about glib-compile-schemas was wrong. I trusted
fedora-review without checking the guidelines, but
/usr/bin/glib-compile-schemas should not be called since F24 (#1409315). So
please remove those calls again.

Looks good otherwise, I'll re-review when #1476560 is done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1460917] Review Request: rpkg - Command-line client tool to DistGit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1460917



--- Comment #31 from Fedora Update System  ---
rpkg-client-0.8-1.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1460917] Review Request: rpkg - Command-line client tool to DistGit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1460917

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2017-07-26 18:52:17 |2017-08-06 18:25:28



--- Comment #30 from Fedora Update System  ---
rpkg-client-0.8-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443



--- Comment #14 from Christoph Junghans  ---
(In reply to Christoph Junghans from comment #12)
> Created attachment 1292418 [details]
> hdf5: enable szip support through libaec
> 
> With this patch we can now enable szip support in hdf5:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=20122306
> 
> Patch was send to hdf5-ow...@fedoraproject.org.
https://src.fedoraproject.org/rpms/hdf5/pull-request/1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421058



--- Comment #5 from sensor@gmail.com ---
SPEC: 
https://raw.githubusercontent.com/FZUG/repo/afcfb988017bd8354ec4f60e63c5d692da957cf4/rpms/deepin_project/deepin-metacity.spec

Fixed all. Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444682] Review Request: python-XStatic-DataTables - DataTables jquery javascript framework ( XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444682



--- Comment #12 from Fedora Update System  ---
python-XStatic-DataTables-1.10.15.1-1.el7 has been pushed to the Fedora EPEL 7
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447120] Review Request: python-pyfakefs - pyfakefs implements a fake file system that mocks the Python file system modules.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447120



--- Comment #14 from Fedora Update System  ---
python-pyfakefs-3.1-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444666] Review Request: python-XStatic-Patternfly - Patternfly CSS/ JS framework (XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444666



--- Comment #15 from Fedora Update System  ---
python-XStatic-Patternfly-3.21.0.1-1.el7 has been pushed to the Fedora EPEL 7
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476560] Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476560



--- Comment #3 from sensor@gmail.com ---
SPEC: 
https://raw.githubusercontent.com/FZUG/repo/5e57f37830e634919c2c440cf8a5fb2311ca2e7e/rpms/deepin_project/deepin-desktop-schemas.spec

Fixed :)
I will be submit deepin-artwork-themes package for review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421048] Review Request: deepin-sound-theme - Deepin sound theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421048



--- Comment #2 from sensor@gmail.com ---
SPEC: 
https://raw.githubusercontent.com/FZUG/repo/aae8453fbda7ce83d72d3c385a4122909f7d759e/rpms/deepin_project/deepin-sound-theme.spec

I fixed release tag and description. Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476584] Review Request: deepin-session-ui - Deepin desktop-environment Session UI module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476584



--- Comment #5 from sensor@gmail.com ---
SPEC: 
https://raw.githubusercontent.com/FZUG/repo/0ee362e6a7f81ba7df3ddda0472465154d651e6e/rpms/deepin_project/deepin-session-ui.spec
Diff: 
https://github.com/FZUG/repo/commit/0ee362e6a7f81ba7df3ddda0472465154d651e6e

> - The package name should follow upstream convention, dde-session-ui
We want to use same prefix ("deepin-") for Deepin desktop environment packages
instead of "dde-". Some projects of deepin use easy to confuse the name, so we
made the above changes.

> - You must validate .desktop file with desktop-file-validate in %check. See 
> https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
> - Rpmlint complains that one of your Desktop file is not valid:
dde-session-ui.x86_64: E: invalid-desktopfile
/usr/share/applications/deepin-toggle-desktop.desktop value "Deepin;" for key
"OnlyShowIn" in group "Desktop Entry" contains an unregistered value "Deepin";
values extending the format should start with "X-"
The desktop-file-validate command failed due to "Deepin" key not included the
desktop-file-utils packages. So i submit new bug for this.
(https://bugs.freedesktop.org/show_bug.cgi?id=101878)

> - As I said in other review before, if you're packaging a release version, 
> you must not include the git revision in your %changelog
Fixed

> - The description must end with a dot, and more detailed one would be nice, 
> to explain what this specific module does.
Fixed

> - You must run gtk-update-icon-cache in %postun and %posttrans as your 
> package contains icons. See 
> https://fedoraproject.org/wiki/PackagingDrafts/ScriptletSnippets#GTK.2B_icon_cache
Fixed

> Also, you could use pkgconfig to handle your -devel dependencies.
Fixed, except the deepin-tool-kit, because the upstream decide to split package
to dtkcore and dtkwidget, and them doesn‘t compatible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476558] Review Request: deepin-desktop-base - Base component for Deepin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476558



--- Comment #3 from Robert-André Mauchin  ---
You should post both the updated SPEC and the updated SRPM.
One last thing, you shouldn't own "/usr/share/distro-info" because it is owned
by other package (distro-info).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1422123] Review Request: python-pykafka - Full-featured Pure-Python Kafka Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1422123

Haïkel Guémar  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2017-08-06 13:18:16



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476558] Review Request: deepin-desktop-base - Base component for Deepin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476558



--- Comment #2 from sensor@gmail.com ---
SPEC: 
https://raw.githubusercontent.com/FZUG/repo/05164f3d4a5344d2c6099e0675a92ec205f9d434/rpms/deepin_project/deepin-desktop-base.spec

Hello, 

Thank you for your help. I fixed some problem.

- change to "Recommends:  deepin-wallpapers"
- enhance description
- remove git revision from changelog and remove "PREFIX=%{_prefix}"
- add %dir line to %files
- change /usr/lib/deepin/deepin-version to /usr/share/deepin/deepin-version

Please see
https://github.com/FZUG/repo/commit/05164f3d4a5344d2c6099e0675a92ec205f9d434

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426972] Review Request: hugo - A Fast and Flexible Static Site Generator built with love in GoLang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426972

Dusty Mabe  changed:

   What|Removed |Added

  Flags||needinfo?(athoscribeiro@gma
   ||il.com)



--- Comment #26 from Dusty Mabe  ---
Hey Athos,

Can we get this updated so it will make it into Fedora!!! :) Thanks for all the
hard work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476458] Review Request: paho-c - MQTT client library in C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476458

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #8 from Robert-André Mauchin  ---
Hello,

A couple of points:

 - make %{?_smp_mflags} could be replaced with %make_build and make install
DESTDIR=%{buildroot} with %make_install
 - I believe you should include %license in the devel-docs package as it can be
installed independently of others.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476584] Review Request: deepin-session-ui - Deepin desktop-environment Session UI module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476584



--- Comment #4 from Robert-André Mauchin  ---
Also, you could use pkgconfig to handle your -devel dependencies.

If you don't know what's the pkgconfig name for a -devel, just search for it
with dnf. For example: 

>$dnf repoquery -l deepin-tool-kit-devel | grep ".pc"
>/usr/lib64/pkgconfig/dtkbase.pc
>/usr/lib64/pkgconfig/dtkutil.pc
>/usr/lib64/pkgconfig/dtkwidget.pc
>/usr/lib64/pkgconfig/dtkbase.pc
>/usr/lib64/pkgconfig/dtkutil.pc
>/usr/lib64/pkgconfig/dtkwidget.pc
>/usr/lib64/pkgconfig/dtkbase.pc
>/usr/lib64/pkgconfig/dtkutil.pc
>/usr/lib64/pkgconfig/dtkwidget.pc

so you can add: pkgconfig(dtkbase) as a BR

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476584] Review Request: deepin-session-ui - Deepin desktop-environment Session UI module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476584

Robert-André Mauchin  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #3 from Robert-André Mauchin  ---
Actually after reading the specs, I don't think that rpmlint error is relevant.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476584] Review Request: deepin-session-ui - Deepin desktop-environment Session UI module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476584

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #2 from Robert-André Mauchin  ---
Hello,

 - The package name should follow upstream convention, dde-session-ui
 - You must validate .desktop file with desktop-file-validate in %check. See
https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
 - As I said in other review before, if you're packaging a release version, you
must not include the git revision in your %changelog
 - The description must end with a dot, and more detailed one would be nice, to
explain what this specific module does.
 - You must run gtk-update-icon-cache in %postun and %posttrans as your package
contains icons. See
https://fedoraproject.org/wiki/PackagingDrafts/ScriptletSnippets#GTK.2B_icon_cache
 - Rpmlint complains that one of your Desktop file is not valid:
dde-session-ui.x86_64: E: invalid-desktopfile
/usr/share/applications/deepin-toggle-desktop.desktop value "Deepin;" for key
"OnlyShowIn" in group "Desktop Entry" contains an unregistered value "Deepin";
values extending the format should start with "X-"

I wasn't able to test it on Rawhide as one package on your copr repo depends on
qt 5.7.1. I built it on F26:

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3 or later)", "Unknown or generated". 700 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/dde-session-ui/review-dde-session-
 ui/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/dbus-1,
 /usr/share/dbus-1/services
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/share/dde-session-
 ui/translations(deepin-session-ui), /usr/share/dde-session-ui(deepin-
 session-ui)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[!]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain 

[Bug 1478689] Review Request: deepin-movie - Deepin Movie based on QtAV

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478689



--- Comment #2 from Robin Lee  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> Hmm, Robin, can you provide some details why this is closed?

Oh, this package requires qtav and in turn FFmpeg. The latter is not permitted
by Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478689] Review Request: deepin-movie - Deepin Movie based on QtAV

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478689

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
Hmm, Robin, can you provide some details why this is closed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #21 from Zamir SUN  ---
SPEC URL: https://zsun.fedorapeople.org/pub/pkgs/danmaq/danmaq.spec
SRPM URL:
https://zsun.fedorapeople.org/pub/pkgs/danmaq/danmaq-0.2-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #20 from Zamir SUN  ---
(In reply to Zamir SUN from comment #19)
> (In reply to Zamir SUN from comment #16)
> > (In reply to Zbigniew Jędrzejewski-Szmek from comment #15)
> > > ... that said, if you strongly prefer "danmaQ", then just go ahead — the
> > > guidelines (the old and the new) allow camelCased names when there's good
> > > justification.
> In order to make it sync with other distributions - Now I will change it to
> lower case danmaq but leave the . Will edit corresponding tickets soon.
...leave the binary file unchanged.. Sorry I happened to click the submit
before finishing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806

Zamir SUN  changed:

   What|Removed |Added

  Alias|danmaQ  |danmaq



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806

Zamir SUN  changed:

   What|Removed |Added

Summary|Review Request: danmaQ - A  |Review Request: danmaq - A
   |small client side Qt|small client side Qt
   |program to play danmaku on  |program to play danmaku on
   |any screen  |any screen



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #19 from Zamir SUN  ---
(In reply to Zamir SUN from comment #16)
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #15)
> > ... that said, if you strongly prefer "danmaQ", then just go ahead — the
> > guidelines (the old and the new) allow camelCased names when there's good
> > justification.
In order to make it sync with other distributions - Now I will change it to
lower case danmaq but leave the . Will edit corresponding tickets soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #18 from Zamir SUN  ---

(In reply to sensor.wen from comment #17)
> - "_" prefix in macro names is not necessary.
> 
> %{_commit} -> %{commit}

Oh, thanks. Will change it when packaging into repo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaQ - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806

sensor@gmail.com changed:

   What|Removed |Added

 CC||sensor@gmail.com



--- Comment #17 from sensor@gmail.com ---
- "_" prefix in macro names is not necessary.

%{_commit} -> %{commit}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421046] Review Request: golang-deepin-go-lib - Go bindings for DDE development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421046

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |deepin-go-lib - Go bindings |golang-deepin-go-lib - Go
   |for DDE development |bindings for DDE
   ||development



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434578] Review Request: gtef - GTK+ Text Editor Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434578



--- Comment #3 from c72...@yahoo.de ---
LaTeXila has switched from Gtef to Tepl in Release 3.25.1
https://git.gnome.org/browse/latexila/tree/NEWS

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476558] Review Request: deepin-desktop-base - Base component for Deepin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476558

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
Hello,


A few points:
 - It seems curious to me to depend on deepin-wallpapers. The package should be
usable even without the official wallpapers.
 - Your description should end with a dot "." It could be a bit more explicit.
What does this package do?
 - Your changelog entries shouldn't include the git revision if you are
packaging a release version. Git revisions only need to be included when you
are packaging a development snapshot.
 - PREFIX=%{_prefix} is not needed, the %make_install macro takes care of that.
 - Your package should own all the directories it creates with the %dir macro
For example %dir %{_datadir}/backgrounds/deepin
See also %{_datadir}/distro-info and %{_usr}/lib/deepin/ unless they are used
and should be owned by another deepin package.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3 or later)", "Unknown or generated". 22 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/deepin-desktop-base/review-deepin-desktop-
 base/licensecheck.txt
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib/deepin, /usr/share/backgrounds/deepin
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/i18n,
 /usr/lib/deepin, /usr/share/backgrounds/deepin, /usr/share/distro-
 info, /usr/share/plymouth
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager 

[Bug 1421046] Review Request: deepin-go-lib - Go bindings for DDE development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421046



--- Comment #3 from sensor@gmail.com ---
SPEC：
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00587260-golang-deepin-go-lib/deepin-go-lib.spec
SRPM: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00587260-golang-deepin-go-lib/golang-deepin-go-lib-1.0.5-2.fc26.src.rpm

Rename package name to golang-deepin-go-lib, and require the
golang-github-go-fsnotify-fsnotify instead of golang-github-howeyc-fsnotify
package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421048] Review Request: deepin-sound-theme - Deepin sound theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421048

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
Hello,

A few points:

 - You are packaging the git master but your SOURCE0 URL point to the released
version. It's a no-no: the source in the SOURCE0 must be what is compiled. I'd
recommend you to ask upstream to release a new version. Your other solutions
are: package the last released version (but it will lack a LICENSE file), or
package the master branch: in that case, your package name must follow the
versionning guidelines:
https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots
 - I'd like a slightly more descriptive description, like "Sound files for the
Deeping Desktop Environment."
 - In any case, your description must end with a dot "."
 - PREFIX=%{_prefix} is not needed.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3 or later)", "Unknown or generated". 29 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/deepin-sound-theme/review-deepin-sound-
 theme/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[?]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license 

[Bug 1478705] Review Request: deepin-calendar - Calendar for Deepin Desktop Environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478705

Zamir SUN  changed:

   What|Removed |Added

 CC||felixonm...@archlinux.org,
   ||sensor@gmail.com
 Blocks||1465889
   ||(DeepinDEPackageReview)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1465889
[Bug 1465889] Tracking: Deepin Desktop related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465889] Tracking: Deepin Desktop related package review tracker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465889

Zamir SUN  changed:

   What|Removed |Added

 Depends On||1478705




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1478705
[Bug 1478705] Review Request: deepin-calendar - Calendar for Deepin Desktop
Environment
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478705] New: Review Request: deepin-calendar - Calendar for Deepin Desktop Environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478705

Bug ID: 1478705
   Summary: Review Request: deepin-calendar - Calendar for Deepin
Desktop Environment
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: szts...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://zsun.fedorapeople.org/pub/pkgs/deepin-calendar/deepin-calendar.spec
SRPM URL:
https://zsun.fedorapeople.org/pub/pkgs/deepin-calendar/deepin-calendar-1.0.11-2.fc27.src.rpm
Description: Calendar for Deepin Desktop Environment.
Fedora Account System Username: zsun

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478703] Review Request: perl-Exporter-Easy - Takes the drudgery out of Exporting symbols

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478703

Emmanuel Seyman  changed:

   What|Removed |Added

 Blocks||1472755




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1472755
[Bug 1472755] perl-JSON-Path-0.411 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478703] New: Review Request: perl-Exporter-Easy - Takes the drudgery out of Exporting symbols

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478703

Bug ID: 1478703
   Summary: Review Request: perl-Exporter-Easy - Takes the
drudgery out of Exporting symbols
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: emman...@seyman.fr
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://people.parinux.org/~seyman/fedora/perl-Exporter-Easy/perl-Exporter-Easy.spec
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-Exporter-Easy/perl-Exporter-Easy-0.18-1.fc26.src.rpm
Description:
Exporter::Easy makes using Exporter easy. In its simplest case, it allows
you to drop the boilerplate code that comes with using Exporter, so more
complicated situations where you use tags to build lists and more tags
become easy

Fedora Account System Username: eseyman
Rpmlint Output: 2 packages and 1 specfiles checked; 0 errors, 0 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478656] Review Request: gap-pkg-digraphs - GAP package for digraphs and multidigraphs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478656

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
This looks very good to me.

You've got a couple of rpmlint errors because some files are empty:

gap-pkg-digraphs.x86_64: E: zero-length
/usr/lib/gap/pkg/digraphs/tst/out/.empty
gap-pkg-digraphs.x86_64: E: zero-length
/usr/lib/gap/pkg/digraphs/tst/out/test.d6

You can remove all zero-length files with:

find %{buildroot} -size 0 -delete

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "GPL", "GPL (v3 or later)", "Unknown or
 generated". 157 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/gap-pkg-digraphs/review-
 gap-pkg-digraphs/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD 

[Bug 1344276] Review Request: gdeploy - Tool to deploy GlusterFS clusters and other utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344276



--- Comment #26 from Eyal Edri  ---
Any update on accepting the gdeploy package? any more actions are required?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434578] Review Request: gtef - GTK+ Text Editor Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434578



--- Comment #2 from Kalev Lember  ---
Right. We still need gtef though to get latexila updated in F26.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475228

Robert-André Mauchin  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475228



--- Comment #10 from Robert-André Mauchin  ---
There's nothing after your %systemd_postun, didn't you forget to add the
service file there?
%systemd_postun tpm2-abrmd.service

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465889] Tracking: Deepin Desktop related package review tracker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465889
Bug 1465889 depends on bug 1478689, which changed state.

Bug 1478689 Summary: Review Request: deepin-movie - Deepin Movie based on QtAV
https://bugzilla.redhat.com/show_bug.cgi?id=1478689

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478689] Review Request: deepin-movie - Deepin Movie based on QtAV

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478689

Robin Lee  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||robinlee.s...@gmail.com
 Blocks||182235 (FE-Legal)
 Resolution|--- |WONTFIX
  Flags||fedora-review-
Last Closed||2017-08-06 03:56:31




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475961] Review Request: cmrt - C for Media Runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475961



--- Comment #7 from Robert-André Mauchin  ---
Thank you for your review and helpful comments.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457737] Review Request: rubygem-overcommit - Git hook manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457737

František Dvořák  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Blocks||201449 (FE-DEADREVIEW)
 Resolution|--- |NOTABUG
Last Closed||2017-08-06 03:07:40



--- Comment #5 from František Dvořák  ---
Dependency review has been closed as stalled, let's close also this one. Please
reopen, as needed.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465889] Tracking: Deepin Desktop related package review tracker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465889

Zamir SUN  changed:

   What|Removed |Added

 Depends On||1478689 (deepin-movie)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1478689
[Bug 1478689] Review Request: deepin-movie - Deepin Movie based on QtAV
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478689] Review Request: deepin-movie - Deepin Movie based on QtAV

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478689

Zamir SUN  changed:

   What|Removed |Added

 CC||felixonm...@archlinux.org,
   ||sensor@gmail.com
 Blocks||1465889
   ||(DeepinDEPackageReview)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1465889
[Bug 1465889] Tracking: Deepin Desktop related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478689] Review Request: deepin-movie - Deepin Movie based on QtAV

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478689

Zamir SUN  changed:

   What|Removed |Added

  Alias||deepin-movie



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478689] New: Review Request: deepin-movie - Deepin Movie based on QtAV

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478689

Bug ID: 1478689
   Summary: Review Request: deepin-movie - Deepin Movie based on
QtAV
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: szts...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://zsun.fedorapeople.org/pub/pkgs/deepin-movie/deepin-movie.spec
SRPM URL:
https://zsun.fedorapeople.org/pub/pkgs/deepin-movie/deepin-movie-2.2.14-2.fc27.src.rpm
Description: Movie player for Deepin desktop environment
Fedora Account System Username: zsun

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478358] Review Request: php-sebastian-diff2 - Diff implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478358



--- Comment #5 from Remi Collet  ---
Thanks for the review

New repo requested
https://pagure.io/dist-git-requests/issue/24
https://pagure.io/dist-git-requests/issue/26

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org