[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479027

Jan Chaloupka  changed:

   What|Removed |Added

 CC||jchal...@redhat.com



--- Comment #4 from Jan Chaloupka  ---
golang-googlecode-text-0-0.20.git65f4f82.fc27 at
https://koji.fedoraproject.org/koji/taskinfo?taskID=21229221

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476440] Review Request: gimp-luminosity-masks - Luminosity mask channels plug-in for Gimp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476440

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
gimp-luminosity-masks-0-3.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-88fc3cc994

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477137] Review Request: tetrominos - Simple CLI logical game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477137



--- Comment #9 from Fedora Update System  ---
tetrominos-1.0.1-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426972] Review Request: hugo - A Fast and Flexible Static Site Generator built with love in GoLang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426972
Bug 1426972 depends on bug 1427336, which changed state.

Bug 1427336 Summary: Missing Provides - cammelCase should not be used
https://bugzilla.redhat.com/show_bug.cgi?id=1427336

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443



--- Comment #16 from Fedora Update System  ---
libaec-1.0.1-4.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-fb600d5f60

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481477] Review Request: greenwave - Greenwave is a service for gating on automated tests by querying ResultsDB and WaiverDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481477

matt jia  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|dcall...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481477] New: Review Request: greenwave - Greenwave is a service for gating on automated tests by querying ResultsDB and WaiverDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481477

Bug ID: 1481477
   Summary: Review Request: greenwave - Greenwave is a service for
gating on automated tests by querying ResultsDB and
WaiverDB
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: m...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://mjia.fedorapeople.org/greenwave/greenwave.spec
SRPM URL: https://mjia.fedorapeople.org/greenwave/greenwave-0.1-1.fc25.src.rpm
Description: Greenwave is a service for gating on automated tests by querying
ResultsDB and WaiverDB.
Fedora Account System Username: mjia

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478461] Review Request: PyDrive - A wrapper library of google-api-python-client that simplifies many common Google Drive API tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478461



--- Comment #4 from Fedora Update System  ---
PyDrive-1.3.1-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-8ebb30441c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478461] Review Request: PyDrive - A wrapper library of google-api-python-client that simplifies many common Google Drive API tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478461

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431235] Review Request: python3-virtualenv - Tool to create isolated Python environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431235



--- Comment #1 from Orion Poplawski  ---
Spec URL: https://www.cora.nwra.com/~orion/fedora/python3-virtualenv.spec
SRPM URL:
https://www.cora.nwra.com/~orion/fedora/python3-virtualenv-15.1.0-1.el7.src.rpm

* Mon Aug 14 2017 Orion Poplawski  - 15.1.0-1
- Update to 15.1.0

https://koji.fedoraproject.org/koji/taskinfo?taskID=21231746

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427634] Review Request: syncthing - Continuous File Synchronization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427634



--- Comment #33 from Fedora Update System  ---
syncthing-0.14.36-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-af8b6b4204

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467651] Review Request: cvechecker - Tool for compare packages installed in your system with CVE database

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467651

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-08-14 17:50:37



--- Comment #11 from Fedora Update System  ---
cvechecker-3.8-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474958] Review Request: lammps - Large-scale Atomic/ Molecular Massively Parallel Simulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474958



--- Comment #5 from Christoph Junghans  ---
(In reply to Antonio Trande from comment #4)
> > Honestly lammps.py works with both, so should I just install 2 same files 
> > twice?
> 
> I guess you can install it in 'python3-sitearch' on Fedora (you need
> python3-devel) but 'python2-sitearch' on epel6 and 'python34-sitearch' on
> epel7.
> 
> Like 'python-vxi11':
> https://src.fedoraproject.org/rpms/python-vxi11/blob/master/f/python-vxi11.
> spec
> 
> Use Python macros, please:
> http://fedoraproject.org/wiki/Packaging:Python#Macros
Done! I also did a version bump to drop the one patch.

Spec URL: https://fedorapeople.org/~junghans/lammps.spec
SRPM URL: https://fedorapeople.org/~junghans/lammps-20170811-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462467] Review Request: hollywood - Fill your console with Hollywood melodrama techno-babble

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462467
Bug 1462467 depends on bug 1462466, which changed state.

Bug 1462466 Summary: Review Request: jp2a - Converts jpg images to ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1462466

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462466] Review Request: jp2a - Converts jpg images to ASCII

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462466

Raphael Groner  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-08-14 16:44:16



--- Comment #12 from Raphael Groner  ---
Imported and built in rawhide. As pagure does not allow me to build for other
branches, I'll delay till pagure is ready.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481416] New: Review Request: light - control backlight controllers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481416

Bug ID: 1481416
   Summary: Review Request: light - control backlight controllers
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jkadl...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Fedora Account System Username: frostyx
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/frostyx/light/fedora-rawhide-x86_64/00590463-light/light.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/frostyx/light/fedora-rawhide-x86_64/00590463-light/light-1.0-1.fc27.src.rpm
Description:

Light is a program to control backlight controllers under GNU/Linux,
it is the successor of lightscript, which was a bash script with the same
purpose,
and tries to maintain the same functionality.

Features

- Works excellent where other software have been proven unusable or
problematic,
  thanks to how it operates internally and the fact that it does not rely on X.
- Can automatically figure out the best controller to use,
  making full use of underlying hardware.
- Possibility to set a minimum brightness value, as some controllers
  set the screen to be pitch black at a vaĺue of 0 (or higher).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481415] New: Review Request: oci-umount - OCI umount hook for container runtimes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481415

Bug ID: 1481415
   Summary: Review Request: oci-umount - OCI umount hook for
container runtimes
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: l...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://lsm5.fedorapeople.org/oci-umount/oci-umount.spec
SRPM URL:
https://lsm5.fedorapeople.org/oci-umount/SRPMS/oci-umount-2.0.0-1.git299e781.fc26.src.rpm

Description:
OCI umount hooks unmount potential leaked mount points in a containers
mount namespaces.

Upstream: https://github.com/projectatomic/oci-umount

Fedora Account System Username: lsm5

koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21229349

$ rpmlint oci-umount.spec SRPMS/* RPMS/*
oci-umount.src: W: spelling-error Summary(en_US) runtimes -> run times,
run-times, centimes
oci-umount.src: W: spelling-error %description -l en_US unmount -> unmounted,
mount, Mount
oci-umount.src: W: spelling-error %description -l en_US namespaces -> name
spaces, name-spaces, names paces
oci-umount.x86_64: W: spelling-error Summary(en_US) runtimes -> run times,
run-times, centimes
oci-umount.x86_64: W: spelling-error %description -l en_US unmount ->
unmounted, mount, Mount
oci-umount.x86_64: W: spelling-error %description -l en_US namespaces -> name
spaces, name-spaces, names paces
3 packages and 1 specfiles checked; 0 errors, 6 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481415] Review Request: oci-umount - OCI umount hook for container runtimes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481415

Lokesh Mandvekar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|fkluk...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431868] Review Request: syncthing-inotify - Syncthing File watcher

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431868



--- Comment #4 from Fabio Valentini  ---
Yes, I know. This is due to an incompatibility with a changed API in syncthing
0.14.33+.

I have a patch from upstream that fixes the compilation. However, the tests
fail when run against the new version. I still have to investigate why.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431868] Review Request: syncthing-inotify - Syncthing File watcher

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431868



--- Comment #3 from Athos Ribeiro  ---
The package does not build in rawhide due to an error [1]

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21229077

[1] ./syncwatcher.go:503:23: cannot use false (type bool) as type ignore.Option
in argument to ignore.New

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480958] Review Request: golang-github-BurntSushi-freetype-go - A fork of freetype-go with bounding box calculations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480958



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-BurntSushi-freetype-go

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480958] Review Request: golang-github-BurntSushi-freetype-go - A fork of freetype-go with bounding box calculations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480958



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-BurntSushi-freetype-go

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480959] Review Request: golang-github-BurntSushi-graphics-go - Graphics library for the Go programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480959



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-BurntSushi-graphics-go

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480959] Review Request: golang-github-BurntSushi-graphics-go - Graphics library for the Go programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480959



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-BurntSushi-graphics-go

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480961] Review Request: golang-github-howeyc-fsnotify - File change notification Go language Binding

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480961



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-howeyc-fsnotify

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480961] Review Request: golang-github-howeyc-fsnotify - File change notification Go language Binding

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480961



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-howeyc-fsnotify

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426972] Review Request: hugo - A Fast and Flexible Static Site Generator built with love in GoLang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426972



--- Comment #31 from Athos Ribeiro  ---
(In reply to Dusty Mabe from comment #30)
> Thanks Athos 
> 
> What about issue #3? 

Working on it

> 
> Are the deps the ones mentioned by 1479027 1480762 and 1480781? I can try to
> review some of them if so.

Just 1480762 1480781, the other one is already taken!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479027



--- Comment #3 from Athos Ribeiro  ---
Just created the PR in golang-googlecode-text [1].

[1] https://src.fedoraproject.org/rpms/golang-googlecode-text/pull-request/1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1443076] Review Request: java-9-openjdk - OpenJDK Runtime Environment in implementation of java 9 specification

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1443076



--- Comment #43 from Severin Gehwolf  ---
(In reply to jiri vanek from comment #42)
> (In reply to Severin Gehwolf from comment #41)
> > (In reply to Severin Gehwolf from comment #40)
> > > (In reply to jiri vanek from comment #36)
> > > > Yah. I noted. Already respined: 
> > > > https://koji.fedoraproject.org/koji/taskinfo?taskID=21048132
> > > 
> > > BuildError: The following noarch package built differently on different
> > > architectures: java-9-openjdk-javadoc-zip-9.0.0.181-1.fc26.noarch.rpm
> > > 
> > > Not sure what do do about this. Make javadoc-zip archful?
> > 
> > Note that aot is x86_64 Linux only. So that might be the reason why this
> > happens.
> 
> Yes, that would be the reason. So There are only two options - to disable
> aot, or make javadocs arch dependent:(

The latter, please.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1443076] Review Request: java-9-openjdk - OpenJDK Runtime Environment in implementation of java 9 specification

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1443076



--- Comment #42 from jiri vanek  ---
(In reply to Severin Gehwolf from comment #41)
> (In reply to Severin Gehwolf from comment #40)
> > (In reply to jiri vanek from comment #36)
> > > Yah. I noted. Already respined: 
> > > https://koji.fedoraproject.org/koji/taskinfo?taskID=21048132
> > 
> > BuildError: The following noarch package built differently on different
> > architectures: java-9-openjdk-javadoc-zip-9.0.0.181-1.fc26.noarch.rpm
> > 
> > Not sure what do do about this. Make javadoc-zip archful?
> 
> Note that aot is x86_64 Linux only. So that might be the reason why this
> happens.

Yes, that would be the reason. So There are only two options - to disable aot,
or make javadocs arch dependent:(

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476440] Review Request: gimp-luminosity-masks - Luminosity mask channels plug-in for Gimp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476440



--- Comment #9 from Fedora Update System  ---
gimp-luminosity-masks-0-3.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-5072da698d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476440] Review Request: gimp-luminosity-masks - Luminosity mask channels plug-in for Gimp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476440

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480957] Review Request: golang-github-axgle-mahonia - Character-set conversion library implemented in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480957



--- Comment #3 from sensor@gmail.com ---
I opened a new ticket in the upstream for license.

https://github.com/axgle/mahonia/issues/4

Release and license tag is fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480958] Review Request: golang-github-BurntSushi-freetype-go - A fork of freetype-go with bounding box calculations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480958



--- Comment #2 from sensor@gmail.com ---
SPEC:
https://raw.githubusercontent.com/FZUG/repo/b37e00151f173afd6f092c29868e2b59a956f609/rpms/deepin_project/golang-github-BurntSushi-freetype-go.spec

Thanks  I fixed it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1340327] Review Request: M3D-Linux - Linux program that can communicate with the Micro M3D printer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340327

Dennis Gilmore  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 CC||dgilm...@redhat.com
 Resolution|--- |WONTFIX
Last Closed||2017-08-14 12:02:08



--- Comment #6 from Dennis Gilmore  ---
closing this as my printer died. and the software was renamed at the request of
the hardware vendor

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474958] Review Request: lammps - Large-scale Atomic/ Molecular Massively Parallel Simulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474958



--- Comment #4 from Antonio Trande  ---
> Honestly lammps.py works with both, so should I just install 2 same files 
> twice?

I guess you can install it in 'python3-sitearch' on Fedora (you need
python3-devel) but 'python2-sitearch' on epel6 and 'python34-sitearch' on
epel7.

Like 'python-vxi11':
https://src.fedoraproject.org/rpms/python-vxi11/blob/master/f/python-vxi11.spec

Use Python macros, please:
http://fedoraproject.org/wiki/Packaging:Python#Macros

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474958] Review Request: lammps - Large-scale Atomic/ Molecular Massively Parallel Simulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474958



--- Comment #3 from Christoph Junghans  ---
Thanks for the review!

(In reply to Antonio Trande from comment #2)
> Initial comments:
> 
> %if 0%{?fedora} > 12 || 0%{?rhel} > 6
> %global with_python3 1
> %else
> %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from
> distutils.sysconfig import get_python_lib; print get_python_lib(1)")}
> %endif
> 
> '%global with_python3 1' is used for ??
> On Fedora, do you want provide python2 or python3 or both wrappers?
Honestly lammps.py works with both, so should I just install 2 same files
twice?
> 
> - For epel6 use macros reported in
> https://fedoraproject.org/wiki/EPEL:Packaging#Python.
> 
> - Install '*.py*' files separately in 'python?-lammps' packages.
ok

> 
> - Install MPI libraries and header files separately in their own packages:
> 
> lammps
> lammps-devel (unversiond libs + header files)
> lammps-openmpi
> lammps-openmpi-devel (OpenMPI unversiond libs + header files)
> lammps-mpich
> lammps-mpich-devel (MPICH unversiond libs + header files)
There are no MPI-specific headers, so lammps-*mpi*-devel would only contain the
libs and would be useless without the devel package, so I put them into one.

It seems https://fedoraproject.org/wiki/Packaging:MPI suggested to use a
lammps-headers package for that case.

> 
> - For epel* use 'BuildRequires: cmake3'
I haven't really starting working on epel7 support yet, but I wlll push that
in.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480960] Review Request: golang-github-BurntSushi-xgb - XGB is the X protocol Go language Binding

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480960



--- Comment #3 from sensor@gmail.com ---
Diff:
https://github.com/FZUG/repo/commit/244de033cf54514c0c240dba1f3caa64d4825221

Thanks, I fixed license and release tag.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440971] Review Request: python-pyclipper - Cython wrapper for the C++ translation of the Angus Johnson 's Clipper library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440971



--- Comment #5 from Athos Ribeiro  ---
Not really, the library API seems to change with each new version...

I opened an issue upstream [1]. If they are not willing to update nor to accept
a patch for that, I could either patch the package here or bundle polyclipper
6.2.1, as upstream does.

[1] https://github.com/greginvm/pyclipper/issues/10

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474958] Review Request: lammps - Large-scale Atomic/ Molecular Massively Parallel Simulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474958



--- Comment #2 from Antonio Trande  ---
Initial comments:

%if 0%{?fedora} > 12 || 0%{?rhel} > 6
%global with_python3 1
%else
%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print get_python_lib(1)")}
%endif

'%global with_python3 1' is used for ??
On Fedora, do you want provide python2 or python3 or both wrappers?

- For epel6 use macros reported in
https://fedoraproject.org/wiki/EPEL:Packaging#Python.

- Install '*.py*' files separately in 'python?-lammps' packages.

- Install MPI libraries and header files separately in their own packages:

lammps
lammps-devel (unversiond libs + header files)
lammps-openmpi
lammps-openmpi-devel (OpenMPI unversiond libs + header files)
lammps-mpich
lammps-mpich-devel (MPICH unversiond libs + header files)

- For epel* use 'BuildRequires: cmake3'

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440992] Review Request: python-booleanoperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992

Athos Ribeiro  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |python-booleanOperations -  |python-booleanoperations -
   |Boolean operations on paths |Boolean operations on paths



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440992] Review Request: python-booleanOperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992



--- Comment #3 from Athos Ribeiro  ---
Changed the package name and updated version

Spec URL:
https://athoscr.fedorapeople.org/packaging/python-booleanoperations.spec
SRPM URL:
https://athoscr.fedorapeople.org/packaging/python-booleanoperations-0.7.1-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474425] Review Request: perl-Alien-Build - Build external dependencies for use in CPAN

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474425

Jitka Plesnikova  changed:

   What|Removed |Added

 CC||jples...@redhat.com



--- Comment #1 from Jitka Plesnikova  ---
Please update to the latest version 0.95. 
Alien::Base was merged into this package in 0.67_01.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1473712] Review Request: perl-Alien-Base - Base classes for Alien:: Perl modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1473712



--- Comment #1 from Jitka Plesnikova  ---
Alien-Base and Alien-Build were merge into Alien-Build.

More information:
https://metacpan.org/source/PLICEASE/Alien-Build-0.95/Changes#L134

0.67_01   2017-07-18 13:52:56 -0400
  - Merged Alien-Base and Alien-Build.  For the old Test-Alien change log
see Changes.Alien-Base

Please closed this review and update package review BZ#1474425

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1473712] Review Request: perl-Alien-Base - Base classes for Alien:: Perl modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1473712

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431868] Review Request: syncthing-inotify - Syncthing File watcher

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431868
Bug 1431868 depends on bug 1427634, which changed state.

Bug 1427634 Summary: Review Request: syncthing - Continuous File Synchronization
https://bugzilla.redhat.com/show_bug.cgi?id=1427634

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427634] Review Request: syncthing - Continuous File Synchronization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427634

Fabio Valentini  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-08-14 09:57:28



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1344276] Review Request: gdeploy - Tool to deploy GlusterFS clusters and other utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344276



--- Comment #35 from Paulo Andrade  
---
  The easiest approach would be to make a new release, and
change the files to use GPLv3+. But you would need to ask
all contributors to agree to it. Likely just one line
replacement of /2/3/ for the files under GPLv2+.

  Files without a license header use the LICENSE file. But
IANAL, and this could be contested. But I do not suggest
patching the files to add a license header, as most if not
all are kind of trivial or non distributed files.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441023] Review Request: python-fontmake - Compile fonts from sources to binary

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441023



--- Comment #2 from Shawn Starr  ---
I will review your packaging

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474033] Review Request: ucx - Communication library implementing high-performance messaging

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474033



--- Comment #11 from Andrey Maslennikov  ---
Spec URL:
https://gist.github.com/amaslenn/3c847e0bdc063bcbb4b6507b5efbf6b9/raw/09b525799964828c26eb6604a0404511ae231167/ucx.spec
SRPM URL:
https://gist.github.com/amaslenn/3c847e0bdc063bcbb4b6507b5efbf6b9/raw/09b525799964828c26eb6604a0404511ae231167/ucx-1.2.0-1.fc25.src.rpm

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21224428


> > Static libs moved to separate -static package. -devel depends on it.
> 
> That is not what the guidelines suggest. Just think about it a bit. Such a 
> dependency defeats the purpose of moving the static libs into a _separate_ 
> package.
Just want to make it easier for users to get all packages required for
development.
Will removing Required from -devel be enough to comply this policy?


> > Added --disable-rpath to %configure anyway.
> 
> That's a no-op, if the configure script doesn't support that option [yet]:
> 
> | configure: WARNING: unrecognized options: --disable-rpath
Missed that. Thanks, removed. Don't see this issue anyway.


> > %files
> > ...
> > %{_datadir}/ucx
> > %exclude %{_datadir}/ucx/examples
> > %{_datadir}/ucx/perftest
> 
> The first line in the quote above includes the complete %_datadir/ucx/ tree 
> already minus the excluded directory. Hence the last line is superfluous.
Fixed, thanks.


> > Just want to have issues in spec fixed before creating actual release.
> > Can we ignore this one for a while?
> 
> You only need to keep in mind that replacing the source tarball with another 
> release could be a rather disruptive step during review.
Don't like it either. Hope to fix it soon.


> Btw, the build.log contains several warnings about libraries and tools 
> (doxygen!) it cannot find.
All of them (including doxygen) are "nice to have", not "required". The build
is possible, it only reduces some functionality (which is OK). I added one
(libibverbs-devel) to BuildRequires, this one is important.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481237] Review Request: cmu-ipc: message passing between local processes or over TCP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481237

Ye Cheng <18969068...@163.com> changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481237] Review Request: cmu-ipc: message passing between local processes or over TCP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481237

Ye Cheng <18969068...@163.com> changed:

   What|Removed |Added

 Blocks||1225692




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1225692
[Bug 1225692] Tracker for Fedora Robotics SIG
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479707] Review Request: perl-Test-Exit - Test that some code calls exit without terminating testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479707

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Test-Exit-0.11-1.fc27
 Resolution|--- |RAWHIDE
Last Closed||2017-08-14 08:54:35



--- Comment #4 from Petr Pisar  ---
Thank you for the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1473705] Review Request: perl-Alien-Base-ModuleBuild - Perl framework for building Alien:: modules and their libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1473705

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Alien-Base-ModuleBuild
   ||-0.042-1.fc27
 Resolution|--- |RAWHIDE
Last Closed||2017-08-14 08:48:15



--- Comment #7 from Petr Pisar  ---
Thank you for the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1473712] Review Request: perl-Alien-Base - Base classes for Alien:: Perl modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1473712
Bug 1473712 depends on bug 1473705, which changed state.

Bug 1473705 Summary: Review Request: perl-Alien-Base-ModuleBuild - Perl 
framework for building Alien:: modules and their libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1473705

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1471806] Review Request: danmaq - A small client side Qt program to play danmaku on any screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1471806



--- Comment #24 from Fedora Update System  ---
danmaq-0.2-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-29f2713379

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481237] New: Review Request: cmu-ipc: message passing between local processes or over TCP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481237

Bug ID: 1481237
   Summary: Review Request: cmu-ipc: message passing between local
processes or over TCP
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: 18969068...@163.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://copr-be.cloud.fedoraproject.org/results/yecheng/cmu-ipc/fedora-rawhide-x86_64/00590284-cmu-ipc/cmu-ipc.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/yecheng/cmu-ipc/fedora-rawhide-x86_64/00590284-cmu-ipc/cmu-ipc-3.9.1a-1.fc27.x86_64.rpm
Description: IPC provides high-level support for connecting processes using
TCP/IP sockets and sending data between processes. It takes care of opening
sockets, registering messages, and sending and receiving messages, including
both anonymous publish/subscribe and client/server type messages.
Fedora Account System Username:yecheng

The ppc64le version isn't really ready, It was not officially ported and there
may be something other than alignment that is architecture specific but I don't
have a machine to test. Testing and feedbacks are always welcomed!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469726] Review Request: zram - Enable compressed swap in memory

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469726



--- Comment #10 from Zbigniew Jędrzejewski-Szmek  ---
Hmm, it seems that the anaconda service is smarter than the one being packaged
here. Instead of making one swap device per cpu, it just does "echo $num_cpus >
/sys/block/zram0/max_comp_streams". If this is updated, not much is left of the
original, I don't know what you want to do with that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469726] Review Request: zram - Enable compressed swap in memory

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469726



--- Comment #9 from Zbigniew Jędrzejewski-Szmek  ---
Oh, /usr/lib/systemd/system/zram.service is part of anaconda. It seems to be
tailored for anaconda (see the part at the end about configuring /tmp).
It also has no support for enabling (hence the reddit thread).
So it seems that this package is still useful, and in the long run anaconda
should switch to depending on it.


>>> After=multi-user.target
> Drop it?

Yes. I think the following should work:
[Unit]
DefaultDependencies=no
Before=swap.target
Conflicts=umount.target

[Install]
WantedBy=swap.target

>>> sleep 1
>> Hmm. swapoff is synchronous so this is either masking a bug in the kernel or
>> just plain unnecessary.
> Drop it?
Yeah. If anything breaks, there's a bug somewhere.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479730] Review Request: python-cloudpickle - Extended pickling support for Python objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479730



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-cloudpickle

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479730] Review Request: python-cloudpickle - Extended pickling support for Python objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479730



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-cloudpickle

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=960201



--- Comment #27 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/libyui-qt-graph

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=960201



--- Comment #26 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/libyui-qt-graph

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1439893] Review Request: luadec - Lua Decompiler for lua 5.1, 5.2, and 5.3 (built for 5.1)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1439893



--- Comment #4 from Ye Cheng <18969068...@163.com> ---
(In reply to Ye Cheng from comment #1)
>   - Useful -debuginfo package or justification otherwise.
> debuginfo-without-sources, I don't know why this happened, probably due to
> some problems in building procedure.
I'm really sorry for this false positive, debuginfo without source could
probably be acceptable, as debugsource package is now separated. 
Reference: https://fedoraproject.org/wiki/Changes/SubpackageAndSourceDebuginfo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434749] Review Request: si-units - International System of Units ( JSR 363)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434749



--- Comment #8 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/si-units

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434749] Review Request: si-units - International System of Units ( JSR 363)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434749



--- Comment #7 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/si-units

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1463253] rubygem-lru_redux: An efficient implementation of an lru cache

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1463253

Matthias Runge  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Matthias Runge  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package contains Requires: ruby(release).


= MUST items =

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
 Note: Using prebuilt packages

koji scratchbuild: https://koji.fedoraproject.org/koji/taskinfo?taskID=21223848

[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: There is no build directory. Running licensecheck on vanilla
 upstream sources. No licenses found. Please check the source files for
 licenses manually.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
 Note: Using prebuilt rpms.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines

Note: for the fedora package, please remove the provides: line. I would
recommend to add a %if 0%{?fedora} .. %endif around that provides line.

[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ruby:
[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
 independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).

= SHOULD items =

Generic:
[x]: Reviewer should test that the package builds in mock.
https://koji.fedoraproject.org/koji/taskinfo?taskID=21223848

[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.

[Bug 1479022] Review Request: preeny - Some helpful preload libraries for pwning stuff

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479022

Jaroslav Škarvada  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-08-14 06:35:19



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1463253] rubygem-lru_redux: An efficient implementation of an lru cache

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1463253



--- Comment #3 from Juan Badia Payno  ---
Tests added on the spec file.
The with_test argument is still present but set to 1, to enable the
requirements and execute the tests.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379651

Matthias Runge  changed:

   What|Removed |Added

 Blocks||1480922




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1480922
[Bug 1480922] python-pelican is shipped with an old version of
feedgenerator.py which leads to unexpected behaviour
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477363



--- Comment #8 from Richard W.M. Jones  ---
> %define libname ...

I believe that all %define should be %global because of a weirdness
of RPM
(https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#.25global_preferred_over_.25define)

> # make build-native-dynlink; "make install" does it by default, not sure if
> # should be done here.

I'm guessing it should be done there.  Also note the
%{ocaml_natdynlink} macro which expands to the list of
architectures that support natdynlink (≠ list of architectures
supporting native compilation).

In addition, fedora-review complains about:

> [ ]: License field in the package spec file matches the actual license.
>  Note: Checking patched sources after %prep for licenses. Licenses
>  found: "ISC", "Unknown or generated", "*No copyright* Public domain".
>  34 files have unknown license. Detailed output of licensecheck in
>  [...]

As long as MIT is compatible with the license, then that's fine.

> [!]: Uses parallel make %{?_smp_mflags} macro.

Not all packages are compatible with parallel builds, but you should
check to see if it can be used and add a comment to the spec file if
there is a problem.

> [ ]: Spec use %global instead of %define unless justified.
>  Note: %define requiring justification: %define libname %(echo %{name}
>  | sed -e 's/^ocaml-//')

See above.

There are also some rpmlint errors, but they all seem to be irrelevant.

Generated dependencies look fine to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477363



--- Comment #7 from Richard W.M. Jones  ---
(In reply to Ben Rosser from comment #6)
> So it looks like setting true : debug (the equivalent of -tag debug, it
> seems) in the _tags file does indeed generate debuginfo in the *.o files.
> However the debuginfo package still doesn't get made.
> 
> Looking at _build/_log, it seems -g is passed to every step except the last
> ocamlopt invocation, for whatever reason:
> 
> https://paste.fedoraproject.org/paste/-Ww26xBbvH3meABH7ptf0A

The final link doesn't include -g so that's one problem:

ocamlfind ocamlopt -a -package bytes src/cmdliner_suggest.cmx
src/cmdliner_trie.cmx src/cmdliner_base.cmx src/cmdliner_manpage.cmx
src/cmdliner_info.cmx src/cmdliner_docgen.cmx src/cmdliner_msg.cmx
src/cmdliner_cline.cmx src/cmdliner_term.cmx src/cmdliner_arg.cmx
src/cmdliner.cmx -o src/cmdliner.cmxa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424963] Review Request: gnome-shell-extension-ibus-font - use to change ibus font style.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424963



--- Comment #8 from Peng Wu  ---
I want to own this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404043

Hanns-Joachim Uhl  changed:

   What|Removed |Added

 CC||bugpr...@us.ibm.com,
   ||d...@danny.cz
External Bug ID||IBM Linux Technology Center
   ||157646



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404043



--- Comment #41 from Honggang LI  ---
(In reply to Vít Ondruch from comment #40)
> Shouldn't the independent libibverbs [1] and librdmacm [2] packages be
> retired now?
> 
> 
> [1] https://src.fedoraproject.org/rpms/libibverbs
> [2] https://src.fedoraproject.org/rpms/librdmacm


It is more complex than that.

1) Individual packages do not exist any more. They are RDMA hardware usr-space
drivers which has been folded into new "libibverbs" packages. These packages
should be retired.

rpms/libusnic_verbs -- No-op libibverbs driver for the Cisco usNIC device (
master f26 f25 f24 )
rpms/libcxgb3 -- Chelsio T3 iWARP HCA Userspace Driver ( master f26 f25 f24
)
rpms/libcxgb4 -- Chelsio T4 iWARP HCA Userspace Driver ( master f26 f25 f24
)
rpms/libmlx5 -- Mellanox Connect-IB and ConnectX-4 InfiniBand HCAs User
Space Driver ( master f26 f25 )
rpms/libocrdma -- User-space Library for Emulex ROCE Device ( master f26
f25 f24 )
rpms/libipathverbs -- QLogic InfiniPath HCA Userspace Driver ( master f26
f25 f24 )
rpms/libmlx4 -- Mellanox ConnectX InfiniBand HCA Userspace Driver ( master
f26 f25 f24 )
rpms/libmthca -- Mellanox InfiniBand HCA Userspace Driver ( master f26 f25
f24 )
rpms/libnes -- NetEffect RNIC Userspace Driver ( master f26 f25 f24 )


2) Packages still exist with the *old* names.

rpms/libibcm -- Userspace InfiniBand Connection Manager ( master f26 f25
f24 )
rpms/libibumad -- OpenFabrics Alliance InfiniBand umad (user MAD) library (
master f26 f25 f24 )
rpms/libibverbs -- A library for direct userspace use of RDMA
(InfiniBand/iWARP) hardware ( master f26 f25 f24 )
rpms/librdmacm -- Userspace RDMA Connection Manager ( master f26 f25 f24 )
rpms/ibacm -- InfiniBand Communication Manager Assistant ( master f26 f25
f24 )


3) Packages had been renamed.
rpms/libiwpm -- iWarp Port Mapper userspace daemon ( master f26 f25 f24 )
rpms/rdma -- RDMA Kernel Stack Initializer ( master f26 f25 f24 )
rpms/srptools -- Tools for using the InfiniBand SRP protocol devices (
master f26 f25 f24 )

libiwpm --> iwpmd
rdma ---> rdma-core
srptools --> srp_daemon

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404043

Vít Ondruch  changed:

   What|Removed |Added

 CC||vondr...@redhat.com



--- Comment #40 from Vít Ondruch  ---
Shouldn't the independent libibverbs [1] and librdmacm [2] packages be retired
now?


[1] https://src.fedoraproject.org/rpms/libibverbs
[2] https://src.fedoraproject.org/rpms/librdmacm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=960201

Wolfgang Ulbrich  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #25 from Wolfgang Ulbrich  ---
APPROVED!

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[ ]: Provides: bundled(gnulib) in place as required.
 Note: Sources not installed
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[ ]: License field in the package spec file matches the actual license.
 Note: There is no build directory. Running licensecheck on vanilla
 upstream sources. No licenses found. Please check the source files for
 licenses manually.
[ ]: License file installed when any subpackage combination is installed.
[ ]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
 names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 1 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[ ]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libyui-
 qt-graph-doc , libyui-qt-graph-debuginfo
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from 

[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404043

Honggang LI  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-08-14 03:45:26



--- Comment #39 from Honggang LI  ---
Confirmed all sub-packages of rdma-core packages are available in rawhide repo.
Closing this bug as 'RAWHIDE'.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469726] Review Request: zram - Enable compressed swap in memory

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469726



--- Comment #8 from Raphael Groner  ---
(In reply to František Zatloukal from comment #4)
> Packaging looks good to me.
> 
> I see upstream recommends disabling swap after installation but I don't see
> the package doing it. Is it an issue if swap remains enabled? It would make
> sense to at least print warning to the terminal during installation (I'd be
> against disabling swap in a completely automatic manner).

OK

> The other potential issue - I see documented incompatibility with encrypted
> /home . Does it break anything after installing this package to such system?

Please provide any link for more information and reproducibility.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469726] Review Request: zram - Enable compressed swap in memory

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469726



--- Comment #7 from Raphael Groner  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #6)
> > # need Linux kernel version 2.6.37.1 or better to use zram
> > Requires: kernel >= 2.6.37.1
> 
> First, nowadays kernel has been split into kernel-core and other
> subpackages, so you can easily boot a machine without kernel.rpm (which also
> pulls in kernel-modules). Second, the fact that you have a specific
> kernel.rpm installed does not mean that you're running with that version so
> this is not effective. And third, there's no way to install a kernel rpm for
> 2.6.x in any Fedora. So you should just drop this line.

OK. Good point about several kernels available to boot on a system.

> > BuildRequires: systemd-units
> 
> > Requires(post): systemd-sysv
> > Requires(post): systemd-units
> > Requires(preun): systemd-units
> > Requires(postun): systemd-units
> > Requires: systemd
> > Requires: initscripts
> 
> This should be replaced by
> %{?systemd_requires}
> BuildRequires: systemd
> [https://fedoraproject.org/wiki/Packaging:Scriptlets#Systemd]

OK

> > %systemd_postun_with_restart mkzram.service
> Hmm, that could be dangerous. Disabling swap during an upgrade could bring
> the machine down. %systemd_postun seems more reasonable.

OK

> > After=multi-user.target
> That's certainly the wrong place to order this. Not only it causes a
> dependency loop with swap.target which is ordered much earlier, it might
> also disable swap at the beginning of shutdown, crashing the machine.

Drop it?

> > sleep 1
> Hmm. swapoff is synchronous so this is either masking a bug in the kernel or
> just plain unnecessary.

Drop it?

> I'm not particularly impressed by how this is all put together. The problem
> starts with the stupid kernel interface which requires ~50 lines of shell to
> bring up swap. That's just bizarre. But anyway, zram is useful, so we should
> make it easy to use, so I think it's worth to package this, so it'd be great
> to finally get this package into Fedora.

How can they talk on reddit about available systemd integration without an
official package? Is this review still needed?
https://www.reddit.com/r/Fedora/comments/4y6n5t/how_to_enable_zram_on_fedora_24/

What about storaged-zram? Is it stilled developed? I see it's part of general
storaged, merged into systemd or somehow actual plans to merge.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468949] Review Request: python3-greenlet - Lightweight in-process concurrent programming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468949

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-08-14 02:53:23



--- Comment #13 from Fedora Update System  ---
python-neovim-0.1.13-3.el7, python3-greenlet-0.4.12-1.el7 has been pushed to
the Fedora EPEL 7 stable repository. If problems still persist, please make
note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480130] Review Request: perl-Math-Utils - Useful mathematical functions not in Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480130

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Math-Utils-1.10-1.fc27
 Resolution|--- |RAWHIDE
Last Closed||2017-08-14 02:45:12



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468995] Review Request: python-geopandas - Geographic pandas extensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468995

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Depends On||1481100




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1481100
[Bug 1481100] python-Rtree is outdated and lacks Python 3 support
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org