[Bug 1344276] Review Request: gdeploy - Tool to deploy GlusterFS clusters and other utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1344276 --- Comment #42 from Sachidananda Urs --- (In reply to Paulo Andrade from comment #40) > Welcome as a Fedora Packager! > > I suggest following the procedures starting at > https://fedoraproject.org/wiki/ > Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management > _.28SCM.29_system_and_Set_Owner > to add the package. > > I also suggest using your gmail account for Fedora bugzilla > issues, as it is the email associated with your FAS account. Sure. > > If you have any issues feel free to ping me in irc, nickname > pcpa, or send me an email. Thank you. I've raised a request to add the package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1440971] Review Request: python-pyclipper - Cython wrapper for the C++ translation of the Angus Johnson 's Clipper library
https://bugzilla.redhat.com/show_bug.cgi?id=1440971 --- Comment #6 from Elliott Sales de Andrade --- It might be faster to open a PR there if the change is straightforward. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481416] Review Request: light - control backlight controllers
https://bugzilla.redhat.com/show_bug.cgi?id=1481416 --- Comment #2 from Jakub Kadlčík --- Thank you Robert, for the review. I've addressed your comments. Spec URL: https://copr-be.cloud.fedoraproject.org/results/frostyx/light/fedora-rawhide-x86_64/00591454-light/light.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/frostyx/light/fedora-rawhide-x86_64/00591454-light/light-1.0-1.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1336164] Review Request: golang-github-bgentry-go-netrc - netrc file parser for Go programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1336164 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com --- Comment #2 from Elliott Sales de Andrade --- Here is an updated spec/srpm: Spec URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-rawhide-x86_64/00591456-golang-github-bgentry-go-netrc/golang-github-bgentry-go-netrc.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-rawhide-x86_64/00591456-golang-github-bgentry-go-netrc/golang-github-bgentry-go-netrc-0-0.2.git9fd32a8.fc27.src.rpm Description: A Golang package for reading and writing netrc files. This package can parse netrc files, make changes to them, and then serialize them back to netrc format, while preserving any whitespace that was present in the source file. Fedora Account System Username: qulogic -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1336161] Review Request: golang-github-ThomsonReutersEikon-go-ntlm - Native implementation of NTLM for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1336161 --- Comment #5 from Elliott Sales de Andrade --- Apologies, I didn't notice that tito bumped the version instead of the release; here is a corrected spec: Spec URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-26-x86_64/00591448-golang-github-ThomsonReutersEikon-go-ntlm/golang-github-ThomsonReutersEikon-go-ntlm.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-26-x86_64/00591448-golang-github-ThomsonReutersEikon-go-ntlm/golang-github-ThomsonReutersEikon-go-ntlm-0-0.2.gitb00ec39.fc26.src.rpm Description: Native implementation of NTLM for Go. Fedora Account System Username: qulogic -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480825] Review Request: python-pytest-forked - py.test plugin for running tests in isolated forked subprocesses
https://bugzilla.redhat.com/show_bug.cgi?id=1480825 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- All good, package accepted. Thank you for your work. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1336161] Review Request: golang-github-ThomsonReutersEikon-go-ntlm - Native implementation of NTLM for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1336161 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com --- Comment #4 from Elliott Sales de Andrade --- Here is an updated SPEC/SRPM for you: Spec URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-26-x86_64/00591446-golang-github-ThomsonReutersEikon-go-ntlm/golang-github-ThomsonReutersEikon-go-ntlm.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/git-lfs/fedora-26-x86_64/00591446-golang-github-ThomsonReutersEikon-go-ntlm/golang-github-ThomsonReutersEikon-go-ntlm-1-0.2.gitb00ec39.fc26.src.rpm Description: Native implementation of NTLM for Go. Fedora Account System Username: qulogic -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1404895] Review Request: partclone - File System Clone Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1404895 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #19 from Robert-André Mauchin --- It's good now, package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1479967] Review Request: fritzing-parts - Parts library for the Fritzing electronic design application
https://bugzilla.redhat.com/show_bug.cgi?id=1479967 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #7 from Robert-André Mauchin --- Everything's okay. Package accepted. Thanks for your work. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1476201 --- Comment #4 from Robert-André Mauchin --- Updated with your recommendation. SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/qdirstat/fedora-rawhide-x86_64/00591438-qdirstat/qdirstat.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/qdirstat/fedora-rawhide-x86_64/00591438-qdirstat/qdirstat-1.4-3.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475863] Review Request: golang-github-xanzy-ssh-agent - Create a ssh-agent on any type of OS from any Go application
https://bugzilla.redhat.com/show_bug.cgi?id=1475863 --- Comment #3 from Robert-André Mauchin --- Added commitdate SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591435-golang-github-xanzy-ssh-agent/golang-github-xanzy-ssh-agent.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591435-golang-github-xanzy-ssh-agent/golang-github-xanzy-ssh-agent-0-0.1.20151215.gitba9c9e3.fc27.src.rpm FAS username: eclipseo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475846] Review Request: golang-github-nsf-termbox-go - A minimalistic API which allows programmers to write text-based user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1475846 --- Comment #3 from Robert-André Mauchin --- Added commitdate SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591431-golang-github-nsf-termbox-go/golang-github-nsf-termbox-go.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591431-golang-github-nsf-termbox-go/golang-github-nsf-termbox-go-0-0.1.20170710.git4ed959e.fc27.src.rpm FAS username: eclipseo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475841] Review Request: golang-github-ncw-go-acd - Go library for accessing the Amazon Cloud Drive
https://bugzilla.redhat.com/show_bug.cgi?id=1475841 --- Comment #3 from Robert-André Mauchin --- Added commitdate SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591323-golang-github-ncw-go-acd/golang-github-ncw-go-acd.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591323-golang-github-ncw-go-acd/golang-github-ncw-go-acd-0-0.1.20170306.git96a49aa.fc27.src.rpm FAS username: eclipseo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482205] Review Request: syncthing-gtk - Syncthing GTK+ GUI
https://bugzilla.redhat.com/show_bug.cgi?id=1482205 Neal Gompa changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #2 from Neal Gompa --- Review notes: * Package is named appropriately, per packaging guidelines * Package follows Fedora packaging guidelines * Package follows Fedora Python packaging guidelines * Package has no rpmlint issues * Package builds and installs correctly * No issues from fedora-review Looks good to me. PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #26 from Yunying Sun --- f27 has tpm2-tss 1.1.0, which does not provide resource manager daemon anymore. tpm2-abrmd is the replacing daemon, which is required when using many tpm2 userspace tools like those tpm2_*** provided by tpm2-tools. Therefore tpm2-abrmd is needed for f27 as well. I did a tpm2-abrmd-1.1.0-5 koji build for f27: https://koji.fedoraproject.org/koji/taskinfo?taskID=21293091 But "fedpkg update" failed for f27 with error: [test@SKLS02 tpm2-abrmd]$ git branch * f27 master [test@SKLS02 tpm2-abrmd]$ fedpkg update Invalid tag: tpm2-abrmd-1.1.0-5.fc27 not tagged with any of the following tags [u'f22-updates-candidate', u'dist-6E-epel-testing-candidate', u'f21-updates-candidate', u'f24-updates-candidate', u'epel7-testing-candidate', u'f25-updates-candidate', u'dist-5E-epel-testing-candidate', u'f23-updates-candidate', u'f26-updates-candidate'] Unable to determine release from build: tpm2-abrmd-1.1.0-5.fc27 Seems f27 is at early branched state before Bodhi activation point: https://fedoraproject.org/wiki/Releases/27/Schedule According to https://fedoraproject.org/wiki/Package_update_HOWTO#Rawhide and early Branched , suppose no "fedpkg update" needed and tpm2-abrmd-1.1.0-5 will be included into f27 automatically. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475228] Review Request: tpm2-abrmd - TPM2 access broker and resource manager daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1475228 --- Comment #25 from Yunying Sun --- Koji rawhide build completed for tpm2-abrmd-1.1.0-5: https://koji.fedoraproject.org/koji/taskinfo?taskID=21292902 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1478231] Review Request: conda - Cross-platform, Python-agnostic binary package manager
https://bugzilla.redhat.com/show_bug.cgi?id=1478231 Robin Lee changed: What|Removed |Added Status|NEW |ASSIGNED CC||robinlee.s...@gmail.com Assignee|nob...@fedoraproject.org|robinlee.s...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1462472] Review Request: qotd - A simple and lightweight Quote of the Day daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1462472 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2017-07-20 11:52:49 |2017-08-17 21:20:50 --- Comment #14 from Fedora Update System --- qotd-0.11.3-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481876] Review Request: python-pytest-shutil - A goodie-bag of unix shell and environment tools for py.test
https://bugzilla.redhat.com/show_bug.cgi?id=1481876 --- Comment #2 from Kevin Fenzi --- Odd. It built fine a few days ago... https://koji.fedoraproject.org/koji/taskinfo?taskID=21247929 will take a look. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480825] Review Request: python-pytest-forked - py.test plugin for running tests in isolated forked subprocesses
https://bugzilla.redhat.com/show_bug.cgi?id=1480825 --- Comment #2 from Scott Talbert --- Thanks for the review! Updated to address your comment. Spec URL: https://www.techie.net/~talbert/python-pytest-forked.spec SRPM URL: https://www.techie.net/~talbert/python-pytest-forked-0.2-2.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481875] Review Request: python-pytest-virtualenv - Virtualenv fixture for py.test
https://bugzilla.redhat.com/show_bug.cgi?id=1481875 Scott Talbert changed: What|Removed |Added Assignee|s...@techie.net |nob...@fedoraproject.org Flags|fedora-review? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481876] Review Request: python-pytest-shutil - A goodie-bag of unix shell and environment tools for py.test
https://bugzilla.redhat.com/show_bug.cgi?id=1481876
--- Comment #1 from Scott Talbert ---
Doesn't build on rawhide:
running install_scripts
Traceback (most recent call last):
File "setup.py", line 48, in
setup(**kwargs)
File "/usr/lib64/python2.7/distutils/core.py", line 151, in setup
dist.run_commands()
File "/usr/lib64/python2.7/distutils/dist.py", line 953, in run_commands
self.run_command(cmd)
File "/usr/lib64/python2.7/distutils/dist.py", line 972, in run_command
cmd_obj.run()
File "/usr/lib/python2.7/site-packages/setuptools/command/install.py", line
61, in run
return orig.install.run(self)
File "/usr/lib64/python2.7/distutils/command/install.py", line 575, in run
self.run_command(cmd_name)
File "/usr/lib64/python2.7/distutils/cmd.py", line 326, in run_command
self.distribution.run_command(command)
File "/usr/lib64/python2.7/distutils/dist.py", line 972, in run_command
cmd_obj.run()
File
"/usr/lib/python2.7/site-packages/setuptools/command/install_scripts.py", line
33, in run
bs_cmd = (self.get_finalized_command('build_scripts', create=False) or
File "/usr/lib64/python2.7/distutils/cmd.py", line 312, in
get_finalized_command
cmd_obj.ensure_finalized()
AttributeError: 'NoneType' object has no attribute 'ensure_finalized'
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.LN9Lc5 (%install)
Bad exit status from /var/tmp/rpm-tmp.LN9Lc5 (%install)
Child return code was: 1
EXCEPTION: [Error()]
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480739] Review Request: golang-github-montanaflynn-stats - Common statistics functions missing in Golang standard library
https://bugzilla.redhat.com/show_bug.cgi?id=1480739 Athos Ribeiro changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-08-17 18:47:25 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480762] Review Request: golang-github-jdkato-prose - Golang library for text processing
https://bugzilla.redhat.com/show_bug.cgi?id=1480762 Bug 1480762 depends on bug 1480739, which changed state. Bug 1480739 Summary: Review Request: golang-github-montanaflynn-stats - Common statistics functions missing in Golang standard library https://bugzilla.redhat.com/show_bug.cgi?id=1480739 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482577] Review Request: python3-cryptography - PyCA' s cryptography library
https://bugzilla.redhat.com/show_bug.cgi?id=1482577 --- Comment #2 from Aurelien Bompard --- Yeah I agree it should be the same version as in RHEL, but that's what I tried to do: # repoquery --location python2-cryptography http://infrastructure.fedoraproject.org/repo/rhel/rhel7/x86_64/rhel-7-server-rpms/Packages/python2-cryptography-1.7.2-1.el7.x86_64.rpm Nathaniel, what version do you have in RHEL? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1426972] Review Request: hugo - A Fast and Flexible Static Site Generator built with love in GoLang
https://bugzilla.redhat.com/show_bug.cgi?id=1426972 Bug 1426972 depends on bug 1480781, which changed state. Bug 1480781 Summary: Review Request: golang-github-markbates-inflect - Go library to perform word transformations https://bugzilla.redhat.com/show_bug.cgi?id=1480781 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480781] Review Request: golang-github-markbates-inflect - Go library to perform word transformations
https://bugzilla.redhat.com/show_bug.cgi?id=1480781 Athos Ribeiro changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-08-17 18:22:00 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1479027 --- Comment #18 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-golang-image -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1479027 --- Comment #17 from Athos Ribeiro --- Thank you for the review, Fabio! I will request the repository and wait for the confirmation on the licensing issie before importing the package. I will wait until then to document so in this bug and only then, close it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475763] Review Request: golang-github-Unknwon-goconfig - Configuration file parser for the Go Programming Language
https://bugzilla.redhat.com/show_bug.cgi?id=1475763 --- Comment #8 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-Unknwon-goconfig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1404895] Review Request: partclone - File System Clone Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1404895 --- Comment #18 from Robert Scheck --- (In reply to Robert-André Mauchin from comment #17) > One last minor thing : If the package is under multiple licenses, the > licensing breakdown must be documented in the spec. > > Since the breakdown is fairly complex, summarizes it to the best of your > abilities. I did it per internal "component", otherwise this will end up in a license per file list as it seems. Hope this is good enough: Spec URL: https://labs.linuxnetz.de/bugzilla/partclone.spec SRPM URL: https://labs.linuxnetz.de/bugzilla/partclone-0.3.5a-3.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482055] Review Request: shairport-sync - AirTunes emulator. Shairport Sync adds multi-room capability with Audio Synchronisation.
https://bugzilla.redhat.com/show_bug.cgi?id=1482055 --- Comment #18 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/shairport-sync -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1479027 Fabio Valentini changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #16 from Fabio Valentini --- From my point of view, the package can be approved, as all packaging issues have been resolved. Still, it would probably be wise to wait with importing the package until you get confirmation for the licensing of the testdata fonts and pictures. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1479027 --- Comment #15 from Athos Ribeiro --- Oh, sorry for that! I messed up the links. Spec URL: https://athoscr.fedorapeople.org/packaging/golang-github-golang-image.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/golang-github-golang-image-0-0.2.20170514.git426cfd8.fc26.src.rpm Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21286115 About the license for the testdata files, it seems that they are covered by the same license of the package, as mentioned in [1]. We can always wait for the pending reply in [1] to make sure. [1] https://groups.google.com/forum/#!topic/golang-nuts/ayvhNCVqE0Q -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1474958] Review Request: lammps - Large-scale Atomic/ Molecular Massively Parallel Simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1474958 --- Comment #18 from Christoph Junghans --- Thanks! (In reply to Antonio Trande from comment #17) > Issues: > === > - lammps-openmpi and lammps-mpich do not need 'Buildrequires:' Done > - 'Requires: mpich or openmpi' are lines for 'lammps-openmpi' or > 'lammps-mpich' > respectively Done > - lammps-openmpi and lammps-mpich do not provide their own LICENSE Done Spec URL: https://fedorapeople.org/~junghans/lammps.spec SRPM URL: https://fedorapeople.org/~junghans/lammps-20170811-5.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1479967] Review Request: fritzing-parts - Parts library for the Fritzing electronic design application
https://bugzilla.redhat.com/show_bug.cgi?id=1479967 --- Comment #6 from Ed Marshall --- Ah, good point. I've added a comment about licensing disposition, and both spec and SRPM have been updated, and the koji task is at: https://koji.fedoraproject.org/koji/taskinfo?taskID=21285345 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475832] Review Request: golang-github-ncw-dropbox-sdk-go-unofficial - An unofficial Go SDK for integrating with the Dropbox API v2
https://bugzilla.redhat.com/show_bug.cgi?id=1475832 --- Comment #4 from Robert-André Mauchin --- Added commitdate SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591316-golang-github-ncw-dropbox-sdk-go-unofficial/golang-github-ncw-dropbox-sdk-go-unofficial.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591316-golang-github-ncw-dropbox-sdk-go-unofficial/golang-github-ncw-dropbox-sdk-go-unofficial-0-0.1.20170530.git5d9f46f.fc27.src.rpm FAS username: eclipseo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1476201
--- Comment #3 from Antonio Trande ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
== Issues ==
- %doc %{_docdir}/%{name}/*
Documentation files are already installed in the %doc directory by Make.
Just use:
%{_docdir}/%{name}/
- 'hicolor-icon-theme' is required
- Add an appdata file.
https://fedoraproject.org/wiki/Packaging:AppData
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* GPL (v2 or later)", "Unknown or generated". 221
files have unknown license. Detailed output of licensecheck in
/home/sagitter/1476201-qdirstat/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/doc/qdirstat
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/doc/qdirstat,
/usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/32x32,
/usr/share/icons/hicolor
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
contains desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in qdirstat
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in qdirstat
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 204800 bytes in 20 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packag
[Bug 1468383] Review Request: python-easyargs - Making argument parsing easy
https://bugzilla.redhat.com/show_bug.cgi?id=1468383 Carl George changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-08-17 15:25:35 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475817] Review Request: golang-github-jlaffaye-ftp - A FTP client package for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1475817 --- Comment #2 from Robert-André Mauchin --- Added commitdate SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591311-golang-github-jlaffaye-ftp/golang-github-jlaffaye-ftp.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591311-golang-github-jlaffaye-ftp/golang-github-jlaffaye-ftp-0-0.1.20170721.git769512c.fc27.src.rpm FAS username: eclipseo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks
https://bugzilla.redhat.com/show_bug.cgi?id=1451066 Julien Enselme changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #13 from Julien Enselme --- Looks good to me. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482576] Review Request: python3-cryptography-vectors - Test vectors for the cryptography package
https://bugzilla.redhat.com/show_bug.cgi?id=1482576 Jeremy Cline changed: What|Removed |Added Blocks||1481618 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1481618 [Bug 1481618] RFE: python 3 package for python-cryptography in EPEL7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482577] Review Request: python3-cryptography - PyCA' s cryptography library
https://bugzilla.redhat.com/show_bug.cgi?id=1482577 Jeremy Cline changed: What|Removed |Added Blocks||1481618 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1481618 [Bug 1481618] RFE: python 3 package for python-cryptography in EPEL7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482576] Review Request: python3-cryptography-vectors - Test vectors for the cryptography package
https://bugzilla.redhat.com/show_bug.cgi?id=1482576
Jeremy Cline changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||jer...@jcline.org
Assignee|nob...@fedoraproject.org|jer...@jcline.org
Flags||fedora-review+
--- Comment #1 from Jeremy Cline ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "Apache (v2.0) BSD (unspecified)", "*No
copyright* Apache (v2.0) BSD (unspecified)", "Unknown or generated",
"*No copyright* Apache (v2.0)". 2102 files have unknown license.
Detailed output of licensecheck in /home/vagrant/1482576-python3
-cryptography-vectors/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[-]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile an
[Bug 1482055] Review Request: shairport-sync - AirTunes emulator. Shairport Sync adds multi-room capability with Audio Synchronisation.
https://bugzilla.redhat.com/show_bug.cgi?id=1482055 --- Comment #17 from Bill Peck --- Yes. In case anyone else is stuck I had to delete .bugzillacookie and .bugzillatoken from my home dir. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482055] Review Request: shairport-sync - AirTunes emulator. Shairport Sync adds multi-room capability with Audio Synchronisation.
https://bugzilla.redhat.com/show_bug.cgi?id=1482055 --- Comment #16 from Robert-André Mauchin --- It seems to be working, I see your newrepo request here: https://pagure.io/releng/fedora-scm-requests/issue/80 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475872] Review Request: golang-github-golang-sync - Go concurrency primitives
https://bugzilla.redhat.com/show_bug.cgi?id=1475872 --- Comment #2 from Robert-André Mauchin --- Added commitdate SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591305-golang-github-golang-sync/golang-github-golang-sync.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591305-golang-github-golang-sync/golang-github-golang-sync-0-0.1.20170517.gitf52d181.fc27.src.rpm FAS username: eclipseo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475763] Review Request: golang-github-Unknwon-goconfig - Configuration file parser for the Go Programming Language
https://bugzilla.redhat.com/show_bug.cgi?id=1475763 --- Comment #7 from Robert-André Mauchin --- Thank you! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475741] Review Request: golang-github-billziss-gh-cgofuse - Cross-platform FUSE library for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1475741 --- Comment #3 from Robert-André Mauchin --- Added commitdate SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591302-golang-github-billziss-gh-cgofuse/golang-github-billziss-gh-cgofuse.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591302-golang-github-billziss-gh-cgofuse/golang-github-billziss-gh-cgofuse-0-0.1.20170616.git35bcf03.fc27.src.rpm FAS username: eclipseo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482055] Review Request: shairport-sync - AirTunes emulator. Shairport Sync adds multi-room capability with Audio Synchronisation.
https://bugzilla.redhat.com/show_bug.cgi?id=1482055 --- Comment #15 from Robert-André Mauchin --- I have no idea why you're getting this message. Try asking on fedora-devel or do a bug request on https://pagure.io/fedora-infrastructure/issues -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1476201 Robert-André Mauchin changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #2 from Robert-André Mauchin --- I have been sponsored since then. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475763] Review Request: golang-github-Unknwon-goconfig - Configuration file parser for the Go Programming Language
https://bugzilla.redhat.com/show_bug.cgi?id=1475763 Fabio Valentini changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Fabio Valentini --- Package Review == (...) [x]: Package complies to the Packaging Guidelines (...) Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems
https://bugzilla.redhat.com/show_bug.cgi?id=1475750 --- Comment #4 from Robert-André Mauchin --- Added commitdate SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591298-golang-bazil-fuse/golang-bazil-fuse.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591298-golang-bazil-fuse/golang-bazil-fuse-0-0.1.20160811.git371fbbd.fc27.src.rpm FAS username: eclipseo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1476201 Antonio Trande changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1476201 Antonio Trande changed: What|Removed |Added Status|NEW |ASSIGNED CC||anto.tra...@gmail.com Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482055] Review Request: shairport-sync - AirTunes emulator. Shairport Sync adds multi-room capability with Audio Synchronisation.
https://bugzilla.redhat.com/show_bug.cgi?id=1482055 --- Comment #14 from Bill Peck --- What is the next step I should be doing here? I tried the following: [bpeck@bpeck ~]$ fedrepo-req shairport-sync -t 1482055 Error: The Bugzilla ticket provided is invalid Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482055] Review Request: shairport-sync - AirTunes emulator. Shairport Sync adds multi-room capability with Audio Synchronisation.
https://bugzilla.redhat.com/show_bug.cgi?id=1482055
Robert-André Mauchin changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #13 from Robert-André Mauchin ---
Here we are, all good. Package accepted.
Thanks for your work.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "ISC", "GPL (v3 or later)", "Unknown or
generated", "BSD (3 clause)". 42 files have unknown license. Detailed
output of licensecheck in /home/bob/packaging/review/shairport-sync
/review-shairport-sync/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 133120 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
shairport-sync-debuginfo
[?]: Package functio
[Bug 1475763] Review Request: golang-github-Unknwon-goconfig - Configuration file parser for the Go Programming Language
https://bugzilla.redhat.com/show_bug.cgi?id=1475763 --- Comment #5 from Robert-André Mauchin --- Spec URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591293-golang-github-Unknwon-goconfig/golang-github-Unknwon-goconfig.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591293-golang-github-Unknwon-goconfig/golang-github-Unknwon-goconfig-0-0.1.20161121.git87a46d9.fc27.src.rpm 1) Done. 2) I did not add a %dir "testdata", instead I've changed how I was packaging testdata based on reviews I did more recently, it should be more consistent and take care of the %dir automatically. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1474958] Review Request: lammps - Large-scale Atomic/ Molecular Massively Parallel Simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1474958
--- Comment #17 from Antonio Trande ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- lammps-openmpi and lammps-mpich do not need 'Buildrequires:'
- 'Requires: mpich or openmpi' are lines for 'lammps-openmpi' or 'lammps-mpich'
respectively
- lammps-openmpi and lammps-mpich do not provide their own LICENSE
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
generated", "*No copyright* GPL", "MIT/X11 (BSD like)", "SIL (v1.1)",
"BSD (unspecified)", "GPL (v2 or later) (with incorrect FSF address)",
"*No copyright* CC0", "BSD (3 clause)", "BSD (2 clause)", "*No
copyright* MIT/X11 (BSD like)". 5522 files have unknown license.
Detailed output of licensecheck in
/home/sagitter/1474958-lammps/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see
[Bug 1482055] Review Request: shairport-sync - AirTunes emulator. Shairport Sync adds multi-room capability with Audio Synchronisation.
https://bugzilla.redhat.com/show_bug.cgi?id=1482055 --- Comment #12 from Bill Peck --- I was trying to be too clever. Updated -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482055] Review Request: shairport-sync - AirTunes emulator. Shairport Sync adds multi-room capability with Audio Synchronisation.
https://bugzilla.redhat.com/show_bug.cgi?id=1482055 --- Comment #11 from Robert-André Mauchin --- You must separate license by "and": License:MIT and BSD and GPLv3+ and ISC -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1461290] Review Request: gtk4 - GTK+ graphical user interface library
https://bugzilla.redhat.com/show_bug.cgi?id=1461290 Kalev Lember changed: What|Removed |Added Fixed In Version||gtk4-3.91.2-1.fc27 --- Comment #5 from Kalev Lember --- OK, the builds are running for rawhide (F28) and F27 now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482055] Review Request: shairport-sync - AirTunes emulator. Shairport Sync adds multi-room capability with Audio Synchronisation.
https://bugzilla.redhat.com/show_bug.cgi?id=1482055 --- Comment #10 from Bill Peck --- Thank you very much. I believe I've made all of the requested changes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1476201 --- Comment #1 from Robert-André Mauchin --- SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/qdirstat/fedora-rawhide-x86_64/00591266-qdirstat/qdirstat.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/qdirstat/fedora-rawhide-x86_64/00591266-qdirstat/qdirstat-1.4-3.fc27.src.rpm FAS username: eclipseo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475872] Review Request: golang-github-golang-sync - Go concurrency primitives
https://bugzilla.redhat.com/show_bug.cgi?id=1475872 --- Comment #1 from Robert-André Mauchin --- SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591262-golang-github-golang-sync/golang-github-golang-sync.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591262-golang-github-golang-sync/golang-github-golang-sync-0-0.1.gitf52d181.fc27.src.rpm FAS username: eclipseo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482055] Review Request: shairport-sync - AirTunes emulator. Shairport Sync adds multi-room capability with Audio Synchronisation.
https://bugzilla.redhat.com/show_bug.cgi?id=1482055 --- Comment #9 from Robert-André Mauchin --- LICENSESdoesn't contain all the breakdown. Go with something like # MIT licensed except for tinysvcmdns under BSD, # FFTConvolver/ under GPLv3+ and audio_sndio.c # under ISC -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482577] Review Request: python3-cryptography - PyCA' s cryptography library
https://bugzilla.redhat.com/show_bug.cgi?id=1482577 Nathaniel McCallum changed: What|Removed |Added CC||npmccal...@redhat.com --- Comment #1 from Nathaniel McCallum --- I am strongly against having a python3 pyca package that is a different version than the python2 pyca package that ships in RHEL. This will result in extra work for the RHEL developers and will also cause subtle compatibility issues on code written to work on either python2 or python3. NACK from me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475763] Review Request: golang-github-Unknwon-goconfig - Configuration file parser for the Go Programming Language
https://bugzilla.redhat.com/show_bug.cgi?id=1475763
--- Comment #4 from Fabio Valentini ---
There are two small issues with the .spec file:
1) According to the changed Versioning guidelines (that gofed hasn't yet been
adapted to comply with), the snapshot _DATE_ must be also part of the Release
string. So, change the Release line to:
Release:0.1.%{commitdate}.git%{shortcommit}%{?dist}
and add a "%global commitdate 20161121" to the definitions at the beginning of
the spec file (also, dont forget to update this when doing snapshot updates
later). You will also have to adapt the version-release number in the changelog
entry.
2) The manually created "testdata" directory is unowned. Add a
%dir %{gopath}/src/%{provider}.%{provider_tld}/%{project}/testdata
entry to the -unit-test-devel subpackage (please double-check that string for
typos on my side).
Otherwise, the .spec file (except for copying the testdata manually, which is
necessary) corresponds exactly with the template that gofed generates, and is
thus generally acceptable.
Once those two issues are fixed (you don't have to bump the release from 1 to
2, it's not required from my side), I'll approve the package.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family
https://bugzilla.redhat.com/show_bug.cgi?id=1475962 --- Comment #2 from Robert-André Mauchin --- SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/libva-intel-hybrid-driver/fedora-rawhide-x86_64/00586995-libva-intel-hybrid-driver/libva-intel-hybrid-driver.spec SRpM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/libva-intel-hybrid-driver/fedora-rawhide-x86_64/00586995-libva-intel-hybrid-driver/libva-intel-hybrid-driver-1.0.2-3.fc27.src.rpm FAS username: eclipseo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475791] Review Request: golang-github-VividCortex-ewma - Exponentially Weighted Moving Average algorithms for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1475791 --- Comment #3 from Robert-André Mauchin --- SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584409-golang-github-VividCortex-ewma/golang-github-VividCortex-ewma.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584409-golang-github-VividCortex-ewma/golang-github-VividCortex-ewma-1.1.1-1.fc27.src.rpm FAS username: eclipseo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475863] Review Request: golang-github-xanzy-ssh-agent - Create a ssh-agent on any type of OS from any Go application
https://bugzilla.redhat.com/show_bug.cgi?id=1475863 --- Comment #2 from Robert-André Mauchin --- SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584410-golang-github-xanzy-ssh-agent/golang-github-xanzy-ssh-agent.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584410-golang-github-xanzy-ssh-agent/golang-github-xanzy-ssh-agent-0-0.1.gitba9c9e3.fc27.src.rpm FAS username: eclipseo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475850] Review Request: golang-github-rfjakob-eme - Encrypt-Mix-Encrypt for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1475850 --- Comment #2 from Robert-André Mauchin --- SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584407-golang-github-rfjakob-eme/golang-github-rfjakob-eme.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584407-golang-github-rfjakob-eme/golang-github-rfjakob-eme-1.1-1.fc27.src.rpm FAS username: eclipseo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482055] Review Request: shairport-sync - AirTunes emulator. Shairport Sync adds multi-room capability with Audio Synchronisation.
https://bugzilla.redhat.com/show_bug.cgi?id=1482055 --- Comment #8 from Bill Peck --- Can you give me an example on how to reference the licenses inside the spec? I went by this example: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios # For a breakdown of the licensing, see PACKAGE-LICENSING -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475846] Review Request: golang-github-nsf-termbox-go - A minimalistic API which allows programmers to write text-based user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1475846 --- Comment #2 from Robert-André Mauchin --- SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584406-golang-github-nsf-termbox-go/golang-github-nsf-termbox-go.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584406-golang-github-nsf-termbox-go/golang-github-nsf-termbox-go-0-0.1.git4ed959e.fc27.src.rpm FAS username: eclipseo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475832] Review Request: golang-github-ncw-dropbox-sdk-go-unofficial - An unofficial Go SDK for integrating with the Dropbox API v2
https://bugzilla.redhat.com/show_bug.cgi?id=1475832 --- Comment #3 from Robert-André Mauchin --- SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584404-golang-github-ncw-dropbox-sdk-go-unofficial/golang-github-ncw-dropbox-sdk-go-unofficial.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584404-golang-github-ncw-dropbox-sdk-go-unofficial/golang-github-ncw-dropbox-sdk-go-unofficial-0-0.1.git5d9f46f.fc27.src.rpm FAS username: eclipseo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475841] Review Request: golang-github-ncw-go-acd - Go library for accessing the Amazon Cloud Drive
https://bugzilla.redhat.com/show_bug.cgi?id=1475841 --- Comment #2 from Robert-André Mauchin --- SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584405-golang-github-ncw-go-acd/golang-github-ncw-go-acd.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584405-golang-github-ncw-go-acd/golang-github-ncw-go-acd-0-0.1.git96a49aa.fc27.src.rpm FAS username: eclipseo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475750] Review Request: golang-bazil-fuse - Go library for writing FUSE userspace filesystems
https://bugzilla.redhat.com/show_bug.cgi?id=1475750 --- Comment #3 from Robert-André Mauchin --- SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584399-golang-bazil-fuse/golang-bazil-fuse.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584399-golang-bazil-fuse/golang-bazil-fuse-0-0.1.git371fbbd.fc27.src.rpm FAS username: eclipseo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475741] Review Request: golang-github-billziss-gh-cgofuse - Cross-platform FUSE library for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1475741 --- Comment #2 from Robert-André Mauchin --- SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584400-golang-github-billziss-gh-cgofuse/golang-github-billziss-gh-cgofuse.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584400-golang-github-billziss-gh-cgofuse/golang-github-billziss-gh-cgofuse-0-0.1.git35bcf03.fc27.src.rpm FAS username: eclipseo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475817] Review Request: golang-github-jlaffaye-ftp - A FTP client package for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1475817 --- Comment #1 from Robert-André Mauchin --- SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584403-golang-github-jlaffaye-ftp/golang-github-jlaffaye-ftp.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584403-golang-github-jlaffaye-ftp/golang-github-jlaffaye-ftp-0-0.1.git769512c.fc27.src.rpm FAS username: eclipseo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475763] Review Request: golang-github-Unknwon-goconfig - Configuration file parser for the Go Programming Language
https://bugzilla.redhat.com/show_bug.cgi?id=1475763 --- Comment #3 from Robert-André Mauchin --- Spec URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584408-golang-github-Unknwon-goconfig/golang-github-Unknwon-goconfig.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00584408-golang-github-Unknwon-goconfig/golang-github-Unknwon-goconfig-0-0.1.git87a46d9.fc27.src.rpm FAS usernam: eclipseo Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475763] Review Request: golang-github-Unknwon-goconfig - Configuration file parser for the Go Programming Language
https://bugzilla.redhat.com/show_bug.cgi?id=1475763 Fabio Valentini changed: What|Removed |Added CC||decatho...@gmail.com Assignee|nob...@fedoraproject.org|decatho...@gmail.com Flags||fedora-review? --- Comment #2 from Fabio Valentini --- Taking this review. - The .src.rpm file is no longer available at that link, please re-upload (even github would work better, koji builds are recycled regularly). - Make sure to link the "raw" github link of any files, otherwise fedora-review can't process the links correctly. PS: Please follow the Review Request template so the request can be processed more easily. " Spec URL: URL SRPM URL: URL (etc.) " -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482055] Review Request: shairport-sync - AirTunes emulator. Shairport Sync adds multi-room capability with Audio Synchronisation.
https://bugzilla.redhat.com/show_bug.cgi?id=1482055
--- Comment #7 from Robert-André Mauchin ---
You've got a rpmlint error because your summary line is too long and ends with
a dot. Shorten it and remove the dot.
Also you should detail the breakdown of license in the SPEC, not make a
reference to the LICENSES
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "ISC", "GPL (v3 or later)", "Unknown or
generated", "BSD (3 clause)". 42 files have unknown license. Detailed
output of licensecheck in /home/bob/packaging/review/shairport-sync
/review-shairport-sync/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 133120 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
shairport-sync-debuginfo
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Descr
[Bug 1482055] Review Request: shairport-sync - AirTunes emulator. Shairport Sync adds multi-room capability with Audio Synchronisation.
https://bugzilla.redhat.com/show_bug.cgi?id=1482055 --- Comment #6 from Robert-André Mauchin --- Sorry there's still some issue regarding licensing that I didn't catch before: GPL (v3 or later) - shairport-sync-3.1/FFTConvolver/FFTConvolver.cpp shairport-sync-3.1/FFTConvolver/FFTConvolver.h shairport-sync-3.1/FFTConvolver/Utilities.cpp shairport-sync-3.1/FFTConvolver/Utilities.h ISC --- shairport-sync-3.1/audio_sndio.c You need to add: and GPLv3+ and ISC -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482055] Review Request: shairport-sync - AirTunes emulator. Shairport Sync adds multi-room capability with Audio Synchronisation.
https://bugzilla.redhat.com/show_bug.cgi?id=1482055 --- Comment #5 from Robert-André Mauchin --- I've just noticed that you didn't fix this: the %changelog version is wrong: the version should be in the format %version-%release For example: 3.1-1 You need to add -1 to your changelog entry. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482055] Review Request: shairport-sync - AirTunes emulator. Shairport Sync adds multi-room capability with Audio Synchronisation.
https://bugzilla.redhat.com/show_bug.cgi?id=1482055 --- Comment #4 from Bill Peck --- Good catch! Thank you. above url should show the update. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482055] Review Request: shairport-sync - AirTunes emulator. Shairport Sync adds multi-room capability with Audio Synchronisation.
https://bugzilla.redhat.com/show_bug.cgi?id=1482055 --- Comment #3 from Robert-André Mauchin --- One last thing: your %config should be %config(noreplace) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468383] Review Request: python-easyargs - Making argument parsing easy
https://bugzilla.redhat.com/show_bug.cgi?id=1468383 --- Comment #8 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-easyargs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482576] Review Request: python3-cryptography-vectors - Test vectors for the cryptography package
https://bugzilla.redhat.com/show_bug.cgi?id=1482576 Aurelien Bompard changed: What|Removed |Added Blocks||1482577 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1482577 [Bug 1482577] Review Request: python3-cryptography - PyCA's cryptography library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482577] Review Request: python3-cryptography - PyCA' s cryptography library
https://bugzilla.redhat.com/show_bug.cgi?id=1482577 Aurelien Bompard changed: What|Removed |Added Depends On||1482576 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1482576 [Bug 1482576] Review Request: python3-cryptography-vectors - Test vectors for the cryptography package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482577] New: Review Request: python3-cryptography - PyCA' s cryptography library
https://bugzilla.redhat.com/show_bug.cgi?id=1482577 Bug ID: 1482577 Summary: Review Request: python3-cryptography - PyCA's cryptography library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: aurel...@bompard.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://abompard.fedorapeople.org/reviews/python3-cryptography/python3-cryptography.spec SRPM URL: https://abompard.fedorapeople.org/reviews/python3-cryptography/python3-cryptography-1.7.2-2.el7.centos.src.rpm Description: This package is identical to the python-cryptography that is already in Fedora. The only purpose of this new package is to be built for Python 3 in EPEL7+, since this package is already in RHEL for Python 2. Fedora Account System Username: abompard -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482576] New: Review Request: python3-cryptography-vectors - Test vectors for the cryptography package
https://bugzilla.redhat.com/show_bug.cgi?id=1482576 Bug ID: 1482576 Summary: Review Request: python3-cryptography-vectors - Test vectors for the cryptography package Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: aurel...@bompard.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://abompard.fedorapeople.org/reviews/python3-cryptography-vectors/python3-cryptography-vectors.spec SRPM URL: https://abompard.fedorapeople.org/reviews/python3-cryptography-vectors/python3-cryptography-vectors-1.7.2-2.el7.centos.src.rpm Description: This package is identical to the python-cryptography-vectors that is already in Fedora. The only purpose of this new package is to be built for Python 3 in EPEL7+, since this package is already in RHEL for Python 2. Fedora Account System Username: abompard -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482055] Review Request: shairport-sync - AirTunes emulator. Shairport Sync adds multi-room capability with Audio Synchronisation.
https://bugzilla.redhat.com/show_bug.cgi?id=1482055 --- Comment #2 from Bill Peck --- Thank you for the thorough review. I believe I've addressed all your concerns here: https://github.com/p3ck/shairport-sync/blob/development/shairport-sync.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1362490] Review Request: libphutil - A collection of PHP utility classes
https://bugzilla.redhat.com/show_bug.cgi?id=1362490 Andreas Schneider changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|a...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1362487] Review Request: arcanist - A command line interface to Phabricator
https://bugzilla.redhat.com/show_bug.cgi?id=1362487 Andreas Schneider changed: What|Removed |Added Assignee|jsmith.fed...@gmail.com |a...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468383] Review Request: python-easyargs - Making argument parsing easy
https://bugzilla.redhat.com/show_bug.cgi?id=1468383 --- Comment #7 from Carl George --- No problem at all, ripgrep is very useful. I had submitted it for review previously, but the Rust SIG wants to package it using ranged dependencies, which I don't believe is available ina released version of RPM yet. Even when it is (F28?), it is doubtful to ever be available on RHEL, so I'll keep that COPR going everywhere it makes sense. Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1468383] Review Request: python-easyargs - Making argument parsing easy
https://bugzilla.redhat.com/show_bug.cgi?id=1468383 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #6 from Robert-André Mauchin --- >Using the py2_dist/py3_dist macros would prevent me from having an identical >spec file for Fedora and EPEL, since stock RHEL packages don't provide >"python2dist()". Okay >Is it a blocker? No Everything is okay. Package accepted. BTW, thanks for your ripgrep COPR package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1479280] Review Request: python-jieba - Chinese Words Segementation Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1479280 Zamir SUN changed: What|Removed |Added Assignee|nob...@fedoraproject.org|szts...@gmail.com Flags||fedora-review+ --- Comment #2 from Zamir SUN --- Package approved by zsun. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1479280] Review Request: python-jieba - Chinese Words Segementation Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1479280
Zamir SUN changed:
What|Removed |Added
Status|NEW |POST
CC||szts...@gmail.com
--- Comment #1 from Zamir SUN ---
Hi,
Thanks for the work. Looks good to me. Please fix the following two before push
to dist-git.
* Description are sentenses, so should end with a dot(.)
* You can use %{srcname} to replace 'jieba' in Source0
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 73 files have
unknown license. Detailed output of licensecheck in /tmp/1479280
-python-jieba/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 81920 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python2-jieba , python3-jieba
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file
[Bug 1471885] Review Request: oci-umount - OCI umount hook for docker
https://bugzilla.redhat.com/show_bug.cgi?id=1471885 --- Comment #6 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/oci-umount -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481604] Review Request: octave-interval - Interval arithmetic for Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1481604
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #3 from Robert-André Mauchin ---
Hello,
- The Group: tag is not required when packaging for Fedora. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
- Most of the package is GPLv3+ but crlibm is under LGPLv2+. This should be
reflected in the License: tag and detailed
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* LGPL (v2 or later)", "GPL (v3)", "GPL (v3 or
later)", "Unknown or generated", "Apache GPL", "MIT/X11 (BSD like)",
"*No copyright* Apache", "Apache (v2.0) GPL (v3 or later)", "LGPL (v2
or later)", "LGPL (v2.1 or later)", "FSF All Permissive". 260 files
have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/octave-interval/review-octave-
interval/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note:
