[Bug 1480955] Review Request: golang-github-alecthomas-repr - Python' s repr for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1480955 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- Okay, package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1435920] Review Request: python-j1m.sphinxautointerface - Sphinx extension for documenting zope.interface interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1435920 --- Comment #8 from Antonio Trande --- (In reply to Jerry James from comment #7) > Yes, it is a fork of this repository: > https://bitbucket.org/birkenfeld/sphinx-contrib. The fork was made because > of lack of movement on this pull request: > https://bitbucket.org/birkenfeld/sphinx-contrib/pull-requests/126/fixes- > based-on-using-the-extension-with/diff. Since there has been some recent > movement on that PR, we should maybe wait a bit and see if things get > resolved. You could include LICENSE file from original source, leaving a comment about. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483129] golang-github-neurosnap-sentences - Multilingual command line sentence tokenizer in Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1483129
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
%global import_path %{provider_prefix}
You should use this as import path, but use the upstream provided one,
gopkg.in/neurosnap/sentences.v1
%global import_path gopkg.in/neurosnap/sentences.v1
And in the bottom of the spec:
%dir %{gopath}/src/gopkg.in/neurosnap/sentences.v1
Otherwise projects depending on this won't find it. Likewise you shouldn't
patch the source in bug #1480762, it will find it once this is fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475741] Review Request: golang-github-billziss-gh-cgofuse - Cross-platform FUSE library for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1475741 --- Comment #5 from Robert-André Mauchin --- >Upstream does provide versions, have you considered using them? Ha good catch, I missed it. > If they are to be packaged, the files under examples directory should be > under %doc Noted. SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591774-golang-github-billziss-gh-cgofuse/golang-github-billziss-gh-cgofuse.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00591774-golang-github-billziss-gh-cgofuse/golang-github-billziss-gh-cgofuse-1.0.2-1.fc27.src.rpm Thank for your reviews! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482205] Review Request: syncthing-gtk - Syncthing GTK+ GUI
https://bugzilla.redhat.com/show_bug.cgi?id=1482205 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482205] Review Request: syncthing-gtk - Syncthing GTK+ GUI
https://bugzilla.redhat.com/show_bug.cgi?id=1482205 --- Comment #4 from Fedora Update System --- syncthing-gtk-0.9.2.5-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f28ffc58a2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483154] Review Request: nodejs-set-blocking - Set blocking stdio and stderr ensuring that terminal output does not truncate
https://bugzilla.redhat.com/show_bug.cgi?id=1483154
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
Hello,
Minor issues:
- Description should end with a dot.
- Use spaces only in your spec, no tabs please.
- Instead of using a complex script to download the tests, why don't you
download directly the archive from Github? It contains the tests. Just do:
Source0:
https://github.com/yargs/%{packagename}/archive/v%{version}/%{packagename}-%{version}.tar.gz
You'll have everything you need.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "ISC", "Unknown or generated". 7 files have unknown license.
Detailed output of licensecheck in /home/bob/packaging/review/nodejs-
set-blocking/review-nodejs-set-blocking/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original
[Bug 1472663] Review Request: variety - Wallpaper changer that automatically downloads wallpapers
https://bugzilla.redhat.com/show_bug.cgi?id=1472663 --- Comment #5 from mgans...@alice.de --- (In reply to Robert-André Mauchin from comment #4) > Sorry but I was still missing Requires: I had to add libappindicator-gtk3 > and webkitgtk3 as dependency. Also imagemagick is case sensitive, it's > ImageMagick. > > See > https://copr-be.cloud.fedoraproject.org/results/eclipseo/variety/fedora- > rawhide-x86_64/00591769-variety/variety.spec > > If you want I can review your package later. yes you can review the package, you are welcome. Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/variety.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/variety-0.6.4-3.fc26.src.rpm %changelog * Sat Aug 19 2017 Martin Gansser - 0.6.4-3 - Add RR libappindicator-gtk3 - Correct RR ImageMagick it's case sensitive - Add RR webkitgtk3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1452958] Review Request: sasutils - Serial Attached SCSI (SAS) Linux utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1452958
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #6 from Robert-André Mauchin ---
Hi,
- The Group: tag is not needed in Fedora. See:
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
- You didn't remove the line: Provides: python3-%{name} = %{version}
which is not useful with %{?python_provide:%python_provide
python%{python3_pkgversion}-%{srcname}}
- You've got a whole bunch of rpmlint error because some of Python files
contain a shebang:
Checking: sasutils-0.3.8-1.fc27.noarch.rpm
sasutils-0.3.8-1.fc27.src.rpm
sasutils.noarch: E: wrong-script-interpreter
/usr/lib/python3.6/site-packages/sasutils/cli/sas_counters.py /usr/bin/env
python
sasutils.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/sasutils/cli/sas_counters.py 644 /usr/bin/env
python
sasutils.noarch: E: wrong-script-interpreter
/usr/lib/python3.6/site-packages/sasutils/cli/sas_devices.py /usr/bin/env
python
sasutils.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/sasutils/cli/sas_devices.py 644 /usr/bin/env
python
sasutils.noarch: E: wrong-script-interpreter
/usr/lib/python3.6/site-packages/sasutils/cli/sas_discover.py /usr/bin/env
python
sasutils.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/sasutils/cli/sas_discover.py 644 /usr/bin/env
python
sasutils.noarch: E: wrong-script-interpreter
/usr/lib/python3.6/site-packages/sasutils/cli/sas_mpath_snic_alias.py
/usr/bin/env python
sasutils.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/sasutils/cli/sas_mpath_snic_alias.py 644
/usr/bin/env python
sasutils.noarch: E: wrong-script-interpreter
/usr/lib/python3.6/site-packages/sasutils/cli/sas_sd_snic_alias.py /usr/bin/env
python
sasutils.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/sasutils/cli/sas_sd_snic_alias.py 644
/usr/bin/env python
sasutils.noarch: E: wrong-script-interpreter
/usr/lib/python3.6/site-packages/sasutils/cli/ses_report.py /usr/bin/env python
sasutils.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/sasutils/cli/ses_report.py 644 /usr/bin/env
python
sasutils.noarch: W: no-manual-page-for-binary sas_mpath_snic_alias
sasutils.noarch: W: no-manual-page-for-binary sas_sd_snic_alias
2 packages and 0 specfiles checked; 12 errors, 2 warnings.
That's a no-no in Fedora. Remove them in %prep with something like:
find -name \*.py | xargs sed -i -e '1 {/^#!/d}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483200] Review Request: golang-github-lucasb-eyer-go-colorful - A library for playing with colors in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1483200
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
Hello,
- You _should_ query upstream to have a separate LICENSE file that we can
include.
- You should include a commitdate which the gofed fails to do:
%global commitdate 20170710
Then:
Release:0.1.%{commitdate}.git%{shortcommit}%{?dist}
And:
* Fri Aug 18 2017 Elliott Sales de Andrade
0-0.1.20170710.gitd1be5f1
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 26 files have unknown license. Detailed
output of licensecheck in /home/bob/packaging/review/golang-github-
lucasb-eyer-go-colorful/review-golang-github-lucasb-eyer-go-
colorful/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode, /usr/share/gocode/src/github.com
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[!]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{ver
[Bug 1483198] Review Request: golang-github-gdamore-encoding - Various character map encodings missing from golang.org /x/net/encoding
https://bugzilla.redhat.com/show_bug.cgi?id=1483198
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
Hello,
Same as before you should include a commitdate (tip: it's 20151215)
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Apache (v2.0)", "*No copyright* Apache", "Unknown or
generated", "*No copyright* Apache (v2.0)". 2 files have unknown
license. Detailed output of licensecheck in /home/bob/packaging/review
/golang-github-gdamore-encoding/review-golang-github-gdamore-
encoding/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode, /usr/share/gocode/src/github.com
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
github-gdamore-encoding-devel , golang-github-gdamore-encoding-unit-
test-devel
[?]: Package functions as described.
[x]: Latest versi
[Bug 1483200] Review Request: golang-github-lucasb-eyer-go-colorful - A library for playing with colors in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1483200 --- Comment #2 from Elliott Sales de Andrade --- (In reply to Robert-André Mauchin from comment #1) > - You should include a commitdate which the gofed fails to do: This is not part of the (admittedly draft) Go guidelines [1] or any existing go packages. If this is to be changed, I think the Go guidelines should be updates along with gofed. [1] https://fedoraproject.org/wiki/PackagingDrafts/Go#Versions -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483201] Review Request: golang-github-gdamore-tcell - An alternate terminal package
https://bugzilla.redhat.com/show_bug.cgi?id=1483201
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
Hello,
- Add a commitdate (20170807)
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Apache (v2.0)", "*No copyright* Apache", "Unknown or
generated", "*No copyright* Apache (v2.0)". 10 files have unknown
license. Detailed output of licensecheck in /home/bob/packaging/review
/golang-github-gdamore-tcell/review-golang-github-gdamore-
tcell/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode, /usr/share/gocode/src/github.com
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
github-gdamore-tcell-devel , golang-github-gdamore-tcell-unit-test-
devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include
[Bug 1483202] Review Request: golang-github-mattn-go-shellwords - Parse line as shell words
https://bugzilla.redhat.com/show_bug.cgi?id=1483202
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
Hello,
mattn/go-shellwords provides Releases:
https://github.com/mattn/go-shellwords/releases
You should in this case use the provided stable release instead of a git
snapshot. You can keep the global %commit matching the release with a
%commitdate for later use if you want.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 6 files have
unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/golang-github-mattn-go-shellwords/review-
golang-github-mattn-go-shellwords/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode, /usr/share/gocode/src/github.com
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/gocode/src/github.com/mattn(golang-github-mattn-go-
runewidth-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully version
[Bug 1483203] Review Request: fzf - A command-line fuzzy finder written in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1483203 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #1 from Robert-André Mauchin --- Hello, This package is a program but you're packaging it like any other Golang library with gofed: you're just providing the -devel and -unit-test-devel subpackage, but there is no "main" package for the fzf binary. You can use gofed as a basis to generate the dependencies and tests, but it stops there, the spec should be written from scratch to provide the fzf binaries in main package. See the sample for packaging a binary here: https://fedoraproject.org/wiki/PackagingDrafts/Go#Packaging_a_binary -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483200] Review Request: golang-github-lucasb-eyer-go-colorful - A library for playing with colors in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1483200 --- Comment #3 from Robert-André Mauchin --- This is part of the main guidelines https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots that normally applies to Golang packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483200] Review Request: golang-github-lucasb-eyer-go-colorful - A library for playing with colors in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1483200 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Robert-André Mauchin --- Okay, keep it like you are used to do. I 'll ask on fedora-devel later which of the Guidelines we should follow. Still try to get a LICENSE file from upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483201] Review Request: golang-github-gdamore-tcell - An alternate terminal package
https://bugzilla.redhat.com/show_bug.cgi?id=1483201 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483198] Review Request: golang-github-gdamore-encoding - Various character map encodings missing from golang.org /x/net/encoding
https://bugzilla.redhat.com/show_bug.cgi?id=1483198 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1476201 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1476201 --- Comment #8 from Fedora Update System --- qdirstat-1.4-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8fd9fb646b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483129] golang-github-neurosnap-sentences - Multilingual command line sentence tokenizer in Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1483129 --- Comment #2 from Robert-André Mauchin --- s/should/shouldn't/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1443076] Review Request: java-9-openjdk - OpenJDK Runtime Environment in implementation of java 9 specification
https://bugzilla.redhat.com/show_bug.cgi?id=1443076 jiri vanek changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2017-08-19 11:06:00 --- Comment #53 from jiri vanek --- as all the builds passed, and bodhi updates are still not enabled for f27, and noupdate planned for f26 (just builds), closing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1443076] Review Request: java-9-openjdk - OpenJDK Runtime Environment in implementation of java 9 specification
https://bugzilla.redhat.com/show_bug.cgi?id=1443076 jiri vanek changed: What|Removed |Added Resolution|CURRENTRELEASE |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483129] golang-github-neurosnap-sentences - Multilingual command line sentence tokenizer in Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1483129 --- Comment #3 from Athos Ribeiro --- What if some project decides to import "github.com/neurosnap/sentences" ? Note that upstream does so, here [1] and here [2]. So I see 3 possible options: a) packaging this under both namespaces b) package only one of the namespaces and patch the source code and dependencies to stick to only one namespace (a) seems to be a good option at first, but then if we pay closer attention to the namespace in 'gopkg.in/neurosnap/sentences.v1', it carries the package major version with it. So whenever they decide to bump the major version, we would need to package it again and retire the old namespace. I believe this is not a good approach for software distribution. That's why I opted to go with (b). If you prefer, we could go with (a), but packaging only gopkg.in/neurosnap/sentences.v1 is not possible because upstream itself would not build without the github package. A third option (c) would be to send a patch upstream to make [1] and [2] import gopkg.in/neurosnap/sentences.v1 But then this would still be a problem if some other project we want to package ever decides to import the github path for some reason (I do not have a solution for this). [1] https://github.com/neurosnap/sentences/blob/eaa759e51378560dd9b545de7502d7c92c5166a7/_cmd/sentences/main.go#L10 [2] https://github.com/neurosnap/sentences/blob/c4a4a02cd25ad0d1b1b623459a63fbeceae6c375/sentences_test.go#L8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483129] golang-github-neurosnap-sentences - Multilingual command line sentence tokenizer in Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1483129
--- Comment #4 from Robert-André Mauchin ---
You can go with (a) and define a x_provider, x_provider_tld, x_project, x_repo
and x_import_path for the second one, then add the list of provides with the
second import_path, then do a symlink between the two:
ln -sT %{gopath}/src/%{import_path} %{buildroot}%{gopath}/src/%{x_import_path}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483200] Review Request: golang-github-lucasb-eyer-go-colorful - A library for playing with colors in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1483200 --- Comment #5 from Robert-André Mauchin --- @Elliot: So I asked on fedora-devel and I've got an answer form Ralf Corsepius of the Packaging committee: https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/message/4DRIFJD6EUMHBF742TOUQ2KWJWVZFAPV/ So we should go with the official rules, i.e. with a commitdate. Take note for your other packages that I've accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480957] Review Request: golang-github-axgle-mahonia - Character-set conversion library implemented in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1480957 --- Comment #4 from sensor@gmail.com --- https://github.com/FZUG/repo/blob/master/rpms/deepin_project/golang-github-axgle-mahonia.spec I think project owner is leave. Could you approve it? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475741] Review Request: golang-github-billziss-gh-cgofuse - Cross-platform FUSE library for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1475741 --- Comment #6 from Athos Ribeiro --- Hi Robert, Thanks for the fixes! Note that the -devel package is still providing the examples subpackages in the GOPATH: /usr/share/gocode/src/github.com/billziss-gh/cgofuse/examples /usr/share/gocode/src/github.com/billziss-gh/cgofuse/examples/hellofs /usr/share/gocode/src/github.com/billziss-gh/cgofuse/examples/memfs /usr/share/gocode/src/github.com/billziss-gh/cgofuse/examples/passthrough /usr/share/gocode/src/github.com/billziss-gh/cgofuse/examples/shared /usr/share/gocode/src/github.com/billziss-gh/cgofuse/examples/hellofs/hellofs.go /usr/share/gocode/src/github.com/billziss-gh/cgofuse/examples/memfs/memfs.go /usr/share/gocode/src/github.com/billziss-gh/cgofuse/examples/passthrough/passthrough.go /usr/share/gocode/src/github.com/billziss-gh/cgofuse/examples/passthrough/port_darwin.go /usr/share/gocode/src/github.com/billziss-gh/cgofuse/examples/passthrough/port_linux.go /usr/share/gocode/src/github.com/billziss-gh/cgofuse/examples/shared/trace.go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475741] Review Request: golang-github-billziss-gh-cgofuse - Cross-platform FUSE library for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1475741 --- Comment #7 from Athos Ribeiro --- I mean, if that is intentional, let me know and I will conclude the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480972] Review Request: golang-github-BurntSushi-xgbutil - XGB is the X protocol Go language Binding
https://bugzilla.redhat.com/show_bug.cgi?id=1480972 --- Comment #3 from sensor@gmail.com --- http://dl.fedoraproject.org/pub/fedora/linux/development/rawhide/Everything/x86_64/os/Packages/g/golang-github-BurntSushi-graphics-go-devel-0-0.2.gitb43f31a.fc28.noarch.rpm http://dl.fedoraproject.org/pub/fedora/linux/development/rawhide/Everything/x86_64/os/Packages/g/golang-github-BurntSushi-freetype-go-devel-0-0.1.gitb763ddb.fc28.noarch.rpm Some dependencies package looks good. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483129] golang-github-neurosnap-sentences - Multilingual command line sentence tokenizer in Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1483129 --- Comment #5 from Athos Ribeiro --- You mean, packaging 2 different -devel subpackages, like the extra packages from golang.org/x/foo? That works for me. I will prepare sth and update the sources as soon as I can. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483129] golang-github-neurosnap-sentences - Multilingual command line sentence tokenizer in Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1483129 --- Comment #6 from Robert-André Mauchin --- No. No need for two -devel packages, just one with the double provides and a symlink. I have a sample somewhere, see this spec: https://github.com/eclipseo/packaging/blob/master/golang-googlecode-image.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1430143] Review Request: golang-github-mattn-go-isatty - isatty for Go (golang)
https://bugzilla.redhat.com/show_bug.cgi?id=1430143 --- Comment #5 from Ed Marshall --- Hmm. Not sure what happened here, but it looks like Jan took the package (he's listed as sole admin), so he'll need to issue a new package update for F25 and F26. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family
https://bugzilla.redhat.com/show_bug.cgi?id=1475962 Antonio Trande changed: What|Removed |Added CC|anto.tra...@gmail.com | Flags|fedora-review? |fedora-review+ --- Comment #13 from Antonio Trande --- (In reply to Robert-André Mauchin from comment #11) > It's a MIT type license. More close to a BSD Clause 3 with the no > advertising part. Okay. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475741] Review Request: golang-github-billziss-gh-cgofuse - Cross-platform FUSE library for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1475741 --- Comment #8 from Robert-André Mauchin --- It's not. Let's me fix that. SPEC URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-26-x86_64/00591841-golang-github-billziss-gh-cgofuse/golang-github-billziss-gh-cgofuse.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-26-x86_64/00591841-golang-github-billziss-gh-cgofuse/golang-github-billziss-gh-cgofuse-1.0.2-1.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481876] Review Request: python-pytest-shutil - A goodie-bag of unix shell and environment tools for py.test
https://bugzilla.redhat.com/show_bug.cgi?id=1481876 --- Comment #3 from Kevin Fenzi --- Yeah it builds fine in koji here: http://koji.fedoraproject.org/koji/taskinfo?taskID=21332425 Were you building locally or in mock? I don't think I am missing any buildrequires or it wouldnt work in koji either... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481875] Review Request: python-pytest-virtualenv - Virtualenv fixture for py.test
https://bugzilla.redhat.com/show_bug.cgi?id=1481875 --- Comment #3 from Kevin Fenzi --- Sorry about that. I meant to set dependencies here, but obviously failed to. Yes, this does need pytest-shutil first. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482997] Review Request: prename - Perl script to rename multiple files
https://bugzilla.redhat.com/show_bug.cgi?id=1482997 Ben Rosser changed: What|Removed |Added CC||rosser@gmail.com Assignee|nob...@fedoraproject.org|rosser@gmail.com --- Comment #1 from Ben Rosser --- Taken the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475961] Review Request: cmrt - C for Media Runtime
https://bugzilla.redhat.com/show_bug.cgi?id=1475961 --- Comment #10 from Fedora Update System --- cmrt-1.0.6-4.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e727a51e23 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1478358] Review Request: php-sebastian-diff2 - Diff implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1478358 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- php-phpunit-diff-1.4.3-3.fc26, php-sebastian-comparator2-2.0.2-1.fc26, php-sebastian-diff2-2.0.1-1.fc26, phpunit6-6.3.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2b910cc8ad -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family
https://bugzilla.redhat.com/show_bug.cgi?id=1475962 --- Comment #14 from Robert-André Mauchin --- Thank you for your review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1476438] Review Request: clustersos - collect multiple sosreports simultaneously
https://bugzilla.redhat.com/show_bug.cgi?id=1476438 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- clustersos-1.1.1-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-38dd117277 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1441728] Review Request: cld2 - Compact Language Detector 2
https://bugzilla.redhat.com/show_bug.cgi?id=1441728 --- Comment #24 from Fedora Update System --- cld2-0-0.9.20150821gitb56fa78.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-eda10926f3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #30 from Fedora Update System --- libyui-qt-graph-2.44.6-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-845fd591a3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1479022] Review Request: preeny - Some helpful preload libraries for pwning stuff
https://bugzilla.redhat.com/show_bug.cgi?id=1479022 --- Comment #11 from Fedora Update System --- preeny-0.1-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9f4ec77ae9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1476584] Review Request: deepin-session-ui - Deepin desktop-environment Session UI module
https://bugzilla.redhat.com/show_bug.cgi?id=1476584 --- Comment #7 from sensor@gmail.com --- https://koji.fedoraproject.org/koji/taskinfo?taskID=21332099 Build pass. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480825] Review Request: python-pytest-forked - py.test plugin for running tests in isolated forked subprocesses
https://bugzilla.redhat.com/show_bug.cgi?id=1480825 --- Comment #4 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pytest-forked -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475817] Review Request: golang-github-jlaffaye-ftp - A FTP client package for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1475817 --- Comment #4 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-jlaffaye-ftp -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480966] Review Request: golang-github-sergi-go-diff - Diff, match and patch text in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1480966 --- Comment #5 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-sergi-go-diff -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480965] Review Request: golang-github-nfnt-resize - Pure golang image resize
https://bugzilla.redhat.com/show_bug.cgi?id=1480965 --- Comment #4 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-nfnt-resize -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480964] Review Request: golang-github-msteinert-pam - Go wrapper module for the PAM API
https://bugzilla.redhat.com/show_bug.cgi?id=1480964 --- Comment #4 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-msteinert-pam -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1419330] Review Request: deepin-menu - deepin menu service
https://bugzilla.redhat.com/show_bug.cgi?id=1419330 --- Comment #17 from sensor@gmail.com --- Package is looks good. Please approve. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480956] Review Request: golang-github-alecthomas-template - Go' s text/template package with newline elisio
https://bugzilla.redhat.com/show_bug.cgi?id=1480956 --- Comment #4 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-alecthomas-template -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480955] Review Request: golang-github-alecthomas-repr - Python' s repr for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1480955 --- Comment #4 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-alecthomas-repr -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480971] Review Request: golang-github-alecthomas-assert - Fork of stretchr/testify/ assert that uses FailNow
https://bugzilla.redhat.com/show_bug.cgi?id=1480971 --- Comment #3 from sensor@gmail.com --- :) It's looks good. Please review and approve. Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1479967] Review Request: fritzing-parts - Parts library for the Fritzing electronic design application
https://bugzilla.redhat.com/show_bug.cgi?id=1479967 --- Comment #8 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/fritzing-parts -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1476595] Review Request: dtkcore - Deepin tool kit core modules
https://bugzilla.redhat.com/show_bug.cgi?id=1476595 --- Comment #3 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/dtkcore -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483262] New: Review Request: phpdoc - Documentation generator for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1483262 Bug ID: 1483262 Summary: Review Request: phpdoc - Documentation generator for PHP Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: sh...@iwin.ski QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://raw.githubusercontent.com/siwinski/rpms/3c9f24b039cc5fbee88685a9e524a0cd7a3a4fe4/phpdoc/phpdoc.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/phpdoc-2.9.0-1.fc26.src.rpm Description: phpDocumentor is an application that is capable of analyzing your PHP source code and DocBlock comments to generate a complete set of API Documentation. Inspired by phpDocumentor 1 and JavaDoc it continues to innovate and is up to date with the latest technologies and PHP language features. Features: phpDocumentor supports the following: * PHP 5.3 compatible, full support for Namespaces, Closures and more is provided * Shows any tag, some tags add additional functionality to phpDocumentor (such as @link) * Processing speed, Zend Framework experienced a significant reduction in processing time compared to phpDocumentor 1 * Low memory usage, peak memory usage for small projects is less than 20MB, medium projects 40MB and large frameworks 100MB * Incremental parsing, if you kept the Structure file from a previous run you get an additional performance boost of up to 80% on top of the mentioned processing speed above * Easy template building, if you want to make a branding you only have to call 1 task and edit 3 files * Command-line compatibility with phpDocumentor 1, phpDocumentor 2 is an application in its own right but the basic phpDocumentor 1 arguments, such as --directory, --file and --target, have been adopted * Two-step process, phpDocumentor first generates a cache with your application structure before creating the output. If you'd like you can use that to power your own tools or formatters! Fedora Account System Username: siwinski -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483262] Review Request: phpdoc - Documentation generator for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1483262 Shawn Iwinski changed: What|Removed |Added Blocks||1458576 ||(phpdoc_v2_tracking) Depends On||1470355 ||(php-zetacomponents-documen ||t), 1470358 ||(php-jms-serializer) Alias||phpdoc Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1458576 [Bug 1458576] v2 tracking https://bugzilla.redhat.com/show_bug.cgi?id=1470355 [Bug 1470355] Review Request: php-zetacomponents-document - Provides a general conversion framework for different documents https://bugzilla.redhat.com/show_bug.cgi?id=1470358 [Bug 1470358] Review Request: php-jms-serializer - Library for (de-)serializing data of any complexity -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1470355] Review Request: php-zetacomponents-document - Provides a general conversion framework for different documents
https://bugzilla.redhat.com/show_bug.cgi?id=1470355 Shawn Iwinski changed: What|Removed |Added Blocks||1483262 (phpdoc) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1483262 [Bug 1483262] Review Request: phpdoc - Documentation generator for PHP -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1470358] Review Request: php-jms-serializer - Library for (de-) serializing data of any complexity
https://bugzilla.redhat.com/show_bug.cgi?id=1470358 Shawn Iwinski changed: What|Removed |Added Blocks||1483262 (phpdoc) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1483262 [Bug 1483262] Review Request: phpdoc - Documentation generator for PHP -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1476584] Review Request: deepin-session-ui - Deepin desktop-environment Session UI module
https://bugzilla.redhat.com/show_bug.cgi?id=1476584 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #8 from Robert-André Mauchin --- Package accpted! But you need to package deepin-control-center in order to install this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480971] Review Request: golang-github-alecthomas-assert - Fork of stretchr/testify/ assert that uses FailNow
https://bugzilla.redhat.com/show_bug.cgi?id=1480971 --- Comment #4 from Robert-André Mauchin --- You need to build the packages golang-github-alecthomas-colour, golang-github-alecthomas-repr and golang-github-sergi-go-diff on Rawhide otherwise fedora-review can't find them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475763] Review Request: golang-github-Unknwon-goconfig - Configuration file parser for the Go Programming Language
https://bugzilla.redhat.com/show_bug.cgi?id=1475763 --- Comment #9 from Fedora Update System --- golang-github-Unknwon-goconfig-0-0.1.20161121git87a46d9.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-43074215e5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475763] Review Request: golang-github-Unknwon-goconfig - Configuration file parser for the Go Programming Language
https://bugzilla.redhat.com/show_bug.cgi?id=1475763 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475791] Review Request: golang-github-VividCortex-ewma - Exponentially Weighted Moving Average algorithms for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1475791 --- Comment #9 from Fedora Update System --- golang-github-VividCortex-ewma-1.1.1-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0a91dca49f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475791] Review Request: golang-github-VividCortex-ewma - Exponentially Weighted Moving Average algorithms for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1475791 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483200] Review Request: golang-github-lucasb-eyer-go-colorful - A library for playing with colors in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1483200 --- Comment #6 from Elliott Sales de Andrade --- Opened https://github.com/lucasb-eyer/go-colorful/issues/16 for the license file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475962] Review Request: libva-intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family
https://bugzilla.redhat.com/show_bug.cgi?id=1475962 Robert-André Mauchin changed: What|Removed |Added Summary|Review Request: |Review Request: |intel-hybrid-driver - VA|libva-intel-hybrid-driver - |driver for Intel G45 & HD |VA driver for Intel G45 & |Graphics family |HD Graphics family -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475962] Review Request: libva-intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family
https://bugzilla.redhat.com/show_bug.cgi?id=1475962 --- Comment #15 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libva-intel-hybrid-driver -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483200] Review Request: golang-github-lucasb-eyer-go-colorful - A library for playing with colors in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1483200 --- Comment #7 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-lucasb-eyer-go-colorful -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483201] Review Request: golang-github-gdamore-tcell - An alternate terminal package
https://bugzilla.redhat.com/show_bug.cgi?id=1483201 --- Comment #2 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-gdamore-tcell -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483198] Review Request: golang-github-gdamore-encoding - Various character map encodings missing from golang.org /x/net/encoding
https://bugzilla.redhat.com/show_bug.cgi?id=1483198 --- Comment #2 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-gdamore-encoding -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483202] Review Request: golang-github-mattn-go-shellwords - Parse line as shell words
https://bugzilla.redhat.com/show_bug.cgi?id=1483202 --- Comment #2 from Elliott Sales de Andrade --- Huh, I thought I had checked them all for releases. Here is an updated spec for the released version: Spec URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/fzf/fedora-rawhide-x86_64/00591856-golang-github-mattn-go-shellwords/golang-github-mattn-go-shellwords.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/fzf/fedora-rawhide-x86_64/00591856-golang-github-mattn-go-shellwords/golang-github-mattn-go-shellwords-1.0.3-2.fc28.src.rpm Description: Parse line as shell words Fedora Account System Username: qulogic -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481604] Review Request: octave-interval - Interval arithmetic for Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1481604 --- Comment #4 from Colin Macdonald --- Spec URL: https://cbm.fedorapeople.org/octave-interval.spec SRPM URL: https://cbm.fedorapeople.org/octave-interval-2.1.0-3.fc26.src.rpm Thank you for the review! I have addressed those comments. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483198] Review Request: golang-github-gdamore-encoding - Various character map encodings missing from golang.org /x/net/encoding
https://bugzilla.redhat.com/show_bug.cgi?id=1483198 --- Comment #3 from Fedora Update System --- golang-github-gdamore-encoding-0-0.1.20151215gitb23993c.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e5e943947d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483198] Review Request: golang-github-gdamore-encoding - Various character map encodings missing from golang.org /x/net/encoding
https://bugzilla.redhat.com/show_bug.cgi?id=1483198 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483200] Review Request: golang-github-lucasb-eyer-go-colorful - A library for playing with colors in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1483200 --- Comment #8 from Fedora Update System --- golang-github-lucasb-eyer-go-colorful-0-0.1.20170710gitd1be5f1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0b305d6921 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483200] Review Request: golang-github-lucasb-eyer-go-colorful - A library for playing with colors in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1483200 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481630] Review Request: VirtualBox-guest-additions - VirtualBox Guest Additions
https://bugzilla.redhat.com/show_bug.cgi?id=1481630 --- Comment #7 from Sergio Monteiro Basto --- Hi, After tweak fedora-review [1] I needed 2 patches [2] , I see one issue , the provides of libGL.so.1()(64bit) [3] can we remove this rpm provides ? Regards. [1] https://copr.fedorainfracloud.org/coprs/sergiomb/builds_for_Stable_Releases/build/591889/ [2] 0001-don-t-verify-certificates-of-ssl-connections.patch 0001-use-mock-old-chroot-to-not-break-some-scripts.patch [3] Provides VirtualBox-guest-additions: VirtualBox-guest-additions VirtualBox-guest-additions(x86-64) libGL.so.1()(64bit) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1478231] Review Request: conda - Cross-platform, Python-agnostic binary package manager
https://bugzilla.redhat.com/show_bug.cgi?id=1478231
--- Comment #6 from Zbigniew Jędrzejewski-Szmek ---
Thanks you for taking the review. Being so through has been very helpful.
I fixed most stuff (comments below), except some parts I disagree with.
> Issues:
> ===
> - All build dependencies are listed in BuildRequires, except for any that
> are listed in the exceptions section of Packaging Guidelines.
> Note: These BR are not needed: sed
> See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
fedora-review is wrong here. If you follow the link it shows, actually gcc
is *not* guaranteed to be present and the list of exceptions has been removed
a while back.
> [!]: License field in the package spec file matches the actual license.
> Note: Checking patched sources after %prep for licenses. Licenses
> found: "Apache (v2.0)", "Unknown or generated", "MIT/X11 (BSD like)",
> "BSD (3 clause) LGPL", "BSD (unspecified)", "*No copyright* BSD
> (unspecified)", "BSD (3 clause)", "LGPL (v2.1 or later)". 265 files
> have unknown license. licensecheck.txt is attached.
> Note: License tag of python*-conda should be "BSD and ASL 2.0 and
> LGPLv2+ and MIT", and multiple licensing description should be provided.
Good catch! I updated the License field and added a bunch of
Provides: bundles(...) fields.
I also looked into unbundling, but the "vendored" copies have different version
then the ones in fedora, and have local modifications. So I think in this
case it just isn't worth the risk of breaking stuff.
> [!]: Package obeys FHS, except libexecdir and /usr/target.
> Note: Fedora does not allow new directories directly under / or /usr
> without FPC approval.
> Note: /usr/condarc.d is provided.
Right. I patched the python code to look in /usr/share/conda/condarc.d, and
moved the file we create to that directory.
> Note: %_bindir/{de,}activate scripts are used for being sourced, but not
> executed. Placing them to %_datadir seems more proper.
Even if they are sourced, $PATH is used, so it's more convenient to have them
in /usr/bin ('source activate' works, and the full path would have to be given
otherwise).
> [?]: Package functions as described.
> Note: Re-examine this after filesystem layout revised.
> [!]: Description of activate
> subpackage is bad.
I fixed the description of activate subpackage to explain what it does.
@Orion: I carried that package over from your spec file. Is there a particular
reason to make this a seperate subpackage?
> Descriptions of some subpackages are the same.
I don't think there's any prohibition against having the same package
desctiptions.
With python2-/python3- packages it's extremely common to have the exact same
text, and this doesn't lead to any confusion because the package name is
enough to understand that one is for python2 and the other for python3.
And I think it's pretty clear without stating it explicitly, that conda is
the main package and python[23]-conda are the python modules backing it.
[!]: Package consistently uses macros (instead of hard-coded directory
names).
Note: Many occurrences of "conda" can be replaced with %{name}.
There's no reason to prefer %{name} to conda. It's longer, harder to type,
and harder to read.
There are two reasons when a macro should be used:
- the string it replaces is long or awkward to type (e.g. because of weird
casing or whatever),
- the string varies, e.g. between architectures, or distro releases.
For strings which are both shorter then the macro, and are unlikely to ever
change,
macros are just obfuscation.
The guidelines talk about hardcoded directory names. E.g. %_libdir is necessary
because it is /usr/lib64 sometimes, and /usr/lib othertimes. But most of the
macro usage in spec files is pointless self-flagellation. ;)
(In reply to Orion Poplawski from comment #3)
> Created attachment 1315375 [details]
> patch to try to support epel7
Added.
(In reply to Elliott Sales de Andrade from comment #5)
> Is there much need to package a Python 2 executable (on Fedora at least)?
Python 2 versions create python2 environments. It's also possible to do
it through other means (e.g. by calling 'python2 /usr/bin/conda create ...'),
but having the versioned executables makes it easier.
Spec URL: https://in.waw.pl/~zbyszek/fedora/conda.spec
SRPM URL: https://in.waw.pl/~zbyszek/fedora/conda-4.3.24-1.fc27.src.rpm
%changelog
- Add all licenses to the License tag
- Add Provides: bundled(...) for all the "vendored" dependencies
- Update descriptions and simplify the spec file a bit
- Move condarc.d directory under /usr/share/conda
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le
[Bug 1478231] Review Request: conda - Cross-platform, Python-agnostic binary package manager
https://bugzilla.redhat.com/show_bug.cgi?id=1478231 --- Comment #7 from Elliott Sales de Andrade --- With miniconda/anaconda, you do `conda create python=2 ...`; I've never had any need for the root to be in a specific version to create environments of it. Why would a system install be any different? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1478231] Review Request: conda - Cross-platform, Python-agnostic binary package manager
https://bugzilla.redhat.com/show_bug.cgi?id=1478231 --- Comment #8 from Zbigniew Jędrzejewski-Szmek --- Yeah, you're right. Let's drop it. Spec URL: https://in.waw.pl/~zbyszek/fedora/conda.spec SRPM URL: https://in.waw.pl/~zbyszek/fedora/conda-4.3.24-3.fc27.src.rpm %changelog - Install just one version of the executables (python 2 or 3) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1470448] Review Request: php-simplesamlphp-saml2_3 - SAML2 PHP library from SimpleSAMLphp ( version 3)
https://bugzilla.redhat.com/show_bug.cgi?id=1470448 --- Comment #2 from Shawn Iwinski --- Update to 3.0.2 and fix source Spec URL: https://raw.githubusercontent.com/siwinski/rpms/94831dd9476291f491a9d12f3bbd37e8d099885c/php-simplesamlphp-saml2_3/php-simplesamlphp-saml2_3.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-simplesamlphp-saml2_3-3.0.2-1.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475817] Review Request: golang-github-jlaffaye-ftp - A FTP client package for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1475817 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475817] Review Request: golang-github-jlaffaye-ftp - A FTP client package for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1475817 --- Comment #5 from Fedora Update System --- golang-github-jlaffaye-ftp-0-0.1.20170721git769512c.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-632bb49bf2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
