[Bug 1421605] Container Review Request: nginx - Platform for running nginx or building nginx-based application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421605

Pavel Zhukov  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+
   |needinfo?(pzhu...@redhat.co |
   |m)  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478231] Review Request: conda - Cross-platform, Python-agnostic binary package manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478231

Robin Lee  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #9 from Robin Lee  ---
All patches should have an upstream bug link or comment 
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

(In reply to Zbigniew Jędrzejewski-Szmek from comment #8)
> SRPM URL: https://in.waw.pl/~zbyszek/fedora/conda-4.3.24-3.fc27.src.rpm
Should be https://in.waw.pl/~zbyszek/fedora/conda-4.3.24-3.fc28.src.rpm

[x]: Package functions as described.

This packages is approved by cheeselee.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483386] Review Request: php-pear-Archive-Tar - Tar file management class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483386

Shawn Iwinski  changed:

   What|Removed |Added

 Blocks||1483285 (drush_v9_tracking)
  Alias||php-pear-Archive-Tar




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1483285
[Bug 1483285] v9 tracking
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483386] New: Review Request: php-pear-Archive-Tar - Tar file management class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483386

Bug ID: 1483386
   Summary: Review Request: php-pear-Archive-Tar - Tar file
management class
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sh...@iwin.ski
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/40c05f3a44bfa5d77b77b250846c3c57e5a1d612/php-pear-Archive-Tar/php-pear-Archive-Tar.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-pear-Archive-Tar-1.4.3-1.fc26.src.rpm

Description:
This class provides handling of tar files in PHP.
It supports creating, listing, extracting and adding to tar files.
Gzip support is available if PHP has the zlib extension built-in or
loaded. Bz2 compression is also supported with the bz2 extension loaded.


Fedora Account System Username: siwinski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483384] Review Request: php-league-container - A fast and intuitive dependency injection container

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483384

Shawn Iwinski  changed:

   What|Removed |Added

 Blocks||1483285 (drush_v9_tracking)
  Alias||php-league-container




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1483285
[Bug 1483285] v9 tracking
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483384] New: Review Request: php-league-container - A fast and intuitive dependency injection container

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483384

Bug ID: 1483384
   Summary: Review Request: php-league-container - A fast and
intuitive dependency injection container
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sh...@iwin.ski
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/b1670e3e5238b253d16049481c62cec63e144a01/php-league-container/php-league-container.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-league-container-2.4.1-1.fc26.src.rpm

Description:
A small but powerful dependency injection container that allows you to decouple
components in your application in order to write clean and testable code.


Fedora Account System Username: siwinski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483383] New: Review Request: php-jakubledl-dissect - Lexing and parsing in pure PHP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483383

Bug ID: 1483383
   Summary: Review Request: php-jakubledl-dissect - Lexing and
parsing in pure PHP
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sh...@iwin.ski
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/8ca266f86e247ba4c0d9c2e626c095c45a53ff1f/php-jakubledl-dissect/php-jakubledl-dissect.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-jakubledl-dissect-1.0.1-1.fc26.src.rpm

Description:
Dissect is a set of tools for lexical and syntactical analysis written in pure
PHP.


Fedora Account System Username: siwinski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483383] Review Request: php-jakubledl-dissect - Lexing and parsing in pure PHP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483383

Shawn Iwinski  changed:

   What|Removed |Added

 Blocks||1483285 (drush_v9_tracking)
  Alias||php-jakubledl-dissect




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1483285
[Bug 1483285] v9 tracking
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483382] Review Request: php-henrikbjorn-lurker - Resource watcher

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483382

Shawn Iwinski  changed:

   What|Removed |Added

 Blocks||1483285 (drush_v9_tracking)
  Alias||php-henrikbjorn-lurker




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1483285
[Bug 1483285] v9 tracking
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483382] New: Review Request: php-henrikbjorn-lurker - Resource watcher

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483382

Bug ID: 1483382
   Summary: Review Request: php-henrikbjorn-lurker - Resource
watcher
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sh...@iwin.ski
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/410da37c1c10b4fd19128e07b8c4e26041b03624/php-henrikbjorn-lurker/php-henrikbjorn-lurker.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-henrikbjorn-lurker-1.2.0-1.fc26.src.rpm

Description:
Resource tracking for PHP. Watch files and/or directories.


Fedora Account System Username: siwinski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483381] Review Request: php-flow-jsonpath - JSONPath implementation for parsing, searching and flattening arrays

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483381

Shawn Iwinski  changed:

   What|Removed |Added

 Blocks||1483285 (drush_v9_tracking)
  Alias||php-flow-jsonpath




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1483285
[Bug 1483285] v9 tracking
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483381] New: Review Request: php-flow-jsonpath - JSONPath implementation for parsing, searching and flattening arrays

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483381

Bug ID: 1483381
   Summary: Review Request: php-flow-jsonpath - JSONPath
implementation for parsing, searching and flattening
arrays
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sh...@iwin.ski
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/5a9e431c5f7ebcba6b600bfd8fe8b01b28d5a739/php-flow-jsonpath/php-flow-jsonpath.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-flow-jsonpath-0.3.4-1.fc26.src.rpm

Description:
This is a JSONPath implementation for PHP based on Stefan Goessner's
JSONPath script.

JSONPath is an XPath-like expression language for filtering, flattening and
extracting data.

I believe that is improves on the original script (which was last updated in
2007) by doing a few things:
* Object-oriented code (should be easier to manage or extend in future)
* Expressions are parsed into tokens using some code cribbed from Doctrine
  Lexer and cached
* There is no eval() in use
* Performance is pretty much the same
* Any combination of objects/arrays/ArrayAccess-objects can be used as the data
  input which is great if you're de-serializing JSON in to objects or if you
  want to process your own data structures.


Fedora Account System Username: siwinski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483376] Review Request: php-dflydev-dot-access-data - Given a deep data structure, access data by dot notation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483376

Shawn Iwinski  changed:

   What|Removed |Added

 Blocks||1483379
   ||(php-grasmash-yaml-expander
   ||)
 Depends On|1483379 |
   |(php-grasmash-yaml-expander |
   |)   |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1483379
[Bug 1483379] Review Request: php-grasmash-yaml-expander - Expands internal
property references in a yaml file
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483379] Review Request: php-grasmash-yaml-expander - Expands internal property references in a yaml file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483379

Shawn Iwinski  changed:

   What|Removed |Added

 Blocks|1483376 |
   |(php-dflydev-dot-access-dat |
   |a)  |
 Depends On||1483376
   ||(php-dflydev-dot-access-dat
   ||a)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1483376
[Bug 1483376] Review Request: php-dflydev-dot-access-data - Given a deep
data structure, access data by dot notation
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483379] New: Review Request: php-grasmash-yaml-expander - Expands internal property references in a yaml file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483379

Bug ID: 1483379
   Summary: Review Request: php-grasmash-yaml-expander - Expands
internal property references in a yaml file
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sh...@iwin.ski
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/420ae813f2e726e9262a99714797729efacd4529/php-grasmash-yaml-expander/php-grasmash-yaml-expander.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-grasmash-yaml-expander-1.1.1-1.fc26.src.rpm

Description:
Expands internal property references in a yaml file


Fedora Account System Username: siwinski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483379] Review Request: php-grasmash-yaml-expander - Expands internal property references in a yaml file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483379

Shawn Iwinski  changed:

   What|Removed |Added

 Blocks||1483285
   ||(drush_v9_tracking),
   ||1483376
   ||(php-dflydev-dot-access-dat
   ||a)
  Alias||php-grasmash-yaml-expander




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1483285
[Bug 1483285] v9 tracking
https://bugzilla.redhat.com/show_bug.cgi?id=1483376
[Bug 1483376] Review Request: php-dflydev-dot-access-data - Given a deep
data structure, access data by dot notation
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483376] Review Request: php-dflydev-dot-access-data - Given a deep data structure, access data by dot notation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483376

Shawn Iwinski  changed:

   What|Removed |Added

 Depends On||1483379
   ||(php-grasmash-yaml-expander
   ||)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1483379
[Bug 1483379] Review Request: php-grasmash-yaml-expander - Expands internal
property references in a yaml file
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483376] Review Request: php-dflydev-dot-access-data - Given a deep data structure, access data by dot notation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483376

Shawn Iwinski  changed:

   What|Removed |Added

 Blocks||1483285 (drush_v9_tracking)
  Alias||php-dflydev-dot-access-data




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1483285
[Bug 1483285] v9 tracking
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483376] New: Review Request: php-dflydev-dot-access-data - Given a deep data structure, access data by dot notation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483376

Bug ID: 1483376
   Summary: Review Request: php-dflydev-dot-access-data - Given a
deep data structure, access data by dot notation
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sh...@iwin.ski
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/2f2a478860d610129105b8d48989e4c84005325b/php-dflydev-dot-access-data/php-dflydev-dot-access-data.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-dflydev-dot-access-data-1.1.0-2.fc26.src.rpm

Description:
Given a deep data structure, access data by dot notation


Fedora Account System Username: siwinski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483375] Review Request: php-consolidation-log - Improved Psr-3 / Psr\Log logger based on Symfony Console components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483375

Shawn Iwinski  changed:

   What|Removed |Added

 Blocks||1483285 (drush_v9_tracking)
  Alias||php-consolidation-log




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1483285
[Bug 1483285] v9 tracking
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483375] New: Review Request: php-consolidation-log - Improved Psr-3 / Psr\Log logger based on Symfony Console components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483375

Bug ID: 1483375
   Summary: Review Request: php-consolidation-log - Improved Psr-3
/ Psr\Log logger based on Symfony Console components
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sh...@iwin.ski
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/f16870cc756c20f88e5449b723e7b93a2d1df8ed/php-consolidation-log/php-consolidation-log.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-consolidation-log-1.0.3-2.fc26.src.rpm

Description:
Consolidation\Log provides a Psr-3 compatible logger that provides styled log
output to the standard error (stderr) stream. By default, styling is provided
by the SymfonyStyle class from the Symfony Console component; however,
alternative stylers may be provided if desired.


Fedora Account System Username: siwinski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483374] New: Review Request: php-codeception-verify - BDD assertion library for PHPUnit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483374

Bug ID: 1483374
   Summary: Review Request: php-codeception-verify - BDD assertion
library for PHPUnit
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sh...@iwin.ski
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/27d9ebd1234ff0da8f74c06ef9ff6e962c93d1ae/php-codeception-verify/php-codeception-verify.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-codeception-verify-0.4.0-1.fc26.src.rpm

Description:
BDD Assertions for PHPUnit and Codeception

This is very tiny wrapper for PHPUnit assertions, that are aimed to make tests
a bit more readable. With BDD assertions influenced by Chai, Jasmine, and
RSpec your assertions would be a bit closer to natural language.


Fedora Account System Username: siwinski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483374] Review Request: php-codeception-verify - BDD assertion library for PHPUnit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483374

Shawn Iwinski  changed:

   What|Removed |Added

 Blocks||1483285 (drush_v9_tracking)
  Alias||php-codeception-verify




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1483285
[Bug 1483285] v9 tracking
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483373] Review Request: php-codeception-specify - BDD code blocks for PHPUnit and Codeception

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483373

Shawn Iwinski  changed:

   What|Removed |Added

 Blocks||1483285 (drush_v9_tracking)
  Alias||php-codeception-specify




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1483285
[Bug 1483285] v9 tracking
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483373] New: Review Request: php-codeception-specify - BDD code blocks for PHPUnit and Codeception

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483373

Bug ID: 1483373
   Summary: Review Request: php-codeception-specify - BDD code
blocks for PHPUnit and Codeception
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sh...@iwin.ski
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/c11ef7058ab8bafa3da347a15612041366bcd5bd/php-codeception-specify/php-codeception-specify.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-codeception-specify-0.4.6-1.fc26.src.rpm

Description:
BDD style code blocks for PHPUnit / Codeception

Specify allows you to write your tests in more readable BDD style, the
same way you might have experienced with Jasmine. Inspired by MiniTest
of Ruby now you combine BDD and classical TDD style in one test.


Fedora Account System Username: siwinski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483372] Review Request: php-behat-gherkin - Gherkin DSL parser for PHP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483372

Shawn Iwinski  changed:

   What|Removed |Added

 Blocks||1483285 (drush_v9_tracking)
  Alias||php-behat-gherkin




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1483285
[Bug 1483285] v9 tracking
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483372] New: Review Request: php-behat-gherkin - Gherkin DSL parser for PHP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483372

Bug ID: 1483372
   Summary: Review Request: php-behat-gherkin - Gherkin DSL parser
for PHP
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sh...@iwin.ski
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/77ac598c9dda3d43839762d3b6a4a7cc2462648d/php-behat-gherkin/php-behat-gherkin.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-behat-gherkin-4.4.5-1.fc26.src.rpm

Description:
Gherkin DSL parser for PHP


Fedora Account System Username: siwinski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475791] Review Request: golang-github-VividCortex-ewma - Exponentially Weighted Moving Average algorithms for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475791

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
golang-github-VividCortex-ewma-1.1.1-1.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f62d7b0d87

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475817] Review Request: golang-github-jlaffaye-ftp - A FTP client package for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475817

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
golang-github-jlaffaye-ftp-0-0.1.20170721git769512c.fc25 has been pushed to the
Fedora 25 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-632bb49bf2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474958] Review Request: lammps - Large-scale Atomic/ Molecular Massively Parallel Simulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474958



--- Comment #23 from Fedora Update System  ---
lammps-20170811-5.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f348e9d287

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476201

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
qdirstat-1.4-3.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a546993ca7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475763] Review Request: golang-github-Unknwon-goconfig - Configuration file parser for the Go Programming Language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475763

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
golang-github-Unknwon-goconfig-0-0.1.20161121git87a46d9.fc25 has been pushed to
the Fedora 25 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a916bfeaee

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1482205] Review Request: syncthing-gtk - Syncthing GTK+ GUI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1482205

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
syncthing-gtk-0.9.2.5-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b7760f8e52

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483203] Review Request: fzf - A command-line fuzzy finder written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483203



--- Comment #2 from Elliott Sales de Andrade  ---
Thanks for the reviews; I was not expecting them to be so quick! Here is an
updated spec that installs the binaries as well as some of the other niceties
that fzf provides.


Spec URL:
https://copr-be.cloud.fedoraproject.org/results/qulogic/fzf/fedora-rawhide-x86_64/00592070-fzf/fzf.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/qulogic/fzf/fedora-rawhide-x86_64/00592070-fzf/fzf-0.16.11-3.src.rpm
Description: A command-line fuzzy finder written in Go
Fedora Account System Username: qulogic

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483202] Review Request: golang-github-mattn-go-shellwords - Parse line as shell words

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483202



--- Comment #4 from Elliott Sales de Andrade  ---
Yes, I determined the same thing when working on the fzf package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474958] Review Request: lammps - Large-scale Atomic/ Molecular Massively Parallel Simulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474958

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #22 from Fedora Update System  ---
lammps-20170811-5.el7 has been pushed to the Fedora EPEL 7 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-628075ea93

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404895] Review Request: partclone - File System Clone Utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404895



--- Comment #25 from Fedora Update System  ---
partclone-0.3.5a-3.el7 has been pushed to the Fedora EPEL 7 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-0bfdb723ff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404895] Review Request: partclone - File System Clone Utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404895

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #24 from Fedora Update System  ---
partclone-0.3.5a-3.el6 has been pushed to the Fedora EPEL 6 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-dd1fbf8208

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481477] Review Request: greenwave - Service for gating on automated tests by querying ResultsDB and WaiverDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481477



--- Comment #3 from Fedora Update System  ---
greenwave-0.1-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-fbe38da88c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481477] Review Request: greenwave - Service for gating on automated tests by querying ResultsDB and WaiverDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481477

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431546] Container Review Request: python3 - Platform for building and running Python 3.5 applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431546

Honza Horak  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NOTABUG
Last Closed||2017-08-20 18:42:32



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421605] Container Review Request: nginx - Platform for running nginx or building nginx-based application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421605

Honza Horak  changed:

   What|Removed |Added

  Flags||needinfo?(pzhu...@redhat.co
   ||m)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421605] Container Review Request: nginx - Platform for running nginx or building nginx-based application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421605

Honza Horak  changed:

   What|Removed |Added

  Flags|fedora-review+  |fedora-review?



--- Comment #12 from Honza Horak  ---
Pavel, the fedrepo-req seems to be fixed, but it complains that "Error: The
Bugzilla ticket's review was approved over 60 days ago".. So, please,
re-approve this request.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1482997] Review Request: prename - Perl script to rename multiple files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1482997



--- Comment #3 from Robert-André Mauchin  ---
My bad

SPEC URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/prename/fedora-rawhide-x86_64/00591541-prename/prename.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/prename/fedora-rawhide-x86_64/00591541-prename/prename-1.9-4.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1482997] Review Request: prename - Perl script to rename multiple files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1482997



--- Comment #2 from Ben Rosser  ---
> SRPM URL: 
> https://copr-be.cloud.fedoraproject.org/results/eclipseo/prename/fedora-rawhide-x86_64/00591541-prename/prename-1.9-4.fc27.noarch.rpm

Uh, this isn't actually the SRPM, this is the actual RPM.

Since it's all pulled from copr, I assume
https://copr-be.cloud.fedoraproject.org/results/eclipseo/prename/fedora-rawhide-x86_64/00591541-prename/prename-1.9-4.fc27.src.rpm
is the corresponding SRPM?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481775] Review Request: python-jep - Embed Python in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481775



--- Comment #4 from Kevin Fenzi  ---
1. There's 2 jar files in the tests directory that are provided from 
the upstream source. These should be removed before the build and any
tests that need them disabled. 

2. Should javadoc be made with this package? It's optional, but 
you might want to see if it's worthwhile. 
http://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation

3. IMHO The python-jep package should be python2-jep (if you are making 
the python2 version, which it looks like you are not?) 

4. The /usr/bin/jep file should be in both python2 and python3 
subpackages, or only the python3 one if you are only shipping that 
version. Right now someone could install python3-jep and have no 
bin to run. 

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
  Note: No javadoc subpackage present
  See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
- Javadoc documentation files are generated and included in -javadoc
  subpackage
  Note: No javadoc subpackage present. Note: Javadocs are optional for
  Fedora versions >= 21
  See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
- Bundled jar/class files should be removed before build
  Note: Jar files in source (see attachment)
  See: http://fedoraproject.org/wiki/Packaging:Java#Pre-
  built_JAR_files_.2F_Other_bundled_software'


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "zlib/libpng". 137 files have unknown
 license. Detailed output of licensecheck in /home/kevin/1481775
 -python-jep/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make 

[Bug 1481608] Review Request: python-django-macros - Macros for Django templates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481608



--- Comment #2 from Göran Uddeborg  ---
Thank you for your feedback!

I've changed to using the pyX_dist macros.  Adding "%check" work took a bit
more.  It seems the tests weren't quite compatible with current Django.  But
now it builds, and an upstreams report is created.

Spec URL:
ftp://ftp.uddeborg.se/pub/python-django-macros/v2/python-django-macros.spec
SRPM URL:
ftp://ftp.uddeborg.se/pub/python-django-macros/v2/python-django-macros-0.4.0-2.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483297] Review Request: deepin-control-center - New control center for Linux Deepin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483297



--- Comment #2 from sensor@gmail.com ---
SPEC: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00592000-deepin-control-center/deepin-control-center.spec
SRPM: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00592000-deepin-control-center/deepin-control-center-4.2.5.4-1.fc25.src.rpm

Fixed it. Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483308] Review Request: pgzero - A zero-boilerplate 2D games framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483308

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
Hello,

 - I think you should add the "examples/" to the %doc.

 - You should add a more meaningful name to the downloaded archive, with:

Source0:   
https://bitbucket.org/lordmauve/%{name}/get/%{version}.tar.gz#/%{name}-%{version}.tar.gz

 - We've got several license here, you must add them all in the License: tag
and detail which covers what part.

*No copyright* Apache (v2.0)

lordmauve-pgzero-de127c76f809/examples/basic/fonts/Cherry_Cream_Soda/LICENSE.txt
lordmauve-pgzero-de127c76f809/examples/basic/fonts/Roboto_Condensed/LICENSE.txt

*No copyright* CC by-sa (v4.0)
--
lordmauve-pgzero-de127c76f809/examples/lander/lander.py

CC0
---
lordmauve-pgzero-de127c76f809/examples/basic/fonts/bubblegum_sans.ttf

LGPL (v3)

lordmauve-pgzero-de127c76f809/COPYING

MIT/X11 (BSD like)
--
lordmauve-pgzero-de127c76f809/examples/memory/LICENCE

SIL (v1.1)
--
lordmauve-pgzero-de127c76f809/examples/basic/fonts/Boogaloo/OFL.txt
lordmauve-pgzero-de127c76f809/examples/basic/fonts/Bubblegum_Sans/OFL.txt

See https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses
for a list of valid license shortname. For example SIL license shortname is OFL
and Apache → ASL 2.0.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483296] Review Request: deepin-dock - Deepin desktop environment Dock module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483296



--- Comment #2 from sensor@gmail.com ---
SPEC: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00591996-deepin-dock/deepin-dock.spec
SRPM: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00591996-deepin-dock/deepin-dock-4.3.4-1.fc25.src.rpm

Fixed it. Thanks
We need to review dtkwidget first. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404895] Review Request: partclone - File System Clone Utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404895

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-08-20 14:29:02



--- Comment #23 from Fedora Update System  ---
partclone-0.3.5a-3.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476596] Review Request: dtkwidget - Deepin tool kit widget modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476596

sensor@gmail.com changed:

   What|Removed |Added

 Blocks||1483296




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1483296
[Bug 1483296] Review Request: deepin-dock - Deepin desktop environment Dock
module
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483296] Review Request: deepin-dock - Deepin desktop environment Dock module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483296

sensor@gmail.com changed:

   What|Removed |Added

 Depends On||1476596




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1476596
[Bug 1476596] Review Request: dtkwidget - Deepin tool kit widget modules
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483296] Review Request: deepin-dock - Deepin desktop environment Dock module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483296

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
Hello,

Some similar issues as before:

 - You must post both SPEC URL and SRPM URL. It's used by fedora review to
fetch the files from a bug number.
 - The latest version is 4.3.4, not 4.3.3
 - Just use: %global repo dde-dock , no need for project
 - The changelog version is incorrect, you shouldn't include the git revision
for a stable release
 - Why did you add a Provides and Obsoletes, this doesn't seem useful since
it's not a renamed package.
 - Removes the Requires which are commented
 - Use pkgconfig where you can:

BuildRequires:  pkgconfig(dtkbase)
BuildRequires:  pkgconfig(dframeworkdbus)
BuildRequires:  pkgconfig(gsettings-qt)
BuildRequires:  pkgconfig(gtk+-2.0)
BuildRequires:  pkgconfig(xtst)
BuildRequires:  qt5-linguist
BuildRequires:  pkgconfig(Qt5)
BuildRequires:  pkgconfig(Qt5X11Extras)
BuildRequires:  pkgconfig(Qt5Svg)
BuildRequires:  pkgconfig(xcb-ewmh)
BuildRequires:  pkgconfig(xcb-image)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483339] New: Review Request: python-kiwi - A flexible operating system image builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483339

Bug ID: 1483339
   Summary: Review Request: python-kiwi - A flexible operating
system image builder
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ngomp...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://copr-be.cloud.fedoraproject.org/results/ngompa/KIWI/fedora-rawhide-x86_64/00591985-python-kiwi/python-kiwi.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/ngompa/KIWI/fedora-rawhide-x86_64/00591985-python-kiwi/python-kiwi-9.10.4-0.fc28.1.src.rpm

Description:
The KIWI Image System provides an operating system image builder
for Linux supported hardware platforms as well as for virtualization
and cloud systems like Xen, KVM, VMware, EC2 and more.

Fedora Account System Username: ngompa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476596] Review Request: dtkwidget - Deepin tool kit widget modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476596



--- Comment #2 from sensor@gmail.com ---
SPEC: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00591987-dtkwidget/dtkwidget.spec
SRPM: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00591987-dtkwidget/dtkwidget-2.0.0-1.fc25.src.rpm

Updated to latest version (2.0.0).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431420] Review Request: python-agate - Data analysis library that is optimized for humans instead of machines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431420



--- Comment #2 from Terje Røsten  ---
Package fails to build: 

 https://koji.fedoraproject.org/koji/taskinfo?taskID=21359176

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431420] Review Request: python-agate - Data analysis library that is optimized for humans instead of machines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431420

Terje Røsten  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #1 from Terje Røsten  ---
I prefer to use source urls like:

 https://files.pythonhosted.org/packages/source/a/agate/agate-1.6.0.tar.gz

makes things simpler or?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431420] Review Request: python-agate - Data analysis library that is optimized for humans instead of machines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431420

Terje Røsten  changed:

   What|Removed |Added

 CC||terje...@phys.ntnu.no
   Assignee|nob...@fedoraproject.org|terje...@phys.ntnu.no



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431420] Review Request: python-agate - Data analysis library that is optimized for humans instead of machines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431420

Terje Røsten  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483297] Review Request: deepin-control-center - New control center for Linux Deepin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483297

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com
 Depends On||1483296



--- Comment #1 from Robert-André Mauchin  ---
Hello,

Some similar issues as before:

 - You must post both SPEC URL and SRPM URL. It's used by fedora review to
fetch the files from a bug number.
 - The latest version is 4.2.5.4, not 4.2.5
 - Just use: %global repo dde-control-center , no need for %project
 - Use pkgconfig where you can:

BuildRequires:  pkgconfig(dtkbase)
BuildRequires:  deepin-dock-devel
BuildRequires:  pkgconfig(dframeworkdbus)
BuildRequires:  pkgconfig(gsettings-qt)
BuildRequires:  pkgconfig(geoip)
BuildRequires:  qt5-linguist
BuildRequires:  pkgconfig(Qt5)
BuildRequires:  pkgconfig(Qt5Svg)
BuildRequires:  pkgconfig(Qt5Multimedia)
BuildRequires:  pkgconfig(Qt5X11Extras)

 - You forgot to do the desktop-file validation:

%check
desktop-file-validate %{buildroot}/%{_datadir}/applications/%{repo}.desktop

 - Need deepin-dock-devel, so I'm adding a dependency on #1483296


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1483296
[Bug 1483296] Review Request: deepin-dock - Deepin desktop environment Dock
module
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483296] Review Request: deepin-dock - Deepin desktop environment Dock module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483296

Robert-André Mauchin  changed:

   What|Removed |Added

 Blocks||1483297




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1483297
[Bug 1483297] Review Request: deepin-control-center - New control center
for Linux Deepin
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483298] Review Request: deepin-launcher - Deepin desktop-environment Launcher module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483298

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
Hello,

Some similar issues as before:

 - You must post both SPEC URL and SRPM URL. It's used by fedora review to
fetch the files from a bug number.
 - The latest version is 4.1.7, not 4.1.6
 - Just use: %global repo dde-launcher
 - Use pkgconfig where you can:

BuildRequires:  pkgconfig(dtkbase)
BuildRequires:  pkgconfig(dframeworkdbus)
BuildRequires:  pkgconfig(gsettings-qt)
BuildRequires:  pkgconfig(gtk+-2.0)
BuildRequires:  qt5-linguist
BuildRequires:  pkgconfig(Qt5)
BuildRequires:  pkgconfig(Qt5Svg)
BuildRequires:  pkgconfig(Qt5X11Extras)
BuildRequires:  pkgconfig(xcb-ewmh)

 - If you install icons your must run the scriptlets described in this section:
https://fedoraproject.org/wiki/Packaging:Scriptlets#Icon_Cache
 You also need to add a: Requires:   hicolor-icon-theme

 - I wasn't able to build the project because it seems a BR is missing:

Project ERROR: dtkcore development package not found

Have you packaged this yet? https://github.com/linuxdeepin/dtkcore

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483300] Review Request: deepin-qt5integration - Qt platform theme integration plugins for DDE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483300

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
Hello,

You need to post both the SPEC URL: and the SRPM URL.

You should use pkg config for your BR. Here is the full list:

BuildRequires:  pkgconfig(dbus-1)
BuildRequires:  pkgconfig(dtkbase)
BuildRequires:  pkgconfig(egl)
BuildRequires:  pkgconfig(gl)
BuildRequires:  pkgconfig(Qt5OpenGLExtensions)
BuildRequires:  pkgconfig(Qt5Svg)
BuildRequires:  pkgconfig(Qt5X11Extras)
BuildRequires:  pkgconfig(Qt5Xdg)
BuildRequires:  pkgconfig(ice)
BuildRequires:  pkgconfig(sm)
BuildRequires:  pkgconfig(x11)
BuildRequires:  pkgconfig(xext)
BuildRequires:  pkgconfig(xi)
BuildRequires:  pkgconfig(xrender)
BuildRequires:  pkgconfig(atk)
BuildRequires:  pkgconfig(cairo)
BuildRequires:  pkgconfig(fontconfig)
BuildRequires:  pkgconfig(freetype2)
BuildRequires:  pkgconfig(gtk+-2.0)
BuildRequires:  pkgconfig(glib-2.0)
BuildRequires:  pkgconfig(gdk-pixbuf-2.0)
BuildRequires:  pkgconfig(libinput)
BuildRequires:  pkgconfig(mtdev)
BuildRequires:  pkgconfig(pango)
BuildRequires:  pkgconfig(xcb-ewmh)
BuildRequires:  pkgconfig(xcb-image)
BuildRequires:  pkgconfig(xcb-keysyms)
BuildRequires:  pkgconfig(xcb-renderutil)
BuildRequires:  pkgconfig(xcb)
BuildRequires:  pkgconfig(xkbcommon-x11)
BuildRequires:  pkgconfig(xkbcommon)

 - You need to package the latest version, which is 0.2.3, not 0.2.1.

 - The version in your changelog is wront, you don't need .git2cd7432 if you're
packaging a stable release, it's only for development snapshot.

 - I don't get why you define two times the same variable under different
names:
%global project qt5integration
%global repo %{project}

  Just keep: %global repo qt5integration

 - There are parts of the code which are not under GPLv3:

BSD (3 clause)
--
qt5integration-0.2.3/styles/main.cpp
qt5integration-0.2.3/styles/norwegianwoodstyle.cpp
qt5integration-0.2.3/styles/norwegianwoodstyle.h
qt5integration-0.2.3/styles/widgetgallery.cpp
qt5integration-0.2.3/styles/widgetgallery.h

GPL (v3 or later)
-
qt5integration-0.2.3/dstyleplugin/colorutils.cpp
qt5integration-0.2.3/dstyleplugin/colorutils.h
qt5integration-0.2.3/dstyleplugin/comboboxhelper.cpp
qt5integration-0.2.3/dstyleplugin/common.h
qt5integration-0.2.3/dstyleplugin/commonhelper.cpp
qt5integration-0.2.3/dstyleplugin/commonhelper.h
qt5integration-0.2.3/dstyleplugin/dstyleplugin.cpp
qt5integration-0.2.3/dstyleplugin/dstyleplugin.h
qt5integration-0.2.3/dstyleplugin/framehelper.cpp
qt5integration-0.2.3/dstyleplugin/geometryutils.cpp
qt5integration-0.2.3/dstyleplugin/geometryutils.h
qt5integration-0.2.3/dstyleplugin/lineedithelper.cpp
qt5integration-0.2.3/dstyleplugin/paletteextended.cpp
qt5integration-0.2.3/dstyleplugin/paletteextended.h
qt5integration-0.2.3/dstyleplugin/progressbarhelper.cpp
qt5integration-0.2.3/dstyleplugin/pushbuttonhelper.cpp
qt5integration-0.2.3/dstyleplugin/sliderhelper.cpp
qt5integration-0.2.3/dstyleplugin/style.cpp
qt5integration-0.2.3/dstyleplugin/style.h
qt5integration-0.2.3/platformplugin/dforeignplatformwindow.h
qt5integration-0.2.3/platformplugin/dforeignplatformwindow_x11.cpp
qt5integration-0.2.3/platformplugin/dframewindow.cpp
qt5integration-0.2.3/platformplugin/dframewindow.h
qt5integration-0.2.3/platformplugin/dplatformbackingstorehelper.cpp
qt5integration-0.2.3/platformplugin/dplatformbackingstorehelper.h
qt5integration-0.2.3/platformplugin/dplatformopenglcontexthelper.cpp
qt5integration-0.2.3/platformplugin/dplatformopenglcontexthelper.h
qt5integration-0.2.3/platformplugin/dplatformwindowhelper.cpp
qt5integration-0.2.3/platformplugin/dplatformwindowhelper.h
qt5integration-0.2.3/platformplugin/dwmsupport.h
qt5integration-0.2.3/platformplugin/windoweventhook.cpp
qt5integration-0.2.3/platformplugin/windoweventhook.h

LGPL (v2.1 or v3)
-
qt5integration-0.2.3/dstyleplugin/dstyleanimation.cpp
qt5integration-0.2.3/dstyleplugin/dstyleanimation.h
qt5integration-0.2.3/platformplugin/main.cpp

MIT/X11 (BSD like)
--
qt5integration-0.2.3/platformplugin/LICENSE


Please add them in the Licence: tag and add a comment detailing which licenses
cover which parts of the code.


 - During the build of your package, it requires an Internet access to git
clone a repository. You won't be able to do this on Koji because networking is
disabled, you'll get the following error:

Checking for dtkwidget... Cloning into 'libqt5xcbqpa-dev'...
fatal: unable to access 'https://cr.deepin.io/libqt5xcbqpa-dev/': Could not
resolve host: 

[Bug 1480971] Review Request: golang-github-alecthomas-assert - Fork of stretchr/testify/ assert that uses FailNow

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480971



--- Comment #6 from sensor@gmail.com ---
The golang-github-alecthomas-colour is build passd.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480971] Review Request: golang-github-alecthomas-assert - Fork of stretchr/testify/ assert that uses FailNow

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480971



--- Comment #5 from Robert-André Mauchin  ---
You still need to build golang-github-alecthomas-colour in Koji, the other two
are there. I'll review asap when it's included.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476596] Review Request: dtkwidget - Deepin tool kit widget modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476596



--- Comment #1 from Robin Lee  ---
Please update to the latest version (2.0.0)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1419330] Review Request: deepin-menu - deepin menu service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1419330



--- Comment #18 from Robin Lee  ---
Please update to the lastest version (3.1.6)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479967] Review Request: fritzing-parts - Parts library for the Fritzing electronic design application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479967



--- Comment #9 from mpr...@redhat.com  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.stg.fedoraproject.org/rpms/fritzing-parts

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479967] Review Request: fritzing-parts - Parts library for the Fritzing electronic design application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479967

mpr...@redhat.com  changed:

   What|Removed |Added

 CC||mpr...@redhat.com



--- Comment #10 from mpr...@redhat.com  ---
Please ignore the above comment. That was just testing in staging.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480962] Review Request: golang-github-disintegration-imaging - Simple Go image processing package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480962



--- Comment #2 from Robert-André Mauchin  ---
golang-googlecode-image is approved but still not built in Koji, so I can't use
fedora-review yet to check if it builds.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483202] Review Request: golang-github-mattn-go-shellwords - Parse line as shell words

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483202

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
Not an issue per se but i would strongly prefer if you kept the original commit
here instead of putting the version:

%global commit  9858af9cca4c73576f0b8c6609a396eb0878023c

And then change Source0 to:

Source0:   
https://%{provider_prefix}/archive/v%{version}/%{repo}-%{version}.tar.gz

Otherwise commit, and shortcommit which is based upon it, won't reflect correct
values, even if it "works".

Otherwise it's good, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483308] New: Review Request: pgzero - A zero-boilerplate 2D games framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483308

Bug ID: 1483308
   Summary: Review Request: pgzero - A zero-boilerplate 2D games
framework
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: lbal...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://lbalhar.fedorapeople.org/pgzero.spec
SRPM URL: https://lbalhar.fedorapeople.org/pgzero-1.1-1.fc26.src.rpm
Description: Pygame Zero A zero boilerplate games programming framework for
Python 3, based on Pygame. Pygame Zero consists of a runner pgzrun that will
run a Pygame Zero script with a full game loop and a range of useful builtins.
Fedora Account System Username: lbalhar

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=21350130

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481604] Review Request: octave-interval - Interval arithmetic for Octave

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481604

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Robert-André Mauchin  ---
All good. Package accepted.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "*No copyright* LGPL (v2 or later)", "GPL (v3)", "GPL (v3 or
 later)", "Unknown or generated", "Apache GPL", "MIT/X11 (BSD like)",
 "*No copyright* Apache", "Apache (v2.0) GPL (v3 or later)", "LGPL (v2
 or later)", "LGPL (v2.1 or later)", "FSF All Permissive". 260 files
 have unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/octave-interval/review-octave-
 interval/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in octave-
 interval-debuginfo
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from 

[Bug 1480962] Review Request: golang-github-disintegration-imaging - Simple Go image processing package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480962



--- Comment #1 from sensor@gmail.com ---
The golang-googlecode-image package was approved. So this package can begin to
be  reviewed. @zebob

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483297] Review Request: deepin-control-center - New control center for Linux Deepin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483297

sensor@gmail.com changed:

   What|Removed |Added

 Blocks||1465889
   ||(DeepinDEPackageReview)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1465889
[Bug 1465889] Tracking: Deepin Desktop related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465889] Tracking: Deepin Desktop related package review tracker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465889

sensor@gmail.com changed:

   What|Removed |Added

 Depends On||1483296, 1483297, 1483298,
   ||1483300




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1483296
[Bug 1483296] Review Request: deepin-dock - Deepin desktop environment Dock
module
https://bugzilla.redhat.com/show_bug.cgi?id=1483297
[Bug 1483297] Review Request: deepin-control-center - New control center
for Linux Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1483298
[Bug 1483298] Review Request: deepin-launcher - Deepin desktop-environment
Launcher module
https://bugzilla.redhat.com/show_bug.cgi?id=1483300
[Bug 1483300] Review Request: deepin-qt5integration - Qt platform theme
integration plugins for DDE
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483298] Review Request: deepin-launcher - Deepin desktop-environment Launcher module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483298

sensor@gmail.com changed:

   What|Removed |Added

 Blocks||1465889
   ||(DeepinDEPackageReview)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1465889
[Bug 1465889] Tracking: Deepin Desktop related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483296] Review Request: deepin-dock - Deepin desktop environment Dock module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483296

sensor@gmail.com changed:

   What|Removed |Added

 Blocks||1465889
   ||(DeepinDEPackageReview)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1465889
[Bug 1465889] Tracking: Deepin Desktop related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483300] Review Request: deepin-qt5integration - Qt platform theme integration plugins for DDE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483300

sensor@gmail.com changed:

   What|Removed |Added

 Blocks||1465889
   ||(DeepinDEPackageReview)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1465889
[Bug 1465889] Tracking: Deepin Desktop related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483300] New: Review Request: deepin-qt5integration - Qt platform theme integration plugins for DDE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483300

Bug ID: 1483300
   Summary: Review Request: deepin-qt5integration - Qt platform
theme integration plugins for DDE
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: sensor@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec:
https://raw.githubusercontent.com/FZUG/repo/master/rpms/deepin_project/deepin-qt5integration.spec

Description: Qt platform theme integration plugins for DDE

Fedora Account System Username: mosquito

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483298] New: Review Request: deepin-launcher - Deepin desktop-environment Launcher module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483298

Bug ID: 1483298
   Summary: Review Request: deepin-launcher - Deepin
desktop-environment Launcher module
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: sensor@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec:
https://raw.githubusercontent.com/FZUG/repo/master/rpms/deepin_project/deepin-launcher.spec

Description: Deepin desktop-environment Launcher module

Fedora Account System Username: mosquito

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483297] New: Review Request: deepin-control-center - New control center for Linux Deepin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483297

Bug ID: 1483297
   Summary: Review Request: deepin-control-center - New control
center for Linux Deepin
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: sensor@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec:
https://raw.githubusercontent.com/FZUG/repo/master/rpms/deepin_project/deepin-control-center.spec

Description: New control center for Linux Deepin

Fedora Account System Username: mosquito

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1483296] New: Review Request: deepin-dock - Deepin desktop environment Dock module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1483296

Bug ID: 1483296
   Summary: Review Request: deepin-dock - Deepin desktop
environment Dock module
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: sensor@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec:
https://raw.githubusercontent.com/FZUG/repo/master/rpms/deepin_project/deepin-dock.spec

Description: Deepin desktop environment Dock module

Fedora Account System Username: mosquito

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476595] Review Request: dtkcore - Deepin tool kit core modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476595

sensor@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|POST



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org