[Bug 1487891] Review Request: ghc-feed - Interfacing with RSS (v 0.9x, 2.x , 1.0) + Atom feeds
https://bugzilla.redhat.com/show_bug.cgi?id=1487891 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #7 from Robert-André Mauchin --- Everything is good, package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488093] Review Request: krbcontext - A Kerberos context manager
https://bugzilla.redhat.com/show_bug.cgi?id=1488093 --- Comment #2 from c...@redhat.com --- Hi, please review again. This time, I created a new dedicated project in Fedora Copr for package review. SPEC URL: https://copr-be.cloud.fedoraproject.org/results/cqi/krbcontext-package-review/fedora-26-x86_64/00598427-python-krbcontext/python-krbcontext.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/cqi/krbcontext-package-review/fedora-26-x86_64/00598427-python-krbcontext/python-krbcontext-0.7-1.fc26.src.rpm Fixed issues you pointed out above. Regarding the work keytab, I would like to keep it as that is a term in Kerberos and it is also mentioned in various Kerberos documentation. Thank you very much for your review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487611] Review Request: dontpanic - Very simple library and executable used in testing Alien:: Base
https://bugzilla.redhat.com/show_bug.cgi?id=1487611 Petr Pisar changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||dontpanic-1.00-1.fc28 Resolution|--- |RAWHIDE Last Closed||2017-09-05 02:37:42 --- Comment #9 from Petr Pisar --- Thank you for the review and the repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487632] Review Request: perl-Acme-Alien-DontPanic - Test module for Alien::Base
https://bugzilla.redhat.com/show_bug.cgi?id=1487632 Bug 1487632 depends on bug 1487611, which changed state. Bug 1487611 Summary: Review Request: dontpanic - Very simple library and executable used in testing Alien::Base https://bugzilla.redhat.com/show_bug.cgi?id=1487611 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1485975] Review Request: rubygem-activestorage - Attach cloud and local files in Rails applications
https://bugzilla.redhat.com/show_bug.cgi?id=1485975 Vít Ondruch changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||rubygem-activestorage-0.1-1 ||.fc28 Resolution|--- |RAWHIDE Last Closed||2017-09-05 02:05:33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487891] Review Request: ghc-feed - Interfacing with RSS (v 0.9x, 2.x , 1.0) + Atom feeds
https://bugzilla.redhat.com/show_bug.cgi?id=1487891 --- Comment #6 from Elliott Sales de Andrade --- Sorry, didn't see that. Spec URL: https://qulogic.fedorapeople.org/git-annex/ghc-feed.spec SRPM URL: https://qulogic.fedorapeople.org/git-annex/ghc-feed-1.0.0.0-2.git.0.23e3aca.fc26.src.rpm Description: Interfacing with RSS (v 0.9x, 2.x, 1.0) + Atom feeds. To help working with the multiple feed formats we've ended up with, this set of modules provides parsers, pretty printers and some utility code for querying and just generally working with a concrete representation of feeds in Haskell. For basic reading and editing of feeds, consult the documentation of the Text.Feed.* hierarchy. koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21654587 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1485869] Review Request: compat-ImageMagick693 - Compat package with ImageMagick 6.9.3 libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1485869 Adam Williamson changed: What|Removed |Added CC||awill...@redhat.com --- Comment #11 from Adam Williamson --- "Discussion and idea from FESCo meeting." Can you please point to the meeting in question? I'm not clear on why this is really necessary. We rebuilt everything that depended on 6.9.3 along with the 6.9.9.9 updates, and included them in the updates. Does anything at all actually *need* this any more? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483499] Review Request: gnome-remote-desktop - Remote desktop server for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=1483499 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #18 from Fedora Update System --- gnome-remote-desktop-0.1.2-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d8232a4821 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1445923] Review Request: streameye - Simple MJPEG streamer for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1445923 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System --- streameye-0.8-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2919664de4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1246199] Review Request: rdopkg - RPM packaging automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1246199 --- Comment #16 from Neal Gompa --- Looks good to me at this point. That said, Haikel needs actually do the approval. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1485869] Review Request: compat-ImageMagick693 - Compat package with ImageMagick 6.9.3 libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1485869 Sergio Monteiro Basto changed: What|Removed |Added CC||ser...@serjux.com --- Comment #10 from Sergio Monteiro Basto --- Pete Walter, any particular reason to be ImageMagick 6.9.3 ABI compatibility package ? why not ImageMagick 6.9.6 ABI compatibility package for F27+ ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487966] Review Request: libcloudproviders - Library for desktop integration for cloud storage providers
https://bugzilla.redhat.com/show_bug.cgi?id=1487966 --- Comment #3 from Carlos Soriano --- Thanks Robert for the review, it's my first package so a little noobie here. I'll fix the spec and the upstream stuff tomorrow. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487505] Review Request: R-plyr - Tools for Splitting, Applying and Combining Data
https://bugzilla.redhat.com/show_bug.cgi?id=1487505 --- Comment #5 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-plyr -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487505] Review Request: R-plyr - Tools for Splitting, Applying and Combining Data
https://bugzilla.redhat.com/show_bug.cgi?id=1487505 Elliott Sales de Andrade changed: What|Removed |Added Assignee|nob...@fedoraproject.org|zebo...@gmail.com QA Contact|zebo...@gmail.com |extras...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488241] Review Request: mingw-python-qt5 - MinGW Windows PyQt5
https://bugzilla.redhat.com/show_bug.cgi?id=1488241 Sandro Mani changed: What|Removed |Added Depends On||1488244 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1488244 [Bug 1488244] Review Request: mingw-sip - MinGW Windows SIP -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487960] Review Request: mingw-python2 - MinGW Windows python2
https://bugzilla.redhat.com/show_bug.cgi?id=1487960 --- Comment #6 from Sandro Mani --- Thanks! Some followups, if you're still up for it ;) mingw-python-setuptools: https://bugzilla.redhat.com/show_bug.cgi?id=1488242 mingw-cython: https://bugzilla.redhat.com/show_bug.cgi?id=1488245 mingw-numpy: https://bugzilla.redhat.com/show_bug.cgi?id=1488240 mingw-sip: https://bugzilla.redhat.com/show_bug.cgi?id=1488244 mingw-python-qt5: https://bugzilla.redhat.com/show_bug.cgi?id=1488241 If you have anything I can review in exchange, even at some later time, please do ping me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488244] Review Request: mingw-sip - MinGW Windows SIP
https://bugzilla.redhat.com/show_bug.cgi?id=1488244 Sandro Mani changed: What|Removed |Added Blocks||1488241 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1488241 [Bug 1488241] Review Request: mingw-python-qt5 - MinGW Windows PyQt5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488245] Review Request: mingw-Cython - MinGW Windows Python cython library
https://bugzilla.redhat.com/show_bug.cgi?id=1488245 Sandro Mani changed: What|Removed |Added Blocks||1488240 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1488240 [Bug 1488240] Review Request: mingw-numpy - MinGW Windows Python numpy library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488242] Review Request: mingw-python-setuptools - MinGW Windows Python setuptools library
https://bugzilla.redhat.com/show_bug.cgi?id=1488242 Sandro Mani changed: What|Removed |Added Blocks||1488240 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1488240 [Bug 1488240] Review Request: mingw-numpy - MinGW Windows Python numpy library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488240] Review Request: mingw-numpy - MinGW Windows Python numpy library
https://bugzilla.redhat.com/show_bug.cgi?id=1488240 Sandro Mani changed: What|Removed |Added Depends On||1488242, 1488245 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1488242 [Bug 1488242] Review Request: mingw-python-setuptools - MinGW Windows Python setuptools library https://bugzilla.redhat.com/show_bug.cgi?id=1488245 [Bug 1488245] Review Request: mingw-Cython - MinGW Windows Python cython library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488245] Review Request: mingw-Cython - MinGW Windows Python cython library
https://bugzilla.redhat.com/show_bug.cgi?id=1488245 Sandro Mani changed: What|Removed |Added Depends On||1488242 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1488242 [Bug 1488242] Review Request: mingw-python-setuptools - MinGW Windows Python setuptools library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488242] Review Request: mingw-python-setuptools - MinGW Windows Python setuptools library
https://bugzilla.redhat.com/show_bug.cgi?id=1488242 Sandro Mani changed: What|Removed |Added Blocks||1488245 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1488245 [Bug 1488245] Review Request: mingw-Cython - MinGW Windows Python cython library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488245] New: Review Request: mingw-Cython - MinGW Windows Python cython library
https://bugzilla.redhat.com/show_bug.cgi?id=1488245 Bug ID: 1488245 Summary: Review Request: mingw-Cython - MinGW Windows Python cython library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: manisan...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://smani.fedorapeople.org/review/mingw-Cython.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-cython-0.25.2-1.fc28.src.rpm Description: MinGW Windows Python cython library Fedora Account System Username: smani -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488244] New: Review Request: mingw-sip - MinGW Windows SIP
https://bugzilla.redhat.com/show_bug.cgi?id=1488244 Bug ID: 1488244 Summary: Review Request: mingw-sip - MinGW Windows SIP Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: manisan...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://smani.fedorapeople.org/review/mingw-sip.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-sip-4.19.3-2.fc28.src.rpm Description: MinGW Windows SIP Fedora Account System Username: smani -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488242] New: Review Request: mingw-python-setuptools - MinGW Windows Python setuptools library
https://bugzilla.redhat.com/show_bug.cgi?id=1488242 Bug ID: 1488242 Summary: Review Request: mingw-python-setuptools - MinGW Windows Python setuptools library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: manisan...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://smani.fedorapeople.org/review/mingw-python-setuptools.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-python-setuptools-36.2.0-1.fc28.src.rpm Description: MinGW Windows Python setuptools library Fedora Account System Username: smani -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488241] New: Review Request: mingw-python-qt5 - MinGW Windows PyQt5
https://bugzilla.redhat.com/show_bug.cgi?id=1488241 Bug ID: 1488241 Summary: Review Request: mingw-python-qt5 - MinGW Windows PyQt5 Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: manisan...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://smani.fedorapeople.org/review/mingw-python-qt5.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-python-qt5-5.9-2.fc28.src.rpm Description: MinGW Windows PyQt5 Fedora Account System Username: smani -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488240] New: Review Request: mingw-numpy - MinGW Windows Python numpy library
https://bugzilla.redhat.com/show_bug.cgi?id=1488240 Bug ID: 1488240 Summary: Review Request: mingw-numpy - MinGW Windows Python numpy library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: manisan...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://smani.fedorapeople.org/review/mingw-numpy.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-numpy-1.13.1-1.fc28.src.rpm Description: MinGW Windows Python numpy library Fedora Account System Username: smani -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488238] New: Review Request: mingw-Cython - MinGW Windows Python cython library
https://bugzilla.redhat.com/show_bug.cgi?id=1488238 Bug ID: 1488238 Summary: Review Request: mingw-Cython - MinGW Windows Python cython library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: manisan...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://smani.fedorapeople.org/review/mingw-Cython.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-cython-0.25.2-1.fc28.src.rpm Description: MinGW Windows Python cython library Fedora Account System Username: smani -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487884] Review Request: python-sortedcontainers - Python Sorted Container Types: SortedList, SortedDict, and SortedSet
https://bugzilla.redhat.com/show_bug.cgi?id=1487884 --- Comment #7 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-sortedcontainers -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487896] Review Request: ghc-sandi - Data encoding library
https://bugzilla.redhat.com/show_bug.cgi?id=1487896 --- Comment #6 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-sandi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487900] Review Request: ghc-memory - Memory and related abstraction stuff
https://bugzilla.redhat.com/show_bug.cgi?id=1487900 --- Comment #6 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-memory -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487893] Review Request: ghc-hourglass - Simple performant time related library
https://bugzilla.redhat.com/show_bug.cgi?id=1487893 --- Comment #6 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-hourglass -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488214] Review Request: deepin-manual - Deepin User Manual
https://bugzilla.redhat.com/show_bug.cgi?id=1488214
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
Hello,
- One issue with the icon you install, you need to run gtk-update-icon-cache:
%post
touch --no-create %{_datadir}/icons/hicolor || :
if [ -x %{_bindir}/gtk-update-icon-cache ] ; then
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi
%postun
touch --no-create %{_datadir}/icons/hicolor || :
if [ -x %{_bindir}/gtk-update-icon-cache ] ; then
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi
and you need to Require hicolor-icon-theme:
Requires: hicolor-icon-theme
- Internet access is disabled during Koji and Mock builds, thus you can't
download all the node modules required for the manual. You need to either to
bundle them. Or better: you could package them all with node2rpm, and their
dependencies… it would be a lot of work though.
List of dependencies:
"dependencies": {
"angular": "^1.3.15",
"angular-animate": "^1.3.15",
"angular-gettext": "^2.0.5",
"angular-hotkeys": "^1.4.5",
"babel-core": "^5.1.11",
"babelify": "^5.0.4",
"browserify": "^9.0.4",
"expect.js": "^0.3.1",
"gulp": "^3.8.11",
"gulp-angular-gettext": "^2.1.0",
"gulp-mocha": "^2.0.1",
"gulp-ng-annotate": "^0.5.2",
"gulp-rename": "^1.2.2",
"gulp-uglify": "^1.2.0",
"jquery": "^2.1.3",
"marked": "^0.3.3",
"mousetrap": "^1.5.2",
"url-parse": "^1.0.0"
},
"devDependencies": {
"gulp-sass": "^1.3.3",
"gulp-sourcemaps": "^1.5.2"
}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487901] Review Request: ghc-persistent - Type-safe, multi-backend data serialization
https://bugzilla.redhat.com/show_bug.cgi?id=1487901 --- Comment #6 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-persistent -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488171] Review Request: perl-Alien-PCRE2 - Install and locate PCRE2 library
https://bugzilla.redhat.com/show_bug.cgi?id=1488171 --- Comment #2 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Alien-PCRE2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487960] Review Request: mingw-python2 - MinGW Windows python2
https://bugzilla.redhat.com/show_bug.cgi?id=1487960 --- Comment #5 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-python2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488147] Review Request: flatpak-builder - Tool to build flatpaks from source
https://bugzilla.redhat.com/show_bug.cgi?id=1488147 --- Comment #3 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/flatpak-builder -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487632] Review Request: perl-Acme-Alien-DontPanic - Test module for Alien::Base
https://bugzilla.redhat.com/show_bug.cgi?id=1487632 --- Comment #3 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Acme-Alien-DontPanic -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487611] Review Request: dontpanic - Very simple library and executable used in testing Alien:: Base
https://bugzilla.redhat.com/show_bug.cgi?id=1487611 --- Comment #8 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/dontpanic -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487055] Review Request: golang-github-flynn-go-shlex - Simple lexer for golang
https://bugzilla.redhat.com/show_bug.cgi?id=1487055 --- Comment #4 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-flynn-go-shlex -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488216] Review Request: deepin-help - Help files for DDE
https://bugzilla.redhat.com/show_bug.cgi?id=1488216 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- All good, package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1238377] Review Request: mingw-g2clib - MinGW Windows g2clib library
https://bugzilla.redhat.com/show_bug.cgi?id=1238377 --- Comment #6 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-g2clib -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1238376] Review Request: mingw-freexl - MinGW Windows freexl library
https://bugzilla.redhat.com/show_bug.cgi?id=1238376 --- Comment #6 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-freexl -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1486238] Review Request: python-subliminal - Python library to search and download subtitles
https://bugzilla.redhat.com/show_bug.cgi?id=1486238 --- Comment #10 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-subliminal. You may create the branch "f27" using git in about 10 minutes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1238374] Review Request: mingw-cfitsio - MinGW Windows CFITSIO library
https://bugzilla.redhat.com/show_bug.cgi?id=1238374 --- Comment #12 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-cfitsio -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487894] Review Request: ghc-pem - Privacy Enhanced Mail (PEM) format reader and writer
https://bugzilla.redhat.com/show_bug.cgi?id=1487894 --- Comment #4 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-pem -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487898] Review Request: ghc-socks - Socks proxy (version 5) implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1487898 --- Comment #4 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-socks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1486226] Review Request: python-guessit - Python library that extracts as much information as possible from a video filename
https://bugzilla.redhat.com/show_bug.cgi?id=1486226 --- Comment #10 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-guessit. You may create the branch "f27" using git in about 10 minutes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1486904] Review Request: python-pytest-benchmark - A py.test fixture for benchmarking code. It will group the tests into rounds that are calibrated to the chosen timer
https://bugzilla.redhat.com/show_bug.cgi?id=1486904 --- Comment #6 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pytest-benchmark. You may create the branch "f27" using git in about 10 minutes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487416] Review Request: python-zabbix-api-erigones - Zabbix API Python Library.
https://bugzilla.redhat.com/show_bug.cgi?id=1487416 --- Comment #6 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-zabbix-api-erigones. You may create the branch "f26" using git in about 10 minutes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1358741] Review Request: python-msrestazure - AutoRest swagger generator Python client runtime ( Azure-specific module)
https://bugzilla.redhat.com/show_bug.cgi?id=1358741 --- Comment #13 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-msrestazure -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487581] Review Request: python34-cairo - Python 3 bindings for the cairo library
https://bugzilla.redhat.com/show_bug.cgi?id=1487581 --- Comment #3 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python34-cairo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480957] Review Request: golang-github-axgle-mahonia - Character-set conversion library implemented in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1480957 --- Comment #6 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-axgle-mahonia -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487542] Review Request: R-sp - Classes and Methods for Spatial Data
https://bugzilla.redhat.com/show_bug.cgi?id=1487542 --- Comment #5 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-sp -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483300] Review Request: deepin-qt5integration - Qt platform theme integration plugins for DDE
https://bugzilla.redhat.com/show_bug.cgi?id=1483300 --- Comment #11 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/deepin-qt5integration -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488093] Review Request: krbcontext - A Kerberos context manager
https://bugzilla.redhat.com/show_bug.cgi?id=1488093
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
Hello,
- Source0 is returning 404. In order to fix it, change %{name} to %{src_name}:
Source0:
https://files.pythonhosted.org/packages/source/k/%{src_name}/%{src_name}-%{version}.tar.gz
- The Group: tag is not used in Fedora. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
- Similarly, no %clean section is needed
- %defattr(-,root,root) is not needed either in %files sections
- You should probably use %python_version macro for your tests:
%check
PYTHONPATH=. py.test-%{python2_version} test/
PYTHONPATH=. py.test-%{python3_version} test/
- You need to add python provides in each %package section:
* for the Python2 package:
%package -n python2-%{src_name}
Summary: A Kerberos context manager
BuildRequires: python-devel
BuildRequires: python-setuptools
BuildRequires: python-gssapi
# For running test
BuildRequires: python2-mock
BuildRequires: python-flake8
BuildRequires: python-pytest-cov
BuildRequires: python2-pytest
Requires: python-gssapi
%{?python_provide:%python_provide python2-%{src_name}}
* for the Python3 package:
%package -n python3-%{src_name}
Summary: A Kerberos context manager
BuildRequires: python3-setuptools
BuildRequires: python3-devel
BuildRequires: python3-gssapi
# For running test
BuildRequires: python3-flake8
BuildRequires: python3-mock
BuildRequires: python3-pytest
BuildRequires: python3-pytest-cov
Requires: python3-gssapi
%{?python_provide:%python_provide python%{python3_pkgversion}-%{src_name}}
- You mustn't use %define, but %global instead:
%global src_name krbcontext
- You musn't add LICENSE into %doc but into %license:
%files -n python2-%{src_name}
%license LICENSE
%doc README.rst CHANGELOG.rst docs/
and:
%files -n python3-%{src_name}
%license LICENSE
%doc README.rst CHANGELOG.rst docs/
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file LICENSE is not marked as %license
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v3 or later)", "Unknown or generated". 26 files have
unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/python-krbcontext/review-python-
krbcontext/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 143360 bytes in 18 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x
[Bug 1484561] Review Request: python-ludolph - Monitoring Jabber Bot with Zabbix support, completely written in Python.
https://bugzilla.redhat.com/show_bug.cgi?id=1484561 --- Comment #15 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-ludolph. You may create the branch "f26" using git in about 10 minutes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1476590] Review Request: deepin-daemon - Daemon handling the DDE session settings
https://bugzilla.redhat.com/show_bug.cgi?id=1476590
--- Comment #15 from Robert-André Mauchin ---
I was tired of waiting so I built deepin-api locally.
Anyway, there's an issue, the package doesn't provide debugging symbols. It
seems they have been deactivated in the Makefile. Thus you need to patch the
Makefile to get the debugging symbols back. Here's my patch:
diff -up dde-daemon-3.1.19/Makefile.old dde-daemon-3.1.19/Makefile
--- dde-daemon-3.1.19/Makefile.old2017-08-24 03:42:43.0 +0200
+++ dde-daemon-3.1.19/Makefile2017-09-04 18:06:11.382062647 +0200
@@ -3,7 +3,7 @@ GOPATH_DIR = gopath
GOPKG_PREFIX = pkg.deepin.io/dde/daemon
ifndef USE_GCCGO
-GOLDFLAGS = -ldflags '-s -w'
+GOLDFLAGS =
else
GOLDFLAGS = -s -w -Os -O2 -mieee
endif
- One useful macro to avoid hardcoded directories:
/usr/lib/sysusers.d/ →→ %{_sysusersdir
- Some directories specific to your package are unowned:
/usr/share/dde
/usr/share/deepin-default-settings
/var/cache/appearance
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
generated", "*No copyright* Public domain", "LGPL (v3 or later)", "GPL
(v2 or later) (with incorrect FSF address)", "*No copyright* LGPL
(v2.1 or later)". 369 files have unknown license. Detailed output of
licensecheck in /home/bob/packaging/review/deepin-daemon/review-
deepin-daemon/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[ ]: Package requires other packages for directories it uses.
Note: No known owner of /var/cache/appearance,
/usr/share/locale/es_419, /usr/share/deepin-default-settings,
/usr/share/locale/am_ET/LC_MESSAGES, /usr/lib/systemd/logind.conf.d,
/usr/share/locale/am_ET, /usr/share/dde,
/usr/share/locale/es_419/LC_MESSAGES
[ ]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/locale/am_ET/LC_MESSAGES, /usr/share/locale/am_ET,
/usr/share/dbus-1/system-services, /usr/share/dde, /usr/share/dbus-1,
/usr/lib/systemd/logind.conf.d, /usr/share/deepin-default-settings,
/var/cache/appearance, /usr/share/locale/es_419,
/usr/share/locale/es_419/LC_MESSAGES, /usr/share/dbus-1/services
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[!]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $
[Bug 1404895] Review Request: partclone - File System Clone Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1404895 --- Comment #29 from Fedora Update System --- partclone-0.3.5a-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1474958] Review Request: lammps - Large-scale Atomic/ Molecular Massively Parallel Simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1474958 --- Comment #27 from Fedora Update System --- lammps-20170811-5.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1404895] Review Request: partclone - File System Clone Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1404895 --- Comment #28 from Fedora Update System --- partclone-0.3.5a-3.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1485722] Review Request: deepin-file-manager - Deepin File Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1485722 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #8 from Robert-André Mauchin --- Perfect, package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488216] New: Review Request: deepin-help - Help files for DDE
https://bugzilla.redhat.com/show_bug.cgi?id=1488216 Bug ID: 1488216 Summary: Review Request: deepin-help - Help files for DDE Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: sensor@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00598290-deepin-help/deepin-help.spec SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00598290-deepin-help/deepin-help-15.4.8-1.fc26.src.rpm Description: Help files for DDE Fedora Account System Username: mosquito -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488214] New: Review Request: deepin-manual - Deepin User Manual
https://bugzilla.redhat.com/show_bug.cgi?id=1488214 Bug ID: 1488214 Summary: Review Request: deepin-manual - Deepin User Manual Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: sensor@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00598286-deepin-manual/deepin-manual.spec SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-26-x86_64/00598286-deepin-manual/deepin-manual-1.0.6-1.fc26.src.rpm Description: Deepin User Manual Fedora Account System Username: mosquito -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1485722] Review Request: deepin-file-manager - Deepin File Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1485722 --- Comment #7 from sensor@gmail.com --- https://github.com/FZUG/repo/commit/a9f6b85bb31d085ef5ab1b0295c4ecc91c7ae432 Fixed. Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1482145] Review Request: python3-pyasn1 - ASN.1 tools for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1482145 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1485869] Review Request: compat-ImageMagick693 - Compat package with ImageMagick 6.9.3 libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1485869 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-09-04 12:16:02 --- Comment #9 from Fedora Update System --- compat-ImageMagick693-6.9.3.10-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488171] Review Request: perl-Alien-PCRE2 - Install and locate PCRE2 library
https://bugzilla.redhat.com/show_bug.cgi?id=1488171 Jitka Plesnikova changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Jitka Plesnikova --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok $ rpm -qp --requires perl-Alien-PCRE2-0.013000-1.fc28.x86_64.rpm | sort | uniq -c 1 pcre2-devel(x86-64) 1 perl(Alien::Base) 1 perl(Alien::PCRE2) 1 perl(base) 1 perl(:MODULE_COMPAT_5.26.0) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -qp --provides perl-Alien-PCRE2-0.013000-1.fc28.x86_64.rpm | sort | uniq -c 1 perl(Alien::PCRE2) = 0.013000 1 perl-Alien-PCRE2 = 0.013000-1.fc28 1 perl(Alien::PCRE2::Install::Files) 1 perl-Alien-PCRE2(x86-64) = 0.013000-1.fc28 Binary provides are Ok. $ rpmlint ./perl-Alien-PCRE2* perl-Alien-PCRE2.x86_64: E: no-binary perl-Alien-PCRE2.x86_64: W: only-non-binary-in-usr-lib 2 packages and 1 specfiles checked; 1 errors, 1 warnings. Rpmlint is ok The package looks good. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488156] Review Request: python-ludolph-zabbix - Ludolph: Zabbix API plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1488156
--- Comment #3 from Miro Hrončok ---
Rpmlint
---
Checking: python2-ludolph-zabbix-1.7-1.fc28.noarch.rpm
python3-ludolph-zabbix-1.7-1.fc28.noarch.rpm
python-ludolph-zabbix-1.7-1.fc28.src.rpm
python2-ludolph-zabbix.noarch: W: spelling-error %description -l en_US plugini
-> plugin, plugins, plugin i
python2-ludolph-zabbix.noarch: E: description-line-too-long C Python 2 module
with Ludolph: Zabbix API plugini. Use the python3-ludolph and
python3-ludolph-zabbix\
3 packages and 0 specfiles checked; 1 errors, 1 warnings.
This line is still too long:
Python 2 module with Ludolph: Zabbix API plugini. Use the python3-ludolph and
python3-%{pypi_name}\
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1485722] Review Request: deepin-file-manager - Deepin File Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1485722
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #6 from Robert-André Mauchin ---
Hello,
There's a couple of typo, it doesn't break anything but are kind of annoying
for comprehension:
- first the name of the patch:
deepin-file-manager-diable_ffmpeg.patch →
deepin-file-manager-disable_ffmpeg.patch
- then inside of the patch itself:
SUPPORT_FFMEPG → SUPPORT_FFMPEG
- There are several issue regarding ownership of directories:
/usr/lib64/dde-dock
/usr/lib64/dde-dock/plugins
/usr/lib64/dde-file-manager
/usr/lib64/dde-file-manager/plugins
/usr/lib64/dde-file-manager/plugins/previews
/usr/share/dde-desktop
/usr/share/dde-desktop/translations
/usr/share/dman
/usr/share/usb-device-formatter
/usr/share/usb-device-formatter/translations
/usr/include/dde-file-manager
/usr/include/dde-file-manager/dde-file-manager-plugins
/usr/include/dde-file-manager/gvfs
/usr/include/dde-file-manager/private
All those dirs are created by your package but aren't owned. Please add a %dir
macro for each one.
- You forgot to call desktop-file-validate on your desktop files:
%check
desktop-file-validate %{buildroot}/%{_datadir}/applications/%{repo}.desktop
desktop-file-validate
%{buildroot}/%{_datadir}/applications/dde-computer.desktop
desktop-file-validate %{buildroot}/%{_datadir}/applications/dde-trash.desktop
- Also I couldn't install the package because it depends on deepin-manual,
which I don't have. And is it really necessary to make a file manager depends
on the manual?
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
generated", "Unicode strict", "MIT/X11 (BSD like)", "LGPL (v2.1)",
"BSD (3 clause)". 1645 files have unknown license. Detailed output of
licensecheck in /home/bob/packaging/review/deepin-file-manager/review-
deepin-file-manager/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/dde-desktop/translations,
/usr/lib64/dde-file-manager/plugins, /usr/lib64/dde-dock/plugins,
/usr/include/dde-file-manager/private, /usr/lib64/dde-file-manager,
/usr/share/usb-device-formatter, /usr/lib64/dde-file-
manager/plugins/previews, /usr/share/dde-desktop, /usr/include/dde-
file-manager, /usr/share/dman, /usr/include/dde-file-manager/gvfs,
/usr/lib64/dde-dock, /usr/share/usb-device-formatter/translations,
/usr/include/dde-file-manager/dde-file-manager-plugins
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/usb-device-
formatter/translations, /usr/lib64/dde-dock, /usr/share/dde-desktop,
/usr/share/dbus-1/system-services, /usr/include/dde-file-manager/gvfs,
/usr/share/dbus-1, /etc/dbus-1, /usr/share/dbus-1/interfaces,
/usr/include/dde-file-manager, /usr/lib64/dde-dock/plugins,
/usr/include/dde-file-manager/private, /usr/lib64/dde-file-
manager/plugins, /usr/lib64/dde-file-manager, /usr/share/usb-device-
formatter, /etc/dbus-1/system.d, /usr/share/dde-desktop/translations,
/usr/share/dbus-1/services, /usr/include/dde-file-manager/dde-file-
manager-plugins, /usr/lib64/dde-file-manager/plugins/previews,
/usr/share/dman
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or co
[Bug 1487960] Review Request: mingw-python2 - MinGW Windows python2
https://bugzilla.redhat.com/show_bug.cgi?id=1487960 --- Comment #4 from Robert-André Mauchin --- Actually I purged my mock chroot and the problem disappeared so everything is good. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487960] Review Request: mingw-python2 - MinGW Windows python2
https://bugzilla.redhat.com/show_bug.cgi?id=1487960 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #3 from Robert-André Mauchin --- I tried to do a Koji scratch to show you but the problem doesn't happen there. ( https://koji.fedoraproject.org/koji/taskinfo?taskID=21648651 ) Anyway the relevant part of my build.log is there: ++ mingw32-pkg-config libffi --cflags-only-I ++ sed 's|\-I||g' + export LIBFFI_INCLUDEDIR= + LIBFFI_INCLUDEDIR= Full log https://gist.github.com/eclipseo/f034ce1c3bdc22b66ecf2e02ffcd055f Since it doesn't happen in Koji, I think it's a bug on my end, so I accept the package. I don't understand why it happens though since when I run "mingw32-pkg-config libffi --cflags-only-I" in my chroot, it does display the include path. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487776] Review Request: wsjtx - Weak Signal communication by K1JT
https://bugzilla.redhat.com/show_bug.cgi?id=1487776 Robert-André Mauchin changed: What|Removed |Added Status|POST|ASSIGNED Flags|fedora-review+ |fedora-review? --- Comment #4 from Robert-André Mauchin --- Sorry wrong window. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488171] Review Request: perl-Alien-PCRE2 - Install and locate PCRE2 library
https://bugzilla.redhat.com/show_bug.cgi?id=1488171 Jitka Plesnikova changed: What|Removed |Added Status|NEW |ASSIGNED CC||jples...@redhat.com Assignee|nob...@fedoraproject.org|jples...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487776] Review Request: wsjtx - Weak Signal communication by K1JT
https://bugzilla.redhat.com/show_bug.cgi?id=1487776 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- I tried to do a Koji scratch to show you but the problem doesn't happen there. ( https://koji.fedoraproject.org/koji/taskinfo?taskID=21648651 ) Anyway the relevant part of my build.log is there: ++ mingw32-pkg-config libffi --cflags-only-I ++ sed 's|\-I||g' + export LIBFFI_INCLUDEDIR= + LIBFFI_INCLUDEDIR= Full log https://gist.github.com/eclipseo/f034ce1c3bdc22b66ecf2e02ffcd055f Since it doesn't happen in Koji, I think it's a bug on my end, so I accept the package. I don't understand why it happens though since when I run "mingw32-pkg-config libffi --cflags-only-I" in my chroot, it does display the include path. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488171] New: Review Request: perl-Alien-PCRE2 - Install and locate PCRE2 library
https://bugzilla.redhat.com/show_bug.cgi?id=1488171 Bug ID: 1488171 Summary: Review Request: perl-Alien-PCRE2 - Install and locate PCRE2 library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ppi...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ppisar.fedorapeople.org/perl-Alien-PCRE2/perl-Alien-PCRE2.spec SRPM URL: https://ppisar.fedorapeople.org/perl-Alien-PCRE2/perl-Alien-PCRE2-0.013000-1.fc28.src.rpm Description: This package can be used by other Perl modules that require PCRE2 library, the new Perl Compatible Regular Expression engine. Fedora Account System Username: ppisar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488156] Review Request: python-ludolph-zabbix - Ludolph: Zabbix API plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1488156 --- Comment #2 from Richard Kellner --- Sorry I have forgotten to remove unused commented lines in the spec. Also updated the description to be in two lines. Both spec and srpm files updated in GitHub repo. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488156] Review Request: python-ludolph-zabbix - Ludolph: Zabbix API plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1488156
--- Comment #1 from Miro Hrončok ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
Please fix the following rpmlint issues:
* description-line-too-long
* macro-in-comment
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
= EXTRA items =
Generic:
[?]: Rpmlint is run on all installed packages.
[x]: Spec file according to URL is the same as in SRPM.
Inst
[Bug 1487960] Review Request: mingw-python2 - MinGW Windows python2
https://bugzilla.redhat.com/show_bug.cgi?id=1487960 --- Comment #2 from Sandro Mani --- Hmm can you post the full log of the failing build? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488101] Review Request: eclipse-recommenders - Eclipse Code Recommenders
https://bugzilla.redhat.com/show_bug.cgi?id=1488101 --- Comment #1 from Mat Booth --- I noticed it didn't build correctly on F26 -- new revision fixes that: Spec URL: https://fedorapeople.org/~mbooth/reviews/eclipse-recommenders.spec SRPM URL: https://fedorapeople.org/~mbooth/reviews/eclipse-recommenders-2.4.9-2.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488156] Review Request: python-ludolph-zabbix - Ludolph: Zabbix API plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1488156 Miro Hrončok changed: What|Removed |Added Status|NEW |ASSIGNED CC||mhron...@redhat.com Assignee|nob...@fedoraproject.org|mhron...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488156] New: Review Request: python-ludolph-zabbix - Ludolph: Zabbix API plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1488156 Bug ID: 1488156 Summary: Review Request: python-ludolph-zabbix - Ludolph: Zabbix API plugin Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: richard.kell...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://raw.githubusercontent.com/erigones/ludolph-zabbix/master/rpmbuild/SPECS/python-ludolph-zabbix.spec SRPM URL: https://github.com/erigones/ludolph-zabbix/raw/master/rpmbuild/SRPMS/python-ludolph-zabbix-1.7-1.fc26.src.rpm Ludolph: Zabbix API plugin This is the plugin for Zabbix support in the Ludolph: Monitoring Jabber Bot, that has support to easily write plugins in Python. Fedora Account System Username: ricco I am a co-creator of this library and also an active developer and a package maintainer at GitHub. Repository: https://github.com/erigones/ludolph-zabbix Build works OK. The plugin is not installable, due to dependencies not released yet. Dependencies: * Package python-ludolph has been already reviewed: https://bugzilla.redhat.com/show_bug.cgi?id=1484561 but I am still waiting for repository: https://pagure.io/releng/fedora-scm-requests/issue/827 * Package python-zabbix-api-erigones has been reviewed: https://bugzilla.redhat.com/show_bug.cgi?id=1487416 but again I am waiting for the repository: https://pagure.io/releng/fedora-scm-requests/issue/845 Koji builds: f26: https://koji.fedoraproject.org/koji/taskinfo?taskID=21646223 f27: https://koji.fedoraproject.org/koji/taskinfo?taskID=21646225 f28: https://koji.fedoraproject.org/koji/taskinfo?taskID=21646255 rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=21646170 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487884] Review Request: python-sortedcontainers - Python Sorted Container Types: SortedList, SortedDict, and SortedSet
https://bugzilla.redhat.com/show_bug.cgi?id=1487884 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #6 from Robert-André Mauchin --- All good, package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488147] Review Request: flatpak-builder - Tool to build flatpaks from source
https://bugzilla.redhat.com/show_bug.cgi?id=1488147 Kalev Lember changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from Kalev Lember --- Thanks David! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488147] Review Request: flatpak-builder - Tool to build flatpaks from source
https://bugzilla.redhat.com/show_bug.cgi?id=1488147 David King changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from David King --- The same as the flatpak package which it was split from. Seems to fulfil the packaging guidelines (as with the original package). Looks good! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487896] Review Request: ghc-sandi - Data encoding library
https://bugzilla.redhat.com/show_bug.cgi?id=1487896 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #5 from Robert-André Mauchin --- Ok, package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488147] Review Request: flatpak-builder - Tool to build flatpaks from source
https://bugzilla.redhat.com/show_bug.cgi?id=1488147 David King changed: What|Removed |Added CC||amigad...@amigadave.com Assignee|nob...@fedoraproject.org|amigad...@amigadave.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1488147] New: Review Request: flatpak-builder - Tool to build flatpaks from source
https://bugzilla.redhat.com/show_bug.cgi?id=1488147 Bug ID: 1488147 Summary: Review Request: flatpak-builder - Tool to build flatpaks from source Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: klem...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://kalev.fedorapeople.org/flatpak-builder.spec SRPM URL: https://kalev.fedorapeople.org/flatpak-builder-0.9.9-1.fc28.src.rpm Description: flatpak-builder used to be part of the flatpak source package, but was split out to a separate upstream tarball in flatpak 0.9.9. Fedora Account System Username: kalev -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487611] Review Request: dontpanic - Very simple library and executable used in testing Alien:: Base
https://bugzilla.redhat.com/show_bug.cgi?id=1487611 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #7 from Robert-André Mauchin --- All right, package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1246199] Review Request: rdopkg - RPM packaging automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1246199 --- Comment #15 from Jakub Ruzicka --- W: file-size-mismatch rdopkg-0.45.0.tar.gz is a one time issue due to .spec being included in tarball and I regenerated that without updating PyPI version. Once reviewd, .spec will move to fedora distgit so this will no longer be an issue. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487900] Review Request: ghc-memory - Memory and related abstraction stuff
https://bugzilla.redhat.com/show_bug.cgi?id=1487900 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #5 from Robert-André Mauchin --- Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1445923] Review Request: streameye - Simple MJPEG streamer for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1445923 --- Comment #14 from Fedora Update System --- streameye-0.8-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2919664de4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1445923] Review Request: streameye - Simple MJPEG streamer for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1445923 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1246199] Review Request: rdopkg - RPM packaging automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1246199
--- Comment #14 from Jakub Ruzicka ---
Spec URL:
https://raw.githubusercontent.com/softwarefactory-project/rdopkg/master/rdopkg.spec
SRPM URL: https://jruzicka.fedorapeople.org/pkgs/rdopkg-0.45.0-3.fc25.src.rpm
Note this package built successfully in my copr on f2{5,6,7}, el7 and rawhide:
https://copr.fedorainfracloud.org/coprs/jruzicka/rdopkg/build/597985/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487893] Review Request: ghc-hourglass - Simple performant time related library
https://bugzilla.redhat.com/show_bug.cgi?id=1487893 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #5 from Robert-André Mauchin --- All good, package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487901] Review Request: ghc-persistent - Type-safe, multi-backend data serialization
https://bugzilla.redhat.com/show_bug.cgi?id=1487901 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #5 from Robert-André Mauchin --- Everything is good, package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin
https://bugzilla.redhat.com/show_bug.cgi?id=1421055 --- Comment #9 from Peter Robinson --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #7) > Is this package really needed? The diff between gnome's cogl 1.22 and this > fork is just a few commits. Wouldn't it be possible to cooperate with Fedora > cogl maintainers and cogl upstream to upstream those patches and dispose of > the fork: > > Only in deepin-cogl cogl-1.22 branch: > * 1e1e1b8a97 winsys: Disable sync_control > * f28fe60db1 Add LICENSE > * 9ee8ef2d2d (tag: 1.22.3) Change debian dir > * a34f7835c0 Debian dir migration > * 9e113c10da Add debian dir > * d8b34ab060 texture: Support copy_sub_image > * 78636289b0 Add GL_ARB_shader_texture_lod support > > Only in upstream cogl cogl-1.22 branch: > * cbdde65b7e (upstream/cogl-1.22) Add Nepali translation > * 84d9ed33ef Update Malayalam translation > * 811f285a8e Update po/Makevars > * 3baa2d7a65 Updated Norwegian bokmål translation. > * 0bc94d13df Update Friulian translation > * cdb3229f54 Update Friulian translation > * df29d85990 Add Friulian translation > * b583e21d86 Fix an incorrect preprocessor conditional > > @pbrobinson, what do you think? Yes, absolutely, having overlapping libraries is ridiculous. Also looking at the 7 patches in deepin-cogl listed above there's probably only two that actually would affect Fedora, the top 5 listed commits are debian/windows/licence related, it's likely only the bottom two of real effect to Fedora and those should go for review upstream (well they all should). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487611] Review Request: dontpanic - Very simple library and executable used in testing Alien:: Base
https://bugzilla.redhat.com/show_bug.cgi?id=1487611 --- Comment #6 from Petr Pisar --- (In reply to Robert-André Mauchin from comment #5) > AutoTools: Obsoleted m4s found > -- > AM_PROG_LIBTOOL found in: dontpanic-1.00/configure.ac:15 > AC_PROG_LIBTOOL found in: dontpanic-1.00/configure.ac:14 > > > These need to be patched with LT_INIT. See > https://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html for > further details. > > Here's a patch: > > diff -up dontpanic-1.00/configure.ac.fix_obsolete_m4s > dontpanic-1.00/configure.ac > --- dontpanic-1.00/configure.ac.fix_obsolete_m4s 2016-06-22 > 21:31:58.0 +0200 > +++ dontpanic-1.00/configure.ac 2017-09-04 12:35:55.066064941 +0200 > @@ -11,8 +11,7 @@ AC_CONFIG_FILES([src/dontpanic.pc]) > > # Checks for programs. > AC_PROG_CC > -AC_PROG_LIBTOOL > -AM_PROG_LIBTOOL > +LT_INIT > > # Checks for libraries. > The configure.ac already calls LT_INIT. These deprecated macros are there for backward compatibility. There is no need to remove them now. > - You can replace %setup -q + patchX -p1 with the following macro that will > handle the setup and all the patches automatically: > > %prep > %autosetup -p1 > That would add build-time dependency on git. I won't do it. > - There's a typo in your comment above your patch: congifured → configured > The typo is fixed in the updated package that is located on the same addresses. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487891] Review Request: ghc-feed - Interfacing with RSS (v 0.9x, 2.x , 1.0) + Atom feeds
https://bugzilla.redhat.com/show_bug.cgi?id=1487891 --- Comment #5 from Robert-André Mauchin --- You don't want to split the docs?? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1246199] Review Request: rdopkg - RPM packaging automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1246199
--- Comment #13 from Jakub Ruzicka ---
(In reply to Neal Gompa from comment #12)
> > I wanted to wait until it's supported in latest EL to avoid %if but OK,
> > I'll pave the way ;)
>
> I'm not sure how it could get supported in EL7, since RPM 4.11 and Yum don't
> support it. We'd be waiting for EL8...
>
> Just do "%if 0%{?fedora} || 0%{?rhel} >= 8"
I've addressed your suggestions in
https://softwarefactory-project.io/r/#/c/9546/
Please either leave +1/-1 there (you can login with github) or let me know here
if it's OK.
> If there's a missing dependency, I'd rather block rdopkg from being included
> period.
Although missing python3-bunch is being investigated, it is absolutely no
reason to block because rdopkg has on-demand import and the missing dep is only
needed for `rdopkg cbsbuild` command which is CLI and CLI depends on python2
version so it's all good.
I specifically built rdopkg in a way so that one broken subcommand doesn't
block entire project and missing deps only surface for commands that really use
them. Unlike usual python LOAD ALL THE MODULES and then really use 2 of them ;)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
