[Bug 1493720] Review Request: nodejs-make-dir - Make a directory and its parents if needed - Think
https://bugzilla.redhat.com/show_bug.cgi?id=1493720 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1448738] Review Request: nodejs-temp-write - Write string/buffer/ stream to a random temp file
https://bugzilla.redhat.com/show_bug.cgi?id=1448738 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- - You forgot to switch makedir to make-dir: BuildRequires:npm(make-dir) - The package requires npm(uuid) >= 3.0.1 but the latest version of npm(uuid) is 2.0.x. Thus I added: %nodejs_fixdep uuid Package otherwise accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1449413] Review Request: nodejs-mock-bin - Mock any executable binary
https://bugzilla.redhat.com/show_bug.cgi?id=1449413 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- All ok, package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493932] New: Review Request: plasma-vault - strong encryption features presented in a user-friendly way
https://bugzilla.redhat.com/show_bug.cgi?id=1493932 Bug ID: 1493932 Summary: Review Request: plasma-vault - strong encryption features presented in a user-friendly way Product: Fedora Version: 26 Component: Package Review Assignee: nob...@fedoraproject.org Reporter: mky...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Description of problem: Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/mkyral/plasma-unstable/plasma-vault.git/tree/plasma-vault.spec?h=f26 SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mkyral/plasma-unstable/fedora-26-x86_64/00604183-plasma-vault/plasma-vault-5.10.95-0.1.fc26.src.rpm Description: Plasma Vault offers strong encryption features presented in a user-friendly way Fedora Account System Username: mkyral Version-Release number of selected component (if applicable): 5.10.95 Additional info: To be imported in rawhide together with the rest of Plasma 5.11 (beta or final) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1443560] Review Request: nodejs-multipipe - Pipe streams with centralized error handling
https://bugzilla.redhat.com/show_bug.cgi?id=1443560 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493937] New: Review Request: plasma-drkonqi - crash handler for KF5/ Plasma5
https://bugzilla.redhat.com/show_bug.cgi?id=1493937 Bug ID: 1493937 Summary: Review Request: plasma-drkonqi - crash handler for KF5/Plasma5 Product: Fedora Version: 26 Component: Package Review Assignee: nob...@fedoraproject.org Reporter: mky...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Description of problem: Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/mkyral/plasma-unstable/plasma-drkonqi.git/tree/plasma-drkonqi.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mkyral/plasma-unstable/fedora-26-x86_64/00604336-plasma-drkonqi/plasma-drkonqi-5.10.95-0.1.fc26.src.rpm Description: DrKonqi crash handler for KF5/Plasma5 Fedora Account System Username: mkyral Version-Release number of selected component (if applicable): 5.10.95 Additional info: Drkonqi has been split from plasma-workspace into a component of its own in Plasma 5.11. To be imported in rawhide together with the rest of Plasma 5.11 (beta or final) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1364624] Review Request: nodejs-gulp-util - Utility functions for gulp plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1364624 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST CC||zebo...@gmail.com Assignee|vanmeeuwen+fedora@kolabsys. |zebo...@gmail.com |com | Flags|fedora-review? |fedora-review+ --- Comment #2 from Robert-André Mauchin --- Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1364624] Review Request: nodejs-gulp-util - Utility functions for gulp plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1364624 Robert-André Mauchin changed: What|Removed |Added Blocks||1364660 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1364660 [Bug 1364660] Review Request: nodejs-gulp-mocha - Run Mocha tests -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1364660] Review Request: nodejs-gulp-mocha - Run Mocha tests
https://bugzilla.redhat.com/show_bug.cgi?id=1364660 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Depends On||1364624 Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- All ok, package accepted Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1364624 [Bug 1364624] Review Request: nodejs-gulp-util - Utility functions for gulp plugins -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493789] Review Request: ghc-asn1-parse - Simple monadic parser for ASN1 stream types
https://bugzilla.redhat.com/show_bug.cgi?id=1493789
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #3 from Robert-André Mauchin ---
All good, package accepted.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (2 clause)", "Unknown or generated", "*No copyright* BSD
(unspecified)". 2 files have unknown license. Detailed output of
licensecheck in /home/bob/packaging/review/ghc-asn1-parse/review-ghc-
asn1-parse/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 81920 bytes in 12 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text
[Bug 1493787] Review Request: ghc-free - Monads for free
https://bugzilla.redhat.com/show_bug.cgi?id=1493787
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #3 from Robert-André Mauchin ---
All ok, package accepted.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (unspecified)", "BSD (2 clause)", "Unknown or generated".
22 files have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/ghc-free/review-ghc-free/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/doc/ghc/html,
/usr/share/doc/ghc/html/libraries, /usr/share/doc/ghc
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 92160 bytes in 15 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versio
[Bug 1493761] Review Request: nodejs-mdn-data - Open Web data by the Mozilla Developer Network
https://bugzilla.redhat.com/show_bug.cgi?id=1493761 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493762] Review Request: nodejs-css-tree - Fast detailed CSS parser
https://bugzilla.redhat.com/show_bug.cgi?id=1493762 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493764] Review Request: nodejs-csso - CSSO (CSS Optimizer) is a CSS minifier with structural optimisations
https://bugzilla.redhat.com/show_bug.cgi?id=1493764 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- All good, package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493765] Review Request: nodejs-whet-dot-extend - A sharped version of port of jQuery.extend
https://bugzilla.redhat.com/show_bug.cgi?id=1493765 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1364646] Review Request: nodejs-svgo - Nodejs-based tool for optimizing SVG vector graphics files
https://bugzilla.redhat.com/show_bug.cgi?id=1364646 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- - Error: Cannot find module 'js-yaml' ⇒ Move js-yaml BR outside of enable_tests Package otherwise accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493676] Review Request: nodejs-spec - An event-driven JavaScript unit testing library.
https://bugzilla.redhat.com/show_bug.cgi?id=1493676 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - You should remove the dot at the end of the summary: nodejs-spec.src: W: summary-ended-with-dot C An event-driven JavaScript unit testing library. Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493701] Review Request: nodejs-json3 - A modern JSON implementation compatible with nearly all JavaScript platforms.
https://bugzilla.redhat.com/show_bug.cgi?id=1493701 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- Please remove the dot at the end of the summary: nodejs-json3.src: W: summary-ended-with-dot C A modern JSON implementation compatible with nearly all JavaScript platforms. Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493708] Review Request: nodejs-has-flag - Check if argv has a specific flag
https://bugzilla.redhat.com/show_bug.cgi?id=1493708 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493718] Review Request: nodejs-makedir - Recursively make directories that you need in node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1493718 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493748] Review Request: nodejs-browser-stdout - A process.stdout for your browser
https://bugzilla.redhat.com/show_bug.cgi?id=1493748 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493932] Review Request: plasma-vault - strong encryption features presented in a user-friendly way
https://bugzilla.redhat.com/show_bug.cgi?id=1493932
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
Hello,
- I don't think you need to run %post -p /sbin/ldconfig . The .so files are
plugins in private directories.
- Your %description line must be split to stay below 80 characters per line.
- You must own the directory /usr/share/plasma/plasmoids/org.kde.plasma.vault
- The version in the %changelog is not consistent with the Release: tag. It
should probably be:
* Thu Sep 14 2017 Martin Kyral - 5.10.95-0.1
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL", "LGPL (v2.1 or v3)", "Unknown or generated". 56 files
have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/plasma-vault/review-plasma-
vault/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: Package requires other packages for directories it uses.
Note: No known owner of
/usr/share/plasma/plasmoids/org.kde.plasma.vault
[!]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/lib64/qt5/plugins/plasma/applets,
/usr/share/plasma/plasmoids/org.kde.plasma.vault
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in
[Bug 1494018] New: Review Request: erlang-fuse - A Circuit Breaker for Erlang
https://bugzilla.redhat.com/show_bug.cgi?id=1494018 Bug ID: 1494018 Summary: Review Request: erlang-fuse - A Circuit Breaker for Erlang Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: lemen...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://peter.fedorapeople.org/packages/erlang-fuse.spec SRPM URL: https://peter.fedorapeople.org/packages/erlang-fuse-2.4.0-1.fc27.src.rpm Description: This application implements a so-called circuit-breaker for Erlang. Fedora Account System Username: peter Koji scratchbuild for Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=22000325 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1457929] Review Request: proxysql - A high-performance MySQL proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1457929 Jakub Jedelsky changed: What|Removed |Added CC||jakub.jedel...@gmail.com --- Comment #25 from Jakub Jedelsky --- Hi there, I just found this Review and, if I understand correctly, there should be packages in rawhide and f27. Do you plan to prepare the package to EPEL7 too? Or are there any issues with it? Thanks, - jj -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493524] Review Request: oci-kvm-hook - An OCI hook that always adds /dev/kvm to each container
https://bugzilla.redhat.com/show_bug.cgi?id=1493524 --- Comment #2 from Stef Walter --- Thanks for the review. Much appreciated. I've fixed all the highlighted items: - ExclusiveArch - dist in Release: - Correct tarball directory in %setup - %make_build - %make_install - Bumped revision https://fedorapeople.org/~stefw/oci-kvm-hook.spec https://fedorapeople.org/~stefw/oci-kvm-hook-0.2-2.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1491163] Review Request: nvidia-query-resource-opengl - Querying OpenGL resource usage of applications using the NVIDIA OpenGL driver
https://bugzilla.redhat.com/show_bug.cgi?id=1491163 --- Comment #5 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nvidia-query-resource-opengl. You may commit to the branch "f27" in about 10 minutes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493789] Review Request: ghc-asn1-parse - Simple monadic parser for ASN1 stream types
https://bugzilla.redhat.com/show_bug.cgi?id=1493789 --- Comment #4 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-asn1-parse -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493787] Review Request: ghc-free - Monads for free
https://bugzilla.redhat.com/show_bug.cgi?id=1493787 --- Comment #4 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-free -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1481416] Review Request: light - control backlight controllers
https://bugzilla.redhat.com/show_bug.cgi?id=1481416 --- Comment #6 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/light -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1489383] Review Request: transtats-cli - Transtats command line interface to query server
https://bugzilla.redhat.com/show_bug.cgi?id=1489383 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1489383] Review Request: transtats-cli - Transtats command line interface to query server
https://bugzilla.redhat.com/show_bug.cgi?id=1489383 --- Comment #6 from Fedora Update System --- transtats-cli-0.1.0-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e03095b475 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1489383] Review Request: transtats-cli - Transtats command line interface to query server
https://bugzilla.redhat.com/show_bug.cgi?id=1489383 --- Comment #7 from Fedora Update System --- transtats-cli-0.1.0-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-2c59a13726 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1494089] New: Review Request: WoeUSB - Windows USB installation media creator
https://bugzilla.redhat.com/show_bug.cgi?id=1494089 Bug ID: 1494089 Summary: Review Request: WoeUSB - Windows USB installation media creator Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mpr...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://mprahl.fedorapeople.org/WoeUSB.spec SRPM URL: https://mprahl.fedorapeople.org/WoeUSB-2.1.3-1.fc26.src.rpm Description: A utility that enables you to create your own bootable Windows installation USB storage device from an existing Windows Installation disc or disk image. Fedora Account System Username: mprahl -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1393086] Review Request: golang-github-Microsoft-winio - Utilities for efficiently performing Win32 IO operations in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1393086 Bug 1393086 depends on bug 1393077, which changed state. Bug 1393077 Summary: rebase needed for golang-github-Microsoft-winio https://bugzilla.redhat.com/show_bug.cgi?id=1393077 What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1477363] Review Request: ocaml-cmdliner - Declarative definition of command line interfaces for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1477363 --- Comment #11 from Ben Rosser --- Now that ocaml-result is in Rawhide, I added a BR on ocaml-result-devel and no longer patch cmdliner to use Pervasives.result instead. I think this should now be ready for review (again). Spec URL: https://tc01.fedorapeople.org/ocaml/opam/ocaml-cmdliner.spec SRPM URL: https://tc01.fedorapeople.org/ocaml/opam/ocaml-cmdliner-1.0.2-4.fc26.src.rpm (I did this a while ago but apparently never updated the review ticket, my bad!) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1494162] New: Review Request: rakudo-MIME-Base64 - A Perl6 implementation of MIME:: Base64 for ASCII strings
https://bugzilla.redhat.com/show_bug.cgi?id=1494162 Bug ID: 1494162 Summary: Review Request: rakudo-MIME-Base64 - A Perl6 implementation of MIME::Base64 for ASCII strings Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: g...@zimt.uni-siegen.de QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: ftp://ftp.uni-siegen.de/pub/review/rakudo-MIME-Base64/spec/rakudo-MIME-Base64.spec SRPM URL: ftp://ftp.uni-siegen.de/pub/review/rakudo-MIME-Base64/srpm/rakudo-MIME-Base64-1.2.1-1.fc26.src.rpm Description: MIME::Base64 - Encoding and decoding Base64 ASCII strings. A Perl6 implementation of MIME::Base64 to encoding and decoding to and from base64. Fedora Account System Username: gerd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1494176] New: Review Request: python-renderspec - Jinja2 template renderer for generating .spec files
https://bugzilla.redhat.com/show_bug.cgi?id=1494176 Bug ID: 1494176 Summary: Review Request: python-renderspec - Jinja2 template renderer for generating .spec files Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jp...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jpena.fedorapeople.org/python-renderspec/python-renderspec.spec SRPM URL: https://jpena.fedorapeople.org/python-renderspec/python-renderspec-1.7.0-1.fc28.src.rpm Description: renderspec is a tool to convert a .spec.j2 Jinja2 template to a rpm .spec file which is usable for different distributions and follow their policies and processes. Fedora Account System Username: jpena Koji scratch build available at https://koji.fedoraproject.org/koji/taskinfo?taskID=22003023 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1494018] Review Request: erlang-fuse - A Circuit Breaker for Erlang
https://bugzilla.redhat.com/show_bug.cgi?id=1494018
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #1 from Robert-André Mauchin ---
All good, package accepted.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "ISC", "Unknown or generated". 37 files
have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/erlang-fuse/review-erlang-
fuse/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the
[Bug 1443759] Review Request: nodejs-is-error - Detect whether a value is an error
https://bugzilla.redhat.com/show_bug.cgi?id=1443759 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-09-21 11:33:21 --- Comment #5 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1443764] Review Request: nodejs-core-assert - Node.js 'assert' as a standalone module
https://bugzilla.redhat.com/show_bug.cgi?id=1443764 Bug 1443764 depends on bug 1443759, which changed state. Bug 1443759 Summary: Review Request: nodejs-is-error - Detect whether a value is an error https://bugzilla.redhat.com/show_bug.cgi?id=1443759 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1364656] Review Request: nodejs-resolve-dir - Resolve a directory
https://bugzilla.redhat.com/show_bug.cgi?id=1364656 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-09-21 11:36:05 --- Comment #5 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1364690] Review Request: nodejs-matched - Adds array support to node-glob, sync and async
https://bugzilla.redhat.com/show_bug.cgi?id=1364690 Bug 1364690 depends on bug 1364656, which changed state. Bug 1364656 Summary: Review Request: nodejs-resolve-dir - Resolve a directory https://bugzilla.redhat.com/show_bug.cgi?id=1364656 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1364693] Review Request: nodejs-write - Write files to disk, creating intermediate directories if they don't exist
https://bugzilla.redhat.com/show_bug.cgi?id=1364693 Bug 1364693 depends on bug 1364678, which changed state. Bug 1364678 Summary: Review Request: nodejs-read-json-sync - Read and parse a JSON file synchronously https://bugzilla.redhat.com/show_bug.cgi?id=1364678 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1364678] Review Request: nodejs-read-json-sync - Read and parse a JSON file synchronously
https://bugzilla.redhat.com/show_bug.cgi?id=1364678 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-09-21 11:43:30 --- Comment #8 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1364695] Review Request: nodejs-flat-cache - A stupidly simple key/ value storage using files to persist some data
https://bugzilla.redhat.com/show_bug.cgi?id=1364695 Bug 1364695 depends on bug 1364678, which changed state. Bug 1364678 Summary: Review Request: nodejs-read-json-sync - Read and parse a JSON file synchronously https://bugzilla.redhat.com/show_bug.cgi?id=1364678 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1364690] Review Request: nodejs-matched - Adds array support to node-glob, sync and async
https://bugzilla.redhat.com/show_bug.cgi?id=1364690 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-09-21 11:47:32 --- Comment #7 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1364691] Review Request: nodejs-delete - Delete files and folders and any intermediate directories
https://bugzilla.redhat.com/show_bug.cgi?id=1364691 Bug 1364691 depends on bug 1364690, which changed state. Bug 1364690 Summary: Review Request: nodejs-matched - Adds array support to node-glob, sync and async https://bugzilla.redhat.com/show_bug.cgi?id=1364690 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1494089] Review Request: WoeUSB - Windows USB installation media creator
https://bugzilla.redhat.com/show_bug.cgi?id=1494089
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
Hello,
- Use a more meaningful name for your archive, with:
Source0:
https://github.com/slacka/WoeUSB/archive/v%{version}/%{name}-%{version}.tar.gz
- rm -rf $RPM_BUILD_ROOT should *not* be run at the beginning of %install (or
elsewhere).
- why do you exclude the gui?
- The %changelog must contain the version:
* Wed Sep 20 2017 Matt Prahl - 2.1.3-1
- Rpmlint error:
WoeUSB.x86_64: E: wrong-script-interpreter /usr/bin/woeusb /usr/bin/env bash
Please patch it in the SPEC with sed in %install:
sed -i '1!b;s/env bash/bash/' %{buildroot}%{_bindir}/woeusb
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
generated", "MIT/X11 (BSD like)", "*No copyright* GPL (v3 or later)",
"GPL (v3 or later) (with incorrect FSF address)". 71 files have
unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/WoeUSB/review-WoeUSB/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the
[Bug 1494162] Review Request: rakudo-MIME-Base64 - A Perl6 implementation of MIME:: Base64 for ASCII strings
https://bugzilla.redhat.com/show_bug.cgi?id=1494162
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #1 from Robert-André Mauchin ---
All ok, package accepted.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Artistic (v2.0)", "Unknown or generated". 9 files have unknown
license. Detailed output of licensecheck in /home/bob/packaging/review
/rakudo-MIME-Base64/review-rakudo-MIME-Base64/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean sectio
[Bug 1494018] Review Request: erlang-fuse - A Circuit Breaker for Erlang
https://bugzilla.redhat.com/show_bug.cgi?id=1494018 --- Comment #2 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/erlang-fuse -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1364691] Review Request: nodejs-delete - Delete files and folders and any intermediate directories
https://bugzilla.redhat.com/show_bug.cgi?id=1364691 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-09-21 12:50:39 --- Comment #6 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1364693] Review Request: nodejs-write - Write files to disk, creating intermediate directories if they don't exist
https://bugzilla.redhat.com/show_bug.cgi?id=1364693 Bug 1364693 depends on bug 1364691, which changed state. Bug 1364691 Summary: Review Request: nodejs-delete - Delete files and folders and any intermediate directories https://bugzilla.redhat.com/show_bug.cgi?id=1364691 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1364693] Review Request: nodejs-write - Write files to disk, creating intermediate directories if they don't exist
https://bugzilla.redhat.com/show_bug.cgi?id=1364693 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-09-21 13:01:26 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1364695] Review Request: nodejs-flat-cache - A stupidly simple key/ value storage using files to persist some data
https://bugzilla.redhat.com/show_bug.cgi?id=1364695 Bug 1364695 depends on bug 1364693, which changed state. Bug 1364693 Summary: Review Request: nodejs-write - Write files to disk, creating intermediate directories if they don't exist https://bugzilla.redhat.com/show_bug.cgi?id=1364693 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1494176] Review Request: python-renderspec - Jinja2 template renderer for generating .spec files
https://bugzilla.redhat.com/show_bug.cgi?id=1494176
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
Hello,
- The SPEC itself is mostly fine, but you could use the %{py2_dist/%{py3_dist
macros to handle your Python dependencies. See
https://fedoraproject.org/wiki/Packaging:Python#Requires_and_BuildRequires_with_standardized_names
- You've got a bunch of rpmlint errors because of shebangs in Python
libraries:
python2-renderspec.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/renderspec/__init__.py 644 /usr/bin/python
python2-renderspec.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/renderspec/distloader.py 644 /usr/bin/python
python2-renderspec.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/renderspec/utils.py 644 /usr/bin/python
python2-renderspec.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/renderspec/versions.py 644 /usr/bin/python
python3-renderspec.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/renderspec/__init__.py 644 /usr/bin/python
python3-renderspec.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/renderspec/distloader.py 644 /usr/bin/python
python3-renderspec.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/renderspec/utils.py 644 /usr/bin/python
python3-renderspec.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/renderspec/versions.py 644 /usr/bin/python
See
https://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries
# Remove shebang
for lib in %{buildroot}%{python3_sitelib}/%{pypi_name}/{,*/}/*.py; do
sed '1{\@^#!/usr/bin/python@d}' $lib > $lib.new &&
touch -r $lib $lib.new &&
mv $lib.new $lib
done
# Remove shebang
for lib in %{buildroot}%{python2_sitelib}/%{pypi_name}/{,*/}/*.py; do
sed '1{\@^#!/usr/bin/python@d}' $lib > $lib.new &&
touch -r $lib $lib.new &&
mv $lib.new $lib
done
- #%check is commented out, it shouldn't:
%check
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Apache (v2.0)", "*No copyright* Apache", "Unknown or
generated", "*No copyright* Apache (v2.0)". 14 files have unknown
license. Detailed output of licensecheck in /home/bob/packaging/review
/python-renderspec/review-python-renderspec/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencie
[Bug 1493524] Review Request: oci-kvm-hook - An OCI hook that always adds /dev/kvm to each container
https://bugzilla.redhat.com/show_bug.cgi?id=1493524 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- Package is accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493738] Review Request: python-xappy - The "xappy" python module is an easy-to-use interface to the Xapian search engine
https://bugzilla.redhat.com/show_bug.cgi?id=1493738 --- Comment #5 from Clement Verna --- Updated Spec and SRPM Spec URL: https://cverna.fedorapeople.org/python-xappy.spec SRPM URL: https://cverna.fedorapeople.org/python2-xappy-0.6.0-0.11.fc26.src.rpm -Why did you move upstream to pagure? Are you forking the project? The upstream used to be on google code, since google decided to retire this service is not possible to get the release from it anymore. That why I move the source to pagure. - It seems that version 0.6 used to be a pre-release (under development), any comments here? Check the version guidelines [3] for pre-releases and make sure your new release is greater than the last one released before this package was retired. I believe it still should be 0.6 since it is the version of the upstream and I indeed raise the release version so that is it greater than the last release of this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493738] Review Request: python-xappy - The "xappy" python module is an easy-to-use interface to the Xapian search engine
https://bugzilla.redhat.com/show_bug.cgi?id=1493738 Clement Verna changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1494223] New: Review Request: nodejs-suspend - Async control-flow for Node.js using ES6 generators
https://bugzilla.redhat.com/show_bug.cgi?id=1494223 Bug ID: 1494223 Summary: Review Request: nodejs-suspend - Async control-flow for Node.js using ES6 generators Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: jsmith.fed...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Blocks: 956806 (nodejs-reviews), 1387531 (Node-RED) Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-suspend/nodejs-suspend.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-suspend/nodejs-suspend-0.7.0-1.fc28.src.rpm Description: Async control-flow for Node.js using ES6 generators Fedora Account System Username: jsmith Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker https://bugzilla.redhat.com/show_bug.cgi?id=1387531 [Bug 1387531] Package tracker for supporting Node-RED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1494224] New: Review Request: nodejs-gnode - Run node with ES6 Generators, today!
https://bugzilla.redhat.com/show_bug.cgi?id=1494224 Bug ID: 1494224 Summary: Review Request: nodejs-gnode - Run node with ES6 Generators, today! Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: jsmith.fed...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Depends On: 1494223 Blocks: 956806 (nodejs-reviews), 1387531 (Node-RED) Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-gnode/nodejs-gnode.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-gnode/nodejs-gnode-0.1.2-1.fc28.src.rpm Description: Run node with ES6 Generators, today! Fedora Account System Username: jsmith Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker https://bugzilla.redhat.com/show_bug.cgi?id=1387531 [Bug 1387531] Package tracker for supporting Node-RED https://bugzilla.redhat.com/show_bug.cgi?id=1494223 [Bug 1494223] Review Request: nodejs-suspend - Async control-flow for Node.js using ES6 generators -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1364959] Review Request: nodejs-ware - Easily create your own middleware layer
https://bugzilla.redhat.com/show_bug.cgi?id=1364959 Jared Smith changed: What|Removed |Added Depends On||1494224 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1494224 [Bug 1494224] Review Request: nodejs-gnode - Run node with ES6 Generators, today! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1494224] Review Request: nodejs-gnode - Run node with ES6 Generators, today!
https://bugzilla.redhat.com/show_bug.cgi?id=1494224 Jared Smith changed: What|Removed |Added Blocks||1364959 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1364959 [Bug 1364959] Review Request: nodejs-ware - Easily create your own middleware layer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1364695] Review Request: nodejs-flat-cache - A stupidly simple key/ value storage using files to persist some data
https://bugzilla.redhat.com/show_bug.cgi?id=1364695 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-09-21 13:56:29 --- Comment #8 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1364696] Review Request: nodejs-file-entry-cache - Super simple cache for file metadata
https://bugzilla.redhat.com/show_bug.cgi?id=1364696 Bug 1364696 depends on bug 1364695, which changed state. Bug 1364695 Summary: Review Request: nodejs-flat-cache - A stupidly simple key/value storage using files to persist some data https://bugzilla.redhat.com/show_bug.cgi?id=1364695 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1364959] Review Request: nodejs-ware - Easily create your own middleware layer
https://bugzilla.redhat.com/show_bug.cgi?id=1364959 --- Comment #3 from Jared Smith --- Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-ware/nodejs-ware.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-ware/nodejs-ware-1.3.0-1.fc28.src.rpm Even with your changes, I'm still having problems with the tests on this package :-( -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1443764] Review Request: nodejs-core-assert - Node.js 'assert' as a standalone module
https://bugzilla.redhat.com/show_bug.cgi?id=1443764 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-09-21 14:13:00 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493206] Review Request: nodejs-async-limiter - An asynchronous function queue with adjustable concurrency
https://bugzilla.redhat.com/show_bug.cgi?id=1493206 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-09-21 14:19:39 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493214] Review Request: nodejs-es6-promisify - Converts callback-based functions to ES6 Promises
https://bugzilla.redhat.com/show_bug.cgi?id=1493214 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-09-21 14:20:11 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1494223] Review Request: nodejs-suspend - Async control-flow for Node.js using ES6 generators
https://bugzilla.redhat.com/show_bug.cgi?id=1494223 Jared Smith changed: What|Removed |Added Blocks||1494224 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1494224 [Bug 1494224] Review Request: nodejs-gnode - Run node with ES6 Generators, today! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1492866] Review Request: exercism - Exercism command-line interface
https://bugzilla.redhat.com/show_bug.cgi?id=1492866
--- Comment #5 from Clément DAVID ---
(In reply to Robert-André Mauchin from comment #4)
> You didn't remove:
>
> %if 0%{?with_devel}
> %files devel -f devel.file-list
> %license LICENSE
> %doc CHANGELOG.md RELEASE.md README.md
> %dir %{gopath}/src/%{provider}.%{provider_tld}/%{project}
> %endif
>
> %if 0%{?with_unit_test} && 0%{?with_devel}
> %files unit-test-devel -f unit-test-devel.file-list
> %license LICENSE
> %doc CHANGELOG.md RELEASE.md README.md
> %endif
>
>
> ??
Right that's a miss ! Updated at :
Spec URL: https://davidcl.fedorapeople.org/exercism/exercism.spec
SRPM URL:
https://davidcl.fedorapeople.org/exercism/exercism-2.4.1-1.fc26.src.rpm
Description: Exercism provides a way to do the problems on https://exercism.io
Fedora Account System Username: davidcl
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493352] Review Request: nodejs-echomd - An md like conversion tool for shell terminals
https://bugzilla.redhat.com/show_bug.cgi?id=1493352 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-09-21 14:43:10 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493353] Review Request: nodejs-consolemd - An echomd conversion tool for browsers and console
https://bugzilla.redhat.com/show_bug.cgi?id=1493353 Bug 1493353 depends on bug 1493352, which changed state. Bug 1493352 Summary: Review Request: nodejs-echomd - An md like conversion tool for shell terminals https://bugzilla.redhat.com/show_bug.cgi?id=1493352 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1492866] Review Request: exercism - Exercism command-line interface
https://bugzilla.redhat.com/show_bug.cgi?id=1492866 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #6 from Robert-André Mauchin --- Ok for me, package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493353] Review Request: nodejs-consolemd - An echomd conversion tool for browsers and console
https://bugzilla.redhat.com/show_bug.cgi?id=1493353 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-09-21 14:58:56 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493355] Review Request: nodejs-tressa - A little test utility
https://bugzilla.redhat.com/show_bug.cgi?id=1493355 Bug 1493355 depends on bug 1493353, which changed state. Bug 1493353 Summary: Review Request: nodejs-consolemd - An echomd conversion tool for browsers and console https://bugzilla.redhat.com/show_bug.cgi?id=1493353 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493355] Review Request: nodejs-tressa - A little test utility
https://bugzilla.redhat.com/show_bug.cgi?id=1493355 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-09-21 15:12:19 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1442486] Review Request: nodejs-ansi-colors - Collection of ansi colors and styles
https://bugzilla.redhat.com/show_bug.cgi?id=1442486 Bug 1442486 depends on bug 1442481, which changed state. Bug 1442481 Summary: Review Request: nodejs-ansi-red - The color red, in ansi https://bugzilla.redhat.com/show_bug.cgi?id=1442481 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1443631] Review Request: nodejs-is-negated-glob - Returns an object with a negated boolean and the ! stripped
https://bugzilla.redhat.com/show_bug.cgi?id=1443631 Jared Smith changed: What|Removed |Added Status|POST|MODIFIED --- Comment #2 from Jared Smith --- 'Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1476' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1442481] Review Request: nodejs-ansi-red - The color red, in ansi
https://bugzilla.redhat.com/show_bug.cgi?id=1442481 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-09-21 15:13:02 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1442482] Review Request: nodejs-ansi-reset - The color reset, in ansi
https://bugzilla.redhat.com/show_bug.cgi?id=1442482 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-09-21 15:17:13 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1442486] Review Request: nodejs-ansi-colors - Collection of ansi colors and styles
https://bugzilla.redhat.com/show_bug.cgi?id=1442486 Bug 1442486 depends on bug 1442482, which changed state. Bug 1442482 Summary: Review Request: nodejs-ansi-reset - The color reset, in ansi https://bugzilla.redhat.com/show_bug.cgi?id=1442482 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493738] Review Request: python-xappy - The "xappy" python module is an easy-to-use interface to the Xapian search engine
https://bugzilla.redhat.com/show_bug.cgi?id=1493738 --- Comment #6 from Athos Ribeiro --- Hi Clement, thanks for the quick response. Since you I am sponsoring you, this reply is a little long so I can explain some parts of the packaging guidelines. I did not get to comment about this, but note that this package was retired because it is dead upstream. We usually avoid packaging dead projects in Fedora and when the ones we have die, we retire them. It may be a bad idea to put this back in Fedora, and since you are working directly on the package that requires python-xappy, it would be a great opportunity to remove/replace this dependency. Now, to the package: - All your package Requires and BRs should be versioned. For example, BuildRequires: python-setuptools should be BuildRequires: python2-setuptools After 2020, python-setuptools will point to python3-setuptools and your package will not build. - You can also run your tests with nosetests-2 for the same reasons above. > The upstream used to be on google code, since google decided to retire this > service is not possible to get the release from it anymore. That why I move > the source to pagure. It would be nice to add a comment about that on the specfile. Also, use upstream url for the URL tag (which is google code). I am not sure if this is the best approach here. I will check if there is a better option than just importing the project to pagure in a single commit and then give you some feedback as soon as I get an answer for that. > I believe it still should be 0.6 since it is the version of the upstream and > I indeed raise the release version so that is it greater than the last > release of this package. According to the commits in upstream SVN, they never really released version 0.6.0. The 0.6.0 version variable was set in __setup__.py in SVN commit 565. Check the author's note: "Bump version to 0.6.0 - release won't be for a little while yet, but this allows me to test the version for backward compatibility" 0.6.0-0.1.svn624 was the first Fedora package, the release tag reads 0.1.svn624. It reads 0.1 because the packager wanted to show that this was a pre-release, meaning that the author had not had released this version of the package yet, and it was being shipped anyway. When we ship a pre-release like that, we must show which revision of the VCS we are shipping, that is where the svn624 part enters: it is the number of the SVN commit being packaged for Fedora. The package was updated a few times: 0.6.0-0.2.svn624 [...] 0.6.0-0.10.svn624 0.6.0-0.11 <= Why is it missing now? You are still packaging a pre-release, so it would be nice to keep the same '.svn624' suffix there, showing whoever uses this package that they are actually using a specific revision of the package, not version 0.6.0 (nor 0.5.0) itself. Read the versioning guidelines if you have any doubts [1]. [1] https://fedoraproject.org/wiki/Packaging:Versioning -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1483154] Review Request: nodejs-set-blocking - Set blocking stdio and stderr ensuring that terminal output does not truncate
https://bugzilla.redhat.com/show_bug.cgi?id=1483154 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-09-21 15:23:00 --- Comment #5 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1485458] Review Request: orangefs - parallel network file system ( formerly PVFS2)
https://bugzilla.redhat.com/show_bug.cgi?id=1485458 --- Comment #12 from Martin Brandenburg --- (In reply to Jonathan Dieter from comment #10) > > (In reply to Jonathan Dieter from comment #8) > > > (In reply to Martin Brandenburg from comment #0) > > > > I am not sure how to handle this. I assume that the BSD/MIT style > > > > licenses will not pose a problem, but I don't know where to document it. > > > > > > Normally like this: GPLv3 and BSD and ... > > Ok, a quick note on the licensing. The NTP license is actually a variant of > MIT, and, at least according to > https://lists.fedoraproject.org/archives/list/le...@lists.fedoraproject.org/ > thread/JM7YJILE4GIFRD3J636EAT2PBOEND7WP/, should be listed as such. > > And, according https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses, > you can list LGPLv2.1 as LGPLv2. And LGPLv2 and LGPLv2+? They're still listed separately. > > Most of the client applications look for /etc/pvfs2tab. Should I patch > > it to look for /etc/orangefs/pvfs2tab? The server configuration is > > given on the command line, but this is hardcoded (or settable by > > environment variable). > > Thanks for this. If /etc/pvfs2tab is a well-known location, I sure wouldn't > change it unless upstream is planning to make the change universal. Then that will remain as it is now. > > > > The utility programs distributed and others which can be linked against > > > > our libraries will run against the server. It is also possible to use a > > > > userspace client program along with the kernel module (distributed by > > > > kernel.org and already present in Fedora). This would require running > > > > the client program and mounting the filesystem through the kernel. I > > > > suppose systemd scripts are needed, but I'm not sure what to distribute. > > > > > > If the client needs to be run with arguments to mount the filesystem, I'd > > > probably not bother with a systemd service, but if it reads the > > > configuration from /etc, a service might make sense. > > > > It doesn't need any arguments. The mount request comes in from the > > kernel with all the information it needs. I've added a systemd unit for > > it. > > > > I'm not sure how to arrange things so that systemd doesn't try to mount > > the filesystem before the daemon is started. > > You could try putting After= in the mount unit file, which would order it > after the server if and only if the server is also installed on the same > machine. If there is no server on the local machine, then the client will > start in parallel with everything else. No you've misunderstood me, though you bring up another good point. If a pvfs2 filesystem appears in fstab, it cannot be mounted before the pvfs2-client (i.e. orangefs-client.service) is running. The mount will hang until either a timeout expires or the client starts running. Given systemd's parallel nature this might not actually cause a problem, but certainly isn't very clean. And you bring up something I hadn't thought about: if the server and client are to run on the same machine, it will be necessary to start the server first. > > > The one other thing I noticed is that you're packaging .a files in your > > > -devel package. I'd remove them as part of your build process. > > > > I figure somebody may want to link statically, but I have no preference > > either way, and this is easy to change. I've left it in for now, but > > will remove if there's a Fedora policy or anyone has a strong opinion. > > Fedora has very specific guidelines if you're packaging static libraries > (see: > https://fedoraproject.org/wiki/Packaging: > Guidelines#Packaging_Static_Libraries, specifically the part about splitting > static libraries into a separate subpackage), so I'd recommend just > dropping the static libraries, unless you have a deep and overwhelming > desire to deal with the extra red tape. ;) Then I will take the static libraries out. > One major thing you need to do is remove the manual Provides in the orangefs > client package. The reason the libraries aren't automatically being > Provided: is that they're not executable, so you need to make sure they are > installed with 0755 permissions. Once you do that, rpm will automatically > add the Provides: for you. Okay fixed with Dave Love's orangefs-soname.patch. > Hopefully this will sort out some of the rpmlint errors I'm seeing. I am a > bit concerned by the shared-lib-calls-exit warning I'm getting. Do you > intend for your library to actually exit the calling program as opposed to > returning an error? Unfortunately, probably yes. I've done some quick grepping, and many of them look like places where an assert wouldn't be unreasonable. (In reply to Dave Love from comment #11) > Somewhat late, these are comments partly as a user and partly as a > packager (which may duplicate the reviewer's somewhat). I've put an > updated version of what I ran on an HPC system previously at >
[Bug 1442483] Review Request: nodejs-ansi-strikethrough - The color strikethrough, in ansi
https://bugzilla.redhat.com/show_bug.cgi?id=1442483 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-09-21 15:43:26 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1442486] Review Request: nodejs-ansi-colors - Collection of ansi colors and styles
https://bugzilla.redhat.com/show_bug.cgi?id=1442486 Bug 1442486 depends on bug 1442483, which changed state. Bug 1442483 Summary: Review Request: nodejs-ansi-strikethrough - The color strikethrough, in ansi https://bugzilla.redhat.com/show_bug.cgi?id=1442483 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1442486] Review Request: nodejs-ansi-colors - Collection of ansi colors and styles
https://bugzilla.redhat.com/show_bug.cgi?id=1442486 Bug 1442486 depends on bug 1442485, which changed state. Bug 1442485 Summary: Review Request: nodejs-ansi-white - The color white, in ansi https://bugzilla.redhat.com/show_bug.cgi?id=1442485 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1442485] Review Request: nodejs-ansi-white - The color white, in ansi
https://bugzilla.redhat.com/show_bug.cgi?id=1442485 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-09-21 15:44:56 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1442450] Review Request: nodejs-ansi-bgyellow - The color bgyellow, in ansi
https://bugzilla.redhat.com/show_bug.cgi?id=1442450 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-09-21 15:48:02 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1442486] Review Request: nodejs-ansi-colors - Collection of ansi colors and styles
https://bugzilla.redhat.com/show_bug.cgi?id=1442486 Bug 1442486 depends on bug 1442450, which changed state. Bug 1442450 Summary: Review Request: nodejs-ansi-bgyellow - The color bgyellow, in ansi https://bugzilla.redhat.com/show_bug.cgi?id=1442450 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1364699] Review Request: nodejs-linefix - Recursively repair line endings
https://bugzilla.redhat.com/show_bug.cgi?id=1364699 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-09-21 15:53:03 --- Comment #8 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1443657] Review Request: nodejs-shebang-regex - Regular expression for matching a shebang line
https://bugzilla.redhat.com/show_bug.cgi?id=1443657 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-09-21 15:55:19 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1449413] Review Request: nodejs-mock-bin - Mock any executable binary
https://bugzilla.redhat.com/show_bug.cgi?id=1449413 Bug 1449413 depends on bug 1443657, which changed state. Bug 1443657 Summary: Review Request: nodejs-shebang-regex - Regular expression for matching a shebang line https://bugzilla.redhat.com/show_bug.cgi?id=1443657 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1443659] Review Request: nodejs-shebang-command - Get the command from a shebang
https://bugzilla.redhat.com/show_bug.cgi?id=1443659 Bug 1443659 depends on bug 1443657, which changed state. Bug 1443657 Summary: Review Request: nodejs-shebang-regex - Regular expression for matching a shebang line https://bugzilla.redhat.com/show_bug.cgi?id=1443657 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1443773] Review Request: nodejs-strip-eof - Strip the End-Of-File ( EOF) character from a string/buffer
https://bugzilla.redhat.com/show_bug.cgi?id=1443773 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-09-21 15:59:54 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1443788] Review Request: nodejs-execa - A better child_process
https://bugzilla.redhat.com/show_bug.cgi?id=1443788 Bug 1443788 depends on bug 1443773, which changed state. Bug 1443773 Summary: Review Request: nodejs-strip-eof - Strip the End-Of-File (EOF) character from a string/buffer https://bugzilla.redhat.com/show_bug.cgi?id=1443773 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1493738] Review Request: python-xappy - The "xappy" python module is an easy-to-use interface to the Xapian search engine
https://bugzilla.redhat.com/show_bug.cgi?id=1493738 --- Comment #7 from Clement Verna --- > I did not get to comment about this, but note that this package was retired > because it is dead upstream. We usually avoid packaging dead projects in > Fedora and when the ones we have die, we retire them. It may be a bad idea > to put this back in Fedora, and since you are working directly on the > package that requires python-xappy, it would be a great opportunity to > remove/replace this dependency. I do agree, it is not ideal unfortunately, this package provides the backbone of fedora-packages (search engine). I could not see any easy way to replace it. There are talks about a rewrite of packages, but I don't see this happening soon. So it will be useful to have this package until we manage to remove this dependency from fedora-packages. > Now, to the package: > > - All your package Requires and BRs should be versioned. For example, > > BuildRequires: python-setuptools > should be > BuildRequires: python2-setuptools > I thought I had changed that. I will update the spec file. > According to the commits in upstream SVN, they never really released version > 0.6.0. The 0.6.0 version variable was set in __setup__.py in SVN commit 565. > Check the author's note: > > "Bump version to 0.6.0 - release won't be for a little while yet, but this > allows me to test the version for backward compatibility" > > 0.6.0-0.1.svn624 was the first Fedora package, the release tag reads > 0.1.svn624. > > It reads 0.1 because the packager wanted to show that this was a > pre-release, meaning that the author had not had released this version of > the package yet, and it was being shipped anyway. When we ship a pre-release > like that, we must show which revision of the VCS we are shipping, that is > where the svn624 part enters: it is the number of the SVN commit being > packaged for Fedora. > > The package was updated a few times: > > 0.6.0-0.2.svn624 > [...] > 0.6.0-0.10.svn624 > 0.6.0-0.11 <= Why is it missing now? > Thanks for the explanations, it makes much more sense now. I went through the version guideline one more time and it is clearer for me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1442486] Review Request: nodejs-ansi-colors - Collection of ansi colors and styles
https://bugzilla.redhat.com/show_bug.cgi?id=1442486 Jared Smith changed: What|Removed |Added Status|POST|MODIFIED --- Comment #4 from Jared Smith --- 'Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1477' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1448675] Review Request: nodejs-dargs - Convert an object of options into an array of command-line arguments
https://bugzilla.redhat.com/show_bug.cgi?id=1448675 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-09-21 16:04:35 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1364660] Review Request: nodejs-gulp-mocha - Run Mocha tests
https://bugzilla.redhat.com/show_bug.cgi?id=1364660 Bug 1364660 depends on bug 1448675, which changed state. Bug 1448675 Summary: Review Request: nodejs-dargs - Convert an object of options into an array of command-line arguments https://bugzilla.redhat.com/show_bug.cgi?id=1448675 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
