[Bug 1495845] Review Request: zegrapher - Free and opensource math graphing software
https://bugzilla.redhat.com/show_bug.cgi?id=1495845 --- Comment #10 from Fedora Update System --- zegrapher-3.0.1-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-40f54714a3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1495845] Review Request: zegrapher - Free and opensource math graphing software
https://bugzilla.redhat.com/show_bug.cgi?id=1495845 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1476434] Review Request: bstrlib - Better String Library
https://bugzilla.redhat.com/show_bug.cgi?id=1476434 --- Comment #16 from Michael Schwendt --- > libbstrsafe.so.1.0.0 -> libbstrsafe.so.1.0.0 That is evidence of a wrong and highly problematic SONAME. Let's see: eu-readelf -d libbstrsafe.so.1.0.0 |grep SONAME SONAMELibrary soname: [libbstrsafe.so.1.0.0] Indeed. It contains the full version, and the symlinks you create are superfluous and will be useless, because nothing will use them. Programs linked with bstrlib will depend on the exact SONAME. You can query the automatic RPM SONAME Provides by examining the built packages, too: $ rpm -qp --provides bstrlib-1.0.0-1.fc27.2.x86_64.rpm |grep ^lib libbstr.so.1.0.0()(64bit) libbstrc++.so.1.0.0()(64bit) libbstrsafe.so.1.0.0()(64bit) Any time there would be a minor version upgrade, all programs would need to be rebuilt to relink them. That is bad for a lib that is declared as "stable". The SONAMEs ought to end with just the major version. This is an example of a package, which seems to be simple, but even a library package can be full of pitfalls. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497508] New: Review Request: ghc-lens - Lenses, Folds and Traversals
https://bugzilla.redhat.com/show_bug.cgi?id=1497508 Bug ID: 1497508 Summary: Review Request: ghc-lens - Lenses, Folds and Traversals Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: quantum.anal...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://qulogic.fedorapeople.org//ghc-lens.spec SRPM URL: http://qulogic.fedorapeople.org//ghc-lens-4.15.4-1.git.0.154bd87.fc26.src.rpm Description: This package comes "Batteries Included" with many useful lenses for the types commonly used from the Haskell Platform, and with tools for automatically generating lenses and isomorphisms for user-supplied data types. The combinators in 'Control.Lens' provide a highly generic toolbox for composing families of getters, folds, isomorphisms, traversals, setters and lenses and their indexed variants. An overview, with a large number of examples can be found in the README at https://github.com/ekmett/lens#lens-lenses-folds-and-traversals. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497508] Review Request: ghc-lens - Lenses, Folds and Traversals
https://bugzilla.redhat.com/show_bug.cgi?id=1497508 --- Comment #1 from Elliott Sales de Andrade --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=22180991 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1495845] Review Request: zegrapher - Free and opensource math graphing software
https://bugzilla.redhat.com/show_bug.cgi?id=1495845 --- Comment #11 from Fedora Update System --- zegrapher-3.0.1-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0ddb868807 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1495845] Review Request: zegrapher - Free and opensource math graphing software
https://bugzilla.redhat.com/show_bug.cgi?id=1495845 --- Comment #12 from Fedora Update System --- zegrapher-3.0.1-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e27d9aa463 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1473314] Review Request: rclone - rsync for cloud storage
https://bugzilla.redhat.com/show_bug.cgi?id=1473314 --- Comment #8 from Robert-André Mauchin --- Version 1.38 was published yesterday: SPEC URL: https://raw.githubusercontent.com/eclipseo/packaging/2530052/rclone.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00610165-rclone/rclone-1.38-1.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497508] Review Request: ghc-lens - Lenses, Folds and Traversals
https://bugzilla.redhat.com/show_bug.cgi?id=1497508
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #2 from Robert-André Mauchin ---
Hello,
Please split the doc ito a subpackage.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 9635840 bytes in 218 files.
See:
http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (unspecified)", "BSD (2 clause)", "Unknown or generated".
30 files have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/ghc-lens/review-ghc-lens/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[?]: Package functions as des
[Bug 1497508] Review Request: ghc-lens - Lenses, Folds and Traversals
https://bugzilla.redhat.com/show_bug.cgi?id=1497508 --- Comment #3 from Elliott Sales de Andrade --- Done. Spec URL: https://qulogic.fedorapeople.org/git-annex/ghc-lens.spec SRPM URL: https://qulogic.fedorapeople.org/git-annex/ghc-lens-4.15.4-2.git.0.09c2a5e.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497482] Review Request: dnsviz - Tools for analyzing and visualizing DNS and DNSSEC behavior
https://bugzilla.redhat.com/show_bug.cgi?id=1497482 Robert-André Mauchin changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497482] Review Request: dnsviz - Tools for analyzing and visualizing DNS and DNSSEC behavior
https://bugzilla.redhat.com/show_bug.cgi?id=1497482
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
Hello,
- %clean us not needed in Fedora. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
%clean
rm -rf %{buildroot}
- The changelog must contain the version and release info, and also your mail:
* Sat Sep 30 2017 Casey Deccio - 0.6.6-1
- Remove the asterisks * at the end here:
%{python2_sitelib}/%{name}/*
%{python2_sitelib}/%{name}-%{version}-py2.7.egg-info/*
%{_datadir}/%{name}/*
otherwise these directories wouldn't be marked as owned.
- You must own %{_defaultdocdir}/%{name} and %{_defaultdocdir}/%{name}/images
too, add:
%dir %{_defaultdocdir}/%{name}
%dir %{_defaultdocdir}/%{name}/images
- You've got Python scripts with shebang. See
https://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries
to remove them.
for lib in $(find %{buildroot}%{python2_sitelib}/%{name} -name '*.py'); do
sed '1{\@^#!/usr/bin/env python@d}' $lib > $lib.new &&
touch -r $lib $lib.new &&
mv $lib.new $lib
done
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "PSF (v2)", "GPL (v2 or later)", "Unknown or generated". 81
files have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/dnsviz/review-dnsviz/licensecheck.txt
[-]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/doc/dnsviz/images,
/usr/share/dnsviz, /usr/lib/python2.7/site-packages/dnsviz-0.6.6-py2.7
.egg-info, /usr/lib/python2.7/site-packages/dnsviz
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python2.7/site-
packages/dnsviz-0.6.6-py2.7.egg-info, /usr/lib/python2.7/site-
packages/dnsviz, /usr/share/dnsviz, /usr/share/doc/dnsviz/images
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 839680 bytes in 59 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /u
[Bug 1497460] Review Request: nodejs-bind-obj-methods - Bind methods to an object from that object or some other source
https://bugzilla.redhat.com/show_bug.cgi?id=1497460 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1473314] Review Request: rclone - rsync for cloud storage
https://bugzilla.redhat.com/show_bug.cgi?id=1473314 --- Comment #9 from Igor Gnatenko --- I don't think that runtime Requires are needed. I think it is wrong ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1430146] Review Request: golang-github-mgutz-ansi - Small, fast library to create ANSI colored strings and codes.
https://bugzilla.redhat.com/show_bug.cgi?id=1430146 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- Sorry for the delay, I must have missed the Bugzilla mail: Package is accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1474694] Review Request: libcbor - C library for parsing and generating CBOR
https://bugzilla.redhat.com/show_bug.cgi?id=1474694 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1475832] Review Request: golang-github-ncw-dropbox-sdk-go-unofficial - An unofficial Go SDK for integrating with the Dropbox API v2
https://bugzilla.redhat.com/show_bug.cgi?id=1475832 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497462] Review Request: nodejs-color-support - A module which will guess your terminal' s level of color support
https://bugzilla.redhat.com/show_bug.cgi?id=1497462 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #1 from Robert-André Mauchin --- - You've got a Rpmlint error to fix: nodejs-color-support.noarch: E: wrong-script-interpreter /usr/lib/node_modules/color-support/bin.js /usr/bin/env node -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1436734] Review Request: ocfs2-tools - Tools for managing the Oracle Cluster Filesystem 2
https://bugzilla.redhat.com/show_bug.cgi?id=1436734
--- Comment #2 from Robert-André Mauchin ---
Hello,
- You must install COPYING in %license:
%files
%doc README.O2CB COPYING CREDITS MAINTAINERS
%doc documentation/users_guide.txt
%license COPYING
- make install DESTDIR=%{buildroot} ⇒ %make_install
- For clarity, please only use one BR and R per line
- Group: is not used in Fedora. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
- Build fails with:
gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector-strong --param=ssp-buffer-size=4
-grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64
-mtune=generic -Wall -Wstrict-prototypes -Wmissing-prototypes
-Wmissing-declarations -pipe-I../include -Iinclude -DVERSION=\"1.8.5\"
-MD -MP -MF ./.pass4.d -o pass4.o -c pass4.c
In file included from /usr/include/string.h:431:0,
from ../include/ocfs2/ocfs2.h:41,
from pass4.c:32:
include/strings.h:37:1: error: unknown type name 'errcode_t'; did you mean
'mode_t'?
errcode_t o2fsck_strings_insert(o2fsck_strings *strings, char *string,
^
mode_t
make[1]: Leaving directory
'/builddir/build/BUILD/ocfs2-tools-ocfs2-tools-1.8.5/fsck.ocfs2
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1492475] Review Request: aftertheflood-spark-fonts - a font to display charts within text
https://bugzilla.redhat.com/show_bug.cgi?id=1492475 --- Comment #6 from Robert-André Mauchin --- I had no reply yet. Good thing is that they've dual licensed with SIL which a font license approved by Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487067] Review Request: Botan, a C++11 crypto and TLS library, version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1487067 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487067] Review Request: Botan, a C++11 crypto and TLS library, version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1487067 Jack Lloyd changed: What|Removed |Added CC||ll...@randombit.net --- Comment #12 from Jack Lloyd --- Upstream maintainer here. I'm not aware of any patents (whatsoever, in any jurisdiction) on GOST-34.10 signature scheme. Nor am I aware of any (unexpired) patents affecting the ECC code. Obviously you can remove whatever you like, but if your legal knows something I don't please share. I know Fedora previously excluded RC5 and RC6, Botan 2.x doesn't include either of those anymore (though I believe all patents there have expired in any case). Only thing added in 2.x that I know is patented is OCB mode, for which there is a free license for open source code. OpenSSL has OCB as well so I guess you would just follow whatever decision you made for them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497508] Review Request: ghc-lens - Lenses, Folds and Traversals
https://bugzilla.redhat.com/show_bug.cgi?id=1497508 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Robert-André Mauchin --- Ok, package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1473314] Review Request: rclone - rsync for cloud storage
https://bugzilla.redhat.com/show_bug.cgi?id=1473314 --- Comment #10 from Robert-André Mauchin --- Yeah, you are right, I don't know why gofed added them in the first place. SPEC URL: https://raw.githubusercontent.com/eclipseo/packaging/0a1fd03/rclone.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-rawhide-x86_64/00610187-rclone/rclone-1.38-1.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1496885] Review Request: libnuml - Numerical Markup Language
https://bugzilla.redhat.com/show_bug.cgi?id=1496885 --- Comment #6 from Fedora Update System --- libnuml-1.1.1-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9f52a26653 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1496885] Review Request: libnuml - Numerical Markup Language
https://bugzilla.redhat.com/show_bug.cgi?id=1496885 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1496885] Review Request: libnuml - Numerical Markup Language
https://bugzilla.redhat.com/show_bug.cgi?id=1496885 --- Comment #8 from Fedora Update System --- libnuml-1.1.1-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3af99694b7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1496885] Review Request: libnuml - Numerical Markup Language
https://bugzilla.redhat.com/show_bug.cgi?id=1496885 --- Comment #7 from Fedora Update System --- libnuml-1.1.1-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d78b010f25 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497465] Review Request: nodejs-function-loop - Run a list of functions in order in a given object context
https://bugzilla.redhat.com/show_bug.cgi?id=1497465 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497467] Review Request: nodejs-own-or - Either use the object' s own property, or a fallback
https://bugzilla.redhat.com/show_bug.cgi?id=1497467 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497468] Review Request: nodejs-own-or-env - Use an objects own property, or an environment variable
https://bugzilla.redhat.com/show_bug.cgi?id=1497468 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497469] Review Request: nodejs-tsame - The logic behind tap's t.same () and t.strictSame()
https://bugzilla.redhat.com/show_bug.cgi?id=1497469 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497470] Review Request: nodejs-trivial-deferred - The most dead-simple trivial Deferred implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1497470 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497471] Review Request: nodejs-yapool - Yet Another object pool in JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1497471 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497464] Review Request: nodejs-fs-exists-cached - Just like fs.exists and fs.existsSync, but cached
https://bugzilla.redhat.com/show_bug.cgi?id=1497464 --- Comment #2 from Jared Smith --- Sorry about that -- I had a typo when I pushed it over. It should be better now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497256] Review Request: nodejs-thread-sleep - A module for when you just need node to back off for a few milliseconds
https://bugzilla.redhat.com/show_bug.cgi?id=1497256 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-10-01 09:37:41 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497255] Review Request: nodejs-try-thread-sleep - Use thread-sleep if native compilation succeeded , otherwise it's a noop
https://bugzilla.redhat.com/show_bug.cgi?id=1497255 Bug 1497255 depends on bug 1497256, which changed state. Bug 1497256 Summary: Review Request: nodejs-thread-sleep - A module for when you just need node to back off for a few milliseconds https://bugzilla.redhat.com/show_bug.cgi?id=1497256 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497219] Review Request: nodejs-rfile - Require a plain text or binary file in node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1497219 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-10-01 09:38:35 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497239] Review Request: nodejs-tar-pack - Package and un-package modules of some sort (in tar/ gz bundles)
https://bugzilla.redhat.com/show_bug.cgi?id=1497239 Bug 1497239 depends on bug 1497219, which changed state. Bug 1497219 Summary: Review Request: nodejs-rfile - Require a plain text or binary file in node.js https://bugzilla.redhat.com/show_bug.cgi?id=1497219 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497273] Review Request: nodejs-spawn-sync - Prollyfill for child_process.spawnSync
https://bugzilla.redhat.com/show_bug.cgi?id=1497273 Bug 1497273 depends on bug 1497271, which changed state. Bug 1497271 Summary: Review Request: nodejs-os-shim - Native OS module API shim for older node.js versions https://bugzilla.redhat.com/show_bug.cgi?id=1497271 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497271] Review Request: nodejs-os-shim - Native OS module API shim for older node.js versions
https://bugzilla.redhat.com/show_bug.cgi?id=1497271 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-10-01 09:39:25 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497294] Review Request: nodejs-spdy - Implementation of the SPDY protocol on node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1497294 Bug 1497294 depends on bug 1497292, which changed state. Bug 1497292 Summary: Review Request: nodejs-select-hose - Select protocol using first bytes of incoming data and hose stuff to the handler https://bugzilla.redhat.com/show_bug.cgi?id=1497292 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497460] Review Request: nodejs-bind-obj-methods - Bind methods to an object from that object or some other source
https://bugzilla.redhat.com/show_bug.cgi?id=1497460 Jared Smith changed: What|Removed |Added Status|POST|MODIFIED --- Comment #2 from Jared Smith --- Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1821 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497300] Review Request: nodejs-keep-alive-agent - A keep-alive agent for http and https
https://bugzilla.redhat.com/show_bug.cgi?id=1497300 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-10-01 09:48:30 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497304] Review Request: nodejs-server-destroy - Enable destroying a server, and all currently open connections
https://bugzilla.redhat.com/show_bug.cgi?id=1497304 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-10-01 09:49:05 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1431422] Review Request: python-agate-sql - Adds SQL read/ write support to agate
https://bugzilla.redhat.com/show_bug.cgi?id=1431422
Ye Cheng <18969068...@163.com> changed:
What|Removed |Added
CC||18969068...@163.com
--- Comment #1 from Ye Cheng <18969068...@163.com> ---
Please identify your Fedora account system user name.
This is an unofficial review.
Issues:
>URL:https://pypi.python.org/pypi/agate-sql
agate-sql could be substituted by %{pypi-name}
[!]: Uses parallel make %{?_smp_mflags} macro.
when cuilding document
[!]: Latest version is packaged.
0.52 have came out.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 18 files have
unknown license. Detailed output of licensecheck in /home/lu/1431422
-python-agate-sql/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[?]: Package contains desktop file if it is a GUI application.
Note: I am not sure about the license of example.db
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[?]: Package consistently uses macros (instead of hard-coded directory
names).
>URL:https://pypi.python.org/pypi/agate-sql
agate-sql could be substituted by %{pypi-name}
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[?]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
[x]: Avoid bundling fonts in non-fonts packages.
Note: Package contains font files
They are used for documents
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if a
[Bug 1497292] Review Request: nodejs-select-hose - Select protocol using first bytes of incoming data and hose stuff to the handler
https://bugzilla.redhat.com/show_bug.cgi?id=1497292 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-10-01 09:45:03 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497462] Review Request: nodejs-color-support - A module which will guess your terminal' s level of color support
https://bugzilla.redhat.com/show_bug.cgi?id=1497462 --- Comment #2 from Jared Smith --- Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-color-support/nodejs-color-support.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-color-support/nodejs-color-support-1.1.0-2.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497465] Review Request: nodejs-function-loop - Run a list of functions in order in a given object context
https://bugzilla.redhat.com/show_bug.cgi?id=1497465 Jared Smith changed: What|Removed |Added Status|POST|MODIFIED --- Comment #2 from Jared Smith --- Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1822 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497467] Review Request: nodejs-own-or - Either use the object' s own property, or a fallback
https://bugzilla.redhat.com/show_bug.cgi?id=1497467 Jared Smith changed: What|Removed |Added Status|POST|MODIFIED --- Comment #2 from Jared Smith --- Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1823 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497468] Review Request: nodejs-own-or-env - Use an objects own property, or an environment variable
https://bugzilla.redhat.com/show_bug.cgi?id=1497468 Jared Smith changed: What|Removed |Added Status|POST|MODIFIED --- Comment #2 from Jared Smith --- Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1824 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497469] Review Request: nodejs-tsame - The logic behind tap's t.same () and t.strictSame()
https://bugzilla.redhat.com/show_bug.cgi?id=1497469 Jared Smith changed: What|Removed |Added Status|POST|MODIFIED --- Comment #2 from Jared Smith --- Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1825 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497471] Review Request: nodejs-yapool - Yet Another object pool in JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1497471 Jared Smith changed: What|Removed |Added Status|POST|MODIFIED --- Comment #2 from Jared Smith --- Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1827 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497470] Review Request: nodejs-trivial-deferred - The most dead-simple trivial Deferred implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1497470 Jared Smith changed: What|Removed |Added Status|POST|MODIFIED --- Comment #2 from Jared Smith --- Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1826 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497239] Review Request: nodejs-tar-pack - Package and un-package modules of some sort (in tar/ gz bundles)
https://bugzilla.redhat.com/show_bug.cgi?id=1497239 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-10-01 10:08:42 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497250] Review Request: node-pre-gyp - Node.js native addon binary install tool
https://bugzilla.redhat.com/show_bug.cgi?id=1497250 Bug 1497250 depends on bug 1497239, which changed state. Bug 1497239 Summary: Review Request: nodejs-tar-pack - Package and un-package modules of some sort (in tar/gz bundles) https://bugzilla.redhat.com/show_bug.cgi?id=1497239 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497255] Review Request: nodejs-try-thread-sleep - Use thread-sleep if native compilation succeeded , otherwise it's a noop
https://bugzilla.redhat.com/show_bug.cgi?id=1497255 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-10-01 10:09:52 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497273] Review Request: nodejs-spawn-sync - Prollyfill for child_process.spawnSync
https://bugzilla.redhat.com/show_bug.cgi?id=1497273 Bug 1497273 depends on bug 1497255, which changed state. Bug 1497255 Summary: Review Request: nodejs-try-thread-sleep - Use thread-sleep if native compilation succeeded, otherwise it's a noop https://bugzilla.redhat.com/show_bug.cgi?id=1497255 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497462] Review Request: nodejs-color-support - A module which will guess your terminal' s level of color support
https://bugzilla.redhat.com/show_bug.cgi?id=1497462 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #3 from Robert-André Mauchin --- Forgot to add version 1.1.3 is out. Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497464] Review Request: nodejs-fs-exists-cached - Just like fs.exists and fs.existsSync, but cached
https://bugzilla.redhat.com/show_bug.cgi?id=1497464 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #3 from Robert-André Mauchin --- Package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1442148] Review Request: nodejs-cheerio - Tiny, fast implementation of core jQuery for the server
https://bugzilla.redhat.com/show_bug.cgi?id=1442148 Jared Smith changed: What|Removed |Added Status|POST|MODIFIED --- Comment #2 from Jared Smith --- Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1828 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497462] Review Request: nodejs-color-support - A module which will guess your terminal' s level of color support
https://bugzilla.redhat.com/show_bug.cgi?id=1497462 Jared Smith changed: What|Removed |Added Status|POST|MODIFIED --- Comment #4 from Jared Smith --- Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1829 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497464] Review Request: nodejs-fs-exists-cached - Just like fs.exists and fs.existsSync, but cached
https://bugzilla.redhat.com/show_bug.cgi?id=1497464 Jared Smith changed: What|Removed |Added Status|POST|MODIFIED --- Comment #4 from Jared Smith --- Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1830 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1384048] Review Request: python-Flask-APScheduler - Adds APScheduler support to Flask
https://bugzilla.redhat.com/show_bug.cgi?id=1384048 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #5 from Robert-André Mauchin --- (In reply to David Hannequin from comment #2) > Hi, > > I fix rpm here : > > Spec URL: > https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-Flask- > APScheduler.spec > > SRPM URL: > https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-Flask- > APScheduler-1.5.0-1.fc25.src.rpm > > LICENSE file doesn't exist. > > Thanks LICENSE file does exist in the repo. Add it as a Source: https://raw.githubusercontent.com/viniciuschiele/flask-apscheduler/master/LICENSE Please update the description as asked by Zbigniew and I'll finish the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1460325] Review Request: gnome-flashback - GNOME Flashback desktop session
https://bugzilla.redhat.com/show_bug.cgi?id=1460325 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #1 from Robert-André Mauchin --- SPEC and SRPM are 404, if you still intend to package this for Fedora, please upload them again and I'll review the package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497539] New: Review Request: vid.stab - Video stabilize library for fmpeg, mlt or transcode
https://bugzilla.redhat.com/show_bug.cgi?id=1497539 Bug ID: 1497539 Summary: Review Request: vid.stab - Video stabilize library for fmpeg, mlt or transcode Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mgans...@online.de QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/vid.stab.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/vid.stab-1.1-120170830gitafc8ea9.fc26.src.rpm Description: Vidstab is a video stabilization library which can be plugged-in with Ffmpeg and Transcode. Fedora Account System Username: martinkg rpmlint E: incorrect-fsf-address is already reported upstream https://github.com/georgmartius/vid.stab/issues/49 rpmlint -i -v vid.stab.spec /home/martin/rpmbuild/SRPMS/vid.stab-1.1-120170830gitafc8ea9.fc26.src.rpm /home/martin/rpmbuild/RPMS/x86_64/vid.stab-1.1-120170830gitafc8ea9.fc26.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/vid.stab-devel-1.1-120170830gitafc8ea9.fc26.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/vid.stab-debuginfo-1.1-120170830gitafc8ea9.fc26.x86_64.rpm vid.stab.spec: I: checking vid.stab.spec: I: checking-url https://github.com/georgmartius/vid.stab/archive/afc8ea9fb0632e0cdf781725a770edb1de788fed/vid.stab-afc8ea9.tar.gz (timeout 10 seconds) vid.stab.src: I: checking vid.stab.src: W: spelling-error Summary(en_US) fmpeg -> MPEG The value of this tag appears to be misspelled. Please double-check. vid.stab.src: W: spelling-error Summary(en_US) mlt -> ml, mt, melt The value of this tag appears to be misspelled. Please double-check. vid.stab.src: W: spelling-error Summary(en_US) transcode -> trans code, trans-code, transcendent The value of this tag appears to be misspelled. Please double-check. vid.stab.src: W: spelling-error %description -l en_US Vidstab -> Vista The value of this tag appears to be misspelled. Please double-check. vid.stab.src: E: description-line-too-long C Vidstab is a video stabilization library which can be plugged-in with Ffmpeg and Transcode. Your description lines must not exceed 80 characters. If a line is exceeding this number, cut it to fit in two lines. vid.stab.src: I: checking-url http://public.hronopik.de/vid.stab (timeout 10 seconds) vid.stab.src: I: checking-url https://github.com/georgmartius/vid.stab/archive/afc8ea9fb0632e0cdf781725a770edb1de788fed/vid.stab-afc8ea9.tar.gz (timeout 10 seconds) vid.stab.x86_64: I: checking vid.stab.x86_64: W: spelling-error Summary(en_US) fmpeg -> MPEG The value of this tag appears to be misspelled. Please double-check. vid.stab.x86_64: W: spelling-error Summary(en_US) mlt -> ml, mt, melt The value of this tag appears to be misspelled. Please double-check. vid.stab.x86_64: W: spelling-error Summary(en_US) transcode -> trans code, trans-code, transcendent The value of this tag appears to be misspelled. Please double-check. vid.stab.x86_64: W: spelling-error %description -l en_US Vidstab -> Vista The value of this tag appears to be misspelled. Please double-check. vid.stab.x86_64: E: description-line-too-long C Vidstab is a video stabilization library which can be plugged-in with Ffmpeg and Transcode. Your description lines must not exceed 80 characters. If a line is exceeding this number, cut it to fit in two lines. vid.stab.x86_64: I: checking-url http://public.hronopik.de/vid.stab (timeout 10 seconds) vid.stab.x86_64: E: incorrect-fsf-address /usr/share/licenses/vid.stab/LICENSE The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. vid.stab-devel.x86_64: I: checking vid.stab-devel.x86_64: W: spelling-error Summary(en_US) vid -> div, bid, vi The value of this tag appears to be misspelled. Please double-check. vid.stab-devel.x86_64: I: checking-url http://public.hronopik.de/vid.stab (timeout 10 seconds) vid.stab-devel.x86_64: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. vid.stab-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/boxblur.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. vid.stab-devel.x86_64: E: incorrect-fsf-address /usr/include/vid.stab/frameinfo.h The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly
[Bug 1497539] Review Request: vid.stab - Video stabilize library for fmpeg , mlt or transcode
https://bugzilla.redhat.com/show_bug.cgi?id=1497539 mgans...@alice.de changed: What|Removed |Added URL||https://github.com/georgmar ||tius/vid.stab CC||ser...@serjux.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497539] Review Request: vid.stab - Video stabilize library for fmpeg , mlt or transcode
https://bugzilla.redhat.com/show_bug.cgi?id=1497539 Antonio Trande changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1487067] Review Request: Botan, a C++11 crypto and TLS library, version 2
https://bugzilla.redhat.com/show_bug.cgi?id=1487067 Thomas Moschny changed: What|Removed |Added Blocks||182235 (FE-Legal) --- Comment #13 from Thomas Moschny --- (In reply to Jack Lloyd from comment #12) > Upstream maintainer here. I'm not aware of any patents (whatsoever, in any > jurisdiction) on GOST-34.10 signature scheme. Nor am I aware of any > (unexpired) patents affecting the ECC code. Obviously you can remove > whatever you like, but if your legal knows something I don't please share. That's why I put spot on CC. He (with his Fedora Legal Hat on) is the one to answer what can be kept and what has to be removed. (Earlier experience shows that it might not be possible for the Legal Team to share the exact reasoning, though.) Blocking FE-Legal now. But don't get me wrong: I'd be totally happy to get their OK. > Only thing added in 2.x that I know is patented is OCB mode, for which there > is a free license for open source code. OpenSSL has OCB as well so I guess > you would just follow whatever decision you made for them. Just looking at http://web.cs.ucdavis.edu/~rogaway/ocb/license.htm , I see there is a special license for OpenSSL. I would think that we need a similar license for Botan, or we have to remove OCB from the Fedora package. The reason is, that (in my own terms, IANAL) Fedora packages need to be free and not limited to Open Source projects (for the same reason the NC variants of CC are not allowed in Fedora). Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497539] Review Request: vid.stab - Video stabilize library for fmpeg , mlt or transcode
https://bugzilla.redhat.com/show_bug.cgi?id=1497539 --- Comment #1 from mgans...@alice.de --- There seems to be a bug somewhere in tests suite: https://forums.fedoraforum.org/showpost.php?p=1795399&postcount=3 sh-4.3# ./tests/tests *** UNIT TEST generateFrames(&testdata, 5) *** testframe transforms 1: Trans 5.00 -5.00 0.00 0.00 0 2: Trans -10.00 -10.00 0.00 0.00 0 3: Trans 15.00 15.00 0.052360 0.00 0 4: Trans -20.00 -20.00 0.069813 0.00 0 >Tests checks succeeded: 13/13 PASSED *** SUMMARY ** UNIT TESTs succeeded: 1/1 sh-4.3# echo $? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497273] Review Request: nodejs-spawn-sync - Prollyfill for child_process.spawnSync
https://bugzilla.redhat.com/show_bug.cgi?id=1497273 Jared Smith changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-10-01 11:49:58 --- Comment #4 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497460] Review Request: nodejs-bind-obj-methods - Bind methods to an object from that object or some other source
https://bugzilla.redhat.com/show_bug.cgi?id=1497460 --- Comment #3 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-bind-obj-methods -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1460325] Review Request: gnome-flashback - GNOME Flashback desktop session
https://bugzilla.redhat.com/show_bug.cgi?id=1460325
--- Comment #2 from Robert-André Mauchin ---
Found an SRPM on your profile, I'll review it.
Trivial issues:
- make %{?_smp_mflags} ⇒ %make_build
- make install DESTDIR=$RPM_BUILD_ROOT ⇒ %make_install
- The glib-compile-schemas scripplets shouldn't be used on Fedora 24 and
above. See
https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=481889#GSettings_Schema
- DEBUG util.py:458: Problem: conflicting requests
DEBUG util.py:458:- nothing provides gnome-applets needed by
gnome-flashback-3.24.0-1.fc28.x86_64
gnome-applets doesn't exist on Rawhide anymore (since Fedora 19 apparently).
- You have several files containing an invalid FSF address (list at the end of
the review). You should notify upstream about this and patch the files. See
https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
generated", "MIT/X11 (BSD like)", "GPL (v2 or later) (with incorrect
FSF address)", "FSF All Permissive". 259 files have unknown license.
Detailed output of licensecheck in /home/bob/packaging/review/gnome-
flashback/review-gnome-flashback/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 51200 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstre
[Bug 1497465] Review Request: nodejs-function-loop - Run a list of functions in order in a given object context
https://bugzilla.redhat.com/show_bug.cgi?id=1497465 --- Comment #3 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-function-loop -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497467] Review Request: nodejs-own-or - Either use the object' s own property, or a fallback
https://bugzilla.redhat.com/show_bug.cgi?id=1497467 --- Comment #3 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-own-or -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497468] Review Request: nodejs-own-or-env - Use an objects own property, or an environment variable
https://bugzilla.redhat.com/show_bug.cgi?id=1497468 --- Comment #3 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-own-or-env -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497469] Review Request: nodejs-tsame - The logic behind tap's t.same () and t.strictSame()
https://bugzilla.redhat.com/show_bug.cgi?id=1497469 --- Comment #3 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-tsame -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497470] Review Request: nodejs-trivial-deferred - The most dead-simple trivial Deferred implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1497470 --- Comment #3 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-trivial-deferred -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497471] Review Request: nodejs-yapool - Yet Another object pool in JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1497471 --- Comment #3 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-yapool -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1442148] Review Request: nodejs-cheerio - Tiny, fast implementation of core jQuery for the server
https://bugzilla.redhat.com/show_bug.cgi?id=1442148 --- Comment #3 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-cheerio -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497462] Review Request: nodejs-color-support - A module which will guess your terminal' s level of color support
https://bugzilla.redhat.com/show_bug.cgi?id=1497462 --- Comment #5 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-color-support -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497464] Review Request: nodejs-fs-exists-cached - Just like fs.exists and fs.existsSync, but cached
https://bugzilla.redhat.com/show_bug.cgi?id=1497464 --- Comment #5 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-fs-exists-cached -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1406881] Review Request: vint - Lint tool for Vim script Language
https://bugzilla.redhat.com/show_bug.cgi?id=1406881 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #6 from Robert-André Mauchin --- Please update to version 0.3.14 Tests fail: pkg_resources.DistributionNotFound: The 'typing>=3.6.2' distribution was not found and is required by vim-vint because it needs python-typing >= 3.6.2 and it doesn't seem to be available in Rawhide: https://koji.fedoraproject.org/koji/packageinfo?packageID=23206 I guess you'll have to contact the maintainer. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376749] Review Request: golang-github-klauspost-compress - Optimized compression packages
https://bugzilla.redhat.com/show_bug.cgi?id=1376749
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
- Please use the latest release https://github.com/klauspost/compress/releases
%global commit 6c8db69c4b49dd4df1fff66996cf556176d0b9bf
%global shortcommit %(c=%{commit}; echo ${c:0:7})
%global commitdate 20170114
Name: golang-%{provider}-%{project}-%{repo}
Version:1.2.1
Release:1%{?dist}
And:
* Sun Oct 01 2017 Matthias Runge - 1.2.1-1
- Please also fix:
W: wrong-file-end-of-line-encoding
/usr/share/doc/golang-github-klauspost-compress-devel/README.md
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "Unknown or generated". 144 files have
unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/golang-github-klauspost-compress/review-
golang-github-klauspost-compress/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode, /usr/share/gocode/src/github.com
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/gocode/src/github.com/klauspost(golang-github-klauspost-
cpuid-devel, golang-github-klauspost-crc32-devel, golang-github-
klauspost-reedsolomon-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 61440 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sou
[Bug 1406881] Review Request: vint - Lint tool for Vim script Language
https://bugzilla.redhat.com/show_bug.cgi?id=1406881 Filip Szymański changed: What|Removed |Added CC||filip.szyman...@zoho.eu --- Comment #7 from Filip Szymański --- https://github.com/Kuniwak/vint/issues/238 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1426844] Review Request: notepadqq - An advanced text editor for developers
https://bugzilla.redhat.com/show_bug.cgi?id=1426844 --- Comment #6 from William Moreno --- Hello kevin, do you still want to continúe here? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376691] Review Request: golang-github-go-macaron-macaron - A high productive and modular web framework in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1376691
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
- If upstream provides Releases, you should use them:
https://github.com/go-macaron/macaron/releases
%global commit 97f995df0bf34ca1a77c00704c9278476275566b
%global shortcommit %(c=%{commit}; echo ${c:0:7})
%global commitdate 20170817
Name: golang-%{provider}-%{project}-%{repo}
Version:1.2.2
Release:1%{?dist}
And:
* Sun Oct 01 2017 Matthias Runge - 1.2.2-1
- A dependency is missing:
DEBUG util.py:458: Problem 1: conflicting requests
DEBUG util.py:458:- nothing provides golang(github.com/Unknwon/com) needed
by golang-github-go-macaron-macaron-devel-1.2.2-1.fc28.noarch
It seems to be packaged
https://koji.fedoraproject.org/koji/packageinfo?packageID=24133 but not
available in the repo? You are listed as the admin for the package
https://src.fedoraproject.org/rpms/golang-github-Unknwon-com, did you forget to
build it?
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
(v2.0)". 15 files have unknown license. Detailed output of
licensecheck in /home/bob/packaging/review/golang-github-go-macaron-
macaron/review-golang-github-go-macaron-macaron/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/gocode/src/gopkg.in
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode/src/gopkg.in, /usr/share/gocode,
/usr/share/gocode/src/github.com
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/gocode/src/github.com/go-macaron(golang-github-go-macaron-
inject-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not
[Bug 1497549] New: Review Request: tio - Simple TTY terminal I/ O application
https://bugzilla.redhat.com/show_bug.cgi?id=1497549 Bug ID: 1497549 Summary: Review Request: tio - Simple TTY terminal I/O application Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: redhat-bugzi...@linuxnetz.de QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://labs.linuxnetz.de/bugzilla/tio.spec SRPM URL: https://labs.linuxnetz.de/bugzilla/tio-1.24-1.src.rpm Description: Tio is a simple TTY terminal application which features a straightforward commandline interface to easily connect to TTY devices for basic input/output. Fedora Account System Username: robert -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497550] New: Review Request: rakudo-XML - An Object-Oriented XML Library for Perl 6
https://bugzilla.redhat.com/show_bug.cgi?id=1497550 Bug ID: 1497550 Summary: Review Request: rakudo-XML - An Object-Oriented XML Library for Perl 6 Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: g...@zimt.uni-siegen.de QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: ftp://ftp.uni-siegen.de/pub/review/rakudo-XML/spec/rakudo-XML.spec SRPM URL: ftp://ftp.uni-siegen.de/pub/review/rakudo-XML/srpm/rakudo-XML-0.0.3-0.1.20170930git420bf9c.fc26.src.rpm Description: XML (originally called Exemel) is a full fledged XML library for Perl 6. It handles parsing, generating, manipulating and querying XML. It supports element queries, parent element information, namespaces, and an extendable interface. It supports every major kind of XML Node (XML::Node): - Document (XML::Document) - Element (XML::Element) - Text (XML::Text) - Comment (XML::Comment) - PI (XML::PI) - CDATA (XML::CDATA) You can easily serialize the objects back to XML text by using any XML::Node object in a string context. Fedora Account System Username: gerd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376691] Review Request: golang-github-go-macaron-macaron - A high productive and modular web framework in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1376691 Robert-André Mauchin changed: What|Removed |Added Blocks||1377262 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1377262 [Bug 1377262] Review Request: golang-github-go-macaron-gzip - Provides Gzip compress to responses for Macaron -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1377262] Review Request: golang-github-go-macaron-gzip - Provides Gzip compress to responses for Macaron
https://bugzilla.redhat.com/show_bug.cgi?id=1377262
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
Depends On||1376691
--- Comment #2 from Robert-André Mauchin ---
- Please use the latest git revision
(cad1c6580a07c56f5f6bc52d66002a05985c5854)
- Please use a commit date for versioning:
%global commit cad1c6580a07c56f5f6bc52d66002a05985c5854
%global shortcommit %(c=%{commit}; echo ${c:0:7})
%global commitdate 20160222
Name: golang-%{provider}-%{project}-%{repo}
Version:0
Release:0.1.%{commitdate}git%{shortcommit}%{?dist}
And:
* Fri Sep 16 2016 Matthias Runge - 0-0.1.20160222gitcad1c65
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1376691
[Bug 1376691] Review Request: golang-github-go-macaron-macaron - A high
productive and modular web framework in Go
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497539] Review Request: vid.stab - Video stabilize library for fmpeg , mlt or transcode
https://bugzilla.redhat.com/show_bug.cgi?id=1497539 --- Comment #2 from mgans...@alice.de --- test suite gives now correct exit code back. Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/vid.stab.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/vid.stab-1.1-2.20170830gitafc8ea9.fc26.src.rpm %changelog * Sat Oct 01 2017 Martin Gansser - 1.1-2.20170830gitafc8ea9 - use macros EXIT_SUCCESS and EXIT_FAILURE instead for portability reasons -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee
https://bugzilla.redhat.com/show_bug.cgi?id=1290235
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #3 from Robert-André Mauchin ---
Hello,
- Group: is not needed in Fedora. See:
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
- %clean and rm -rf $RPM_BUILD_ROOT should not be included either.
- BuildRoot: is not needed either
- Not needed too: %{!?_licensedir:%global license %%doc}
- make %{?_smp_mflags} ⇒ %make_build
- make DESTDIR=$RPM_BUILD_ROOT install ⇒ %make_install
- please only use 1 BR and R per line for clarity
- you could include ChangeLog in %doc
- I've got a build error:
configure: error: Package requirements (json-glib-1.0 >= 0.14.0) were not met:
because your BR is wrong. Fix them:
BuildRequires:pkgconfig(bitlbee) >= 3.4
BuildRequires:pkgconfig(json-glib-1.0) >= 0.14.0
- Package contains obsolete m4 macros
[!]: Package should not use obsolete m4 macros
Note: Some obsoleted macros found, see the attachment.
See: https://fedorahosted.org/FedoraReview/wiki/AutoTools
Please report it upstream and patch it.
See https://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html
Here's a patch for it:
diff -up bitlbee-facebook-1.1.2/configure.ac.remove_obsolete_macros
bitlbee-facebook-1.1.2/configure.ac
--- bitlbee-facebook-1.1.2/configure.ac.remove_obsolete_macros2017-08-31
01:22:50.0 +0200
+++ bitlbee-facebook-1.1.2/configure.ac2017-10-01 19:56:13.313441648 +0200
@@ -29,8 +29,7 @@ AM_INIT_AUTOMAKE([no-define])
AC_PROG_CC
AM_PROG_CC_C_O
-AC_DISABLE_STATIC
-AC_PROG_LIBTOOL
+LT_INIT([disable-static])
m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
m4_ifdef([AC_PROG_CC_C99], [AC_PROG_CC_C99])
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "GPL", "FSF All Permissive", "GPL (v2 or
later)", "Unknown or generated". 24 files have unknown license.
Detailed output of licensecheck in /home/bob/packaging/review/bitlbee-
facebook/review-bitlbee-facebook/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib64/bitlbee
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint me
[Bug 1497549] Review Request: tio - Simple TTY terminal I/O application
https://bugzilla.redhat.com/show_bug.cgi?id=1497549 Igor Gnatenko changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|ignate...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497549] Review Request: tio - Simple TTY terminal I/O application
https://bugzilla.redhat.com/show_bug.cgi?id=1497549
--- Comment #1 from Igor Gnatenko ---
> %if 0%{?rhel} < 7
> Group: Applications/Communications
> %endif
This doesn't make any sense, why do you want to include Group for RHEL7 and
below? Also it is wrong because %rhel is not defined on Fedora, so Group tag
will be used on Fedora as well.
> Source1:
> https://github.com/tio/tio/releases/download/v%{version}/%{name}-%{version}.tar.xz.asc
Why do you include signature, but do not verify archive?
> %{!?_licensedir:%global license %%doc}
This is not needed
---
Apart from above, looks good to me from first glance.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497549] Review Request: tio - Simple TTY terminal I/O application
https://bugzilla.redhat.com/show_bug.cgi?id=1497549 --- Comment #2 from Igor Gnatenko --- Also add --disable-silent-rules for %configure, so the build is verbose. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1290235] Review Request: bitlbee-facebook - Facebook protocol plugin for BitlBee
https://bugzilla.redhat.com/show_bug.cgi?id=1290235 --- Comment #4 from Robert Scheck --- (In reply to Robert-André Mauchin from comment #3) > - please only use 1 BR and R per line for clarity If three comma separated strings make it less readable, I'm sorry for you. > configure: error: Package requirements (json-glib-1.0 >= 0.14.0) were not > met: > > because your BR is wrong. Fix them: > > BuildRequires:pkgconfig(bitlbee) >= 3.4 > BuildRequires:pkgconfig(json-glib-1.0) >= 0.14.0 My main mistake was to use json-glib rather json-glib-devel, however the usage of pkgconfig(…) rather …-devel is IMHO not wrong per se. Spec URL: https://labs.linuxnetz.de/bugzilla/bitlbee-facebook.spec SRPM URL: https://labs.linuxnetz.de/bugzilla/bitlbee-facebook-1.1.2-2.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1443429] Review Request: quisk - Software Defined Radio (SDR) software
https://bugzilla.redhat.com/show_bug.cgi?id=1443429
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
Hello,
- Please update to latest version 4.1.10
- Use this source so you don't have to update each time:
Source0:http://james.ahlstrom.name/quisk/%{name}-%{version}.tar.gz
- # make Python scripts with shebangs executable ⇒ You should instead remove
the shebang from these files:
for lib in $(find %{buildroot}%{python2_sitelib}/%{name} -name '*.py'); do
sed '1{\@^#!/usr/bin/python@d}' $lib > $lib.new &&
touch -r $lib $lib.new &&
mv $lib.new $lib
done
- please only use one BR per line for clarity
- Your patch has mostly been included upstream. The folowing:
diff -up quisk-4.1.3/quisk.py.wx-assert quisk-4.1.3/quisk.py
--- quisk-4.1.3/quisk.py.wx-assert2016-11-30 11:26:59.0 -0700
+++ quisk-4.1.3/quisk.py2017-04-19 02:50:40.476598810 -0600
@@ -1,4 +1,4 @@
-#! /usr/bin/python
+#!/usr/bin/python2
should probably be handled with sed from within the spec:
sed -i '1 s@^#! /usr/bin/python@#!/usr/bin/python2@' quisk.py
- Source contains BSD code too:
BSD (3 clause)
--
quisk-4.1.10/usb/LICENSE
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497549] Review Request: tio - Simple TTY terminal I/O application
https://bugzilla.redhat.com/show_bug.cgi?id=1497549 --- Comment #3 from Robert Scheck --- Spec URL: https://labs.linuxnetz.de/bugzilla/tio.spec SRPM URL: https://labs.linuxnetz.de/bugzilla/tio-1.24-2.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1497549] Review Request: tio - Simple TTY terminal I/O application
https://bugzilla.redhat.com/show_bug.cgi?id=1497549 Igor Gnatenko changed: What|Removed |Added Keywords||EasyFix Status|ASSIGNED|POST Flags||fedora-review+ --- Comment #4 from Igor Gnatenko --- Nothing I can complain about now.. Apart from missing BuildRequires: gcc This is too trivial and can be fixed during import. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
