[Bug 1491216] Review Request: 5minute - Give me an instance of mine image on OpenStack

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1491216



--- Comment #16 from Pavlina Moravcova Varekova  ---
Thanks. Files are changed
Spec URL: https://people.redhat.com/pmoravec/5minute/5minute.spec
SRPM URL:
https://people.redhat.com/pmoravec/5minute/5minute-0.2.18-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510565] Review Request: ntpstat - Utility to print NTP synchronization status

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510565



--- Comment #2 from Miroslav Lichvar  ---
Thanks, I'll fix that in the next release. Would you like to do a full review?

In order to not lose ntpstat after an upgrade, I was planning to add Recommends
or Requires to the ntp package, but I'm wondering if there is not a better way.
If ntpstat obsoleted the old ntp package and required "(ntp or chrony)", I
suspect an upgrade could result in an installed ntp being replaced by chrony as
the new requirement would be satisfied without ntp.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1503175] Review Request: thonny - Python IDE for beginners

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #6 from Aivar Annamaa  ---
I made a small tweak in the upstream (removed StartupNotify from the desktop
file). New state:

* https://bitbucket.org/plas/thonny-rpm/downloads/thonny.spec
* https://bitbucket.org/plas/thonny-rpm/downloads/thonny-2.1.15-1.fc26.src.rpm
* https://copr.fedorainfracloud.org/coprs/aivarannamaa/thonny/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1509937] Review Request: ghc-yesod-persistent - Some helpers for using Persistent from Yesod

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1509937

Jens Petersen  changed:

   What|Removed |Added

 Status|POST|MODIFIED
   Fixed In Version||ghc-yesod-persistent-1.4.2-
   ||1.fc28



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1508384] Review Request: git-publish - Prepare and store patch revisions as git tags

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1508384

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1508384] Review Request: git-publish - Prepare and store patch revisions as git tags

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1508384



--- Comment #8 from Fedora Update System  ---
git-publish-1.4.2-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-893971aa25

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1508384] Review Request: git-publish - Prepare and store patch revisions as git tags

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1508384



--- Comment #9 from Fedora Update System  ---
git-publish-1.4.2-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-8a148ce945

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510869] New: Review Request: ocaml-num - Legacy Num library for arbitrary-precision integer and rational arithmetic

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510869

Bug ID: 1510869
   Summary: Review Request: ocaml-num - Legacy Num library for
arbitrary-precision integer and rational arithmetic
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: rjo...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://oirase.annexia.org/reviews/ocaml-num/ocaml-num.spec
SRPM URL:
http://oirase.annexia.org/reviews/ocaml-num/ocaml-num-1.1-1.fc28.src.rpm
Description: Legacy Num library for arbitrary-precision integer and rational
arithmetic
Fedora Account System Username: rjones

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510870] New: Review Request: ghc-yesod-form - Form handling support for Yesod Web Framework

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510870

Bug ID: 1510870
   Summary: Review Request: ghc-yesod-form - Form handling support
for Yesod Web Framework
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: peter...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://petersen.fedorapeople.org//ghc-yesod-form.spec
SRPM URL:
http://petersen.fedorapeople.org//ghc-yesod-form-1.4.16-1.fc26.src.rpm

Description:
Form handling for Yesod, in the same style as formlets.
See the forms chapter of the Yesod book.

This package provides a set of basic form inputs such as text, number, time,
checkbox, select, textarea, and etc. via Yesod.Form.Fields module.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510870] Review Request: ghc-yesod-form - Form handling support for Yesod Web Framework

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510870



--- Comment #1 from Jens Petersen  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=22991557

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510877] New: Review Request: perl-LMDB_File - Perl wrapper around the OpenLDAP's LMDB

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510877

Bug ID: 1510877
   Summary: Review Request: perl-LMDB_File - Perl wrapper around
the OpenLDAP's LMDB
   Product: Fedora
   Version: 26
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jja...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/kubco2/pkg_perl-LMDB_File/master/perl-LMDB_File.spec
SRPM URL:
https://github.com/kubco2/pkg_perl-LMDB_File/raw/master/perl-LMDB_File-0.12-1.fc26.src.rpm
Description: LMDB_File is a Perl wrapper around the OpenLDAP's LMDB (Lightning
Memory-Mapped Database) C library. Right now this package works only on x86_64
and aarch64.
Fedora Account System Username: jjanco

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510877] Review Request: perl-LMDB_File - Perl wrapper around the OpenLDAP's LMDB

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510877

Richard W.M. Jones  changed:

   What|Removed |Added

 CC||rjo...@redhat.com
   Assignee|nob...@fedoraproject.org|rjo...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510877] Review Request: perl-LMDB_File - Perl wrapper around the OpenLDAP's LMDB

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510877



--- Comment #1 from Richard W.M. Jones  ---
I think you either need to now or will need to in the future file
bugs about the failures on !64 bit and ppc64*, see:

https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Build_Failures

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510877] Review Request: perl-LMDB_File - Perl wrapper around the OpenLDAP's LMDB

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510877

Petr Pisar  changed:

   What|Removed |Added

 CC||ppi...@redhat.com



--- Comment #2 from Petr Pisar  ---
If you increase "BuildRequires:  perl(ExtUtils::MakeMaker) >= 5.16" version
constraint to >= 6.76, you can add NO_PACKLIST=1 argument to perl Makefile.PL
and remove the find command from %install section together with BuildRequires
on coreutils and findutils. Also the "%exclude %{perl_archlib}/perllocal.pod"
should be unnecessary.

I think the "rm -rf $RPM_BUILD_ROOT" command is not needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510869] Review Request: ocaml-num - Legacy Num library for arbitrary-precision integer and rational arithmetic

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510869

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
Hello,

 - Use a more meaningful name for your archive:

Source0:   
https://github.com/ocaml/num/archive/v%{version}/%{name}-%{version}.tar.gz


No other issue, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510877] Review Request: perl-LMDB_File - Perl wrapper around the OpenLDAP's LMDB

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510877



--- Comment #3 from Petr Pisar  ---
Could you please declare dependencies on all used Perl modules in Makefile.PL
(strict, Config; ExtUtils::Constant or File::Copy and File::Spec)?

The same applies to modules used when running tests (./lib and ./t
directories). We in Fedora declare all dependencies including CORE modules.

You can use "tangerine" tool from the same-named RPM package for rough
estimation what modules could be used.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510655] Review Request: rust-num-bigint - Big integer implementation for Rust

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510655



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-num-bigint

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510656] Review Request: rust-num-iter - External iterators for generic mathematics

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510656



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-num-iter

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1491216] Review Request: 5minute - Give me an instance of mine image on OpenStack

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1491216



--- Comment #17 from Neal Gompa  ---
There were some rpmlint errors raised by fedora-review:

5minute.noarch: E: wrong-script-interpreter
/usr/lib/python3.6/site-packages/vminute/__init__.py /usr/bin/env python
5minute.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/vminute/__init__.py 644 /usr/bin/env python
5minute.noarch: E: wrong-script-interpreter
/usr/lib/python3.6/site-packages/vminute/vminute.py /usr/bin/env python
5minute.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/vminute/vminute.py 644 /usr/bin/env python

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510657] Review Request: rust-pkg-config - Library to run the pkg-config system tool

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510657



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-pkg-config

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510869] Review Request: ocaml-num - Legacy Num library for arbitrary-precision integer and rational arithmetic

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510869



--- Comment #2 from Richard W.M. Jones  ---
Spec URL: http://oirase.annexia.org/reviews/ocaml-num/ocaml-num.spec
SRPM URL:
http://oirase.annexia.org/reviews/ocaml-num/ocaml-num-1.1-2.fc28.src.rpm

FWIW I updated the package with the new suggested Source0 URL ^^

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510659] Review Request: rust-thread_local - Per-object thread-local storage

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510659



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-thread_local

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510662] Review Request: rust-syn - Nom parser for Rust source code

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510662



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-syn

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1509770] Review Request: sendemail - Lightweight command line SMTP e-mail client

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1509770



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/sendemail

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1508384] Review Request: git-publish - Prepare and store patch revisions as git tags

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1508384



--- Comment #10 from Fedora Update System  ---
git-publish-1.4.2-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9fdf5dd6bd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510869] Review Request: ocaml-num - Legacy Num library for arbitrary-precision integer and rational arithmetic

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510869



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ocaml-num

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510877] Review Request: perl-LMDB_File - Perl wrapper around the OpenLDAP's LMDB

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510877



--- Comment #4 from Richard W.M. Jones  ---
rpmlint output is:

Checking: perl-LMDB_File-0.12-1.fc27.x86_64.rpm
  perl-LMDB_File-debuginfo-0.12-1.fc27.x86_64.rpm
  perl-LMDB_File-debugsource-0.12-1.fc27.x86_64.rpm
  perl-LMDB_File-0.12-1.fc27.src.rpm
perl-LMDB_File.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
perl-LMDB_File.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
perl-LMDB_File-debuginfo.x86_64: E: debuginfo-without-sources
perl-LMDB_File-debugsource.x86_64: W: no-documentation
perl-LMDB_File-debugsource.x86_64: W: devel-file-in-non-devel-package
/usr/src/debug/perl-LMDB_File-0.12-1.fc27.x86_64/LMDB.c
perl-LMDB_File-debugsource.x86_64: W: devel-file-in-non-devel-package
/usr/src/debug/perl-LMDB_File-0.12-1.fc27.x86_64/ppport.h
4 packages and 0 specfiles checked; 1 errors, 5 warnings.

I believe these can all be ignored.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510877] Review Request: perl-LMDB_File - Perl wrapper around the OpenLDAP's LMDB

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510877



--- Comment #5 from Richard W.M. Jones  ---
Package review says:

- Package contains the mandatory BuildRequires and Requires:.
  Note: Explicit dependency on perl-devel is not allowed
  See: http://fedoraproject.org/wiki/Packaging:Perl
- Header files in -devel subpackage, if present.
  Note: perl-LMDB_File-debugsource : /usr/src/debug/perl-
  LMDB_File-0.12-1.fc27.x86_64/ppport.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: coreutils findutils
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

These do seem all to be errors.

I'll wait for you to update the package according to Petr's comments
above before I do the full review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510656] Review Request: rust-num-iter - External iterators for generic mathematics

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510656

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-11-08 08:48:16



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510657] Review Request: rust-pkg-config - Library to run the pkg-config system tool

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510657

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-11-08 08:48:54



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510659] Review Request: rust-thread_local - Per-object thread-local storage

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510659

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-11-08 08:48:57



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510662] Review Request: rust-syn - Nom parser for Rust source code

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510662

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-11-08 08:49:03



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510869] Review Request: ocaml-num - Legacy Num library for arbitrary-precision integer and rational arithmetic

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510869



--- Comment #4 from Richard W.M. Jones  ---
Built into the f28-ocaml target:

https://koji.fedoraproject.org/koji/taskinfo?taskID=22993003

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510869] Review Request: ocaml-num - Legacy Num library for arbitrary-precision integer and rational arithmetic

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510869

Richard W.M. Jones  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-11-08 09:04:29



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510870] Review Request: ghc-yesod-form - Form handling support for Yesod Web Framework

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510870

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
No issue, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1508071] Review Request: golang-gopkg-sourcemap - Source Maps consumer for Golang

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1508071



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-gopkg-sourcemap. You may commit to
the branch "f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510686] Review Request: R-tikzDevice - R Graphics Output in LaTeX Format

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510686

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
Hello,

 - Consider asking upstream for a license file

All good otherwise, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1508060] Review Request: golang-github-kylelemons-godebug - Debugging helper utilities for Go

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1508060



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-kylelemons-godebug. You may
commit to the branch "f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1508020] Review Request: python-diff-cover - Automatically find diff lines that need test coverage

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1508020



--- Comment #4 from Fedora Update System  ---
python-diff-cover-0.9.12-1.fc26 python-jinja2_pluralize-0.3.0-8.fc26 has been
submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-58f1de689c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1508016] Review Request: python-jinja2_pluralize - Jinja2 pluralize filters

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1508016



--- Comment #4 from Fedora Update System  ---
python-diff-cover-0.9.12-1.fc26 python-jinja2_pluralize-0.3.0-8.fc26 has been
submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-58f1de689c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510655] Review Request: rust-num-bigint - Big integer implementation for Rust

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510655

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-11-08 10:43:56



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1508071] Review Request: golang-gopkg-sourcemap - Source Maps consumer for Golang

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1508071



--- Comment #3 from Fedora Update System  ---
golang-gopkg-sourcemap-1.0.5-1.fc27 has been submitted as an update to Fedora
27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-48c54f44ee

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1508071] Review Request: golang-gopkg-sourcemap - Source Maps consumer for Golang

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1508071

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511101] New: Review Request: rust-aho-corasick - Fast multiple substring searching with finite state machines

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511101

Bug ID: 1511101
   Summary: Review Request: rust-aho-corasick - Fast multiple
substring searching with finite state machines
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-aho-corasick.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-aho-corasick-0.6.3-3.fc28.src.rpm
Description: Fast multiple substring searching with finite state machines.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511102] New: Review Request: rust-num-rational - Rational numbers implementation for Rust

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511102

Bug ID: 1511102
   Summary: Review Request: rust-num-rational - Rational numbers
implementation for Rust
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-num-rational.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-num-rational-0.1.39-1.fc28.src.rpm
Description: Rational numbers implementation for Rust.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511104] New: Review Request: rust-serde_derive_internals - AST representation used by Serde derive macros

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511104

Bug ID: 1511104
   Summary: Review Request: rust-serde_derive_internals - AST
representation used by Serde derive macros
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-serde_derive_internals.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-serde_derive_internals-0.17.0-1.fc28.src.rpm
Description: AST representation used by Serde derive macros.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1060852] Review Request: flnet - Amateur Radio Net Control Station

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1060852



--- Comment #23 from Richard Shaw  ---
Thanks for the review! Repository has been requested.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1060852] Review Request: flnet - Amateur Radio Net Control Station

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1060852



--- Comment #24 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/flnet

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1503175] Review Request: thonny - Python IDE for beginners

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #7 from Jason Tibbitts  ---
Please note that we don't sponsor packages, we sponsor people.  The sponsor is
responsible for helping the packager get their package through the system and
providing a direct contact point for questions when existing documentation or
mailing lists aren't enough.

I am always willing to sponsor upstream developers who wish to include their
software in Fedora, but I find it vastly preferable to work via public means of
communication, particularly via IRC.  That way anyone who is available can help
instead of everything relying on my response time (which can be variable).

So if you're on IRC, I'm tibbs in #fedora-devel on freenode.  Feel free to ping
me.  And if you're not but this gets through a package review without you
having picked up a sponsor, feel free to email me.

Note also that, sadly, I don't really have the time to do proper package
review.  So someone else will need to do that.  I did have a quick look at the
spec, though, and it certainly looks clean to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1503175] Review Request: thonny - Python IDE for beginners

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #8 from Aivar Annamaa  ---
Thanks, Jason!

I'll contact you when the review gets done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1503175] Review Request: thonny - Python IDE for beginners

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1503175

Miro Hrončok  changed:

   What|Removed |Added

 CC||mhron...@redhat.com
  Flags||needinfo?(aivar.annamaa@gma
   ||il.com)



--- Comment #9 from Miro Hrončok  ---
I can do a full review and I'm also willing to sponsor you.

I would very much like to include Thonny in the Fedora Python Classroom Lab.

From reading the spec, couple of nitpicks:

 * The reason to define and use the pypi_name macro does not apply here, since
it equals the package name. I'd recommend getting rid of it and use %{name}
everywhere.


 * I believe the -n option for %autosetup is not necessary, the used value is
the default.

 * %{buildroot} already contains the trailing slash, so using %{buildroot}/ is
not necessary and may eventually lead to trouble.

 * You can use desktop-file-install instead of install + desktop-file-validate.

 * Using %{python3_sitelib}/* in the %files section is very error prone.
Instead, I recommend to go with something more specific, like
%{python3_sitelib}/thonny (I haven't yet seen what the package installs
exactly, so this might differ a bit, but a quick look at setup.py makes me
think it should work here).

 * If more icon/logo resolutions are available, it would be a good idea to
package them as well. (At least the ico file seems to have more resolution
options).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511154] New: Review Request: rust-serde_derive - Macros 1.1 implementation of #[derive(Serialize, Deserialize)]

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511154

Bug ID: 1511154
   Summary: Review Request: rust-serde_derive - Macros 1.1
implementation of #[derive(Serialize, Deserialize)]
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-serde_derive.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-serde_derive-1.0.19-1.fc28.src.rpm
Description: Macros 1.1 implementation of #[derive(Serialize, Deserialize)].
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511156] New: Review Request: rust-serde - Generic serialization/ deserialization framework

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511156

Bug ID: 1511156
   Summary: Review Request: rust-serde - Generic
serialization/deserialization framework
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-serde.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-serde-1.0.19-1.fc28.src.rpm
Description: Generic serialization/deserialization framework.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511102] Review Request: rust-num-rational - Rational numbers implementation for Rust

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511102

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511102] Review Request: rust-num-rational - Rational numbers implementation for Rust

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511102

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511101] Review Request: rust-aho-corasick - Fast multiple substring searching with finite state machines

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511101

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511101] Review Request: rust-aho-corasick - Fast multiple substring searching with finite state machines

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511101

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511104] Review Request: rust-serde_derive_internals - AST representation used by Serde derive macros

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511104

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511104] Review Request: rust-serde_derive_internals - AST representation used by Serde derive macros

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511104

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511154] Review Request: rust-serde_derive - Macros 1.1 implementation of #[derive(Serialize, Deserialize)]

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511154

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511154] Review Request: rust-serde_derive - Macros 1.1 implementation of #[derive(Serialize, Deserialize)]

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511154

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511156] Review Request: rust-serde - Generic serialization/ deserialization framework

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511156

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511156] Review Request: rust-serde - Generic serialization/ deserialization framework

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511156

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511102] Review Request: rust-num-rational - Rational numbers implementation for Rust

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511102



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-num-rational

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511101] Review Request: rust-aho-corasick - Fast multiple substring searching with finite state machines

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511101



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-aho-corasick

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511104] Review Request: rust-serde_derive_internals - AST representation used by Serde derive macros

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511104



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-serde_derive_internals

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511154] Review Request: rust-serde_derive - Macros 1.1 implementation of #[derive(Serialize, Deserialize)]

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511154



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-serde_derive

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511156] Review Request: rust-serde - Generic serialization/ deserialization framework

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511156



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-serde

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511101] Review Request: rust-aho-corasick - Fast multiple substring searching with finite state machines

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511101

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-11-08 14:48:03



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511104] Review Request: rust-serde_derive_internals - AST representation used by Serde derive macros

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511104

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-11-08 14:49:14



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1503175] Review Request: thonny - Python IDE for beginners

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1503175

Aivar Annamaa  changed:

   What|Removed |Added

  Flags|needinfo?(aivar.annamaa@gma |
   |il.com) |



--- Comment #10 from Aivar Annamaa  ---
Thanks, Miro!

I got rid of pypi_name, the -n option, extra slahs after buildroot (the slash
after %{_datadir} is required, right?). I also introduced desktop-file-install.
I also updated the version in changelog (forgot it last time).

With `%{python3_sitelib}/thonny` rpmbuild gave me:

Checking for unpackaged file(s): /usr/lib/rpm/check-files
/home/aivar/rpmbuild/BUILDROOT/thonny-2.1.15-1.fc26.x86_64
error: Installed (but unpackaged) file(s) found:
   /usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/PKG-INFO
   /usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/SOURCES.txt
  
/usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/dependency_links.txt
  
/usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/entry_points.txt
   /usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/requires.txt
   /usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/top_level.txt

I tried `%{python3_sitelib}/thonny*` instead, and it seemed to work fine.
Should I keep this?

The changes are visible here:
https://bitbucket.org/plas/thonny-rpm/commits/8e6565e3b387cde2402f296ea2f11d303582a724


I now noticed that I've forgotten a licensing issue. The toolbar icons are
licensed with EPL, so I guess I need to change `License: MIT` to `License: MIT
and EPL`. Am I right? But what should I then do with the EPL license text? (It
is included in the upstream tarball in LICENSES/ECLIPSE-ICONS-LICENSE.txt)
Currently my `%license LICENSE.txt` references the MIT license, which is the
license for the code. I didn't find clear answers from
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1508510] Review Request: qtools - Simple command-line tools for sending and receiving AMQP messages

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1508510

Alan Conway  changed:

   What|Removed |Added

 CC||ibove...@redhat.com
  Flags||needinfo?(iboverma@redhat.c
   ||om)



--- Comment #1 from Alan Conway  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

Issues:
===
Minor issues, easy to fix:

Found manually

- Source tarball contains .git directory and .gitignore files (not source
files)
- no %check in spec file
- rpmlint errors and warnings, see below

Found by fedora-review program:

- Package contains BR: python2-devel or python3-devel
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: make
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE.txt is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "*No copyright* Apache (v2.0)". 15
 files have unknown license. Detailed output of licensecheck in
 /home/aconway/tmp/qtools/review-qtools/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Sources contain only permissible code or content (.git directory was
packaged)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[-]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[-]: Package meets the Packaging Guidelines::Python (package is executable, not
a python library.)
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides 

[Bug 1485107] Review Request: R-pbdZMQ - Programming with Big Data -- Interface to ZeroMQ

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1485107

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
R-pbdZMQ-0.2.6-4.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0f68edc235

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1489340] Review Request: R-jsonlite - A Robust, High Performance JSON Parser and Generator for R

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1489340

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
R-jsonlite-1.5-5.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-583b13f08f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1485582] Review Request: R-markdown - Markdown Rendering for R

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1485582

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
R-markdown-0.8-3.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-8d824779cd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1485585] Review Request: R-htmltools - Tools for HTML

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1485585

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
R-htmltools-0.3.6-2.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9adfb8b53f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1484766] Review Request: R-repr - Serializable Representations

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1484766

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
R-repr-0.12.0-2.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-7a2f27bf82

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1485185] Review Request: R-IRdisplay - Jupyter Display Machinery

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1485185

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
R-IRdisplay-0.4.4-2.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c0808690f0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1506413] Review Request: R-stringr - Simple, Consistent Wrappers for Common String Operations

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1506413

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #10 from Fedora Update System  ---
R-stringr-1.2.0-2.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-970f9ecd9e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1507286] Review Request: R-evaluate - Parsing and Evaluation Tools that Provide More Details than the Default

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1507286

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
R-evaluate-0.10.1-5.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c4b5c2b003

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1509777] Review Request: d-din-fonts - Datto D-DIN fonts

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1509777

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
d-din-fonts-1.0-1.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d54b8e5aa7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1508016] Review Request: python-jinja2_pluralize - Jinja2 pluralize filters

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1508016

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
python-diff-cover-0.9.12-1.fc27, python-jinja2_pluralize-0.3.0-8.fc27 has been
pushed to the Fedora 27 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-3caa89333f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1508020] Review Request: python-diff-cover - Automatically find diff lines that need test coverage

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1508020

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
python-diff-cover-0.9.12-1.fc27, python-jinja2_pluralize-0.3.0-8.fc27 has been
pushed to the Fedora 27 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-3caa89333f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510209] Review Request: R-filehash - Simple Key-Value Database

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510209

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
R-filehash-2.4.1-1.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-78b377a5e5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1508384] Review Request: git-publish - Prepare and store patch revisions as git tags

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1508384

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
git-publish-1.4.2-2.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9fdf5dd6bd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1508071] Review Request: golang-gopkg-sourcemap - Source Maps consumer for Golang

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1508071

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
golang-gopkg-sourcemap-1.0.5-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-48c54f44ee

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1503175] Review Request: thonny - Python IDE for beginners

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1503175



--- Comment #11 from Miro Hrončok  ---
(In reply to Aivar Annamaa from comment #10)
> Thanks, Miro!
> 
> I got rid of pypi_name, the -n option, extra slahs after buildroot (the
> slash after %{_datadir} is required, right?)

Yes. You can check with:

$ rpm --eval '%{_datadir}'
/usr/share

> I also introduced
> desktop-file-install. I also updated the version in changelog (forgot it
> last time).

Good catch


> With `%{python3_sitelib}/thonny` rpmbuild gave me:
> 
> Checking for unpackaged file(s): /usr/lib/rpm/check-files
> /home/aivar/rpmbuild/BUILDROOT/thonny-2.1.15-1.fc26.x86_64
> error: Installed (but unpackaged) file(s) found:
>/usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/PKG-INFO
>/usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/SOURCES.txt
>   
> /usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/
> dependency_links.txt
>   
> /usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/entry_points.
> txt
>/usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/requires.txt
>   
> /usr/lib/python3.6/site-packages/thonny-2.1.15-py3.6.egg-info/top_level.txt
> 
> I tried `%{python3_sitelib}/thonny*` instead, and it seemed to work fine.
> Should I keep this?

Sorry about that, I forgot egg-info. Whether you go with thorny* or something
more sophisticated is up to you. Thorny* will continue the build even if
something like thorny_tests will get packaged by accident. I'd go with:

%{python3_sitelib}/%{name}/
%{python3_sitelib}/%{name}-%{version}-py%{python3_version}.egg-info/

Noticed the trailing slashes? I use them to make sure it's a directory.
Using %{name} here, spo others can copy paste form your spec with minimum
effort.

However this works as well:


%{python3_sitelib}/thonny/
%{python3_sitelib}/thonny-*.egg-info

It's your call here.

> 
> The changes are visible here:
> https://bitbucket.org/plas/thonny-rpm/commits/
> 8e6565e3b387cde2402f296ea2f11d303582a724

I see "%autosetup %{name}-%{version}" - you should be able to go with just
"%autosetup".

> I now noticed that I've forgotten a licensing issue. The toolbar icons are
> licensed with EPL, so I guess I need to change `License: MIT` to `License:
> MIT and EPL`. Am I right? But what should I then do with the EPL license
> text? (It is included in the upstream tarball in
> LICENSES/ECLIPSE-ICONS-LICENSE.txt) Currently my `%license LICENSE.txt`
> references the MIT license, which is the license for the code. I didn't find
> clear answers from
> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/
> LicensingGuidelines#Multiple_Licensing_Scenarios

I haven't looked at the licenses yet, but if what you say is correect, than I'd
go with the following (notice the comment):



# Code is MIT, icons are EPL
License: MIT and EPL

...


%license LICENSE.txt LICENSES/ECLIPSE-ICONS-LICENSE.txt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511102] Review Request: rust-num-rational - Rational numbers implementation for Rust

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511102

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-11-08 15:53:46



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511154] Review Request: rust-serde_derive - Macros 1.1 implementation of #[derive(Serialize, Deserialize)]

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511154

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-11-08 16:06:29



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1509770] Review Request: sendemail - Lightweight command line SMTP e-mail client

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1509770



--- Comment #4 from Fedora Update System  ---
sendemail-1.56-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-13bec62c6e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1509770] Review Request: sendemail - Lightweight command line SMTP e-mail client

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1509770

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1509770] Review Request: sendemail - Lightweight command line SMTP e-mail client

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1509770



--- Comment #5 from Fedora Update System  ---
sendemail-1.56-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9e3f53ddef

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1509770] Review Request: sendemail - Lightweight command line SMTP e-mail client

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1509770



--- Comment #6 from Fedora Update System  ---
sendemail-1.56-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-5fc6ae1c30

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1509770] Review Request: sendemail - Lightweight command line SMTP e-mail client

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1509770



--- Comment #7 from Fedora Update System  ---
sendemail-1.56-1.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-86ce304327

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511156] Review Request: rust-serde - Generic serialization/ deserialization framework

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511156

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-11-08 17:01:58



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511204] New: Review Request: rust-vec_map - Simple map based on a vector for small integer keys

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511204

Bug ID: 1511204
   Summary: Review Request: rust-vec_map - Simple map based on a
vector for small integer keys
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-vec_map.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-vec_map-0.8.0-2.fc28.src.rpm
Description: Simple map based on a vector for small integer keys.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511205] New: Review Request: rust-serde_test - Token De/ Serializer for testing De/Serialize implementations

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511205

Bug ID: 1511205
   Summary: Review Request: rust-serde_test - Token De/Serializer
for testing De/Serialize implementations
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-serde_test.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-serde_test-1.0.19-1.fc28.src.rpm
Description: Token De/Serializer for testing De/Serialize implementations.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1510686] Review Request: R-tikzDevice - R Graphics Output in LaTeX Format

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1510686



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/R-tikzDevice

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511208] New: Review Request: rust-num - Collection of numeric types and traits for Rust

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511208

Bug ID: 1511208
   Summary: Review Request: rust-num - Collection of numeric types
and traits for Rust
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-num.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-num-0.1.40-1.fc28.src.rpm
Description: Collection of numeric types and traits for Rust.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1511212] New: Review Request: rust-either - Enum [`Either`] is a general purpose sum type with two cases

2017-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1511212

Bug ID: 1511212
   Summary: Review Request: rust-either - Enum [`Either`] is a
general purpose sum type with two cases
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-either.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-either-1.3.0-1.fc28.src.rpm
Description: Enum [`Either`] is a general purpose sum type with two cases.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


  1   2   >