[Bug 1519880] Review Request: rust-cpp_demangle - Crate for demangling C++ symbols

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519880

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-12-02 02:45:57



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519782] Review Request: rust-futures-cpupool - Implementation of thread pools which hand out futures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519782

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-12-02 02:45:54



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519804] Review Request: rust-ordermap - Hash table with consistent order and fast iteration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519804

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-12-02 02:45:53



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519843] Review Request: rust-macro-attr - Macro that enables the use of custom, macro-based attributes and derivations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519843

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-12-02 02:45:52



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519891] Review Request: rust-adler32 - Minimal Adler32 implementation for Rust

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519891

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-12-02 02:45:55



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519855] Review Request: rust-stable_deref_trait - Unsafe marker trait that dereference to a stable address even when moved

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519855

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-12-02 02:45:51



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519892] Review Request: rust-typed-arena - The arena, a fast but limited type of allocator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519892

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-12-02 02:45:50



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519894] Review Request: rust-gzip-header - Crate for decoding and encoding the header part of gzip files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519894

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-12-02 02:45:48



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519081] Review Request: scribus-generator - Open source high-quality PDF template and mail-merge alternative

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519081

Jerry James  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Jerry James  ---
Rpmlint still complains:

scribus-generator.noarch: E: wrong-script-end-of-line-encoding
/usr/share/scribus/scripts/ScribusGeneratorBackend.py

That can be fixed in %prep as follows:

sed -i 's/\r//' ScribusGeneratorBackend.py

Please fix that when you import the package.  Everything else looks great, so
this package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520024] New: Review Request: netatalk - Open Source Apple Filing Protocol (AFP) File Server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520024

Bug ID: 1520024
   Summary: Review Request: netatalk - Open Source Apple Filing
Protocol (AFP) File Server
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ryan@breaker.rocks
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://breaker.rocks/netatalk.spec
SRPM URL: http://breaker.rocks/netatalk-3.1.11-1.fc28.src.rpm
Description: Netatalk is a freely-available Open Source AFP file server. A
*NIX/*BSD system running Netatalk is capable of serving many Macintosh clients
simultaneously as an AppleShare file server.
Fedora Account System Username: ryanbreaker

This is my first package contribution to any Linux distribution and I also
currently seek a sponsor. This package was previously in the Fedora
repositories but was later orphaned and abandoned in 2016
(https://src.fedoraproject.org/rpms/netatalk). This first package of mine is an
attempt to revive it to its latest version as well as maintain it.

This revision is much like the orphaned version but with Patch1 removed, which
was worked into the upstream of the project itself, as well as the sources
updated to the most recent version of 3.1.11 from the previous 3.1.7.

Except for arch s390x, which I am still troubleshooting and may require
assistance with, here is a successful scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=23489939

I have also tested this package and its service in my own environment
successfully.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468995] Review Request: python-geopandas - Geographic pandas extensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468995



--- Comment #10 from Elliott Sales de Andrade  ---
Spec URL: https://qulogic.fedorapeople.org/python-geopandas.spec
SRPM URL:
https://qulogic.fedorapeople.org/python-geopandas-0.3.0-2.fc26.src.rpm

koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=23488964

Now working on all arches (though it's a noarch package itself).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519324] Review Request: onedrive - OneDrive Free Client written in D

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519324

Iwicki Artur  changed:

   What|Removed |Added

 CC||fed...@svgames.pl



--- Comment #1 from Iwicki Artur  ---
>Group: Applications/Internet
The "Group:" tag should not be used.
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

>URL: https://github.com/skilion/onedrive
I think this should use the %{repo} macro declared at the start of the spec.

>This do not support OneDrive for business
Broken grammar. "This does not support OneDrive For Business", or maybe
"OneDrive For Business is not supported".

>sed -i 's/\/usr\/local/\/usr/' Makefile
Sed allows to use any character as the regex delimiter; if you use something
else than the slash (e.g. a pipe "|"), you won't have to escape every slash.

Also, you either forgot to roll the "Release:" tag back to 1, or there's a
missing changelog entry for 1.0.1-2.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469767] Review Request: systemd-swap - Creating hybrid swap space from zram swaps, swap files and swap partitions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469767



--- Comment #7 from Raphael Groner  ---
Less time available for development currently and so I can't promise anything,
sorry. Do you have interest to take over for this request? We could close here
and please feel free to take this as a base for your new request. You can add
me as co-maintainer after imported the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469726] Review Request: zram - Enable compressed swap in memory

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469726



--- Comment #13 from Raphael Groner  ---
Less time available for development currently and so I can't promise anything,
sorry. Do you have interest to take over for this request? We could close here
and please feel free to take this as a base for your new request. You can add
me as co-maintainer after imported the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468995] Review Request: python-geopandas - Geographic pandas extensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468995

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

  Flags|needinfo?(davejohansen@gmai |
   |l.com)  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468995] Review Request: python-geopandas - Geographic pandas extensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468995



--- Comment #9 from Volker Fröhlich  ---
You might want to add the GIS-related packages on this page:
https://fedoraproject.org/wiki/GIS

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468995] Review Request: python-geopandas - Geographic pandas extensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468995

Volker Fröhlich  changed:

   What|Removed |Added

 CC||volke...@gmx.at



--- Comment #8 from Volker Fröhlich  ---
Updated in F25 through Rawhide, thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519844] Review Request: python-pymediainfo - Python wrapper around the MediaInfo library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519844



--- Comment #2 from Vasiliy Glazov  ---
Spec URL:
https://raw.githubusercontent.com/RussianFedora/python-pymediainfo/master/python-pymediainfo.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/7548/23487548/python-pymediainfo-2.2.0-1.fc28.src.rpm

Spec corrected.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1516117] Review Request: python-hexdump - Dump binary data to hex format and restore from there

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1516117

David Carlos  changed:

   What|Removed |Added

 CC||ddavidcarlos1...@gmail.com



--- Comment #2 from David Carlos  ---
Hello Michal,

I will do a unofficial review (this is my first review).

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:

- Your patch should link to upstream bugs/comments/lists.

- Your snapshot must follows the Fedora versioning guidelines [1].

- Instead of use python%{python3_pkgversion}-setuptools, you can use py3_dist
macro. The same is applicable to python-setuptools.
On the source name, you can also use the srcname macro [2].

- The source version is different from the changelog header. The Version is
set to 3.4 and the changelog points to 3.3-1.

- There are rpmlint warnings on the python3 rpm package.

- Your rpm packages are creating files in the wrong directory. All
files installed by the package are being created in the
/usr/lib/python3.6/site-packages directory, instead
of /usr/lib/python3.6/site-packages/hexdump/ directory.
This is probably happening because your
files section have the %{python3_sitelib}/* macro, instead of
%{python3_sitelib}/hexdump/*. You can check that by running
rpm -qpl python3-hexdump-3.4-0.1.hg66325cb5fed8.fc28.noarch.rpm.

- Some files have unknown license.
techtonik-hexdump-66325cb5fed8/.hg_archival.txt
techtonik-hexdump-66325cb5fed8/.hgignore
techtonik-hexdump-66325cb5fed8/.hgtags
techtonik-hexdump-66325cb5fed8/README.txt
techtonik-hexdump-66325cb5fed8/UNLICENSE
techtonik-hexdump-66325cb5fed8/data/hexfile.bin
techtonik-hexdump-66325cb5fed8/data/hexfile.txt
techtonik-hexdump-66325cb5fed8/data/hextest.txt
techtonik-hexdump-66325cb5fed8/data/testdata-far-ansi.txt
techtonik-hexdump-66325cb5fed8/data/testdata-far-utf8.txt
techtonik-hexdump-66325cb5fed8/data/testdata.bin
techtonik-hexdump-66325cb5fed8/hexdump.py
techtonik-hexdump-66325cb5fed8/hexdump.py.setup
techtonik-hexdump-66325cb5fed8/tox.ini

[1] https://fedoraproject.org/wiki/Packaging:Versioning
[2]
https://fedoraproject.org/wiki/Packaging:Python#Requires_and_BuildRequires_with_standardized_names

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "*No copyright* Public domain". 14
 files have unknown license. Detailed output of licensecheck in
 /home/davidcarlos/rpmbuild/REVISIONS/1516117-python-
 hexdump/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/python3.6/site-
 packages/__pycache__(system-python-libs), /usr/lib/python2.7/site-
 packages/data(pilas)
[?]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are 

[Bug 1517451] Review Request: gnome-internet-radio-locator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1517451



--- Comment #3 from Ole Aamot  ---
The program gnome-internet-radio-locator replaces it and is based on GTK+ 3.0,
GNOME Maps, libchamplain and gst-player.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519880] Review Request: rust-cpp_demangle - Crate for demangling C++ symbols

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519880



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-cpp_demangle

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519894] Review Request: rust-gzip-header - Crate for decoding and encoding the header part of gzip files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519894



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-gzip-header

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519893] Review Request: rust-enum_primitive - Macro to generate num: :FromPrimitive instances for enum that works in Rust 1.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519893



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-enum_primitive

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519880] Review Request: rust-cpp_demangle - Crate for demangling C++ symbols

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519880

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- as this is a crate that provides an application, it installs binaries
correctly
- as this is a crate that provides an API, it installs sources correctly
through devel subpackage

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519880] Review Request: rust-cpp_demangle - Crate for demangling C++ symbols

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519880

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519894] Review Request: rust-gzip-header - Crate for decoding and encoding the header part of gzip files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519894

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519894] Review Request: rust-gzip-header - Crate for decoding and encoding the header part of gzip files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519894

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519893] Review Request: rust-enum_primitive - Macro to generate num: :FromPrimitive instances for enum that works in Rust 1.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519893

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519893] Review Request: rust-enum_primitive - Macro to generate num: :FromPrimitive instances for enum that works in Rust 1.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519893

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519892] Review Request: rust-typed-arena - The arena, a fast but limited type of allocator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519892



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-typed-arena

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519891] Review Request: rust-adler32 - Minimal Adler32 implementation for Rust

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519891



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-adler32

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519892] Review Request: rust-typed-arena - The arena, a fast but limited type of allocator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519892

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519891] Review Request: rust-adler32 - Minimal Adler32 implementation for Rust

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519891

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519892] Review Request: rust-typed-arena - The arena, a fast but limited type of allocator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519892

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519891] Review Request: rust-adler32 - Minimal Adler32 implementation for Rust

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519891

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519906] Review Request: CodeReview - Application to perform code review on local Git repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519906

Fabrice Salvaire  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519906] New: Review Request: CodeReview - Application to perform code review on local Git repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519906

Bug ID: 1519906
   Summary: Review Request: CodeReview - Application to perform
code review on local Git repositories
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fabrice.salva...@orange.fr
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Successful Copr build:
https://copr-be.cloud.fedoraproject.org/results/fabricesalvaire/code-review/fedora-27-x86_64/00683146-CodeReview/
Spec URL:
https://github.com/FabriceSalvaire/CodeReview/blob/master/distro/fedora/CodeReview.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/fabricesalvaire/code-review/fedora-27-x86_64/00683146-CodeReview/CodeReview-0.3.6-1.fc27.src.rpm
Description: Application to perform code review on local Git repositories
Fedora Account System Username: fabricesalvaire

Listed on https://git-scm.com/download/gui/linux

https://github.com/FabriceSalvaire/CodeReview
http://fabricesalvaire.github.io/CodeReview

https://copr.fedorainfracloud.org/coprs/fabricesalvaire/code-review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519855] Review Request: rust-stable_deref_trait - Unsafe marker trait that dereference to a stable address even when moved

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519855



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-stable_deref_trait

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1518713] Review Request: guidelines-support-library - Guidelines Support Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1518713

Vitaly Zaitsev  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-12-01 11:26:02



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519896] New: Review Request: rust-smallvec - 'Small vector' optimization: store up to a small number of items on the stack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519896

Bug ID: 1519896
   Summary: Review Request: rust-smallvec - 'Small vector'
optimization: store up to a small number of items on
the stack
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-smallvec.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-smallvec-0.5.0-1.fc28.src.rpm
Description: 'Small vector' optimization: store up to a small number of items
on the stack.
FAS account: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519760] Review Request: range-v3 - Experimental range library for C++11/14/17

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519760

Vitaly Zaitsev  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-12-01 11:25:22



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519851] Review Request: rust-scroll - Powerful, extensible, generic, endian-aware Read/Write traits for byte buffers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519851



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-scroll

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519843] Review Request: rust-macro-attr - Macro that enables the use of custom, macro-based attributes and derivations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519843



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-macro-attr

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519894] New: Review Request: rust-gzip-header - Crate for decoding and encoding the header part of gzip files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519894

Bug ID: 1519894
   Summary: Review Request: rust-gzip-header - Crate for decoding
and encoding the header part of gzip files
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-gzip-header.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-gzip-header-0.2.0-1.fc28.src.rpm
Description: Crate for decoding and encoding the header part of gzip files.
FAS account: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519893] New: Review Request: rust-enum_primitive - Macro to generate num:: FromPrimitive instances for enum that works in Rust 1.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519893

Bug ID: 1519893
   Summary: Review Request: rust-enum_primitive - Macro to
generate num::FromPrimitive instances for enum that
works in Rust 1.0
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-enum_primitive.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-enum_primitive-0.1.1-1.fc28.src.rpm
Description: Macro to generate num::FromPrimitive instances for enum that works
in Rust 1.0.
FAS account: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519804] Review Request: rust-ordermap - Hash table with consistent order and fast iteration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519804



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-ordermap

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519892] New: Review Request: rust-typed-arena - The arena, a fast but limited type of allocator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519892

Bug ID: 1519892
   Summary: Review Request: rust-typed-arena - The arena, a fast
but limited type of allocator
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-typed-arena.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-typed-arena-1.3.0-1.fc28.src.rpm
Description: The arena, a fast but limited type of allocator.
FAS account: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519891] New: Review Request: rust-adler32 - Minimal Adler32 implementation for Rust

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519891

Bug ID: 1519891
   Summary: Review Request: rust-adler32 - Minimal Adler32
implementation for Rust
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-adler32.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-adler32-1.0.2-1.fc28.src.rpm
Description: Minimal Adler32 implementation for Rust.
FAS account: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519790] Review Request: rust-seahash - Blazingly fast, portable hash function with proven statistical guarantees

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519790



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-seahash

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519782] Review Request: rust-futures-cpupool - Implementation of thread pools which hand out futures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519782



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-futures-cpupool

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519880] New: Review Request: rust-cpp_demangle - Crate for demangling C++ symbols

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519880

Bug ID: 1519880
   Summary: Review Request: rust-cpp_demangle - Crate for
demangling C++ symbols
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-cpp_demangle.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-cpp_demangle-0.2.7-1.fc28.src.rpm
Description: Crate for demangling C++ symbols.
FAS account: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519855] Review Request: rust-stable_deref_trait - Unsafe marker trait that dereference to a stable address even when moved

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519855

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519855] Review Request: rust-stable_deref_trait - Unsafe marker trait that dereference to a stable address even when moved

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519855

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519851] Review Request: rust-scroll - Powerful, extensible, generic, endian-aware Read/Write traits for byte buffers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519851

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519851] Review Request: rust-scroll - Powerful, extensible, generic, endian-aware Read/Write traits for byte buffers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519851

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519843] Review Request: rust-macro-attr - Macro that enables the use of custom, macro-based attributes and derivations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519843

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519843] Review Request: rust-macro-attr - Macro that enables the use of custom, macro-based attributes and derivations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519843

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519804] Review Request: rust-ordermap - Hash table with consistent order and fast iteration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519804

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519804] Review Request: rust-ordermap - Hash table with consistent order and fast iteration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519804

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519790] Review Request: rust-seahash - Blazingly fast, portable hash function with proven statistical guarantees

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519790

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519790] Review Request: rust-seahash - Blazingly fast, portable hash function with proven statistical guarantees

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519790

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519782] Review Request: rust-futures-cpupool - Implementation of thread pools which hand out futures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519782

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519782] Review Request: rust-futures-cpupool - Implementation of thread pools which hand out futures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519782

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519844] Review Request: python-pymediainfo - Python wrapper around the MediaInfo library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519844

Igor Gnatenko  changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #1 from Igor Gnatenko  ---
> %if 0%{?fedora}
%if 0%{?rhel} && 0%{?rhel} <= 7
and turn conditions around

* %global srcname pymediainfo and use it in package names and so

> Source0:%{url}/archive/v%{version}.tar.gz
Source0:%{url}/archive/v%{version}/%{srcname}-%{version}.tar.gz

* Move Requires/BuildRequires in respective packages

> cp -a python2 python3
I would assume that you don't need this because it should work even in same
directory.

> rm -rf $RPM_BUILD_ROOT
remove this

> %{python2_sitelib}/*
> %{python3_sitelib}/*
Be more specific here

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519844] Review Request: python-pymediainfo - Python wrapper around the MediaInfo library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519844

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ignate...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519855] New: Review Request: rust-stable_deref_trait - Unsafe marker trait that dereference to a stable address even when moved

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519855

Bug ID: 1519855
   Summary: Review Request: rust-stable_deref_trait - Unsafe
marker trait that dereference to a stable address even
when moved
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-stable_deref_trait.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-stable_deref_trait-1.0.0-1.fc28.src.rpm
Description: Unsafe marker trait that dereference to a stable address even when
moved.
FAS account: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1517451] Review Request: gnome-internet-radio-locator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1517451



--- Comment #2 from Michael Schwendt  ---
How does this new program related to "girl", which is shipped by rpmfusion?

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3485
 -> https://bugzilla.rpmfusion.org/show_bug.cgi?id=3693

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519851] New: Review Request: rust-scroll - Powerful, extensible, generic, endian-aware Read/Write traits for byte buffers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519851

Bug ID: 1519851
   Summary: Review Request: rust-scroll - Powerful, extensible,
generic, endian-aware Read/Write traits for byte
buffers
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-scroll.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-scroll-0.7.0-1.fc28.src.rpm
Description: Powerful, extensible, generic, endian-aware Read/Write traits for
byte buffers.
FAS account: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1517451] Review Request: gnome-internet-radio-locator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1517451



--- Comment #1 from Michael Schwendt  ---
*** Bug 1161834 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1161834] Review Request: girl - GNOME Internet Radio Locator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1161834

Michael Schwendt  changed:

   What|Removed |Added

 CC|bugs.mich...@gmx.net|
 Resolution|NEXTRELEASE |DUPLICATE



--- Comment #15 from Michael Schwendt  ---
Modifying ancient tickets like that serves no purpose.

Usually, what is done in the case of a new review ticket is to close the old
one as duplicate, so that one is linked and locatable easily.

*** This bug has been marked as a duplicate of bug 1517451 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519844] New: Review Request: python-pymediainfo - Python wrapper around the MediaInfo library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519844

Bug ID: 1519844
   Summary: Review Request: python-pymediainfo - Python wrapper
around the MediaInfo library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: vasc...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/RussianFedora/python-pymediainfo/master/python-pymediainfo.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/5387/23485387/python-pymediainfo-2.2.0-1.fc28.src.rpm

Description:
Python 2 and Python 3 wrapper around the MediaInfo library.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519843] New: Review Request: rust-macro-attr - Macro that enables the use of custom, macro-based attributes and derivations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519843

Bug ID: 1519843
   Summary: Review Request: rust-macro-attr - Macro that enables
the use of custom, macro-based attributes and
derivations
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-macro-attr.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-macro-attr-0.2.0-1.fc28.src.rpm
Description: Macro that enables the use of custom, macro-based attributes and
derivations.
FAS account: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519834] New: Review Request: BOUT++ - Computational fluid simulation library for curvi-linear geometries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519834

Bug ID: 1519834
   Summary: Review Request: BOUT++ - Computational fluid
simulation library for curvi-linear geometries
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: david08...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://github.com/dschwoerer/bout-spec/raw/master/bout%2B%2B.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/davidsch/bout/fedora-rawhide-x86_64/00683036-bout++/bout++-4.1.2-1.fc28.src.rpm
Description:

BOUT++ is a framework for writing fluid and plasma simulations in curvilinear
geometry. It is intended to be quite modular, with a variety of numerical
methods and time-integration solvers available. BOUT++ is primarily designed
and tested with reduced plasma fluid models in mind, but it can evolve any
number of equations, with equations appearing in a readable form.

Fedora Account System Username: davidsch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1161834] Review Request: girl - GNOME Internet Radio Locator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1161834

Ole Aamot  changed:

   What|Removed |Added

 Resolution|NOTABUG |NEXTRELEASE



--- Comment #14 from Ole Aamot  ---
Obsolete package.  See bug #1517451

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519760] Review Request: range-v3 - Experimental range library for C++11/14/17

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519760



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/range-v3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1518713] Review Request: guidelines-support-library - Guidelines Support Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1518713



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/guidelines-support-library

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519804] New: Review Request: rust-ordermap - Hash table with consistent order and fast iteration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519804

Bug ID: 1519804
   Summary: Review Request: rust-ordermap - Hash table with
consistent order and fast iteration
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-ordermap.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-ordermap-0.3.2-1.fc28.src.rpm
Description: Hash table with consistent order and fast iteration.
FAS account: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519790] New: Review Request: rust-seahash - Blazingly fast, portable hash function with proven statistical guarantees

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519790

Bug ID: 1519790
   Summary: Review Request: rust-seahash - Blazingly fast,
portable hash function with proven statistical
guarantees
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-seahash.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-seahash-3.0.5-1.fc28.src.rpm
Description: Blazingly fast, portable hash function with proven statistical
guarantees.
FAS account: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519785] New: Review Request: notepadqq - An advanced text editor for developers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519785

Bug ID: 1519785
   Summary: Review Request: notepadqq - An advanced text editor
for developers
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: j...@kcore.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Continuing where https://bugzilla.redhat.com/show_bug.cgi?id=1426844 left
off...

Spec URL:
https://github.com/jdeluyck/notepadqq-packaging/blob/master/Fedora/notepadqq.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/4438/23484438/notepadqq-1.2.0-1.fc27.src.rpm
Description: A qt text editor for developers, with advanced tools, but
remaining simple. It supports syntax highlighting, themes and more.

Fedora Account System Username: jdeluyck

Taking over to try to get notepadqq included in Fedora. I've taken up some of
the comments in the previous bug report, and updated the spec file.

I'm awaiting some comments before I further push the spec file upstream to the
author. I've updated it in the past to build newer versions.

Kodji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=23484438

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519760] Review Request: range-v3 - Experimental range library for C++11/14/17

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519760

Vasiliy Glazov  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||vasc...@gmail.com
   Assignee|nob...@fedoraproject.org|vasc...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Vasiliy Glazov  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSL (v0.0)", "*No copyright* BSL", "Unknown or generated",
 "BSL (v1.0)", "BSL", "*No copyright* BSL (v1.0)", "MIT/X11 (BSD like)
 BSL (v1.0)", "BSL (v1.0) NTP". 39 files have unknown license. Detailed
 output of licensecheck in
 /home/vascom/1519760-range-v3/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No 

[Bug 1519782] New: Review Request: rust-futures-cpupool - Implementation of thread pools which hand out futures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519782

Bug ID: 1519782
   Summary: Review Request: rust-futures-cpupool - Implementation
of thread pools which hand out futures
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-futures-cpupool.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-futures-cpupool-0.1.7-1.fc28.src.rpm
Description: Implementation of thread pools which hand out futures.
FAS account: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1518713] Review Request: guidelines-support-library - Guidelines Support Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1518713

Vasiliy Glazov  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||vasc...@gmail.com
   Assignee|nob...@fedoraproject.org|vasc...@gmail.com
  Flags||fedora-review+



--- Comment #3 from Vasiliy Glazov  ---
1. You can remove -p1 from %autosetup because there are no any patch.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "*No copyright* BSL", "Unknown or
 generated". 30 files have unknown license. Detailed output of
 licensecheck in /home/vascom/1518713-guidelines-support-
 library/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file 

[Bug 1519346] Review Request: python37 - Version 3.7 of the Python interpreter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519346



--- Comment #7 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python37. You may commit to the branch "f27"
in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519747] Review request: libdigidocpp - Library offers creating, signing and verification of digitally signed documents, according to XAdES and XML-DSIG standards

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519747

Germano Massullo  changed:

   What|Removed |Added

 Blocks||1519749




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1519749
[Bug 1519749] Review request: qdigidoc - Estonian digital signature
application
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519749] New: Review request: qdigidoc - Estonian digital signature application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519749

Bug ID: 1519749
   Summary: Review request: qdigidoc - Estonian digital signature
application
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: germano.massu...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Depends On: 1519747



Unretiring https://src.fedoraproject.org/rpms/qdigidoc

Description
QDigiDoc is an application for digitally signing and encrypting documents in
ASiC-E, BDoc, DDoc, and CDoc container formats. These file formats are
widespread in Estonia where they are used for storing legally binding digital
signatures.

https://germano.fedorapeople.org/package_reviews/qdigidoc/qdigidoc.spec

https://germano.fedorapeople.org/package_reviews/qdigidoc/qdigidoc-3.13.4-1.fc27.src.rpm


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1519747
[Bug 1519747] Review request: libdigidocpp - Library offers creating,
signing and verification of digitally signed documents, according to XAdES
and XML-DSIG standards
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1518957] Review request: esteidcerts - Estonian ID card root, intermediate and OCSP certificates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1518957

Germano Massullo  changed:

   What|Removed |Added

 Blocks||1519747




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1519747
[Bug 1519747] Review request: libdigidocpp - Library offers creating,
signing and verification of digitally signed documents, according to XAdES
and XML-DSIG standards
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519747] New: Review request: libdigidocpp - Library offers creating, signing and verification of digitally signed documents, according to XAdES and XML-DSIG standards

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519747

Bug ID: 1519747
   Summary: Review request: libdigidocpp - Library offers
creating, signing and verification of digitally signed
documents, according to XAdES and XML-DSIG standards
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: germano.massu...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Depends On: 1518957



Unretiring qesteidutil package
https://src.fedoraproject.org/rpms/libdigidocpp

Description
Libdigidocpp library offers creating, signing and verification of digitally
signed documents, according to XAdES and XML-DSIG standards. Documentation
http://open-eid.github.io/libdigidocpp

https://germano.fedorapeople.org/package_reviews/libdigidocpp/libdigidocpp.spec

https://germano.fedorapeople.org/package_reviews/libdigidocpp/libdigidocpp-3.13.2-1.fc27.src.rpm


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1518957
[Bug 1518957] Review request: esteidcerts - Estonian ID card root,
intermediate and OCSP certificates
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1117223] Review Request: kronometer - A simple KDE stopwatch application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1117223

Germano Massullo  changed:

   What|Removed |Added

   Assignee|germano.massu...@gmail.com  |nob...@fedoraproject.org
  Flags|fedora-review?  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519590] Review Request: module-build-service-copr - Copr plugin for the Module Build Service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519590



--- Comment #2 from Igor Gnatenko  ---
> %if 0%{?fedora}
> %global with_python3 1
> %else
> %global with_python3 0
> %endif

%if 0%{?rhel} && 0%{?rhel} <= 7
%bcond_with python3
%else
%bcond_without python3
%endif

* Move Requires/BuildRequires under appropriate subpackages

> %{python3_sitelib}/*

Be more specific here.

> * Tue Nov 28 2017 Jakub Kadlčík  0.1-1

Version is wrong, encoding is wrong.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519719] Review Request: php-phpunit-mock-objects5 - Mock Object library for PHPUnit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519719



--- Comment #1 from Remi Collet  ---
If interested in PHPUnit 6.5 (for testing of this new version)
available in my repostiory

See:
https://git.remirepo.net/cgit/rpms/php/phpunit/phpunit6.git/commit/?id=4aab3627f084f847c939abd37e02c18adc042666

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519719] New: Review Request: php-phpunit-mock-objects5 - Mock Object library for PHPUnit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519719

Bug ID: 1519719
   Summary: Review Request: php-phpunit-mock-objects5 - Mock
Object library for PHPUnit
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fed...@famillecollet.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://git.remirepo.net/cgit/rpms/php/phpunit/php-phpunit-mock-objects5.git/plain/php-phpunit-mock-objects5.spec?id=6c362a772380e7437688fe0a830ad195bd5c75de
SRPM URL:
http://rpms.remirepo.net/SRPMS/php-phpunit-mock-objects5-5.0.0-0.remi.src.rpm
Description: 
Mock Object library for PHPUnit

Fedora Account System Username: remi


---

New dependency on PHPUnit 6.5

WARNING: because of bug #1505030 fedora-review is unable to download to right
spec file.

Latest changes (in my git) are mostly switch from boostrap to normal build
(because of circular dependency on PHPUnit 6.5)

After import, php-phpunit-mock-objects4 will be removed from the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1513669] Review Request: php-phpmailer6 - Full-featured email creation and transfer class for PHP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1513669



--- Comment #2 from Remi Collet  ---
Updated to 6.0.2

Spec:
https://git.remirepo.net/cgit/rpms/php/phpmailer/php-phpmailer6.git/plain/php-phpmailer6.spec?id=14399d94b9aac19eb768d63466c7b323644bc6ed
Srpm: http://rpms.remirepo.net/SRPMS/php-phpmailer6-6.0.2-1.remi.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519346] Review Request: python37 - Version 3.7 of the Python interpreter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519346



--- Comment #6 from Zbigniew Jędrzejewski-Szmek  ---
Great. I guess that having /usr/lib64/libpython3.7m.so is enough.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org