[Bug 1520568] Review Request: perl-Crypt-MySQL - Emulate MySQL PASSWORD() function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520568

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Jitka Plesnikova  ---
> BuildRequires
> FIX: Please add following buildrequires:
>  - perl(DBI) - t/03_dbi.t:6
>  - perl(Exporter) - lib/Crypt/MySQL.pm:17
>  - perl(strict) - Build.PL:1
>  - perl(vars) - lib/Crypt/MySQL.pm:4
>  - perl(warnings) - Build.PL:2
>  - perl(XSLoader) - lib/Crypt/MySQL.pm:10
> FIX: Please add perl-devel and gcc, because it is XS package
Ok.

> $ rpm -qp --requires perl-Crypt-MySQL-0.04-1.fc28.x86_64.rpm | sort | uniq -c
>   1 libc.so.6()(64bit)
>   1 libc.so.6(GLIBC_2.2.5)(64bit)
>   1 libc.so.6(GLIBC_2.3.4)(64bit)
>   1 libc.so.6(GLIBC_2.4)(64bit)
>   1 libperl.so.5.26()(64bit)
>   1 perl(Digest::SHA1)
>   1 perl(:MODULE_COMPAT_5.26.1)
>   1 perl(strict)
>   1 perl(vars)
>   1 rpmlib(CompressedFileNames) <= 3.0.4-1
>   1 rpmlib(FileDigests) <= 4.6.0-1
>   1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
>   1 rpmlib(PayloadIsXz) <= 5.2-1
>   1 rtld(GNU_HASH)
> FIX: Please add run-requires
>  - perl(Exporter)
>  - perl(XSLoader)
Ok.

Package looks good.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268744] Review Request: rubygem-ast - A library for working with Abstract Syntax Trees

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268744



--- Comment #5 from Ilya Gradina  ---
(In reply to Vít Ondruch from comment #4)
> Could you please consider removing the following build dependencies:
> 
> BuildRequires: rubygem(bacon-colored_output)
> BuildRequires: rubygem(simplecov)
> BuildRequires: rubygem(coveralls)
> BuildRequires: rubygem(yard)
> 
> I don't think they are strictly necessary for build of the package. We don't
> care about code coverage (simplecov, coveralls), the documentation doesn't
> need to by in yard formant and if the bacon output is colored or not, it
> changes nothing.

new spec:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-ast.spec
new srpm:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-ast-2.3.0-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268698] Review Request: rubygem-guard-bundler - Guard gem for Bundler

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268698



--- Comment #4 from Ilya Gradina  ---
(In reply to Robert-André Mauchin from comment #2)
> Also grab the license from upstream:
> 
> https://raw.githubusercontent.com/guard/guard-bundler/master/LICENSE

the license is already present

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268698] Review Request: rubygem-guard-bundler - Guard gem for Bundler

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268698

Ilya Gradina  changed:

   What|Removed |Added

 Depends On||1516328




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1516328
[Bug 1516328] Review Request: rubygem-guard-compat - Tools for developing
Guard compatible plugins
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1516328] Review Request: rubygem-guard-compat - Tools for developing Guard compatible plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1516328

Ilya Gradina  changed:

   What|Removed |Added

 Blocks||1268698




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1268698
[Bug 1268698] Review Request: rubygem-guard-bundler - Guard gem for Bundler
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268698] Review Request: rubygem-guard-bundler - Guard gem for Bundler

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268698



--- Comment #5 from Ilya Gradina  ---
new spec:
https://raw.githubusercontent.com/ilgrad/fedora-packages/master/rubygems/rubygem-guard-bundler.spec
new srpm:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-guard-bundler-2.1.0-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268698] Review Request: rubygem-guard-bundler - Guard gem for Bundler

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268698



--- Comment #3 from Robert-André Mauchin  ---
Missing runtime deps:


Runtime Dependencies (3):
bundler ~> 1.0
guard ~> 2.2 → not packaged
guard-compat ~> 1.1 → not packaged

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268698] Review Request: rubygem-guard-bundler - Guard gem for Bundler

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268698

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #2 from Robert-André Mauchin  ---
Also grab the license from upstream:

https://raw.githubusercontent.com/guard/guard-bundler/master/LICENSE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520585] Review Request: perl-Test-SQL-Data - Helps running SQL tests : database preparing and result matching

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520585



--- Comment #3 from Robert-André Mauchin  ---
Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/0b84599/perl-Test-SQL-Data.spec
 
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00685178-perl-Test-SQL-Data/perl-Test-SQL-Data-0.0.6-1.fc28.src.rpm

SPEC diff:
https://github.com/eclipseo/packaging/compare/047fc7fca9631e153ad240528ee5048b15fba725...0b8459908aa551796eb7d3cecdf18813968547e7#diff-0ec5c037792d877cec8d1450f1ce4732


Thanks for the reviews!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520570] Review Request: perl-Scalar-String - String aspects of scalars

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520570



--- Comment #2 from Robert-André Mauchin  ---
Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/044a039/perl-Scalar-String.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00685171-perl-Scalar-String/perl-Scalar-String-0.003-1.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520584] Review Request: perl-MooseX-Types-NetAddr-IP - NetAddr:: IP related types and coercions for Moose

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520584



--- Comment #3 from Robert-André Mauchin  ---
Final changes following feedback from other review:

Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/044a039/perl-MooseX-Types-NetAddr-IP.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00684670-perl-MooseX-Types-NetAddr-IP/perl-MooseX-Types-NetAddr-IP-0.07-1.fc28.src.rpm


SPEC diff:
https://github.com/eclipseo/packaging/commit/044a03915082b110c40bbfbadc70c339554545de#diff-812e936b32511716e815c02974f34fb1



Thanks for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520582] Review Request: perl-Mojolicious-Plugin-I18N - Internationalization Plugin for Mojolicious

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520582



--- Comment #2 from Robert-André Mauchin  ---
Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/044a039/perl-Mojolicious-Plugin-I18N.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00685167-perl-Mojolicious-Plugin-I18N/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520571



--- Comment #6 from Robert-André Mauchin  ---
Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/044a039/perl-Data-Integer.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00685165-perl-Data-Integer/perl-Data-Integer-0.006-1.fc28.src.rpm

SPEC diff:
https://github.com/eclipseo/packaging/commit/044a03915082b110c40bbfbadc70c339554545de#diff-12ce820cb7d7c06d431cb39906fa6237

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917

Robert-André Mauchin  changed:

   What|Removed |Added

 Blocks||1520569




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1520569
[Bug 1520569] Review Request: perl-Crypt-UnixCrypt_XS - Perl xs interface
for a portable traditional crypt function
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520569] Review Request: perl-Crypt-UnixCrypt_XS - Perl xs interface for a portable traditional crypt function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520569

Robert-André Mauchin  changed:

   What|Removed |Added

 Depends On||1522917



--- Comment #2 from Robert-André Mauchin  ---
Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/044a039/perl-Crypt-UnixCrypt_XS.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00685164-perl-Crypt-UnixCrypt_XS/perl-Crypt-UnixCrypt_XS-0.11-1.fc28.src.rpm


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1522917
[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for
looping constructs
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917



--- Comment #1 from Robert-André Mauchin  ---
Forgot some BR.

Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/01555df/perl-Algorithm-Loops.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00685163-perl-Algorithm-Loops/perl-Algorithm-Loops-1.032-1.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520568] Review Request: perl-Crypt-MySQL - Emulate MySQL PASSWORD() function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520568



--- Comment #2 from Robert-André Mauchin  ---
Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/044a039/perl-Crypt-MySQL.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00685148-perl-Crypt-MySQL/perl-Crypt-MySQL-0.04-1.fc28.src.rpm


SPEC Diff:
https://github.com/eclipseo/packaging/commit/044a03915082b110c40bbfbadc70c339554545de#diff-a47b802852c67a90d3f8178f444cba99

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520581] Review Request: perl-Authen-Passphrase - Hashed passwords/ passphrases as objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520581



--- Comment #2 from Robert-André Mauchin  ---
Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/044a039/perl-Authen-Passphrase.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00685145-perl-Authen-Passphrase/perl-Authen-Passphrase-0.008-1.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520572] Review Request: perl-Authen-DecHpwd - DEC VMS password hashing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520572



--- Comment #2 from Robert-André Mauchin  ---
Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/044a039/perl-Authen-DecHpwd.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00685142-perl-Authen-DecHpwd/perl-Authen-DecHpwd-2.007-1.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] New: Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917

Bug ID: 1522917
   Summary: Review Request: perl-Algorithm-Loops - Perl module for
looping constructs
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: zebo...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/044a039/perl-Algorithm-Loops.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00685135-perl-Algorithm-Loops/perl-Algorithm-Loops-1.032-1.fc28.src.rpm

Description:
Looping constructs: NestedLoops, MapCar*, Filter, and NextPermute*

Fedora Account System Username: eclipseo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268698] Review Request: rubygem-guard-bundler - Guard gem for Bundler

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268698

Jaroslav Prokop  changed:

   What|Removed |Added

 CC||jar.pro...@volny.cz



--- Comment #1 from Jaroslav Prokop  ---
Hi Ilya, I did informal review on your package and I found following:

* Group is not needed
  - Group tags are not needed currently, so you should delete lines:
~~~
Group: Development/Languages
~~~

~~~
Group: Documentation
~~~

* Tests are not working
  - Tests are not working properly, because it seems upstream didn't include
spec  
folder in the gem. Please fix this.

* Include Runtime Dependencies
  - With tests I discovered there are runtime dependencies that need to be
added.
Please do so.

I did not discover other errors.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1518262



--- Comment #5 from Neal Gompa  ---
(In reply to Zuzana Svetlikova from comment #4)
> > Upstream does not advise that yarn sources are retrieved from npm and 
> > suggest it should be packaged from the pristine sources uploaded to GitHub.
> 
> I haven't seen such information. But I admit, that among alternative install
> methods[1] they state "installing from npm is not recommended due to
> security risks" and rather provide their own tarball, which is, however, the
> same, contentwise. I will change URL to that source [2].
> 
> When I tried GH sources, I needed to install quite an amount of packages. To
> be exact:
> root@435574b62c7d:~/yarn# npm ls | wc -l
> 1725
> I would like to avoid that.

This means that you're bundling all those node modules, right? Then you need to
declare bundled() Provides for all the components you're bundling[1].

[1]: https://fedoraproject.org/wiki/Bundled_Libraries#Requirement_if_you_bundle

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1518262] Review Request: nodejs-yarn - Fast, reliable, and secure dependency management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1518262



--- Comment #4 from Zuzana Svetlikova  ---
> Upstream does not advise that yarn sources are retrieved from npm and suggest 
> it should be packaged from the pristine sources uploaded to GitHub.

I haven't seen such information. But I admit, that among alternative install
methods[1] they state "installing from npm is not recommended due to security
risks" and rather provide their own tarball, which is, however, the same,
contentwise. I will change URL to that source [2].

When I tried GH sources, I needed to install quite an amount of packages. To be
exact:
root@435574b62c7d:~/yarn# npm ls | wc -l
1725
I would like to avoid that.

> Also, I don't know of any conflicts that exist for "%{_bindir}/yarnpkg".

I wanted some consistency, so I renamed both yarn and yarnpkg.
Readme added.

[1]: https://yarnpkg.com/en/docs/install#alternatives-tab
[2]: https://yarnpkg.com/downloads/1.3.2/yarn-v1.3.2.tar.gz

Spec URL: https://zvetlik.fedorapeople.org/nodejs-yarn/nodejs-yarn.spec
SRPM URL:
https://zvetlik.fedorapeople.org/nodejs-yarn/nodejs-yarn-1.3.2-2.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508332] Review Request: php-icewind-smb2 - php wrapper for smbclient and libsmbclient-php

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508332



--- Comment #2 from William Moreno  ---
Spec URL:
https://git.remirepo.net/cgit/rpms/php/icewind/php-icewind-smb2.git/plain/php-icewind-smb2.spec?id=a7b1f277b2f2d4cf40e7cb642127a09a8ffab661
SRPM URL: http://rpms.remirepo.net/SRPMS/php-icewind-smb2-2.0.3-1.remi.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508332] Review Request: php-icewind-smb2 - php wrapper for smbclient and libsmbclient-php

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508332

William Moreno  changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com
   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508324] Review Request: php-icewind-searchdav - A sabre/ dav plugin to implement rfc5323 SEARCH

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508324

William Moreno  changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com
   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520585] Review Request: perl-Test-SQL-Data - Helps running SQL tests : database preparing and result matching

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520585



--- Comment #2 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires
FIX: Please add missing buildrequires:
 - make - used in spec
 - perl(Carp) - lib/Test/SQL/Data.pm:16
 - perl(File::Path) - lib/Test/SQL/Data.pm:17
 - perl(strict) - Makefile.PL:2
 - perl(version) - lib/Test/SQL/Data.pm:7
 - perl(warnings) - Makefile.PL:3

$ rpm -qp --requires perl-Test-SQL-Data-0.0.6-1.fc28.noarch.rpm | sort | uniq
-c
  1 perl(Carp)
  1 perl(File::Path)
  1 perl(:MODULE_COMPAT_5.26.1)
  1 perl(strict)
  1 perl(Test::More)
  1 perl(version)
  1 perl(warnings)
  1 perl(YAML)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: To use this module, you need to add to run-requires
 - perl(DBIx::Connector) >= 0.4.5
 - perl(DBD::SQLite) >= 1.20

$ rpm -qp --provides perl-Test-SQL-Data-0.0.6-1.fc28.noarch.rpm | sort | uniq
-c
  1 perl(Test::SQL::Data) = 0.0.6
  1 perl-Test-SQL-Data = 0.0.6-1.fc28
Binary provides are Ok.

$ rpmlint ./perl-Test-SQL-Data*
perl-Test-SQL-Data.noarch: W: spelling-error %description -l en_US pre -> per,
ore, pee
perl-Test-SQL-Data.src: W: spelling-error %description -l en_US pre -> per,
ore, pee
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR.

Please correct all 'FIX' issues and consider fixing 'TODO' items and
provide new spec file.

Package is not approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519844] Review Request: python-pymediainfo - Python wrapper around the MediaInfo library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519844

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Igor Gnatenko  ---
replace "appname" with "srcname" and will look good.

Trivial enough for doing during import. APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520584] Review Request: perl-MooseX-Types-NetAddr-IP - NetAddr:: IP related types and coercions for Moose

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520584

Peter Oliver  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|ma...@mavit.org.uk



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520863] Review Request: eclipse-sgx - Intel Software Guard Extensions Plug-in for Eclipse

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520863



--- Comment #4 from Fedora Update System  ---
eclipse-sgx-2.0-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c4b0813d02

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520863] Review Request: eclipse-sgx - Intel Software Guard Extensions Plug-in for Eclipse

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520863



--- Comment #5 from Fedora Update System  ---
eclipse-sgx-2.0-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1ff16079c5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520863] Review Request: eclipse-sgx - Intel Software Guard Extensions Plug-in for Eclipse

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520863

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520585] Review Request: perl-Test-SQL-Data - Helps running SQL tests : database preparing and result matching

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520585

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522690] Review Request: mohawk - time series metric data storage

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522690

Yaacov Zamir  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522690] New: Review Request: mohawk - time series metric data storage

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522690

Bug ID: 1522690
   Summary: Review Request: mohawk - time series metric data
storage
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: yza...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://copr-be.cloud.fedoraproject.org/results/yaacov/mohawk/fedora-27-x86_64/00684948-mohawk/mohawk.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/yaacov/mohawk/fedora-27-x86_64/00684948-mohawk/mohawk-0.26.2-6.fc27.src.rpm
Description: Mohawk is a metric data storage engine that uses a plugin
architecture for data storage and a simple REST API as the primary interface.
Fedora Account System Username: yaacov

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org