[Bug 1529785] Review Request: python-pypillowfight - Various image processing algorithms
https://bugzilla.redhat.com/show_bug.cgi?id=1529785 --- Comment #4 from Elliott Sales de Andrade --- Fixed. Spec URL: https://qulogic.fedorapeople.org/python-pypillowfight.spec SRPM URL: https://qulogic.fedorapeople.org/python-pypillowfight-0.2.2-2.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529785] Review Request: python-pypillowfight - Various image processing algorithms
https://bugzilla.redhat.com/show_bug.cgi?id=1529785 --- Comment #3 from Elliott Sales de Andrade --- Fixed. Spec URL: https://qulogic.fedorapeople.org/python-pypillowfight.spec SRPM URL: https://qulogic.fedorapeople.org/python-pypillowfight-0.2.2-1.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1505094] Review Request: budget - Personal financial assistant
https://bugzilla.redhat.com/show_bug.cgi?id=1505094 --- Comment #3 from Eduardo Mayorga --- (In reply to Eduardo Mayorga from comment #2) > So I think you are missing the BR python3-gobject-base. So I see this is not the case since python3-gobject will pull this package. But you are effectively missing the file /usr/lib64/girepository-1.0/Gtk-3.0.typelib provided by gtk3. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1505094] Review Request: budget - Personal financial assistant
https://bugzilla.redhat.com/show_bug.cgi?id=1505094 --- Comment #2 from Eduardo Mayorga --- Sir, the build fails in the %check section. + /usr/bin/python3 -c 'import budget.budget' Traceback (most recent call last): File "", line 888, in _find_spec AttributeError: 'DynamicImporter' object has no attribute 'find_spec' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "", line 1, in File "/builddir/build/BUILD/budget-0.0.10/budget/budget.py", line 19, in from gi.repository import Gtk, Gio, Gdk File "/usr/lib64/python3.6/site-packages/gi/importer.py", line 127, in find_module 'introspection typelib not found' % namespace) ImportError: cannot import name Gtk, introspection typelib not found error: Bad exit status from /var/tmp/rpm-tmp.OvmBEh (%check) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.OvmBEh (%check) Child return code was: 1 EXCEPTION: [Error()] So I think you are missing the BR python3-gobject-base. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529824] Review Request: awx - AWX, Ansible Management GUI
https://bugzilla.redhat.com/show_bug.cgi?id=1529824
--- Comment #5 from Neal Gompa ---
This covers the major issues:
* Amazon Linux doesn't use Upstart anymore. They just released Amazon Linux 2,
which uses systemd and they're no longer supporting Amazon Linux AMI v1 (which
used upstart). Aside from that, packages for Fedora and EPEL cannot have Amazon
Linux specific conditionals.
c.f.: https://fedoraproject.org/wiki/Packaging:Guidelines#Spec_Legibility
* Your Source0 is invalid. It needs to point to valid URL or have a comment of
some kind describing where it came from.
c.f.: https://fedoraproject.org/wiki/Packaging:SourceURL
* License is wrong. It's "ASL 2.0", not GPLv3:
https://github.com/ansible/awx/blob/devel/LICENSE.md
* Vendor, Prefix, and BuildRoot tags MUST NOT be used.
* Group is not mandatory, but when used, should match one of the following
groups: https://fedoraproject.org/wiki/RPMGroups
c.f.: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
c.f.: https://fedoraproject.org/wiki/Packaging:Guidelines#Relocatable_packages
* Packaging virtualenvs is not permitted in Fedora. Moreover, there is no
internet access in the build environment, so packaging virtualenvs is
functionally impossible.
c.f.:
https://fedoraproject.org/wiki/Packaging:Guidelines#Build_time_network_access
* Web app files should be installed into `/usr/share/%{name}` rather than in a
weird virtualenv location.
c.f.: https://fedoraproject.org/wiki/Packaging:Guidelines#Web_Applications
Packages like AWX can absolutely work in Fedora and EPEL, you just need to
leverage the system packages for its dependent components.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529891] New: Review Request: persepolis - A powerful download manager powered by aria2
https://bugzilla.redhat.com/show_bug.cgi?id=1529891 Bug ID: 1529891 Summary: Review Request: persepolis - A powerful download manager powered by aria2 Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: heday...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://hedayat.fedorapeople.org/reviews/persepolis/persepolis.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/hedayat/persepolis/fedora-rawhide-x86_64/00692127-persepolis/persepolis-3.0.1-1.fc28.src.rpm Description: Persepolis is a download manager and a GUI for aria2 powered by Python. - Graphical UI front end for aria2 - Multi-segment downloading - Scheduling downloads - Download queue Fedora Account System Username: hedayat -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529555] Review Request: mint-themes - Mint themes
https://bugzilla.redhat.com/show_bug.cgi?id=1529555 --- Comment #9 from Fedora Update System --- cinnamon-3.6.7-3.fc26, cinnamon-themes-2017.06.20-4.fc26, mint-themes-1.5.0-1.fc26, mint-themes-gtk3-3.18+17-1.fc26, mint-y-theme-1.2.3-1.fc26, slick-greeter-1.1.4-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-cf0e3033d2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1411154] Review Request: mint-y-theme - The Mint-Y theme
https://bugzilla.redhat.com/show_bug.cgi?id=1411154 --- Comment #9 from Fedora Update System --- cinnamon-3.6.7-3.fc26, cinnamon-themes-2017.06.20-4.fc26, mint-themes-1.5.0-1.fc26, mint-themes-gtk3-3.18+17-1.fc26, mint-y-theme-1.2.3-1.fc26, slick-greeter-1.1.4-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-cf0e3033d2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1518671] Review Request: mozilla-ublock-origin - An efficient blocker for Firefox
https://bugzilla.redhat.com/show_bug.cgi?id=1518671 --- Comment #8 from Fedora Update System --- mozilla-ublock-origin-1.14.22-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-94e8bf7417 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529516] Un-retirement Review Request: mint-y-theme - The Mint-Y theme
https://bugzilla.redhat.com/show_bug.cgi?id=1529516 --- Comment #8 from Fedora Update System --- cinnamon-3.6.7-3.fc26, cinnamon-themes-2017.06.20-4.fc26, mint-themes-1.5.0-1.fc26, mint-themes-gtk3-3.18+17-1.fc26, mint-y-theme-1.2.3-1.fc26, slick-greeter-1.1.4-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-cf0e3033d2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529559] Review Request: mint-themes-gtk3 - Mint themes for GTK3
https://bugzilla.redhat.com/show_bug.cgi?id=1529559 --- Comment #10 from Fedora Update System --- cinnamon-3.6.7-3.fc26, cinnamon-themes-2017.06.20-4.fc26, mint-themes-1.5.0-1.fc26, mint-themes-gtk3-3.18+17-1.fc26, mint-y-theme-1.2.3-1.fc26, slick-greeter-1.1.4-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-cf0e3033d2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529516] Un-retirement Review Request: mint-y-theme - The Mint-Y theme
https://bugzilla.redhat.com/show_bug.cgi?id=1529516 --- Comment #7 from Fedora Update System --- cinnamon-3.6.7-3.fc27, cinnamon-themes-2017.06.20-4.fc27, mint-themes-1.5.0-1.fc27, mint-themes-gtk3-3.18+17-1.fc27, mint-y-theme-1.2.3-1.fc27, slick-greeter-1.1.4-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-546a9d254e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529559] Review Request: mint-themes-gtk3 - Mint themes for GTK3
https://bugzilla.redhat.com/show_bug.cgi?id=1529559 --- Comment #9 from Fedora Update System --- cinnamon-3.6.7-3.fc27, cinnamon-themes-2017.06.20-4.fc27, mint-themes-1.5.0-1.fc27, mint-themes-gtk3-3.18+17-1.fc27, mint-y-theme-1.2.3-1.fc27, slick-greeter-1.1.4-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-546a9d254e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1518671] Review Request: mozilla-ublock-origin - An efficient blocker for Firefox
https://bugzilla.redhat.com/show_bug.cgi?id=1518671 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- mozilla-ublock-origin-1.14.22-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-a8b77b0496 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529555] Review Request: mint-themes - Mint themes
https://bugzilla.redhat.com/show_bug.cgi?id=1529555 --- Comment #8 from Fedora Update System --- cinnamon-3.6.7-3.fc27, cinnamon-themes-2017.06.20-4.fc27, mint-themes-1.5.0-1.fc27, mint-themes-gtk3-3.18+17-1.fc27, mint-y-theme-1.2.3-1.fc27, slick-greeter-1.1.4-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-546a9d254e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1411154] Review Request: mint-y-theme - The Mint-Y theme
https://bugzilla.redhat.com/show_bug.cgi?id=1411154 --- Comment #8 from Fedora Update System --- cinnamon-3.6.7-3.fc27, cinnamon-themes-2017.06.20-4.fc27, mint-themes-1.5.0-1.fc27, mint-themes-gtk3-3.18+17-1.fc27, mint-y-theme-1.2.3-1.fc27, slick-greeter-1.1.4-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-546a9d254e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529824] Review Request: awx - AWX, Ansible Management GUI
https://bugzilla.redhat.com/show_bug.cgi?id=1529824 --- Comment #4 from Martin Juhl --- Hi Could you give me some hints? I don't see what is broken? is it because the package includes a virtual environment? Also, as mentioned earlier, the package doesn't build on Fedora, so I want to push it directly to EPEL-test... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529785] Review Request: python-pypillowfight - Various image processing algorithms
https://bugzilla.redhat.com/show_bug.cgi?id=1529785
--- Comment #2 from Björn "besser82" Esser ---
Package looks good, but two issues:
* Package's license is actually `GPLv2+` as strongly indicated by [1] and
the license file distributed in the source-tarball.
s!GPLv3+$!GPLv2+!
* The package should have an archful Requires on python3-pillow:
s!^Requires:[ \t]*python3-pillow$!&%{?_isa}!
[1]
https://github.com/openpaperwork/libpillowfight/commit/4123ec6ba5918878ec665e73faf37668247820cf
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529785] Review Request: python-pypillowfight - Various image processing algorithms
https://bugzilla.redhat.com/show_bug.cgi?id=1529785 Björn "besser82" Esser changed: What|Removed |Added Status|NEW |ASSIGNED CC||besse...@fedoraproject.org Assignee|nob...@fedoraproject.org|besse...@fedoraproject.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 --- Comment #15 from Andrea Musuruane --- Latest version is 2.0.2. Pyamf support is optional: https://github.com/mitmproxy/mitmproxy/pull/62 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529789] Review Request: spirv-tools - API and commands for processing SPIR-V modules
https://bugzilla.redhat.com/show_bug.cgi?id=1529789 Björn "besser82" Esser changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #2 from Björn "besser82" Esser --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 13 files have unknown license. Detailed output of licensecheck in /home/besser82/vm_shared/fedora/review/1529789-spirv- tools/licensecheck.txt ---> License: ASL 2.0 is fine. [x]: License file installed when any subpackage combination is installed. [-]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/.build-id/2f(nss- tools, cyrus-sasl-md5, cairo, gstreamer1-plugins-bad-free, gegl, jwhois, rsyslog, libinput, webkitgtk4, python3-pwquality, libunicap, openal-soft, zip, wine-core, glibc, libdvdnav, jack-audio-connection- kit-example-clients, gstreamer1-plugins-base, bind99-libs, libdap, djvulibre-libs, qemu-block-nfs, pam, vorbis-tools, brasero-libs, ModemManager, vlc, gstreamer1-plugins-good, gtk2, sane-backends- drivers-scanners, octave, util-linux, libreswan, libXrandr, libmwaw, isdn4k-utils, bind-utils, python3-scipy, libnl3-cli), /usr/lib/.build- id/db(libavc1394, libv4l, ImageMagick-libs, gnome-autoar, gimp, pcre, live555, gfs2-utils, wine-core, clang-libs, coreutils, tracker, ntfsprogs, python2-libs, libgphoto2, gstreamer1-plugins-good, sane- backends-drivers-scanners, brltty, libquvi, evolution, libldb, hdf5, rpm-build, syslinux-extlinux, python3-scipy, crda, glib2, glibc), /usr/lib/.build-id/44(ncurses-compat-libs, libcomps, ImageMagick-libs, brasero, libglvnd-glx, openni, gimp, systemd, GConf2, sssd-common, libvisio, libgnome-keyring, wine-core, glibc, gnome-terminal, btrfs- progs, postgresql-libs, coreutils, ntfsprogs, python2-libs, vlc, libgeotiff, libgphoto2, ModemManager, openssh-server, unixODBC, pinentry, gstreamer1-plugins-good, teckit, graphite2, GraphicsMagick, util-linux, libtheora, evolution, evolution-data-server, dbus, java-1.8.0-openjdk-headless, isdn4k-utils, device-mapper-multipath- libs, libdhash, libgusb, samba-client-libs, libselinux-utils), /usr/lib/.build-id(python-libxml2, libmad, cups-client, efivar-libs, netcdf, rsyslog, policycoreutils-python-utils, qemu-block-gluster, rpm-plugin-selinux, abrt, ghc-transformers, libimagequant, giflib, libreoffice-graphicfilter, trousers, libdb-utils, tracker-miners, xorg-x11-font-utils, OpenEXR-libs, libcom_err, libseccomp, arprec, openblas-openmp64_, p11-kit, libabw, gtkspell, libvirt-daemon-driver- storage-iscsi, libmodman, xdotool, ghc-semigroups, cfitsio, argyllcms, parted, gnome-disk-utility, libdvdread, zstd, bluez-libs, libwebp, libxslt, system-config-printer-udev, perl-Encode, elfutils, python2-cryptography, libevdev, libgpg-error, lvm2-libs, libchromaprint, perl-Digest-SHA, libzstd, gtk-murrine-engine, xdg- desktop-portal-gtk, ghc-mmorph, lua-lpeg, symlinks, openbox-libs, libcdr, cdparanoia-libs, e2fsprogs-libs, pulseaudio-libs, lcms2, qemu- guest-agent, ntfs-3g, libxcb, freexl, libyubikey, sssd-common-pac, openconnect, rtkit, xcb-util-keysyms, orc, m4, libgphoto2, cdparanoia, xcb-util, libwmf-lite, python3-coverage, anaconda-widgets, http- parser, java-1.8.0-openjdk, pulseaudio-utils, libeot, ImageMagick-c++, systemd-bootchart, uniconvertor, python3-scipy, ghc-old-time, ncurses- libs, libidn2, ldns, libreport-plugin-logger, gnome-color-manager, fcoe-utils, libyui-mga-ncurses, xorg-x11-xkb-utils, python- setproctitle, NetworkManager-openvpn, libxkbfile, hplip-libs, libwvstreams, ghc-binary, xmlrpc-c-client, sane-backends-drivers- cameras, python3-hawkey, libwpd, libdc1394, libvirt-daemon-driver- qemu, perl-Time-HiRes, ghc-filemanip, qemu-block-ssh, libwps, gssdp, ghc-zlib, libacl, xorg-x11-drv-ati, libSM, policycoreutils, mcelog,
[Bug 1529788] Review Request: spirv-headers - Header files from the SPIR-V registry
https://bugzilla.redhat.com/show_bug.cgi?id=1529788
Björn "besser82" Esser changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #2 from Björn "besser82" Esser ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Header files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 41 files have unknown license. Detailed
output of licensecheck in
/home/besser82/vm_shared/fedora/review/1529788-spirv-
headers/licensecheck.txt
---> License: MIT is fine.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in S
[Bug 1528815] Review Request: librealsense1 - Cross-platform camera capture for Intel RealSense
https://bugzilla.redhat.com/show_bug.cgi?id=1528815 Till Hofmann changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-12-30 04:49:28 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
