[Bug 1529352] Review Request: wlroots - Pluggable, composable modules for building a Wayland compositor

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1529352

Tristan Cacqueray  changed:

   What|Removed |Added

 CC||tdeca...@redhat.com



--- Comment #6 from Tristan Cacqueray  ---
Just a little nit: it seems like you could use "mkdir" and "cp" directly
instead of the %{__ macros.
Otherwise it's LGTM!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1465889] Tracking: Deepin Desktop related package review tracker

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1465889
Bug 1465889 depends on bug 1479844, which changed state.

Bug 1479844 Summary: Review Request: deepin-notifications - System 
notifications for linuxdeepin desktop environment
https://bugzilla.redhat.com/show_bug.cgi?id=1479844

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1479844] Review Request: deepin-notifications - System notifications for linuxdeepin desktop environment

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1479844

Zamir SUN  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-12-31 20:56:00



--- Comment #6 from Zamir SUN  ---
This is already in Rawhide. Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1524133] Review Request: deepin-calculator - an easy to use calculator

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1524133

Zamir SUN  changed:

   What|Removed |Added

 CC|szts...@gmail.com   |sensor@gmail.com
  Flags||needinfo?(sensor.wen@gmail.
   ||com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1485376] Review Request: deepin-icon-theme - Deepin Icons

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1485376

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-icon-theme



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1485374] Review Request: deepin-grub2-themes - Deepin grub2 themes

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1485374

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-grub2-themes



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1485378] Review Request: deepin-wallpapers - Deepin Wallpapers provides wallpapers of dde

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1485378

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-wallpapers



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1485373] Review Request: deepin-gtk-theme - Deepin GTK Theme

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1485373

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-gtk-theme



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1485366] Review Request: deepin-polkit-agent - Deepin Polkit Agent

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1485366

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-polkit-agent



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1483300] Review Request: deepin-qt5integration - Qt platform theme integration plugins for DDE

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1483300

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-qt5integration



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1485369] Review Request: deepin-account-faces - Account faces for Linux Deepin

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1485369

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-account-faces



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1485372] Review Request: deepin-artwork-themes - Deepin artwork themes

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1485372

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-artwork-themes



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1484305] Review Request: dtkwm - Deepin graphical user interface library

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1484305

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||dtkwm



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1524136] Review Request: zssh - SSH and Telnet client with ZMODEM file transfer capability

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1524136

Zamir SUN  changed:

   What|Removed |Added

 CC||sensor@gmail.com
  Alias||zssh
  Flags||needinfo?(sensor.wen@gmail.
   ||com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1488216] Review Request: deepin-help - Help files for DDE

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1488216

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-help



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1488350] Review Request: deepin-screenshot - Deepin Screenshot Tool

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1488350

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-screenshot



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1524133] Review Request: deepin-calculator - an easy to use calculator

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1524133

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-calculator



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1488357] Review Request: deepin-system-monitor - A more user-friendly system monitor

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1488357

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-system-monitor



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1502016] Review Request: deepin-picker - color picker tool for Deepin

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1502016

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-picker



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1485722] Review Request: deepin-file-manager - Deepin File Manager

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1485722

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-file-manager



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1488214] Review Request: deepin-manual - Deepin User Manual

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1488214

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-manual



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1485720] Review Request: golang-github-linuxdeepin-go-x11-client - A X11 client Go bindings for Deepin Desktop Environment

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1485720

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||golang-github-linuxdeepin-g
   ||o-x11-client



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1485723] Review Request: deepin-image-viewer - Deepin Image Viewer

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1485723

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-image-viewer



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1485721] Review Request: deepin-wm - Deepin Window Manager

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1485721

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-wm



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1483297] Review Request: deepin-control-center - New control center for Linux Deepin

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1483297

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-control-center



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1483296] Review Request: deepin-dock - Deepin desktop environment Dock module

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1483296

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-dock



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1480971] Review Request: golang-github-alecthomas-assert - Fork of stretchr/testify/ assert that uses FailNow

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1480971

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||golang-github-alecthomas-as
   ||sert



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1483298] Review Request: deepin-launcher - Deepin desktop-environment Launcher module

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1483298

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-launcher



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1480973] Review Request: golang-github-alecthomas-kingpin - A Go command line and flag parser

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1480973

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||golang-github-alecthomas-ki
   ||ngpin



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1480972] Review Request: golang-github-BurntSushi-xgbutil - XGB is the X protocol Go language Binding

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1480972

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||golang-github-BurntSushi-xg
   ||butil



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1480970] Review Request: golang-github-alecthomas-colour - Quake-style colour formatting for Unix terminals

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1480970

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||golang-github-alecthomas-co
   ||lour



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1480967] Review Request: golang-github-alecthomas-units - Helpful unit multipliers and functions for Go

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1480967

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||golang-github-alecthomas-un
   ||its



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1480966] Review Request: golang-github-sergi-go-diff - Diff, match and patch text in Go

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1480966

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||golang-github-sergi-go-diff



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1480964] Review Request: golang-github-msteinert-pam - Go wrapper module for the PAM API

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1480964

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||golang-github-msteinert-pam



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1480965] Review Request: golang-github-nfnt-resize - Pure golang image resize

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1480965

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||golang-github-nfnt-resize



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1480962] Review Request: golang-github-disintegration-imaging - Simple Go image processing package

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1480962

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||golang-github-disintegratio
   ||n-imaging



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1480960] Review Request: golang-github-BurntSushi-xgb - XGB is the X protocol Go language Binding

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1480960

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||golang-github-BurntSushi-xg
   ||b



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1480956] Review Request: golang-github-alecthomas-template - Go' s text/template package with newline elisio

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1480956

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||golang-github-alecthomas-te
   ||mplate



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1480961] Review Request: golang-github-howeyc-fsnotify - File change notification Go language Binding

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1480961

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||golang-github-howeyc-fsnoti
   ||fy



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1480958] Review Request: golang-github-BurntSushi-freetype-go - A fork of freetype-go with bounding box calculations

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1480958

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||golang-github-BurntSushi-fr
   ||eetype-go



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1480957] Review Request: golang-github-axgle-mahonia - Character-set conversion library implemented in Go

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1480957

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||golang-github-axgle-mahonia



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1480955] Review Request: golang-github-alecthomas-repr - Python' s repr for Go

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1480955

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||golang-github-alecthomas-re
   ||pr



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1480959] Review Request: golang-github-BurntSushi-graphics-go - Graphics library for the Go programming language

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1480959

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||golang-github-BurntSushi-gr
   ||aphics-go



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1480963] Review Request: golang-github-mattn-go-isatty - isatty for golang

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1480963

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||golang-github-mattn-go-isat
   ||ty



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1468861] Review Request: dtksettings - DtkSettings is a powerful tool to generate config from json

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1468861

Zamir SUN  changed:

   What|Removed |Added

  Alias||dtksettings



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1480969] Review Request: golang-googlecode-image - Supplementary Go image libraries

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1480969

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
 Blocks|1465889 |
   |(DeepinDEPackageReview) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1465889
[Bug 1465889] Tracking: Deepin Desktop related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1465889] Tracking: Deepin Desktop related package review tracker

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1465889

Zamir SUN  changed:

   What|Removed |Added

 Depends On|1480969 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1480969
[Bug 1480969] Review Request: golang-googlecode-image - Supplementary Go
image libraries
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1469951] Review Request: perl-XML-LibXML-PrettyPrint - Add pleasant white space to an XML tree

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1469951

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||perl-XML-LibXML-PrettyPrint



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1479027

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||golang-github-golang-image



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1421041] Review Request: deepin-gettext-tools - Deepin Gettext Tools

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1421041

Zamir SUN  changed:

   What|Removed |Added

  Alias||deepin-gettext-tools



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1419332] Review Request: deepin-shortcut-viewer - deepin shortcut viewer

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1419332

Zamir SUN  changed:

   What|Removed |Added

  Alias||deepin-shortcut-viewer



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1421047] Review Request: deepin-tool-kit - Base development tool of all C++/ Qt Developer work on Deepin

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1421047

Zamir SUN  changed:

   What|Removed |Added

  Alias||deepin-tool-kit



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1421051] Review Request: deepin-nautilus-properties - Provide file property dialog for DDE

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1421051

Zamir SUN  changed:

   What|Removed |Added

  Alias||deepin-nautilus-properties



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1465889] Tracking: Deepin Desktop related package review tracker

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1465889
Bug 1465889 depends on bug 1478705, which changed state.

Bug 1478705 Summary: Review Request: deepin-calendar - Calendar for Deepin 
Desktop Environment
https://bugzilla.redhat.com/show_bug.cgi?id=1478705

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1478705] Review Request: deepin-calendar - Calendar for Deepin Desktop Environment

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1478705

Zamir SUN  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
  Alias||deepin-calendar
Last Closed||2017-12-31 20:30:00



--- Comment #10 from Zamir SUN  ---
Close as FIXED since it's in rawhide now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1477834] Review Request: treefrog-framework - High-speed C++ MVC Framework for Web Application

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1477834

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||treefrog-framework



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476596] Review Request: dtkwidget - Deepin tool kit widget modules

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476596

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||dtkwidget



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476564] Review Request: deepin-dbus-generator - Convert dbus interfaces to go-lang or qml wrapper code

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476564

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-dbus-generator



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476573] Review Request: deepin-mutter - Base window manager for deepin, fork of gnome mutter

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476573

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-mutter



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476583] Review Request: startdde - Starter of deepin desktop environment

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476583

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||startdde



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476589

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-api



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476565] Review Request: golang-deepin-dbus-factory - Golang DBus factory for DDE

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476565

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||golang-deepin-dbus-factory



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476584] Review Request: deepin-session-ui - Deepin desktop-environment Session UI module

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476584

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-session-ui



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476595] Review Request: dtkcore - Deepin tool kit core modules

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476595

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||dtkcore



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476590] Review Request: deepin-daemon - Daemon handling the DDE session settings

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476590

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-daemon



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476560] Review Request: deepin-desktop-schemas - GSettings deepin desktop-wide schemas

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476560

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-desktop-schemas



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1476558] Review Request: deepin-desktop-base - Base component for Deepin

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1476558

Zamir SUN  changed:

   What|Removed |Added

  Alias||deepin-desktop-base



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1421066] Review Request: deepin-wm-switcher - Window manager switcher for Deepin

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1421066

Zamir SUN  changed:

   What|Removed |Added

  Alias||deepin-wm-switcher



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1421058] Review Request: deepin-metacity - 2D window manager for Deepin

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1421058

Zamir SUN  changed:

   What|Removed |Added

  Alias||deepin-metacity



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1421063] Review Request: deepin-gir-generator - Generate static golang bindings for GObject

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1421063

Zamir SUN  changed:

   What|Removed |Added

  Alias||deepin-gir-generator



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1421065

Zamir SUN  changed:

   What|Removed |Added

  Alias||deepin-qt-dbus-factory



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1421044] Review Request: deepin-qml-widgets - Deepin QML widgets

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1421044

Zamir SUN  changed:

   What|Removed |Added

  Alias||deepin-qml-widgets



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1421046] Review Request: golang-deepin-go-lib - Go bindings for DDE development

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1421046

Zamir SUN  changed:

   What|Removed |Added

  Alias||golang-deepin-go-lib



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1421048] Review Request: deepin-sound-theme - Deepin sound theme

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1421048

Zamir SUN  changed:

   What|Removed |Added

  Alias||deepin-sound-theme



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1419330] Review Request: deepin-menu - deepin menu service

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1419330

Zamir SUN  changed:

   What|Removed |Added

  Alias||deepin-menu



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1419317] Review Request: deepin-terminal - terminal emulation application

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1419317

Zamir SUN  changed:

   What|Removed |Added

  Alias||deepin-terminal



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1421055] Review Request: deepin-cogl - An object oriented GL/ GLES Utility Layer for Deepin

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1421055

Zamir SUN  changed:

   What|Removed |Added

  Alias||deepin-cogl



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1528393] Review Request: urlscan - Extract and browse the URLs contained in an email ( urlview replacement)

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1528393

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-12-31 16:25:41



--- Comment #6 from Fedora Update System  ---
urlscan-0.8.6-2.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1515554] Review Request: python-certbot-dns-rfc2136 - RFC 2136 DNS Authenticator plugin for Certbot

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1515554



--- Comment #18 from Matt Dainty  ---
Can this be pushed to EPEL 7 (and 6 if possible) as well please?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1529352] Review Request: wlroots - Pluggable, composable modules for building a Wayland compositor

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1529352



--- Comment #5 from Björn "besser82" Esser  ---
(In reply to Elliott Sales de Andrade from comment #4)
> Iwicki is correct about those two points.

Yes, of course…  But his suggestions are more a matter of taste, then
'hard-coded' rules.


> Not sure why you added explicit install to %_pkgdocdir; you could just list
> the
> relative paths in %doc directly. Is it to be able to delete .*ignore* and
> meson.build from the installed version?

I did that, so all built (sub-)packages share the same dir for documentation;
if you simply add the relative paths using %%doc, every %package will get a
seperate dir laying inside of %%{_defaultdocdir}.


> Need to add BuildRequires on gcc and/or g++:
> https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B

Fixed.


> A couple files are not MIT; they are not installed, but I think some
> transformation of them is. Not exactly sure what the legal meaning of that
> is,
> or if you need to mention that in the license field.

I added some clarification comment to the spec file.


> It would be nice if the description said a bit more than the summary.

Well, at some day in the future, when upstream writes a better one…


> Package Review
> ==
> 
> [!]: License field in the package spec file matches the actual license.
>  Note: Checking patched sources after %prep for licenses. Licenses
>  found: "MIT/X11 (BSD like)", "LGPL (v2.1 or later)", "NTP (legal
>  disclaimer)", "Unknown or generated". 197 files have unknown license.
>  Detailed output of licensecheck in
>  /home/elliott/rpmbuild/review/1529352-wlroots/licensecheck.txt

See added clarification in the spec file.

***

=== Updated package ===


Scratch build:

  Rawhide:  https://koji.fedoraproject.org/koji/taskinfo?taskID=23955196


Urls:

  Spec URL: 
https://pagure.io/besser82/package-review/raw/master/f/wlroots.spec
  SRPM URL: 
https://pagure.io/besser82/package-review/raw/master/f/wlroots-0.0.1-0.4.20171229git80ed4d4.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1529785] Review Request: python-pypillowfight - Various image processing algorithms

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1529785

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Björn "besser82" Esser  ---
(In reply to Elliott Sales de Andrade from comment #4)
> Fixed.

LGTM!  Package APPROVED!!!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1529936] New: Review Request: dianara - Pump.io application for the desktop

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1529936

Bug ID: 1529936
   Summary: Review Request: dianara - Pump.io application for the
desktop
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: anto.tra...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://sagitter.fedorapeople.org/dianara/dianara.spec
SRPM URL:
https://sagitter.fedorapeople.org/dianara/dianara-1.4.1-1.fc27.src.rpm

Description:
Dianara is a pump.io client, a desktop application that allows users to manage
their Pump.io social networking accounts without the need to use a
web browser, and provides many features not available in the standard web
interface.

Fedora Account System Username: sagitter

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1529352] Review Request: wlroots - Pluggable, composable modules for building a Wayland compositor

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1529352

Elliott Sales de Andrade  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1529352] Review Request: wlroots - Pluggable, composable modules for building a Wayland compositor

2017-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1529352

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||quantum.anal...@gmail.com
   Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com



--- Comment #4 from Elliott Sales de Andrade  ---
Iwicki is correct about those two points.

Not sure why you added explicit install to %_pkgdocdir; you could just list the
relative paths in %doc directly. Is it to be able to delete .*ignore* and
meson.build from the installed version?

Need to add BuildRequires on gcc and/or g++:
https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B

A couple files are not MIT; they are not installed, but I think some
transformation of them is. Not exactly sure what the legal meaning of that is,
or if you need to mention that in the license field.

It would be nice if the description said a bit more than the summary.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Header files in -devel subpackage, if present.
  Note: wlroots-debugsource :
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "LGPL (v2.1 or later)", "NTP (legal
 disclaimer)", "Unknown or generated". 197 files have unknown license.
 Detailed output of licensecheck in
 /home/elliott/rpmbuild/review/1529352-wlroots/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[?]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 348160 bytes in 18 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatab