[Bug 1527289] Review Request: nototools - Noto fonts support tools and scripts plus web site generation
https://bugzilla.redhat.com/show_bug.cgi?id=1527289 --- Comment #11 from Parag AN(पराग) --- Thanks but one issue still remained. We want this package to support python2 as well as python3? I will say good to provide only python3 package with same name binaries instead to go for renaming binaries for py2 as well as py3 variants. If package is not supposed to be used on RHEL7/EPEL7 or its previous releases then just target python3 subpackage. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1266847] Review Request: ghc-extra - Extra Haskell functions
https://bugzilla.redhat.com/show_bug.cgi?id=1266847 --- Comment #12 from Jens Petersen --- Oops I just realised that extra needs clock (currently also a subpackage of hlint) to build... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1527289] Review Request: nototools - Noto fonts support tools and scripts plus web site generation
https://bugzilla.redhat.com/show_bug.cgi?id=1527289 --- Comment #10 from Peng Wu --- Thanks for the help on the spec file! Please review the package again! Spec URL: https://pwu.fedorapeople.org/fonts/nototools/nototools.spec SRPM URL: https://pwu.fedorapeople.org/fonts/nototools/nototools-0-0.20170926.git0c99dff.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1530113] Review Request: yices - SMT solver
https://bugzilla.redhat.com/show_bug.cgi?id=1530113 Jerry James changed: What|Removed |Added Depends On||1530112 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1530112 [Bug 1530112] Review Request: libpoly - C library for manipulating polynomials -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1530112] Review Request: libpoly - C library for manipulating polynomials
https://bugzilla.redhat.com/show_bug.cgi?id=1530112 Jerry James changed: What|Removed |Added Blocks||1530113 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1530113 [Bug 1530113] Review Request: yices - SMT solver -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1530112] New: Review Request: libpoly - C library for manipulating polynomials
https://bugzilla.redhat.com/show_bug.cgi?id=1530112 Bug ID: 1530112 Summary: Review Request: libpoly - C library for manipulating polynomials Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: loganje...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jjames.fedorapeople.org/libpoly/libpoly.spec SRPM URL: https://jjames.fedorapeople.org/libpoly/libpoly-0.1.4-1.fc28.src.rpm Description: LibPoly is a C library for manipulating polynomials. The target applications are symbolic reasoning engines, such as SMT solvers, that need to reason about polynomial constraints. Fedora Account System Username: jjames -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1530113] New: Review Request: yices - SMT solver
https://bugzilla.redhat.com/show_bug.cgi?id=1530113 Bug ID: 1530113 Summary: Review Request: yices - SMT solver Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: loganje...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jjames.fedorapeople.org/yices/yices.spec SRPM URL: https://jjames.fedorapeople.org/yices/yices-2.5.4-1.fc28.src.rpm Description: Yices 2 is an efficient SMT solver that decides the satisfiability of formulas containing uninterpreted function symbols with equality, linear real and integer arithmetic, bitvectors, scalar types, and tuples. Yices 2 can process input written in the SMT-LIB notation (both versions 2.0 and 1.2 are supported). Alternatively, you can write specifications using the Yices 2 specification language, which includes tuples and scalar types. Yices 2 can also be used as a library in other software. Fedora Account System Username: jjames -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1528561] Review Request: ocaml-ptmap - Maps over integers implemented as Patricia trees
https://bugzilla.redhat.com/show_bug.cgi?id=1528561 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1528561] Review Request: ocaml-ptmap - Maps over integers implemented as Patricia trees
https://bugzilla.redhat.com/show_bug.cgi?id=1528561 --- Comment #4 from Fedora Update System --- ocaml-ptmap-2.0.3-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-085b6f3010 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1528561] Review Request: ocaml-ptmap - Maps over integers implemented as Patricia trees
https://bugzilla.redhat.com/show_bug.cgi?id=1528561 --- Comment #3 from Fedora Update System --- ocaml-ptmap-2.0.3-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-caa183957b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529202] Review Request: ocaml-migrate-parsetree - Convert OCaml parsetrees between different major versions
https://bugzilla.redhat.com/show_bug.cgi?id=1529202 --- Comment #2 from Andy Li --- Spec URL: https://gist.github.com/andyli/e0be941c55e2b740916235198e82dd9e/raw/7f94a313ca5cdc05dbc618b02ffd01d919a9b8e5/ocaml-migrate-parsetree.spec SRPM URL: https://gist.github.com/andyli/e0be941c55e2b740916235198e82dd9e/raw/7f94a313ca5cdc05dbc618b02ffd01d919a9b8e5/ocaml-migrate-parsetree-1.0.7-1.fc28.src.rpm Glad to learn how to resolve that warning. Change applied as suggested. Happy new year! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529202] Review Request: ocaml-migrate-parsetree - Convert OCaml parsetrees between different major versions
https://bugzilla.redhat.com/show_bug.cgi?id=1529202
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
- You should generate debuginfo:
ocaml-migrate-parsetree.x86_64: W: unstripped-binary-or-object
/usr/lib64/ocaml/ocaml-migrate-parsetree-ocamlbuild/migrate_parsetree_ocamlbuild.cmxs
ocaml-migrate-parsetree.x86_64: W: unstripped-binary-or-object
/usr/lib64/ocaml/ocaml-migrate-parsetree/driver-main/migrate_parsetree_driver_main.cmxs
ocaml-migrate-parsetree.x86_64: W: unstripped-binary-or-object
/usr/lib64/ocaml/ocaml-migrate-parsetree/migrate_parsetree.cmxs
Cf. the guidelines:
"find-debuginfo.sh processes only files that are executable when it's run; for
practical purposes one can assume that happens under the hood after the
%install section. Make sure that all ELF binaries (executables, shared
libraries, DSO's) are executable at end of %install."
https://fedoraproject.org/wiki/Packaging:Debuginfo
Just make these files executables in %install:
find %{buildroot} -name '*.cmxs' -exec chmod 0755 {} \;
And remove "%global debug_package %{nil}"
You'll then proporly generate debuginfo and debugsource packages.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "LGPL (v2.1)", "Unknown or generated". 80 files have unknown
license. Detailed output of licensecheck in /home/bob/packaging/review
/ocaml-migrate-parsetree/review-ocaml-migrate-
parsetree/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[!]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 81920 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relo
[Bug 1519608] Review Request: gap-pkg-sophus - Computing in nilpotent Lie algebras
https://bugzilla.redhat.com/show_bug.cgi?id=1519608 --- Comment #2 from Jerry James --- Thank you so much for the review, and please excuse my long silence. December got busy. I have found a new email address for the author, who appears to have moved to another school. I have sent another email about the license. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1519607] Review Request: gap-pkg-nautytracesinterface - GAP interface to nauty and Traces
https://bugzilla.redhat.com/show_bug.cgi?id=1519607
--- Comment #2 from Jerry James ---
Thank you for the review, Luya.
(In reply to Luya Tshimbalanga from comment #1)
> Finally found the time for the review.
No worries. December got super busy for me, too, as evidenced by the fact that
I am only now getting back to Fedora issues...
> Additionally, replace %setup -q -n %{user}-NautyTracesInterface-%{shorttag}
> by
> %autosetup -p1 -n %{user}-NautyTracesInterface-%{shorttag}
Done.
> Issues:
> ===
> - All build dependencies are listed in BuildRequires, except for any that
> are listed in the exceptions section of Packaging Guidelines.
> Note: These BR are not needed: gcc-c++
> See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
I wish somebody would fix that. Rpmlint is wrong about this. Try following
that URL. :-) The BR is required:
https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B
> [!]: License field in the package spec file matches the actual license.
> Note: Checking patched sources after %prep for licenses. Licenses
> found: "Apache (v2.0)", "GPL (v2)".
> Could you check with upstream about the licensing from the following:
> Apache (v2.0)
> -
> sebasguts-NautyTracesInterface-5f16120/nauty26r7/COPYRIGHT
>
> GPL (v2)
>
> sebasguts-NautyTracesInterface-5f16120/COPYING
>
> Main reason is the compatibility between Apache 2.0 and GPLv2 as highlighted
> by
> https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses
The nauty distribution is packaged separately in Fedora, and this is in %prep:
# Make sure the bundled nauty is not used
rm -fr src/nauty*
Plus, the lone patch in this package removes dependencies on the bundled
version of nauty in favor of dependencies on the system version. So none of
the Apache-licensed code is in the binary package.
> [!]: Spec file according to URL is the same as in SRPM.
> Note: Spec file as given by url is not the same as in SRPM (see
> attached diff).
> See: (this test has no URL)
Oops. Fixed. In addition, the package identifies itself as version 0.2, not
0.1, when it loads, so I have corrected the version field. New URLs:
Spec URL:
https://jjames.fedorapeople.org/gap-pkg-nautytracesinterface/gap-pkg-nautytracesinterface.spec
SRPM URL:
https://jjames.fedorapeople.org/gap-pkg-nautytracesinterface/gap-pkg-nautytracesinterface-0.2-1.20171120git5f16120.fc28.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529891] Review Request: persepolis - A powerful download manager powered by aria2
https://bugzilla.redhat.com/show_bug.cgi?id=1529891 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #5 from Robert-André Mauchin --- All good, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529891] Review Request: persepolis - A powerful download manager powered by aria2
https://bugzilla.redhat.com/show_bug.cgi?id=1529891 --- Comment #4 from Hedayat Vatankhah --- Oops, you are right, I found what was my mistake :P Anyway, this is the new SPEC & SRPM: SPEC: https://hedayat.fedorapeople.org/reviews/persepolis/persepolis.spec SRPM: https://hedayat.fedorapeople.org/reviews/persepolis/persepolis-3.0.1-2.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529891] Review Request: persepolis - A powerful download manager powered by aria2
https://bugzilla.redhat.com/show_bug.cgi?id=1529891 --- Comment #3 from Robert-André Mauchin --- It fails for me in mock with "-c". See this Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=23965815 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529784] Review Request: shyaml - YAML for command line
https://bugzilla.redhat.com/show_bug.cgi?id=1529784 --- Comment #2 from Till Hofmann --- Thank you for reviewing! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529891] Review Request: persepolis - A powerful download manager powered by aria2
https://bugzilla.redhat.com/show_bug.cgi?id=1529891
--- Comment #2 from Hedayat Vatankhah ---
Thank you for taking this review.
> - You should remove -c to autosetup to apply your patch correctly:
> %autosetup -n %{name}-%{version}
Sorry, I don't understand. On my system, rpmbuild fails if I remove '-c'; and
also it seems that the patch is correctly applied right now.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529824] Review Request: awx - AWX, Ansible Management GUI
https://bugzilla.redhat.com/show_bug.cgi?id=1529824 --- Comment #6 from Martin Juhl --- Ok.. thanks... I'll rework the spec, if I can get the depends to check out.. Thanks again... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529784] Review Request: shyaml - YAML for command line
https://bugzilla.redhat.com/show_bug.cgi?id=1529784
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #1 from Robert-André Mauchin ---
Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (2 clause)", "Unknown or generated", "*No copyright* BSD
(unspecified)". 8 files have unknown license. Detailed output of
licensecheck in /home/bob/packaging/review/shyaml/review-
shyaml/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should no
[Bug 1372893] Review Request: python-parquet - Python implementation of the Parquet file format
https://bugzilla.redhat.com/show_bug.cgi?id=1372893 Elliott Sales de Andrade changed: What|Removed |Added Whiteboard||AwaitingSubmitter Flags||needinfo?(ignatenko@redhat. ||com) --- Comment #7 from Elliott Sales de Andrade --- Ping Igor? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays
https://bugzilla.redhat.com/show_bug.cgi?id=769487 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com --- Comment #18 from Elliott Sales de Andrade --- I'm pretty sure the (C code) triangle license effectively means this will never be packaged as it stands: > This program may be freely redistributed under the condition that the >copyright notices (including this entire header and the copyright >notice printed when the `-h' switch is selected) are not removed, and >no compensation is received. Private, research, and institutional >use is free. You may distribute modified versions of this code UNDER >THE CONDITION THAT THIS CODE AND ANY MODIFICATIONS MADE TO IT IN THE >SAME FILE REMAIN UNDER COPYRIGHT OF THE ORIGINAL AUTHOR, BOTH SOURCE >AND OBJECT CODE ARE MADE FREELY AVAILABLE WITHOUT CHARGE, AND CLEAR >NOTICE IS GIVEN OF THE MODIFICATIONS. Distribution of this code as >part of a commercial system is permissible ONLY BY DIRECT ARRANGEMENT >WITH THE AUTHOR. (If you are not directly supplying this code to a >customer, and you are instead telling them how they can obtain it for >free, then you are not required to make any arrangement with me.) Stuff like "no compensation is received", "part of a commercial system", etc. sound rather non-Free to me and I doubt they'd get by legal. See also https://github.com/glumpy/glumpy/issues/118 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1280480] Review Request: python-duecredit - Automated collection and reporting of citations for used software /methods/datasets
https://bugzilla.redhat.com/show_bug.cgi?id=1280480 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com Whiteboard||AwaitingSubmitter Flags||needinfo?(ignatenko@redhat. ||com) --- Comment #3 from Elliott Sales de Andrade --- Ping Igor? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1491281] Review Request: python-libsass - python bindings for libsass
https://bugzilla.redhat.com/show_bug.cgi?id=1491281 Elliott Sales de Andrade changed: What|Removed |Added CC||mp...@redhat.com, ||quantum.anal...@gmail.com Whiteboard||AwaitingSubmitter Flags||needinfo?(mp...@redhat.com) --- Comment #11 from Elliott Sales de Andrade --- Any updates Marcel? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1445926] Review Request: python-moto - Allows your python tests to easily mock out the boto library
https://bugzilla.redhat.com/show_bug.cgi?id=1445926 Elliott Sales de Andrade changed: What|Removed |Added CC||besse...@fedoraproject.org, ||quantum.anal...@gmail.com Whiteboard||AwaitingSubmitter Flags||needinfo?(besser82@fedorapr ||oject.org) --- Comment #2 from Elliott Sales de Andrade --- Ping Björn? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1416705] Review Request: python-kivy - Kivy - Multimedia / Multitouch framework in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1416705 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com Whiteboard||AwaitingSubmitter --- Comment #4 from Elliott Sales de Andrade --- Ping MartinKG? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1354115] Review Request: python-aenum - Advanced Enumerations ( compatible with Python's stdlib Enum), NamedTuples, and NamedConstants
https://bugzilla.redhat.com/show_bug.cgi?id=1354115 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com Whiteboard||AwaitingSubmitter Flags||needinfo?(ignatenko@redhat. ||com) --- Comment #2 from Elliott Sales de Andrade --- Please update the review to the latest version. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379651] Review Request: python-feedgenerator - Standalone version of Django' s feedgenerator module
https://bugzilla.redhat.com/show_bug.cgi?id=1379651 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com, ||sanjay.an...@gmail.com Whiteboard||AwaitingSubmitter Flags||needinfo?(sanjay.ankur@gmai ||l.com) --- Comment #19 from Elliott Sales de Andrade --- Can you provide an update Ankur? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com Flags||needinfo?(jama...@fc.up.pt) --- Comment #19 from Elliott Sales de Andrade --- Any more updates? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1530084] Review Request: numix-icon-theme-square - Numix Project square icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1530084 Brendan Early changed: What|Removed |Added CC||mymindsto...@gmail.com Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1530084] New: Review Request: numix-icon-theme-square - Numix Project square icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1530084 Bug ID: 1530084 Summary: Review Request: numix-icon-theme-square - Numix Project square icon theme Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: mymindsto...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://raw.githubusercontent.com/mymindstorm/numix-square-spec/master/numix-icon-theme-square.spec SRPM URL: https://raw.githubusercontent.com/mymindstorm/numix-square-spec/master/numix-icon-theme-square-0.1.0-1.git084e0ae.fc27.src.rpm Description: Numix Square is a modern icon theme for Linux from the Numix project. Fedora Account System Username: mymindstorm Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=23960255 This is my first package and I'm looking for a sponsor. I'd also appreciate any feedback since I'm new to this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1530073] Review Request: rust-cbindgen - Tool for generating C bindings to Rust code
https://bugzilla.redhat.com/show_bug.cgi?id=1530073 --- Comment #2 from Neal Gompa --- Erk, It actually *does* provide an API, and the crate subpackage is installed correctly. It's still valid, but the earlier statement about no API is wrong. In any case, still approved. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1530073] Review Request: rust-cbindgen - Tool for generating C bindings to Rust code
https://bugzilla.redhat.com/show_bug.cgi?id=1530073 Neal Gompa changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Neal Gompa --- Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - as this is a CLI crate that provides no API, it installs binaries correctly PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1530073] Review Request: rust-cbindgen - Tool for generating C bindings to Rust code
https://bugzilla.redhat.com/show_bug.cgi?id=1530073 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529936] Review Request: dianara - Pump.io application for the desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1529936 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- Perfect, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529891] Review Request: persepolis - A powerful download manager powered by aria2
https://bugzilla.redhat.com/show_bug.cgi?id=1529891
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
- Add a comment explaining what's the patch is for.
- Use:
%{_mandir}/man1/persepolis.1*
- You should remove -c to autosetup to apply your patch correctly:
%autosetup -n %{name}-%{version}
-Be more specific in %files:
%files
%license LICENSE
%doc README.md
%{_bindir}/%{name}
%{_datadir}/applications/%{name}.desktop
%{_datadir}/pixmaps/*
%{_mandir}/man1/%{name}.1*
%{python3_sitelib}/%{name}
%{python3_sitelib}/%{name}-%{version}-py?.?.egg-info
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* GPL (v3 or later)", "Unknown or generated". 230
files have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/persepolis/review-
persepolis/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see at
[Bug 1530073] New: Review Request: rust-cbindgen - Tool for generating C bindings to Rust code
https://bugzilla.redhat.com/show_bug.cgi?id=1530073 Bug ID: 1530073 Summary: Review Request: rust-cbindgen - Tool for generating C bindings to Rust code Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ignate...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-cbindgen.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-cbindgen-0.3.3-1.fc28.src.rpm Description: Tool for generating C bindings to Rust code. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529936] Review Request: dianara - Pump.io application for the desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1529936
--- Comment #2 from Antonio Trande ---
(In reply to Robert-André Mauchin from comment #1)
> - If an application installs icons into one of the subdirectories in
> %{_datadir}/icons/ (such as hicolor in the following examples), icon caches
> must be updated so that the installed icons show up in menus right after
> package installation.
>
Indeed.
Spec URL: https://sagitter.fedorapeople.org/dianara/dianara.spec
SRPM URL:
https://sagitter.fedorapeople.org/dianara/dianara-1.4.1-2.fc27.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1530060] Review Request: python-rnc2rng - RELAX NG Compact to regular syntax conversion library
https://bugzilla.redhat.com/show_bug.cgi?id=1530060 Neal Gompa changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #2 from Neal Gompa --- Review notes: [x] Follows Fedora Python package naming [x] License is correctly marked and license file is properly installed [x] Builds and installs correctly (with dependent package built+installed) [x] All appropriate Python packaging macros are used Looks good to me! PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1530059] Review Request: python-rply - Port David Beazley' s PLY to RPython
https://bugzilla.redhat.com/show_bug.cgi?id=1530059 Neal Gompa changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Neal Gompa --- Looks good! PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1530059] Review Request: python-rply - Port David Beazley' s PLY to RPython
https://bugzilla.redhat.com/show_bug.cgi?id=1530059 --- Comment #3 from Igor Gnatenko --- Fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1530060] Review Request: python-rnc2rng - RELAX NG Compact to regular syntax conversion library
https://bugzilla.redhat.com/show_bug.cgi?id=1530060 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Flags||fedora-review? --- Comment #1 from Neal Gompa --- Taking this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1530059] Review Request: python-rply - Port David Beazley' s PLY to RPython
https://bugzilla.redhat.com/show_bug.cgi?id=1530059 --- Comment #2 from Neal Gompa --- Review notes: [x] Follows Fedora Python package naming [x] License is correctly marked and license file is properly installed [x] Builds and installs correctly [!] Missing %python_provide macro for flavor subpackages From what I can tell, the only thing missing is the %python_provide macro. Please add that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1530059] Review Request: python-rply - Port David Beazley' s PLY to RPython
https://bugzilla.redhat.com/show_bug.cgi?id=1530059 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Flags||fedora-review? --- Comment #1 from Neal Gompa --- Taking this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1530060] Review Request: python-rnc2rng - RELAX NG Compact to regular syntax conversion library
https://bugzilla.redhat.com/show_bug.cgi?id=1530060 Igor Gnatenko changed: What|Removed |Added Blocks||1464617 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1464617 [Bug 1464617] python-citeproc-py-0.4.0 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1530060] Review Request: python-rnc2rng - RELAX NG Compact to regular syntax conversion library
https://bugzilla.redhat.com/show_bug.cgi?id=1530060 Igor Gnatenko changed: What|Removed |Added Depends On||1530059 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1530059 [Bug 1530059] Review Request: python-rply - Port David Beazley's PLY to RPython -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1530059] Review Request: python-rply - Port David Beazley' s PLY to RPython
https://bugzilla.redhat.com/show_bug.cgi?id=1530059 Igor Gnatenko changed: What|Removed |Added Blocks||1530060 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1530060 [Bug 1530060] Review Request: python-rnc2rng - RELAX NG Compact to regular syntax conversion library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1530060] New: Review Request: python-rnc2rng - RELAX NG Compact to regular syntax conversion library
https://bugzilla.redhat.com/show_bug.cgi?id=1530060 Bug ID: 1530060 Summary: Review Request: python-rnc2rng - RELAX NG Compact to regular syntax conversion library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ignate...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-rnc2rng.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-rnc2rng-2.5-1.fc28.src.rpm Description: RELAX NG Compact to regular syntax conversion library. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1530059] New: Review Request: python-rply - Port David Beazley' s PLY to RPython
https://bugzilla.redhat.com/show_bug.cgi?id=1530059 Bug ID: 1530059 Summary: Review Request: python-rply - Port David Beazley's PLY to RPython Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ignate...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-rply.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-rply-0.7.5-1.fc28.src.rpm Description: Port David Beazley's PLY to RPython. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1529936] Review Request: dianara - Pump.io application for the desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1529936
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
- If an application installs icons into one of the subdirectories in
%{_datadir}/icons/ (such as hicolor in the following examples), icon caches
must be updated so that the installed icons show up in menus right after
package installation.
https://fedoraproject.org/wiki/Packaging:Scriptlets#Icon_Cache
Requires: hicolor-icon-theme
And:
%post
/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
%postun
if [ $1 -eq 0 ] ; then
/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
fi
%posttrans
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
- Split the description line to stay below 80 characters
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in dianara
See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later)", "Unknown or generated". 75 files have
unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/dianara/review-dianara/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/64x64,
/usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor,
/usr/share/icons/hicolor/64x64/apps
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicat
[Bug 1520191] Review Request: rust-wait-timeout - Crate to wait on a child process with a timeout
https://bugzilla.redhat.com/show_bug.cgi?id=1520191 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-01-01 09:48:06 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520189] Review Request: rust-permutate - Generic permutator that permutates singular and multiple lists
https://bugzilla.redhat.com/show_bug.cgi?id=1520189 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-01-01 09:47:50 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520183] Review Request: rust-owning_ref - Library for creating references that carry their owner with them
https://bugzilla.redhat.com/show_bug.cgi?id=1520183 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-01-01 09:47:40 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520179] Review Request: rust-nodrop - Wrapper type to inhibit drop ( destructor)
https://bugzilla.redhat.com/show_bug.cgi?id=1520179 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-01-01 09:46:52 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520180] Review Request: rust-arrayvec - Vector with fixed capacity, backed by an array
https://bugzilla.redhat.com/show_bug.cgi?id=1520180 Bug 1520180 depends on bug 1520179, which changed state. Bug 1520179 Summary: Review Request: rust-nodrop - Wrapper type to inhibit drop (destructor) https://bugzilla.redhat.com/show_bug.cgi?id=1520179 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520182] Review Request: rust-gimli - Blazing fast DWARF debugging format parser
https://bugzilla.redhat.com/show_bug.cgi?id=1520182 Bug 1520182 depends on bug 1520180, which changed state. Bug 1520180 Summary: Review Request: rust-arrayvec - Vector with fixed capacity, backed by an array https://bugzilla.redhat.com/show_bug.cgi?id=1520180 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520182] Review Request: rust-gimli - Blazing fast DWARF debugging format parser
https://bugzilla.redhat.com/show_bug.cgi?id=1520182 Bug 1520182 depends on bug 1520175, which changed state. Bug 1520175 Summary: Review Request: rust-test-assembler - A set of types for building complex binary streams. https://bugzilla.redhat.com/show_bug.cgi?id=1520175 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520175] Review Request: rust-test-assembler - A set of types for building complex binary streams.
https://bugzilla.redhat.com/show_bug.cgi?id=1520175 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-01-01 09:47:06 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520180] Review Request: rust-arrayvec - Vector with fixed capacity, backed by an array
https://bugzilla.redhat.com/show_bug.cgi?id=1520180 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-01-01 09:46:57 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520171] Review Request: rust-glib-sys - FFI bindings to libglib-2.0
https://bugzilla.redhat.com/show_bug.cgi?id=1520171 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-01-01 09:46:47 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520136] Review Request: rust-scroll_derive - Macros 1.1 derive implementation for Pread and Pwrite traits from scroll crate
https://bugzilla.redhat.com/show_bug.cgi?id=1520136 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-01-01 09:46:11 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520173] Review Request: rust-goblin - Impish, cross-platform binary parsing and loading crate
https://bugzilla.redhat.com/show_bug.cgi?id=1520173 Bug 1520173 depends on bug 1520136, which changed state. Bug 1520136 Summary: Review Request: rust-scroll_derive - Macros 1.1 derive implementation for Pread and Pwrite traits from scroll crate https://bugzilla.redhat.com/show_bug.cgi?id=1520136 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520177] Review Request: rust-object - Unified interface for the target platform' s object file format
https://bugzilla.redhat.com/show_bug.cgi?id=1520177 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-01-01 09:35:53 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520182] Review Request: rust-gimli - Blazing fast DWARF debugging format parser
https://bugzilla.redhat.com/show_bug.cgi?id=1520182 Bug 1520182 depends on bug 1520177, which changed state. Bug 1520177 Summary: Review Request: rust-object - Unified interface for the target platform's object file format https://bugzilla.redhat.com/show_bug.cgi?id=1520177 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520195] Review Request: rust-sys-info - Get system information in Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1520195 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-01-01 09:08:39 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520177] Review Request: rust-object - Unified interface for the target platform' s object file format
https://bugzilla.redhat.com/show_bug.cgi?id=1520177 Bug 1520177 depends on bug 1520173, which changed state. Bug 1520173 Summary: Review Request: rust-goblin - Impish, cross-platform binary parsing and loading crate https://bugzilla.redhat.com/show_bug.cgi?id=1520173 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1520173] Review Request: rust-goblin - Impish, cross-platform binary parsing and loading crate
https://bugzilla.redhat.com/show_bug.cgi?id=1520173 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-01-01 09:04:59 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1527289] Review Request: nototools - Noto fonts support tools and scripts plus web site generation
https://bugzilla.redhat.com/show_bug.cgi?id=1527289
--- Comment #9 from Parag AN(पराग) ---
If you follow the current guidelines of Python packaging then you can use the
py2_* and py3_* macros.
Use snapshot release guideline for release tag which should be
Release:0.20170926.git%{shortcommit0}%{?dist}
You may want to use this modified spec file here ->
https://paste.fedoraproject.org/paste/dtiP95sW0puc46~R4z8e9w
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1525900] Review Request: js-html5shiv - Enable use of HTML5 sectioning elements in legacy browsers
https://bugzilla.redhat.com/show_bug.cgi?id=1525900 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com --- Comment #1 from Elliott Sales de Andrade --- There is a problem with the SSL certificate on the site you used for the spec and srpm, and fedora-review is unable to download either one to check them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1525696] Review Request: golang-github-nwidger-jsoncolor - Colorized JSON output for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1525696
Elliott Sales de Andrade changed:
What|Removed |Added
Status|NEW |POST
CC||quantum.anal...@gmail.com
Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com
Flags||fedora-review+
--- Comment #1 from Elliott Sales de Andrade ---
APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 2 files have
unknown license. Detailed output of licensecheck in
review/1525696-golang-github-nwidger-jsoncolor/licensecheck.txt
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode, /usr/share/gocode/src/github.com
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[?]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file
[Bug 1525694] Review Request: golang-github-bitly-go-simplejson - Go package to interact with arbitrary JSON
https://bugzilla.redhat.com/show_bug.cgi?id=1525694
Elliott Sales de Andrade changed:
What|Removed |Added
Status|NEW |POST
CC||quantum.anal...@gmail.com
Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com
Flags||fedora-review+
--- Comment #1 from Elliott Sales de Andrade ---
Looks good to me.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* MIT/X11 (BSD like)", "Unknown or generated". 8
files have unknown license. Detailed output of licensecheck in
review/1525694-golang-github-bitly-go-simplejson/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode, /usr/share/gocode/src/github.com
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
github-bitly-go-simplejson-devel , golang-github-bitly-go-simplejson-
unit-test-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file
