[Bug 1528315] Review Request: pgaudit - PostgreSQL auditing plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1528315

cap.filip@gmail.com changed:

   What|Removed |Added

  Flags|needinfo?(cap.filip.dev@gma |
   |il.com) |



--- Comment #4 from cap.filip@gmail.com ---
fixed. old files on fedorapeople replaced with new ones.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505094] Review Request: budget - Personal financial assistant

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505094



--- Comment #4 from William Moreno  ---
Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/budget.spec
SRPM URL:
https://williamjmorenor.fedorapeople.org/rpmdev/budget-0.0.10.1-2.fc28.src.rpm

Added BR gtk3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530431] Review Request: nodepool - nodes management for a distributed test infrastructure

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530431



--- Comment #2 from Tristan Cacqueray  ---
Thanks for the review Robert.

Spec URL: https://fedorapeople.org/~tdecacqu/pkgs/nodepool.spec
SRPM URL:
https://fedorapeople.org/~tdecacqu/pkgs/nodepool-0.4.0-1.20171214gita20d81c.fc27.src.rpm

New version changes:

- Add %{?systemd_requires}
- Uses %license instead of %doc
- Uses %global gitdate 20171214
- Fixes release and changelog using 1.%{gitdate}git%{shortcommit}%{?dist}
- Fixes LICENSE encoding
- Add logrotate configuration
- Add manpage with help2man
- Fixes %file directives for correct ownership
- Remove sphinx buildinfo


Regarding the remaining rpmlint errors:

non-readable and zero-length /etc/nodepool/secure.conf is expected and may be
removed in the final release. This is a legacy file unused anymore, but the
service still tries to load it.

non-standard-dir-perm 750 are expected because those directory should only be
available to the nodepool user. Not sure why this is an error.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530438] Review Request: R-V8 - Embedded JavaScript Engine for R

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530438



--- Comment #5 from Fedora Update System  ---
R-V8-1.5-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-fb7cc19fb3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530438] Review Request: R-V8 - Embedded JavaScript Engine for R

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530438

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530438] Review Request: R-V8 - Embedded JavaScript Engine for R

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530438



--- Comment #4 from Fedora Update System  ---
R-V8-1.5-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-68e45e4836

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1528781] Review Request: mpfr - multiple-precision floating-point computations [needs sponsor]

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1528781

Pavel Cahyna  changed:

   What|Removed |Added

 CC||jamesturner...@gmail.com
  Flags||needinfo?(jamesturner246@gm
   ||ail.com)



--- Comment #5 from Pavel Cahyna  ---
There is an API change in MPFR 4, see http://www.mpfr.org/mpfr-current/#changes
(also its soname changes to libmpfr.so.6). Given that quite a lot of packages
depend on mpfr, are they ready to cope with this API change?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529891] Review Request: persepolis - A powerful download manager powered by aria2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529891



--- Comment #11 from Fedora Update System  ---
persepolis-3.0.1-2.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-50c7ab5902

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529785] Review Request: python-pypillowfight - Various image processing algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529785



--- Comment #10 from Fedora Update System  ---
python-pypillowfight-0.2.2-2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-afe1741a0f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1513290] Review Request: ocaml-oasis - Tooling for building OCaml libraries and applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1513290

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #9 from Fedora Update System  ---
ocaml-oasis-0.4.10-3.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-afda83891b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529230] Review Request: python-pyinsane2 - Python library to access and use image scanners (Linux /Windows/etc)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529230



--- Comment #9 from Fedora Update System  ---
python-pyinsane2-2.0.10-1.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-7a7f1746e8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1528612] Review Request: librs232 - Library for serial communications over RS-232 with Lua bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1528612



--- Comment #7 from Fedora Update System  ---
librs232-1.0.3-3.20171229git21ecc3c.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-a0899d68d2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402416] Review Request: timew - Timewarrior tracks and reports time

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402416



--- Comment #8 from Fedora Update System  ---
timew-1.0.0-3.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-0fe0962417

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529784] Review Request: shyaml - YAML for command line

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529784



--- Comment #7 from Fedora Update System  ---
shyaml-0.5.0-3.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-911d1e59f0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529758] Review Request: paper-icon-theme - Modern freedesktop icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529758



--- Comment #12 from Fedora Update System  ---
paper-icon-theme-1.4.0-1.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-3cf5fe9165

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530771] Review Request: python3-lupa - Lupa integrates the runtimes of Lua or LuaJIT2 into CPython

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530771

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|POST|ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530771] Review Request: python3-lupa - Lupa integrates the runtimes of Lua or LuaJIT2 into CPython

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530771

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---

 - Remove the superfluous %check

 - Source0 could be simplified like this:

Source0:   
https://github.com/scoder/%{srcname}/archive/%{srcname}-%{version}/%{srcname}-%{srcname}-%{version}.tar.gz

 - The Github page states it is also compatible with Python 2.6 and later
("tested with Python 2.6/3.2 and later"). You should probably generate both
python2 and python3 subpackages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530438] Review Request: R-V8 - Embedded JavaScript Engine for R

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530438



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/R-V8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530352] Review Request: calligraplan - A Project Planner

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530352



--- Comment #11 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/calligraplan

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526847] Review Request: python-softlayer - SoftLayer API Python Client and library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526847

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #8 from Robert-André Mauchin  ---
Package approved.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 421 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/python-softlayer/review-python-
 softlayer/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 61440 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-softlayer , python3-softlayer
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary 

[Bug 1529891] Review Request: persepolis - A powerful download manager powered by aria2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529891

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
persepolis-3.0.1-2.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-2e35b639c9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529643] Review Request: python-zuul-sphinx - A Sphinx extension for documenting Zuul jobs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529643

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---
   Keywords||Reopened



--- Comment #6 from Fedora Update System  ---
python-zuul-sphinx-0.2.1-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-5a2a61caa1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525696] Review Request: golang-github-nwidger-jsoncolor - Colorized JSON output for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525696

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
golang-github-nwidger-jsoncolor-0-0.1.20170215git75a6de4.fc27 has been pushed
to the Fedora 27 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-343f30b49e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1528612] Review Request: librs232 - Library for serial communications over RS-232 with Lua bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1528612

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
librs232-1.0.3-3.20171229git21ecc3c.fc27 has been pushed to the Fedora 27
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-b490728a33

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402416] Review Request: timew - Timewarrior tracks and reports time

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402416

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
timew-1.0.0-3.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-f10bc5d87f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529230] Review Request: python-pyinsane2 - Python library to access and use image scanners (Linux /Windows/etc)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529230

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
python-pyinsane2-2.0.10-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-6642f2fc52

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1513733] Review Request: libcircle - A library used to distribute workloads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1513733

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
libcircle-0.2.1-0.3rc1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-0975aa7ad1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529784] Review Request: shyaml - YAML for command line

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529784

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
shyaml-0.5.0-3.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-b4f66a68b6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529785] Review Request: python-pypillowfight - Various image processing algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529785

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
python-pypillowfight-0.2.2-2.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-96ce59df4a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519608] Review Request: gap-pkg-sophus - Computing in nilpotent Lie algebras

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519608

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|ON_QA



--- Comment #4 from Fedora Update System  ---
gap-pkg-sophus-1.23-1.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-0fe1c1ffed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529936] Review Request: dianara - Pump.io application for the desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529936

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
dianara-1.4.1-2.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-4885fe3613

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529758] Review Request: paper-icon-theme - Modern freedesktop icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529758

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #11 from Fedora Update System  ---
paper-icon-theme-1.4.0-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-8c19ed35f9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529758] Review Request: paper-icon-theme - Modern freedesktop icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529758

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-01-03 16:32:57



--- Comment #10 from Fedora Update System  ---
paper-icon-theme-1.4.0-1.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529593] Review Request: adapta-gtk-theme - An adaptive Gtk+ theme based on Material Design Guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529593

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-01-03 16:32:54



--- Comment #13 from Fedora Update System  ---
adapta-gtk-theme-3.92.2.63-1.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506419] Review Request: python-pep8-naming - Check PEP-8 naming conventions, a plugin for flake8

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506419



--- Comment #5 from Fedora Update System  ---
python-pep8-naming-0.4.1-4.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-c15d7786a8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506419] Review Request: python-pep8-naming - Check PEP-8 naming conventions, a plugin for flake8

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506419



--- Comment #4 from Fedora Update System  ---
python-pep8-naming-0.4.1-4.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-3dadf51714

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506419] Review Request: python-pep8-naming - Check PEP-8 naming conventions, a plugin for flake8

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506419

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1515701] Review Request: diceware - It will create passphrases which one can remember

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1515701

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-01-03 16:19:15



--- Comment #10 from Fedora Update System  ---
diceware-0.9.3-3.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526847] Review Request: python-softlayer - SoftLayer API Python Client and library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526847



--- Comment #7 from Athmane Madjoudj  ---
It seems that the test are failing randomly in Koji but not in local mock due
to the fact they try to do local DNS lookup which depends on config of the
build host.

I've disabled more of those test.

Spec URL: https://athmane.fedorapeople.org/review/python-softlayer.spec
SRPM URL:
https://athmane.fedorapeople.org/review/python-softlayer-5.3.2-2.fc27.src.rpm

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=23986549

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529396] Review Request: python3-websocket-client - WebSocket client for python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529396

Carl George  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2018-01-03 15:47:28



--- Comment #7 from Carl George  ---
https://bodhi.fedoraproject.org/updates/python3-websocket-client-0.46.0-1.el7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530352] Review Request: calligraplan - A Project Planner

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530352



--- Comment #10 from Rex Dieter  ---
Thanks for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530352] Review Request: calligraplan - A Project Planner

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530352

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #9 from Robert-André Mauchin  ---
Ok then the package is approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530352] Review Request: calligraplan - A Project Planner

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530352



--- Comment #8 from Rex Dieter  ---
/usr/share/config.kcfg ownership added:
https://src.fedoraproject.org/rpms/kf5/c/8a1196371df990a8d43be24464b726f2c3fc38db

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530438] Review Request: R-V8 - Embedded JavaScript Engine for R

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530438

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---

 - %{_datadir}/javascript → %{_jsdir}

Package otherwise approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


 = MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 37 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/R-V8/review-R-V8/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

R:
[x]: Package contains the mandatory BuildRequires.
[x]: The package has the standard %install section.

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: 

[Bug 1530352] Review Request: calligraplan - A Project Planner

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530352



--- Comment #7 from Rex Dieter  ---
Spec URL: https://rdieter.fedorapeople.org/rpms/calligra/calligraplan.spec
SRPM URL:
https://rdieter.fedorapeople.org/rpms/calligra/calligraplan-3.0.91-3.el7.src.rpm

* Wed Jan 03 2018 Rex Dieter  3.0.91-3
- -libs: really add ldconfig scriptlet
- fix icon dir ownership


Ownership of /usr/share/config.kcfg is not a problem specific to this package,
and should be owned elsewhere.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530771] New: Review Request: python3-lupa - Lupa integrates the runtimes of Lua or LuaJIT2 into CPython

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530771

Bug ID: 1530771
   Summary: Review Request: python3-lupa - Lupa integrates the
runtimes of Lua or LuaJIT2 into CPython
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: dhanes...@disroot.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://pagure.io/rpm-packaging/raw/master/f/python3-lupa/python3-lupa.spec
SRPM URL:
https://pagure.io/rpm-packaging/raw/master/f/python3-lupa/python3-lupa-1.6-1.fc27.src.rpm

Description: Lupa integrates the runtimes of Lua or LuaJIT2 into CPython. It is
a partial rewrite of LunaticPython in Cython with some additional features such
as proper coroutine support.

Fedora Account System Username: dhanesh95

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530431] Review Request: nodepool - nodes management for a distributed test infrastructure

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530431

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
 - You need systemd requires too, add:

%{?systemd_requires}
BuildRequires: systemd

   See https://fedoraproject.org/wiki/Packaging:Scriptlets#Systemd

 - The license file mist be installed with the %license macro, not %doc:

%files
%license LICENSE

 - Some dirs are not owned:

[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python3.6/site-
 packages/nodepool/driver, /usr/lib/python3.6
 /site-packages/nodepool, /etc/nodepool

 - gitdate should not be separated by dots:

%global gitdate 20171214

  - The Release field should mention the type of VCS:

Release:1.%{gitdate}git%{shortcommit}%{?dist}

  - The %changelog release info are not identical to the header ones:

* Wed Jan  3 2018 Tristan Cacqueray  -
0.4.0-1.20171214gita20d81c

 - Fix the line encodings for the LICENSE file:

nodepool-launcher.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/nodepool-launcher/LICENSE

 - You must ship a logrotate config file for your log. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Logrotate_config_file


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "*No copyright* Apache", "Unknown or
 generated", "*No copyright* Apache (v2.0)". 33 files have unknown
 license. Detailed output of licensecheck in
 /home/bob/packaging/review/nodepool/review-nodepool/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /etc/nodepool
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python3.6/site-
 packages/nodepool/driver, /usr/lib/systemd/system, /usr/lib/python3.6
 /site-packages/nodepool, /etc/nodepool, /usr/lib/systemd
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
 → Missing sytemd requires
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 81920 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: 

[Bug 1530084] Review Request: numix-icon-theme-square - Numix Project square icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530084



--- Comment #3 from Brendan Early  ---
Changes made, new files:

Spec URL:
https://raw.githubusercontent.com/mymindstorm/numix-square-spec/master/numix-icon-theme-square.spec
SRPM URL:
https://raw.githubusercontent.com/mymindstorm/numix-square-spec/master/numix-icon-theme-square-0.1.0-1.20171225.git084e0ae.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1513733] Review Request: libcircle - A library used to distribute workloads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1513733



--- Comment #11 from Christoph Junghans  ---
(In reply to Ankur Sinha (FranciscoD) from comment #10)
> Ah - I only said so because I didn't see a message notifying us of a
> completed SCM request like this one:
Yeah, it must have gotten lost in the last big infrastructure update move.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402416] Review Request: timew - Timewarrior tracks and reports time

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402416



--- Comment #6 from Fedora Update System  ---
timew-1.0.0-3.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-0fe0962417

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402416] Review Request: timew - Timewarrior tracks and reports time

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402416



--- Comment #5 from Fedora Update System  ---
timew-1.0.0-3.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-f10bc5d87f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402416] Review Request: timew - Timewarrior tracks and reports time

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402416

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529396] Review Request: python3-websocket-client - WebSocket client for python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529396



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python3-websocket-client. You may commit to
the branch "epel7" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530718] Review Request: rust-backtrace-sys - Bindings to the libbacktrace gcc library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530718



--- Comment #2 from Igor Gnatenko  ---
Because there is no system one... Same reason as we do for Rust itself.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525906] Review Request: js-respond - A fast & lightweight polyfill for min/ max-width CSS3 Media Queries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525906

Xavier Bachelot  changed:

   What|Removed |Added

 Resolution|CURRENTRELEASE  |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525900] Review Request: js-html5shiv - Enable use of HTML5 sectioning elements in legacy browsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525900

Xavier Bachelot  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-03 12:04:54



--- Comment #4 from Xavier Bachelot  ---
Thanks for the review !
Imported and built for Rawhide and F27.
F26, EL7 and EL6 are missing a dependency, I've filed RHBZ#1530733.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525906] Review Request: js-respond - A fast & lightweight polyfill for min/ max-width CSS3 Media Queries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525906

Xavier Bachelot  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2018-01-03 12:03:07



--- Comment #3 from Xavier Bachelot  ---
Thanks for the review !
Imported and built for Rawhide, F27, F26, EL7 and EL6.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530718] Review Request: rust-backtrace-sys - Bindings to the libbacktrace gcc library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530718



--- Comment #1 from Neal Gompa  ---
Question: why are you continuing to use a bundled copy of libbacktrace instead
of using the system provided one?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530669] Review Request: perl-RDF-NS-Curated - Curated set of RDF prefixes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530669

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-RDF-NS-Curated-0.005-1.fc28.noarch.rpm | sort | uniq
-c
  1 perl(:MODULE_COMPAT_5.26.1)
  1 perl(strict)
  1 perl(:VERSION) >= 5.6.0
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-RDF-NS-Curated-0.005-1.fc28.noarch.rpm | sort | uniq
-c
  1 perl(RDF::NS::Curated) = 0.005
  1 perl-RDF-NS-Curated = 0.005-1.fc28
Binary provides are Ok.

$ rpmlint ./perl-RDF-NS-Curated*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1513733] Review Request: libcircle - A library used to distribute workloads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1513733



--- Comment #10 from Ankur Sinha (FranciscoD)  ---
Ah - I only said so because I didn't see a message notifying us of a completed
SCM request like this one:

https://bugzilla.redhat.com/show_bug.cgi?id=1402416#c4

Anyway, thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508950] Review Request: eccodes - a library for decoding and encoding WMO data formats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508950



--- Comment #7 from Jos de Kloe  ---
Spec URL: http://www.jdekloe.nl/Fedora/eccodes-2.6.0-1-rev1/eccodes.spec
SRPM URL:
http://www.jdekloe.nl/Fedora/eccodes-2.6.0-1-rev1/eccodes-2.6.0-1.fc28.src.rpm

sorry, there was a typo in the srpm package. This one should work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530718] Review Request: rust-backtrace-sys - Bindings to the libbacktrace gcc library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530718

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508950] Review Request: eccodes - a library for decoding and encoding WMO data formats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508950



--- Comment #6 from Jos de Kloe  ---
Spec URL: http://www.jdekloe.nl/Fedora/eccodes-2.6.0-1-rev1/eccodes.spec
SRPM URL:
http://www.jdekloe.nl/Fedora/eccodes-2.6.0-1-rev1/eccodes-2.6.0-1.fc26.src.rpm

Thanks a lot for your comments.
The above links point to my next iteration.
Changes this time are:
* update to new upstream version 2.6.0
* defined a downstream so version since upstream refuses to do so
* found that next to LD_LIBRARY_PATH the tests also need the LIBRARY_PATH
environment setting, since many tests generate c or fortran code and compile it
on the fly. Without it the compiler does not find the libraries in the build
tree. With this change the rpath setting could be removed from the eccodes.pc
and eccodes_f90.pc without the earlier mentioned problems
* added a small patch to fix 2 remaining failures for tests that compile pieces
of fortran code

With these changes the number of errors reported by rpmlint is reduced to 5.
Four of the remaining errors are false positives since they are triggered by
data files that start with something resembling a shebang as mentioned above.

The only other error is:
   eccodes-debuginfo.x86_64: E: useless-provides debuginfo(build-id)
I suspect this is caused by the fact that the package installs two tools in the
bin directory that are binary identical to each other. I don't think I can fix
that, since it is an upstream choice to do it like that.

I noticed two new warnings on the so files that I don't understand yet:
eccodes.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libeccodes.so
eccodes.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libeccodes_f90.so
this seems not correct to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520581] Review Request: perl-Authen-Passphrase - Hashed passwords/ passphrases as objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520581

Petr Pisar  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Petr Pisar  ---
Url and Source0 addresses are Ok.
Source archive (SHA-256:
55db4520617d859d88c0ee54965da815b7226d792b8cdc8debf92073559e0463) is original.
Ok.
Summary verified from lib/Authen/Passphrase.pm. Ok.

TODO: The Description text is about Authen::Passphrase module only while the
perl-Authen-Passphrase package provides all the modules included in the
Authen-Passphrase CPAN distribition. I recommend to change the Description text
so that it's more representative. E.g.:

  These Perl modules provide a passphrase recognizer. Its job is
  to recognize whether an offered passphrase is the right one. Various
  passphrase encoding schemes are supported.

License verified from lib/Authen/Passphrase, README, and other files. Ok.
No XS code, noarch BuildArch is Ok.

Build-time requires are Ok.
All tests pass. Ok.

$ rpmlint perl-Authen-Passphrase.spec
../SRPMS/perl-Authen-Passphrase-0.008-1.fc28.src.rpm
../RPMS/noarch/perl-Authen-Passphrase-0.008-1.fc28.noarch.rpm 
perl-Authen-Passphrase.src: W: spelling-error Summary(en_US) passphrases ->
pass phrases, pass-phrases, paraphrases
perl-Authen-Passphrase.src: W: spelling-error %description -l en_US passphrases
-> pass phrases, pass-phrases, paraphrases
perl-Authen-Passphrase.src: W: spelling-error %description -l en_US recogniser
-> recognizer, recognize
perl-Authen-Passphrase.src: W: spelling-error %description -l en_US recognise
-> recognize, recognition
perl-Authen-Passphrase.src: W: spelling-error %description -l en_US recognisers
-> recognizes
perl-Authen-Passphrase.noarch: W: spelling-error Summary(en_US) passphrases ->
pass phrases, pass-phrases, paraphrases
perl-Authen-Passphrase.noarch: W: spelling-error %description -l en_US
passphrases -> pass phrases, pass-phrases, paraphrases
perl-Authen-Passphrase.noarch: W: spelling-error %description -l en_US
recogniser -> recognizer, recognize
perl-Authen-Passphrase.noarch: W: spelling-error %description -l en_US
recognise -> recognize, recognition
perl-Authen-Passphrase.noarch: W: spelling-error %description -l en_US
recognisers -> recognizes
2 packages and 1 specfiles checked; 0 errors, 10 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Authen-Passphrase-0.008-1.fc28.noarch.rpm 
drwxr-xr-x2 rootroot0 Jan  3 17:25
/usr/share/doc/perl-Authen-Passphrase
-rw-r--r--1 rootroot 8780 Feb  4  2012
/usr/share/doc/perl-Authen-Passphrase/Changes
-rw-r--r--1 rootroot 1411 Feb  4  2012
/usr/share/doc/perl-Authen-Passphrase/README
-rw-r--r--1 rootroot 7314 Jan  3 17:25
/usr/share/man/man3/Authen::Passphrase.3pm.gz
-rw-r--r--1 rootroot 2771 Jan  3 17:25
/usr/share/man/man3/Authen::Passphrase::AcceptAll.3pm.gz
-rw-r--r--1 rootroot 3718 Jan  3 17:25
/usr/share/man/man3/Authen::Passphrase::BigCrypt.3pm.gz
-rw-r--r--1 rootroot 4642 Jan  3 17:25
/usr/share/man/man3/Authen::Passphrase::BlowfishCrypt.3pm.gz
-rw-r--r--1 rootroot 2674 Jan  3 17:25
/usr/share/man/man3/Authen::Passphrase::Clear.3pm.gz
-rw-r--r--1 rootroot 3676 Jan  3 17:25
/usr/share/man/man3/Authen::Passphrase::Crypt16.3pm.gz
-rw-r--r--1 rootroot 5134 Jan  3 17:25
/usr/share/man/man3/Authen::Passphrase::DESCrypt.3pm.gz
-rw-r--r--1 rootroot 3068 Jan  3 17:25
/usr/share/man/man3/Authen::Passphrase::EggdropBlowfish.3pm.gz
-rw-r--r--1 rootroot 3282 Jan  3 17:25
/usr/share/man/man3/Authen::Passphrase::LANManager.3pm.gz
-rw-r--r--1 rootroot 3305 Jan  3 17:25
/usr/share/man/man3/Authen::Passphrase::LANManagerHalf.3pm.gz
-rw-r--r--1 rootroot 4133 Jan  3 17:25
/usr/share/man/man3/Authen::Passphrase::MD5Crypt.3pm.gz
-rw-r--r--1 rootroot 2894 Jan  3 17:25
/usr/share/man/man3/Authen::Passphrase::MySQL323.3pm.gz
-rw-r--r--1 rootroot 2841 Jan  3 17:25
/usr/share/man/man3/Authen::Passphrase::MySQL41.3pm.gz
-rw-r--r--1 rootroot 3168 Jan  3 17:25
/usr/share/man/man3/Authen::Passphrase::NTHash.3pm.gz
-rw-r--r--1 rootroot 3288 Jan  3 17:25
/usr/share/man/man3/Authen::Passphrase::NetscapeMail.3pm.gz
-rw-r--r--1 rootroot 3752 Jan  3 17:25
/usr/share/man/man3/Authen::Passphrase::PHPass.3pm.gz
-rw-r--r--1 rootroot 2758 Jan  3 17:25
/usr/share/man/man3/Authen::Passphrase::RejectAll.3pm.gz
-rw-r--r-- 

[Bug 1530718] New: Review Request: rust-backtrace-sys - Bindings to the libbacktrace gcc library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530718

Bug ID: 1530718
   Summary: Review Request: rust-backtrace-sys - Bindings to the
libbacktrace gcc library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-backtrace-sys.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-backtrace-sys-0.1.16-1.fc28.src.rpm
Description: Bindings to the libbacktrace gcc library.
FAS account: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491281] Review Request: python-libsass - python bindings for libsass

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491281

Marcel Plch  changed:

   What|Removed |Added

  Flags|needinfo?(mp...@redhat.com) |



--- Comment #12 from Marcel Plch  ---
I managed to push a patch to the upstream for easier packaging.
Not much since then, I'm currently working on some matters around cpython, but
I'd like to finish this package during January.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530669] Review Request: perl-RDF-NS-Curated - Curated set of RDF prefixes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530669

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530060] Review Request: python-rnc2rng - RELAX NG Compact to regular syntax conversion library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530060

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-03 11:24:30



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530060] Review Request: python-rnc2rng - RELAX NG Compact to regular syntax conversion library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530060
Bug 1530060 depends on bug 1530059, which changed state.

Bug 1530059 Summary: Review Request: python-rply - Port David Beazley's PLY to 
RPython
https://bugzilla.redhat.com/show_bug.cgi?id=1530059

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530059] Review Request: python-rply - Port David Beazley' s PLY to RPython

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530059

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-03 11:24:26



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1513733] Review Request: libcircle - A library used to distribute workloads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1513733

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1513733] Review Request: libcircle - A library used to distribute workloads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1513733



--- Comment #9 from Fedora Update System  ---
libcircle-0.2.1-0.3rc1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-0975aa7ad1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530352] Review Request: calligraplan - A Project Planner

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530352



--- Comment #6 from Robert-André Mauchin  ---
 - /usr/share/config.kcfg still has no owner

 - /usr/share/icons/hicolor (%{_kf5_datadir}/icons/*/*/*) should not be owned
by this package since it is owned by hicolor-icon-theme

 - /sbin/ldconfig should probably be called in calligraplan-libs too

%post -n libs -p /sbin/ldconfig
%postun -n libs -p /sbin/ldconfig


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- ldconfig called in %post and %postun if required.
  Note: /sbin/ldconfig not called in calligraplan-libs
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL (v2)", "LGPL (v2 or later)", "GPL (v2 or later)",
 "Unknown or generated", "LGPL", "LGPL (v2.1)", "BSD (3 clause)", "LGPL
 (v2.1 or later)", "GPL (v2)". 641 files have unknown license. Detailed
 output of licensecheck in /home/bob/packaging/review/calligraplan
 /review-calligraplan/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[-]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/icons/hicolor/1024x1024
[!]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/icons/hicolor/1024x1024, /usr/share/icons/hicolor,
 /usr/share/kxmlgui5, /usr/share/config.kcfg
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/icons/hicolor/16x16/mimetypes(hicolor-icon-theme),
 /usr/share/icons/hicolor/22x22/apps(hicolor-icon-theme, fedora-logos),
 /usr/share/calligraplanwork/icons/hicolor/48x48(calligra-plan),
 /usr/share/icons/hicolor/32x32/apps(hicolor-icon-theme, fedora-logos),
 /usr/share/icons/hicolor/16x16/apps(hicolor-icon-theme, fedora-logos),
 /usr/share/icons/hicolor/128x128/apps(hicolor-icon-theme),
 /usr/share/icons/hicolor/128x128/mimetypes(hicolor-icon-theme),
 /usr/share/calligraplanwork/templates/Simple/.source(calligra-plan),
 /usr/share/calligraplan/icons/hicolor/48x48/actions(calligra-plan),
 /usr/share/calligraplanwork/icons/hicolor/32x32/actions(calligra-
 plan), /usr/share/calligraplan/templates/Simple(calligra-plan),
 /usr/share/icons/hicolor/48x48/mimetypes(hicolor-icon-theme),
 /usr/share/icons/hicolor/256x256/apps(hicolor-icon-theme, fedora-
 logos), /usr/share/calligraplanwork/icons/hicolor/16x16/actions
 (calligra-plan), /usr/share/icons/hicolor/64x64/mimetypes(hicolor-
 icon-theme), /usr/share/icons/hicolor/scalable/mimetypes(hicolor-icon-
 theme), /usr/share/calligraplan/about(calligra-plan),
 /usr/lib64/qt5/plugins/calligraplan(calligra-plan-libs),
 /usr/share/calligraplan/icons/hicolor(calligra-plan),
 /usr/share/calligraplan/icons(calligra-plan),
 /usr/share/calligraplanwork/icons/hicolor/22x22/actions(calligra-
 plan), /usr/share/kxmlgui5/calligraplan(calligra-plan),
 /usr/share/icons/hicolor/48x48/apps(hicolor-icon-theme, fedora-logos),
 /usr/share/calligraplan/icons/hicolor/scalable/actions(calligra-plan),
 /usr/share/calligraplan(calligra-plan),
 /usr/share/calligraplanwork/icons/hicolor/22x22(calligra-plan),
 /usr/share/calligraplanwork/templates(calligra-plan),
 /usr/share/calligraplanwork/icons/hicolor/32x32(calligra-plan),
 /usr/share/calligraplan/templates(calligra-plan),
 /usr/share/calligraplanwork(calligra-plan),
 /usr/share/icons/hicolor/512x512/apps(hicolor-icon-theme),
 /usr/share/icons/hicolor/scalable/apps(hicolor-icon-theme, fedora-
 logos), /usr/share/calligraplanwork/icons/hicolor/64x64(calligra-
 plan), /usr/share/calligraplanwork/icons/hicolor(calligra-plan),
 /usr/share/icons/hicolor/22x22/mimetypes(hicolor-icon-theme),
 /usr/share/calligraplanwork/icons/hicolor/16x16(calligra-plan),
 /usr/share/icons/hicolor/64x64/apps(hicolor-icon-theme),
 /usr/share/kxmlgui5/calligraplanwork(calligra-plan),
 /usr/lib64/qt5/plugins/calligraplan/schedulers(calligra-plan-libs),
 

[Bug 1520581] Review Request: perl-Authen-Passphrase - Hashed passwords/ passphrases as objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520581

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530669] New: Review Request: perl-RDF-NS-Curated - Curated set of RDF prefixes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530669

Bug ID: 1530669
   Summary: Review Request: perl-RDF-NS-Curated - Curated set of
RDF prefixes
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ppisar.fedorapeople.org/perl-RDF-NS-Curated/perl-RDF-NS-Curated.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-RDF-NS-Curated/perl-RDF-NS-Curated-0.005-1.fc28.src.rpm
Description:
This contains a list of prefix and URI pairs that are commonly used in RDF.
The intention is that prefixes in this list can be safely used in code that
has a long lifetime. The list has been derived mostly from W3C standards
documents, but also some popularity lists.
Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530668] New: Review Request: rust-libloading - Safer binding to platform’s dynamic library loading utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530668

Bug ID: 1530668
   Summary: Review Request: rust-libloading - Safer binding to
platform’s dynamic library loading utilities
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-libloading.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-libloading-0.4.3-1.fc28.src.rpm
Description: Safer binding to platform’s dynamic library loading utilities.
FAS account: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529012] Review Request: js-jsroot - JavaScript ROOT

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529012

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1513733] Review Request: libcircle - A library used to distribute workloads

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1513733



--- Comment #8 from Christoph Junghans  ---
(In reply to Ankur Sinha (FranciscoD) from comment #7)
> When you have a few cycles to spare, please proceed with the SCM requests as
> documented here:
I wasn't really planning to package it for anything, but f28, however f27
doesn't hurt I guess.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514115] Review Request: python-rsd-lib - python library for communicating with Intel Rack Scale Design enabled hardware

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514115

Jon Schlueter  changed:

   What|Removed |Added

 Blocks||1466874




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1466874
[Bug 1466874] [Intel OSP13] Discover and compose Intel RSD nodes
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514119] Add python-rsdclient to RDO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514119

Jon Schlueter  changed:

   What|Removed |Added

 Blocks||1466874




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1466874
[Bug 1466874] [Intel OSP13] Discover and compose Intel RSD nodes
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530658] New: Review Request: rust-glib - Rust bindings for the GLib library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530658

Bug ID: 1530658
   Summary: Review Request: rust-glib - Rust bindings for the GLib
library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-glib.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-glib-0.4.0-1.fc28.src.rpm
Description: Rust bindings for the GLib library.
FAS account: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1528186] Review Request: js-jquery-ui-touch-punch - Touch Event Support for jQuery UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1528186



--- Comment #3 from Mattias Ellert  ---
Thank you for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1523302] Review Request: yuicompressor - YUI Compressor - The Yahoo JavaScript and CSS Compressor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1523302



--- Comment #3 from Mattias Ellert  ---
Thank you for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402416] Review Request: timew - Timewarrior tracks and reports time

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402416



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/timew

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402416] Review Request: timew - Timewarrior tracks and reports time

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402416



--- Comment #3 from Ankur Sinha (FranciscoD)  ---
Thanks! 

Updated the spec to add the missing BR and did a test scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=23982912

Requesting pagure repo now. Cheers!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1528186] Review Request: js-jquery-ui-touch-punch - Touch Event Support for jQuery UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1528186



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/js-jquery-ui-touch-punch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1523302] Review Request: yuicompressor - YUI Compressor - The Yahoo JavaScript and CSS Compressor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1523302



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/yuicompressor

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520182] Review Request: rust-gimli - Blazing fast DWARF debugging format parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520182

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-03 09:42:44



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520923] Review Request: rust-newtype_derive - Macros for deriving common traits for newtype structures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520923

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-03 09:42:37



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520931] Review Request: rust-gobject-sys - FFI bindings to libgobject-2.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520931

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-03 09:42:32



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520939] Review Request: rust-c_vec - Structures to wrap C arrays

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520939

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-03 09:42:12



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529396] Review Request: python3-websocket-client - WebSocket client for python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529396

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Robert-André Mauchin  ---
Ok, package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529012] Review Request: js-jsroot - JavaScript ROOT

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529012



--- Comment #2 from Mattias Ellert  ---
Spec URL: http://grid.tsl.uu.se/review/js-jsroot.spec
SRPM URL: http://grid.tsl.uu.se/review/js-jsroot-5.3.4-2.fc27.src.rpm

Thank you for reviewing the package.
Updated version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529425] Review Request: python3-backports-ssl_match_hostname - The ssl.match_hostname() function from Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529425

Carl George  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2018-01-03 09:28:39



--- Comment #4 from Carl George  ---
https://bodhi.fedoraproject.org/updates/python3-backports-ssl_match_hostname-3.5.0.1-1.el7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530352] Review Request: calligraplan - A Project Planner

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530352



--- Comment #5 from Rex Dieter  ---
Spec URL: https://rdieter.fedorapeople.org/rpms/calligra/calligraplan.spec
SRPM URL:
https://rdieter.fedorapeople.org/rpms/calligra/calligraplan-3.0.91-1.fc27.src.rpm

%changelog
* Tue Jan 02 2018 Rex Dieter  - 3.0.91-2
- drop x-test locale
- -libs: +ldconfig scriptlet, delete lib.so symlinks, Provides:
calligra-plan-libs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1530352] Review Request: calligraplan - A Project Planner

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1530352



--- Comment #4 from Rex Dieter  ---

* added /usr/share/kxmlgui5 ownership in kf5-kxmlgui packaging

* kf5-kiconthemes already Requires: hicolor-icon-theme

* hicolor-icon-theme already includes scriptlet triggers (though apparently
packaging guidelines aren't updated to reflect that yet):
https://src.fedoraproject.org/rpms/hicolor-icon-theme/blob/master/f/hicolor-icon-theme.spec#_32

* -libs pkg dep on main package should not use %%{_?isa}, that's the whole
point of making a -libs subpkg so that the other content is not multilib'd.

items I'll address:
* remove *.so symlinks (ie, lack of -devel subpkg), they're not used anywhere
else

* remove x-test locale

* can add Provides: calligra-plan-libs too I suppose, though nothing else
should use it.

* Scriptlets: drop desktop/mime, add ldconfig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529402] Review Request: python3-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529402

Carl George  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2018-01-03 09:04:24



--- Comment #8 from Carl George  ---
https://bodhi.fedoraproject.org/updates/python3-docker-pycreds-0.2.1-1.el7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529023] Review Request: python-validators - Data Validation in python for Humans

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529023



--- Comment #8 from William Moreno  ---
> 
> Package APPROVED!

Thanks for this review, please ping if you need a package review, the 3
packages you have listed are already aproved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529396] Review Request: python3-websocket-client - WebSocket client for python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529396



--- Comment #4 from Carl George  ---
Bumped to 0.46.0 as requested.

Spec URL: https://carlwgeorge.fedorapeople.org/python3-websocket-client.spec
SRPM URL:
https://carlwgeorge.fedorapeople.org/python3-websocket-client-0.46.0-1.el7.centos.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529425] Review Request: python3-backports-ssl_match_hostname - The ssl.match_hostname() function from Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529425



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python3-backports-ssl_match_hostname. You
may commit to the branch "epel7" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org