[Bug 1531955] Review Request: seqan2 - C++ library of efficient algorithms and data structures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531955



--- Comment #3 from Alec Leamas  ---
At a glance, here are bundling issues. The library
util/py_lib/seqan/dox/tpl/lib includes several bundled libraries whih needs to
be dealt with. In particular, shouldn't the bundled font be unbundled even
under current, somewhat relaxed rules?

Also the license situation is somewhat more complicated than what could be
expressed in a few comments. I suggest that you run fedora-review and use the
license-check.txt file created, review it and use it as license clarification.

This is just some initial findings.  seqan2 is quite a large package, and I
expect there is more. Please take a stab at this for now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532136] New: Review Request: ocaml-ppx-tools-versioned - Tools for authors of ppx rewriters

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532136

Bug ID: 1532136
   Summary: Review Request: ocaml-ppx-tools-versioned - Tools for
authors of ppx rewriters
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: a...@onthewings.net
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://gist.github.com/andyli/0352fe58d9230f0725206942bb9cbfee/raw/49cbc722d4ce2b2b11d42e3509ca89f08e4967bb/ocaml-ppx-tools-versioned.spec
SRPM URL:
https://gist.github.com/andyli/0352fe58d9230f0725206942bb9cbfee/raw/49cbc722d4ce2b2b11d42e3509ca89f08e4967bb/ocaml-ppx-tools-versioned-5.0.1-1.fc28.src.rpm
Description: Tools for authors of ppx rewriters
Fedora Account System Username: andyli

This is a dependency of sedlex, which is used by the next version of Haxe
(v4.0.0).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519607] Review Request: gap-pkg-nautytracesinterface - GAP interface to nauty and Traces

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519607



--- Comment #5 from Fedora Update System  ---
gap-pkg-nautytracesinterface-0.2-1.20171120git5f16120.fc27 has been submitted
as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-e77c76c909

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519607] Review Request: gap-pkg-nautytracesinterface - GAP interface to nauty and Traces

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519607

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440971] Review Request: python-pyclipper - Cython wrapper for the C++ translation of the Angus Johnson 's Clipper library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440971



--- Comment #19 from Elliott Sales de Andrade  ---
The warnings seem to be gone in the latest version. Please update and I think
this should be good to go.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532042] Review Request: compton - Compositor for X11

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532042

Abhiram K <4kuch...@gmail.com> changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532068] Review Request: stratisd - Daemon that manages block devices to create filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532068

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-07 21:27:49



--- Comment #3 from Igor Gnatenko  ---
With some manual pedaling, it is built!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531288] Review Request: python3-gssapi - Python 3 Bindings for GSSAPI (RFC 2743/ 2744 and extensions)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531288



--- Comment #3 from Carl George  ---
This latest spec file builds a python3-gssapi RPM, not a python34-gssapi RPM
like it should.  The sections `%package -n %{python3}-gssapi`, `%description -n
%{python3}-gssapi`, and `%files -n %{python3}-gssapi` must be added back.  It's
fine to remove the _description macro, that just means you'll have duplicate
`%description` and `%description -n %{python3}-gssapi` sections.

> CFLAGS="%{optflags}" %py3_build

That macro already contains the same CFLAGS variable, it's not necessary to
specify it again.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532106] Review Request: python-into-dbus-python - Transformer to dbus-python types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532106

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |POST



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532084] Review Request: python-dbus-signature-pyparsing - A parser for a dbus signature

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532084

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1532106




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1532106
[Bug 1532106] Review Request: python-into-dbus-python - Transformer to
dbus-python types
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532106] Review Request: python-into-dbus-python - Transformer to dbus-python types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532106

Igor Gnatenko  changed:

   What|Removed |Added

 Depends On||1532084
   Assignee|nob...@fedoraproject.org|ignate...@redhat.com
  Flags||fedora-review+



--- Comment #1 from Igor Gnatenko  ---
LGTM.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1532084
[Bug 1532084] Review Request: python-dbus-signature-pyparsing - A parser
for a dbus signature
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532106] New: Review Request: python-into-dbus-python - Transformer to dbus-python types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532106

Bug ID: 1532106
   Summary: Review Request: python-into-dbus-python - Transformer
to dbus-python types
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ilya.grad...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://github.com/ilgrad/fedora-packages/raw/master/python/python-into-dbus-python.spec
SRPM URL:
https://github.com/ilgrad/fedora-packages/raw/master/python/python-into-dbus-python-0.06-1.fc27.src.rpm
Description: Generates functions that transform values in Python core types to
values in dbus-python types.
Fedora Account System Username: ilgrad

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532084] Review Request: python-dbus-signature-pyparsing - A parser for a dbus signature

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532084

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|ignate...@redhat.com
  Flags||fedora-review+



--- Comment #1 from Igor Gnatenko  ---
No issues found.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532094] Review Request: python-hs-dbus-signature - Hypothesis strategy that generates arbitrary d-bus signatures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532094



--- Comment #5 from Igor Gnatenko  ---
Everything looks good now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532094] Review Request: python-hs-dbus-signature - Hypothesis strategy that generates arbitrary d-bus signatures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532094

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|ignate...@redhat.com
  Flags||fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532094] Review Request: python-hs-dbus-signature - Hypothesis strategy that generates arbitrary d-bus signatures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532094



--- Comment #4 from Ilya Gradina  ---
(In reply to Igor Gnatenko from comment #3)
> Also, neither %doc or %license is specified. All files are in place, so you
> should reference them.

thx).

new spec:
https://github.com/ilgrad/fedora-packages/raw/master/python/python-hs-dbus-signature.spec
new srpm:
https://github.com/ilgrad/fedora-packages/raw/master/python/python-hs-dbus-signature-0.05-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532094] Review Request: python-hs-dbus-signature - Hypothesis strategy that generates arbitrary d-bus signatures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532094



--- Comment #3 from Igor Gnatenko  ---
Also, neither %doc or %license is specified. All files are in place, so you
should reference them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532094] Review Request: python-hs-dbus-signature - Hypothesis strategy that generates arbitrary d-bus signatures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532094



--- Comment #2 from Igor Gnatenko  ---
And tests are not running, you should add BuildRequires: python3-pytest and run
tests using py.test-%{python3_version} -v tests

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532094] Review Request: python-hs-dbus-signature - Hypothesis strategy that generates arbitrary d-bus signatures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532094



--- Comment #1 from Igor Gnatenko  ---
> %global sum Hypothesis strategy that generates arbitrary d-bus signatures
No need, put summary into Summary and use %{summary} later on.

> Source0:   
> https://github.com/stratis-storage/%{srcname}/archive/v%{version}.tar.gz
filename should be meaningful, also use shortcut...
Source0:   %{url}/archive/v%{version}/%{srcname}-%{version}.tar.gz

> BuildRequires: python3-devel
> Requires:  python3-hypothesis
Move those under respective package.
Also missing BuildRequires: python3-setuptools and I guess BuildRequires:
python3-hypothesis

> %{python3_sitelib}/*
Be more specific, do not use wildcard blindly.

> A Hypothesis Strategy for Generating Arbitrary DBus Signatures
Description should end with fullstop.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532094] Review Request: python-hs-dbus-signature - Hypothesis strategy that generates arbitrary d-bus signatures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532094

Ilya Gradina  changed:

   What|Removed |Added

 Blocks||1532084




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1532084
[Bug 1532084] Review Request: python-dbus-signature-pyparsing - A parser
for a dbus signature
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532084] Review Request: python-dbus-signature-pyparsing - A parser for a dbus signature

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532084

Ilya Gradina  changed:

   What|Removed |Added

 Depends On||1532094




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1532094
[Bug 1532094] Review Request: python-hs-dbus-signature - Hypothesis
strategy that generates arbitrary d-bus signatures
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532094] New: Review Request: python-hs-dbus-signature - Hypothesis strategy that generates arbitrary d-bus signatures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532094

Bug ID: 1532094
   Summary: Review Request: python-hs-dbus-signature - Hypothesis
strategy that generates arbitrary d-bus signatures
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ilya.grad...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://github.com/ilgrad/fedora-packages/raw/master/python/python-hs-dbus-signature.spec
SRPM URL:
https://github.com/ilgrad/fedora-packages/raw/master/python/python-hs-dbus-signature-0.05-1.fc27.src.rpm
Description: Hypothesis strategy that generates arbitrary d-bus signatures
Fedora Account System Username: ilgrad

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532084] New: Review Request: python-dbus-signature-pyparsing - A parser for a dbus signature

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532084

Bug ID: 1532084
   Summary: Review Request: python-dbus-signature-pyparsing - A
parser for a dbus signature
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ilya.grad...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://github.com/ilgrad/fedora-packages/raw/master/python/python-dbus-signature-pyparsing.spec
SRPM URL:
https://github.com/ilgrad/fedora-packages/raw/master/python/python-dbus-signature-pyparsing-0.03-1.fc27.src.rpm
Description: A D-Bus signature parser generated using the pyparsing library
Fedora Account System Username: ilgrad

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532082] New: Review Request: python-klusta - Spike detection and automatic clustering for spike sorting

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532082

Bug ID: 1532082
   Summary: Review Request: python-klusta - Spike detection and
automatic clustering for spike sorting
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sanjay.an...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://ankursinha.fedorapeople.org/python-klusta/python-klusta.spec
SRPM URL:
https://ankursinha.fedorapeople.org/python-klusta/python-klusta-3.0.16-1.fc27.src.rpm


Description:
klusta is an open source package for automatic spike sorting of multielectrode
neurophysiological recordings made with probes containing up to a few dozens of
sites.

klusta implements the following features:

- Kwik: An HDF5-based file format that stores the results of a spike sorting
  session.
- Spike detection (also known as SpikeDetekt): an algorithm designed for probes
  containing tens of channels, based on a flood-fill algorithm in the adjacency
graph formed by the recording sites in the probe.
- Automatic clustering (also known as Masked KlustaKwik): an automatic
  clustering algorithm designed for high-dimensional structured datasets.


Fedora Account System Username: ankursinha

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519081] Review Request: scribus-generator - Open source high-quality PDF template and mail-merge alternative

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519081



--- Comment #11 from Fedora Update System  ---
scribus-generator-2.5-3.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-eb8a149bab

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529012] Review Request: js-jsroot - JavaScript ROOT

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529012



--- Comment #10 from Fedora Update System  ---
js-jsroot-5.3.4-2.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-042415a1d7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1523302] Review Request: yuicompressor - YUI Compressor - The Yahoo JavaScript and CSS Compressor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1523302



--- Comment #11 from Fedora Update System  ---
yuicompressor-2.4.8-1.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-cbaf01d959

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1528186] Review Request: js-jquery-ui-touch-punch - Touch Event Support for jQuery UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1528186



--- Comment #9 from Fedora Update System  ---
js-jquery-ui-touch-punch-0.2.3-0.1.20141219git4bc0091.fc27 has been pushed to
the Fedora 27 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-ce7c385f0d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526847] Review Request: python-softlayer - SoftLayer API Python Client and library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526847

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526847] Review Request: python-softlayer - SoftLayer API Python Client and library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526847



--- Comment #10 from Fedora Update System  ---
python-softlayer-5.3.2-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-4ea3d2a1d2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421346] Review Request: extracturl - perl script for url extraction

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421346



--- Comment #6 from klaatu  ---
I've modified my spec file to include some of the suggestions here.

Spec file and latest RPM builds on f27:
https://klaatu.fedorapeople.org/extracturl/

Koji is giving me this error:

$ koji build  --scratch rawhide SRPMS/extracturl-1.6.1-3.fc27.src.rpm 
AuthError: unable to obtain a session

I've renewed my certs with `fedora-cert -n` but when I attempt to verify, I get
Python errors. I assume I'll file a bug against fedora-cert about that,
separately (unless it's an easy fix).

$ fedora-cert -v
Traceback (most recent call last):
  File "/usr/bin/fedora-cert", line 85, in 
main(opts)
  File "/usr/bin/fedora-cert", line 52, in main
if fedora_cert.certificate_expired():
  File "/usr/lib/python2.7/site-packages/fedora_cert/__init__.py", line 83, in
certificate_expired
if my_cert.has_expired():
AttributeError: 'NoneType' object has no attribute 'has_expired'

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519081] Review Request: scribus-generator - Open source high-quality PDF template and mail-merge alternative

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519081

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
scribus-generator-2.5-3.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-4e9aa991b4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529012] Review Request: js-jsroot - JavaScript ROOT

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529012



--- Comment #9 from Fedora Update System  ---
js-jsroot-5.3.4-2.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-0866d0dca0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1523302] Review Request: yuicompressor - YUI Compressor - The Yahoo JavaScript and CSS Compressor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1523302



--- Comment #10 from Fedora Update System  ---
yuicompressor-2.4.8-1.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-e2bf46e878

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1528186] Review Request: js-jquery-ui-touch-punch - Touch Event Support for jQuery UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1528186



--- Comment #8 from Fedora Update System  ---
js-jquery-ui-touch-punch-0.2.3-0.1.20141219git4bc0091.fc26 has been pushed to
the Fedora 26 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-7fe88794a5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1523302] Review Request: yuicompressor - YUI Compressor - The Yahoo JavaScript and CSS Compressor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1523302



--- Comment #9 from Fedora Update System  ---
yuicompressor-2.4.8-1.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-918403bb27

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529012] Review Request: js-jsroot - JavaScript ROOT

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529012

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
js-jsroot-5.3.4-2.el7 has been pushed to the Fedora EPEL 7 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-377ad5b245

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1523302] Review Request: yuicompressor - YUI Compressor - The Yahoo JavaScript and CSS Compressor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1523302

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
yuicompressor-2.4.8-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-35e5d63125

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1528186] Review Request: js-jquery-ui-touch-punch - Touch Event Support for jQuery UI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1528186

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
js-jquery-ui-touch-punch-0.2.3-0.1.20141219git4bc0091.el7 has been pushed to
the Fedora EPEL 7 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-90b3e1f4eb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531952] Review Request: rust-unsafe-any - Traits and implementations for unchecked downcasting

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531952

Ilya Gradina  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531952] Review Request: rust-unsafe-any - Traits and implementations for unchecked downcasting

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531952



--- Comment #1 from Ilya Gradina  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 4 files have unknown license. Detailed
 output of licensecheck in /home/ilgrad/Desktop/1531952-rust-unsafe-
 any/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: Spec use %global instead of %define unless justified.

= EXTRA items =

Generic:
[!]: Rpmlint is run on all installed 

[Bug 1249211] Review Request: cndoom - Conservative Doom engine for speedrunning competition

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1249211



--- Comment #5 from Ankur Sinha (FranciscoD)  ---
Two years later.. 

Adam, if you're still interested in this, I'd be happy to take the review over?

Cheers!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1089553] Review Request: python-sparqlwrapper - Wrapper for a remote SPARQL endpoint

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1089553

Ankur Sinha (FranciscoD)  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX
Last Closed||2018-01-07 17:48:52



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 827723] Review Request: gnuhealth - The free Health and Hospital Information System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=827723

Ankur Sinha (FranciscoD)  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
Last Closed||2018-01-07 17:47:28



--- Comment #22 from Ankur Sinha (FranciscoD)  ---
Closing as WONTFIX.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531951] Review Request: rust-traitobject - Unsafe helpers for working with raw trait objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531951



--- Comment #1 from Ilya Gradina  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 5 files have unknown license. Detailed
 output of licensecheck in /home/ilgrad/Desktop/1531951-rust-
 traitobject/licensecheck.txt
[-]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: Spec use %global instead of %define unless justified.

= EXTRA items =

Generic:
[x]: Rpmlint is run on all installed 

[Bug 1531951] Review Request: rust-traitobject - Unsafe helpers for working with raw trait objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531951

Ilya Gradina  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531954] Review Request: rust-siphasher - SipHash functions from rust-core < 1.13

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531954

Ilya Gradina  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531954] Review Request: rust-siphasher - SipHash functions from rust-core < 1.13

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531954



--- Comment #1 from Ilya Gradina  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0) or MIT (unspecified)", "Unknown or generated". 4
 files have unknown license. Detailed output of licensecheck in
 /home/ilgrad/Desktop/1531954-rust-siphasher/licensecheck.txt
[-]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: Spec use 

[Bug 1529555] Review Request: mint-themes - Mint themes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529555



--- Comment #11 from Fedora Update System  ---
cinnamon-3.6.7-3.fc26, cinnamon-themes-2017.06.20-4.fc26,
mint-themes-1.5.0-1.fc26, mint-themes-gtk3-3.18+17-1.fc26,
mint-y-theme-1.2.3-1.fc26, slick-greeter-1.1.4-1.fc26 has been pushed to the
Fedora 26 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529559] Review Request: mint-themes-gtk3 - Mint themes for GTK3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529559



--- Comment #12 from Fedora Update System  ---
cinnamon-3.6.7-3.fc26, cinnamon-themes-2017.06.20-4.fc26,
mint-themes-1.5.0-1.fc26, mint-themes-gtk3-3.18+17-1.fc26,
mint-y-theme-1.2.3-1.fc26, slick-greeter-1.1.4-1.fc26 has been pushed to the
Fedora 26 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411154] Review Request: mint-y-theme - The Mint-Y theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411154



--- Comment #11 from Fedora Update System  ---
cinnamon-3.6.7-3.fc26, cinnamon-themes-2017.06.20-4.fc26,
mint-themes-1.5.0-1.fc26, mint-themes-gtk3-3.18+17-1.fc26,
mint-y-theme-1.2.3-1.fc26, slick-greeter-1.1.4-1.fc26 has been pushed to the
Fedora 26 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529516] Un-retirement Review Request: mint-y-theme - The Mint-Y theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529516



--- Comment #10 from Fedora Update System  ---
cinnamon-3.6.7-3.fc26, cinnamon-themes-2017.06.20-4.fc26,
mint-themes-1.5.0-1.fc26, mint-themes-gtk3-3.18+17-1.fc26,
mint-y-theme-1.2.3-1.fc26, slick-greeter-1.1.4-1.fc26 has been pushed to the
Fedora 26 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531951] Review Request: rust-traitobject - Unsafe helpers for working with raw trait objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531951

Ilya Gradina  changed:

   What|Removed |Added

 CC||ilya.grad...@gmail.com
   Assignee|nob...@fedoraproject.org|ilya.grad...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531954] Review Request: rust-siphasher - SipHash functions from rust-core < 1.13

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531954

Ilya Gradina  changed:

   What|Removed |Added

 CC||ilya.grad...@gmail.com
   Assignee|nob...@fedoraproject.org|ilya.grad...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531952] Review Request: rust-unsafe-any - Traits and implementations for unchecked downcasting

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531952

Ilya Gradina  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1089553] Review Request: python-sparqlwrapper - Wrapper for a remote SPARQL endpoint

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1089553



--- Comment #15 from Dan Scott  ---
I think that's the best plan, Ankur.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531952] Review Request: rust-unsafe-any - Traits and implementations for unchecked downcasting

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531952

Ilya Gradina  changed:

   What|Removed |Added

 CC||ilya.grad...@gmail.com
   Assignee|nob...@fedoraproject.org|ilya.grad...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531950] Review Request: rust-modifier - Fluid chaining APIs for both mutable ownership types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531950



--- Comment #2 from Ilya Gradina  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 5 files have unknown license. Detailed
 output of licensecheck in /home/ilgrad/Desktop/1531950-rust-
 modifier/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: Spec use %global instead of %define unless justified.

= EXTRA items =

Generic:
[x]: Rpmlint is run on all installed packages.
 Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in 

[Bug 1531950] Review Request: rust-modifier - Fluid chaining APIs for both mutable ownership types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531950

Ilya Gradina  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532068] Review Request: stratisd - Daemon that manages block devices to create filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532068

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1531488




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1531488
[Bug 1531488] Stratis Storage
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519906] Review Request: CodeReview - Application to perform code review on local Git repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519906

Omar Berroteran  changed:

   What|Removed |Added

 CC||omarberroteran...@gmail.com



--- Comment #4 from Omar Berroteran  ---
To be recommended use lowercase filenames. 

Package Review
==


Issues:
===
- Sources used to build the package match the upstream source, as provided
  in the spec URL.
  Note: Upstream MD5sum check error, diff is in
  /home/lkf/1519906-CodeReview/diff.txt
  See: http://fedoraproject.org/wiki/Packaging/SourceURL


= MUST items =

C/C++:
[X]: Package does not contain kernel modules.
[X]: Package contains no static executables.
[X]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[X]: Package does not contain any libtool archives (.la)
[X]: Rpath absent or only used for internal libs.

Generic:
[X]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[X]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[X]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (unspecified)", "GPL (v2 or later)", "GPL (v3 or later)",
 "Unknown or generated". 88 files have unknown license. Detailed output
 of licensecheck in /home/lkf/1519906-CodeReview/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[!]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/.build-id(iputils,
 efivar-libs, gd, gc, libtomcrypt, gdbm, gpgme, rpm-plugin-selinux,
 python3-sqlalchemy, libmcpp, libnfsidmap, libimagequant, lua-libs,
 trousers, bzip2-libs, unzip, libdb-utils, xorg-x11-font-utils, gtk2,
 gtk3, OpenEXR-libs, libcom_err, pycryptopp, libseccomp, gnutls, npth,
 p11-kit, libyaml, iptables-libs, rpm-build, cryptsetup-libs, ykpers,
 libmodman, libselinux-utils, perl-Scalar-List-Utils, parted, zstd,
 mozjs17, mesa-libwayland-egl, ghostscript-x11, lua-posix, libwebp,
 libxslt, libpkgconf, libunistring, keyutils-libs, perl-Encode,
 elfutils, python2-cryptography, libgpg-error, perl-Digest-SHA, audit-
 libs-python3, nss-tools, perl-Data-Dumper, gawk, python2-rpm,
 libbasicobjects, c-ares, lua-lpeg, python2-cairo, python3-crypto,
 jansson, e2fsprogs-libs, libdwarf, librsvg2, lcms2, apr,
 libsss_nss_idmap, annobin, deltarpm, file-libs, grub2-tools, libxcb,
 trousers-lib, libyubikey, python3-pycurl, mokutil, zip,
 python3-gobject, m4, gdb-headless, vim-enhanced, libusbx,
 python3-psutil, compat-openssl10, qrencode-libs, libICE, drpm, libwmf-
 lite, createrepo_c-libs, libtasn1, python3-coverage, openssh, sqlite,
 http-parser, tar, diffstat, sudo, freetype, openssl, dhcp-client,
 libarchive, gcc, systemd-bootchart, dwz, python2-gobject, avahi-libs,
 pyliblzma, ncurses-libs, polkit, pigz, checkpolicy, libpsl,
 python2-tornado, python3-rpm, libini_config, openssh-clients, libuser,
 python3-tornado, perl-libs, libX11, systemtap-devel, kbd, graphviz,
 htop, boost-date-time, python3-cryptography, systemd, libacl, gts,
 libwayland-cursor, libnl3, libsecret, libSM, policycoreutils, pixman,
 libidn, libXxf86misc, grubby, libatomic_ops, python2-kerberos, pango,
 libss, libbabeltrace, systemtap-client, libpath_utils, dbus, polkit-
 libs, python3-systemd, perl-threads, perl-Params-Validate,
 libsss_certmap, python2-libcomps, rpm-plugin-systemd-inhibit, cairo,
 audit-libs, nss-sysinit, libgcc, ilmbase, gettext-libs, p11-kit-trust,
 libref_array, python2-krbv, python3-cffi, libstemmer, dbus-libs,
 syslinux-extlinux, cairo-gobject, fftw-libs-double, at-spi2-core,
 usermode, bash, glibc-common, linux-atm-libs, libedit, libidn2,
 enchant, libuuid, subversion-libs, atk, python3-cairo, openldap, isl,
 ImageMagick, harfbuzz, xz, libXcomposite, mtools, gtk-update-icon-
 cache, vim-minimal, python3-wrapt, pcre-cpp, python2-libs,
 python3-markupsafe, libcrypt, groff-base, libdatrie, python3-lazy-
 object-proxy, gdk-pixbuf2, dhcp-libs, python2-cccolutils, libtalloc,
 libldb, grep, guile, pcre-utf16, libepoxy, cronie-anacron, libserf,
 xfsprogs, man-db, libcroco, libgcrypt, grub2-tools-efi, ipcalc,
 libart_lgpl, dconf, xz-libs, dbus-glib, timedatex, perl-Package-Stash-
 XS, colord-libs, which, 

[Bug 1531925] Review Request: rust-quickersort - Fast sorting compatible with stable Rust

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531925



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-quickersort

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526847] Review Request: python-softlayer - SoftLayer API Python Client and library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526847



--- Comment #9 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-softlayer

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532068] Review Request: stratisd - Daemon that manages block devices to create filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532068
Bug 1532068 depends on bug 1532065, which changed state.

Bug 1532065 Summary: Review Request: rust-libudev - Rust wrapper for libudev
https://bugzilla.redhat.com/show_bug.cgi?id=1532065

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531950] Review Request: rust-modifier - Fluid chaining APIs for both mutable ownership types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531950

Ilya Gradina  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|ilya.grad...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532065] Review Request: rust-libudev - Rust wrapper for libudev

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532065

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-07 17:06:36



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531950] Review Request: rust-modifier - Fluid chaining APIs for both mutable ownership types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531950

Ilya Gradina  changed:

   What|Removed |Added

 CC||ilya.grad...@gmail.com



--- Comment #1 from Ilya Gradina  ---
I'll review it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531925] Review Request: rust-quickersort - Fast sorting compatible with stable Rust

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531925

Ilya Gradina  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|ilya.grad...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531925] Review Request: rust-quickersort - Fast sorting compatible with stable Rust

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531925



--- Comment #1 from Ilya Gradina  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "*No copyright* Apache (v2.0)". 16
 files have unknown license. Detailed output of licensecheck in
 /home/ilgrad/Desktop/1531925-rust-quickersort/licensecheck.txt
[-]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 194560 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: Spec use %global 

[Bug 1531925] Review Request: rust-quickersort - Fast sorting compatible with stable Rust

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531925

Ilya Gradina  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532064] Review Request: rust-libudev-sys - FFI bindings to libudev

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532064

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-07 16:55:23



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532065] Review Request: rust-libudev - Rust wrapper for libudev

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532065
Bug 1532065 depends on bug 1532064, which changed state.

Bug 1532064 Summary: Review Request: rust-libudev-sys - FFI bindings to libudev
https://bugzilla.redhat.com/show_bug.cgi?id=1532064

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 721112] Review Request: vmtk - The Vascular Modeling Toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=721112

Ankur Sinha (FranciscoD)  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX
Last Closed||2018-01-07 16:46:08



--- Comment #20 from Ankur Sinha (FranciscoD)  ---
I'm going to close this as WONTFIX. I'm not working on medical applications
anymore so I'm not the best person to maintain this package now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 505154] Tracker: Review Requests for Science and Technology related packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=505154
Bug 505154 depends on bug 721112, which changed state.

Bug 721112 Summary: Review Request: vmtk - The Vascular Modeling Toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=721112

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531925] Review Request: rust-quickersort - Fast sorting compatible with stable Rust

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531925

Ilya Gradina  changed:

   What|Removed |Added

 CC||ilya.grad...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1315852] Review Request: gstreamermm1 - C++ wrapper for GStreamer library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315852

Ankur Sinha (FranciscoD)  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX
Last Closed||2018-01-07 16:44:24



--- Comment #9 from Ankur Sinha (FranciscoD)  ---
I reckon this should've been closed as WONTFIX already.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1089553] Review Request: python-sparqlwrapper - Wrapper for a remote SPARQL endpoint

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1089553



--- Comment #14 from Ankur Sinha (FranciscoD)  ---
Hi all,

Should we close this as a WONTFIX so that someone else that wishes to package
this up can do so? We haven't made much progress in a while :)

Cheers!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532068] Review Request: stratisd - Daemon that manages block devices to create filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532068



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/stratisd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532065] Review Request: rust-libudev - Rust wrapper for libudev

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532065



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-libudev

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532064] Review Request: rust-libudev-sys - FFI bindings to libudev

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532064



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-libudev-sys

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508078] Review Request: golang-github-flynn-json5 - Go JSON5 decoder package based on encoding/ json

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508078



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-flynn-json5. You may commit to
the branch "f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519607] Review Request: gap-pkg-nautytracesinterface - GAP interface to nauty and Traces

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519607



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/gap-pkg-nautytracesinterface. You may commit
to the branch "f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1504512] Review Request: classifier - Organize files in your current directory, by classifying them into folders of music, pdfs, images, etc.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1504512

William Moreno  changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com
   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532068] Review Request: stratisd - Daemon that manages block devices to create filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532068

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- as this is a CLI crate that provides no API, it installs binaries correctly

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532068] Review Request: stratisd - Daemon that manages block devices to create filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532068

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532064] Review Request: rust-libudev-sys - FFI bindings to libudev

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532064

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532065] Review Request: rust-libudev - Rust wrapper for libudev

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532065

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532065] Review Request: rust-libudev - Rust wrapper for libudev

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532065

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532064] Review Request: rust-libudev-sys - FFI bindings to libudev

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532064

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532065] Review Request: rust-libudev - Rust wrapper for libudev

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532065

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1532068




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1532068
[Bug 1532068] Review Request: stratisd - Daemon that manages block devices
to create filesystems
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532068] Review Request: stratisd - Daemon that manages block devices to create filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532068

Igor Gnatenko  changed:

   What|Removed |Added

 Depends On||1532065




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1532065
[Bug 1532065] Review Request: rust-libudev - Rust wrapper for libudev
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532068] New: Review Request: stratisd - Daemon that manages block devices to create filesystems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532068

Bug ID: 1532068
   Summary: Review Request: stratisd - Daemon that manages block
devices to create filesystems
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust/stratisd.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/stratisd-0.1.4-1.fc28.src.rpm
Description: Daemon that manages block devices to create filesystems.
FAS account: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532064] Review Request: rust-libudev-sys - FFI bindings to libudev

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532064

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1532065




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1532065
[Bug 1532065] Review Request: rust-libudev - Rust wrapper for libudev
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532065] Review Request: rust-libudev - Rust wrapper for libudev

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532065

Igor Gnatenko  changed:

   What|Removed |Added

 Depends On||1532064




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1532064
[Bug 1532064] Review Request: rust-libudev-sys - FFI bindings to libudev
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532065] New: Review Request: rust-libudev - Rust wrapper for libudev

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532065

Bug ID: 1532065
   Summary: Review Request: rust-libudev - Rust wrapper for
libudev
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-libudev.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-libudev-0.2.0-1.fc28.src.rpm
Description: Rust wrapper for libudev.
FAS account: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532064] New: Review Request: rust-libudev-sys - FFI bindings to libudev

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532064

Bug ID: 1532064
   Summary: Review Request: rust-libudev-sys - FFI bindings to
libudev
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-libudev-sys.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust/rust-libudev-sys-0.1.4-1.fc28.src.rpm
Description: FFI bindings to libudev.
FAS account: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519906] Review Request: CodeReview - Application to perform code review on local Git repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519906



--- Comment #3 from William Moreno  ---
Spec URL:
https://raw.githubusercontent.com/FabriceSalvaire/CodeReview/master/distro/fedora/CodeReview.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/fabricesalvaire/code-review/fedora-27-x86_64/00683146-CodeReview/CodeReview-0.3.6-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520922] Review Request: extractpdfmark - Extract page mode and named destinations as PDFmark from PDF

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520922

Omar Berroteran  changed:

   What|Removed |Added

 CC||omarberroteran...@gmail.com



--- Comment #5 from Omar Berroteran  ---
Package Review
==
Must check owned files properties, there are many conflicts. 

= MUST items =

Generic:
[X]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[X]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "FSF All Permissive", "GPL (v3 or
 later)", "Unknown or generated". 79 files have unknown license.
 Detailed output of licensecheck in
 /home/lkf/1520922-extractpdfmark/licensecheck.txt
[X]: License file installed when any subpackage combination is installed.
[!]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/.build-id(iputils,
 efivar-libs, gd, gc, libtomcrypt, gdbm, gpgme, rpm-plugin-selinux,
 python3-sqlalchemy, libmcpp, libnfsidmap, libimagequant, lua-libs,
 trousers, bzip2-libs, unzip, libdb-utils, xorg-x11-font-utils, gtk2,
 gtk3, OpenEXR-libs, libcom_err, pycryptopp, libseccomp, gnutls, npth,
 p11-kit, libyaml, iptables-libs, rpm-build, cryptsetup-libs, ykpers,
 libmodman, libselinux-utils, perl-Scalar-List-Utils, parted, zstd,
 mozjs17, mesa-libwayland-egl, ghostscript-x11, lua-posix, libwebp,
 libxslt, libpkgconf, libunistring, keyutils-libs, perl-Encode,
 elfutils, python2-cryptography, libgpg-error, perl-Digest-SHA, audit-
 libs-python3, nss-tools, perl-Data-Dumper, gawk, python2-rpm,
 libbasicobjects, c-ares, lua-lpeg, python2-cairo, python3-crypto,
 jansson, e2fsprogs-libs, libdwarf, librsvg2, lcms2, apr,
 libsss_nss_idmap, annobin, deltarpm, file-libs, grub2-tools, libxcb,
 trousers-lib, libyubikey, python3-pycurl, mokutil, zip,
 python3-gobject, m4, gdb-headless, vim-enhanced, libusbx,
 python3-psutil, compat-openssl10, qrencode-libs, libICE, drpm, libwmf-
 lite, createrepo_c-libs, libtasn1, python3-coverage, openssh, sqlite,
 http-parser, tar, diffstat, sudo, freetype, openssl, dhcp-client,
 libarchive, gcc, systemd-bootchart, dwz, python2-gobject, avahi-libs,
 pyliblzma, ncurses-libs, polkit, pigz, checkpolicy, libpsl,
 python2-tornado, python3-rpm, libini_config, openssh-clients, libuser,
 python3-tornado, perl-libs, libX11, systemtap-devel, kbd, graphviz,
 htop, boost-date-time, python3-cryptography, systemd, libacl, gts,
 libwayland-cursor, libnl3, libsecret, libSM, policycoreutils, pixman,
 libidn, libXxf86misc, grubby, libatomic_ops, python2-kerberos, pango,
 libss, libbabeltrace, systemtap-client, libpath_utils, dbus, polkit-
 libs, python3-systemd, perl-threads, perl-Params-Validate,
 libsss_certmap, python2-libcomps, rpm-plugin-systemd-inhibit, cairo,
 audit-libs, nss-sysinit, libgcc, ilmbase, gettext-libs, p11-kit-trust,
 libref_array, python2-krbv, python3-cffi, libstemmer, dbus-libs,
 syslinux-extlinux, cairo-gobject, fftw-libs-double, at-spi2-core,
 usermode, bash, glibc-common, linux-atm-libs, libedit, libidn2,
 enchant, libuuid, subversion-libs, atk, python3-cairo, openldap, isl,
 ImageMagick, harfbuzz, xz, libXcomposite, mtools, gtk-update-icon-
 cache, vim-minimal, python3-wrapt, pcre-cpp, python2-libs,
 python3-markupsafe, libcrypt, groff-base, libdatrie, python3-lazy-
 object-proxy, gdk-pixbuf2, dhcp-libs, python2-cccolutils, libtalloc,
 libldb, grep, guile, pcre-utf16, libepoxy, cronie-anacron, libserf,
 xfsprogs, man-db, libcroco, libgcrypt, grub2-tools-efi, ipcalc,
 libart_lgpl, dconf, xz-libs, dbus-glib, timedatex, perl-Package-Stash-
 XS, colord-libs, which, boost-chrono, libcap, sssd-nfs-idmap, libdb,
 passwd, libgcab1, python3-bcrypt, desktop-file-utils, libXdamage,
 libsmartcols, rpm-libs, nano, libthai, createrepo_c, fakeroot,
 python2-markupsafe, libproxy, libpipeline, python2-sqlalchemy,
 iproute, python2-gpg, findutils, popt, python2-xpyb, fakeroot-libs,
 libsss_idmap, gobject-introspection, libpwquality, lua, boost-atomic,
 fontconfig, patchutils, krb5-workstation, python3-hawkey, os-prober,
 jbigkit-libs, python3-dbus, info, iproute-tc, systemd-libs, libjpeg-
 turbo, cpio, libpng, rest, lz4-libs, util-linux, libXfont, patch,
 krb5-libs, sqlite-libs, net-tools, python3-librepo, pkgconf, json-c,
 python3-libselinux, libwayland-client, sed, libipt, libsss_autofs,
 perl-threads-shared, glib-networking, kmod, initscripts, 

[Bug 1531955] Review Request: seqan2 - C++ library of efficient algorithms and data structures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531955

Alec Leamas  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||leamas.a...@gmail.com
   Assignee|nob...@fedoraproject.org|leamas.a...@gmail.com
 Whiteboard||mailto:nobody@fedoraproject
   ||.org



--- Comment #2 from Alec Leamas  ---
Taking this one

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532023] Review Request: ddupdate - A Dynamic DNS Updater

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532023

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Antonio Trande  ---
- Please, use %py3_build and py3_build macros in respective sections.

- Use %{_unitdir} always

- "%global debug_package %{nil}" is not needed when package is marked as
"noarch"

- Fix these SPEC/SRPM differences:

Diff spec file in url and in SRPM
-
--- /home/sagitter/1532023-ddupdate/srpm/ddupdate.spec2018-01-07
19:59:57.758161778 +0100
+++ /home/sagitter/1532023-ddupdate/srpm-unpacked/ddupdate.spec2018-01-07
12:19:55.0 +0100
@@ -57,5 +57,10 @@
 mkdir -p $RPM_BUILD_ROOT/usr/lib/systemd/system
 mv $RPM_BUILD_ROOT/lib/systemd/system/* $RPM_BUILD_ROOT/usr/lib/systemd/system
-rm -rf $RPM_BUILD_ROOT/usr/share/doc/ddupdate/*
+
+rm  -rf $RPM_BUILD_ROOT/usr/share/doc/ddupdate/*
+#rm  $RPM_BUILD_ROOT/usr/share/doc/ddupdate/LICENSE.txt
+#rm  $RPM_BUILD_ROOT/usr/share/doc/ddupdate/README.md
+#rm  $RPM_BUILD_ROOT/usr/share/doc/ddupdate/CONTRIBUTE.md
+#rm  $RPM_BUILD_ROOT/usr/share/doc/ddupdate/NEWS

 %pre

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[ ]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 38 files have
 unknown license. Detailed output of licensecheck in
 /home/sagitter/1532023-ddupdate/licensecheck.txt
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
 names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 3 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[ ]: Python eggs