[Bug 1119197] Review Request: gnushogi - Shogi (Japanese Chess) AI engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1119197



--- Comment #19 from Chen Chen  ---
SPEC updated as per your suggestion.

SPEC (Same link, you can read the change in gist):
https://gist.github.com/aflyhorse/dc5f37bd72008315ac323f66b88ead1e

SRPM:
https://www.lunes.faith/SRPMS/gnushogi-1.5-0.2.git5bb0b5b.fc26.src.rpm

Built Binaries (Same link):
https://copr.fedorainfracloud.org/coprs/aflyhorse/gnushogi


BTW, should I still upload to koji, or copr is OK?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #6 from Alexander Ploumistos  ---
I ran a side by side comparison of the 0.5.1-2 and 0.5.1-4 x86_64 builds and I
found the difference:

Processing files: molsketch-0.5.1-2.fc28.x86_64
[…]
Requires: libGL.so.1()(64bit) libQt5Core.so.5()(64bit)
libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.10)(64bit)
libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit)
libQt5Network.so.5(Qt_5)(64bit) libQt5PrintSupport.so.5()(64bit)
libQt5PrintSupport.so.5(Qt_5)(64bit) libQt5Svg.so.5()(64bit)
libQt5Svg.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit)
libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit)
libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit)
libc.so.6(GLIBC_2.4)(64bit) libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libm.so.6(GLIBC_2.2.5)(64bit)
libmolsketch-qt5.so.0()(64bit) libobabeliface-qt5.so.0()(64bit)
libopenbabel.so.5()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit)
libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.14)(64bit)
rtld(GNU_HASH)


Processing files: molsketch-0.5.1-4.fc28.x86_64
[…]
Requires: libGL.so.1()(64bit) libQt5Core.so.5()(64bit)
libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.10)(64bit)
libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit)
libQt5Network.so.5(Qt_5)(64bit) libQt5PrintSupport.so.5()(64bit)
libQt5PrintSupport.so.5(Qt_5)(64bit) libQt5Svg.so.5()(64bit)
libQt5Svg.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit)
libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit)
libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit)
libc.so.6(GLIBC_2.4)(64bit) libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libm.so.6(GLIBC_2.2.5)(64bit)
libmolsketch-qt5.so.0()(64bit) libopenbabel.so.5()(64bit)
libpthread.so.0()(64bit) libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit)
libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.14)(64bit)
rtld(GNU_HASH)

The 0.5.1-4 build is missing the requirement on
libobabeliface-qt5.so.0()(64bit). But how did this happen?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537403] New: Review Request: rust-intervaltree - Simple and generic implementation of an immutable interval tree

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537403

Bug ID: 1537403
   Summary: Review Request: rust-intervaltree - Simple and generic
implementation of an immutable interval tree
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-intervaltree.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-intervaltree-0.2.3-1.fc28.src.rpm
Description:
Simple and generic implementation of an immutable interval tree.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537398] New: Review Request: spectre-meltdown-checker - Spectre & Meltdown vulnerability/ mitigation checker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537398

Bug ID: 1537398
   Summary: Review Request: spectre-meltdown-checker - Spectre &
Meltdown vulnerability/mitigation checker
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: reto.gantenb...@linuxmonk.ch
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/ganto/spectre-meltdown-checker/spectre-meltdown-checker.git/tree/spectre-meltdown-checker.spec
SRPM URL:
https://linuxmonk.ch/packages/spectre-meltdown-checker/fedora/SRPMS/spectre-meltdown-checker-0.32-0.3.fc26.src.rpm
Description: Spectre & Meltdown vulnerability/mitigation checker for Linux
Fedora Account System Username: ganto

Hi. I created a RPM on COPR [1] for the spectre-meltdown-checker script which
is developed at [2]. It helps users to identify in what way their machine is
affected of the different Spectre and Meltdown security issues and how far they
are already mitigated on their machine. I assumed that maybe a larger part of
the Fedora users would be interested in such a check that's why I propose this
package here for inclusion into Fedora and EPEL.

[1]: https://copr.fedorainfracloud.org/coprs/ganto/spectre-meltdown-checker/
[2]: https://github.com/speed47/spectre-meltdown-checker

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1119197] Review Request: gnushogi - Shogi (Japanese Chess) AI engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1119197

Ben Rosser  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|rosser@gmail.com
  Flags||fedora-review?



--- Comment #18 from Ben Rosser  ---
Great! I have a few comments just based off of reading the spec.

> Version:1.5pre
> Release:1.git%{shortcommit}%{?dist}

Fedora's Versioning guidelines say that to indicate a pre-release version, you
should use the expected version number as the Version tag and put a leading
"0." in the release tag. That is, something like this:

Version: 1.5
Release: 0.1.git%{shortcommit}%{?dist}

Then if and when upstream releases 1.5, you can remove the trailing 0 and rpm
will see your package as an update.

https://fedoraproject.org/wiki/Packaging:Versioning#Prerelease_versions

> # The source of this package was pulled from upstreams's vcs.

While this is okay to do when necessary, it's always better to use an actual
SourceURL if possible. After poking around the Savannah cgit interface I
believe you can use the following SourceURL:

Source0:
https://git.savannah.gnu.org/cgit/gnushogi.git/snapshot/gnushogi-%{commit}.tar.gz

In which case, you'll need to modify the "setup" macro appropriately:

%setup -qn %{name}-%{commit}

And then you need to add the invocation of autogen.sh to the spec as well,
along with the necessary BuildRequires on autoconf/automake/texinfo as well.

> make %{?_smp_mflags}

While this works fine, it is recommended to replace this with the relatively
new "%make_build" macro.

> %{__rm} -f %{buildroot}%{_infodir}/dir

This is frowned upon. You should just use "rm":

"Macro forms of system executables SHOULD NOT be used except when there is a
need to allow the location of those executables to be configurable. For
example, rm should be used in preference to %{__rm}, but %{__python} is
acceptable."

https://fedoraproject.org/wiki/Packaging:Guidelines#Macros

> Requires:   ncurses-libs

This explicit dependency is probably unnecessary. RPM can generally figure out
C/C++ library dependencies. You can check to make sure by running "rpm -qpR"
over a spec to see the dependencies, like so:

[bjr@rannoch Downloads]$ rpm -qpR
/var/lib/mock/fedora-rawhide-x86_64/result/gnushogi-1.5pre-1.git5bb0b5b.fc28.x86_64.rpm
 
/bin/sh
/bin/sh
libc.so.6()(64bit)
libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.3.4)(64bit)
libc.so.6(GLIBC_2.4)(64bit)
libc.so.6(GLIBC_2.7)(64bit)
libm.so.6()(64bit)
libm.so.6(GLIBC_2.2.5)(64bit)
libncurses.so.6()(64bit)
...

So, rpm was able to find the libncurses dependency on it's own.

In addition, according to
https://fedoraproject.org/wiki/Packaging:Scriptlets#Texinfo you need to add the
Requires for "info" for the post and preun triggers.

> Requires(post): info
> Requires(preun): info

You might want to consider adding a weak dependency on xboard. You can read
more about them here: https://fedoraproject.org/wiki/Packaging:WeakDependencies

Otherwise the spec looks fine to me. I'll do a more detailed run through over
the next few days and let you know if I find anything else.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536984] Review Request: sequeler - SQL Client built in Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536984

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
Package approved.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (2 clause)", "GPL (v2 or later)", "GPL (v3 or later)",
 "Unknown or generated". 246 files have unknown license. Detailed
 output of licensecheck in /home/bob/packaging/review/sequeler/review-
 sequeler/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/locale/mo,
 /usr/share/locale/mo/LC_MESSAGES
[x]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/locale/mo/LC_MESSAGES, /usr/share/locale/mo
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if 

[Bug 1536882] Review Request: harvey - Color contrast checker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536882

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
Package approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
 generated". 219 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/harvey/review-
 harvey/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/icons/hicolor/64x64@2/apps,
 /usr/share/locale/mo/LC_MESSAGES,
 /usr/share/icons/hicolor/48x48@2/apps,
 /usr/share/icons/hicolor/128x128@2/apps, /usr/share/locale/mo,
 /usr/share/icons/hicolor/64x64@2, /usr/share/icons/hicolor/48x48@2,
 /usr/share/icons/hicolor/128x128@2
[x]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/icons/hicolor/64x64@2, /usr/share/icons/hicolor/48x48@2,
 /usr/share/icons/hicolor/64x64@2/apps,
 /usr/share/locale/mo/LC_MESSAGES, /usr/share/icons/hicolor/128x128@2,
 /usr/share/icons/hicolor/48x48@2/apps, /usr/share/icons/hicolor,
 /usr/share/icons/hicolor/128x128@2/apps, /usr/share/locale/mo
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

[Bug 1507103] Review Request: kronosnet - VPNs on steroids

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #9 from digimer  ---
This is a rebuild using bandini's .spec and the SRPM source from master.

f26:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24381668

f27:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24381821

rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24381926

epel7:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24382047

New .spec and srpm:
https://www.alteeve.com/an-repo/files/packages/kronosnet.spec.1.0-2
https://www.alteeve.com/an-repo/files/packages/kronosnet-1.0-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536873] Review Request: dippi - Calculate display info like DPI and aspect ratio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536873

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
Package approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
 generated". 232 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/dippi/review-
 dippi/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/icons/hicolor/64x64@2/apps,
 /usr/share/icons/hicolor/48x48@2/apps,
 /usr/share/icons/hicolor/128x128@2/apps,
 /usr/share/icons/hicolor/24x24@2, /usr/share/icons/hicolor/32x32@2,
 /usr/share/icons/hicolor/32x32@2/apps,
 /usr/share/icons/hicolor/16x16@2/apps, /usr/share/locale/mo,
 /usr/share/icons/hicolor/24x24@2/apps,
 /usr/share/icons/hicolor/16x16@2, /usr/share/locale/mo/LC_MESSAGES,
 /usr/share/icons/hicolor/64x64@2, /usr/share/icons/hicolor/48x48@2,
 /usr/share/icons/hicolor/128x128@2
[x]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/icons/hicolor/64x64@2, /usr/share/icons/hicolor/128x128@2,
 /usr/share/icons/hicolor/48x48@2,
 /usr/share/icons/hicolor/128x128@2/apps,
 /usr/share/icons/hicolor/24x24@2,
 /usr/share/icons/hicolor/64x64@2/apps,
 /usr/share/icons/hicolor/32x32@2, /usr/share/locale/mo/LC_MESSAGES,
 /usr/share/icons/hicolor/32x32@2/apps,
 /usr/share/icons/hicolor/24x24@2/apps,
 /usr/share/icons/hicolor/48x48@2/apps, /usr/share/icons/hicolor,
 /usr/share/icons/hicolor/16x16@2/apps,
 /usr/share/icons/hicolor/16x16@2, /usr/share/locale/mo
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install 

[Bug 972346] Review Request: ros-common_msgs - Common ROS Messages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=972346



--- Comment #11 from Rich Mattes  ---
Hi Tim and Ankur,

I don't have nearly the time it would take to complete this packaging effort
anymore.  I was actually considering retiring the few ROS 1 packages I did get
through the review process.  If Till wants to take them over to move some of
his work into Fedora proper, I would be happy to re-assign them

Rich

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536159] Review Request: openvswitch-ovn-kubernetes - Wedge between kubernetes and OVN

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536159



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/openvswitch-ovn-kubernetes

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536159] Review Request: openvswitch-ovn-kubernetes - Wedge between kubernetes and OVN

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536159

Phil Cameron  changed:

   What|Removed |Added

   Assignee|pcame...@redhat.com |admil...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536159] Review Request: openvswitch-ovn-kubernetes - Wedge between kubernetes and OVN

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536159

Phil Cameron  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|pcame...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534787] Review Request: python-fastavro - Fast Avro for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534787



--- Comment #8 from Fedora Update System  ---
python-fastavro-0.17.3-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-38b8e0f3ab

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534787] Review Request: python-fastavro - Fast Avro for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534787

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534787] Review Request: python-fastavro - Fast Avro for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534787



--- Comment #7 from Fedora Update System  ---
python-fastavro-0.17.3-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-3a013f7342

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531151] Review Request: python3-docker - A Python library for the Docker Engine API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531151

Carl George  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2018-01-22 16:43:01



--- Comment #11 from Carl George  ---
Thanks Robert!

https://bodhi.fedoraproject.org/updates/python3-docker-2.6.1-1.el7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534050] Review Request: python-nixio - Python bindings for NIX

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534050



--- Comment #10 from Fedora Update System  ---
python-nixio-1.4.3-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-2bce70970a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534050] Review Request: python-nixio - Python bindings for NIX

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534050

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534050] Review Request: python-nixio - Python bindings for NIX

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534050



--- Comment #9 from Fedora Update System  ---
python-nixio-1.4.3-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-3381d175d6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 972346] Review Request: ros-common_msgs - Common ROS Messages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=972346



--- Comment #10 from Ankur Sinha (FranciscoD)  ---
Hi Tim!

That's lovely. I'll hop on to the robotics ML and get in touch.

Cheers!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #5 from Alexander Ploumistos  ---
$ diff 0.5.1-2/molsketch.spec 0.5.1-4/molsketch.spec 
3c3
< Release:2%{?dist}
---
> Release:4%{?dist}
5c5
< License:GPLv2
---
> License:GPLv2+
16d15
< BuildRequires:  qca
23c22
< Requires:   openbabel
---
> Requires:   openbabel%{?_isa}
36c35
< License:GPLv2
---
> License:GPLv2+
47,48c46,47
< Requires:   lib%{name}-qt5
< #Requires:   libqt5-qttools
---
> Requires:   %{name}%{?_isa} = %{version}-%{release}
> Requires:   qt5-qttools-devel
59c58
< #%setup -q -n Molsketch-%{version}
---
> #%%setup -q -n Molsketch-%%{version}
61c60
< #%setup -q -n Molsketch-latest
---
> #%%setup -q -n Molsketch-latest
68c67
< %{qmake_qt5} "MSK_PREFIX=%{_prefix}" "MSK_INSTALL_PREFIX=%{_prefix}"
"MSK_INSTALL_DOCS=%{_docdir}/%{name}" ./Molsketch.pro
---
> %{qmake_qt5} "MSK_PREFIX=%{_prefix}" "MSK_INSTALL_PREFIX=%{_prefix}" 
> "MSK_INSTALL_DOCS=%{_docdir}/%{name}" "MSK_INSTALL_LIBS=%{_libdir}" 
> "MSK_INSTALL_INCLUDES=%{_includedir}/lib%{name}" ./Molsketch.pro
73c72
< make INSTALL_ROOT="%{buildroot}" install
---
> %make_install INSTALL_ROOT="%{buildroot}"
81,82c80
< %post
< /sbin/ldconfig
---
> %post -p /sbin/ldconfig
85,86c83
< %postun
< /sbin/ldconfig
---
> %postun -p /sbin/ldconfig
91c88
< %doc CHANGELOG INSTALL
---
> %doc CHANGELOG
93c90
< %{_libdir}/lib*.so*
---
> %{_libdir}/lib*.so.*
97c94,95
< %{_datadir}/icons/hicolor/scalable/*
---
> %{_datadir}/icons/hicolor/scalable/mimetypes/application-x-%{name}.svg
> %{_datadir}/icons/hicolor/scalable/apps/%{name}.svg
101a100
> %license COPYING
106c105
< %{_includedir}/%{name}
---
> %{_includedir}/lib%{name}
111a111,116
> * Mon Jan 22 2018 Alexander Ploumistos  - 0.5.1-4
> - More cleaning up 
> 
> * Mon Jan 22 2018 Alexander Ploumistos  - 0.5.1-3
> - Clean up spec file according to remarks by Antonio Trande (rhbz#1536852)
> 
128c133
< - Fix %post & %postun scriptlets
---
> - Fix post & postun scriptlets


Could it be the %{_includedir}/lib%{name} change? Maybe change it to
%{_includedir}/%{name}?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1488214] Review Request: deepin-manual - Deepin User Manual

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1488214



--- Comment #3 from Robert-André Mauchin  ---
I think the best course of action is to bundle the required node packages as a
Source1, they are only needed at build time. Here's how I generated a
node_modules.tar.gz:

# git clone https://github.com/linuxdeepin/deepin-manual
# cd deepin-manual
# git checkout %%version
# pushd src/web/
# npm install
# popd
# tar -czvf node_modules.tar.gz src/web/node_modules
Source1:node_modules.tar.gz



Also version 2 now depends on qcef: https://github.com/linuxdeepin/qcef
In order to speed things up, I have prepared a SPEC for you, you just need to
review it and submit it as your own if you're ok with it. It is available here:
https://eclipseo.fedorapeople.org/deepin/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536159] Review Request: openvswitch-ovn-kubernetes - Wedge between kubernetes and OVN

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536159



--- Comment #4 from Phil Cameron  ---
admil...@redhat.com
Thanks for doing the review. I deleted the "ExclusiveArch" line and updated the
files. Now its on to requesting a repo...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #4 from Alexander Ploumistos  ---
(In reply to Antonio Trande from comment #3)
> - Error: 
>  Problem: conflicting requests
>   - nothing provides libmolsketch-qt5 needed by
> molsketch-devel-0.5.1-3.fc28.x86_64
> 
> Remove 
> 
> 'Requires: lib%{name}-qt5'

Done.

> >The OpenSUSE spec file also listed libqt5-qttools as a requirement for the 
> >devel >package, but we don't have that in Fedora. Do you know what that is 
> >about?
> 
> Use 'qt5-qttools-devel'.

Done.


> - Diff spec file in url and in SRPM

These should be the same now:

Spec URL: https://alexpl.fedorapeople.org/packages/Molsketch/molsketch.spec
SRPM URL:
https://alexpl.fedorapeople.org/packages/Molsketch/molsketch-0.5.1-4.fc28.src.rpm

koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24376144

Something that changed since 0.5.1-2 build is disabling the extra features,
probably during the build phase, but I can't figure out what that might have
been.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536780] Review Request: swift-lang - Apple' s Swift Programming Language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536780



--- Comment #6 from Ron Olson  ---
I figured out how to exclude LLDB from the rpm, but running the REPL brings up
this message:

***  You are running Swift's integrated REPL,  ***
***  intended for compiler and stdlib  ***
***  development and testing purposes only.***
***  The full REPL is built as part of LLDB.   ***
***  Type ':help' for assistance.  ***

I'm testing the ramifications of this right now; will update the ticket
accordingly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531151] Review Request: python3-docker - A Python library for the Docker Engine API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531151



--- Comment #10 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python3-docker. You may commit to the branch
"epel7" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531151] Review Request: python3-docker - A Python library for the Docker Engine API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531151

Carl George  changed:

   What|Removed |Added

  Component|Package Review  |Package Review
Version|rawhide |epel7
Product|Fedora  |Fedora EPEL



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #3 from Antonio Trande  ---
- Error: 
 Problem: conflicting requests
  - nothing provides libmolsketch-qt5 needed by
molsketch-devel-0.5.1-3.fc28.x86_64

Remove 

'Requires: lib%{name}-qt5'

- 
>The OpenSUSE spec file also listed libqt5-qttools as a requirement for the 
>devel >package, but we don't have that in Fedora. Do you know what that is 
>about?

Use 'qt5-qttools-devel'.

- Diff spec file in url and in SRPM
-
--- /home/sagitter/1536852-molsketch/srpm/molsketch.spec2018-01-22
18:33:42.450467184 +0100
+++ /home/sagitter/1536852-molsketch/srpm-unpacked/molsketch.spec2018-01-22
13:12:35.0 +0100
@@ -130,5 +130,5 @@

 * Wed Nov 01 2017 Alexander Ploumistos  - 0.5.0-6
-- Fix post & postun scriptlets
+- Fix %post & %postun scriptlets

 * Wed Nov 01 2017 Alexander Ploumistos  - 0.5.0-5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536780] Review Request: swift-lang - Apple' s Swift Programming Language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536780



--- Comment #5 from Ron Olson  ---
Figured out the issue with the Koji job dying: One of the sub-projects uses
rsync instead of cp and it wasn't listed in the BRs and apparently rsync is not
installed by default...?

Koji scratch build succeeded:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24373311

Latest spec and srpm available at:
https://tachoknight.fedorapeople.org/swift-lang/

* I added rsync as a BR
* Moved all the BRs to separate lines; right away I found this useful so I see
why it's a good idea.

I'm going to see about minimizing the files installed in the package,
specifically lldb as that's explicitly included. This may require another
upstream modification; they've been amenable to all of my pull requests so far.
:)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534268] Review Request: erlang-jose - JSON Object Signing and Encryption (JOSE) for Erlang and Elixir

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534268

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534188



--- Comment #11 from Fedora Update System  ---
ejabberd-18.01-2.fc27 erlang-base64url-1.0-1.fc27
erlang-cache_tab-1.0.12-1.fc27 erlang-esip-1.0.21-1.fc27
erlang-ezlib-1.0.3-1.fc27 erlang-fast_tls-1.0.20-1.fc27
erlang-fast_xml-1.1.28-1.fc27 erlang-fast_yaml-1.0.12-1.fc27
erlang-fs-4.1-2.fc27 erlang-jose-1.8.4-1.fc27 erlang-stun-1.0.20-1.fc27
erlang-xmpp-1.1.19-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8d1658ffde

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534188

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534268] Review Request: erlang-jose - JSON Object Signing and Encryption (JOSE) for Erlang and Elixir

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534268



--- Comment #7 from Fedora Update System  ---
ejabberd-18.01-2.fc27 erlang-base64url-1.0-1.fc27
erlang-cache_tab-1.0.12-1.fc27 erlang-esip-1.0.21-1.fc27
erlang-ezlib-1.0.3-1.fc27 erlang-fast_tls-1.0.20-1.fc27
erlang-fast_xml-1.1.28-1.fc27 erlang-fast_yaml-1.0.12-1.fc27
erlang-fs-4.1-2.fc27 erlang-jose-1.8.4-1.fc27 erlang-stun-1.0.20-1.fc27
erlang-xmpp-1.1.19-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8d1658ffde

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534261] Review Request: erlang-base64url - URL safe base64-compatible codec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534261



--- Comment #7 from Fedora Update System  ---
ejabberd-18.01-2.fc27 erlang-base64url-1.0-1.fc27
erlang-cache_tab-1.0.12-1.fc27 erlang-esip-1.0.21-1.fc27
erlang-ezlib-1.0.3-1.fc27 erlang-fast_tls-1.0.20-1.fc27
erlang-fast_xml-1.1.28-1.fc27 erlang-fast_yaml-1.0.12-1.fc27
erlang-fs-4.1-2.fc27 erlang-jose-1.8.4-1.fc27 erlang-stun-1.0.20-1.fc27
erlang-xmpp-1.1.19-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8d1658ffde

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534261] Review Request: erlang-base64url - URL safe base64-compatible codec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534261

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531151] Review Request: python3-docker - A Python library for the Docker Engine API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531151

Robert-André Mauchin  changed:

   What|Removed |Added

  Flags|needinfo?(zebo...@gmail.com |
   |)   |



--- Comment #9 from Robert-André Mauchin  ---
Still ok for me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536159] Review Request: openvswitch-ovn-kubernetes - Wedge between kubernetes and OVN

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536159

Adam Miller  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #3 from Adam Miller  ---
ackage Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "CDDL", "CC by (v4.0)", "CC by-sa (v4.0)",
 "*No copyright* BSD (2 clause)", "Unknown or generated", "MIT/X11 (BSD
 like)", "*No copyright* Apache", "*No copyright* BSD (unspecified)",
 "*No copyright* LGPL", "*No copyright* MPL (v2.0)", "ISC", "CDDL
 (v1.0)", "MIT/X11 (BSD like) BSD (2 clause)", "MIT/X11 (BSD like) BSD
 (3 clause)", "BSD (3 clause)", "BSD (2 clause)", "GPL (v3)", "LGPL
 (v3)", "*No copyright* Apache (v2.0)". 5278 files have unknown
 license. Detailed output of licensecheck in
 /home/admiller/reviews/1536159-openvswitch-ovn-
 kubernetes/licensecheck.txt
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /etc/openvswitch
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 51200 bytes in 7 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream 

[Bug 1531151] Review Request: python3-docker - A Python library for the Docker Engine API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531151

Carl George  changed:

   What|Removed |Added

  Flags||needinfo?(zebo...@gmail.com
   ||)



--- Comment #8 from Carl George  ---
I decided that the safest path forward is to use the previous upstream version
(2.6.1) from before they bumped the minimum requests requirement.  I was also
able to isolate the pytest issue and get the test suite to run.

Spec URL: https://carlwgeorge.fedorapeople.org/python3-docker.spec
SRPM URL:
https://carlwgeorge.fedorapeople.org/python3-docker-2.6.1-1.el7.centos.src.rpm

If at some point python34-requests is updated then I'll revist updating this
package to it's latest version.  I know you already approved this, but I'll
wait a bit in case you want to look over the latest spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #2 from Alexander Ploumistos  ---
Hello Antonio and thanks for taking this review request.


(In reply to Antonio Trande from comment #1)
> - Are you sure that 'qca' (or qca-qt5?) is required for building?

Not really and neither was upstream. I commented it out, didn't notice any
problems. The OpenSUSE spec file also listed libqt5-qttools as a requirement
for the devel package, but we don't have that in Fedora. Do you know what that
is about?


> - Make arch-specific the 'openbabel' explicit request:
> Requires:  openbabel%{?_isa}

Changed it, but why is that needed?


> - devel subpackage requires the main package (that contains libmolsketch.so):
> Requires: %{name}%{?_isa} = %{version}-%{release}

Fixed.


> - Remove that macros in comments or use %% for disabling them.

Did not know about the % escaping, did that.


> - Use %make_install in the %install section

Fixed.


> - Remove INSTALL as documentation

Removed.


> - %{_libdir}/lib*.so* installs unversioned libraries too. Change it with
>   %{_libdir}/lib*.so.*

Fixed. Can you point me to any good resource regarding versioned-unversioned
libraries?


> - Regarding your question on devel mailing list, there could be a problem
> with some architectures (like s390x) about how to set correctly the
> libraries directory.
> In particular, 
> 
> obabeliface/obabeliface.pro
> libmolsketch/libmolsketch.pro
> 
> contain a "DESTDIR = ../lib" line. To fix try to add the option
> ""MSK_INSTALL_LIBS=%{_libdir}" to qmake's line.

Thanks, it builds now.


> - Set MSK_INSTALL_INCLUDES to %{_includedir}/lib%{name}

I also changed

%files devel
%{_includedir}/%{name}

to

%files devel
%{_includedir}/lib%{name}

because the build failed complaining about a missing file.


> - /usr/share/icons/hicolor/scalable/mimetypes must not be owned by this
> package.

I declared both images in the %files section, perhaps I should just have gone a
level below %{_datadir}/icons/hicolor/scalable/ and used the wildcard there.


> - doc is a stand-alone package, it must provide an own license file.

Added.


> - Most files are licensed under GPLv2+ license; you can use it as License
> file i guess.

Changed to GPLv2+.


Spec URL: https://alexpl.fedorapeople.org/packages/Molsketch/molsketch.spec
SRPM URL:
https://alexpl.fedorapeople.org/packages/Molsketch/molsketch-0.5.1-3.fc28.src.rpm
koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24370202


There is one serious regression now. When the program starts, I can see that it
is not using OpenBabel, in the bottom right corner it shows everything with a
minus (OpenBabel, InChI, gen2d). Can you tell where I've messed up?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536159] Review Request: openvswitch-ovn-kubernetes - Wedge between kubernetes and OVN

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536159



--- Comment #2 from Phil Cameron  ---
RE comment #1
I have access to x86_64 and that is were the work was done. This connects
Openshift/kubernetes and OVN so it will be supported on all common
environments.
I will delete the "ExclusiveArch" line.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536827] Review Request: rust-pest_derive - Pest's derive macro

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536827

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-22 09:51:35



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536725] Review Request: rust-horrorshow - Templating library written in rust macros

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536725

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-22 09:32:18



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536724] Review Request: rust-sourceview - Rust bindings for the GtkSourceView 3 library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536724

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-22 09:32:14



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536077] Review Request: jackson-bom - Bill of materials POM for Jackson projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536077



--- Comment #8 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/jackson-bom

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534787] Review Request: python-fastavro - Fast Avro for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534787



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-fastavro

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534050] Review Request: python-nixio - Python bindings for NIX

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534050



--- Comment #8 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-nixio

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536827] Review Request: rust-pest_derive - Pest's derive macro

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536827



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-pest_derive

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536725] Review Request: rust-horrorshow - Templating library written in rust macros

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536725



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-horrorshow

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536077] Review Request: jackson-bom - Bill of materials POM for Jackson projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536077



--- Comment #7 from Mat Booth  ---
(In reply to Robert-André Mauchin from comment #6)
> (In reply to Mat Booth from comment #4)
> > Aha, my mistake. In that case, thanks.
> > 
> > When I asked Zodbot about you, it gave me this user account:
> > 
> > https://admin.fedoraproject.org/accounts/user/view/zebob
> > 
> > Different person?
> 
> Huh, apparently it's an old account which I had forgotten. That email
> doesn't exist anymore and I no longer work with GNOME.

Oh well, I blame Zodbot for misleading me with inactive accounts in search
results ;-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536724] Review Request: rust-sourceview - Rust bindings for the GtkSourceView 3 library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536724



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-sourceview

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536077] Review Request: jackson-bom - Bill of materials POM for Jackson projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536077



--- Comment #6 from Robert-André Mauchin  ---
(In reply to Mat Booth from comment #4)
> Aha, my mistake. In that case, thanks.
> 
> When I asked Zodbot about you, it gave me this user account:
> 
> https://admin.fedoraproject.org/accounts/user/view/zebob
> 
> Different person?

Huh, apparently it's an old account which I had forgotten. That email doesn't
exist anymore and I no longer work with GNOME.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536077] Review Request: jackson-bom - Bill of materials POM for Jackson projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536077



--- Comment #5 from Mat Booth  ---
Branch requested: https://pagure.io/releng/fedora-scm-requests/issue/4242

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 616881] Review Request: extracc - Package to use C++ pojects with Cruise Control

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=616881

Christophe LACOMBE  changed:

   What|Removed |Added

  Flags|needinfo?(clacombe@amadeus. |
   |com)|



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536077] Review Request: jackson-bom - Bill of materials POM for Jackson projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536077



--- Comment #4 from Mat Booth  ---
Aha, my mistake. In that case, thanks.

When I asked Zodbot about you, it gave me this user account:

https://admin.fedoraproject.org/accounts/user/view/zebob

Different person?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536077] Review Request: jackson-bom - Bill of materials POM for Jackson projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536077

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
I am member of the packager group.

https://admin.fedoraproject.org/accounts/user/view/eclipseo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537071] Review Request: perl-curry - Create automatic curried method call closures for any class or object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537071

Jitka Plesnikova  changed:

   What|Removed |Added

 Blocks||1536768




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1536768
[Bug 1536768] perl-DBIx-Class-Schema-Loader-0.07048 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537071] New: Review Request: perl-curry - Create automatic curried method call closures for any class or object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537071

Bug ID: 1537071
   Summary: Review Request: perl-curry - Create automatic curried
method call closures for any class or object
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jples...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://jplesnik.fedorapeople.org/perl-curry/perl-curry.spec
SRPM URL:
https://jplesnik.fedorapeople.org/perl-curry/perl-curry-1.001000-1.fc28.src.rpm

Description:
This modules creates automatic curried method call closures for any class
or object.

Fedora Account System Username: jples...@redhat.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526768] Review Request: clickhouse - a distributed column-oriented DBMS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526768

Michael Cullen  changed:

   What|Removed |Added

  Flags|needinfo?(michael@cullen-on |
   |line.com)   |



--- Comment #7 from Michael Cullen  ---
Looking much better in terms of comments!

You might want to consider packaging cctz from that Git release (it doesn't
seem to be in Fedora at all right now) but it isn't something I'm going to moan
about too much.

Just one thing about the bundling though: the guidelines [0] require any
bundled libraries to be called out in the spec file as provides - something
like:

Provides: bundled(cctz) = 20171031.4f9776a

should do the trick. 

[0]
https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication_of_system_libraries
[1] https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450590] Review Request: watchman - a file watching service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450590

Laurent Rineau  changed:

   What|Removed |Added

 CC||laurent.rineau__fedora@norm
   ||alesup.org



--- Comment #20 from Laurent Rineau  ---
This review seems stalled, and now that Git version 2.16 has a support for
watchman (to speed up operations on big working directories), the inclusion of
watchman in Fedora is even more interesting.

I cannot download https://mattysmith.co.uk/watchman/watchman.spec

James Hogarth, do you have the last version of the spec file?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525900] Review Request: js-html5shiv - Enable use of HTML5 sectioning elements in legacy browsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525900

Xavier Bachelot  changed:

   What|Removed |Added

 Depends On||1530733




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1530733
[Bug 1530733] nodejs-grunt-contrib copy not available for F26, EL7 and EL6
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525900] Review Request: js-html5shiv - Enable use of HTML5 sectioning elements in legacy browsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525900



--- Comment #8 from Fedora Update System  ---
js-html5shiv-3.7.3-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-ba20010674

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536077] Review Request: jackson-bom - Bill of materials POM for Jackson projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536077

Mat Booth  changed:

   What|Removed |Added

   Assignee|zebo...@gmail.com   |nob...@fedoraproject.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536077] Review Request: jackson-bom - Bill of materials POM for Jackson projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536077

Mat Booth  changed:

   What|Removed |Added

 Status|POST|NEW
  Flags|fedora-review+  |fedora-review?



--- Comment #2 from Mat Booth  ---
Thanks for the feedback, but I don't think you can approve reviews without
being a member of the "packager" group

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536565] Review Request: ntp-refclock - Drivers for hardware reference clocks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536565



--- Comment #2 from Miroslav Lichvar  ---
Thanks for the review.

I've asked on the packaging list about the version/release:
https://lists.fedoraproject.org/archives/list/packag...@lists.fedoraproject.org/thread/4YUJLK34CW6XSL35IWDJJURFQSZYCYST/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532541] Review Request: python2-django1.11 - Version 1.11 LTS of Django, a high-level Python Web framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532541



--- Comment #10 from Petr Viktorin  ---
Waiting for repo creation, which failed somehow:
https://pagure.io/releng/fedora-scm-requests/issue/4231

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536990] Review Request: openssl-ibmpkcs11 - IBM OpenSSL PKCS#11 engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536990



--- Comment #2 from IBM Bug Proxy  ---
any update here?
This should really make Fedora 19 ... to make RHEL xx based on F19
Thx in advance

*** Bug 139187 has been marked as a duplicate of this bug. ***

--- Comment From ebarre...@br.ibm.com 2017-01-31 06:38 EDT---
Hi Dan and Hans-Georg,

the openssl-ibmpkcs11 is since last semester under my responsibility as well as
opencryptoki.

I'm working on make it stable, whenever I have a break from opencryptoki, as
there are many issues on it.

I was not aware of this Fedora requirement and I will make sure as soon as it
gets stable that I will implement it.

I don't have a specific date yet for this to be done.

If you need more information or requests just let me know.

Thanks,
Eduardo

--- Comment From m...@de.ibm.com 2017-12-11 06:03 EDT---
There is a new version of  OpenSSL-ibmpkcs11 available upstream
You can easily grab this release in tarball format on Github:
https://github.com/opencryptoki/openssl-ibmpkcs11/archive/v1.0.1.tar.gz

Please integrate into Fedora

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 979332] Review Request: libpqtypes - Software extension to the PostgreSQL libpq interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=979332

Dan Horák  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX
Last Closed||2018-01-22 03:53:36



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 457517] Review Request: perl-Padre - Perl Application Development and Refactoring Environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=457517
Bug 457517 depends on bug 463768, which changed state.

Bug 463768 Summary: Package review: perl-PAR
https://bugzilla.redhat.com/show_bug.cgi?id=463768

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |CURRENTRELEASE



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 463768] Package review: perl-PAR

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=463768

Dan Horák  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed|2008-11-19 02:59:07 |2018-01-22 03:50:39



--- Comment #12 from Dan Horák  ---
Closing as bodhi reopened this.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536993] New: Review Request: notejot - Stupidly-simple sticky notes applet

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536993

Bug ID: 1536993
   Summary: Review Request: notejot - Stupidly-simple sticky notes
applet
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: decatho...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://decathorpe.fedorapeople.org/packages/notejot.spec
SRPM URL:
https://decathorpe.fedorapeople.org/packages/notejot-1.3.7-1.fc27.src.rpm

Description:
Stupidly simple sticky notes applet.

Fedora Account System Username: decathorpe

koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24365741

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 558535] CalculiX (ccx, cgx)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=558535
Bug 558535 depends on bug 566974, which changed state.

Bug 566974 Summary: Review Request: cgx - finite element pre/postprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=566974

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 566974] Review Request: cgx - finite element pre/postprocessor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=566974

Dan Horák  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX
Last Closed||2018-01-22 03:48:48



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 558535] CalculiX (ccx, cgx)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=558535
Bug 558535 depends on bug 566972, which changed state.

Bug 566972 Summary: Review Request: ccx - finite element solver
https://bugzilla.redhat.com/show_bug.cgi?id=566972

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 566972] Review Request: ccx - finite element solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=566972

Dan Horák  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX
Last Closed||2018-01-22 03:48:20



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536990] Review Request: openssl-ibmpkcs11 - IBM OpenSSL PKCS#11 engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536990

Dan Horák  changed:

   What|Removed |Added

 Blocks||1525184



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 794793] Review Request: openssl-ibmpkcs11 - An openssl PKCS#11 engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=794793

Dan Horák  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |DUPLICATE
  Flags|needinfo?(bugpr...@us.ibm.c |
   |om) needinfo?(d...@danny.cz) |
Last Closed||2018-01-22 03:44:20



--- Comment #12 from Dan Horák  ---


*** This bug has been marked as a duplicate of bug 1536990 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536990] Review Request: openssl-ibmpkcs11 - IBM OpenSSL PKCS#11 engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536990

Dan Horák  changed:

   What|Removed |Added

 Blocks||467765 (ZedoraTracker)
 CC||k...@linux.vnet.ibm.com



--- Comment #1 from Dan Horák  ---
*** Bug 794793 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=467765
[Bug 467765] Fedora for System z (s390): Bug Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536990] New: Review Request: openssl-ibmpkcs11 - IBM OpenSSL PKCS#11 engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536990

Bug ID: 1536990
   Summary: Review Request: openssl-ibmpkcs11 - IBM OpenSSL
PKCS#11 engine
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: d...@danny.cz
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://fedora.danny.cz/openssl-ibmpkcs11.spec
SRPM URL: http://fedora.danny.cz/openssl-ibmpkcs11-1.0.1-1.fc27.src.rpm

Description:
This package contains a shared object OpenSSL dynamic engine for the use
with a PKCS#11 implementation such as openCryptoki.

Fedora Account System Username: sharkcz

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24365696

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536984] New: Review Request: sequeler - SQL Client built in Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536984

Bug ID: 1536984
   Summary: Review Request: sequeler - SQL Client built in Vala
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: decatho...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://decathorpe.fedorapeople.org/packages/sequeler.spec
SRPM URL:
https://decathorpe.fedorapeople.org/packages/sequeler-0.4.2-1.fc27.src.rpm

Description:
Sequeler is a native Linux SQL client built in Vala and Gtk. It allows
you to connect to your local and remote databases, write SQL in a handy
text editor with language recognition, and visualize SELECT results in
a Gtk.Grid Widget.

Fedora Account System Username: decathorpe

koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24365427


Packager's comments:
The "invalid-lc-messages-dir" rpmlint errors for the "bh" and "mo" locales seem
to be outdated, there's already a lot of packages that supply translations for
those languages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536870] Review Request: agenda - Simple, fast, no-nonsense to-do ( task) list

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536870



--- Comment #2 from Fabio Valentini  ---
Thanks for doing the review, and good catch noticing the LICENSE discrepancy!

Reported at: https://github.com/dahenson/agenda/issues/63

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org