[Bug 1539276] Review Request: rust-threadpool - Thread pool for running a number of jobs on a fixed set of worker threads
https://bugzilla.redhat.com/show_bug.cgi?id=1539276
Igor Gnatenko changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|ignate...@redhat.com
Summary|Review Request: |Review Request:
|rust-threadpool - A thread |rust-threadpool - Thread
|pool for running a number |pool for running a number
|of jobs on a fixed set of |of jobs on a fixed set of
|worker threads. |worker threads
--- Comment #1 from Igor Gnatenko ---
> Summary:A thread pool for running a number of jobs on a fixed set of
> worker threads.
summary should not end with ".", also remove "A " (but keep it in description).
> %license LICENSE-MIT
> %license LICENSE-APACHE
nitpick: better to have them in one line.
Also you need to add:
* %doc README.md CHANGES.md
* %exclude %{cargo_registry}/%{crate}-%{version}/appveyor.yml
Apart from above, looks good.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1538188] Review Request: rust-cssparser - Rust implementation of CSS Syntax Level 3
https://bugzilla.redhat.com/show_bug.cgi?id=1538188 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-01-28 02:20:49 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539319] Review Request: ghc-data-default-instances-old-locale - Default instances for types in old-locale
https://bugzilla.redhat.com/show_bug.cgi?id=1539319
Elliott Sales de Andrade changed:
What|Removed |Added
Status|NEW |POST
CC||quantum.anal...@gmail.com
Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com
Flags||fedora-review+
--- Comment #1 from Elliott Sales de Andrade ---
APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (2 clause)", "Unknown or generated". 2 files have unknown
license. Detailed output of licensecheck in
review/1539319-ghc-data-default-instances-old-locale/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 71680 bytes in 14 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets m
[Bug 1539257] Review Request: rust-pretty-git-prompt - Your current git repository information inside a beautiful shell prompt
https://bugzilla.redhat.com/show_bug.cgi?id=1539257 Igor Gnatenko changed: What|Removed |Added Summary|Review Request: |Review Request: |pretty-git-prompt - Your|rust-pretty-git-prompt - |current git repository |Your current git repository |information inside a|information inside a |beautiful shell prompt |beautiful shell prompt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539281] Review Request: rust-chan - Multi-producer, multi-consumer channels with select
https://bugzilla.redhat.com/show_bug.cgi?id=1539281 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-01-28 02:02:09 --- Comment #4 from Igor Gnatenko --- Randy, can you add "rust-sig" group with "commit" privileges please? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539318] Review Request: ghc-data-default-instances-dlist - Default instances for types in dlist
https://bugzilla.redhat.com/show_bug.cgi?id=1539318
Elliott Sales de Andrade changed:
What|Removed |Added
Status|NEW |POST
CC||quantum.anal...@gmail.com
Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com
Flags||fedora-review+
--- Comment #1 from Elliott Sales de Andrade ---
APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (2 clause)", "Unknown or generated". 2 files have unknown
license. Detailed output of licensecheck in
review/1539318-ghc-data-default-instances-dlist/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 61440 bytes in 14 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be
[Bug 1539317] Review Request: ghc-data-default-instances-containers - Default instances for types in containers
https://bugzilla.redhat.com/show_bug.cgi?id=1539317
Elliott Sales de Andrade changed:
What|Removed |Added
Status|NEW |POST
CC||quantum.anal...@gmail.com
Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com
Flags||fedora-review+
--- Comment #1 from Elliott Sales de Andrade ---
APPROVED; please fix the URL on import.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (2 clause)", "Unknown or generated". 2 files have unknown
license. Detailed output of licensecheck in
review/1539317-ghc-data-default-instances-containers/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 81920 bytes in 14 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate fr
[Bug 1535549] Review Request: mupen64plus - Nintendo 64 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1535549 --- Comment #10 from Wade Berrier --- Ok, I've made the additional changes and posted them here: http://berrier.org/tmp/mupen64plus.spec http://berrier.org/tmp/mupen64plus-2.5-4.fc27.src.rpm (In reply to Robert-André Mauchin from comment #6) > You shouldn't patch the FSF address in the LICENSES files. It is allowed > when it's just in the headers of a source file, but not for license files. > See: > https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address So, what to do about this? In the meantime I've removed the patch. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539323] New: Review Request: ghc-unliftio-core - The MonadUnliftIO typeclass for unlifting monads to IO
https://bugzilla.redhat.com/show_bug.cgi?id=1539323 Bug ID: 1539323 Summary: Review Request: ghc-unliftio-core - The MonadUnliftIO typeclass for unlifting monads to IO Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: peter...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://petersen.fedorapeople.org//ghc-unliftio-core.spec SRPM URL: http://petersen.fedorapeople.org//ghc-unliftio-core-0.1.1.0-1.fc27.src.rpm Description: Provides the core MonadUnliftIO typeclass, instances for base and transformers, and basic utility functions. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539319] New: Review Request: ghc-data-default-instances-old-locale - Default instances for types in old-locale
https://bugzilla.redhat.com/show_bug.cgi?id=1539319 Bug ID: 1539319 Summary: Review Request: ghc-data-default-instances-old-locale - Default instances for types in old-locale Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: peter...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://petersen.fedorapeople.org//ghc-data-default-instances-old-locale.spec SRPM URL: http://petersen.fedorapeople.org//ghc-data-default-instances-old-locale-0.0.1-1.fc27.src.rpm Description: Default instances for types in old-locale. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539318] New: Review Request: ghc-data-default-instances-dlist - Default instances for types in dlist
https://bugzilla.redhat.com/show_bug.cgi?id=1539318 Bug ID: 1539318 Summary: Review Request: ghc-data-default-instances-dlist - Default instances for types in dlist Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: peter...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://petersen.fedorapeople.org//ghc-data-default-instances-dlist.spec SRPM URL: http://petersen.fedorapeople.org//ghc-data-default-instances-dlist-0.0.1-1.fc27.src.rpm Description: Default instances for types in dlist. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539317] New: Review Request: ghc-data-default-instances-containers - Default instances for types in containers
https://bugzilla.redhat.com/show_bug.cgi?id=1539317 Bug ID: 1539317 Summary: Review Request: ghc-data-default-instances-containers - Default instances for types in containers Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: peter...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://petersen.fedorapeople.org//ghc-data-default-instances-containers.spec SRPM URL: http://petersen.fedorapeople.org//ghc-data-default-instances-containers-0.0.1-1.fc27.src.rpm Description: Default instances for types in containers. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539314] Review Request: ghc-basement - Foundation scrap box of array & string
https://bugzilla.redhat.com/show_bug.cgi?id=1539314 Jens Petersen changed: What|Removed |Added Blocks||1504320 --- Comment #1 from Jens Petersen --- Needed by recent versions of foundation. (Happy to share ownership of course.) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1504320 [Bug 1504320] ghc-foundation-0.0.19 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539314] New: Review Request: ghc-basement - Foundation scrap box of array & string
https://bugzilla.redhat.com/show_bug.cgi?id=1539314 Bug ID: 1539314 Summary: Review Request: ghc-basement - Foundation scrap box of array & string Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: peter...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://petersen.fedorapeople.org//ghc-basement.spec SRPM URL: http://petersen.fedorapeople.org//ghc-basement-0.0.4-1.fc27.src.rpm Description: Foundation most basic primitives without any dependencies. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539281] Review Request: rust-chan - Multi-producer, multi-consumer channels with select
https://bugzilla.redhat.com/show_bug.cgi?id=1539281 --- Comment #3 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-chan -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539291] Review Request: ghc-echo - Cross-platform, cross-console echoing of terminal input
https://bugzilla.redhat.com/show_bug.cgi?id=1539291 Jens Petersen changed: What|Removed |Added Blocks||1527440 --- Comment #1 from Jens Petersen --- Needed for cabal-install-2 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1527440 [Bug 1527440] cabal-install-2.0.0.1 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539291] New: Review Request: ghc-echo - Cross-platform, cross-console echoing of terminal input
https://bugzilla.redhat.com/show_bug.cgi?id=1539291 Bug ID: 1539291 Summary: Review Request: ghc-echo - Cross-platform, cross-console echoing of terminal input Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: peter...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://petersen.fedorapeople.org//ghc-echo.spec SRPM URL: http://petersen.fedorapeople.org//ghc-echo-0.1.3-1.fc27.src.rpm Description: The 'base' library exposes the 'hGetEcho' and 'hSetEcho' functions for querying and setting echo status, but unfortunately, neither function works with MinTTY consoles on Windows. This is a serious issue, since 'hGetEcho' and 'hSetEcho' are often used to disable input echoing when a program prompts for a password, so many programs will reveal your password as you type it on MinTTY! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1526717] Review Request: python-giacpy - Python binding for Giac
https://bugzilla.redhat.com/show_bug.cgi?id=1526717 --- Comment #12 from Fedora Update System --- python-giacpy-0.6.5-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-28145db148 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1526717] Review Request: python-giacpy - Python binding for Giac
https://bugzilla.redhat.com/show_bug.cgi?id=1526717 --- Comment #13 from Fedora Update System --- python-giacpy-0.6.5-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-5e0bc7a4b2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539267] Review Request: rust-tabwriter - Elastic tabstops
https://bugzilla.redhat.com/show_bug.cgi?id=1539267
Randy Barlow changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Randy Barlow ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 9 files have
unknown license. Detailed output of licensecheck in
/home/rbarlow/reviews/1539267-rust-tabwriter/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can
[Bug 1539267] Review Request: rust-tabwriter - Elastic tabstops
https://bugzilla.redhat.com/show_bug.cgi?id=1539267 Randy Barlow changed: What|Removed |Added Status|NEW |ASSIGNED CC||ra...@electronsweatshop.com Assignee|nob...@fedoraproject.org|ra...@electronsweatshop.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539281] Review Request: rust-chan - Multi-producer, multi-consumer channels with select
https://bugzilla.redhat.com/show_bug.cgi?id=1539281 --- Comment #2 from Randy Barlow --- I've fixed those issues, thanks for the review! https://pagure.io/releng/fedora-scm-requests/issue/4302 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539281] Review Request: rust-chan - Multi-producer, multi-consumer channels with select
https://bugzilla.redhat.com/show_bug.cgi?id=1539281 Igor Gnatenko changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|ignate...@redhat.com Flags||fedora-review+ --- Comment #1 from Igor Gnatenko --- Looks good from first glance except the license tag, there should be "or" instead of "/". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539281] New: Review Request: rust-chan - Multi-producer, multi-consumer channels with select
https://bugzilla.redhat.com/show_bug.cgi?id=1539281 Bug ID: 1539281 Summary: Review Request: rust-chan - Multi-producer, multi-consumer channels with select Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ra...@electronsweatshop.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://bowlofeggs.fedorapeople.org/rust-chan.spec SRPM URL: https://bowlofeggs.fedorapeople.org/rust-chan-0.1.20-1.fc28.src.rpm Description: Multi-producer, multi-consumer channels with select Fedora Account System Username: bowlofeggs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539276] New: Review Request: rust-threadpool - A thread pool for running a number of jobs on a fixed set of worker threads.
https://bugzilla.redhat.com/show_bug.cgi?id=1539276
Bug ID: 1539276
Summary: Review Request: rust-threadpool - A thread pool for
running a number of jobs on a fixed set of worker
threads.
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nob...@fedoraproject.org
Reporter: ttome...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Spec URL: https://ttomecek.fedorapeople.org/rust-threadpool.spec
SRPM URL:
https://ttomecek.fedorapeople.org/rust-threadpool-1.7.1-1.fc28.src.rpm
Description: A thread pool for running a number of jobs on a fixed set of
worker threads.
This package contains library source intended for building other packages
which use %{crate} from crates.io.
Fedora Account System Username: ttomecek
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539271] New: Review Request: rust-streaming-stats - Experimental crate for computing basic statistics on streams
https://bugzilla.redhat.com/show_bug.cgi?id=1539271 Bug ID: 1539271 Summary: Review Request: rust-streaming-stats - Experimental crate for computing basic statistics on streams Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: ignate...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-streaming-stats.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-streaming-stats-0.1.28-1.fc28.src.rpm Description: Experimental crate for computing basic statistics on streams. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539267] New: Review Request: rust-tabwriter - Elastic tabstops
https://bugzilla.redhat.com/show_bug.cgi?id=1539267 Bug ID: 1539267 Summary: Review Request: rust-tabwriter - Elastic tabstops Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: ignate...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-tabwriter.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-tabwriter-1.0.3-1.fc28.src.rpm Description: Elastic tabstops. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1526717] Review Request: python-giacpy - Python binding for Giac
https://bugzilla.redhat.com/show_bug.cgi?id=1526717 --- Comment #10 from Fedora Update System --- python-giacpy-0.6.5-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-6942b9aeae -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1526717] Review Request: python-giacpy - Python binding for Giac
https://bugzilla.redhat.com/show_bug.cgi?id=1526717 --- Comment #11 from Fedora Update System --- python-giacpy-0.6.5-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-d1ab3e4970 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1526717] Review Request: python-giacpy - Python binding for Giac
https://bugzilla.redhat.com/show_bug.cgi?id=1526717 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539257] Review Request: pretty-git-prompt - Your current git repository information inside a beautiful shell prompt
https://bugzilla.redhat.com/show_bug.cgi?id=1539257 Randy Barlow changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Randy Barlow --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 24 files have unknown license. Detailed output of licensecheck in /home/rbarlow/reviews/1539257-pretty-git-prompt/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/.build-id (libwayland-server, virglrenderer, cyrus-sasl-md5, iputils, numactl- libs, gd, libvirt-daemon-driver-nwfilter, libtomcrypt, librsync, policycoreutils-python-utils, libxshmfence, qemu-block-gluster, ncurses-c++-libs, gpgme, osinfo-db-tools, libsndfile, python3-sqlalchemy, tidy, libmcpp, libibverbs, libimagequant, giflib, bind99-libs, tk, trousers, atlas, qemu-block-nfs, xemacs, ruby-libs, bzip2-libs, unzip, texlive-pdftex-bin, rpmreaper, libdb-utils, xorg-x11-font-utils, gtk2, gtk3, OpenEXR-libs, python2-setools, libcom_err, pycryptopp, libseccomp, double-conversion, npth, ghostscript, audit-libs-python, p11-kit, libyaml, iptables-libs, mercurial, device-mapper-persistent-data, cryptsetup-libs, python2-krbv, webkit2gtk3-plugin-process-gtk2, libmodman, gc, libXau, libselinux-utils, perl-Scalar-List-Utils, parted, libuser, libdvdread, zstd, orpie, m17n-lib, mozjs17, texlive-xdvi-bin, mesa-libwayland-egl, erlang-fast_xml, glusterfs, lua-posix, libwebp, libxslt, python2-bson, gdbm, libpkgconf, teckit, libunistring, postgresql-libs, keyutils- libs, perl-Encode, elfutils, libproxy, inotify-tools, libgpg-error, snappy, lvm2-libs, libosinfo, erlang-megaco, perl-Digest-SHA, php-gd, audit-libs-python3, nss-tools, perl-Data-Dumper, autotrace, isns- utils-libs, Canna-libs, rpm-plugin-selinux, gawk, libzstd, openal- soft-devel, qemu-block-curl, libEMF, c-ares, lua-lpeg, python2-sqlalchemy, python3-simplejson, php-mbstring, rdma-core, erlang-cache_tab, jansson, vte291, libzip, e2fsprogs-libs, pulseaudio- libs, librsvg2, wxGTK3-webview, libwsman1, lcms2, qemu-block-iscsi, libnfsidmap, perl-XML-Parser, tmux, annobin, deltarpm, file-libs, grub2-tools, libxcb, trousers-lib, libyubikey, avahi-glib, python3-pycurl, erlang-epam, zip, libnetfilter_conntrack, usermode, nodejs, libev, m4, gdb-headless, python26, python2-lazy-object-proxy, vim-enhanced, libvdpau, libusbx, python3-PyYAML, python3-pygpgme, python3-psutil, compat-openssl10, texlive-metafont-bin, rubygem- unf_ext, qrencode-libs, libICE, harfbuzz-devel, drpm, python2-gssapi, libwmf-lite, pstoedit, libnsl, createrepo_c-libs, perl-Compress-Raw- Zlib, libtasn1, python2-wrapt, python3-coverage, upower, openssh, boost-thread, iptables, sqlite, http-parser, perl-interpreter, tar, gtk2-devel, sudo, texlive-mfware-bin, openssl, erlang-typer, logrotate, php-xml, dhcp-client, wxBase3-devel, spice-server, libgomp, erlang-runtime_tools, systemd-bootchart, libvirt-daemon-driver-secret, dwz, alsa-lib, erlang-tools, python2-psutil, ntfsprogs, ebtables, libvirt-daemon-driver-storage-disk, avahi-libs, device-mapper- multipath-libs, dbusmenu-qt, NetworkManager, pyliblzma, ncurses-libs, libidn2, pigz, timedatex, python3-gpg, checkpolicy, libpsl, postfix, python3-rpm, pciutils, erlang-ezlib, libini_config, libao, gcc, hostname, python3-libs, python3-hawkey, lksctp-tools, celt051, kbd, libvirt-daemon-driver-qemu, htop, perl-Time-HiRes, gnutls, qemu-block- ssh, python3-cryptography, wayland-devel, gssproxy, libacl, gts, libwayland-cursor, libnl3, libcap-ng, libSM, policycoreutils, pixman, libnsl2, flex, squashfs-tools, libidn, usbredir, libXxf86misc, grubby, libatomic_ops, python2-kerberos, brltty, pango, libstdc++, libss, libbabeltrace, nspr, libuninameslist, dbus, python2-genshi, qemu- block-rbd, polkit-libs, python3-systemd, psmisc, net-snmp-libs, perl- threads, perl-Params-Validate, rpm-build, compat-readline6, libvirt- daemon-driver-storage-sheepdog, pypy3-libs, libglvnd-gles, python2-libcomps, python2-pyyaml, cairo, audit-libs, zerofree, nss-
[Bug 1539257] Review Request: pretty-git-prompt - Your current git repository information inside a beautiful shell prompt
https://bugzilla.redhat.com/show_bug.cgi?id=1539257 Randy Barlow changed: What|Removed |Added Status|NEW |ASSIGNED CC||ra...@electronsweatshop.com Assignee|nob...@fedoraproject.org|ra...@electronsweatshop.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539257] New: Review Request: pretty-git-prompt - Your current git repository information inside a beautiful shell prompt
https://bugzilla.redhat.com/show_bug.cgi?id=1539257 Bug ID: 1539257 Summary: Review Request: pretty-git-prompt - Your current git repository information inside a beautiful shell prompt Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ignate...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/pretty-git-prompt.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/pretty-git-prompt-0.2.0-1.fc28.src.rpm Description: Your current git repository information inside a beautiful shell prompt. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
