[Bug 1542522] Review Request: jsonnet - a data templating language
https://bugzilla.redhat.com/show_bug.cgi?id=1542522 --- Comment #2 from Naadir Jeewa --- Updated SRPM / Spec as per comments: https://copr-be.cloud.fedoraproject.org/results/randomvariable/jsonnet/fedora-rawhide-x86_64/00713419-jsonnet/jsonnet-0.9.5-3.src.rpm https://github.com/randomvariable/jsonnet-rpm/blob/master/jsonnet.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1377631] Review Request: gnome-shell-extension-netspeed - A gnome-shell extension to show speed of the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1377631
--- Comment #17 from Andrew Toskin ---
I'm pretty sure 3.26 is supposed to be the latest version of GNOME Shell which
the extension was tested against. GNOME Shell *extensions* all have a
metadata.json file, which includes a "version" property. This is supposed to
state the version of the extension itself, and for NetSpeed, that property is
28.
https://github.com/hedayaty/NetSpeed/blob/master/metadata.json
I've tried asking the upstream developer, hedayaty, to git-tag his releases. Or
at least to explain to us how to know when the code is stable enough for
release. But he doesn't seem to get it, and I'm not sure how else to explain
what I'm asking about :/
So, I guess continue with your %{gitdate} and %{shortcommit} Releases. But I'm
pretty sure the spec Version should be 28.
I'll double check everything else one last time when that's done.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate
https://bugzilla.redhat.com/show_bug.cgi?id=1267468 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #13 from Robert-André Mauchin --- Ok, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1268742] Review Request: rubygem-bacon-colored_output - Colored output for Bacon test framework
https://bugzilla.redhat.com/show_bug.cgi?id=1268742 --- Comment #13 from Ilya Gradina --- (In reply to Roman Joost from comment #7) > Approved. Many thanks! Roman, could you maybe mark this as approved again? Error: The Bugzilla bug's review was approved over 60 days ago -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1544151] Review Request: python-idna-ssl - Patch ssl.match_hostname for Unicode(idna) domains support
https://bugzilla.redhat.com/show_bug.cgi?id=1544151 Neal Gompa changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #2 from Neal Gompa --- Review notes: [x] Package is named appropriately [x] Package follows Python packaging guidelines [x] Package follows Fedora packaging guidelines [x] Package builds and installs correctly [!] Missing %python_provide macro. Please fix on import. PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1544151] Review Request: python-idna-ssl - Patch ssl.match_hostname for Unicode(idna) domains support
https://bugzilla.redhat.com/show_bug.cgi?id=1544151 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Flags||fedora-review? --- Comment #1 from Neal Gompa --- Taking this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1544151] New: Review Request: python-idna-ssl - Patch ssl.match_hostname for Unicode(idna) domains support
https://bugzilla.redhat.com/show_bug.cgi?id=1544151 Bug ID: 1544151 Summary: Review Request: python-idna-ssl - Patch ssl.match_hostname for Unicode(idna) domains support Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ignate...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-idna-ssl.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-idna-ssl-1.0.0-1.fc28.src.rpm Description: Patch ssl.match_hostname for Unicode(idna) domains support. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1267468] Review Request: rubygem-codeclimate-test-reporter - Uploads Ruby test coverage data to Code Climate
https://bugzilla.redhat.com/show_bug.cgi?id=1267468 --- Comment #12 from Ilya Gradina --- thx, I fixed dependency resolution fails, and removed Group section. new srpm: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-codeclimate-test-reporter-1.0.8-2.fc28.src.rpm new spec: https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-codeclimate-test-reporter.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1543989] Review Request: rust-structopt - Parse command line argument by defining a struct
https://bugzilla.redhat.com/show_bug.cgi?id=1543989 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-02-10 13:05:43 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1543987] Review Request: rust-structopt-derive - Parse command line argument by defining a struct, derive crate
https://bugzilla.redhat.com/show_bug.cgi?id=1543987 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-02-10 12:41:20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1543989] Review Request: rust-structopt - Parse command line argument by defining a struct
https://bugzilla.redhat.com/show_bug.cgi?id=1543989 Bug 1543989 depends on bug 1543987, which changed state. Bug 1543987 Summary: Review Request: rust-structopt-derive - Parse command line argument by defining a struct, derive crate https://bugzilla.redhat.com/show_bug.cgi?id=1543987 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1543989] Review Request: rust-structopt - Parse command line argument by defining a struct
https://bugzilla.redhat.com/show_bug.cgi?id=1543989 --- Comment #2 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-structopt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1543987] Review Request: rust-structopt-derive - Parse command line argument by defining a struct, derive crate
https://bugzilla.redhat.com/show_bug.cgi?id=1543987 --- Comment #2 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-structopt-derive -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1543578] Review Request: php-deepdiver-zipstreamer - package maintained fork of PHPZipStreamer
https://bugzilla.redhat.com/show_bug.cgi?id=1543578 --- Comment #5 from Christian Glombek --- I will put the commit based source git archive retrieval back in. I see that it's more precise and transparent. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539366] Review Request: linux-driver-management - Generic driver management framework for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1539366 --- Comment #9 from Fedora Update System --- linux-driver-management-1.0.3-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-5dfcc2de15 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539366] Review Request: linux-driver-management - Generic driver management framework for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1539366 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1544081] Review Request: grc - Generic Colorizer
https://bugzilla.redhat.com/show_bug.cgi?id=1544081
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
- Use %{version} in Source0:
Source0:
https://github.com/garabik/grc/archive/v%{version}/%{name}-%{version}.tar.gz
- Seems to work with python3: https://github.com/garabik/grc/blob/master/grc
You should depend on python3-devel instead.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://admin.fedoraproject.org/pkgdb/package/grc
See:
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 122 files have unknown license.
Detailed output of licensecheck in /home/bob/packaging/review/grc
/review-grc/licensecheck.txt
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /etc/profile.d
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should te
[Bug 1536782] Review Request: golang-github-cryptix-wav - golang wav reader and writer
https://bugzilla.redhat.com/show_bug.cgi?id=1536782 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #3 from Robert-André Mauchin --- Tests require github.com/cheekybits/is, it would be nice to package it, and add it to the SPEC to run the tests correctly. Package otherwise approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
