[Bug 1546946] Review Request: golang-github-gobuffalo-envy - Makes working with ENV variables in Go trivial

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546946

Athos Ribeiro  changed:

   What|Removed |Added

 Blocks||1529947




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1529947
[Bug 1529947] hugo-0.36.1 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546946] Review Request: golang-github-gobuffalo-envy - Makes working with ENV variables in Go trivial

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546946

Athos Ribeiro  changed:

   What|Removed |Added

 Depends On||1546947




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1546947
[Bug 1546947] Review Request: godotenv - A Go port of Ruby's dotenv library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546947] Review Request: godotenv - A Go port of Ruby' s dotenv library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546947

Athos Ribeiro  changed:

   What|Removed |Added

 Blocks||1546946




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1546946
[Bug 1546946] Review Request: golang-github-gobuffalo-envy - Makes working
with ENV variables in Go trivial
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546947] New: Review Request: godotenv - A Go port of Ruby' s dotenv library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546947

Bug ID: 1546947
   Summary: Review Request: godotenv - A Go port of Ruby's dotenv
library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: athoscribe...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://athoscr.fedorapeople.org//godotenv.spec
SRPM URL: http://athoscr.fedorapeople.org//godotenv-1.2-1.fc27.src.rpm

Description:
A Go port of Ruby's dotenv library

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546947] Review Request: godotenv - A Go port of Ruby' s dotenv library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546947



--- Comment #1 from Athos Ribeiro  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=25176229

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546946] New: Review Request: golang-github-gobuffalo-envy - Makes working with ENV variables in Go trivial

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546946

Bug ID: 1546946
   Summary: Review Request: golang-github-gobuffalo-envy - Makes
working with ENV variables in Go trivial
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: athoscribe...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://athoscr.fedorapeople.org//golang-github-gobuffalo-envy.spec
SRPM URL:
http://athoscr.fedorapeople.org//golang-github-gobuffalo-envy-1.3.0-1.fc27.src.rpm

Description:
Makes working with ENV variables in Go trivial

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1096052] Review Request: nodejs-i18n - Lightweight translation module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1096052

Piotr Drąg  changed:

   What|Removed |Added

 Blocks|1546484 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1546484
[Bug 1546484] F28 Localization Tracking
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546394] Review Request: open-amp - Open Asymmetric Multi Processing (OpenAMP) framework project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546394

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
All ok, package approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "MIT/X11 (BSD like)", "zlib/libpng",
 "*No copyright* BSD (3 clause)", "BSD (2 clause) GPL (v2 or later)",
 "BSD (3 clause)", "BSD (2 clause)", "GPL (v2)". 121 files have unknown
 license. Detailed output of licensecheck in /home/bob/packaging/review
 /open-amp/review-open-amp/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into 

[Bug 1491492] Review Request: coturn - TURN/STUN & ICE Server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491492



--- Comment #5 from Robert-André Mauchin  ---
 - Shouldn't be marked as %config:

%config %{_tmpfilesdir}/coturn.conf

 - Manpages are wrongly marked as executables, remove the executable bits and
notify upstream:

coturn.x86_64: W: spurious-executable-perm /usr/share/man/man1/coturn.1.gz
coturn.x86_64: W: spurious-executable-perm /usr/share/man/man1/turnadmin.1.gz
coturn.x86_64: W: spurious-executable-perm /usr/share/man/man1/turnserver.1.gz
coturn-utils.x86_64: W: spurious-executable-perm
/usr/share/man/man1/turnutils.1.gz
coturn-utils.x86_64: W: spurious-executable-perm
/usr/share/man/man1/turnutils_natdiscovery.1.gz
coturn-utils.x86_64: W: spurious-executable-perm
/usr/share/man/man1/turnutils_oauth.1.gz
coturn-utils.x86_64: W: spurious-executable-perm
/usr/share/man/man1/turnutils_peer.1.gz
coturn-utils.x86_64: W: spurious-executable-perm
/usr/share/man/man1/turnutils_stunclient.1.gz
coturn-utils.x86_64: W: spurious-executable-perm
/usr/share/man/man1/turnutils_uclient.1.gz

 - Remove Rpath:

coturn.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/turnadmin
['/usr/lib/', '/usr/local/lib/', '/usr/lib64/', '/usr/local/lib64/',
'/usr/lib64/pgsql', '/usr/local/lib']
coturn.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/turnserver
['/usr/lib/', '/usr/local/lib/', '/usr/lib64/', '/usr/local/lib64/',
'/usr/lib64/pgsql', '/usr/local/lib']
coturn-utils.x86_64: E: binary-or-shlib-defines-rpath
/usr/bin/turnutils_natdiscovery ['/usr/lib/', '/usr/local/lib/', '/usr/lib64/',
'/usr/local/lib64/', '/usr/lib64/pgsql', '/usr/local/lib']
coturn-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/turnutils_oauth
['/usr/lib/', '/usr/local/lib/', '/usr/lib64/', '/usr/local/lib64/',
'/usr/lib64/pgsql', '/usr/local/lib']
coturn-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/turnutils_peer
['/usr/lib/', '/usr/local/lib/', '/usr/lib64/', '/usr/local/lib64/',
'/usr/lib64/pgsql', '/usr/local/lib']
coturn-utils.x86_64: E: binary-or-shlib-defines-rpath
/usr/bin/turnutils_stunclient ['/usr/lib/', '/usr/local/lib/', '/usr/lib64/',
'/usr/local/lib64/', '/usr/lib64/pgsql', '/usr/local/lib']
coturn-utils.x86_64: W: crypto-policy-non-compliance-openssl
/usr/bin/turnutils_uclient SSL_CTX_set_cipher_list
coturn-utils.x86_64: E: binary-or-shlib-defines-rpath
/usr/bin/turnutils_uclient ['/usr/lib/', '/usr/local/lib/', '/usr/lib64/',
'/usr/local/lib64/', '/usr/lib64/pgsql', '/usr/local/lib']

%configure --confdir=%{_sysconfdir}/%{name} \
--examplesdir=%{_datadir}/%{name} \
--schemadir=%{_datadir}/%{name} \
--manprefix=%{_datadir} \
--docdir=%{_docdir}/%{name} \
--disable-rpath

 - I find curious to install the examples in %{_datadir}/%{name} They generally
are included in %doc.

 - Read this bit about shipping static library and act accordingly:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Packaging_Static_Libraries_2

 - Should not be executable either:

coturn-client-libs.x86_64: W: spurious-executable-perm
/usr/lib64/libturnclient.a

 - Rpmlint gives more error which I don't really know how to solve, might ask
some help on -devel:

missing-call-to-setgroups-before-setuid:
This executable is calling setuid and setgid without secoturn.x86_64: W:
crypto-policy-non-compliance-openssl /usr/bin/turnadmin SSL_CTX_set_cipher_list
coturn.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/turnserver
SSL_CTX_set_cipher_list
coturn-utils.x86_64: W: crypto-policy-non-compliance-openssl
/usr/bin/turnutils_uclient SSL_CTX_set_cipher_listtgroups or initgroups.
There is a high probability this means it didn't relinquish all groups, and
this would be a potential security issue to be fixed. Seek POS36-C on the web
for details about the problem.

coturn.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/turnadmin
coturn.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/turnserver

  - Another error

crypto-policy-non-compliance-openssl:
This application package calls a function to explicitly set crypto ciphers for
SSL/TLS. That may cause the application not to use the system-wide set
cryptographic policy and should be modified in accordance to:
https://fedoraproject.org/wiki/Packaging:CryptoPolicies


coturn.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/turnadmin
SSL_CTX_set_cipher_list
coturn.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/turnserver
SSL_CTX_set_cipher_list
coturn-utils.x86_64: W: crypto-policy-non-compliance-openssl
/usr/bin/turnutils_uclient SSL_CTX_set_cipher_list

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546534] Review Request: golang-github-paulrosania-go-charset - Character set conversion for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546534



--- Comment #4 from Fedora Update System  ---
golang-github-paulrosania-go-charset-0-0.1.20151028git621bb39.fc26 has been
submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-32e5246061

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546534] Review Request: golang-github-paulrosania-go-charset - Character set conversion for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546534



--- Comment #3 from Fedora Update System  ---
golang-github-paulrosania-go-charset-0-0.1.20151028git621bb39.fc27 has been
submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-77ac44a05d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546534] Review Request: golang-github-paulrosania-go-charset - Character set conversion for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546534

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440992] Review Request: python-booleanoperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992

Athos Ribeiro  changed:

   What|Removed |Added

 Blocks||182235 (FE-Legal)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440992] Review Request: python-booleanoperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992



--- Comment #10 from Athos Ribeiro  ---
(In reply to Peter Oliver from comment #9)
> I notice that
> https://github.com/typemytype/booleanOperations/blob/master/README.rst
> states:
> 
> > Boolean operations on paths based on a super fast polygon clipper library 
> > by Angus Johnson
> 
> However, this Clipper library is released under the Boost Software License,
> not the MIT licence which BooleanOperations claims.  The Boost Software
> License require that this licence is preserved in derivatives.
> 
> I have raised https://github.com/typemytype/booleanOperations/issues/47
> upstream, asking them to clarify the situation.

BooleanOperations is not a derivative work of pyclipper. It is not a derivative
of the clipper library as well and pyclipper itself is not a derivative work of
the clipper library.

- pyclipper is a set of python bindings for the clipper library (this is not a
derivative, it just uses the library).

- BooleanOperations is a python package that uses (imports) pyclipper, which
does not mean it is a derivative as well.

Derivative works would be modifications on top of the software in question.

Just to be sure, I am rasing Fedora legal flag.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546394] Review Request: open-amp - Open Asymmetric Multi Processing (OpenAMP) framework project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546394



--- Comment #2 from Jared Smith  ---
Spec URL: https://jsmith.fedorapeople.org/Packaging/open-amp/open-amp.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/open-amp/open-amp-2017.10-2.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546376] Review Request: libmetal - An abstraction layer across user-space Linux, baremetal, and RTOS environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546376



--- Comment #7 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/libmetal

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440992] Review Request: python-booleanoperations - Boolean operations on paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440992

Peter Oliver  changed:

   What|Removed |Added

 CC||ma...@mavit.org.uk



--- Comment #9 from Peter Oliver  ---
I notice that
https://github.com/typemytype/booleanOperations/blob/master/README.rst states:

> Boolean operations on paths based on a super fast polygon clipper library by 
> Angus Johnson

However, this Clipper library is released under the Boost Software License, not
the MIT licence which BooleanOperations claims.  The Boost Software License
require that this licence is preserved in derivatives.

I have raised https://github.com/typemytype/booleanOperations/issues/47
upstream, asking them to clarify the situation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491492] Review Request: coturn - TURN/STUN & ICE Server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491492

Robert-André Mauchin  changed:

   What|Removed |Added

Summary|Review Request: Coturn -|Review Request: coturn -
   |TURN/STUN & ICE Server  |TURN/STUN & ICE Server



--- Comment #4 from Robert-André Mauchin  ---
 - Simplify your %files.
coturn-turnserver.service is not a config file and should rot be marked as
%config.
Don't mark the manpages as %doc
Don't add the .gz extension for man pages, use .* instead because the
compression could change in the future.


%files
%license %{_docdir}/%{name}/LICENSE
%{_bindir}/turnserver
%{_bindir}/turnadmin
%attr(0750,coturn,coturn) %{_localstatedir}/run/%{name}
%attr(0640,coturn,coturn) %{_localstatedir}/db/turndb
%{_unitdir}/coturn-turnserver.service
%config(noreplace) %{_sysconfdir}/sysconfig/%{name}
%config %{_sysconfdir}/sysusers.d/coturn.conf
%config %{_tmpfilesdir}/coturn.conf
%dir %attr(-,coturn,coturn) %{_sysconfdir}/%{name}
%config(noreplace) %attr(0644,coturn,coturn)
%{_sysconfdir}/%{name}/turnserver.conf
%doc %{_docdir}/%{name}
%exclude %doc %{_docdir}/%{name}/README.turnutils
%exclude %doc %{_docdir}/%{name}/LICENSE
%{_mandir}/man1/coturn.1.*
%{_mandir}/man1/turnserver.1.*
%{_mandir}/man1/turnadmin.1.*
%{_datadir}/%{name}

%files utils
%{_bindir}/turnutils_peer
%{_bindir}/turnutils_stunclient
%{_bindir}/turnutils_uclient
%{_bindir}/turnutils_oauth
%{_bindir}/turnutils_natdiscovery
%{_datadir}/%{name}/etc/turn_client_cert.pem
%{_datadir}/%{name}/etc/turn_client_pkey.pem
%{_mandir}/man1/turnutils.1.*
%{_mandir}/man1/turnutils_*.1.*
%doc %{_docdir}/%{name}/README.turnutils


%files client-libs
%license %{_docdir}/%{name}/LICENSE
%{_libdir}/libturnclient.a


%files client-devel
%{_includedir}/turn

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539189] Review Request: golang-github-zyedidia-pty - PTY interface for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539189



--- Comment #7 from Fedora Update System  ---
golang-github-zyedidia-pty-0-0.1.20180126git3036466.fc27 has been submitted as
an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-9bd59bc220

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539189] Review Request: golang-github-zyedidia-pty - PTY interface for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539189



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-zyedidia-pty

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520922] Review Request: extractpdfmark - Extract page mode and named destinations as PDFmark from PDF

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520922



--- Comment #17 from William Moreno  ---
Please post the updated spec and src.rpm in the form:

Spec URL: 
SRPM URL:

Also note that as per this F29 change [0] gcc-c++ will need to be aded to every
spec that need it, but I will no request a new update os the spec, you have
done a great work adressing the issues in the review and looking for help in
the mailing list, also the package looks good so just update the links in the
mentiones form for a final check and I think we are done with this review.

0: https://fedoraproject.org/wiki/Changes/Remove_GCC_from_BuildRoot

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539189] Review Request: golang-github-zyedidia-pty - PTY interface for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539189

Robert-André Mauchin  changed:

   What|Removed |Added

   Assignee|zebo...@gmail.com   |jsmith.fed...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546546] electrum - please update to version 3.0.6

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546546



--- Comment #6 from Itamar Reis Peixoto  ---
I did some remote pull request

fedpkg clone package

or 

git clone src.fedoraproject.org/rpms/package


then make changes

create a empty git repo on github

git remote add github http://github-repo-address.

git commit 

git push github

file the remote pull request and point the github repo address.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546546] electrum - please update to version 3.0.6

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546546



--- Comment #5 from Jason Tibbitts  ---
Well, it's complicated because you can't fork packages (or maybe you can fork
but can't commit to the fork) if you aren't already a packager.  So caravel
would have to send a remote pull request, which is fine but not as "automatic"
and to be honest I don't have any idea how to do it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546546] electrum - please update to version 3.0.6

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546546



--- Comment #4 from Itamar Reis Peixoto  ---
I think sending a pull request in https://src.fedoraproject.org/rpms/electrum
doesn't require special privileges, probably only a fas account, am I right ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546546] electrum - please update to version 3.0.6

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546546

Jason Tibbitts  changed:

   What|Removed |Added

 Status|CLOSED  |NEW
 CC||heg...@gmail.com
  Component|Package Review  |electrum
 Resolution|NOTABUG |---
   Assignee|nob...@fedoraproject.org|heg...@gmail.com
Summary|Review Request: electrum -  |electrum - please update to
   |updated to version 3.0.6 -  |version 3.0.6
   |first package need sponsor  |
   Keywords||Reopened



--- Comment #3 from Jason Tibbitts  ---
I think it's fair to have this open against the electrum package, though a
patch against the existing spec would be more useful than a whole new spec.  I
did have a conversation on IRC recently with someone who might have been
caravel about this, but I only suggested opening a bug against electrum, not
opening a whole new review request.

Hopefully the current electrum maintainer will see fit to either update the
package (which will also deal with the open security issue) or request that
caravel be sponsored so that they can be made a maintainer and perform the
update.  That request would be made via https://pagure.io/packager-sponsors.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546851] Review Request: python-certbot-dns-dnsmadeeasy - DNS Made Easy DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546851

l...@onesimussystems.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||l...@onesimussystems.com
   Assignee|nob...@fedoraproject.org|l...@onesimussystems.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546851] New: Review Request: python-certbot-dns-dnsmadeeasy - DNS Made Easy DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546851

Bug ID: 1546851
   Summary: Review Request: python-certbot-dns-dnsmadeeasy - DNS
Made Easy DNS Authenticator plugin for Certbot
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: n...@fedoraproject.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://nb.fedorapeople.org/python-certbot-dns-dnsmadeeasy.spec
SRPM URL:
https://nb.fedorapeople.org/python-certbot-dns-dnsmadeeasy-0.21.1-1.fc27.src.rpm
Description: DNS Made Easy DNS Authenticator plugin for Certbot
Fedora Account System Username: nb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545349] Review Request: libplacebo - Reusable library for GPU-accelerated video/ image rendering primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545349

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-02-19 14:20:21



--- Comment #6 from Nicolas Chauvet (kwizart)  ---
Thx for the import and review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546772] Review Request: python-dns-lexicon - Manipulate DNS records on various DNS providers in a standardized /agnostic way

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546772



--- Comment #5 from Fedora Update System  ---
python-dns-lexicon-2.1.19-1.el7 has been submitted as an update to Fedora EPEL
7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-33dbbc5672

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #41 from Alexander Ploumistos  ---
(In reply to Alexander Ploumistos from comment #40)
> 32-bit OpenBabel has been available since last August, so this can't be
> right.

I meant the last build of OpenBabel.

Btw, I have just installed molsketch on actual i686 hardware and there were no
issues.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546772] Review Request: python-dns-lexicon - Manipulate DNS records on various DNS providers in a standardized /agnostic way

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546772



--- Comment #4 from Fedora Update System  ---
python-dns-lexicon-2.1.19-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-d7727c8701

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546772] Review Request: python-dns-lexicon - Manipulate DNS records on various DNS providers in a standardized /agnostic way

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546772

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546772] Review Request: python-dns-lexicon - Manipulate DNS records on various DNS providers in a standardized /agnostic way

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546772



--- Comment #3 from Fedora Update System  ---
python-dns-lexicon-2.1.19-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-1b40cfa6d9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546297] Review Request: python-cloudflare - Python wrapper for the Cloudflare Client API v4

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546297



--- Comment #10 from Fedora Update System  ---
python-cloudflare-2.0.4-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-f4325e3efb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545969] Review Request: python-certbot-dns-digitalocean - DigitalOcean DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545969



--- Comment #9 from Fedora Update System  ---
python-certbot-dns-digitalocean-0.21.1-1.fc27 has been pushed to the Fedora 27
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-be1e6ba7c5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544716] Review Request: golang-github-inconshreveable-go-vhost - HTTP/ TLS hostname multiplexing library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544716



--- Comment #8 from Fedora Update System  ---
golang-github-inconshreveable-go-vhost-0-0.1.20160627git06d8411.fc27 has been
pushed to the Fedora 27 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-35d796c441

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541566] Review Request: whipper - Python CD-DA ripper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541566

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #18 from Fedora Update System  ---
whipper-0.6.0-6.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-55d9cc8fb4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546648] Review Request: perl-IO-Socket-Socks - Provides a way to create socks (4 or 5) client or server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546648



--- Comment #5 from Fedora Update System  ---
perl-IO-Socket-Socks-0.74-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-f105aefd30

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546648] Review Request: perl-IO-Socket-Socks - Provides a way to create socks (4 or 5) client or server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546648

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546648] Review Request: perl-IO-Socket-Socks - Provides a way to create socks (4 or 5) client or server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546648



--- Comment #4 from Fedora Update System  ---
perl-IO-Socket-Socks-0.74-2.el7 has been submitted as an update to Fedora EPEL
7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-47c3d57d25

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546648] Review Request: perl-IO-Socket-Socks - Provides a way to create socks (4 or 5) client or server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546648



--- Comment #3 from Fedora Update System  ---
perl-IO-Socket-Socks-0.74-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-3caef3d480

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546297] Review Request: python-cloudflare - Python wrapper for the Cloudflare Client API v4

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546297



--- Comment #9 from Fedora Update System  ---
python-cloudflare-2.0.4-1.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8477d00cfb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545969] Review Request: python-certbot-dns-digitalocean - DigitalOcean DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545969



--- Comment #8 from Fedora Update System  ---
python-certbot-dns-digitalocean-0.21.1-1.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-11c9d4ea02

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544716] Review Request: golang-github-inconshreveable-go-vhost - HTTP/ TLS hostname multiplexing library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544716

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
golang-github-inconshreveable-go-vhost-0-0.1.20160627git06d8411.fc26 has been
pushed to the Fedora 26 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-569ccc30be

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544384] Review Request: tcl-thread - Tcl Thread extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544384



--- Comment #7 from Fedora Update System  ---
tcl-thread-2.8.2-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-91e44ef9cc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544384] Review Request: tcl-thread - Tcl Thread extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544384



--- Comment #6 from Fedora Update System  ---
tcl-thread-2.8.2-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-5f353e41ca

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544384] Review Request: tcl-thread - Tcl Thread extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544384

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546297] Review Request: python-cloudflare - Python wrapper for the Cloudflare Client API v4

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546297

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
python-cloudflare-2.0.4-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-234443e846

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 919110] Review Request: perl-Data-Float - Details of the floating point data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=919110

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---
   Keywords||Reopened



--- Comment #7 from Fedora Update System  ---
perl-Data-Float-0.013-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-c1d675a7fe

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545969] Review Request: python-certbot-dns-digitalocean - DigitalOcean DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545969

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
python-certbot-dns-digitalocean-0.21.1-1.el7 has been pushed to the Fedora EPEL
7 testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-a0cef0c53f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543813] Review Request: pwkickstart - generate kickstart passwords

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543813

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
pwkickstart-1.0.2-3.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-3053770bc1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546835] Review Request: python-urllib-gssapi - A urllib/ urllib2 backend for GSSAPI/SPNEGO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546835

Robbie Harwood  changed:

   What|Removed |Added

 Blocks||1546836




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1546836
[Bug 1546836] Please orphan python-urllib2_kerberos
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546835] Review Request: python-urllib-gssapi - A urllib/ urllib2 backend for GSSAPI/SPNEGO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546835

Robbie Harwood  changed:

   What|Removed |Added

 CC||mc...@redhat.com
 Blocks||1537249




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1537249
[Bug 1537249] Kerberos in Python modernization
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546835] New: Review Request: python-urllib-gssapi - A urllib/ urllib2 backend for GSSAPI/SPNEGO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546835

Bug ID: 1546835
   Summary: Review Request: python-urllib-gssapi - A
urllib/urllib2 backend for GSSAPI/SPNEGO
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: rharw...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Copr build:
https://copr.fedorainfracloud.org/coprs/rharwood/python-urllib-gssapi/build/717793/
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/rharwood/python-urllib-gssapi/fedora-rawhide-x86_64/00717793-python-urllib-gssapi/python-urllib-gssapi.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/rharwood/python-urllib-gssapi/fedora-rawhide-x86_64/00717793-python-urllib-gssapi/python-urllib-gssapi-1.0.0-1.fc28.src.rpm
Fedora Account System Username: rharwood
Description:
urllib_gssapi is a backend for urllib.  It provides GSSAPI/SPNEGO
authentication to HTTP servers.  urllib_gssapi replaces urllib_kerberos and
behaves in the same ways.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546626] Review Request: nodejs-svgo - Nodejs-based tool for optimizing SVG vector graphics files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546626

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||zebo...@gmail.com
 Resolution|--- |ERRATA
Last Closed||2018-02-19 11:47:15



--- Comment #1 from Robert-André Mauchin  ---
It seems it was already packaged by Jared Smith:
https://src.fedoraproject.org/rpms/nodejs-svgo

I don't know how I missed it the other day. Just add it as a RR for your other
package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 919110] Review Request: perl-Data-Float - Details of the floating point data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=919110



--- Comment #6 from Fedora Update System  ---
perl-Data-Float-0.013-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-c1d675a7fe

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546772] Review Request: python-dns-lexicon - Manipulate DNS records on various DNS providers in a standardized /agnostic way

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546772



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-dns-lexicon

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 919110] Review Request: perl-Data-Float - Details of the floating point data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=919110

Petr Pisar  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #5 from Petr Pisar  ---
*** Bug 1546269 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546376] Review Request: libmetal - An abstraction layer across user-space Linux, baremetal, and RTOS environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546376

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Robert-André Mauchin  ---
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546534] Review Request: golang-github-paulrosania-go-charset - Character set conversion for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546534



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-paulrosania-go-charset

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545349] Review Request: libplacebo - Reusable library for GPU-accelerated video/ image rendering primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545349



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/libplacebo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546648] Review Request: perl-IO-Socket-Socks - Provides a way to create socks (4 or 5) client or server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546648



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-IO-Socket-Socks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546801] New: Review Request: argparse-manpage - Build manual page from Python ArgumentParser object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546801

Bug ID: 1546801
   Summary: Review Request: argparse-manpage - Build manual page
from Python ArgumentParser object
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: prais...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/praiskup/argparse-manpage/master/rpm/argparse-manpage.spec
SRPM URL: http://praiskup.fedorapeople.org/argparse-manpage-1.0.0-1.src.rpm
Description:
Generate manual page an automatic way from ArgumentParser object, so the
manpage 1:1 corresponds to the automatically generated --help output.  The
manpage generator needs to known the location of the object, user can
specify that by (a) the module name or corresponding python filename and
(b) the object name or the function name which returns the object.
There is a limited support for (deprecated) optparse objects, too.

Fedora Account System Username: praiskup

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539189] Review Request: golang-github-zyedidia-pty - PTY interface for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539189

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED
   Assignee|jsmith.fed...@gmail.com |zebo...@gmail.com
  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Jared Smith  ---
Package is APPROVED.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 31 files have
 unknown license. Detailed output of licensecheck in
 /home/jsmith/Documents/Fedora/Reviews/1539189-golang-github-zyedidia-
 pty/licensecheck.txt
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gocode/src,
 /usr/share/gocode, /usr/share/gocode/src/github.com
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/gocode/src/github.com/zyedidia(golang-github-zyedidia-
 tcell-devel, golang-github-zyedidia-poller-devel, golang-github-
 zyedidia-clipboard-devel, golang-github-zyedidia-glob-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.

[Bug 1546376] Review Request: libmetal - An abstraction layer across user-space Linux, baremetal, and RTOS environments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546376



--- Comment #5 from Jared Smith  ---
Spec URL: https://jsmith.fedorapeople.org/Packaging/libmetal/libmetal.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/libmetal/libmetal-2017.10-3.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539189] Review Request: golang-github-zyedidia-pty - PTY interface for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539189

Jared Smith  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jsmith.fed...@gmail.com
   Assignee|nob...@fedoraproject.org|jsmith.fed...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546772] Review Request: python-dns-lexicon - Manipulate DNS records on various DNS providers in a standardized /agnostic way

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546772

l...@onesimussystems.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from l...@onesimussystems.com ---
LGTM: Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546772] Review Request: python-dns-lexicon - Manipulate DNS records on various DNS providers in a standardized /agnostic way

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546772

l...@onesimussystems.com changed:

   What|Removed |Added

 CC||l...@onesimussystems.com
   Assignee|nob...@fedoraproject.org|l...@onesimussystems.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546772] Review Request: python-dns-lexicon - Manipulate DNS records on various DNS providers in a standardized /agnostic way

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546772

l...@onesimussystems.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546772] New: Review Request: python-dns-lexicon - Manipulate DNS records on various DNS providers in a standardized /agnostic way

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546772

Bug ID: 1546772
   Summary: Review Request: python-dns-lexicon - Manipulate DNS
records on various DNS providers in a
standardized/agnostic way
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: n...@fedoraproject.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://nb.fedorapeople.org/python-dns-lexicon.spec
SRPM URL: https://nb.fedorapeople.org/python-dns-lexicon-2.1.19-1.fc27.src.rpm
Description: Manipulate DNS records on various DNS providers in a
standardized/agnostic way
Fedora Account System Username: nb

Koji Scratch Build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25162759

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #40 from Alexander Ploumistos  ---
Hi Antonio,

There are these warning messages in Bodhi:

The update can not be pushed: 1 of 1 required tests failed


The failing test is dist.rpmdeplint and this is the explanation:

results:
- arch: x86_64
  item: molsketch-0.5.1-7.fc27
  outcome: FAILED
  scenario: x86_64
  type: koji_build


nothing provides openbabel(x86-32) needed by molsketch-0.5.1-7.fc27.i686
nothing provides openbabel(x86-32) needed by molsketch-0.5.1-7.fc27.i686

It's the same for fc26.

32-bit OpenBabel has been available since last August, so this can't be right.
Also, while the arch is x86_64, the failures concern the i686 packages.

Have I done something wrong, or should I ask about these failures on devel@?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546297] Review Request: python-cloudflare - Python wrapper for the Cloudflare Client API v4

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546297

Itamar Reis Peixoto  changed:

   What|Removed |Added

 CC||ita...@ispbrasil.com.br



--- Comment #7 from Itamar Reis Peixoto  ---
why not building python34-cloudflare for epel7 ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546297] Review Request: python-cloudflare - Python wrapper for the Cloudflare Client API v4

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546297



--- Comment #6 from Fedora Update System  ---
python-cloudflare-2.0.4-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-234443e846

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546297] Review Request: python-cloudflare - Python wrapper for the Cloudflare Client API v4

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546297

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546297] Review Request: python-cloudflare - Python wrapper for the Cloudflare Client API v4

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546297



--- Comment #5 from Fedora Update System  ---
python-cloudflare-2.0.4-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8477d00cfb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546297] Review Request: python-cloudflare - Python wrapper for the Cloudflare Client API v4

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546297



--- Comment #4 from Fedora Update System  ---
python-cloudflare-2.0.4-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-f4325e3efb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545969] Review Request: python-certbot-dns-digitalocean - DigitalOcean DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545969



--- Comment #6 from Fedora Update System  ---
python-certbot-dns-digitalocean-0.21.1-1.fc27 has been submitted as an update
to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-be1e6ba7c5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545969] Review Request: python-certbot-dns-digitalocean - DigitalOcean DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545969



--- Comment #4 from Fedora Update System  ---
python-certbot-dns-digitalocean-0.21.1-1.fc26 has been submitted as an update
to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-11c9d4ea02

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545969] Review Request: python-certbot-dns-digitalocean - DigitalOcean DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545969

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545969] Review Request: python-certbot-dns-digitalocean - DigitalOcean DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545969



--- Comment #5 from Fedora Update System  ---
python-certbot-dns-digitalocean-0.21.1-1.el7 has been submitted as an update to
Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-a0cef0c53f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545349] Review Request: libplacebo - Reusable library for GPU-accelerated video/ image rendering primitives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545349



--- Comment #4 from Nicolas Chauvet (kwizart)  ---
(In reply to Iwicki Artur from comment #2)
> >**libplacebo** is essentially the core rendering algorithms and ideas of 
> >[mpv](https://mpv.io)
> There's markdown in the %description.
I will fix before import. Thx for the notice

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546648] Review Request: perl-IO-Socket-Socks - Provides a way to create socks (4 or 5) client or server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546648

Petr Pisar  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Petr Pisar  ---
URL and Source address are Ok.
Source archive (SHA-256:
37f071a2cf4ba8f090a2297c6482b7a2c509eb52dcd6ce5d8035d4ee2c6824b1) is original.
Ok.
Summary verified from lib/IO/Socket/Socks.pm. Ok.
Description verified from lib/IO/Socket/Socks.pm. Ok.
License verified from lib/IO/Socket/Socks.pm and Makefile.PL. Ok.
No XS code, noarch BuildArch is Ok.
Build-requires are Ok.
All tests pass. Ok.
Tests that use the Internet (SOCKS_SLOW_TESTS) are not executed. Ok.

$ rpmlint perl-IO-Socket-Socks.spec
../SRPMS/perl-IO-Socket-Socks-0.74-1.fc28.src.rpm
../RPMS/noarch/perl-IO-Socket-Socks-0.74-1.fc28.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-IO-Socket-Socks-0.74-1.fc28.noarch.rpm 
drwxr-xr-x2 rootroot0 Feb 19 13:16
/usr/share/doc/perl-IO-Socket-Socks
-rw-r--r--1 rootroot 3279 May  4  2017
/usr/share/doc/perl-IO-Socket-Socks/Changes
-rw-r--r--1 rootroot  240 Oct 15  2016
/usr/share/doc/perl-IO-Socket-Socks/README
-rw-r--r--1 rootroot 7260 Feb 19 13:16
/usr/share/man/man3/IO::Socket::Socks.3pm.gz
drwxr-xr-x2 rootroot0 Feb 19 13:16
/usr/share/perl5/vendor_perl/IO
drwxr-xr-x2 rootroot0 Feb 19 13:16
/usr/share/perl5/vendor_perl/IO/Socket
-rw-r--r--1 rootroot72238 May  4  2017
/usr/share/perl5/vendor_perl/IO/Socket/Socks.pm
File layout and permissions are Ok.

TODO: Consider packaging `examples' subdirectory as a documentation.

$ rpm -q --requires -p
../RPMS/noarch/perl-IO-Socket-Socks-0.74-1.fc28.noarch.rpm |sort -f | uniq -c
  1 perl(:MODULE_COMPAT_5.26.1)
  1 perl(Carp)
  1 perl(constant)
  1 perl(Errno)
  1 perl(Exporter)
  1 perl(IO::Select)
  1 perl(IO::Socket::IP) >= 0.36
  1 perl(overload)
  1 perl(Socket)
  1 perl(strict)
  1 perl(vars)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
TODO: Constrain `perl(constant)' with `>= 1.03' (Makefile.PL:9).
TODO: Constrain `perl(Socket)' with `>= >= 1.94' (Makefile.PL:9).

$ rpm -q --provides -p
../RPMS/noarch/perl-IO-Socket-Socks-0.74-1.fc28.noarch.rpm |sort -f | uniq -c
  1 perl(IO::Socket::Socks) = 0.74
  1 perl(IO::Socket::Socks::Debug)
  1 perl(IO::Socket::Socks::Error)
  1 perl(IO::Socket::Socks::ReadOnlyVar)
  1 perl(IO::Socket::Socks::SocketClassVar)
  1 perl-IO-Socket-Socks = 0.74-1.fc28
Binary provides are Ok.

The package builds in F28
(https://koji.fedoraproject.org/koji/taskinfo?taskID=25158861). Ok.

This package is in line with Fedora and Perl packaging guidelines.

Please consider fixing the `TODO' items before building this package.
Resolution: Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546648] Review Request: perl-IO-Socket-Socks - Provides a way to create socks (4 or 5) client or server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546648

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com
   Assignee|nob...@fedoraproject.org|ppi...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481630] Review Request: virtualbox-guest-additions - VirtualBox Guest Additions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481630



--- Comment #67 from Hans de Goede  ---
Hi,

(In reply to Sergio Monteiro Basto from comment #66)
> (In reply to Hans de Goede from comment #64)
> > (In reply to Sergio Monteiro Basto from comment #63)
> > > But , shared folder will work ? 
> > 
> > See comment 58.
> 
> I do not understood the comment 58 , do we need build vboxsf.ko or not to
> work right now ? 

Right now for rawhide you still need to build vboxsf.ko.

> (In reply to Hans de Goede from comment #65)
> > Ok, I've just imported virtualbox-guest-additions-5.2.6-4 (with one small
> > fix over the last version posted here) and started a build for it for
> > rawhide.
> > 
> > Please disable the guest-additions sub-package in the rpmfusion package.
> 
> In next iteration I will , is not a priority ... , everything still work
> without any problem ...
> 
> > If you want to test this with vboxsf, here is a standalone version of vboxsf
> > which will build against the vboxguest included in the 4.16-rc1+ kernels in
> > rawhide:
> > 
> > https://github.com/jwrdegoede/vboxsf/
> 
> So this code , can be add to VirtualBox-kmodsrc-5.2.x ? to build vboxsf.ko ? 

Yes, with this code you can use the vboxguest which ships with 4.16-rc1+ in
rawhide and build a vboxsf.ko against it.

Note you only need to build vboxsf for rawhide, vboxguest is already there and
should not be replaced.

> But I remember back here because I have others question. We (RPMFusion) also
> support epel7 and I remember to ask if you think have guest-additions on
> epel7 ? and BTW if F27 also will have this package ?

I do not plan to add this package to EPEL7.
I also will not add this package to F27.

> ah (I almost forgot) and I'd like to know , please, if modules still in
> staging or not , I'd like talk with Larry Finger from opensuse and a friend
> which is the package maintainer of Debian and I don't know where the modules
> are, to tell them ... 

The vboxguest driver lives under drivers/virt. vboxvideo is still in
drivers/staging.

Regards,

Hans

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520922] Review Request: extractpdfmark - Extract page mode and named destinations as PDFmark from PDF

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520922

Federico Bruni  changed:

   What|Removed |Added

  Flags|needinfo?(f...@inventati.or |
   |g)  |



--- Comment #16 from Federico Bruni  ---
Sorry for the delay, I was away for a business trip.

I've just committed these changes to the spec file:

```
$ git diff
diff --git a/extractpdfmark.spec b/extractpdfmark.spec
index a5d8f42..d75197c 100644
--- a/extractpdfmark.spec
+++ b/extractpdfmark.spec
@@ -7,7 +7,9 @@ License:GPLv3+
 URL:https://github.com/trueroad/extractpdfmark/
 Source0:   
https://github.com/trueroad/extractpdfmark/releases/download/v%{version}/%{name}-%{version}.tar.gz

-BuildRequires:  automake gettext-devel poppler-devel gcc-c++
+BuildRequires:  automake
+BuildRequires:  gettext-devel
+BuildRequires:  poppler-devel

 %description
 When you create a PDF document using something like a TeX system you may
include
```

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546648] Review Request: perl-IO-Socket-Socks - Provides a way to create socks (4 or 5) client or server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546648

Paul Howarth  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1543336



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546648] Review Request: perl-IO-Socket-Socks - Provides a way to create socks (4 or 5) client or server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546648

Paul Howarth  changed:

   What|Removed |Added

 Blocks||1479864




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1479864
[Bug 1479864] Upgrade perl-Net-SSH-Perl to 2.12
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546648] New: Review Request: perl-IO-Socket-Socks - Provides a way to create socks (4 or 5) client or server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546648

Bug ID: 1546648
   Summary: Review Request: perl-IO-Socket-Socks - Provides a way
to create socks (4 or 5) client or server
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: p...@city-fan.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://subversion.city-fan.org/repos/cfo-repo/perl-IO-Socket-Socks/branches/fedora/perl-IO-Socket-Socks.spec
SRPM URL:
http://www.city-fan.org/~paul/extras/perl-IO-Socket-Socks/perl-IO-Socket-Socks-0.74-1.fc28.src.rpm

Description:
IO::Socket::Socks connects to a SOCKS proxy and tells it to open a connection
to a remote host/port when the object is created. The object you receive can be
used directly as a socket (with IO::Socket interface) for sending and receiving
data to and from the remote host. In addition to creating a socks client, this
module could be used to create a socks server.

Fedora Account System Username: pghmcfc

This package is needed to update perl-Net-SSH-Perl to the current version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543813] Review Request: pwkickstart - generate kickstart passwords

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543813



--- Comment #11 from Fedora Update System  ---
pwkickstart-1.0.2-3.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-3053770bc1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org