[Bug 1546946] Review Request: golang-github-gobuffalo-envy - Makes working with ENV variables in Go trivial
https://bugzilla.redhat.com/show_bug.cgi?id=1546946 Bug 1546946 depends on bug 1546947, which changed state. Bug 1546947 Summary: Review Request: godotenv - A Go port of Ruby's dotenv library https://bugzilla.redhat.com/show_bug.cgi?id=1546947 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546947] Review Request: godotenv - A Go port of Ruby' s dotenv library
https://bugzilla.redhat.com/show_bug.cgi?id=1546947 Athos Ribeiro changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-02-20 21:35:27 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546946] Review Request: golang-github-gobuffalo-envy - Makes working with ENV variables in Go trivial
https://bugzilla.redhat.com/show_bug.cgi?id=1546946 --- Comment #2 from Athos Ribeiro --- Hi Robert, Once again, thanks for the review and all the input! Spec URL: https://athoscr.fedorapeople.org/packaging/golang-github-gobuffalo-envy.spec SRPM URL: https://athoscr.fedorapeople.org/packaging/golang-github-gobuffalo-envy-1.4.0-1.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546947] Review Request: godotenv - A Go port of Ruby' s dotenv library
https://bugzilla.redhat.com/show_bug.cgi?id=1546947 --- Comment #4 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/godotenv -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547180] Review Request: python-jupyterlab-launcher - JupyterLab Launcher
https://bugzilla.redhat.com/show_bug.cgi?id=1547180 --- Comment #3 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-jupyterlab-launcher -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547180] Review Request: python-jupyterlab-launcher - JupyterLab Launcher
https://bugzilla.redhat.com/show_bug.cgi?id=1547180 --- Comment #2 from Miro Hrončok --- (In reply to Robert-André Mauchin from comment #1) > - Why no Python2 package? Because I don't need it. This is a dependency for python-jupyterlab which will be py3 only as well. Adding legacy python subpackages just because we can is not worth it. Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539190] Review Request: golang-github-zyedidia-terminal - Vt10x terminal emulation backend
https://bugzilla.redhat.com/show_bug.cgi?id=1539190 --- Comment #4 from Fedora Update System --- golang-github-zyedidia-terminal-0-0.1.20180126git1760577.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-cbf443fefa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539190] Review Request: golang-github-zyedidia-terminal - Vt10x terminal emulation backend
https://bugzilla.redhat.com/show_bug.cgi?id=1539190 --- Comment #3 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-zyedidia-terminal -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539190] Review Request: golang-github-zyedidia-terminal - Vt10x terminal emulation backend
https://bugzilla.redhat.com/show_bug.cgi?id=1539190 Robert-André Mauchin changed: What|Removed |Added Assignee|nob...@fedoraproject.org|jsmith.fed...@gmail.com --- Comment #2 from Robert-André Mauchin --- Thanks a lot for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539190] Review Request: golang-github-zyedidia-terminal - Vt10x terminal emulation backend
https://bugzilla.redhat.com/show_bug.cgi?id=1539190
Jared Smith changed:
What|Removed |Added
Status|NEW |MODIFIED
CC||jsmith.fed...@gmail.com
Flags||fedora-review+
--- Comment #1 from Jared Smith ---
Package is APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 16 files have unknown license. Detailed
output of licensecheck in
/home/jsmith/Documents/Fedora/Reviews/1539190-golang-github-zyedidia-
terminal/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode, /usr/share/gocode/src/github.com
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/gocode/src/github.com/zyedidia(golang-github-zyedidia-
tcell-devel, golang-github-zyedidia-poller-devel, golang-github-
zyedidia-clipboard-devel, golang-github-zyedidia-glob-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
[Bug 1547064] Review Request: libappindicator-sharp - Application indicators library - C#
https://bugzilla.redhat.com/show_bug.cgi?id=1547064 Tomas Popela changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||libappindicator-sharp-12.10 ||.0-12.el7 Resolution|--- |CURRENTRELEASE Last Closed||2018-02-20 15:24:37 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547064] Review Request: libappindicator-sharp - Application indicators library - C#
https://bugzilla.redhat.com/show_bug.cgi?id=1547064 --- Comment #9 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libappindicator-sharp -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547064] Review Request: libappindicator-sharp - Application indicators library - C#
https://bugzilla.redhat.com/show_bug.cgi?id=1547064 --- Comment #8 from Tomas Popela --- (In reply to Robert-André Mauchin from comment #7) > Ok, package approved. Thank you Robert! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547064] Review Request: libappindicator-sharp - Application indicators library - C#
https://bugzilla.redhat.com/show_bug.cgi?id=1547064 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #7 from Robert-André Mauchin --- Ok, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547180] Review Request: python-jupyterlab-launcher - JupyterLab Launcher
https://bugzilla.redhat.com/show_bug.cgi?id=1547180
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #1 from Robert-André Mauchin ---
- Why no Python2 package?
Package approved
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "BSD (unspecified)", "MIT/X11 (BSD like)",
"Unknown or generated". 20 files have unknown license. Detailed output
of licensecheck in /home/bob/packaging/review/python-jupyterlab-
launcher/review-python-jupyterlab-launcher/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[Bug 1547064] Review Request: libappindicator-sharp - Application indicators library - C#
https://bugzilla.redhat.com/show_bug.cgi?id=1547064 --- Comment #6 from Tomas Popela --- New version is available on Spec URL: https://tpopela.fedorapeople.org/libappindicator-sharp.spec SRPM URL: https://tpopela.fedorapeople.org/libappindicator-sharp-12.10.0-12.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547064] Review Request: libappindicator-sharp - Application indicators library - C#
https://bugzilla.redhat.com/show_bug.cgi?id=1547064 --- Comment #5 from Tomas Popela --- (In reply to Robert-André Mauchin from comment #4) > - A comment explaining the patch purpose would be nice. Honestly I don't know why it's there I assume that it's because the original install path doesn't follow some Fedora rule. The patch was in the package from the beginning. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547064] Review Request: libappindicator-sharp - Application indicators library - C#
https://bugzilla.redhat.com/show_bug.cgi?id=1547064
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #4 from Robert-André Mauchin ---
- License files should be installed with %license, not %doc:
%files
%doc AUTHORS README
%license COPYING COPYING.LGPL.2.1
- A comment explaining the patch purpose would be nice.
- Don't mix spaces and tabs, use one or another:
libappindicator-sharp.src:31: W: mixed-use-of-spaces-and-tabs (spaces: line 31,
tab: line 1)
ExclusiveArch:%{mono_arches}
- libappindicator-sharp-debuginfo.x86_64: E: empty-debuginfo-package
See https://fedoraproject.org/wiki/Packaging:Mono#Empty_debuginfo
%global debug_package %{nil}
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file COPYING is not marked as %license
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "FSF All Permissive", "GPL (v2 or later)", "Unknown or
generated", "MIT/X11 (BSD like)", "GPL (v2 or later) (with incorrect
FSF address)", "GPL (v3)". 119 files have unknown license. Detailed
output of licensecheck in /home/bob/packaging/review/libappindicator-
sharp/review-libappindicator-sharp/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the
[Bug 1539189] Review Request: golang-github-zyedidia-pty - PTY interface for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1539189 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- golang-github-zyedidia-pty-0-0.1.20180126git3036466.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-9bd59bc220 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546534] Review Request: golang-github-paulrosania-go-charset - Character set conversion for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1546534 --- Comment #6 from Fedora Update System --- golang-github-paulrosania-go-charset-0-0.1.20151028git621bb39.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-77ac44a05d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546648] Review Request: perl-IO-Socket-Socks - Provides a way to create socks (4 or 5) client or server
https://bugzilla.redhat.com/show_bug.cgi?id=1546648 --- Comment #8 from Fedora Update System --- perl-IO-Socket-Socks-0.74-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f105aefd30 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1544384] Review Request: tcl-thread - Tcl Thread extension
https://bugzilla.redhat.com/show_bug.cgi?id=1544384 --- Comment #9 from Fedora Update System --- tcl-thread-2.8.2-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-91e44ef9cc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546946] Review Request: golang-github-gobuffalo-envy - Makes working with ENV variables in Go trivial
https://bugzilla.redhat.com/show_bug.cgi?id=1546946
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
- Version 1.4.0 has been release (4 hours ago!)
%global commit 50fabbbaf1e65fc9b739f37a00590c396485d84d
%global shortcommit %(c=%{commit}; echo ${c:0:7})
Name: golang-%{provider}-%{project}-%{repo}
Version:1.4.0
And in %changelog:
* Tue Feb 20 2018 Athos Ribeiro - 1.4.0-1
- Tests fail:
+ go test -buildmode pie -compiler gc -ldflags ' -extldflags '\''-Wl,-z,relro
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld '\''' github.com/gobuffalo/envy
--- FAIL: Test_LoadDefaultEnvWhenNoArgsPassed (0.00s)
assertions.go:237:
Error Trace:envy_test.go:98
envy.go:148
envy_test.go:96
Error:Received unexpected error open .env: no such file or
directory
--- FAIL: Test_KeepEnvWhenFileInListFails (0.00s)
assertions.go:237:
Error Trace:envy_test.go:143
envy.go:148
envy_test.go:140
Error:Not equal: "none" (expected)
!= "FAILED" (actual)
--- FAIL: Test_KeepEnvWhenSecondLoadFails (0.00s)
assertions.go:237:
Error Trace:envy_test.go:152
envy.go:148
envy_test.go:150
Error:Received unexpected error stat .env: no such file or
directory
--- FAIL: Test_StopLoadingWhenFileInListFails (0.00s)
assertions.go:237:
Error Trace:envy_test.go:168
envy.go:148
envy_test.go:165
Error:Not equal: "none" (expected)
!= "FAILED" (actual)
FAIL
FAILgithub.com/gobuffalo/envy0.004s
After digging around, it seems you're not installing the test file .env
which is in the root directory. Fix it with:
# install data used for tests
cp -pav .env %{buildroot}/%{gopath}/src/%{import_path}/
echo "%%{gopath}/src/%%{import_path}/.env" >> unit-test-devel.file-list
cp -pav ./test_env %{buildroot}/%{gopath}/src/%{import_path}/
echo "%%{gopath}/src/%%{import_path}/test_env" >> unit-test-devel.file-list
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 8 files have
unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/golang-github-gobuffalo-envy/review-golang-
github-gobuffalo-envy/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode, /usr/share/gocode/src/github.com
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one suppor
[Bug 1546534] Review Request: golang-github-paulrosania-go-charset - Character set conversion for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1546534 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System --- golang-github-paulrosania-go-charset-0-0.1.20151028git621bb39.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-32e5246061 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547122] Review Request: python-certbot-dns-dnsimple - DNSimple DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547122 --- Comment #5 from Fedora Update System --- python-certbot-dns-dnsimple-0.21.1-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-4641c70a87 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546648] Review Request: perl-IO-Socket-Socks - Provides a way to create socks (4 or 5) client or server
https://bugzilla.redhat.com/show_bug.cgi?id=1546648 --- Comment #7 from Fedora Update System --- perl-IO-Socket-Socks-0.74-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-3caef3d480 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546648] Review Request: perl-IO-Socket-Socks - Provides a way to create socks (4 or 5) client or server
https://bugzilla.redhat.com/show_bug.cgi?id=1546648 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- perl-IO-Socket-Socks-0.74-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-47c3d57d25 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546851] Review Request: python-certbot-dns-dnsmadeeasy - DNS Made Easy DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1546851 --- Comment #4 from Fedora Update System --- python-certbot-dns-dnsmadeeasy-0.21.1-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-5371e2ee39 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547135] Review Request: python-certbot-dns-nsone - NS1 DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547135 --- Comment #4 from Fedora Update System --- python-certbot-dns-nsone-0.21.1-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-82348b6eb5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547122] Review Request: python-certbot-dns-dnsimple - DNSimple DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547122 --- Comment #4 from Fedora Update System --- python-certbot-dns-dnsimple-0.21.1-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-fe9ffa2aff -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547135] Review Request: python-certbot-dns-nsone - NS1 DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547135 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547135] Review Request: python-certbot-dns-nsone - NS1 DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547135 --- Comment #3 from Fedora Update System --- python-certbot-dns-nsone-0.21.1-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-5b4536078b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546851] Review Request: python-certbot-dns-dnsmadeeasy - DNS Made Easy DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1546851 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546851] Review Request: python-certbot-dns-dnsmadeeasy - DNS Made Easy DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1546851 --- Comment #3 from Fedora Update System --- python-certbot-dns-dnsmadeeasy-0.21.1-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-9507cac181 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547122] Review Request: python-certbot-dns-dnsimple - DNSimple DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547122 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547122] Review Request: python-certbot-dns-dnsimple - DNSimple DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547122 --- Comment #3 from Fedora Update System --- python-certbot-dns-dnsimple-0.21.1-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-656ca83273 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546772] Review Request: python-dns-lexicon - Manipulate DNS records on various DNS providers in a standardized /agnostic way
https://bugzilla.redhat.com/show_bug.cgi?id=1546772 --- Comment #8 from Fedora Update System --- python-dns-lexicon-2.1.19-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1545969] Review Request: python-certbot-dns-digitalocean - DigitalOcean DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1545969 --- Comment #12 from Fedora Update System --- python-certbot-dns-digitalocean-0.21.1-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546297] Review Request: python-cloudflare - Python wrapper for the Cloudflare Client API v4
https://bugzilla.redhat.com/show_bug.cgi?id=1546297 --- Comment #13 from Fedora Update System --- python-cloudflare-2.0.4-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1545951] Review Request: python-tldextract - Accurately separate the TLD from the registered domain and subdomains of a URL
https://bugzilla.redhat.com/show_bug.cgi?id=1545951 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-20 12:16:43 --- Comment #14 from Fedora Update System --- python-tldextract-2.2.0-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1545347] Review Request: microdns - Minimal mDNS resolver and announcer library
https://bugzilla.redhat.com/show_bug.cgi?id=1545347 --- Comment #11 from Fedora Update System --- microdns-0.0.8-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1519323] Review request: qesteidutil - Estonian ID card utility
https://bugzilla.redhat.com/show_bug.cgi?id=1519323 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-20 12:16:00 --- Comment #17 from Fedora Update System --- qesteidutil-3.12.10-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542807] Review Request: gap-pkg-toric - Computations with toric varieties in GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1542807 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-20 12:13:42 --- Comment #6 from Fedora Update System --- gap-pkg-toric-1.9.4-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1519749] Review request: qdigidoc - Estonian digital signature application
https://bugzilla.redhat.com/show_bug.cgi?id=1519749 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-20 12:14:03 --- Comment #11 from Fedora Update System --- qdigidoc-3.13.5-3.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1535207] Review Request: ravada - Remote Virtual Desktops Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1535207 --- Comment #15 from Fedora Update System --- ravada-0.2.13-0.1.20180117gitf70dfbf.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1509119] Review Request: php-gecko-packages-gecko-php-unit3 - Additional PHPUnit asserts and constraints
https://bugzilla.redhat.com/show_bug.cgi?id=1509119 --- Comment #10 from Fedora Update System --- php-gecko-packages-gecko-php-unit3-3.1.1-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1519719] Review Request: php-phpunit-mock-objects5 - Mock Object library for PHPUnit
https://bugzilla.redhat.com/show_bug.cgi?id=1519719 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-20 12:13:09 --- Comment #12 from Fedora Update System --- php-phpunit-mock-objects5-5.0.6-3.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539554] Review Request: php-phpunit-php-invoker2 - Invoke callables with a timeout
https://bugzilla.redhat.com/show_bug.cgi?id=1539554 Bug 1539554 depends on bug 1519719, which changed state. Bug 1519719 Summary: Review Request: php-phpunit-mock-objects5 - Mock Object library for PHPUnit https://bugzilla.redhat.com/show_bug.cgi?id=1519719 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539554] Review Request: php-phpunit-php-invoker2 - Invoke callables with a timeout
https://bugzilla.redhat.com/show_bug.cgi?id=1539554 Bug 1539554 depends on bug 1509856, which changed state. Bug 1509856 Summary: Review Request: php-phpunit-php-token-stream2 - Wrapper around PHP tokenizer extension https://bugzilla.redhat.com/show_bug.cgi?id=1509856 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1509856] Review Request: php-phpunit-php-token-stream2 - Wrapper around PHP tokenizer extension
https://bugzilla.redhat.com/show_bug.cgi?id=1509856 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-20 12:12:52 --- Comment #9 from Fedora Update System --- php-phpunit-PHP-TokenStream-1.4.12-1.fc27, php-phpunit-php-token-stream2-2.0.2-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1541587] Review Request: python-kiwisolver - A fast implementation of the Cassowary constraint solver
https://bugzilla.redhat.com/show_bug.cgi?id=1541587 --- Comment #13 from Fedora Update System --- python-kiwisolver-1.0.1-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1514274] Review Request: twitter-twemoji-fonts - Twitter Emoji for everyone
https://bugzilla.redhat.com/show_bug.cgi?id=1514274 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-20 12:12:57 --- Comment #35 from Fedora Update System --- twitter-twemoji-fonts-2.4.0-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1513669] Review Request: php-phpmailer6 - Full-featured email creation and transfer class for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1513669 --- Comment #13 from Fedora Update System --- php-phpmailer6-6.0.3-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539366] Review Request: linux-driver-management - Generic driver management framework for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1539366 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-20 12:11:41 --- Comment #11 from Fedora Update System --- linux-driver-management-1.0.3-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546947] Review Request: godotenv - A Go port of Ruby' s dotenv library
https://bugzilla.redhat.com/show_bug.cgi?id=1546947 --- Comment #3 from Athos Ribeiro --- Hi Robert, I will fix it before importing. Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546947] Review Request: godotenv - A Go port of Ruby' s dotenv library
https://bugzilla.redhat.com/show_bug.cgi?id=1546947
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #2 from Robert-André Mauchin ---
- godotenv.x86_64: W: incoherent-version-in-changelog 1.2.0-1 ['1.2-1.fc28',
'1.2-1']
Fix it in the Version: field:
Version:1.2.0
Package otherwise approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 11 files have
unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/godotenv/review-godotenv/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode, /usr/share/gocode/src/github.com
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
github-joho-godotenv-devel , golang-github-joho-godotenv-unit-test-
devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
[Bug 1546801] Review Request: argparse-manpage - Build manual page from Python ArgumentParser object
https://bugzilla.redhat.com/show_bug.cgi?id=1546801 --- Comment #3 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/argparse-manpage -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546801] Review Request: argparse-manpage - Build manual page from Python ArgumentParser object
https://bugzilla.redhat.com/show_bug.cgi?id=1546801 --- Comment #2 from Pavel Raiskup --- Thanks for the quick turn-around! https://pagure.io/releng/fedora-scm-requests/issue/4647 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547180] New: Review Request: python-jupyterlab-launcher - JupyterLab Launcher
https://bugzilla.redhat.com/show_bug.cgi?id=1547180 Bug ID: 1547180 Summary: Review Request: python-jupyterlab-launcher - JupyterLab Launcher Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mhron...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-jupyterlab-launcher.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-jupyterlab-launcher-0.10.4-1.fc27.src.rpm Description: This package is used to launch an application built using JupyterLab. Fedora Account System Username: churchyard -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546772] Review Request: python-dns-lexicon - Manipulate DNS records on various DNS providers in a standardized /agnostic way
https://bugzilla.redhat.com/show_bug.cgi?id=1546772 --- Comment #7 from Fedora Update System --- python-dns-lexicon-2.1.19-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546297] Review Request: python-cloudflare - Python wrapper for the Cloudflare Client API v4
https://bugzilla.redhat.com/show_bug.cgi?id=1546297 --- Comment #12 from Fedora Update System --- python-cloudflare-2.0.4-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1545951] Review Request: python-tldextract - Accurately separate the TLD from the registered domain and subdomains of a URL
https://bugzilla.redhat.com/show_bug.cgi?id=1545951 --- Comment #13 from Fedora Update System --- python-tldextract-2.2.0-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1545347] Review Request: microdns - Minimal mDNS resolver and announcer library
https://bugzilla.redhat.com/show_bug.cgi?id=1545347 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-20 11:38:58 --- Comment #10 from Fedora Update System --- microdns-0.0.8-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1545969] Review Request: python-certbot-dns-digitalocean - DigitalOcean DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1545969 --- Comment #11 from Fedora Update System --- python-certbot-dns-digitalocean-0.21.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1525698] Review Request: jid - Json Incremental Digger
https://bugzilla.redhat.com/show_bug.cgi?id=1525698 Bug 1525698 depends on bug 1525694, which changed state. Bug 1525694 Summary: Review Request: golang-github-bitly-go-simplejson - Go package to interact with arbitrary JSON https://bugzilla.redhat.com/show_bug.cgi?id=1525694 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1525694] Review Request: golang-github-bitly-go-simplejson - Go package to interact with arbitrary JSON
https://bugzilla.redhat.com/show_bug.cgi?id=1525694 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2018-01-16 12:15:08 |2018-02-20 11:38:38 --- Comment #8 from Fedora Update System --- golang-github-bitly-go-simplejson-0.5.0-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1525696] Review Request: golang-github-nwidger-jsoncolor - Colorized JSON output for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1525696 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2018-01-16 12:11:09 |2018-02-20 11:38:34 --- Comment #8 from Fedora Update System --- golang-github-nwidger-jsoncolor-0-0.2.20170215git75a6de4.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547135] Review Request: python-certbot-dns-nsone - NS1 DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547135 --- Comment #2 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-certbot-dns-nsone -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1525698] Review Request: jid - Json Incremental Digger
https://bugzilla.redhat.com/show_bug.cgi?id=1525698 Bug 1525698 depends on bug 1525696, which changed state. Bug 1525696 Summary: Review Request: golang-github-nwidger-jsoncolor - Colorized JSON output for Go https://bugzilla.redhat.com/show_bug.cgi?id=1525696 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1542646] Review Request: patool - Portable command line archive file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1542646 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-20 11:38:31 --- Comment #12 from Fedora Update System --- patool-1.12-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539209] Review Request: ddgr - DuckDuckGo from the terminal
https://bugzilla.redhat.com/show_bug.cgi?id=1539209 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-20 11:38:29 --- Comment #10 from Fedora Update System --- ddgr-1.2-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546835] Review Request: python-urllib-gssapi - A urllib/ urllib2 backend for GSSAPI/SPNEGO
https://bugzilla.redhat.com/show_bug.cgi?id=1546835
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #1 from Robert-André Mauchin ---
- You must install the text of the license in %files:
%files -n python2-%{sname}
%doc README.md
%license COPYING
%{python2_sitelib}/%{s_name}*
%files -n python3-%{sname}
%doc README.md
%license COPYING
%{python3_sitelib}/%{s_name}*
- Remove the shebang from:
python2-urllib-gssapi.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/urllib_gssapi/__init__.py 644 /usr/bin/python
python3-urllib-gssapi.noarch: E: non-executable-script
/usr/lib/python3.6/site-packages/urllib_gssapi/__init__.py 644 /usr/bin/python
You can probably do it in %prep with:
sed -i '1{/^#!/d}' lib/urllib_gssapi/__init__.py
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Apache (v2.0)", "*No copyright* Apache", "Unknown or
generated". 7 files have unknown license. Detailed output of
licensecheck in /home/bob/packaging/review/python-urllib-gssapi
/review-python-urllib-gssapi/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license
[Bug 1535207] Review Request: ravada - Remote Virtual Desktops Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1535207 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-20 11:37:19 --- Comment #14 from Fedora Update System --- ravada-0.2.13-0.1.20180117gitf70dfbf.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1513669] Review Request: php-phpmailer6 - Full-featured email creation and transfer class for PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1513669 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-20 11:37:04 --- Comment #12 from Fedora Update System --- php-phpmailer6-6.0.3-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1541587] Review Request: python-kiwisolver - A fast implementation of the Cassowary constraint solver
https://bugzilla.redhat.com/show_bug.cgi?id=1541587 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-20 11:37:23 --- Comment #12 from Fedora Update System --- python-kiwisolver-1.0.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1509119] Review Request: php-gecko-packages-gecko-php-unit3 - Additional PHPUnit asserts and constraints
https://bugzilla.redhat.com/show_bug.cgi?id=1509119 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-20 11:37:01 --- Comment #9 from Fedora Update System --- php-gecko-packages-gecko-php-unit3-3.1.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1545969] Review Request: python-certbot-dns-digitalocean - DigitalOcean DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1545969 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-20 11:24:40 --- Comment #10 from Fedora Update System --- python-certbot-dns-digitalocean-0.21.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546297] Review Request: python-cloudflare - Python wrapper for the Cloudflare Client API v4
https://bugzilla.redhat.com/show_bug.cgi?id=1546297 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-20 11:24:43 --- Comment #11 from Fedora Update System --- python-cloudflare-2.0.4-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546772] Review Request: python-dns-lexicon - Manipulate DNS records on various DNS providers in a standardized /agnostic way
https://bugzilla.redhat.com/show_bug.cgi?id=1546772 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2018-02-20 11:24:46 --- Comment #6 from Fedora Update System --- python-dns-lexicon-2.1.19-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1545951] Review Request: python-tldextract - Accurately separate the TLD from the registered domain and subdomains of a URL
https://bugzilla.redhat.com/show_bug.cgi?id=1545951 --- Comment #12 from Fedora Update System --- python-tldextract-2.2.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1540749] Review Request: python3-pyusb - Python 3 bindings for libusb
https://bugzilla.redhat.com/show_bug.cgi?id=1540749 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-02-20 11:24:16 --- Comment #7 from Fedora Update System --- python3-pyusb-1.0.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547122] Review Request: python-certbot-dns-dnsimple - DNSimple DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547122 --- Comment #2 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-certbot-dns-dnsimple -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546851] Review Request: python-certbot-dns-dnsmadeeasy - DNS Made Easy DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1546851 --- Comment #2 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-certbot-dns-dnsmadeeasy -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547135] Review Request: python-certbot-dns-nsone - NS1 DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547135 l...@onesimussystems.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from l...@onesimussystems.com --- LGTM: Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546801] Review Request: argparse-manpage - Build manual page from Python ArgumentParser object
https://bugzilla.redhat.com/show_bug.cgi?id=1546801
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #1 from Robert-André Mauchin ---
Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later)", "Unknown or generated", "*No copyright*
Apache (v2.0)". 38 files have unknown license. Detailed output of
licensecheck in /home/bob/packaging/review/argparse-manpage/review-
argparse-manpage/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
-argparse-manpage , python3-argparse-manpage
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages
[Bug 1547135] Review Request: python-certbot-dns-nsone - NS1 DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547135 l...@onesimussystems.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||l...@onesimussystems.com Assignee|nob...@fedoraproject.org|l...@onesimussystems.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1532042] Review Request: compton - Compositor for X11
https://bugzilla.redhat.com/show_bug.cgi?id=1532042
Jaroslav Škarvada changed:
What|Removed |Added
CC||jskar...@redhat.com
--- Comment #16 from Jaroslav Škarvada ---
The versioning is still wrong, see [1] and [2] for details. It should be:
Version: 0.1
Release: 0.1.beta3%{?dist}
And you should fix Source0 tag and add '-n %{name}-%{version}_beta3' after the
autosetup.
Of course you can use macros, e.g.:
%global ver 0.1
%global prever beta3
Version: %{ver}
Release: 0.1%{?prever:.%{prever}}%{?dist}
...
Source0:
https://github.com/AxelSilverdew/compton/archive/v%{version}%{?prever:_%{prever}}.tar.gz#/%{name}-%{version}%{?prever:_%{prever}}.tar.gz
...
%autosetup -n %{name}-%{version}%{?prever:_%{prever}}
Also note the #/ part in Source0, it's to give the resulting archive proper
name, it's described in [3].
[1] https://fedoraproject.org/wiki/Packaging:Versioning#Prerelease_versions
[2] https://fedoraproject.org/wiki/Package_Versioning_Examples
[3] https://fedoraproject.org/wiki/Packaging:SourceURL#Troublesome_URLs
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547122] Review Request: python-certbot-dns-dnsimple - DNSimple DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547122 l...@onesimussystems.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from l...@onesimussystems.com --- LGTM: Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547122] Review Request: python-certbot-dns-dnsimple - DNSimple DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547122 l...@onesimussystems.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||l...@onesimussystems.com Assignee|nob...@fedoraproject.org|l...@onesimussystems.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1546851] Review Request: python-certbot-dns-dnsmadeeasy - DNS Made Easy DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1546851 l...@onesimussystems.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from l...@onesimussystems.com --- LGTM: Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547052] Review Request: perl-File-Map - Memory mapping made simple and safe
https://bugzilla.redhat.com/show_bug.cgi?id=1547052 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |DUPLICATE Last Closed||2018-02-20 10:23:14 --- Comment #2 from Petr Pisar --- The package actually already exists. I had a type in repoquery and probably in Bugzilla query too. I'm sorry for bothering you. *** This bug has been marked as a duplicate of bug 641341 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 641341] Review Request: perl-File-Map - Memory mapping made simple and safe
https://bugzilla.redhat.com/show_bug.cgi?id=641341 --- Comment #10 from Petr Pisar --- *** Bug 1547052 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547135] New: Review Request: python-certbot-dns-nsone - NS1 DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547135 Bug ID: 1547135 Summary: Review Request: python-certbot-dns-nsone - NS1 DNS Authenticator plugin for Certbot Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: n...@fedoraproject.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://nb.fedorapeople.org/python-certbot-dns-nsone.spec SRPM URL: https://nb.fedorapeople.org/python-certbot-dns-nsone-0.21.1-1.fc27.src.rpm Description: NS1 DNS Authenticator plugin for Certbot Fedora Account System Username: nb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1441023] Review Request: python-fontmake - Compile fonts from sources to binary
https://bugzilla.redhat.com/show_bug.cgi?id=1441023 --- Comment #7 from Shawn Starr --- python-booleanoperations is being reviewed, this will become unblocked and I will review latest .spec provided. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547052] Review Request: perl-File-Map - Memory mapping made simple and safe
https://bugzilla.redhat.com/show_bug.cgi?id=1547052 Jitka Plesnikova changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Jitka Plesnikova --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok $ rpm -qp --requires perl-File-Map-0.65-1.fc28.x86_64.rpm | sort | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libperl.so.5.26()(64bit) 1 libpthread.so.0()(64bit) 1 libpthread.so.0(GLIBC_2.2.5)(64bit) 1 libpthread.so.0(GLIBC_2.3.2)(64bit) 1 perl(Carp) 1 perl(:MODULE_COMPAT_5.26.1) 1 perl(PerlIO::Layers) 1 perl(strict) 1 perl(Sub::Exporter::Progressive) >= 0.001005 1 perl(subs) 1 perl(:VERSION) >= 5.8.0 1 perl(:VERSION) >= 5.8.1 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -qp --provides perl-File-Map-0.65-1.fc28.x86_64.rpm | sort | uniq -c 1 perl(File::Map) = 0.65 1 perl-File-Map = 0.65-1.fc28 1 perl-File-Map(x86-64) = 0.65-1.fc28 Binary provides are Ok. $ rpmlint ./perl-File-Map* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok The package looks good. Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547122] New: Review Request: python-certbot-dns-dnsimple - DNSimple DNS Authenticator plugin for Certbot
https://bugzilla.redhat.com/show_bug.cgi?id=1547122 Bug ID: 1547122 Summary: Review Request: python-certbot-dns-dnsimple - DNSimple DNS Authenticator plugin for Certbot Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: n...@fedoraproject.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://nb.fedorapeople.org/python-certbot-dns-dnsimple.spec SRPM URL: https://nb.fedorapeople.org/python-certbot-dns-dnsimple-0.21.1-1.fc27.src.rpm Description: DNSimple DNS Authenticator plugin for Certbot Fedora Account System Username: nb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547064] Review Request: libappindicator-sharp - Application indicators library - C#
https://bugzilla.redhat.com/show_bug.cgi?id=1547064 --- Comment #3 from Tomas Popela --- Also I should note that the libappindicator-sharp(-devel) does not depend on libappindicator at all - see https://koji.fedoraproject.org/koji/rpminfo?rpmID=8061410 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1440992] Review Request: python-booleanoperations - Boolean operations on paths
https://bugzilla.redhat.com/show_bug.cgi?id=1440992 --- Comment #13 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-booleanoperations -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547064] Review Request: libappindicator-sharp - Application indicators library - C#
https://bugzilla.redhat.com/show_bug.cgi?id=1547064 --- Comment #2 from Tomas Popela --- (In reply to Igor Gnatenko from comment #1) > How do you intend to keep it in sync with original package and how will you > ensure that libraries are ABI compatible (the one you remove in here and > system-wide version)? Both will be maintained by the same person (me). I can add some warning/note to the SPEC file for readers.. I don't see any other easy way to do it.. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1547064] Review Request: libappindicator-sharp - Application indicators library - C#
https://bugzilla.redhat.com/show_bug.cgi?id=1547064 --- Comment #1 from Igor Gnatenko --- How do you intend to keep it in sync with original package and how will you ensure that libraries are ABI compatible (the one you remove in here and system-wide version)? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
