[Bug 1552450] New: Review Request: php-samyoul-u2f-php-server - Server side handling class for FIDO U2F registration and authentication

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552450

Bug ID: 1552450
   Summary: Review Request: php-samyoul-u2f-php-server - Server
side handling class for FIDO U2F registration and
authentication
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fed...@famillecollet.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://git.remirepo.net/cgit/rpms/php/samyoul/php-samyoul-u2f-php-server.git/plain/php-samyoul-u2f-php-server.spec?id=694fbfe105d27d7e78c0550288b13679db291d28
SRPM URL:
http://rpms.remirepo.net/SRPMS/php-samyoul-u2f-php-server-1.1.3-1.remi.src.rpm

Description: 
Server-side handling of FIDO U2F registration and authentication for PHP.

Securing your online accounts and doing your bit to protect your data is
extremely important and increasingly more so as hackers get more sophisticated.
FIDO's U2F enables you to add a simple unobtrusive method of 2nd factor
authentication, allowing users of your service and/or application to link
a hardware key to their account.



Fedora Account System Username: remi


New optional dependency of upcoming phpMyAdmin 4.8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #84 from Fabio Massimo Di Nitto  ---
(In reply to Jan Pokorný from comment #83)

> There's a misunderstanding, "%files -n libknet1-devel" comment should
> stay where it was in 1.1.4.
> 
> I was asking for a new one to explain the interim character of extra
> treatment of debug packages that shouldn't have been introduced in
> Fedora context in the first place.

this is already addressed in comment #80

> 
> * * *
> 
> re [comment 77], I am not familiar with how the test suite is run
> for kronosnet, an example command would be "make check".
> Nice-to-have category, though, the comment already explains why it
> is not so straightforward in this case to run the tests.

executing the test is straight forward make check, but we comment it out for
safety.

> 
> * * *
> 
> Thanks for dealing with lz4 issues.
> 
> Regarding "pkgconfig(openssl)" expression of dependencies, yes, they can
> be versioned as well and/or can be combined with "Suggests" to prioritize
> particular underlying package name should the conflict on such virtual
> provides arise:
> 
> https://fedoraproject.org/wiki/Packaging:WeakDependencies#Real_life_example
> 
> Depending on how compat packages are structured, the same "satisfied by
> more packages" situation could occur also with the previous cryptical
> select-by-header-file approach, so there's effectively no regression
> in this comparison.

We will just switch back to BuildRequires: package-name.

In context, upstream is also moving away from file based dependencies.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #83 from Jan Pokorný  ---
[the review shifts behind my back, not keen on fighting the mills,
I am not an unprofessional rational-processes-bending person, just
my responses and thank you for your work so far]

There's a misunderstanding, "%files -n libknet1-devel" comment should
stay where it was in 1.1.4.

I was asking for a new one to explain the interim character of extra
treatment of debug packages that shouldn't have been introduced in
Fedora context in the first place.

* * *

re [comment 77], I am not familiar with how the test suite is run
for kronosnet, an example command would be "make check".
Nice-to-have category, though, the comment already explains why it
is not so straightforward in this case to run the tests.

* * *

Thanks for dealing with lz4 issues.

Regarding "pkgconfig(openssl)" expression of dependencies, yes, they can
be versioned as well and/or can be combined with "Suggests" to prioritize
particular underlying package name should the conflict on such virtual
provides arise:

https://fedoraproject.org/wiki/Packaging:WeakDependencies#Real_life_example

Depending on how compat packages are structured, the same "satisfied by
more packages" situation could occur also with the previous cryptical
select-by-header-file approach, so there's effectively no regression
in this comparison.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552442] New: Review Request: php-pragmarx-google2fa - Google Two-Factor Authentication for PHP Package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552442

Bug ID: 1552442
   Summary: Review Request: php-pragmarx-google2fa - Google
Two-Factor Authentication for PHP Package
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fed...@famillecollet.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://git.remirepo.net/cgit/rpms/php/pragmarx/php-pragmarx-google2fa.git/plain/php-pragmarx-google2fa.spec?id=6931f5525a306793497db6078222dbaeee841184
SRPM URL: http://rpms.remirepo.net/SRPMS/php-componere-2.1.2-1.remi.src.rpm

Description: 
Google2FA is a PHP implementation of the Google Two-Factor Authentication
Module, supporting the HMAC-Based One-time Password (HOTP) algorithm
specified in RFC 4226 and the Time-based One-time Password (TOTP) algorithm
specified in RFC 6238.


Fedora Account System Username: remi


New optional dependency of upcoming phpMyAdmin 4.8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #82 from digimer  ---
Thanks, Remi. 

To add a reference; The rhbz related to the -6 change to 'BuildRequire' is
https://bugzilla.redhat.com/show_bug.cgi?id=1552431.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487067



--- Comment #35 from Benjamin Kircher  ---
(In reply to Thomas Moschny from comment #32)
> Benjamin, as said earlier, I can co-maintain the package, if you want.

Of course. Any advice and help is greatly appreciated. I added you (thm) as
admin to the repo on src.fedoraproject.org. If there is anything else I need to
do, please let me know.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103

Remi Collet  changed:

   What|Removed |Added

 CC||fed...@famillecollet.com



--- Comment #81 from Remi Collet  ---
(In reply to digimer from comment #80)

> As an aside for later; When talking to people on #fedora-devel, it was
> recommended *not* to use 'BuildRequires: pkgconfig(x)', despite the package
> guidelines recommending it, as it is more ambiguous. The example given was:

To be clearer, I want to share that pkgconfig(xx) dependency have issues,
probably the reason why Guidelines only only states a "SHOULD", and thus
xx-devel is a usual workaround (why may have other issues).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #80 from digimer  ---
Fixed comments.

As an aside for later; When talking to people on #fedora-devel, it was
recommended *not* to use 'BuildRequires: pkgconfig(x)', despite the package
guidelines recommending it, as it is more ambiguous. The example given was:


issue occurs when various providers exists, ex: pkgconfig(openssl) mays pull
openssl-devel or compat-openssl10-devel (the second being a terrible choice)


I don't want to hold up the approval process, but I wanted to bring this up as
a possible change later. Thoughts?


New .spec and srpm:
https://www.alteeve.com/an-repo/files/packages/kronosnet.spec.1.1-7
https://www.alteeve.com/an-repo/files/packages/kronosnet-1.1-7.fc27.src.rpm

f26:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25535007

f27:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25535014

f28:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25535022

rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25535030

epel7:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25535038


Diff from 1.1-6:

--- kronosnet.spec.1.1-62018-03-07 01:19:35.321125418 -0500
+++ kronosnet.spec.1.1-72018-03-07 01:50:40.831722937 -0500
@@ -70,7 +70,7 @@
 Name: kronosnet
 Summary: Multipoint-to-Multipoint VPN daemon
 Version: 1.1
-Release: 6%{?dist}
+Release: 7%{?dist}
 License: GPLv2+ and LGPLv2+
 URL: http://www.kronosnet.org
 Source0: http://www.kronosnet.org/releases/kronosnet-%{version}.tar.gz
@@ -310,6 +310,13 @@
 Please refer to the not-yet-existing documentation for further
 information. 

+# libknet.pc leading to pkgconfig(libknet) automatic virtual provides,
+# like other files, is not explicitly versioned in the name like the
+# subpackages are -- intention of doing so for subpackage names is
+# to ease the cross-checking the compatibility of the remote clients
+# interchanging data using this network communication library, as
+# the number denotes the protocol version (providing multiple
+# protocol versions in parallel is not planned).
 %files -n libknet1-devel
 %{_libdir}/libknet.so
 %{_includedir}/libknet.h
@@ -458,17 +465,15 @@
 %files -n libknet1-plugins-all

 %if %{with rpmdebuginfo}
-# libknet.pc leading to pkgconfig(libknet) automatic virtual provides,
-# like other files, is not explicitly versioned in the name like the
-# subpackages are -- intention of doing so for subpackage names is
-# to ease the cross-checking the compatibility of the remote clients
-# interchanging data using this network communication library, as
-# the number denotes the protocol version (providing multiple
-# protocol versions in parallel is not planned).
+# This is left over from upstream.
 %debug_package
 %endif

 %changelog
+* Wed Mar 07 2018 Madison Kelly  - 1.1-7
+- Moved the comment back above '%%files -n libknet1-devel'.
+- Added comment to '%%debug_package'.
+
 * Wed Mar 07 2018 Madison Kelly  - 1.1-6
 - Added a version requirement to lz4 to deal with koji pulling in the
   wrong package.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #79 from digimer  ---
I applied the changes and hit an odd build error against just epel7 on x86_64
pulling in an unexpected RPM on koji. Bumped again from 1.1-5 to -6 to add a
version restriction to deal with it. Diff against -4 to -6 below.

New .spec and srpm:
https://www.alteeve.com/an-repo/files/packages/kronosnet.spec.1.1-6
https://www.alteeve.com/an-repo/files/packages/kronosnet-1.1-6.fc27.src.rpm

f26:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25534544

f27:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25534556

f28:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25534564

rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25534572

epel7:
https://koji.fedoraproject.org/koji/taskinfo?taskID=25534493


Diff from 1.1-4:

--- kronosnet.spec.1.1-42018-03-04 02:00:23.290918796 -0500
+++ kronosnet.spec.1.1-62018-03-07 01:19:35.321125418 -0500
@@ -70,7 +70,7 @@
 Name: kronosnet
 Summary: Multipoint-to-Multipoint VPN daemon
 Version: 1.1
-Release: 4%{?dist}
+Release: 6%{?dist}
 License: GPLv2+ and LGPLv2+
 URL: http://www.kronosnet.org
 Source0: http://www.kronosnet.org/releases/kronosnet-%{version}.tar.gz
@@ -93,7 +93,7 @@
 BuildRequires: pkgconfig(zlib)
 %endif
 %if %{defined buildcompresslz4}
-BuildRequires: pkgconfig(liblz4)
+BuildRequires: pkgconfig(liblz4) >= 1.7
 %endif
 %if %{defined buildcompresslzo2}
 BuildRequires: lzo-devel
@@ -257,9 +257,7 @@
 %license COPYING.* COPYRIGHT
 %{_libdir}/libtap.so.*

-%ldconfig_scriptlets libtap1
-
-%postun -n libtap1 -p /sbin/ldconfig
+%ldconfig_scriptlets -n libtap1

 %package -n libtap1-devel
 Summary: Simple userland wrapper around kernel tap devices (developer files)
@@ -299,9 +297,7 @@
 %{_libdir}/libknet.so.*
 %dir %{_libdir}/kronosnet

-%post -n libknet1 -p /sbin/ldconfig
-
-%postun -n libknet1 -p /sbin/ldconfig
+%ldconfig_scriptlets -n libknet1

 %package -n libknet1-devel
 Summary: Kronosnet core switching implementation (developer files)
@@ -314,13 +310,6 @@
 Please refer to the not-yet-existing documentation for further
 information. 

-# libknet.pc leading to pkgconfig(libknet) automatic virtual provides,
-# like other files, is not explicitly versioned in the name like the
-# subpackages are -- intention of doing so for subpackage names is
-# to ease the cross-checking the compatibility of the remote clients
-# interchanging data using this network communication library, as
-# the number denotes the protocol version (providing multiple
-# protocol versions in parallel is not planned).
 %files -n libknet1-devel
 %{_libdir}/libknet.so
 %{_includedir}/libknet.h
@@ -469,10 +458,25 @@
 %files -n libknet1-plugins-all

 %if %{with rpmdebuginfo}
+# libknet.pc leading to pkgconfig(libknet) automatic virtual provides,
+# like other files, is not explicitly versioned in the name like the
+# subpackages are -- intention of doing so for subpackage names is
+# to ease the cross-checking the compatibility of the remote clients
+# interchanging data using this network communication library, as
+# the number denotes the protocol version (providing multiple
+# protocol versions in parallel is not planned).
 %debug_package
 %endif

 %changelog
+* Wed Mar 07 2018 Madison Kelly  - 1.1-6
+- Added a version requirement to lz4 to deal with koji pulling in the
+  wrong package.
+
+* Tue Mar 06 2018 Madison Kelly  - 1.1-5
+- Updated ldconfig scriptlet calls.
+- Moved the debug_package leading comment.
+
 * Sun Mar 04 2018 Madison Kelly  - 1.1-4
 - Removed leading spaces from descriptions.
 - Added the (commented out) %%check tests.
@@ -493,45 +497,3 @@
 - Removed the (no longer needed) gcc8-fixes.patch
 - Added the new doxygen and libqb-devel buildrequires for libknetd.

-* Fri Feb 23 2018 Madison Kelly  - 1.0-10
-- Added missing change log for 1.0-9.
-
-* Thu Feb 22 2018 Madison Kelly  - 1.0-9
-- Changed the source tarball to be one from the upstream source.
-- Updated the main license.
-- Moved down the %%{?systemd_requires} macro.
-
-* Fri Feb 16 2018 Madison Kelly  - 1.0-8
-- Reverted to 'BuildRequires: bzip2-devel' to fix EPEL7 builds.
-
-* Thu Feb 15 2018 Madison Kelly  - 1.0-7
-- Added missing 1.0-6 changelog.
-- Added kronosnetd postun.
-- Clarified licensing.
-- (re)added systemd_requires.
-- Wrapped several buildrequires with pkgconfig().
-
-* Wed Feb 14 2018 Madison Kelly  - 1.0-6
-- Removed sysvinit checks.
-- Fixed the groupadd to add to system group.
-- Added build requirement for systemd.
-- Added %%{_isa} macro to knet requirements in sub packages.
-
-* Mon Feb 12 2018 Madison Kelly  - 1.0-5
-- All changes related to this spec;
-- Fixed typo in previous changelog date (Tue -> Wed).
-- Capitalized summaries as needed.
-- Changed Requires that were file paths to 

[Bug 1551457] Review Request: R-mockery - Mocking Library for R

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551457



--- Comment #6 from Fedora Update System  ---
R-mockery-0.4.1-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-c053e82986

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551457] Review Request: R-mockery - Mocking Library for R

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551457



--- Comment #5 from Fedora Update System  ---
R-mockery-0.4.1-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-3c3c1cbef2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551457] Review Request: R-mockery - Mocking Library for R

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551457

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551457] Review Request: R-mockery - Mocking Library for R

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551457



--- Comment #4 from Fedora Update System  ---
R-mockery-0.4.1-1.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-29e118c7c8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551244] Review Request: golang-github-git-lfs-wildmatch - Pattern matching language for filepaths compatible with Git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551244



--- Comment #5 from Fedora Update System  ---
git-lfs-2.4.0-1.fc27
golang-github-git-lfs-wildmatch-0-0.1.20180219git8a05186.fc27 has been
submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-b1b332c991

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551244] Review Request: golang-github-git-lfs-wildmatch - Pattern matching language for filepaths compatible with Git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551244



--- Comment #6 from Fedora Update System  ---
git-lfs-2.4.0-1.fc26
golang-github-git-lfs-wildmatch-0-0.1.20180219git8a05186.fc26 has been
submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-f205bd5b47

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551244] Review Request: golang-github-git-lfs-wildmatch - Pattern matching language for filepaths compatible with Git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551244



--- Comment #4 from Fedora Update System  ---
git-lfs-2.4.0-1.fc28
golang-github-git-lfs-wildmatch-0-0.1.20180219git8a05186.fc28 has been
submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-ff6d88ef10

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551244] Review Request: golang-github-git-lfs-wildmatch - Pattern matching language for filepaths compatible with Git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551244

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551504] Review Request: python-couchbase - Python client for Couchbase server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551504

Sergey Avseyev  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-03-07 00:08:48



--- Comment #5 from Sergey Avseyev  ---
Thank you for review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1549686] Review Request: f28-backgrounds - Fedora 28 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1549686

Fedora Blocker Bugs Application  changed:

   What|Removed |Added

 CC||l...@fedoraproject.org
 Blocks||1469204
   ||(BetaBlocker,F28BetaBlocker
   ||)



--- Comment #10 from Fedora Blocker Bugs Application 
 ---
Proposed as a Blocker for 28-beta by Fedora user luya using the blocker
tracking app because:

 Default  beta wallpapers for Fedora 28 is recently packaged for the beta
release that just got frozen.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1469204
[Bug 1469204] Fedora 28 Beta blocker bug tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533731] Review Request: ocaml-sedlex - Unicode-friendly lexer generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533731



--- Comment #6 from Fedora Update System  ---
ocaml-sedlex-1.99.4-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-b7409a195a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533731] Review Request: ocaml-sedlex - Unicode-friendly lexer generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533731

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740

Germano Massullo  changed:

   What|Removed |Added

 Depends On||1552371




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1552371
[Bug 1552371] Implement -DCMAKE_INSTALL_LIBDIR:PATH=%{_libdir}  qmake
equivalent
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740



--- Comment #13 from Germano Massullo  ---
I need to add the QMAKE equivalent of cmake flag
-DCMAKE_INSTALL_LIBDIR:PATH=%{_libdir}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424890



--- Comment #22 from Per Bothner  ---
Yes, I'm still interested. Since the previous "push" I'm made major changes
that effect its packaging, especially the qtdomterm sub-package (which now only
handles the UI), and help/man pages. Plus lots of features and polishing and
speed-up and ports (to Atom, to Theia, to Ubuntu, to Windows using WSL). I've
also posted articles to OpenSource.com and dzone.com (submitted yesterday).

I've done some updates to domterm.spec, but it needs more testing and review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103

Chris Feist  changed:

   What|Removed |Added

   Assignee|jpoko...@redhat.com |jfrie...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1252130] Review Request: gnome-shell-extension-drop-down-terminal - Drop Down Terminal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1252130

Andrew Toskin  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX
Last Closed||2018-03-06 18:35:04



--- Comment #13 from Andrew Toskin  ---
I'm gonna go ahead and close this. Mosaab, if you decide you want to keep
working on this package after all, feel free to reopen this ticket.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424890



--- Comment #21 from Andrew Toskin  ---
It's been a while. Per Bothner, are you still interested in working on this
package?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552033] Review Request: python-pycryptodomex - A self-contained cryptographic library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552033



--- Comment #9 from Fedora Update System  ---
python-pycryptodomex-3.4.12-2.fc28 has been submitted as an update to Fedora
28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-7467524a25

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #78 from digimer  ---
> Free-form implementation of
> 
>> - comment above "%debug_package" that it is not relevant for
>>   Fedora and its removal is pending [there]
> 
> per [comment 73] is still missing.


Did I misunderstand? I added the comment above "%files -n libknet1-devel";


> # libknet.pc leading to pkgconfig(libknet) automatic virtual provides,
> # like other files, is not explicitly versioned in the name like the
> # subpackages are -- intention of doing so for subpackage names is
> # to ease the cross-checking the compatibility of the remote clients
> # interchanging data using this network communication library, as
> # the number denotes the protocol version (providing multiple
> # protocol versions in parallel is not planned).
> %files -n libknet1-devel


Anyway, I moved it.

I'm sorry, I don't understand the question/comment/suggestion in comment #77.
Can you please restate?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552033] Review Request: python-pycryptodomex - A self-contained cryptographic library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552033



--- Comment #10 from Fedora Update System  ---
python-pycryptodomex-3.4.12-2.fc26 has been submitted as an update to Fedora
26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-4d0105c8a6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552033] Review Request: python-pycryptodomex - A self-contained cryptographic library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552033



--- Comment #8 from Fedora Update System  ---
python-pycryptodomex-3.4.12-2.fc27 has been submitted as an update to Fedora
27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-fc4179ded4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552033] Review Request: python-pycryptodomex - A self-contained cryptographic library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552033

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551791] Review Request: waylandpp - Wayland C++ bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551791



--- Comment #7 from Fedora Update System  ---
waylandpp-0.2.2-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-80497cd4ba

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551791] Review Request: waylandpp - Wayland C++ bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551791



--- Comment #5 from Fedora Update System  ---
waylandpp-0.2.2-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-16fdcc86cb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551791] Review Request: waylandpp - Wayland C++ bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551791

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551791] Review Request: waylandpp - Wayland C++ bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551791



--- Comment #6 from Fedora Update System  ---
waylandpp-0.2.2-2.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-df618a6936

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 885038] Review Request: pentobi - Program that plays the board game Blokus

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=885038

Andrew Toskin  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
Last Closed||2018-03-06 18:20:05



--- Comment #24 from Andrew Toskin  ---
I'm going to go ahead and close this. But, Christophe, if you decide you want
to resume work on this package, you could just go ahead and reopen this issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1085612] Review Request: voxelands - The Fun-Focused Free Software Voxel World Game (was: minetest-classic)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1085612



--- Comment #21 from Andrew Toskin  ---
I'm still interested in reviewing this package (and playing the game) if you're
still interested in working on it, Maverick.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552262] Review Request: nodejs-pg-pool - A connection pool for node-postgres

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552262

Tom Hughes  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2018-03-06 18:03:17



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552261] Review Request: nodejs-pg-cursor - Use a PostgreSQL result cursor from node with an easy to use API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552261

Tom Hughes  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2018-03-06 18:03:10



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552258] Review Request: nodejs-js-string-escape - Escape any string to be a valid JavaScript string literal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552258

Tom Hughes  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2018-03-06 18:02:45



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551791] Review Request: waylandpp - Wayland C++ bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551791



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/waylandpp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551791] Review Request: waylandpp - Wayland C++ bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551791

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
All good, package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551791] Review Request: waylandpp - Wayland C++ bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551791



--- Comment #2 from Mohamed El Morabity  ---
(In reply to Robert-André Mauchin from comment #1)
>  - The license seems to be MIT:
> https://github.com/NilsBrause/waylandpp/blob/master/LICENSE
> 
>So you should add to License: "and MIT"
Good catch, I fixed the license tag

>  - You should own: {_defaultdocdir}/%{name}
> 
> [!]: Package must own all directories that it creates.
>  Note: Directories without known owners: /usr/share/doc/waylandpp
All files in the doc subpackage is now installed in /usr/share/doc/waylandpp,
with right ownership.

Spec URL:
https://melmorabity.fedorapeople.org/packages/waylandpp/waylandpp.spec
SRPM URL:
https://melmorabity.fedorapeople.org/packages/waylandpp/waylandpp-0.2.2-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552262] Review Request: nodejs-pg-pool - A connection pool for node-postgres

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552262



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-pg-pool

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #77 from Jan Pokorný  ---
Oh, and one more nit, %check might have contained, commented out,
something actually usable for said quick check of the basic
functionality.  In case it would be desired in spite of the
mentioned concerns.  This is a mere recommendation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552033] Review Request: python-pycryptodomex - A self-contained cryptographic library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552033



--- Comment #7 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-pycryptodomex

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552262] Review Request: nodejs-pg-pool - A connection pool for node-postgres

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552262

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
Package approved.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 20 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/nodejs-pg-pool/review-nodejs-pg-
 pool/licensecheck.txt
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/node_modules
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should 

[Bug 1550740] Review request: webextension-token-signing - Firefox extension for signing with your eID on the web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550740



--- Comment #12 from Germano Massullo  ---
My fault, I replaced %_prefix/lib/ with %{_libdir}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552261] Review Request: nodejs-pg-cursor - Use a PostgreSQL result cursor from node with an easy to use API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552261



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-pg-cursor

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552258] Review Request: nodejs-js-string-escape - Escape any string to be a valid JavaScript string literal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552258



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nodejs-js-string-escape

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552033] Review Request: python-pycryptodomex - A self-contained cryptographic library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552033

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #6 from Robert-André Mauchin  ---
Thanks spot for being so quick.

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552261] Review Request: nodejs-pg-cursor - Use a PostgreSQL result cursor from node with an easy to use API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552261

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
Package approved.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 15 files have unknown license. Detailed
 output of licensecheck in /home/bob/packaging/review/nodejs-pg-cursor
 /review-nodejs-pg-cursor/licensecheck.txt
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/node_modules
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

[Bug 1552033] Review Request: python-pycryptodomex - A self-contained cryptographic library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552033



--- Comment #5 from Mohamed El Morabity  ---
Thank you Robert-André for the review.

(In reply to Robert-André Mauchin from comment #1)
>  - License seems to be Public Domain and BSD:
> https://github.com/Legrandin/pycryptodome/blob/master/LICENSE.rst I did not
> find any ASL 2.0.
The license tag is fixed.

>  There's also the issue of the OCB license in Doc/ocb/license1.pdf:
Good catch :). Thanks Tom for the legal review.

Spec URL:
https://melmorabity.fedorapeople.org/packages/python-pycryptodomex/python-pycryptodomex.spec
SRPM URL:
https://melmorabity.fedorapeople.org/packages/python-pycryptodomex/python-pycryptodomex-3.4.12-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552258] Review Request: nodejs-js-string-escape - Escape any string to be a valid JavaScript string literal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552258

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Robert-André Mauchin  ---
Package approved.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 6 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/nodejs-js-string-escape/review-nodejs-js-
 string-escape/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile 

[Bug 1542651] Review Request: libquentier - Set of Qt/ C++ APIs for feature rich desktop clients for Evernote service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542651



--- Comment #8 from Fedora Update System  ---
libquentier-0.4.0-0.3.20180301git4ce8e3b.fc27 has been submitted as an update
to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-b55bef90c8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552262] Review Request: nodejs-pg-pool - A connection pool for node-postgres

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552262

Tom Hughes  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)



--- Comment #2 from Tom Hughes  ---
Note that tests are disabled currently due to bootstrapping issues where this
and nodejs-pg-cursor require each other.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552262] New: Review Request: nodejs-pg-pool - A connection pool for node-postgres

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552262

Bug ID: 1552262
   Summary: Review Request: nodejs-pg-pool - A connection pool for
node-postgres
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: t...@compton.nu
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://tomh.fedorapeople.org//nodejs-pg-pool.spec
SRPM URL: http://tomh.fedorapeople.org//nodejs-pg-pool-2.0.3-1.fc27.src.rpm

Description:
A connection pool for node-postgres.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552262] Review Request: nodejs-pg-pool - A connection pool for node-postgres

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552262



--- Comment #1 from Tom Hughes  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=25528361

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552261] Review Request: nodejs-pg-cursor - Use a PostgreSQL result cursor from node with an easy to use API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552261

Tom Hughes  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)



--- Comment #2 from Tom Hughes  ---
Note that tests are disabled currently due to bootstrapping issues where this
and nodejs-pg-pool require each other.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552261] New: Review Request: nodejs-pg-cursor - Use a PostgreSQL result cursor from node with an easy to use API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552261

Bug ID: 1552261
   Summary: Review Request: nodejs-pg-cursor - Use a PostgreSQL
result cursor from node with an easy to use API
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: t...@compton.nu
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://tomh.fedorapeople.org//nodejs-pg-cursor.spec
SRPM URL: http://tomh.fedorapeople.org//nodejs-pg-cursor-1.3.0-1.fc27.src.rpm

Description:
Use a PostgreSQL result cursor from node with an easy to use API.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552261] Review Request: nodejs-pg-cursor - Use a PostgreSQL result cursor from node with an easy to use API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552261



--- Comment #1 from Tom Hughes  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=25528318

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552258] Review Request: nodejs-js-string-escape - Escape any string to be a valid JavaScript string literal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552258

Tom Hughes  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552258] New: Review Request: nodejs-js-string-escape - Escape any string to be a valid JavaScript string literal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552258

Bug ID: 1552258
   Summary: Review Request: nodejs-js-string-escape - Escape any
string to be a valid JavaScript string literal
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: t...@compton.nu
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://tomh.fedorapeople.org//nodejs-js-string-escape.spec
SRPM URL:
http://tomh.fedorapeople.org//nodejs-js-string-escape-1.0.1-1.fc27.src.rpm

Description:
Escape any string to be a valid JavaScript string literal
between double quotes or single quotes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552258] Review Request: nodejs-js-string-escape - Escape any string to be a valid JavaScript string literal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552258



--- Comment #1 from Tom Hughes  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=25528204

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551504] Review Request: python-couchbase - Python client for Couchbase server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551504



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-couchbase

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #76 from Jan Pokorný  ---
Thanks to everyone involved, also for patience; I understand that
time as a main metric might be preferred to overall quality, but
I tried to explain the significance of the latter for the wider
"package collection".  As this is one-off currently, it's believed
that the reviewed version will be used as a gauge for future updates.

That being said, I find just two points to be addressed prior to
approval, and I am at least partially responsible for the first one:

* * *

re H.:
I should have explained better the required change, as currently
it's only partially satisfied (beside following bad instructions).

Let me provide wider context:

- until very recently, /sbin/ldconfig invocations were interspersed
  in individual spec files in %post and %postun scriptlets (execution
  unit triggered as the package is being installed/removed in this
  case), to keep the dynamic linker cached knowledge about the
  installed libraries current -- so far so good, this is what previous
  version of this spec was using

- some time ago, rpm added generic support for scriptlets to be run
  only once per whole transaction (comprising, e.g., all your updates
  received in one go)

- relatively recently, wise Fedora maintainers realized there can be
  cumulated overhead arising from running ldconfig per package, when
  in most cases it's enough to run it per said transaction, and
  introduced new "self contained" change:

  https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets

  which asks either to drop ldconfig invocation from the spec
  altogether (Fedora 28+ only), or to use the compatibility
  macros (to cover also pre-28 cases, which I believe is the
  intention with kronosnet)

The problem is that we need to address all "ldconfig" occurrences,
not just the one I've mistakenly mentioned in isolation in
[comment 57].  Beside the description at the above page, we can
also investigate on our own:

$ rpm --showrc | grep -A3 ldconfig_scriptlets
> -13: ldconfig_scriptlets(n:)  %{?ldconfig:
> %ldconfig_post %{?*} %{-n:-n %{-n*}}
> %ldconfig_postun %{?*} %{-n:-n %{-n*}}
> }

We can grok that %ldconfig_scriptlets will handle both %post
and %postun sides on its own.  Regarding usage with subpackages,
there's a confirmation that currently adopted usage is OK, e.g.,
on devel ML:
https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/message/JZNJEN5FG5SAVQKC5RTWEJDQDLBETNI4/

Hence what I ask for: for both libtap1 and libknet1 subpackages,
make sure that these occurrences in the original:

> %post -n SUBPACKAGE -p /sbin/ldconfig
> %postun -n SUBPACKAGE -p /sbin/ldconfig

are both mapped to a single, unique line:

> %ldconfig_scriptlets -n SUBPACKAGE

As you can see, I mistakenly provided a bad piece of advice, actually,
as using "-n SUBPACKAGE" vs. just "SUBPACKAGE" is aligned with how
other macros (namely %package, but consequently %description, %files,
%postun, etc.), and it's the former case with both libknet1 and
libtap1.
These naming subtleties are best understood here:
http://ftp.rpm.org/max-rpm/s1-rpm-subpack-spec-file-changes.html#S3-RPM-SUBPACK-PACKAGE-DIRECTIVE-N-OPTION

* * *

Free-form implementation of

> - comment above "%debug_package" that it is not relevant for
>   Fedora and its removal is pending [there]

per [comment 73] is still missing.

* * *

Digimer, you are also free to cut off the older changelog entries
(like up to and including 1.0-10) to make the situation perhaps a bit
easier to grok, since those steps are all prior to inclusion (and
hence not a game changer for downstream users), and you already
demonstrated your changelog entries are spot-on.  But it's merely
up to you, there was certainly an undeniable effort invested since
the initial version...

(And if you decide to do so, there's no reason to state that very
change in the changelog.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542651] Review Request: libquentier - Set of Qt/ C++ APIs for feature rich desktop clients for Evernote service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542651

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542651] Review Request: libquentier - Set of Qt/ C++ APIs for feature rich desktop clients for Evernote service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542651



--- Comment #7 from Fedora Update System  ---
libquentier-0.4.0-0.3.20180301git4ce8e3b.fc28 has been submitted as an update
to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-7d6da5abdd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550685] Review Request: python-cookiecutter - CLI utility to create projects from templates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550685



--- Comment #6 from Brett Lentz  ---
You're right. After further investigation, these are runtime requires. I'll
work on packaging those dependencies then I'll come back to this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551504] Review Request: python-couchbase - Python client for Couchbase server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551504

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
Perfect, package is approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1528781] Review Request: mpfr - multiple-precision floating-point computations [needs sponsor]

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1528781

James Paul Turner  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |NOTABUG



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1528781] Review Request: mpfr - multiple-precision floating-point computations [needs sponsor]

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1528781

James Paul Turner  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2018-03-06 13:53:04



--- Comment #7 from James Paul Turner  ---


*** This bug has been marked as a duplicate of bug 1537252 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1550317

Randy Barlow  changed:

   What|Removed |Added

  Flags||needinfo?(itamar@ispbrasil.
   ||com.br)



--- Comment #4 from Randy Barlow  ---
A few issues to fix:

[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib/python3.6/site-
 packages/flask_security/templates/security/email, /usr/lib/python3.6
 /site-packages/flask_security/templates, /usr/lib/python3.6/site-
 packages/flask_security/translations, /usr/lib/python2.7/site-
 packages/flask_security/templates, /usr/lib/python3.6/site-
 packages/flask_security/__pycache__, /usr/lib/python2.7/site-
 packages/flask_security/translations, /usr/lib/python2.7/site-
 packages/flask_security/templates/security/email, /usr/lib/python2.7
 /site-packages/flask_security, /usr/lib/python2.7/site-
 packages/flask_security/templates/security, /usr/lib/python3.6/site-
 packages/flask_security/templates/security, /usr/lib/python3.6/site-
 packages/flask_security
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python3.6/site-
 packages/flask_security/templates/security/email, /usr/lib/python3.6
 /site-packages/flask_security/templates, /usr/lib/python3.6/site-
 packages/flask_security/__pycache__, /usr/lib/python2.7/site-
 packages/flask_security/templates, /usr/lib/python2.7/site-
 packages/flask_security/translations, /usr/lib/python2.7/site-
 packages/flask_security/templates/security/email, /usr/lib/python2.7
 /site-packages/flask_security, /usr/lib/python3.6/site-
 packages/flask_security/translations, /usr/lib/python2.7/site-
 packages/flask_security/templates/security, /usr/lib/python3.6/site-
 packages/flask_security/templates/security, /usr/lib/python3.6/site-
 packages/flask_security

Recommendation: Simply put %{python2_sitelib}/flask_security and
%{python3_sitelib}/flask_security into your %files sections, rather than trying
to write out all the subpaths.


[!]: You have
 %{?python_provide:%python_provide python%{python3_pkgversion}-%{pkg_name}}
 in the Python 2 subpackage.

Recommendation: It should be %{?python_provide:%python_provide
python2-%{pkg_name}}.


Optional, but recommended: Upstream does have a test suite. I recommend running
it in a %check section.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552033] Review Request: python-pycryptodomex - A self-contained cryptographic library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552033



--- Comment #4 from Tom "spot" Callaway  ---
I just did it, it's fine. If other ECC algorithms besides prime256v1 (NIST
P-256) show up, please let me know.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539291] Review Request: ghc-echo - Cross-platform, cross-console echoing of terminal input

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539291

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
ghc-echo-0.1.3-3.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-34d8fbd75e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551449] Review Request: R-lubridate - Make dealing with dates a little easier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551449



--- Comment #8 from Fedora Update System  ---
R-lubridate-1.7.3-2.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-6415dd58fd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551504] Review Request: python-couchbase - Python client for Couchbase server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551504



--- Comment #2 from Sergey Avseyev  ---
Thanks for review, I've fixed issues and here are updated links:

Spec URL:
https://avsej.fedorapeople.org/python-couchbase/1/python-couchbase.spec
SRPM URL:
https://avsej.fedorapeople.org/python-couchbase/1/python-couchbase-2.3.4-1.fc29.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=25523564

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552033] Review Request: python-pycryptodomex - A self-contained cryptographic library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552033

Yaakov Selkowitz  changed:

   What|Removed |Added

 CC||yselk...@redhat.com



--- Comment #3 from Yaakov Selkowitz  ---
Does a review need to be made for disallowed crypto algorithms?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1551449] Review Request: R-lubridate - Make dealing with dates a little easier

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1551449

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
R-lubridate-1.7.3-2.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-afc7af8128

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552033] Review Request: python-pycryptodomex - A self-contained cryptographic library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552033

Tom "spot" Callaway  changed:

   What|Removed |Added

 CC||tcall...@redhat.com
 Blocks|182235 (FE-Legal)   |



--- Comment #2 from Tom "spot" Callaway  ---
OCB patent license is fine. Lifting FE-Legal.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1552033] Review Request: python-pycryptodomex - A self-contained cryptographic library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1552033

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com
 Blocks||182235 (FE-Legal)



--- Comment #1 from Robert-André Mauchin  ---
 - License seems to be Public Domain and BSD:
https://github.com/Legrandin/pycryptodome/blob/master/LICENSE.rst I did not
find any ASL 2.0.

 There's also the issue of the OCB license in Doc/ocb/license1.pdf:

License for Open Source Software Implementations of OCB
January 9, 2013
1 Definitions
1.1 “Licensor” means Phillip Rogaway.
1.2 “Licensed Patents” means any patent that claims priority to United States
Patent
Application No. 09/918,615 entitled “Method and Apparatus for Facilitating
Efficient Authenticated Encryption,” and any utility, divisional, provisional,
continuation, continuations-in-part, reexamination, reissue, or foreign
counterpart
patents that may issue with respect to the aforesaid patent application. This
includes, but is not limited to, United States Patent No. 7,046,802; United
States
Patent No. 7,200,227; United States Patent No. 7,949,129; United States Patent
No. 8,321,675; and any patent that issues out of United States Patent
Application
No. 13/669,114.
1.3 “Use” means any practice of any invention claimed in the Licensed Patents.
1.4 “Software Implementation” means any practice of any invention claimed in
the
Licensed Patents that takes the form of software executing on a user-
programmable, general-purpose computer or that takes the form of a computer-
readable medium storing such software. Software Implementation does not
include, for example, application-specific integrated circuits (ASICs), field-
programmable gate arrays (FPGAs), embedded systems, or IP cores.
1.5 “Open Source Software” means software whose source code is published and
made available for inspection and use by anyone because either (a) the source
code
is subject to a license that permits recipients to copy, modify, and distribute
the
source code without payment of fees or royalties, or (b) the source code is in
the
public domain, including code released for public use through a CC0 waiver. All
licenses certified by the Open Source Initiative at opensource.org as of
January 9,
2013 and all Creative Commons licenses identified on the creativecommons.org
website as of January 9, 2013, including the Public License Fallback of the CC0
waiver, satisfy these requirements for the purposes of this license.
1.6 “Open Source Software Implementation” means a Software Implementation in
which the software implicating the Licensed Patents is Open Source Software.
Open Source Software Implementation does not include any Software
Implementation in which the software implicating the Licensed Patents is
combined, so as to form a larger program, with software that is not Open Source
Software.
2 License Grant
2.1 License. Subject to your compliance with the terms of this license,
including the
restriction set forth in Section 2.2, Licensor hereby grants to you a
perpetual,
worldwide, non-exclusive, non-transferable, non-sublicenseable, no-charge,
royalty-free, irrevocable license to practice any invention claimed in the
Licensed
Patents in any Open Source Software Implementation.
2.2 Restriction.
 If you or your affiliates institute patent litigation (including, but
not limited to, a cross-claim or counterclaim in a lawsuit) against any entity
alleging that any Use authorized by this license infringes another patent, then
any
rights granted to you under this license automatically terminate as of the date
such
litigation is filed.
3 Disclaimer
YOUR USE OF THE LICENSED PATENTS IS AT YOUR OWN RISK AND
UNLESS REQUIRED BY APPLICABLE LAW, LICENSOR MAKES NO
REPRESENTATIONS OR WARRANTIES OF ANY KIND CONCERNING THE
LICENSED PATENTS OR ANY PRODUCT EMBODYING ANY LICENSED
PATENT, EXPRESS OR IMPLIED, STATUTORY OR OTHERWISE,
INCLUDING, WITHOUT LIMITATION, WARRANTIES OF TITLE,
MERCHANTIBILITY, FITNESS FOR A PARTICULAR PURPOSE, OR
NONINFRINGEMENT. IN NO EVENT WILL LICENSOR BE LIABLE FOR ANY
CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN CONTRACT, TORT
OR OTHERWISE, ARISING FROM OR RELATED TO ANY USE OF THE
LICENSED PATENTS, INCLUDING, WITHOUT LIMITATION, DIRECT,
INDIRECT, INCIDENTAL, CONSEQUENTIAL, PUNITIVE OR SPECIAL
DAMAGES, EVEN IF LICENSOR HAS BEEN ADVISED OF THE POSSIBILITY
OF SUCH DAMAGES PRIOR TO SUCH AN OCCURRENCE.


I'd need FE-LEGAL opinion en this.


==

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: 

[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487067



--- Comment #34 from Thomas Moschny  ---
(In reply to Jack Lloyd from comment #33)
> Re compile flags, configure.py script consumes flags from CXXFLAGS if set in
> the environment, which will override the defaults. Is there something else
> we should be doing here?

No, that's fine.

In many cases, spec files use %configure, which sets (amongst others) CXXFLAGS,
but as %configure is not used here, we should use
  export CXXFLAGS=%{optflags}
instead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545941] Review Request: vim-jellybeans - A colorful, dark color scheme for Vim

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545941



--- Comment #11 from Fedora Update System  ---
vim-jellybeans-1.6-1.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545941] Review Request: vim-jellybeans - A colorful, dark color scheme for Vim

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545941



--- Comment #10 from Fedora Update System  ---
vim-jellybeans-1.6-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1516117] Review Request: python-hexdump - Dump binary data to hex format and restore from there

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1516117



--- Comment #13 from Fedora Update System  ---
python-hexdump-3.4-0.2.20160818hg66325cb5fed8.el7 has been pushed to the Fedora
EPEL 7 stable repository. If problems still persist, please make note of it in
this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548798] Review Request: natural-earth-map-data - Free vector and raster map data at 1:10m, 1:50m, and 1:110m scales

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548798



--- Comment #10 from Fedora Update System  ---
natural-earth-map-data-4.0.0-2.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433657] Review Request: vncpwd - VNC Password Decrypter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433657



--- Comment #13 from Fedora Update System  ---
vncpwd-0.0-3.20170607git596854c.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1545347] Review Request: microdns - Minimal mDNS resolver and announcer library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1545347



--- Comment #12 from Fedora Update System  ---
microdns-0.0.8-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520584] Review Request: perl-MooseX-Types-NetAddr-IP - NetAddr:: IP related types and coercions for Moose

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520584

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2017-12-19 14:47:25 |2018-03-06 12:30:11



--- Comment #13 from Fedora Update System  ---
perl-MooseX-Types-NetAddr-IP-0.07-2.el7 has been pushed to the Fedora EPEL 7
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487067



--- Comment #33 from Jack Lloyd  ---
Re compile flags, configure.py script consumes flags from CXXFLAGS if set in
the environment, which will override the defaults. Is there something else we
should be doing here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544384] Review Request: tcl-thread - Tcl Thread extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544384



--- Comment #11 from Fedora Update System  ---
tcl-thread-2.8.2-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546534] Review Request: golang-github-paulrosania-go-charset - Character set conversion for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546534



--- Comment #8 from Fedora Update System  ---
golang-github-paulrosania-go-charset-0-0.1.20151028git621bb39.fc26 has been
pushed to the Fedora 26 stable repository. If problems still persist, please
make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1546648] Review Request: perl-IO-Socket-Socks - Provides a way to create socks (4 or 5) client or server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1546648



--- Comment #10 from Fedora Update System  ---
perl-IO-Socket-Socks-0.74-2.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 630303] Review Request: yesod - Creation of type-safe, RESTful web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=630303
Bug 630303 depends on bug 1497030, which changed state.

Bug 1497030 Summary: Review Request: ghc-clientsession - Securely store session 
data in a client-side cookie
https://bugzilla.redhat.com/show_bug.cgi?id=1497030

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1497030] Review Request: ghc-clientsession - Securely store session data in a client-side cookie

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1497030

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-03-06 12:25:39



--- Comment #8 from Fedora Update System  ---
ghc-clientsession-0.9.1.2-1.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1496559] Review Request: ghc-cprng-aes - Crypto Pseudo Random Number Generator using AES in counter mode

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1496559

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-03-06 12:25:34



--- Comment #6 from Fedora Update System  ---
ghc-cprng-aes-0.6.1-3.fc27 has been pushed to the Fedora 27 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 925993] Review Request: ghc-yesod-core - Yesod core library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=925993
Bug 925993 depends on bug 1497030, which changed state.

Bug 1497030 Summary: Review Request: ghc-clientsession - Securely store session 
data in a client-side cookie
https://bugzilla.redhat.com/show_bug.cgi?id=1497030

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1497030] Review Request: ghc-clientsession - Securely store session data in a client-side cookie

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1497030
Bug 1497030 depends on bug 1496559, which changed state.

Bug 1496559 Summary: Review Request: ghc-cprng-aes - Crypto Pseudo Random 
Number Generator using AES in counter mode
https://bugzilla.redhat.com/show_bug.cgi?id=1496559

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548797] Review Request: python-cartopy - Cartographic Python library with Matplotlib visualisations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548797
Bug 1548797 depends on bug 1548798, which changed state.

Bug 1548798 Summary: Review Request: natural-earth-map-data - Free vector and 
raster map data at 1:10m, 1:50m, and 1:110m scales
https://bugzilla.redhat.com/show_bug.cgi?id=1548798

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org