[Bug 1613572] Review Request: libdparse - Library for lexing and parsing D source code
https://bugzilla.redhat.com/show_bug.cgi?id=1613572
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
- URL should be
https://github.com/dlang-community/libdparse/
- Use:
Source0:
https://github.com/dlang-community/libdparse/archive/v%{version}%{?pre:-%{pre}}/%{name}-%{version}%{?pre:-%{pre}}.tar.gz
+ ldc2 -I src -o- -c src/dparse/parser.d -Hf include//dparse/parser.di
BUILDSTDERR: src/dparse/parser.d(9): Error: module `mallocator` is in file
'stdx/allocator/mallocator.d' which cannot be read
BUILDSTDERR: import path[0] = src
BUILDSTDERR: import path[1] = /usr/include/d/ldc
BUILDSTDERR: import path[2] = /usr/include/d
- You need to include -I %{_includedir}/d/stdx-allocator:
# generate header
ldc2 -I %{_includedir}/d/stdx-allocator -I "${src_dir}" -o- -c $f -Hf
${header_file};
# generate doc
ldc2 -I %{_includedir}/d/stdx-allocator -I "${src_dir}" -o- -c $f -Df
${doc_file} doc-src/index.ddoc doc-src/macros.ddoc;
# generate object
ldc2 -I %{_includedir}/d/stdx-allocator -I "${src_dir}" ${DFLAGS} -c
-relocation-model=pic $f -of ${object_file}
- I think it would be nice to implement Meson for this too:
# debug info seem not works with D compiler
%global debug_package %{nil}
%global major_version 0
%global minor_version 9
%global patch_version 1
#%%global pre beta
Name: libdparse
Version:%{major_version}.%{minor_version}.%{patch_version}
Release:1%{?pre:.%{pre}}%{?dist}
Summary:Library for lexing and parsing D source code
Summary(fr):Bibliothèque pour l'analyse syntaxique et grammaticale de code
source D
License:Boost
URL:https://github.com/dlang-community/libdparse
Source0:
https://github.com/dlang-community/libdparse/archive/v%{version}%{?pre:-%{pre}}/%{name}-%{version}%{?pre:-%{pre}}.tar.gz
Patch0:
https://patch-diff.githubusercontent.com/raw/dlang-community/libdparse/pull/257.patch#/0001-Add-Meson-build-definition.patch
ExclusiveArch: %{ldc_arches}
BuildRequires: ldc meson stdx-allocator-devel
Requires: ldc-phobos ldc-druntime stdx-allocator
%description
Library for lexing and parsing D source code.
%description -l fr
Bibliothèque pour l'analyse syntaxique et grammaticale de code source en D.
%packagedevel
Summary:Development files for %{name}
Summary(fr):Fichiers de développement pour %{name}
Requires: %{name}%{?_isa} = %{version}-%{release}
Requires:stdx-allocator-devel
%description devel
libdparse package contains header files for developing D applications
that use libdparse.
%description devel -l fr
Le paquet libdparse contient les fichiers d'entêtes pour développer
des applications en D utilisant libdparse.
%package geany-tags
Summary:Support for enable autocompletion in geany
Summary(fr):Support pour activer l'auto-complétion dans geany
Requires: %{name} = %{version}-%{release}
BuildArch: noarch
BuildRequires: geany
Requires: geany
%description geany-tags
Enable autocompletion for dsymbol library in geany (IDE)
%description -l fr geany-tags
Active l'autocompletion pour pour la bibliothèque dsymbol dans geany (IDE)
%prep
%autosetup -p1 -n %{name}-%{version}%{?pre:-%{pre}}
# temp geany config directory for allow geany to generate tags
mkdir geany_config
%build
LDFLAGS='-Wl,-z,relro -Wl,-z,now' %meson
%meson_build
# generate doc
src_dir='src'
sources=$(find "${src_dir}" -name '*.d')
for f in ${sources[@]}; do
d_path=$(dirname ${f});
d_file=$(basename ${f});
doc_file=doc-src/${d_path/${src_dir}}/${d_file/.d/.html}
ldc2 -I %{_includedir}/d/stdx-allocator -I "${src_dir}" -o- -c $f -Df
${doc_file} doc-src/index.ddoc doc-src/macros.ddoc;
done
mv doc-src html
# generate geany tags
headers=$(find src -name '*.d')
geany -c geany_config -g %{name}.d.tags ${headers[@]}
%install
%meson_install
# geany tags
mkdir -p %{buildroot}%{_datadir}/geany/tags/
install -pm0644 %{name}.d.tags %{buildroot}/%{_datadir}/geany/tags/
%ldconfig_scriptlets
%files
%license LICENSE_1_0.txt
%doc README.md
%{_libdir}/libdparse.so.%{version}
%{_libdir}/libdparse.so.%{major_version}
%files devel
%doc html
%{_libdir}/pkgconfig/dparse.pc
%{_includedir}/d/dparse
%{_libdir}/libdparse.so
%files geany-tags
%{_datadir}/geany/tags/%{name}.d.tags
%changelog
* Thu Aug 2 2018 MERCIER Jonathan - 0.9.0-1
- Initial release
=
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list --
[Bug 1613568] Review Request: stdx-allocator - High-level interface for allocators for D
https://bugzilla.redhat.com/show_bug.cgi?id=1613568 --- Comment #5 from MERCIER Jonathan --- SPEC: https://bioinfornatics.fedorapeople.org/packages/stdx-allocator.spec SRPMS: https://bioinfornatics.fedorapeople.org/packages/stdx-allocator-2.77.2-2.fc28.src.rpm $ rpmlint -i ../SRPMS/stdx-allocator-2.77.2-2.fc28.src.rpm stdx-allocator.src: W: spelling-error Summary(en_US) allocators -> locators, allocates, alligators The value of this tag appears to be misspelled. Please double-check. stdx-allocator.src: W: spelling-error %description -l en_US allocators -> locators, allocates, alligators The value of this tag appears to be misspelled. Please double-check. 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint -i stdx-allocator.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ scp stdx-allocator.spec fedorapeople:public_html/packages/ stdx-allocator.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/N7RTPPI4Q6SFZ6KL6X3EVWYEGVXIZOL6/
[Bug 1614044] Review Request: python-animatplot - Making animating in Matplotlib easy
https://bugzilla.redhat.com/show_bug.cgi?id=1614044 --- Comment #1 from Elliott Sales de Andrade --- koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=28929815 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/7K26QLGXPHELPCXZML73EEV2N5QR6DIK/
[Bug 1614044] New: Review Request: python-animatplot - Making animating in Matplotlib easy
https://bugzilla.redhat.com/show_bug.cgi?id=1614044 Bug ID: 1614044 Summary: Review Request: python-animatplot - Making animating in Matplotlib easy Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: quantum.anal...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://qulogic.fedorapeople.org//python-animatplot.spec SRPM URL: https://qulogic.fedorapeople.org//python-animatplot-0.2.2-1.fc28.src.rpm Description: A Python package for making interactive animated plots build on Matplotlib. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/YPABIPSRYJMNMOTLZWCD7WSNHQR4PAOE/
[Bug 1591473] Review Request: sassist - Dell SupportAssist log collector for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1591473 Robert-André Mauchin changed: What|Removed |Added Flags|needinfo?(zebo...@gmail.com | |) | --- Comment #9 from Robert-André Mauchin --- what do you mean? I already approved your package, now you need to request the repo and build it. If you're lost, your next step is https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/V2A6RLCSWHJETP6GAGRZKUB5YUF3O4FU/
[Bug 1613568] Review Request: stdx-allocator - High-level interface for allocators for D
https://bugzilla.redhat.com/show_bug.cgi?id=1613568 --- Comment #4 from MERCIER Jonathan --- I upload the wrong srpms I need to upload the one with meson sorry -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/FOEBHU4WU45M6ABFQJCEP3UTAJPVG376/
[Bug 1613568] Review Request: stdx-allocator - High-level interface for allocators for D
https://bugzilla.redhat.com/show_bug.cgi?id=1613568 --- Comment #3 from MERCIER Jonathan --- Thanks a lot Robert-André I followed your instruction. I do not like the versioning schema of github 'vXX.YY.ZZ' because in my directory ~/rpmbuild/SOURCES I would have plenty of archive following this schema, this involve you do not know the package name of a given archive and you could get some collision name with this schema. It is a question of taste :-) . SPEC: https://bioinfornatics.fedorapeople.org/packages/stdx-allocator.spec SRPMS: https://bioinfornatics.fedorapeople.org/packages/stdx-allocator-2.77.2-2.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/JD5HHWZGWKPUBXGHUEXBZEVMYA5HMOQU/
[Bug 1591473] Review Request: sassist - Dell SupportAssist log collector for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1591473 Charles Rose changed: What|Removed |Added Flags||needinfo?(zebo...@gmail.com ||) --- Comment #8 from Charles Rose --- (In reply to Robert-André Mauchin from comment #7) > Package approved. Hello Robert-Andre, Can you help move this along the next steps? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/2SZK7AQ2LPTHAOE4X2XWORO2U4MLKMXG/
[Bug 1613571] Review Request: containers - Efficient library to use collection in D
https://bugzilla.redhat.com/show_bug.cgi?id=1613571
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
- URL is wrong:
URL:https://github.com/dlang-community/containers
- Use this Source0:
Source0:
https://github.com/dlang-community/containers/archive/v%{version}%{?pre:-%{pre}}/%{name}-%{version}%{?pre:-%{pre}}.tar.gz
- Use meson:
# debug info seem not works with D compiler
%global debug_package %{nil}
%global major_version 0
%global minor_version 8
%global patch_version 0
%global pre alpha.9
Name: containers
Version:%{major_version}.%{minor_version}.%{patch_version}
Release:1%{?pre:.%{pre}}%{?dist}
Summary:Efficient library to use collection in D
Summary(fr):Bibliothèque efficace pour l'utilisation des collections en D
License:Boost
URL:https://github.com/dlang-community/dsymbol
Source0:
https://github.com/dlang-community/containers/archive/v%{version}%{?pre:-%{pre}}/%{name}-%{version}%{?pre:-%{pre}}.tar.gz
ExclusiveArch: %{ldc_arches}
BuildRequires: ldc meson
Requires: ldc-phobos ldc-druntime stdx-allocator
%description
Efficient library to use collection in D. Value insertion can be up to 200
time fatser than method provided by the standard lirbrary Phobos.
%description -l fr
Bibliothèque efficace pour l'utilisation des collections en D . L'insertion de
valeur peut être jusqu'a 200 fois plus rapide que la méthode proposé par la
bibliothèque standard Phobos.
%packagedevel
Summary:Development files for %{name}
Requires: %{name}%{?_isa} = %{version}-%{release}
Requires:stdx-allocator-devel
%description devel
containers package contains header files for developing D applications
that use containers.
%description devel -l fr
Le paquet containers contient les fichiers d'entêtes pour développer
des applications en D utilisant containers.
%package geany-tags
Summary:Support for enable autocompletion in geany
Requires: %{name} = %{version}-%{release}
BuildArch: noarch
BuildRequires: geany
Requires: geany
%description geany-tags
Enable autocompletion for dsymbol library in geany (IDE)
%description -l fr geany-tags
Active l'autocompletion pour pour la bibliothèque dsymbol dans geany (IDE)
%prep
%setup -q -n %{name}-%{version}%{?pre:-%{pre}}
# temp geany config directory for allow geany to generate tags
mkdir geany_config
%build
LDFLAGS='-Wl,-z,relro -Wl,-z,now' %meson
%meson_build
# generate doc
src_dir='src'
sources=$(find "${src_dir}" -name '*.d')
for f in ${sources[@]}; do
d_path=$(dirname ${f});
d_file=$(basename ${f});
doc_file=html/${d_path/${src_dir}}/${d_file/.d/.html}
ldc2 -L-lstdx-allocator -I %{_includedir}/d/stdx-allocator -I "${src_dir}"
-o- -c $f -Df ${doc_file};
done
# generate geany tags
headers=$(find src -name '*.d')
geany -c geany_config -g %{name}.d.tags ${headers[@]}
%install
%meson_install
# geany tags
mkdir -p %{buildroot}%{_datadir}/geany/tags/
install -pm0644 %{name}.d.tags %{buildroot}/%{_datadir}/geany/tags/
%files
%license LICENSE.txt
%doc README.md
%{_libdir}/libd%{name}.so.%{version}
%{_libdir}/libd%{name}.so.%{major_version}
%files devel
%doc html
%{_libdir}/pkgconfig/d%{name}.pc
%{_includedir}/d/%{name}
%{_libdir}/libd%{name}.so
%files geany-tags
%{_datadir}/geany/tags/%{name}.d.tags
%changelog
* Thu Aug 2 2018 MERCIER Jonathan -
0.8.0-1.alpha.9
- Initial release
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* BSL", "Unknown or generated". 32 files have
unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/containers/review-
containers/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[Bug 1613568] Review Request: stdx-allocator - High-level interface for allocators for D
https://bugzilla.redhat.com/show_bug.cgi?id=1613568
--- Comment #2 from Robert-André Mauchin ---
Actually you should use the %meson build system:
# debug info seem not works with D compiler
%global debug_package %{nil}
%global major_version 2
%global minor_version 77
%global patch_version 2
#%%global pre beta.7
Name: stdx-allocator
Version:%{major_version}.%{minor_version}.%{patch_version}
Release:1%{?pre:.%{pre}}%{?dist}
Summary:High-level interface for allocators for D
Summary(fr):Interface haut niveau pour les allocateurs du langage D
License:Boost
URL:https://github.com/dlang-community/stdx-allocator
Source0:
https://github.com/dlang-community/stdx-allocator/archive/v%{version}%{?pre:-%{pre}}/%{name}-%{version}%{?pre:-%{pre}}.tar.gz
ExclusiveArch: %{ldc_arches}
BuildRequires: ldc meson
%description
High-level interface for allocators for D, extracted from Phobos.
%description -l fr
Interface haut niveau pour les allocateurs du langage D. Cette interface a été
extraite de la bibliothèque standard Phobos.
%packagedevel
Summary:Development files for %{name}
Requires: %{name}%{?_isa} = %{version}-%{release}
%description devel
stdx-allocator-devel package contains header files for developing D
applications
that use stdx-allocator.
%description devel -l fr
Le paquet stdx-allocator contient les fichiers d'entêtes pour développer
des applications en D utilisant stdx-allocator.
%package geany-tags
Summary:Support for enable autocompletion in geany
Requires: %{name} = %{version}-%{release}
BuildArch: noarch
BuildRequires: geany
Requires: geany
%description geany-tags
Enable autocompletion for msgpack-d library in geany (IDE)
%description -l fr geany-tags
Active l'autocompletion pour pour la bibliothèque msgpack-d dans geany (IDE)
%prep
%autosetup -n %{name}-%{version}%{?pre:-%{pre}}
# temp geany config directory for allow geany to generate tags
mkdir geany_config
# https://github.com/dlang-community/stdx-allocator/issues/2
sed -i "s|_payload.ptr + _payload.length|cast(ulong*)(_payload.ptr +
_payload.length)|" source/stdx/allocator/building_blocks/bitmapped_block.d
%build
LDFLAGS='-Wl,-z,relro -Wl,-z,now' %meson
%meson_build
# generate doc
src_dir='source'
sources=$(find "${src_dir}" -name '*.d')
for f in ${sources[@]}; do
d_path=$(dirname ${f});
d_file=$(basename ${f});
doc_file=html/${d_path/${src_dir}}/${d_file/.d/.html}
ldc2 -I "${src_dir}" -o- -c $f -Df ${doc_file};
done
# generate geany tags
headers=$(find source -name '*.d')
geany -c geany_config -g %{name}.d.tags ${headers[@]}
%install
%meson_install
# geany tags
mkdir -p %{buildroot}%{_datadir}/geany/tags/
install -m0644 %{name}.d.tags %{buildroot}/%{_datadir}/geany/tags/
%ldconfig_scriptlets
%files
%{_libdir}/lib%{name}.so.%{version}
%{_libdir}/lib%{name}.so.0
%files devel
%doc html
%{_libdir}/pkgconfig/%{name}.pc
%{_includedir}/d/%{name}
%{_libdir}/lib%{name}.so
%files geany-tags
%{_datadir}/geany/tags/%{name}.d.tags
%changelog
* Wed Aug 1 2018 MERCIER Jonathan - 2.77.2-1
- Initial release
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/HMCTW5PFQNMN3L7UNAX7NMC4QPUO6NHQ/
[Bug 1613570] Review Request: msgpack-d - A pure D implementation of MessagePack
https://bugzilla.redhat.com/show_bug.cgi?id=1613570 --- Comment #1 from MERCIER Jonathan --- $ rpmlint -i ../SRPMS/msgpack-d-1.0.0-1.20180529gitf5c0bd0.fc28.src.rpm msgpack-d.src: W: invalid-url Source0: msgpack-d-20180529gitf5c0bd0.tar.xz The value should be a valid, public HTTP, HTTPS, or FTP URL. 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/VB5LENB2MAIOBVU66IWWIF6E7OYOBFOO/
[Bug 1607543] Review Request: python-pluginlib - A framework for creating and importing plugins in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1607543 --- Comment #24 from Fedora Update System --- python-pluginlib-0.6.1-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-5dbf2e4a71 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/GD33SFGVNKYCP4VMGHSEVGFIDNORGNDC/
[Bug 1607543] Review Request: python-pluginlib - A framework for creating and importing plugins in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1607543 --- Comment #23 from Fedora Update System --- python-pluginlib-0.6.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-437510cf18 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/HBSDNGC3LRGWEB7NSMGKZCGJJRDMA6Q3/
[Bug 1573638] Review Request: python-dotenv - Add .env support to your django/flask apps in development
https://bugzilla.redhat.com/show_bug.cgi?id=1573638 --- Comment #15 from Fernando Pereira dos Santos --- (In reply to Miro Hrončok from comment #14) > You can review my package proposal at bz1613753. I'd list you as > co-maintainer if you'd like. Yeah! Sure, I will add to my agenda. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/XZZSKIX4H7JUEYYSGKN7SRW7VOX54BKA/
[Bug 1607718] Review Request: R-igraph - Network Analysis and Visualization
https://bugzilla.redhat.com/show_bug.cgi?id=1607718 --- Comment #13 from Fedora Update System --- R-igraph-1.2.2-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/KIKABR2J7ZRMLQBG2WABV2HRZB6AJ7YO/
[Bug 1607215] Review Request: R-diffobj - Diffs for R Objects
https://bugzilla.redhat.com/show_bug.cgi?id=1607215 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-08-08 12:09:01 --- Comment #8 from Fedora Update System --- R-diffobj-0.1.11-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/FNSZCBPRMWOO3ABQSFSWMOAKAEZBBDOL/
[Bug 1607718] Review Request: R-igraph - Network Analysis and Visualization
https://bugzilla.redhat.com/show_bug.cgi?id=1607718 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-08-08 11:32:57 --- Comment #12 from Fedora Update System --- R-igraph-1.2.2-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/AGPTW32GSFXADRMPNSLPWUZLZJ5WM7UR/
[Bug 1573638] Review Request: python-dotenv - Add .env support to your django/flask apps in development
https://bugzilla.redhat.com/show_bug.cgi?id=1573638 --- Comment #14 from Miro Hrončok --- You can review my package proposal at bz1613753. I'd list you as co-maintainer if you'd like. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/2CNV6TT2OOM5E2PIQZ6W4TQPQ256IF7I/
[Bug 1610554] Review Request: hsxkpasswd - Secure memorable password generator
https://bugzilla.redhat.com/show_bug.cgi?id=1610554 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|NEW |POST CC||zbys...@in.waw.pl Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl Flags||fedora-review+ --- Comment #6 from Zbigniew Jędrzejewski-Szmek --- + package name is OK + latest version + license is acceptable for Fedora (BSD and GPLv2+) + license is specified correctly + license breakdown in a comment in the spec file + builds and install correctly + BR/R/P look OK + perl Requires line is present + fedora-review and rpmlint find no important issues Package is APPROVED. rpmlint output: hsxkpasswd.noarch: W: spelling-error %description -l en_US webcomic -> web comic, web-comic, economic hsxkpasswd.noarch: W: file-not-utf8 /usr/share/doc/hsxkpasswd/README Error checking signature of hsxkpasswd-3.6-1.fc29.noarch.rpm: hsxkpasswd-3.6-1.fc29.noarch.rpm: digests SIGNATURES NOT OK hsxkpasswd.src: W: spelling-error %description -l en_US webcomic -> web comic, web-comic, economic Error checking signature of hsxkpasswd-3.6-1.fc29.src.rpm: hsxkpasswd-3.6-1.fc29.src.rpm: digests SIGNATURES NOT OK 2 packages and 0 specfiles checked; 0 errors, 3 warnings. → all unimportant. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/ZEXSZ34GHGZ6STFQHFLCLE3J7QW3P4BK/
[Bug 1601186] Review Request: wpewebkit - A WebKit port optimized for low-end devices
https://bugzilla.redhat.com/show_bug.cgi?id=1601186
--- Comment #38 from Chris King ---
(In reply to Robert-André Mauchin from comment #36)
> we can see that CMAKE_SHARED_LINKER_FLAGS is not set to
> ${CMAKE_EXE_LINKER_FLAGS} om ARM arches.
Oh sweet, thank you so much for looking into this, that probably would've taken
me forever to find (if I ever did).
That said, I think Michael is right in that this solution is a band-aid and we
should probably ask upstream about this.
For now though, I have made that change and am attempting a build again.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/V5UUBVODDKGXCIMGSBIK7DJ2B3DOMXH4/
[Bug 1601186] Review Request: wpewebkit - A WebKit port optimized for low-end devices
https://bugzilla.redhat.com/show_bug.cgi?id=1601186 --- Comment #37 from Michael Catanzaro --- Thanks for finding a workaround. Still, it's a shame we don't understand why the existing test for whether -lrt is needed is insufficient. Oh well. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/LQKWOM3RAPNWUHZIEQIWQDJCB7CEALWQ/
[Bug 1613568] Review Request: stdx-allocator - High-level interface for allocators for D
https://bugzilla.redhat.com/show_bug.cgi?id=1613568
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
- Use:
Source0:
https://github.com/dlang-community/stdx-allocator/archive/v%{version}%{?pre:-%{pre}}/%{name}-%{version}%{?pre:-%{pre}}.tar.gz
- Remove Rpath:
[!]: Rpath absent or only used for internal libs.
Note: See rpmlint output
stdx-allocator.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libstdx-allocator.so.2.77.2 ['/usr/lib64']
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[!]: Rpath absent or only used for internal libs.
Note: See rpmlint output
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 28 files have unknown license. Detailed
output of licensecheck in /home/bob/packaging/review/stdx-allocator
/review-stdx-allocator/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 798720 bytes in 23 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in stdx-
allocator-devel , stdx-allocator-geany-tags
[?]: Package functions as described.
[x]: Latest
[Bug 1613909] Review Request: containernetworking-plugins - Libraries for writing CNI plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1613909 Lokesh Mandvekar changed: What|Removed |Added Status|NEW |ASSIGNED See Also||https://bugzilla.redhat.com ||/show_bug.cgi?id=1602064 Assignee|nob...@fedoraproject.org|fkluk...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/M2NQJNYEV6B5ZLQIMJAG27PHJJ5LEAP2/
[Bug 1613909] New: Review Request: containernetworking-plugins - Libraries for writing CNI plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1613909 Bug ID: 1613909 Summary: Review Request: containernetworking-plugins - Libraries for writing CNI plugins Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: l...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://pagure.io/containernetworking-plugins/raw/master/f/containernetworking-plugins.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/lsm5/containernetworking-plugins/fedora-rawhide-x86_64/00785823-containernetworking-plugins/containernetworking-plugins-0.7.3-1.fc29.src.rpm Description: The CNI (Container Network Interface) project consists of a specification and libraries for writing plugins to configure network interfaces in Linux containers, along with a number of supported plugins. CNI concerns itself only with network connectivity of containers and removing allocated resources when the container is deleted. Fedora Account System Username: lsm5 $ rpmlint -i containernetworking-plugins.spec SRPMS/containernetworking-plugins-0.7.3-1.fc28.src.rpm RPMS/*/* containernetworking-plugins-devel.noarch: W: spelling-error %description -l en_US github -> git hub, git-hub, GitHub The value of this tag appears to be misspelled. Please double-check. containernetworking-plugins-unit-test-devel.x86_64: W: spelling-error %description -l en_US github -> git hub, git-hub, GitHub The value of this tag appears to be misspelled. Please double-check. 6 packages and 1 specfiles checked; 0 errors, 2 warnings. Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=28923011 This is a package rename review request for containernetworking-cni, since upstream repo has changed name from 'cni' to 'plugins'. See: https://fedoraproject.org/wiki/Package_Renaming_Process -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/YPVQY6OIBLV67B5KS5PZZ2T7HCNB3BZE/
[Bug 1613383] Review Request: timescaledb - Open-source time-series database powered by PostgreSQL
https://bugzilla.redhat.com/show_bug.cgi?id=1613383 --- Comment #7 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/timescaledb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/7CXWL4BY734WKOYWJWZY4LBQKA5VDJPJ/
[Bug 1576792] Review Request: python3-webthing - HTTP Web Thing implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1576792
--- Comment #9 from Robert-André Mauchin ---
(In reply to Peter Robinson from comment #8)
> > You misunderstood me maybe, my advice is to change the Source0 to have an
> > archive name with both name and version instead of only the version:
> >
> > Source0:
> > https://github.com/mozilla-iot/webthing-python/archive/v%{version}/%{name}-
> > %{version}.tar.gz
>
> Personally I don't overly care about this, I have updated it locally, but
> AFAICT there's no packaging policy either way about this so it should not
> block the review.
>
> > The policy is still to make a subpackage even if you only make a python3
> > version. I asked about this a few moths back on IRC.
>
> Can you please provide the reference to this in the guidelines.
If I asked on IRC, it's because I didn't find it in the guidelines:
2018-02-26 18:25:47eclipseoIf a python package only supports Python 3,
should the package be named python-module with a python3-module provide, or
should it be named python3-module?
2018-02-26 18:30:07tibbseclipseo: Assuming it's a module and not an
application, name the SRPM and git repository python-foo and have that produce
the python3-foo subpackage.
2018-02-26 18:30:27tibbsIf it's an application, just name it "foo".
2018-02-26 18:30:28eclipseook thx
2018-02-26 18:30:51tibbsThe only real exception is if python-foo
already exists as a python2-only thing and the python3 version is a separate
upstream.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/XRUEJUHJE4RT7NKB2MLKHE67I274EHWM/
[Bug 1576792] Review Request: python3-webthing - HTTP Web Thing implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1576792
--- Comment #8 from Peter Robinson ---
> You misunderstood me maybe, my advice is to change the Source0 to have an
> archive name with both name and version instead of only the version:
>
> Source0:
> https://github.com/mozilla-iot/webthing-python/archive/v%{version}/%{name}-
> %{version}.tar.gz
Personally I don't overly care about this, I have updated it locally, but
AFAICT there's no packaging policy either way about this so it should not block
the review.
> The policy is still to make a subpackage even if you only make a python3
> version. I asked about this a few moths back on IRC.
Can you please provide the reference to this in the guidelines.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/WF7QYCOWEVGKX5RTRX44K22YNTUWA6R4/
[Bug 1576792] Review Request: python3-webthing - HTTP Web Thing implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1576792
--- Comment #7 from Robert-André Mauchin ---
(In reply to Peter Robinson from comment #3)
> (In reply to Robert-André Mauchin from comment #2)
> > - Use a more meaningful archive name with:
> >
> > Source0:
> > https://github.com/mozilla-iot/webthing-python/archive/v%{version}/%{name}-
> > %{version}.tar.gz
>
> When I packaged this they weren't there, it was from my request they
> happened:
> https://github.com/mozilla-iot/webthing-python/issues/13
>
You misunderstood me maybe, my advice is to change the Source0 to have an
archive name with both name and version instead of only the version:
Source0:
https://github.com/mozilla-iot/webthing-python/archive/v%{version}/%{name}-%{version}.tar.gz
>
> > - I think you should name this package python-webthing and provide a Python
> > 3 subpackage. You could use pyp2rpm to help with that: pyp2rpm -b3 webthing
> > > python-webthing.spec and then adjust the patch, license, description.
>
> I'm considering that, although I'd use python3-webthing naming because I
> have no intention of supporting py2
The policy is still to make a subpackage even if you only make a python3
version. I asked about this a few moths back on IRC.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/ODNNGPPXE7H7ZPP7ZPFIBLEJXGOSPPPV/
[Bug 1573638] Review Request: python-dotenv - Add .env support to your django/flask apps in development
https://bugzilla.redhat.com/show_bug.cgi?id=1573638 --- Comment #13 from Fernando Pereira dos Santos --- OK Miro. Sorry it took me so long to get back to you. Do you need a hand? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/MF3ATFU3HDUFLOSYD2KMMPUULUWEEAZC/
[Bug 1613383] Review Request: timescaledb - Open-source time-series database powered by PostgreSQL
https://bugzilla.redhat.com/show_bug.cgi?id=1613383 Jaroslav Škarvada changed: What|Removed |Added CC||jskar...@redhat.com Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/XP3OMDBSBELCINB2QSX4LWMCRTIVFUL6/
[Bug 1576792] Review Request: python3-webthing - HTTP Web Thing implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1576792 --- Comment #6 from Peter Robinson --- (In reply to Elliott Sales de Andrade from comment #4) > Are there any updates here? are you volunteering to review it, should now be latest upstream with a rename -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/3BKHD4LB26MPTERE5MICADCAH7OKRRDA/
[Bug 1576792] Review Request: python3-webthing - HTTP Web Thing implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1576792 Peter Robinson changed: What|Removed |Added Summary|Review Request: webthing - |Review Request: |HTTP Web Thing |python3-webthing - HTTP Web |implementation |Thing implementation Flags|needinfo?(pbrobinson@gmail. | |com)| --- Comment #5 from Peter Robinson --- SPEC: https://pbrobinson.fedorapeople.org/python3-webthing.spec SRPM: https://pbrobinson.fedorapeople.org/python3-webthing-0.7.0-1.fc28.src.rpm Description: A server implementing the HTTP Web Thing implementation. koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=28921784 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/DXIYTHVQJ3SUHWYQFD5FOV2BGQ7OYCC6/
[Bug 1613383] Review Request: timescaledb - Open-source time-series database powered by PostgreSQL
https://bugzilla.redhat.com/show_bug.cgi?id=1613383 Pavel Raiskup changed: What|Removed |Added Summary|Review Request: |Review Request: timescaledb |postgresql-timescaledb -|- Open-source time-series |Open-source time-series |database powered by |database powered by |PostgreSQL |PostgreSQL | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/FWVAEAQ76PAGNF3BTFWK6FAUQMNMCQHU/
[Bug 1613383] Review Request: postgresql-timescaledb - Open-source time-series database powered by PostgreSQL
https://bugzilla.redhat.com/show_bug.cgi?id=1613383 --- Comment #6 from Pavel Raiskup --- Thanks for the work on the package, btw.! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/PYENQWBETIVPHKG6EG5SG5XAIQZFEEFS/
[Bug 1613383] Review Request: postgresql-timescaledb - Open-source time-series database powered by PostgreSQL
https://bugzilla.redhat.com/show_bug.cgi?id=1613383
Pavel Raiskup changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #5 from Pavel Raiskup ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Header files in -devel subpackage, if present.
Note: timescaledb-debugsource :
/usr/src/debug/timescaledb-0.10.1-1.fc29.x86_64/src/cache.h timescaledb-
debugsource :
praiskup: rhbz#1542507
- All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: These BR are not needed: gcc
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
praiskup: not true anymore, rhbz#1613069
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
praiskup: it's not on ldpath
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
(v2.0)". 310 files have unknown license. Detailed output of
licensecheck in /home/praiskup/1613383-timescaledb/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
praiskup: no subpackage
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib/.build-id(iputils,
efivar-libs, gc, gdbm, gpgme, rpm-plugin-selinux, libnfsidmap, gdb-
headless, createrepo_c-libs, trousers, bzip2-libs, unzip, libdb-utils,
praisukp: broken fedora-review
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates
[Bug 1605156] Review Request: python-bundled-wheels - Wheels to be bundled with Python tools for virtual environments
https://bugzilla.redhat.com/show_bug.cgi?id=1605156 Miro Hrončok changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |NOTABUG Last Closed||2018-08-08 05:53:23 --- Comment #4 from Miro Hrončok --- OK, we'll do it differently, thanks for the review anyway. https://lists.fedoraproject.org/archives/list/python-de...@lists.fedoraproject.org/message/JA2GU7GILK4FYS5CAMOTPRCNJCAFDNRQ/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/QPTOK4ISWVIL2RXVGRJOFWHJMYBKWUNG/
[Bug 1573638] Review Request: python-dotenv - Add .env support to your django/flask apps in development
https://bugzilla.redhat.com/show_bug.cgi?id=1573638 Miro Hrončok changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |DUPLICATE Flags|fedora-review+ | |needinfo?(ferox@fedoraproje | |ct.org) | Last Closed||2018-08-08 05:51:43 --- Comment #12 from Miro Hrončok --- *** This bug has been marked as a duplicate of bug 1613753 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/6N5SIRPUPBLGWCD5SYX2NJ4EURE7BOI7/
[Bug 1613753] Review Request: python-dotenv - Add .env support to your Django/ Flask apps in development and deployments
https://bugzilla.redhat.com/show_bug.cgi?id=1613753 Miro Hrončok changed: What|Removed |Added Blocks||1610571 CC||fe...@fedoraproject.org --- Comment #1 from Miro Hrončok --- *** Bug 1573638 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1610571 [Bug 1610571] ampy-1.0.5 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/A7PALUEIXBFJ52BJO3QNJVPZKMGIPKB3/
[Bug 1613753] New: Review Request: python-dotenv - Add .env support to your Django/ Flask apps in development and deployments
https://bugzilla.redhat.com/show_bug.cgi?id=1613753 Bug ID: 1613753 Summary: Review Request: python-dotenv - Add .env support to your Django/Flask apps in development and deployments Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mhron...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-dotenv.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-dotenv-0.9.1-1.fc28.src.rpm Description: Reads the key/value pair from .env file and adds them to environment variable. Fedora Account System Username: churchyard -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/VWQLGL25VPUKKLHZPC5ZX7YQGIS4TOD5/
[Bug 1613383] Review Request: postgresql-timescaledb - Open-source time-series database powered by PostgreSQL
https://bugzilla.redhat.com/show_bug.cgi?id=1613383
--- Comment #4 from Patrik Novotný ---
Spec URL:
https://gist.githubusercontent.com/UncleAlbie/cfa3c4d70adcf39befb8fde86024080b/raw/4df53d60b614594eeb2524f70af2c81c10eb0485/timescaledb.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/panovotn/timescaledb-test/fedora-rawhide-x86_64/00785720-timescaledb/timescaledb-0.10.1-1.fc29.src.rpm
Package name has been changed to 'timescaledb'. Requirements are now specified
by %{?postgresql_module_requires} macro.
ExcludeArch shouldn't be necessary as 64-bit installation is required only when
building on Windows.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/UOZLGBNDRTE6UZB42NNPXPGTTQSZEYMW/
[Bug 1613642] Review Request: erlang-cf - Terminal color helper
https://bugzilla.redhat.com/show_bug.cgi?id=1613642 Timothée Floure changed: What|Removed |Added Blocks||1613734 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1613734 [Bug 1613734] Review Request: erlang-erlware_commons - Extension to Erlang's standard library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/4DANMNJZWG6YM5JIWTLIJFVR7CPS3APY/
[Bug 1613734] Review Request: erlang-erlware_commons - Extension to Erlang 's standard library
https://bugzilla.redhat.com/show_bug.cgi?id=1613734 Timothée Floure changed: What|Removed |Added Depends On||1613642 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1613642 [Bug 1613642] Review Request: erlang-cf - Terminal color helper -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/7WXR3HURPYLJUO5IRPKOHJF7R4IBOQCP/
[Bug 1613734] New: Review Request: erlang-erlware_commons - Extension to Erlang's standard library
https://bugzilla.redhat.com/show_bug.cgi?id=1613734 Bug ID: 1613734 Summary: Review Request: erlang-erlware_commons - Extension to Erlang's standard library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: timothee.flo...@fnux.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://fedorapeople.org/cgit/fnux/public_git/rpm-erlang-erlware_commons.git/tree/erlang-erlware_commons.spec?id=7bf3c6272e9603e8f0137cbbf13f455ce4289670 SRPM URL: https://fnux.fedorapeople.org/pkg-reviews/erlang-erlware_commons/7bf3c6272e9603e8f0137cbbf13f455ce4289670/erlang-erlware_commons-1.2.0-1.fc28.src.rpm Description: Extension to Erlang's standard library. Fedora Account System Username: fnux -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/FEZKGFDVT7HP2VTFVIZX55IEERXYWERV/
[Bug 1613383] Review Request: postgresql-timescaledb - Open-source time-series database powered by PostgreSQL
https://bugzilla.redhat.com/show_bug.cgi?id=1613383 --- Comment #3 from Pavel Raiskup --- Per upstream README prerequisities: A standard PostgreSQL 9.6 or 10 64-bit installation Does that mean that we should use ExcludeArch? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/KILMO3ORWE5D2ZMFJHCKOY4F5IGE2SSE/
[Bug 1613383] Review Request: postgresql-timescaledb - Open-source time-series database powered by PostgreSQL
https://bugzilla.redhat.com/show_bug.cgi?id=1613383 --- Comment #2 from Pavel Raiskup --- The `fedora-review -b 1613383 -m fedora-rawhide-x86_64` fails with: ERROR: Cannot find/open srpm: /tmp/1613383-postgresql-timescaledb/srpm/postgresql-timescaledb-0.10.1-1.fc28.src.rpm. Error: error reading package header Seems like the SRPM URL above isn't correct. Could you upload the file somewhere else? E.g. copr link should be OK. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/VKWPKX6ERZ3L2LSZ4UKNXTSIT5EQC35T/
