[Bug 1663283] Review Request: php-zendframework-zenddiagnostics - set of components for performing diagnostic tests
https://bugzilla.redhat.com/show_bug.cgi?id=1663283 --- Comment #5 from Remi Collet --- Very strange... I cannot reproduce, and InvalidArgumentException is exactly the expected / tested exception by this test... so not an error... Will try a scratch as soon as possible (when doctrine/migrations will be available) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1649059] Review Request: golang-contrib-opencensus-exporter - OpenCensus Go exporters for OpenCensus Agent
https://bugzilla.redhat.com/show_bug.cgi?id=1649059 --- Comment #4 from Ankur Sinha (FranciscoD) --- Hrm, built on F29 but used fedora review with rawhide configs. Let me update my system and re-run fedora-review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1663221] Review Request: php-doctrine-migrations - PHP Doctrine Migrations project
https://bugzilla.redhat.com/show_bug.cgi?id=1663221 --- Comment #4 from Remi Collet --- Thanks for the review! SCL requests https://pagure.io/releng/fedora-scm-requests/issue/9643 https://pagure.io/releng/fedora-scm-requests/issue/9644 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1672047] Review Request: smoldyn - A particle-based spatial stochastic simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1672047 --- Comment #5 from Ankur Sinha (FranciscoD) --- (In reply to Antonio Trande from comment #3) > (In reply to Ankur Sinha (FranciscoD) from comment #2) > > It's Boost 1.51 (vs Boost 1.66 on Fedora), and eigen3-3.1.1 (vs > eigen3-3.3.7 on Fedora) that is not used maybe. > Unbundling could be a bad idea. Please file a ticket upstream and add the URL to the spec as a comment. > > > * zlib (in Fedora) > > zlib is not used and compilation fails if enable it; probably cannot be > unbundled too. I see you've used zlib-devel in the spec. I expect this has been sorted? > > * SFMT (not in Fedora, but looks simple to package) Please comment in the spec that this particular library and the features it provides to smoldyn are currently unavailable. > > > > - Do the Vcell etc features require Vcell to be packaged already? If not, > > that can be enabled. Vcell is on our list, but it's a web app: > > https://pagure.io/neuro-sig/NeuroFedora/issue/213 > > - VTK support can be enabled. It's in Fedora. > > Vcell and VTK support are disabled by default and fail if enabled. Need > work. Uh---please file a ticket upstream about this too (and mention it in the spec). > > - PDE support can be enabled. I can't find a PDE software, but here's Kairos > > which also includes the same Io.cpp and Io.h files that this does: > > https://github.com/martinjrobins/Kairos/tree/master/src I wonder if > > they've > > been bundled there too. (It's only two files, so bundling them isn't too > > bad) > > > > - Shouldn't the main package also contain a versioned soname that the binary > > will use? Is smoldyn meant to be used as a library---otherwise the devel > > package is not needed either. > > Not needed. It's a private library, not shared. If you are sure that it's a private library (nothing will link against it), the -devel package should not be provided, no? The soname should be in the main package, and examples and headers not installed at all. What do you think? > > > > - Large documentation must go in a -doc subpackage. Large could be size > > (~1MB) or number of files. > > Note: Documentation size is 91258880 bytes in 1812 files. > > See: > > http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation > > ^ All the docs including the examples can go in the docs package. Otherwise > > the > > devel package becomes very large. > > Examples are not documentation, they're configuration files for testing. If they are tests for the tool and will not be used by any other software, they do not need to be provided in any package either (like the -devel package). > > > > > - Please do not include a license file if upstream has not provided it. We > > should file a bug upstream asking them to do include it. > > Why not? > > https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text > I will mail to upstream about. Yes. As the guideline says, we should first attempt the get upstream to provide it. Only if they are unresponsive or refuse, should us packagers consider including a copy ourselves. I think filing another issue upstream and mentioning it in the spec would be safer too. Re-running fedora-review on the updated spec/srpm now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674278] Review Request: tty-clock - clock using libncurses
https://bugzilla.redhat.com/show_bug.cgi?id=1674278 --- Comment #7 from id...@protonmail.com --- I fixed a typo in the URL section. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1667935] Review request nodejs-mqtt - MQTT client library for nodejs
https://bugzilla.redhat.com/show_bug.cgi?id=1667935
Hirotaka Wakabayashi changed:
What|Removed |Added
CC||hiw...@yahoo.com
--- Comment #1 from Hirotaka Wakabayashi ---
Hello, this is an unofficial review. Please read this for your reference.
Summary
===
1. rpmlint results
2. The 'Group' tag should not be used
3. Other suggestions
4. Appendix 2: Koji scratch build succeeded
Details
===
1. rpmlint results
--
A warning on the source rpm and 24 warnings on the binary rpm, which
I built on my fc29 environment::
$ rpmlint /home/vagrant/rpmbuild/SRPMS/nodejs-mqtt-2.18.8-1.fc29.src.rpm
nodejs-mqtt.src: W: no-%build-section
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpmlint
/home/vagrant/rpmbuild/RPMS/noarch/nodejs-mqtt-2.18.8-1.fc29.noarch.rpm
nodejs-mqtt.noarch: W: incoherent-version-in-changelog 2.18.8-2
['2.18.8-1.fc29', '2.18.8-1']
nodejs-mqtt.noarch: W: only-non-binary-in-usr-lib
nodejs-mqtt.noarch: W: pem-certificate
/usr/lib/node_modules/mqtt/examples/tls client/crt.ca.cg.pem
nodejs-mqtt.noarch: W: pem-certificate
/usr/lib/node_modules/mqtt/examples/tls client/tls-cert.pem
nodejs-mqtt.noarch: W: dangling-symlink
/usr/lib/node_modules/mqtt/node_modules/commist /usr/lib/node_modules/commist
nodejs-mqtt.noarch: W: dangling-symlink
/usr/lib/node_modules/mqtt/node_modules/concat-stream
/usr/lib/node_modules/concat-stream
nodejs-mqtt.noarch: W: dangling-symlink
/usr/lib/node_modules/mqtt/node_modules/end-of-stream
/usr/lib/node_modules/end-of-stream
nodejs-mqtt.noarch: W: dangling-symlink
/usr/lib/node_modules/mqtt/node_modules/es6-map /usr/lib/node_modules/es6-map
nodejs-mqtt.noarch: W: dangling-symlink
/usr/lib/node_modules/mqtt/node_modules/help-me /usr/lib/node_modules/help-me
nodejs-mqtt.noarch: W: dangling-symlink
/usr/lib/node_modules/mqtt/node_modules/inherits
/usr/lib/node_modules/inherits@2
nodejs-mqtt.noarch: W: dangling-symlink
/usr/lib/node_modules/mqtt/node_modules/minimist /usr/lib/node_modules/minimist
nodejs-mqtt.noarch: W: dangling-symlink
/usr/lib/node_modules/mqtt/node_modules/mqtt-packet
/usr/lib/node_modules/mqtt-packet
nodejs-mqtt.noarch: W: dangling-symlink
/usr/lib/node_modules/mqtt/node_modules/pump /usr/lib/node_modules/pump
nodejs-mqtt.noarch: W: dangling-symlink
/usr/lib/node_modules/mqtt/node_modules/readable-stream
/usr/lib/node_modules/readable-stream
nodejs-mqtt.noarch: W: dangling-symlink
/usr/lib/node_modules/mqtt/node_modules/reinterval
/usr/lib/node_modules/reinterval
nodejs-mqtt.noarch: W: dangling-symlink
/usr/lib/node_modules/mqtt/node_modules/split2 /usr/lib/node_modules/split2
nodejs-mqtt.noarch: W: dangling-symlink
/usr/lib/node_modules/mqtt/node_modules/websocket-stream
/usr/lib/node_modules/websocket-stream
nodejs-mqtt.noarch: W: dangling-symlink
/usr/lib/node_modules/mqtt/node_modules/xtend /usr/lib/node_modules/xtend
nodejs-mqtt.noarch: W: pem-certificate
/usr/lib/node_modules/mqtt/test/helpers/public-cert.pem
nodejs-mqtt.noarch: W: pem-certificate
/usr/lib/node_modules/mqtt/test/helpers/tls-cert.pem
nodejs-mqtt.noarch: W: pem-certificate
/usr/lib/node_modules/mqtt/test/helpers/wrong-cert.pem
nodejs-mqtt.noarch: W: no-manual-page-for-binary mqtt
nodejs-mqtt.noarch: W: no-manual-page-for-binary mqtt_pub
nodejs-mqtt.noarch: W: no-manual-page-for-binary mqtt_sub
1 packages and 0 specfiles checked; 0 errors, 24 warnings.
My review on the result above is as followings.
1.1. nodejs-mqtt.src: W: no-%build-section
I think this warning is meaningless because this module is neither a native
module nor needs no build processes and has nothing to do in %build section.
1.2. nodejs-mqtt.noarch: W: incoherent-version-in-changelog 2.18.8-2
['2.18.8-1.fc29', '2.18.8-1']
The entry of 2.18.8-1 should exist because it must be the initial version of
this package.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs
'Release: 1%{?dist}' should be 'Release: 2%{?dist}' because the latest version
in the %changelog section is 2.18.8-2.
1.3. nodejs-mqtt.noarch: W: only-non-binary-in-usr-lib
You should ignore this because the following guideline says node.js modules
written purely in JavaScript should be installed to the %nodejs_sitelib.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Node.js/#_macros
1.4. nodejs-mqtt.noarch: W: pem-certificate
/usr/lib/node_modules/mqtt/examples...
I think this warning can be ignored because this PEM certificate will be used
for example purpose.
1.5. nodejs-mqtt.noarch: W: dangling-symlink ...
I think dangling-symlink warnings should be ignored the %nodejs_symlink_deps
macro creates a node_modules tree with symlinks for each dependency listed in
package.json.
1.6. nodejs-mqtt.noarch: W: pem-certificate /usr/lib/node_modules/mqtt/test...
I think this can be igno
[Bug 1666221] Review Request: golang-github-burntsushi-locker - Simple package for conveniently using named read/write locks
https://bugzilla.redhat.com/show_bug.cgi?id=1666221 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- golang-github-burntsushi-locker-0-0.1.20190210gita6e239e.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-e489cb266b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1666285] Review Request: golang-github-mitchellh-hashstructure - Get hash values for arbitrary values in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1666285 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- golang-github-mitchellh-hashstructure-1.0.0-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-9c45b00d6c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674326] New: Review Request: R-unix - Unix System Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1674326 Bug ID: 1674326 Summary: Review Request: R-unix - Unix System Utilities Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: quantum.anal...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://qulogic.fedorapeople.org//R-unix.spec SRPM URL: https://qulogic.fedorapeople.org//R-unix-1.3-1.fc29.src.rpm Description: Bindings to system utilities found in most Unix systems such as POSIX functions which are not part of the Standard C Library. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674326] Review Request: R-unix - Unix System Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1674326 --- Comment #1 from Elliott Sales de Andrade --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=32730032 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1545479
--- Comment #9 from Felix Schwarz ---
Hi Tom, fixing all the small issues I brought up (I had hoped someone more
experienced than me would have reviewed the package by now).
I'm still hesitant to formally reviewing this package but I think I found some
more issues:
hcc package
===
- contains a folder "/usr/include/experimental" which should probably be stored
as "/usr/include/hcc/experimental"
e.g. "algorithm" (no extension?) refers to "../hcc.hpp"
- empty "/lib" folder?
- hcc-config.cmake contains references to "/opt/rocm" (should be
/usr/include/hcc?)
- also there it contains something like
set_and_check( hcc_INCLUDE_DIR "${PACKAGE_PREFIX_DIR}/include" )
- I'm not sure where this cmake file is actually used but I suspect this
should point to "${PACKAGE_PREFIX_DIR}/include/hcc" as well
- are the "cmake" files actually required by hcc directly?
- hcc.spec:
for f in clamp-device clamp-embed clamp-assemble clamp-link
hc-kernel-assemble hc-host-assemble error-check; do
mv %{buildroot}{/usr,%{_libexecdir}/hcc}/bin/$f
done
I'd prefer "install --preserve-timestamps"
hcc-runtime package
=
- empty "/lib" folder?
- does not install a license file!
rocm-device-libs
=
- does not install a license file!
hcc-runtime-devel
=
Note: Package has .a files: hcc-runtime-devel. Does not provide -static:
hcc-runtime-devel.
-> I assume you are aware of the static library and it is actually required by
some part of the ROCm stack
-> Fedora guidelines say that the static library MUST be in a -static package
(https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries)
--
I was unable to check the license of all sources (due to the huge number of
sources files + the perl check script taking forever) so far. Also several
other points which I could not check yet.
I'm also not sure if llvm counts as a bundled library and must be declared as
such (https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling), see
also Fedora's "rust" package.
Tom: I assume the rocm stack currently does not work against any upstream
version of llvm, right? Is there an official way of trying to build with a
vanilla llvm?
My plan is to work through the rest of the review items (though that will take
some time) and also check your "hip" package in parallel. That way I hope to
validate the packaging decisions made in the "hcc" package.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674278] Review Request: tty-clock - clock using libncurses
https://bugzilla.redhat.com/show_bug.cgi?id=1674278 --- Comment #6 from id...@protonmail.com --- I fixed the wrong license short name and modified the changelog -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674278] Review Request: tty-clock - clock using libncurses
https://bugzilla.redhat.com/show_bug.cgi?id=1674278 --- Comment #5 from id...@protonmail.com --- I updated my .spec file to fix the broken url and the bad paths. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674278] Review Request: tty-clock - clock using libncurses
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #4 from id...@protonmail.com ---
(In reply to leigh scott from comment #3)
> The source url is invalid
>
> spectool -g tty-clock.spec
> Getting https://github.com/xorg62/tty-clock/releases/tag/v2.3.tar.gz to
> ./v2.3.tar.gz
> % Total% Received % Xferd Average Speed TimeTime Time
> Current
> Dload Upload Total SpentLeft Speed
> 0 00 00 0 0 0 --:--:-- --:--:-- --:--:--
> 0
> curl: (22) The requested URL returned error: 404 Not Found
>
>
>
> Try using this instead
>
> Source0:%{url}/archive/v%{version}/%{name}-%{version}.tar.gz
>
>
> I also note the package installs to /usr/local, this is unacceptable.
> To fix use.
>
> %install
> %make_install PREFIX=%{_prefix}
I already fixed the broken url link on the local file on my machine.
Thank you for the "%make_install" fix, just what I was looking for!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674278] Review Request: tty-clock - clock using libncurses
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #3 from leigh scott ---
The source url is invalid
spectool -g tty-clock.spec
Getting https://github.com/xorg62/tty-clock/releases/tag/v2.3.tar.gz to
./v2.3.tar.gz
% Total% Received % Xferd Average Speed TimeTime Time Current
Dload Upload Total SpentLeft Speed
0 00 00 0 0 0 --:--:-- --:--:-- --:--:-- 0
curl: (22) The requested URL returned error: 404 Not Found
Try using this instead
Source0:%{url}/archive/v%{version}/%{name}-%{version}.tar.gz
I also note the package installs to /usr/local, this is unacceptable.
To fix use.
%install
%make_install PREFIX=%{_prefix}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674278] Review Request: tty-clock - clock using libncurses
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #2 from id...@protonmail.com ---
(In reply to Jaroslav Prokop from comment #1)
> I'll do an unofficial review, just some basic points:
> * use macros, e.g. %{_bindir}/tty-clock and %{_mandir}/man1/ ...
>
> * I don't think rm -rf buildroot is a way to go and I think there is macro
> for it
>
> * Changelog is in an invalid format (or at least not missing a few things)
>
> Please take a look at the guidelines,
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> and also take a look at Domain Specific guidelines
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> #_domain_specific_guidelines
>
> I'd also recommend running rpmlint on your spec files and rpm packages
> before submitting
>
> I wish you good luck and looking forward to your future work!
Hello,
Thank you for your points.
I've manually specified the path because tty-clock would install in
/usr/local/bin/ and not /usr/bin/ (the value for ${_bindir}, same for the man
pages.
Reading the guidelines seem to forbid installation in /usr/local, so what can I
do to make tty-clock install in /usr/bin without modifying the upstream source?
Also I have removed "rm -rf buildroot" from the .spec.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674278] Review Request: tty-clock - clock using libncurses
https://bugzilla.redhat.com/show_bug.cgi?id=1674278
Jaroslav Prokop changed:
What|Removed |Added
CC||jar.pro...@volny.cz
--- Comment #1 from Jaroslav Prokop ---
I'll do an unofficial review, just some basic points:
* use macros, e.g. %{_bindir}/tty-clock and %{_mandir}/man1/ ...
* I don't think rm -rf buildroot is a way to go and I think there is macro for
it
* Changelog is in an invalid format (or at least not missing a few things)
Please take a look at the guidelines,
https://docs.fedoraproject.org/en-US/packaging-guidelines/
and also take a look at Domain Specific guidelines
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_domain_specific_guidelines
I'd also recommend running rpmlint on your spec files and rpm packages before
submitting
I wish you good luck and looking forward to your future work!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674278] New: Review Request: tty-clock - clock using libncurses
https://bugzilla.redhat.com/show_bug.cgi?id=1674278 Bug ID: 1674278 Summary: Review Request: tty-clock - clock using libncurses Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: id...@protonmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://gitlab.com/IDF31/tty-clock-spec/blob/master/tty-clock.spec SRPM URL: https://gitlab.com/IDF31/tty-clock-spec/blob/master/tty-clock-2.3-1.fc29.src.rpm Description: A simple and cool clock made in ncurses. Fedora Account System Username: idf31 By the way this is my first package and I need a sponsor, thank you! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1662777] Review Request: python-pytest-randomly - Pytest plugin to randomly order tests and control random.seed
https://bugzilla.redhat.com/show_bug.cgi?id=1662777 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added CC||zbys...@in.waw.pl --- Comment #2 from Zbigniew Jędrzejewski-Szmek --- Looks good in general. > pytest_randomly.cpython-37-PYTEST.pyc Is this file created by pytest? It looks like it shouldn't be part of the package at all. The changelog is indeed missing. The spec file and srpm don't match anymore. Please post an updated spec file and srpm. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674260] Review Request: rust-crossbeam-queue - Concurrent queues
https://bugzilla.redhat.com/show_bug.cgi?id=1674260 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2019-02-10 15:46:42 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674260] Review Request: rust-crossbeam-queue - Concurrent queues
https://bugzilla.redhat.com/show_bug.cgi?id=1674260 --- Comment #2 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-crossbeam-queue -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674260] Review Request: rust-crossbeam-queue - Concurrent queues
https://bugzilla.redhat.com/show_bug.cgi?id=1674260 Neal Gompa changed: What|Removed |Added Status|NEW |POST Flags|fedora-review? |fedora-review+ --- Comment #1 from Neal Gompa --- Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674260] Review Request: rust-crossbeam-queue - Concurrent queues
https://bugzilla.redhat.com/show_bug.cgi?id=1674260 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674260] New: Review Request: rust-crossbeam-queue - Concurrent queues
https://bugzilla.redhat.com/show_bug.cgi?id=1674260 Bug ID: 1674260 Summary: Review Request: rust-crossbeam-queue - Concurrent queues Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: i.gnatenko.br...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-crossbeam-queue.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-crossbeam-queue-0.1.2-1.fc30.src.rpm Description: Concurrent queues. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1673854] Review Request: ephemeral - Private-by-default, always-incognito browser
https://bugzilla.redhat.com/show_bug.cgi?id=1673854 --- Comment #8 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ephemeral -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665504] Review Request: qt5-qtnetworkauth - Qt5 - NetworkAuth component
https://bugzilla.redhat.com/show_bug.cgi?id=1665504 --- Comment #5 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/qt5-qtnetworkauth -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665504] Review Request: qt5-qtnetworkauth - Qt5 - NetworkAuth component
https://bugzilla.redhat.com/show_bug.cgi?id=1665504 --- Comment #4 from Rex Dieter --- repo requested: https://pagure.io/releng/fedora-scm-requests/issue/9636 (as well as branches in followup tickets) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1665504] Review Request: qt5-qtnetworkauth - Qt5 - NetworkAuth component
https://bugzilla.redhat.com/show_bug.cgi?id=1665504 --- Comment #3 from Rex Dieter --- thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1673969] Review Request: rust-once_cell - Rust library for single assignment cells and lazy statics without macros
https://bugzilla.redhat.com/show_bug.cgi?id=1673969 Neal Gompa changed: What|Removed |Added Status|NEW |POST Flags|fedora-review? |fedora-review+ --- Comment #1 from Neal Gompa --- Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1672032] Review Request: rust-serde_stacker - Serde adapter that avoids stack overflow by dynamically growing the stack
https://bugzilla.redhat.com/show_bug.cgi?id=1672032 Neal Gompa changed: What|Removed |Added Status|NEW |POST Flags|fedora-review? |fedora-review+ --- Comment #1 from Neal Gompa --- Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1673969] Review Request: rust-once_cell - Rust library for single assignment cells and lazy statics without macros
https://bugzilla.redhat.com/show_bug.cgi?id=1673969 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1673854] Review Request: ephemeral - Private-by-default, always-incognito browser
https://bugzilla.redhat.com/show_bug.cgi?id=1673854 Igor Gnatenko changed: What|Removed |Added Status|ASSIGNED|POST Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1672032] Review Request: rust-serde_stacker - Serde adapter that avoids stack overflow by dynamically growing the stack
https://bugzilla.redhat.com/show_bug.cgi?id=1672032 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1672030] Review Request: rust-stacker - Stack growth library useful when implementing deeply recursive algorithms
https://bugzilla.redhat.com/show_bug.cgi?id=1672030 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1672030] Review Request: rust-stacker - Stack growth library useful when implementing deeply recursive algorithms
https://bugzilla.redhat.com/show_bug.cgi?id=1672030 Neal Gompa changed: What|Removed |Added Status|NEW |POST Flags|fedora-review? |fedora-review+ --- Comment #1 from Neal Gompa --- Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1671540] Review Request: rust-fake-simd - Crate for mimicking simd crate on stable Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1671540 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1671540] Review Request: rust-fake-simd - Crate for mimicking simd crate on stable Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1671540 Neal Gompa changed: What|Removed |Added Status|NEW |POST Flags|fedora-review? |fedora-review+ --- Comment #1 from Neal Gompa --- Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1673854] Review Request: ephemeral - Private-by-default, always-incognito browser
https://bugzilla.redhat.com/show_bug.cgi?id=1673854 Igor Gnatenko changed: What|Removed |Added Summary|Review Request: ephemeral - |Review Request: ephemeral - |A private-by-default, |Private-by-default, |always-incognito browser. |always-incognito browser |Inspired by Firefox Focus. | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1673854] Review Request: ephemeral - A private-by-default, always-incognito browser. Inspired by Firefox Focus.
https://bugzilla.redhat.com/show_bug.cgi?id=1673854 --- Comment #7 from Artem --- Spec file #9: https://copr-be.cloud.fedoraproject.org/results/atim/ephemeral/fedora-29-x86_64/00856896-ephemeral/ephemeral.spec SRPM: https://copr-be.cloud.fedoraproject.org/results/atim/ephemeral/fedora-29-x86_64/00856896-ephemeral/ephemeral-4.0.3-9.fc29.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674192] Review Request: nodejs-spdx-ranges - List of SPDX standard license ranges
https://bugzilla.redhat.com/show_bug.cgi?id=1674192 --- Comment #2 from Tom Hughes --- This all looks fine except for a slight query around the license. The license is clearly CC-BY but the LICENSE.md is MIT so we probably shouldn't package that and should let upstream know. A secondary problem is that while CC-BY-3.0 doesn't appear to require providing a copy of the license it does seem to require providing the URL of the license so we would need to add that I think. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1673854] Review Request: ephemeral - A private-by-default, always-incognito browser. Inspired by Firefox Focus.
https://bugzilla.redhat.com/show_bug.cgi?id=1673854 Igor Gnatenko changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674192] Review Request: nodejs-spdx-ranges - List of SPDX standard license ranges
https://bugzilla.redhat.com/show_bug.cgi?id=1674192 Tom Hughes changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674192] Review Request: nodejs-spdx-ranges - List of SPDX standard license ranges
https://bugzilla.redhat.com/show_bug.cgi?id=1674192
Tom Hughes changed:
What|Removed |Added
CC||t...@compton.nu
Assignee|nob...@fedoraproject.org|t...@compton.nu
Flags||fedora-review?
--- Comment #1 from Tom Hughes ---
This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* Creative Commons Attribution Public License
(v3.0)", "Unknown or generated", "Expat License", "*No copyright*
Creative Commons Attribution Public License (v1.0)". 2 files have
unknown license. Detailed output of licensecheck in /home/tom/1674192
-nodejs-spdx-ranges/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[!]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as d
[Bug 1674242] New: Review Request: golang-github-bep-debounce - A debouncer written in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1674242 Bug ID: 1674242 Summary: Review Request: golang-github-bep-debounce - A debouncer written in Go Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: quantum.anal...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://qulogic.fedorapeople.org//golang-github-bep-debounce.spec SRPM URL: https://qulogic.fedorapeople.org//golang-github-bep-debounce-1.2.0-1.fc29.src.rpm Description: A debouncer written in Go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674240] New: Review Request: golang-github-tdewolff-test - Go test helper functions
https://bugzilla.redhat.com/show_bug.cgi?id=1674240 Bug ID: 1674240 Summary: Review Request: golang-github-tdewolff-test - Go test helper functions Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: quantum.anal...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://qulogic.fedorapeople.org//golang-github-tdewolff-test.spec SRPM URL: https://qulogic.fedorapeople.org//golang-github-tdewolff-test-1.0.0-1.fc29.src.rpm Description: Test is a helper package written in Go. It implements a few functions that are useful for io testing, such as readers and writers that fail after N consecutive reads/writes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674240] Review Request: golang-github-tdewolff-test - Go test helper functions
https://bugzilla.redhat.com/show_bug.cgi?id=1674240 --- Comment #1 from Elliott Sales de Andrade --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=32711740 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674181] Review Request: dino - Modern XMPP ("Jabber") chat client using GTK+/Vala
https://bugzilla.redhat.com/show_bug.cgi?id=1674181
Artur Iwicki changed:
What|Removed |Added
CC||fed...@svgames.pl
--- Comment #1 from Artur Iwicki ---
>Release:0.2.%{commit_short}%{?dist}
Snapshots should also include the date of the commit.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots
># To generate this, go to a git checkout of dino, run git submodule update,
>and then tar it up like this:
># $ tar cvjf libsignal-protocol-c-bundle-2.3.2.tar.bz2
>plugins/signal-protocol/libsignal-protocol-c
>Source1:libsignal-protocol-c-bundle-2.3.2.tar.bz2
This is just personal opinion, but how about putting "%global libsignal_commit"
in the spec,
and then fetching the libsignal repo the same way the main tarball is fetched?
>%package devel
>Requires: dino == %{version}
Use a fully versioned, arched dependency here: "dino%{?_isa} ==
%{version}-%{release}"
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1644010] Review Request: golang-github-pierrec-lz4 - LZ4 compression and decompression in pure Go
https://bugzilla.redhat.com/show_bug.cgi?id=1644010 --- Comment #5 from Elliott Sales de Andrade --- Mostly because we're hitting https://pagure.io/golist/issue/7 and no tests are run, it'd be nice to see that at least a final compile works. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645264] Review Request: golang-github-euank-kmsg-parser - A simpler parser for the /dev/kmsg format
https://bugzilla.redhat.com/show_bug.cgi?id=1645264 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com Flags||fedora-review? --- Comment #1 from Elliott Sales de Andrade --- - Latest version is 2.0.1 - Common description can probably be split a bit. The CLI tool should reference the other package since it's not in -devel, and the godmesg subpackage probably shouldn't start with "This package contains a library". Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache License (v2.0)", "Unknown or generated", "Apache License (v2.0)". 4 files have unknown license. Detailed output of licensecheck in 1645264-golang-github-euank-kmsg-parser/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gocode/src, /usr/share/gocode [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/.build-id(R-date, kde-platform-plugin, qemu-ui-gtk, libhbalinux, cups-client, efivar- libs, netcdf, python3-cffi, librsync, qemu-block-gluster, rpm-plugin- selinux, abrt, ghc-transformers, ghc-parallel, libmediaart, cygwin64 -gcc-gfortran, python3-qt5-webkit, libimagequant, giflib, libreoffice- graphicfilter, openmpi, xsel, libfaketime, trousers, dirac-libs, gst- devtools, python2-h5py, libdb-utils, tracker-miners, xorg-x11-font- utils, PackageKit-command-not-found, OpenEXR-libs, ghc-monad-par- extras, libcom_err, libseccomp, double-conversion, flare-engine, ksysguardd, mingw64-qt-qmake, openblas-openmp64_, python3-pywt, fcgi, libabw, ghc-wai-extra, libvirt-daemon-driver-storage-iscsi, libid3tag, libmodman, ghc-semigroups, telepathy-gabble, cfitsio, argyllcms, parted, gnome-disk-utility, libdvdread, zstd, bluez-libs, xml- security-c, kf5-kjobwidgets, ghc-uniplate, libwebp, libxslt, quesoglc, totem-pl-parser, herqq, netty-tcnative, system-config-printer-udev, ghc-criterion, python2-nss, mingw64-gcc, libverto-libev, python2-cryptography, kf5-kdeclarative, libevdev, libgpg-error, libmaxminddb, lvm2-libs, kf5-sonnet-core, libpurple, perl-Digest-SHA, abrt-gui, perl-Params-Classify, libmicrohttpd, portmidi, med, R-httpuv, irda-utils, python3-unbound, ghc-prelude-extras, kf5-solid, libzstd, ghc-bsb-http-chunked, wxBase, libdazzle, xdg-desktop-portal- gtk, ghc-mmorph, lua-lpeg, symlinks, python3-simplejson, perl-Unicode- String, python3-crypto, armacycles-ad, libcdr, ghc-shakespeare, e2fsprogs-libs, pulseaudio-libs, libdwarf, wxGTK3-webview, tpm2-tools, lcms2, docker-rhel-push-plugin, python3-Bottleneck, avra, qemu-guest- agent, annobin, ntfs-3g, python3-pycosat, libxcb, texlive-chktex, freexl, libyubikey, remmina-plugins-st, libbdplus, python3-pycurl, python3-brlapi, postgresql-libs, mingw64-binutils, CUnit, xcb-util- keysyms, angelscript, celestia, ghc-data-default-instances-dlist, m4, python26, perl-GSSAPI, ghc-StateVar, sushi, libgphoto2, festival-lib, nss-softokn-freebl, libsavitar, R-XML, R-fansi, festival, tinyxml, xcb-util, libwmf-lite, clutter-gtk, python3-PyQt4-webkit, python3-coverage, ghc-cpphs, krb5-devel, gcc-objc++, python2-wrapt, poppler-qt, kf5-kemoticons, http-parser, qt5-qtspeech, R-fts, pulseaudio-utils, perl-Sub-Identify, R-openssl, v8-314, rubygem- hpricot, perl-PerlIO-utf8_strict, kf5-kdelibs4support-libs, python2-pyqt4-sip, pyorbit, openjpeg2-tools, ImageMagick-c++, ghc-hxt- regex-xmlschema, uniconvertor, brasero-libs, ghc-disk-free-space, polyclipping, kf5-kpackage, perl-JSON-XS, kf5-kfilemetadata, texlive- pdftex, perl-Ref-Util-XS, python3-scipy, ghc-base-unicode-symbols, gperf, kile, perl-Time-Piece, ghc-old-time, dbusmenu-qt, qca-qt5, ncurses-libs, libidn2, perl-Crypt-SSLeay, ldns, perl-Sys-Syslog, ghc- adjunctions, liblo, assimp, xorg-x11-xkb-utils, ibus-hangul, native- platform, NetworkManager-openvpn, rubygem-redcarpet, libxkbfile, ghc- cairo, hplip-libs, libwvstreams, rustfmt, ghc-binary, freerdp-libs, xm
[Bug 1655338] Review Request: rmlint - Finds space waste and other broken things on your filesystem
https://bugzilla.redhat.com/show_bug.cgi?id=1655338 Elliott Sales de Andrade changed: What|Removed |Added Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1444518] Review Request: libcoap - C library implementation of CoAP
https://bugzilla.redhat.com/show_bug.cgi?id=1444518 Peter Robinson changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Flags|fedora-review+ |fedora-review? Last Closed||2019-02-10 10:08:23 --- Comment #10 from Peter Robinson --- Thanks for the review -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1670656] Review Request: grafana - an open source, feature rich metrics dashboard and graph editor
https://bugzilla.redhat.com/show_bug.cgi?id=1670656 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com --- Comment #14 from Elliott Sales de Andrade --- Everything in the vendor directory is a bundled Go package that should be unbundled (many already are), or, less preferably, marked as such. Please also consider using the Go macros: https://fedoraproject.org/wiki/More_Go_packaging -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1663633] Review Request: clojure-maven-plugin - maven plugin to build Clojure programs
https://bugzilla.redhat.com/show_bug.cgi?id=1663633 --- Comment #3 from Markku Korkeala --- Thank you for the review, much appreciated. I updated the spec-file with the corrections. I think I added the Epoch looking some examples, not necessary so I removed it. Updated files: Spec-file: https://artifacts-space.ams3.digitaloceanspaces.com/fedora/clojure-maven-plugin/clojure-maven-plugin.spec New source rpm: https://artifacts-space.ams3.digitaloceanspaces.com/fedora/clojure-maven-plugin/clojure-maven-plugin-1.8.1-2.fc29.src.rpm Changelog for the version: * Sun Feb 10 2019 Markku Korkeala - 1.8.1-2 - Remove jpackage-utils from (Build)Requires - Use license macro for file epl-v10.html - Remove unnecessary Epoch New koji scratch build is at: https://koji.fedoraproject.org/koji/taskinfo?taskID=32710236 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674236] Review Request: rust-line-wrap - Efficiently insert line separators
https://bugzilla.redhat.com/show_bug.cgi?id=1674236 Igor Gnatenko changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE Last Closed||2019-02-10 09:15:02 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674236] Review Request: rust-line-wrap - Efficiently insert line separators
https://bugzilla.redhat.com/show_bug.cgi?id=1674236 --- Comment #2 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-line-wrap -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674236] Review Request: rust-line-wrap - Efficiently insert line separators
https://bugzilla.redhat.com/show_bug.cgi?id=1674236 Ilya Gradina changed: What|Removed |Added QA Contact|ilya.grad...@gmail.com |extras...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674236] Review Request: rust-line-wrap - Efficiently insert line separators
https://bugzilla.redhat.com/show_bug.cgi?id=1674236 Ilya Gradina changed: What|Removed |Added QA Contact|extras...@fedoraproject.org |ilya.grad...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674236] Review Request: rust-line-wrap - Efficiently insert line separators
https://bugzilla.redhat.com/show_bug.cgi?id=1674236 Igor Gnatenko changed: What|Removed |Added Assignee|nob...@fedoraproject.org|ilya.grad...@gmail.com QA Contact|ilya.grad...@gmail.com |extras...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1444518] Review Request: libcoap - C library implementation of CoAP
https://bugzilla.redhat.com/show_bug.cgi?id=1444518 --- Comment #9 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libcoap -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674236] Review Request: rust-line-wrap - Efficiently insert line separators
https://bugzilla.redhat.com/show_bug.cgi?id=1674236 Ilya Gradina changed: What|Removed |Added QA Contact|extras...@fedoraproject.org |ilya.grad...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674236] Review Request: rust-line-wrap - Efficiently insert line separators
https://bugzilla.redhat.com/show_bug.cgi?id=1674236 --- Comment #1 from Ilya Gradina --- Package looks good. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674236] Review Request: rust-line-wrap - Efficiently insert line separators
https://bugzilla.redhat.com/show_bug.cgi?id=1674236 Ilya Gradina changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674236] Review Request: rust-line-wrap - Efficiently insert line separators
https://bugzilla.redhat.com/show_bug.cgi?id=1674236 Ilya Gradina changed: What|Removed |Added CC||ilya.grad...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674236] Review Request: rust-line-wrap - Efficiently insert line separators
https://bugzilla.redhat.com/show_bug.cgi?id=1674236 Igor Gnatenko changed: What|Removed |Added Blocks||1674219 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1674219 [Bug 1674219] rust-plist-0.4.1 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1674236] New: Review Request: rust-line-wrap - Efficiently insert line separators
https://bugzilla.redhat.com/show_bug.cgi?id=1674236 Bug ID: 1674236 Summary: Review Request: rust-line-wrap - Efficiently insert line separators Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: i.gnatenko.br...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-line-wrap.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-line-wrap-0.1.1-1.fc30.src.rpm Description: Efficiently insert line separators. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
