[Bug 1684936] Review Request: golang-github-anacrolix-envpprof - Allows run time configuration of Go's pprof features and default HTTP mux

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684936

Didier  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Didier  ---
Read https://fedoraproject.org/wiki/More_Go_packaging for Guidelines.

No problem detected, package approved

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[X]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[X]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "Expat License". 1 files have unknown
 license. Detailed output of licensecheck in /tmp/1684936-golang-
 github-anacrolix-envpprof/licensecheck.txt
[X]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gocode/src,
 /usr/share/gocode
[X]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/gocode/src/github.com(...)
[-]: %build honors applicable compiler flags or justifies otherwise.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[X]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
 names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[-]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[X]: Latest version is packaged.
[X]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[X]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloa

[Bug 1547500] Review Request: python-jupyterlab - The JupyterLab notebook server extension

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1547500



--- Comment #6 from Miro Hrončok  ---
(In reply to Jens Petersen from comment #3)
> Just curious: does jupyterlab need jupyter?

jupyterlab.


(In reply to Elliott Sales de Andrade from comment #5)
> Been about a year; any progress here?

Not really, sorry about that. If anybody want's to take over, please do.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1547500] Review Request: python-jupyterlab - The JupyterLab notebook server extension

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1547500



--- Comment #7 from Miro Hrončok  ---
(In reply to Miro Hrončok from comment #6)
> (In reply to Jens Petersen from comment #3)
> > Just curious: does jupyterlab need jupyter?
> 
> jupyterlab.


Ignore that part. I need my morning coffee.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685022] Review Request: HepMC3 - C++ Event Record for Monte Carlo Generators

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685022



--- Comment #2 from Mattias Ellert  ---
(In reply to Robert-André Mauchin from comment #1)
>  - make %{?_smp_mflags} → %make_build
> 
>  - make install DESTDIR=%{buildroot} → %make_install

I know these macros exist. I find them to be obfuscating and confusing and not
at all helpful or clarifying. So not using them was a conscious decision on my
part. For me they make the specfile harder to read.

>  - The libraries should be versioned:
> 
> %{_libdir}/libHepMC3.so
> 
> %{_libdir}/libHepMC3search.so

I contacted uppstream and they added a soname, I have added a patch with this
change taken from the upstream git in this updated version:

Spec URL: http://www.grid.tsl.uu.se/review/HepMC3.spec
SRPM URL: http://www.grid.tsl.uu.se/review/HepMC3-3.1.0-2.fc29.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1376387] Review Request: golang-github-Unknwon-com - Commonly used functions for the Go programming language

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1376387



--- Comment #5 from Matthias Runge  ---
Ugh, how could I miss this.

However, I don't have any interest in this, and am happy to give this package
to someone caring better than I did.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1377227] Review Request: golang-github-go-stack-stack - Implements utilities to capture, manipulate, and format call stacks

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1377227



--- Comment #7 from Matthias Runge  ---
Ugh, how could I miss this.

However, I don't have any interest in this, and am happy to give this package
to someone caring better than I did, or to just retire the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1547500] Review Request: python-jupyterlab - The JupyterLab notebook server extension

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1547500

José Matos  changed:

   What|Removed |Added

 CC||jama...@fc.up.pt



--- Comment #8 from José Matos  ---
Installing current jupyterlab with pip I get:

$ pip3 list --user
Package   Version
- ---
jupyterlab0.35.4 
jupyterlab-server 0.2.0  

By comparison last year (June) install had:
$ pip3 list --user
Package Version
--- ---
jupyterlab  0.32.1 
jupyterlab-launcher 0.10.5 
orthopy 0.5.3  
pipdate 0.3.1  
pyprof2calltree 1.4.3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685515] Review Request: python-sphinxcontrib-devhelp - Sphinx extension for Devhelp documents

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685515

Miro Hrončok  changed:

   What|Removed |Added

 Blocks||1685211




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1685211
[Bug 1685211] Update Sphinx to version 2 and drop Python 2 support from Sphinx
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685515] New: Review Request: python-sphinxcontrib-devhelp - Sphinx extension for Devhelp documents

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685515

Bug ID: 1685515
   Summary: Review Request: python-sphinxcontrib-devhelp - Sphinx
extension for Devhelp documents
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mhron...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://churchyard.fedorapeople.org/SRPMS/python-sphinxcontrib-devhelp.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/python-sphinxcontrib-devhelp-1.0.1-1.fc29.src.rpm

Description:
sphinxcontrib-devhelp is a sphinx extension which outputs Devhelp document.

Fedora Account System Username: churchyard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685519] New: Review Request: python-sphinxcontrib-jsmath - Sphinx extension for math in HTML via JavaScript

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685519

Bug ID: 1685519
   Summary: Review Request: python-sphinxcontrib-jsmath - Sphinx
extension for math in HTML via JavaScript
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mhron...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://churchyard.fedorapeople.org/SRPMS/python-sphinxcontrib-jsmath.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/python-sphinxcontrib-jsmath-1.0.1-1.fc29.src.rpm

Description:
sphinxcontrib-jsmath is a sphinx extension which renders display math in HTML
via JavaScript.

Fedora Account System Username: churchyard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685519] Review Request: python-sphinxcontrib-jsmath - Sphinx extension for math in HTML via JavaScript

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685519

Miro Hrončok  changed:

   What|Removed |Added

 Blocks||1685211




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1685211
[Bug 1685211] Update Sphinx to version 2 and drop Python 2 support from Sphinx
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685524] New: Review Request: python-sphinxcontrib-htmlhelp - Sphinx extension for HTML help files

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685524

Bug ID: 1685524
   Summary: Review Request: python-sphinxcontrib-htmlhelp - Sphinx
extension for HTML help files
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mhron...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://churchyard.fedorapeople.org/SRPMS/python-sphinxcontrib-htmlhelp.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/python-sphinxcontrib-htmlhelp-1.0.1-1.fc29.src.rpm

Description:
sphinxcontrib-htmlhelp is a sphinx extension which renders HTML help files.

Fedora Account System Username: churchyard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685524] Review Request: python-sphinxcontrib-htmlhelp - Sphinx extension for HTML help files

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685524

Miro Hrončok  changed:

   What|Removed |Added

 Blocks||1685211




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1685211
[Bug 1685211] Update Sphinx to version 2 and drop Python 2 support from Sphinx
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685530] New: Review Request: python-sphinxcontrib-qthelp - Sphinx extension for QtHelp documents

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685530

Bug ID: 1685530
   Summary: Review Request: python-sphinxcontrib-qthelp - Sphinx
extension for QtHelp documents
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mhron...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://churchyard.fedorapeople.org/SRPMS/python-sphinxcontrib-qthelp.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/python-sphinxcontrib-qthelp-1.0.2-1.fc29.src.rpm

Description:
sphinxcontrib-qthelp is a sphinx extension which outputs QtHelp document.

Fedora Account System Username: churchyard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685530] Review Request: python-sphinxcontrib-qthelp - Sphinx extension for QtHelp documents

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685530

Miro Hrončok  changed:

   What|Removed |Added

 Blocks||1685211




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1685211
[Bug 1685211] Update Sphinx to version 2 and drop Python 2 support from Sphinx
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1670441] Review Request: setconf - Tool for changing values of parameters in text files

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1670441

Miro Hrončok  changed:

   What|Removed |Added

 CC||jama...@redhat.com
  Flags||needinfo?(jama...@redhat.co
   ||m)



--- Comment #28 from Miro Hrončok  ---
> Fedora Account System Username: jama...@redhat.com

Jan, what is your Fedora username? Do you have a FAS account?
https://admin.fedoraproject.org/accounts/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1547500] Review Request: python-jupyterlab - The JupyterLab notebook server extension

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1547500



--- Comment #9 from Lumír Balhar  ---
I did the same in a completely empty virtual environment (Python 3.7) and the
result is this huge list of packages:

$ pip freeze
attrs==19.1.0
backcall==0.1.0
bleach==3.1.0
decorator==4.3.2
defusedxml==0.5.0
entrypoints==0.3
ipykernel==5.1.0
ipython==7.3.0
ipython-genutils==0.2.0
jedi==0.13.3
Jinja2==2.10
jsonschema==3.0.1
jupyter-client==5.2.4
jupyter-core==4.4.0
jupyterlab==0.35.4
jupyterlab-server==0.2.0
MarkupSafe==1.1.1
mistune==0.8.4
nbconvert==5.4.1
nbformat==4.4.0
notebook==5.7.4
pandocfilters==1.4.2
parso==0.3.4
pexpect==4.6.0
pickleshare==0.7.5
prometheus-client==0.6.0
prompt-toolkit==2.0.9
ptyprocess==0.6.0
Pygments==2.3.1
pyrsistent==0.14.11
python-dateutil==2.8.0
pyzmq==18.0.1
Send2Trash==1.5.0
six==1.12.0
terminado==0.8.1
testpath==0.4.2
tornado==6.0.1
traitlets==4.3.2
wcwidth==0.1.7
webencodings==0.5.1

And it seems that it also bundles semver.py.

I am willing to help because jupyterlab is my favorite tool. Is there anybody
who would like to drive this effort and create some todo list?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1547500] Review Request: python-jupyterlab - The JupyterLab notebook server extension

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1547500



--- Comment #10 from Miro Hrončok  ---
I've stopped a year ago because the javascript needed internet to build.

Anyway, see this:

In [5]: for pkg, version in pypkgs:
   ...: print(pkg, version)
   ...: subprocess.run(('dnf', 'repoquery', '--repo=rawhide',
'--whatprovides', f'python3dist({pkg.lower()})'), stderr=subprocess.DEVNULL)
   ...: print()

attrs 19.1.0
python3-attrs-0:17.4.0-8.fc30.noarch

backcall 0.1.0
python3-backcall-0:0.1.0-5.fc30.noarch

bleach 3.1.0
python3-bleach-0:3.0.2-2.fc30.noarch

decorator 4.3.2
python3-decorator-0:4.3.0-2.fc30.noarch

defusedxml 0.5.0
python3-defusedxml-0:0.5.0-7.fc30.noarch

entrypoints 0.3
python3-entrypoints-0:0.2.3-11.fc30.noarch

ipykernel 5.1.0
python3-ipykernel-0:5.1.0-1.fc30.noarch

ipython 7.3.0
python3-ipython-0:7.2.0-2.fc30.noarch

ipython-genutils 0.2.0
python3-ipython_genutils-0:0.1.0-16.fc30.noarch

jedi 0.13.3
python3-jedi-0:0.12.1-3.fc30.noarch

Jinja2 2.10
python3-jinja2-0:2.10-7.fc30.noarch

jsonschema 3.0.1
python3-jsonschema-0:3.0.0~b3-2.fc30.noarch

jupyter-client 5.2.4
python3-jupyter-client-0:5.2.3-7.fc30.noarch

jupyter-core 4.4.0
python3-jupyter-core-0:4.4.0-7.fc30.noarch

jupyterlab 0.35.4

jupyterlab-server 0.2.0

MarkupSafe 1.1.1
python3-markupsafe-0:1.0-2.fc30.x86_64

mistune 0.8.4
python3-mistune-0:0.8.3-6.fc30.x86_64

nbconvert 5.4.1
python3-nbconvert-0:5.4.1-1.fc30.noarch

nbformat 4.4.0
python3-nbformat-0:4.4.0-6.fc30.noarch

notebook 5.7.4
python3-notebook-0:5.7.2-2.fc30.noarch

pandocfilters 1.4.2
python3-pandocfilters-0:1.4.1-7.fc30.noarch

parso 0.3.4
python3-parso-0:0.3.1-2.fc30.noarch

pexpect 4.6.0
python3-pexpect-0:4.6-3.fc30.noarch

pickleshare 0.7.5
python3-pickleshare-0:0.7.4-11.fc30.noarch

prometheus-client 0.6.0
python3-prometheus_client-0:0.5.0-1.fc30.noarch

prompt-toolkit 2.0.9
python3-prompt-toolkit-0:2.0.7-2.fc30.noarch

ptyprocess 0.6.0
python3-ptyprocess-0:0.6.0-4.fc30.noarch

Pygments 2.3.1
python3-pygments-0:2.2.0-15.fc30.noarch

pyrsistent 0.14.11
python3-pyrsistent-0:0.14.9-2.fc30.x86_64

python-dateutil 2.8.0
python3-dateutil-1:2.8.0-1.fc30.noarch

pyzmq 18.0.1
python3-zmq-0:17.0.0-4.fc30.x86_64

Send2Trash 1.5.0
python3-send2trash-0:1.4.2-7.fc30.noarch

six 1.12.0
python3-six-0:1.12.0-1.fc30.noarch

terminado 0.8.1
python3-terminado-0:0.8.1-9.fc30.noarch

testpath 0.4.2
python3-testpath-0:0.3.1-7.fc30.noarch

tornado 6.0.1
python3-tornado-0:5.0.2-5.fc30.x86_64

traitlets 4.3.2
python3-traitlets-0:4.3.2-8.fc30.noarch

wcwidth 0.1.7
python3-wcwidth-0:0.1.7-9.fc30.noarch

webencodings 0.5.1
python3-webencodings-0:0.5.1-7.fc30.noarch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1684936] Review Request: golang-github-anacrolix-envpprof - Allows run time configuration of Go's pprof features and default HTTP mux

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684936

Didier Fabert (tartare)  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685200] Review Request: build2 - Cross-platform build toolchain for developing and packaging C++ code

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685200

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #7 from Robert-André Mauchin  ---
Seems everything is good, package is approved.


You still need to find a sponsor.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685270] Review request: git-secret - A bash-tool to store your private data inside a git repository

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685270

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
LGTM, package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1684933] Review Request: golang-github-bradfitz-iter - Range over integers [0,n).

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684933

Robert-André Mauchin  changed:

   What|Removed |Added

 Blocks||1684948




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1684948
[Bug 1684948] Review Request: golang-github-anacrolix-tagflag - Declarative
flag parsing for Go using struct tags
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1684929] Review Request: golang-github-huandu-xstrings - A collection of useful string functions in Go

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684929

Robert-André Mauchin  changed:

   What|Removed |Added

 Blocks||1684948




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1684948
[Bug 1684948] Review Request: golang-github-anacrolix-tagflag - Declarative
flag parsing for Go using struct tags
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1684948] Review Request: golang-github-anacrolix-tagflag - Declarative flag parsing for Go using struct tags

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684948

Robert-André Mauchin  changed:

   What|Removed |Added

 Depends On||1684933, 1684929



--- Comment #2 from Robert-André Mauchin  ---
All are packaged and need review. Missinggo is bootstrapped to avoid the
dependency loop.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1684929
[Bug 1684929] Review Request: golang-github-huandu-xstrings - A collection of
useful string functions in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1684933
[Bug 1684933] Review Request: golang-github-bradfitz-iter - Range over integers
[0,n).
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1684933] Review Request: golang-github-bradfitz-iter - Range over integers [0,n).

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684933



--- Comment #2 from Robert-André Mauchin  ---
Thanks for the review!

Spec URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone1.45/fedora-rawhide-x86_64/00864817-golang-github-bradfitz-iter/golang-github-bradfitz-iter.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone1.45/fedora-rawhide-x86_64/00864817-golang-github-bradfitz-iter/golang-github-bradfitz-iter-0-0.1.20190303git33e6a98.fc30.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685022] Review Request: HepMC3 - C++ Event Record for Monte Carlo Generators

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685022



--- Comment #3 from Robert-André Mauchin  ---
 - Note: %ldconfig_scriptlets is not needed anymore on F30/Rawhide. If you plan
for F29/EPEL, it's ok to keep it.

 - There are issues with the interface subpackage. It contains include files
and require a -devel dependency:

HepMC3-interfaces.noarch: E: devel-dependency HepMC3-devel


HepMC3-interfaces.noarch: W: devel-file-in-non-devel-package
/usr/share/HepMC3/interfaces/Photospp/include/Photos/PhotosHepMC3Event.h
HepMC3-interfaces.noarch: W: devel-file-in-non-devel-package
/usr/share/HepMC3/interfaces/Photospp/include/Photos/PhotosHepMC3Particle.h
HepMC3-interfaces.noarch: W: devel-file-in-non-devel-package
/usr/share/HepMC3/interfaces/Tauolapp/include/Tauola/TauolaHepMC3Event.h
HepMC3-interfaces.noarch: W: devel-file-in-non-devel-package
/usr/share/HepMC3/interfaces/Tauolapp/include/Tauola/TauolaHepMC3Particle.h
HepMC3-interfaces.noarch: W: devel-file-in-non-devel-package
/usr/share/HepMC3/interfaces/Tauolapp/src/TauolaHepMC3Event.cxx
HepMC3-interfaces.noarch: W: devel-file-in-non-devel-package
/usr/share/HepMC3/interfaces/Tauolapp/src/TauolaHepMC3Particle.cxx
HepMC3-interfaces.noarch: W: devel-file-in-non-devel-package
/usr/share/HepMC3/interfaces/mc-tester/include/HepMC3Event.h
HepMC3-interfaces.noarch: W: devel-file-in-non-devel-package
/usr/share/HepMC3/interfaces/mc-tester/include/HepMC3Particle.h
HepMC3-interfaces.noarch: W: devel-file-in-non-devel-package
/usr/share/HepMC3/interfaces/mc-tester/src/HepMC3Event.cxx
HepMC3-interfaces.noarch: W: devel-file-in-non-devel-package
/usr/share/HepMC3/interfaces/mc-tester/src/HepMC3Particle.cxx
HepMC3-interfaces.noarch: W: devel-file-in-non-devel-package
/usr/share/HepMC3/interfaces/pythia8/include/Pythia8/Pythia8ToHepMC3.h

   Should this be a interfaces-devel package instead?





Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Header files in -devel subpackage, if present.
  Note: HepMC3-interfaces :
  /usr/share/HepMC3/interfaces/Photospp/include/Photos/PhotosHepMC3Event.h
  HepMC3-interfaces :
  /usr/share/HepMC3/interfaces/Photospp/include/Photos/PhotosHepMC3Particle.h
  HepMC3-interfaces :
  /usr/share/HepMC3/interfaces/Tauolapp/include/Tauola/TauolaHepMC3Event.h
  HepMC3-interfaces :
  /usr/share/HepMC3/interfaces/Tauolapp/include/Tauola/TauolaHepMC3Particle.h
  HepMC3-interfaces : /usr/share/HepMC3/interfaces/mc-
  tester/include/HepMC3Event.h HepMC3-interfaces :
  /usr/share/HepMC3/interfaces/mc-tester/include/HepMC3Particle.h
  HepMC3-interfaces :
  /usr/share/HepMC3/interfaces/pythia8/include/Pythia8/Pythia8ToHepMC3.h
  HepMC3-doc : /usr/share/doc/HepMC3/examples/ConvertExample/cmdline.h
  HepMC3-doc :
  /usr/share/doc/HepMC3/examples/ConvertExample/include/WriterHEPEVTZEUS.h
  HepMC3-doc :
  /usr/share/doc/HepMC3/examples/ConvertExample/include/WriterRootTreeOPAL.h
  HepMC3-doc :
  /usr/share/doc/HepMC3/examples/RootIOExample2/include/LinkDef.h
  HepMC3-doc :
  /usr/share/doc/HepMC3/examples/RootIOExample2/include/MyClass.h
  HepMC3-doc :
  /usr/share/doc/HepMC3/examples/RootIOExample2/include/MyRunClass.h
  HepMC3-doc :
  /usr/share/doc/HepMC3/examples/RootIOExample2/include/myclass_Classes.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
 BuildRequires against gcc, gcc-c++ or clang.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GNU General Public License", "GPL (v2)", "Unknown or
 generated". 227 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/HepMC3/review-
 HepMC3/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc 

[Bug 1645294] Review Request: delve - Debugger for Go programming language

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1645294



--- Comment #47 from Fedora Update System  ---
delve-1.2.0-1.fc29 has been pushed to the Fedora 29 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-5c4f0a0da7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1684437] Review Request: php-mkopinsky-zxcvbn-php - Realistic password strength estimation PHP library

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684437

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
php-mkopinsky-zxcvbn-php-4.4.2-1.fc29 has been pushed to the Fedora 29 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-c5233c2b67

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1672598] Review Request: golang-github-spf13-jwalterweatherman - So you always leave a note

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1672598

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
golang-github-spf13-jwalterweatherman-1.1.0-1.fc29 has been pushed to the
Fedora 29 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-dd9b295d8b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1664384] Review Request: python-yaspin - library for terminal spinners

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1664384



--- Comment #12 from Patrik Kopkan  ---
Done: https://src.fedoraproject.org/rpms/python-yaspin/settings#usersgroups-tab
.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685270] Review request: git-secret - A bash-tool to store your private data inside a git repository

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685270



--- Comment #4 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/git-secret

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1671790] Review Request: python-vistir - python library including utility functions

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1671790
Bug 1671790 depends on bug 1664384, which changed state.

Bug 1664384 Summary: Review Request: python-yaspin - library for terminal 
spinners
https://bugzilla.redhat.com/show_bug.cgi?id=1664384

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NEXTRELEASE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1664384] Review Request: python-yaspin - library for terminal spinners

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1664384

Patrik Kopkan  changed:

   What|Removed |Added

 Status|POST|CLOSED
   Fixed In Version||python-yaspin-0.14.0-4.fc30
 Resolution|--- |NEXTRELEASE
Last Closed||2019-03-05 14:58:10



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1684938] Review Request: golang-github-docopt - A command-line arguments parser

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684938



--- Comment #2 from Robert-André Mauchin  ---
> Move Version above %gometa (and you can drop %commit).

I am packaging the latest commit because it fixes some stuff since the latest
release. The project is abandoned since 2016, so I don't expect any new
release.


> golang-github-docopt-docopt-go exists, but it appears to be orphaned and
retired. This uses the new name, so the file conflicts below are fine. You may
want to add Obsoletes/Provides for this (though hopefully no-one uses the
-devel name instead of the macro shortcuts.)

Added.


Spec URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone1.45/fedora-rawhide-x86_64/00864828-golang-github-docopt/golang-github-docopt.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone1.45/fedora-rawhide-x86_64/00864828-golang-github-docopt/golang-github-docopt-0.6.2-1.20190303gitee0de3b.fc30.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685515] Review Request: python-sphinxcontrib-devhelp - Sphinx extension for Devhelp documents

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685515

Patrik Kopkan  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1671064] Review Request: libldac - LDAC library from AOSP

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1671064

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2019-03-05 15:20:50



--- Comment #18 from Fedora Update System  ---
libldac-2.0.2.2-4.fc29 has been pushed to the Fedora 29 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1680253] Review Request: R-generics - Common S3 model fitting generics not provided by base R methods

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1680253



--- Comment #9 from Fedora Update System  ---
R-generics-0.0.2-1.fc29 has been pushed to the Fedora 29 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1680194] Review Request: R-remotes - R Package Installation from Remote Repositories

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1680194



--- Comment #9 from Fedora Update System  ---
R-remotes-2.0.2-1.fc29 has been pushed to the Fedora 29 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1675937] Review Request: golang-github-transip-gotransip - TransIP API client for Go

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1675937



--- Comment #9 from Fedora Update System  ---
golang-github-transip-gotransip-5.8.1-2.fc29 has been pushed to the Fedora 29
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1680254] Review Request: R-ellipsis - Tools for Working with ...

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1680254



--- Comment #9 from Fedora Update System  ---
R-ellipsis-0.1.0-1.fc29 has been pushed to the Fedora 29 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1672272] Review Request: tpm2-pkcs11 - PKCS#11 interface for TPM 2.0 hardware

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1672272

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2019-03-05 15:20:53



--- Comment #9 from Fedora Update System  ---
tpm2-pkcs11-0-0.1.20190219git836d715.fc29 has been pushed to the Fedora 29
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1679191] Review Request: yubihsm-connector - Backend to talk to YubiHSM 2

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1679191

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #4 from Fedora Update System  ---
yubihsm-connector-2.0.0-1.fc29 has been submitted as an update to Fedora 29.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-b7c88498ef

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1684929] Review Request: golang-github-huandu-xstrings - A collection of useful string functions in Go

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684929



--- Comment #2 from Robert-André Mauchin  ---
Thanks for the reviews.


Spec URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone1.45/fedora-rawhide-x86_64/00864838-golang-github-huandu-xstrings/golang-github-huandu-xstrings.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone1.45/fedora-rawhide-x86_64/00864838-golang-github-huandu-xstrings/golang-github-huandu-xstrings-1.2.0-1.fc30.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685519] Review Request: python-sphinxcontrib-jsmath - Sphinx extension for math in HTML via JavaScript

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685519

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
Package approved.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (unspecified)", "BSD 2-clause "Simplified" License",
 "Unknown or generated", "*No copyright* BSD (unspecified)". 17 files
 have unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/python-sphinxcontrib-jsmath/review-python-
 sphinxcontrib-jsmath/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/python3.7/site-
 packages/sphinxcontrib(python3-sphinxcontrib-spelling, python3
 -sphinxcontrib-bibtex, python3-sphinxcontrib-seqdiag, python3
 -sphinxcontrib-adadomain, python3-sphinxcontrib-programoutput, python3
 -sphinxcontrib-fulltoc, python3-sphinxcontrib-actdiag, python3
 -sphinxcontrib-issuetracker, python3-sphinxcontrib-blockdiag, python3
 -sphinxcontrib-autoprogram, python3-sphinxcontrib-phpdomain, python3
 -sphinxcontrib-httpdomain)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
 packages named with the unversioned python- prefix unless no properly
 versioned package exists. Dependencies on Python packages instead MUST
 use names beginning with python2- or python3- as appropriate.

[Bug 1685524] Review Request: python-sphinxcontrib-htmlhelp - Sphinx extension for HTML help files

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685524

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
Package approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (unspecified)", "BSD 2-clause "Simplified" License",
 "Unknown or generated", "*No copyright* BSD (unspecified)". 75 files
 have unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/python-sphinxcontrib-htmlhelp/review-
 python-sphinxcontrib-htmlhelp/licensecheck.txt
[-]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/locale/cak/LC_MESSAGES,
 /usr/share/locale/cak
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/python3.7/site-
 packages/sphinxcontrib(python3-sphinxcontrib-spelling, python3
 -sphinxcontrib-bibtex, python3-sphinxcontrib-seqdiag, python3
 -sphinxcontrib-adadomain, python3-sphinxcontrib-programoutput, python3
 -sphinxcontrib-fulltoc, python3-sphinxcontrib-actdiag, python3
 -sphinxcontrib-issuetracker, python3-sphinxcontrib-blockdiag, python3
 -sphinxcontrib-autoprogram, python3-sphinxcontrib-phpdomain, python3
 -sphinxcontrib-httpdomain)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
 packages named with the unversioned python- prefi

[Bug 1685530] Review Request: python-sphinxcontrib-qthelp - Sphinx extension for QtHelp documents

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685530

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
Package approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (unspecified)", "BSD 2-clause "Simplified" License",
 "Unknown or generated", "*No copyright* BSD (unspecified)". 71 files
 have unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/python-sphinxcontrib-qthelp/review-python-
 sphinxcontrib-qthelp/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/python3.7/site-
 packages/sphinxcontrib(python3-sphinxcontrib-spelling, python3
 -sphinxcontrib-bibtex, python3-sphinxcontrib-seqdiag, python3
 -sphinxcontrib-adadomain, python3-sphinxcontrib-programoutput, python3
 -sphinxcontrib-fulltoc, python3-sphinxcontrib-actdiag, python3
 -sphinxcontrib-issuetracker, python3-sphinxcontrib-blockdiag, python3
 -sphinxcontrib-autoprogram, python3-sphinxcontrib-phpdomain, python3
 -sphinxcontrib-httpdomain)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
 packages named with the unversioned python- prefix unless no properly
 versioned package exists. Dependencies on Python packages instead MUS

[Bug 1685524] Review Request: python-sphinxcontrib-htmlhelp - Sphinx extension for HTML help files

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685524



--- Comment #2 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-sphinxcontrib-htmlhelp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685519] Review Request: python-sphinxcontrib-jsmath - Sphinx extension for math in HTML via JavaScript

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685519



--- Comment #2 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-sphinxcontrib-jsmath

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685022] Review Request: HepMC3 - C++ Event Record for Monte Carlo Generators

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685022



--- Comment #4 from Mattias Ellert  ---
(In reply to Robert-André Mauchin from comment #3)
>  - Note: %ldconfig_scriptlets is not needed anymore on F30/Rawhide. If you
> plan for F29/EPEL, it's ok to keep it.

This is for EPEL 7 too.

>  - There are issues with the interface subpackage. It contains include files
> and require a -devel dependency:
> 
> HepMC3-interfaces.noarch: E: devel-dependency HepMC3-devel
> 
> [...]
> 
>Should this be a interfaces-devel package instead?

This is reasonable. New version:

Spec URL: http://www.grid.tsl.uu.se/review/HepMC3.spec
SRPM URL: http://www.grid.tsl.uu.se/review/HepMC3-3.1.0-3.fc29.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685270] Review request: git-secret - A bash-tool to store your private data inside a git repository

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685270

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #5 from Fedora Update System  ---
git-secret-0.2.5-2.fc29 has been submitted as an update to Fedora 29.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-962eb8fe28

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685270] Review request: git-secret - A bash-tool to store your private data inside a git repository

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685270



--- Comment #6 from Fedora Update System  ---
git-secret-0.2.5-2.fc30 has been submitted as an update to Fedora 30.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-7845890e44

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1680435] Review Request: wp-cli - The command line interface for WordPress

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1680435

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #3 from Fedora Update System  ---
wp-cli-2.1.0-1.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-c65e24e2b6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685270] Review request: git-secret - A bash-tool to store your private data inside a git repository

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685270



--- Comment #7 from Gergely Gombos  ---
Koji builds successful

Rawhide https://koji.fedoraproject.org/koji/taskinfo?taskID=33188736
F30 https://koji.fedoraproject.org/koji/taskinfo?taskID=33189245
F29 https://koji.fedoraproject.org/koji/taskinfo?taskID=33189247

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1684936] Review Request: golang-github-anacrolix-envpprof - Allows run time configuration of Go's pprof features and default HTTP mux

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684936

J. Scheurich  changed:

   What|Removed |Added

 CC||muft...@web.de



--- Comment #3 from J. Scheurich  ---
BTW:

$ rpmbuild -ba golang-github-anacrolix-envpprof.spec
warning: -u use in %forgemeta is deprecated, use -z instead to select a
separate 
set of rpm variables!
...
$

The package compiles anyway

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685530] Review Request: python-sphinxcontrib-qthelp - Sphinx extension for QtHelp documents

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685530



--- Comment #2 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-sphinxcontrib-qthelp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685524] Review Request: python-sphinxcontrib-htmlhelp - Sphinx extension for HTML help files

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685524

Miro Hrončok  changed:

   What|Removed |Added

 Status|POST|CLOSED
   Fixed In Version||python-sphinxcontrib-htmlhe
   ||lp-1.0.1-1.fc31
 Resolution|--- |RAWHIDE
Last Closed||2019-03-05 16:39:35



--- Comment #3 from Miro Hrončok  ---
Thank You.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685519] Review Request: python-sphinxcontrib-jsmath - Sphinx extension for math in HTML via JavaScript

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685519

Miro Hrončok  changed:

   What|Removed |Added

 Status|POST|CLOSED
   Fixed In Version||python-sphinxcontrib-jsmath
   ||-1.0.1-1.fc31
 Resolution|--- |RAWHIDE
Last Closed||2019-03-05 16:40:01



--- Comment #3 from Miro Hrončok  ---
Thank You.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685530] Review Request: python-sphinxcontrib-qthelp - Sphinx extension for QtHelp documents

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685530

Miro Hrončok  changed:

   What|Removed |Added

 Status|POST|CLOSED
   Fixed In Version||python-sphinxcontrib-qthelp
   ||-1.0.2-1.fc31
 Resolution|--- |RAWHIDE
Last Closed||2019-03-05 16:41:59



--- Comment #3 from Miro Hrončok  ---
Thank You.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685022] Review Request: HepMC3 - C++ Event Record for Monte Carlo Generators

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685022

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #5 from Robert-André Mauchin  ---
All good, package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1684612] Review Request: f30-backgrounds - Fedora 30 default desktop background

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684612

Adam Williamson  changed:

   What|Removed |Added

 Status|NEW |ON_QA
 CC||awill...@redhat.com



--- Comment #11 from Adam Williamson  ---
Seems that package just beat the freeze, so I will mark this as ON_QA: when we
finally get another successful compose, it should be in it, and we can verify
that the backgrounds are used in all blocking media (Workstation, KDE, XFCE).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1670441] Review Request: setconf - Tool for changing values of parameters in text files

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1670441

Jan Macku  changed:

   What|Removed |Added

  Flags|needinfo?(jama...@redhat.co |
   |m)  |



--- Comment #29 from Jan Macku  ---
My Fedora username is same as in Bugzilla. (jamacku)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1649583] Review Request: golang-github-tv42-httpunix - Go library to talk HTTP over Unix domain sockets

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1649583

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #4 from Fedora Update System  ---
golang-github-tv42-httpunix-0-0.1.20190305gitb75d861.fc30 has been submitted as
an update to Fedora 30.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-224a36b621

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685022] Review Request: HepMC3 - C++ Event Record for Monte Carlo Generators

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685022



--- Comment #6 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/HepMC3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1649583] Review Request: golang-github-tv42-httpunix - Go library to talk HTTP over Unix domain sockets

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1649583



--- Comment #5 from Fedora Update System  ---
golang-github-tv42-httpunix-0-0.1.20190305gitb75d861.fc29 has been submitted as
an update to Fedora 29.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-bb7c7f0a7a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1648595] Review Request: golang-github-pkg-term - Manages POSIX terminals

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1648595

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #7 from Fedora Update System  ---
golang-github-pkg-term-0-0.1.20190305gitaa71e9d.fc30 has been submitted as an
update to Fedora 30.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-62f67043ba

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1643906] Review Request: golang-github-rican7-retry - A simple, stateless, functional mechanism to perform actions repetitively

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1643906



--- Comment #3 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-rican7-retry

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1648584] Review Request: golang-github-dgryski-bitstream - Read and write bits from io.Reader and io.Writer streams

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1648584



--- Comment #5 from Robert-André Mauchin  ---
I updated the SRPM with the correct file, please review it?
Thanks for your time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1684919] Review Request: golang-github-tinylib-msgp - A Go code generator for MessagePack

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684919



--- Comment #3 from Robert-André Mauchin  ---
Thank you!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1648595] Review Request: golang-github-pkg-term - Manages POSIX terminals

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1648595



--- Comment #8 from Fedora Update System  ---
golang-github-pkg-term-0-0.1.20190305gitaa71e9d.fc29 has been submitted as an
update to Fedora 29.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-f180e45e27

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1684909] Review Request: golang-github-ttacon-chalk - Intuitive package for prettifying terminal/console output

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684909



--- Comment #2 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-ttacon-chalk

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1684924] Review Request: golang-github-mschoch-smat - State Machine Assisted Testing

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684924



--- Comment #2 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-mschoch-smat

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1684908] Review Request: golang-github-philhofer-fwd - Buffered Reader/Writer

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684908



--- Comment #5 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-philhofer-fwd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1684919] Review Request: golang-github-tinylib-msgp - A Go code generator for MessagePack

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684919



--- Comment #4 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-tinylib-msgp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1684927] Review Request: golang-github-ryszard-goskiplist - A skip list implementation in Go

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684927



--- Comment #2 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-ryszard-goskiplist

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1684936] Review Request: golang-github-anacrolix-envpprof - Allows run time configuration of Go's pprof features and default HTTP mux

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684936



--- Comment #4 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-anacrolix-envpprof

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1670441] Review Request: setconf - Tool for changing values of parameters in text files

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1670441



--- Comment #30 from Miro Hrončok  ---
In order to get into packagers groups, you need to sign the contributor
agreement.
https://fedoraproject.org/wiki/Legal:Fedora_Project_Contributor_Agreement

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1648593] Review Request: golang-github-mattn-tty - Simple tty utility

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1648593



--- Comment #2 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-mattn-tty

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1684933] Review Request: golang-github-bradfitz-iter - Range over integers [0,n).

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684933

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Elliott Sales de Andrade  ---
OK, looks good.

ANdré -> André in the changelog, though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1684929] Review Request: golang-github-huandu-xstrings - A collection of useful string functions in Go

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684929



--- Comment #3 from Elliott Sales de Andrade  ---
Already approved, but fix the 1.o2.0-1 -> 1.2.0-1 in the changelog.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1644010] Review Request: golang-github-pierrec-lz4 - LZ4 compression and decompression in pure Go

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1644010



--- Comment #7 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-pierrec-lz4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1684933] Review Request: golang-github-bradfitz-iter - Range over integers [0,n).

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684933



--- Comment #4 from Robert-André Mauchin  ---
Fixed locally. Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1684933] Review Request: golang-github-bradfitz-iter - Range over integers [0,n).

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684933



--- Comment #5 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-bradfitz-iter

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1684929] Review Request: golang-github-huandu-xstrings - A collection of useful string functions in Go

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684929



--- Comment #4 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-huandu-xstrings

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1684938] Review Request: golang-github-docopt - A command-line arguments parser

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684938

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Elliott Sales de Andrade  ---
OK, approved.

Please add a comment about the versioning then. Also, you can add a comment
reminder about dropping the Obsoletes/Provides (in +2 releases or so).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685730] New: Review Request: golang-github-nrdcg-auroradns - Aurora DNS API client written in Go

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685730

Bug ID: 1685730
   Summary: Review Request: golang-github-nrdcg-auroradns - Aurora
DNS API client written in Go
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: carl@george.computer
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/00864921-golang-github-nrdcg-auroradns/golang-github-nrdcg-auroradns.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/00864921-golang-github-nrdcg-auroradns/golang-github-nrdcg-auroradns-1.0.0-1.fc30.src.rpm
Description: Aurora DNS API client written in Go.
Fedora Account System Username: carlwgeorge

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1648584] Review Request: golang-github-dgryski-bitstream - Read and write bits from io.Reader and io.Writer streams

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1648584

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Elliott Sales de Andrade  ---
OK, approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685226] Review Request: gnatcoll-core - The GNAT Components Collection – core packages

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685226



--- Comment #3 from Björn Persson  ---
(In reply to Pavel Zhukov from comment #2)
> Gnatcoll 2018 is gnatcoll-core-2018. I'd prefer to add Provides:
> gnatcoll-core tag and package another libraries.

That can also be made to work with some extra trouble. The package named
gnatcoll will need to pull in gnatcoll-bindings and gnatcoll-db, and
gnatcoll-devel will need to pull in gnatcoll-bindings-devel and
gnatcoll-db-devel. Otherwise functionality will mysteriously disappear when
users upgrade. But that creates cyclical build-time dependencies because
building gnatcoll-bindings and gnatcoll-db requires gnatcoll-core. The
dependencies that are needed for upgrades will have to be temporarily removed
for mass rebuilds. Adding gnatcoll-core as a new package avoids the cyclical
dependencies. gnatcoll and gnatcoll-devel will then be empty packages that
exist only to pull in gnatcoll-bindings and gnatcoll-db during upgrades.

I also think it will be less confusing to users, as the name gnatcoll-core
communicates clearly that it's not all of Gnatcoll but only the core.


(In reply to Robert-André Mauchin from comment #1)
>  - Split the doc into its own noarch subpackage

That's a good idea. Thanks.

>  - Please include all licenses you package, and add a comment explaining the
> license breakdown:

I'm afraid I forgot to check the licenses of the files from Sphinx. I'll make
sure to fix that.

> Add %{?_smp_mflags} to make? If it supports it.

Parallel building is done by GPRbuild. The makefile just composes parameters to
GPRbuild and GPRinstall.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1643742] Review Request: golang-etcd-bbolt - An embedded key/value database for Go

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1643742

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||quantum.anal...@gmail.com
   Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Elliott Sales de Andrade  ---
Update to 1.3.2 and you can drop the commit hash and 0 release.

How much memory does %gochecks use? Maybe that can be reported upstream, or
maybe it's fixed already. Also, I think builders have a ridiculous amount of
RAM... I tried uncommenting it and it uses max ~2.6 G; this should be fine,
except maybe 32-bit. Might want to try a scratch build to be sure.

Can remove the %license tag re-definition.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Expat License", "Unknown or generated". 43 files have unknown
 license. Detailed output of licensecheck in
 1643742-golang-etcd-bbolt/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gocode/src,
 /usr/share/gocode, /usr/share/gocode/src/github.com
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 N

[Bug 1684906] Review Request: golang-github-glycerine-go-unsnap-stream - Small golang library for decoding the snappy streaming format

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684906

Jerry James  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||loganje...@gmail.com
 QA Contact|extras...@fedoraproject.org |loganje...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Jerry James  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Spec file name must match the spec package %{name}, in the format
  %{name}.spec.
  Note: golang-github-glycerine-go-unsnap-stream.spec should be golang-
  github-glycerine-unsnap-stream.spec
  See:
  http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name

- Changelog reports the username as root, with no email


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: There is no build directory. Running licensecheck on vanilla
 upstream sources. Licenses found: "Unknown or generated", "Expat
 License". 17 files have unknown license. Detailed output of
 licensecheck in /home/jamesjer/1684906-golang-github-glycerine-go-
 unsnap-stream/licensecheck.txt
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gocode/src,
 /usr/share/gocode
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[!]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages sho

[Bug 1670656] Review Request: grafana - an open source, feature rich metrics dashboard and graph editor

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1670656



--- Comment #26 from Elliott Sales de Andrade  ---
make_webpack.sh can be a simplified a little bit as you don't really need to
use go to build it: https://qulogic.fedorapeople.org/make_webpack.sh

Also, are you interested in maintaining golang-github-go-stack-stack (bug
1377227) and golang-github-Unknwon-com (bug 1376387), since you need them for
grafana?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685022] Review Request: HepMC3 - C++ Event Record for Monte Carlo Generators

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685022



--- Comment #8 from Fedora Update System  ---
HepMC3-3.1.0-3.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-0bc7b26f0f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685022] Review Request: HepMC3 - C++ Event Record for Monte Carlo Generators

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685022



--- Comment #10 from Fedora Update System  ---
HepMC3-3.1.0-3.fc29 has been submitted as an update to Fedora 29.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-99c85070a4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685022] Review Request: HepMC3 - C++ Event Record for Monte Carlo Generators

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685022

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #7 from Fedora Update System  ---
HepMC3-3.1.0-3.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-2432033d99

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685022] Review Request: HepMC3 - C++ Event Record for Monte Carlo Generators

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685022



--- Comment #9 from Fedora Update System  ---
HepMC3-3.1.0-3.fc30 has been submitted as an update to Fedora 30.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-94e3dca61c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1685022] Review Request: HepMC3 - C++ Event Record for Monte Carlo Generators

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1685022



--- Comment #11 from Mattias Ellert  ---
(In reply to Robert-André Mauchin from comment #5)
> All good, package approved.

Thank you for the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1680397] Review Request: combblas - The Combinatorial BLAS Library

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1680397

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2019-03-06 06:58:05



--- Comment #10 from Fedora Update System  ---
combblas-1.6.2-0.1.beta2.fc29 has been pushed to the Fedora 29 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1680308] Review Request: php-typo3-phar-stream-wrapper - Interceptors for PHP's native phar:// stream handling

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1680308

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2019-03-06 06:58:09



--- Comment #8 from Fedora Update System  ---
php-typo3-phar-stream-wrapper-3.0.1-1.fc29 has been pushed to the Fedora 29
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1483262] Review Request: phpdoc - Documentation generator for PHP

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1483262

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2019-03-06 06:58:10



--- Comment #21 from Fedora Update System  ---
phpdoc-2.9.0-7.fc29 has been pushed to the Fedora 29 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1670656] Review Request: grafana - an open source, feature rich metrics dashboard and graph editor

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1670656



--- Comment #27 from Mark Goodwin  ---
(In reply to Elliott Sales de Andrade from comment #25)
> (In reply to Mark Goodwin from comment #24)
> > In addition to Xavier's notes and questions in Comment #23, rpmlint issues
> > warnings that Provides: bundled(foo) should be versioned.
> > 
> > # rpmlint RPMS/x86_64/grafana-5.4.3-10.fc28.x86_64.rpm
> > grafana.x86_64: W: unstripped-binary-or-object /usr/sbin/grafana-cli
> > grafana.x86_64: W: unstripped-binary-or-object /usr/sbin/grafana-server
> 
> This should be done somehow (automatically, I'd have thought), since debug
> information is in the -debuginfo subpackage. It seems like it might be
> because you've disabled debug packages; why is that?

The build failed as follows :

Empty %files file
/home/mgoodwin/rpmbuild/BUILD/grafana-5.4.3/debugsourcefiles.list

I've investigated some more and managed to get the debuginfo package building
again (but omitting the debugsource package since it's empty) - it seems there
are some issues with debuginfo for golang binaries. WHat I have now allows gdb
backtraces, which is better than we had before. And the
unstripped-binary-or-object complaints have gone away now (since we now have
the *.debug versions too)

> > grafana.x86_64: W: non-standard-gid /etc/grafana/grafana.ini grafana
> > grafana.x86_64: E: non-readable /etc/grafana/grafana.ini 640
> > grafana.x86_64: W: non-standard-gid /etc/grafana/ldap.toml grafana
> > grafana.x86_64: E: non-readable /etc/grafana/ldap.toml 640
> > grafana.x86_64: E: non-readable /etc/sysconfig/grafana-server 640
> > grafana.x86_64: W: non-standard-gid /usr/share/grafana/conf/defaults.ini 
> > grafana
> > grafana.x86_64: E: non-readable /usr/share/grafana/conf/defaults.ini 640
> > grafana.x86_64: W: non-standard-gid 
> > /usr/share/grafana/conf/distro-defaults.ini grafana
> > grafana.x86_64: W: non-standard-gid /usr/share/grafana/conf/ldap.toml 
> > grafana
> > grafana.x86_64: W: non-standard-gid /usr/share/grafana/conf/provisioning 
> > grafana
> > grafana.x86_64: W: non-standard-gid 
> > /usr/share/grafana/conf/provisioning/dashboards grafana
> > grafana.x86_64: W: non-standard-gid 
> > /usr/share/grafana/conf/provisioning/dashboards/sample.yaml grafana
> > grafana.x86_64: W: non-standard-gid 
> > /usr/share/grafana/conf/provisioning/datasources grafana
> > grafana.x86_64: W: non-standard-gid 
> > /usr/share/grafana/conf/provisioning/datasources/sample.yaml grafana
> > grafana.x86_64: W: non-standard-gid /usr/share/grafana/conf/sample.ini 
> > grafana
> > grafana.x86_64: W: non-standard-uid /var/lib/grafana/data grafana
> > grafana.x86_64: W: non-standard-gid /var/lib/grafana/data grafana
> > grafana.x86_64: E: non-standard-dir-perm /var/lib/grafana/data 750
> > grafana.x86_64: W: non-standard-uid /var/lib/grafana/data/plugins grafana
> > grafana.x86_64: W: non-standard-gid /var/lib/grafana/data/plugins grafana
> > grafana.x86_64: E: non-standard-dir-perm /var/lib/grafana/data/plugins 750
> > grafana.x86_64: W: non-standard-uid /var/log/grafana grafana
> > grafana.x86_64: W: non-standard-gid /var/log/grafana grafana
> 
> I assume you've followed the instructions on
> https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/ ?

yes I have followed that doc - using the 'dynamic allocation' method, as
described in that document.
It would seem rpmlint is complaining when it shouldn't. To resolve that, I
would have to manually chmod/chgrp in the %post scriptlets. Install/testing the
%pre stuff that's there now in the spec on systems with/without grafana
user/group all seems to work correctly.

> > grafana.x86_64: E: script-without-shebang 
> > /usr/share/grafana/public/app/plugins/datasource/elasticsearch/img/elasticsearch.svg
> > grafana.x86_64: E: script-without-shebang 
> > /usr/share/grafana/public/fonts/grafana-icons.svg
> 
> These should not be executable.

Will add to Patch0 (000-grafana-fedora.patch). This is broken upstream but no
big deal, svg files are not even scripts obviously.

> > grafana.x86_64: W: hidden-file-or-dir 
> > /usr/share/grafana/public/sass/.sass-lint.yml
> > grafana.x86_64: W: hidden-file-or-dir 
> > /usr/share/grafana/public/test/.jshintrc
> 
> Delete these development files.

now deleted via spec %build but might put that in the patch too since it's
broken upstream.

> > grafana.x86_64: W: log-files-without-logrotate ['/var/log/grafana']
> 
> See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_log_files

Grafana has it's own log rotation and management, so we do not ship or
rely on the logrotate config mechanism documented in the guidelines.

> > # rpmlint SRPMS/grafana-5.4.3-10.fc28.src.rpm 
> > grafana.src:98: W: unversioned-explicit-provides ...
> 
> It seems like you have bundled provides for things you've removed from the
> source. You don't need to add those (though yes, technically, it's
> statically bundled, the macros should do that sort of thing for you.)

I need to au

[Bug 1684346] Review Request: ocaml-dune - A composable build system for OCaml

2019-03-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1684346

Andy Li  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2019-03-06 07:56:32



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


  1   2   >