[Bug 1694553] Review Request: oidn - Library of denoising filters for images rendered with ray tracing
https://bugzilla.redhat.com/show_bug.cgi?id=1694553 --- Comment #2 from Vasiliy Glazov --- 6. Change %cmake to %cmake . (With path to curent directory - dot) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694553] Review Request: oidn - Library of denoising filters for images rendered with ray tracing
https://bugzilla.redhat.com/show_bug.cgi?id=1694553
--- Comment #1 from Vasiliy Glazov ---
1. You must move /usr/lib64/libOpenImageDenoise.so to devel subpackage.
2. shared-lib-calls-exit /usr/lib64/libOpenImageDenoise.so.0.8.2
exit@GLIBC_2.2.5
So you should bugreport about this issue to upstream.
3. Large documentation must go in a -doc subpackage. Large could be size(~1MB)
or number of files.
Note: Documentation size is 3420160 bytes in 3 files.
See:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation
4. Change %{_libdir}/cmake to %{_libdir}/cmake/OpenImageDenoise
5. You should remove rm -rf %{buildroot}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694553] Review Request: oidn - Library of denoising filters for images rendered with ray tracing
https://bugzilla.redhat.com/show_bug.cgi?id=1694553 Vasiliy Glazov changed: What|Removed |Added Status|NEW |ASSIGNED CC||vasc...@gmail.com Assignee|nob...@fedoraproject.org|vasc...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694553] Review Request: oidn - Library of denoising filters for images rendered with ray tracing
https://bugzilla.redhat.com/show_bug.cgi?id=1694553 Luya Tshimbalanga changed: What|Removed |Added Alias||oidn -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694553] New: Review Request: oidn - Library of denoising filters for images rendered with ray tracing
https://bugzilla.redhat.com/show_bug.cgi?id=1694553 Bug ID: 1694553 Summary: Review Request: oidn - Library of denoising filters for images rendered with ray tracing Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: luya_...@thefinalzone.net QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://copr-be.cloud.fedoraproject.org/results/luya/LuxCoreRender/fedora-rawhide-x86_64/00876117-oidn/oidn.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/luya/LuxCoreRender/fedora-rawhide-x86_64/00876117-oidn/oidn-0.8.2-1.fc31.src.rpm Description: An open source library of high-performance, high-quality denoising filters for images rendered with ray tracing. Fedora Account System Username: luya -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1684401] Review Request: ocaml-merlin - Context sensitive completion for OCaml in Vim and Emacs
https://bugzilla.redhat.com/show_bug.cgi?id=1684401 --- Comment #8 from Fedora Update System --- ocaml-merlin-3.2.2-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7eae8acee1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1684401] Review Request: ocaml-merlin - Context sensitive completion for OCaml in Vim and Emacs
https://bugzilla.redhat.com/show_bug.cgi?id=1684401 --- Comment #7 from Fedora Update System --- ocaml-merlin-3.2.2-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-1a7efb679c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1693030] Review Request: python-hdmf - The Hierarchical Data Modeling Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1693030 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-04-01 00:01:15 --- Comment #8 from Fedora Update System --- python-hdmf-1.0.1-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1691542] Review Request: python-coloredlogs - Colored terminal output for Python's logging module
https://bugzilla.redhat.com/show_bug.cgi?id=1691542 Bug 1691542 depends on bug 1687962, which changed state. Bug 1687962 Summary: Review Request: python-humanfriendly - Human friendly output for text interfaces using Python https://bugzilla.redhat.com/show_bug.cgi?id=1687962 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1687962] Review Request: python-humanfriendly - Human friendly output for text interfaces using Python
https://bugzilla.redhat.com/show_bug.cgi?id=1687962 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-04-01 00:01:07 --- Comment #9 from Fedora Update System --- python-capturer-2.4-5.fc30, python-coloredlogs-10.0-7.fc30, python-humanfriendly-4.18-1.fc30, python-verboselogs-1.7-4.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1688555] Review Request: python-capturer - Easily capture stdout/stderr of the current process and subprocesses
https://bugzilla.redhat.com/show_bug.cgi?id=1688555 Bug 1688555 depends on bug 1687962, which changed state. Bug 1687962 Summary: Review Request: python-humanfriendly - Human friendly output for text interfaces using Python https://bugzilla.redhat.com/show_bug.cgi?id=1687962 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1691542] Review Request: python-coloredlogs - Colored terminal output for Python's logging module
https://bugzilla.redhat.com/show_bug.cgi?id=1691542 Bug 1691542 depends on bug 1688555, which changed state. Bug 1688555 Summary: Review Request: python-capturer - Easily capture stdout/stderr of the current process and subprocesses https://bugzilla.redhat.com/show_bug.cgi?id=1688555 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1692303] Review Request: paperwork - Using scanner and OCR to grep dead trees the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1692303 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-04-01 00:01:11 --- Comment #10 from Fedora Update System --- paperwork-1.2.4-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1691542] Review Request: python-coloredlogs - Colored terminal output for Python's logging module
https://bugzilla.redhat.com/show_bug.cgi?id=1691542 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-04-01 00:01:09 --- Comment #9 from Fedora Update System --- python-capturer-2.4-5.fc30, python-coloredlogs-10.0-7.fc30, python-humanfriendly-4.18-1.fc30, python-verboselogs-1.7-4.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1688555] Review Request: python-capturer - Easily capture stdout/stderr of the current process and subprocesses
https://bugzilla.redhat.com/show_bug.cgi?id=1688555 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-04-01 00:01:06 --- Comment #10 from Fedora Update System --- python-capturer-2.4-5.fc30, python-coloredlogs-10.0-7.fc30, python-humanfriendly-4.18-1.fc30, python-verboselogs-1.7-4.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1691542] Review Request: python-coloredlogs - Colored terminal output for Python's logging module
https://bugzilla.redhat.com/show_bug.cgi?id=1691542 Bug 1691542 depends on bug 1688563, which changed state. Bug 1688563 Summary: Review Request: python-verboselogs - Verbose logging level for Python's logging module https://bugzilla.redhat.com/show_bug.cgi?id=1688563 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1692303] Review Request: paperwork - Using scanner and OCR to grep dead trees the easy way
https://bugzilla.redhat.com/show_bug.cgi?id=1692303 Bug 1692303 depends on bug 1692218, which changed state. Bug 1692218 Summary: Review Request: python-paperwork-backend - Paperwork's backend https://bugzilla.redhat.com/show_bug.cgi?id=1692218 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1692218] Review Request: python-paperwork-backend - Paperwork's backend
https://bugzilla.redhat.com/show_bug.cgi?id=1692218 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-04-01 00:01:03 --- Comment #8 from Fedora Update System --- python-paperwork-backend-1.2.4-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1688563] Review Request: python-verboselogs - Verbose logging level for Python's logging module
https://bugzilla.redhat.com/show_bug.cgi?id=1688563 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-04-01 00:01:04 --- Comment #9 from Fedora Update System --- python-capturer-2.4-5.fc30, python-coloredlogs-10.0-7.fc30, python-humanfriendly-4.18-1.fc30, python-verboselogs-1.7-4.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1692191] Review Request: R-tidyr - Easily Tidy Data with 'spread()' and 'gather()' Functions
https://bugzilla.redhat.com/show_bug.cgi?id=1692191 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-04-01 00:01:02 --- Comment #5 from Fedora Update System --- R-tidyr-0.8.3-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1693514] Review Request: coin-or-Data-Netlib - COIN-OR Netlib models
https://bugzilla.redhat.com/show_bug.cgi?id=1693514 --- Comment #2 from Jerry James --- The coin-or project is pretty good about including license files in their code projects, but they don't seem to feel the need to do so for their data libraries. If you look in configure.ac, you'll see this on lines 17 to 21: AC_COPYRIGHT([ Copyright 2006 International Business Machines and others. All Rights Reserved. This file is part of the open source package Coin which is distributed under the Eclipse Public License.]) This doesn't specify the version of the Eclipse Public License, but if you look into the coin-or-* projects we already have in Fedora, they all include the version 1.0 license text. (I am in the process of updating those existing packages, and this package is a new dependency. Their License fields will soon be corrected from "EPL" to "EPL-1.0".) On the other hand, the coin-or-Sample package was added to Fedora under a "Public Domain" license; see bug 894610. Maybe that is what should be done here, too. I am uncertain about this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694498] Review Request: python-typing-extensions - Python Typing Extensions
https://bugzilla.redhat.com/show_bug.cgi?id=1694498 Jonny Heggheim changed: What|Removed |Added Blocks||1683665 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1683665 [Bug 1683665] python-trezor-0.11.2 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694498] Review Request: python-typing-extensions - Python Typing Extensions
https://bugzilla.redhat.com/show_bug.cgi?id=1694498 Jonny Heggheim changed: What|Removed |Added Blocks||1688695 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1688695 [Bug 1688695] Unable to update Electron-Cash due to dependency -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694498] New: Review Request: python-typing-extensions - Python Typing Extensions
https://bugzilla.redhat.com/show_bug.cgi?id=1694498 Bug ID: 1694498 Summary: Review Request: python-typing-extensions - Python Typing Extensions Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: heg...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: http://jonny.fedorapeople.org//python-typing-extensions.spec SRPM URL: http://jonny.fedorapeople.org//python-typing-extensions-3.7.2-1.fc29.src.rpm Description: Typing Extensions - Backported and Experimental Type Hints for Python The typing module was added to the standard library in Python 3.5 on a provisional basis and will no longer be provisional in Python 3.7. However, this means users of Python 3.5 - 3.6 who are unable to upgrade will not be able to take advantage of new types added to the typing module, such as typing.Text or typing.Coroutine. The typing_extensions module contains both backports of these changes as well as experimental types that will eventually be added to the typing module, such as Protocol. Users of other Python versions should continue to install and use the typing module from PyPi instead of using this one unless specifically writing code that must be compatible with multiple Python versions or requires experimental types. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694498] Review Request: python-typing-extensions - Python Typing Extensions
https://bugzilla.redhat.com/show_bug.cgi?id=1694498 --- Comment #1 from Jonny Heggheim --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=33857636 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1688881] Review Request: golang-github-armon-consul-api - Golang API client for Consul
https://bugzilla.redhat.com/show_bug.cgi?id=161 --- Comment #8 from Robert-André Mauchin --- Thank you so much. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1688881] Review Request: golang-github-armon-consul-api - Golang API client for Consul
https://bugzilla.redhat.com/show_bug.cgi?id=161 Jerry James changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Jerry James --- This package is APPROVED. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Mozilla Public License (v2.0)", "Unknown or generated". 19 files have unknown license. Detailed output of licensecheck in /home/jamesjer/161-golang-github-armon-consul- api/licensecheck.txt [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gocode/src, /usr/share/gocode [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gocode/src/github.com/armon(golang-github-armon-gomdb- devel, golang-github-armon-go-proxyproto-devel, golang-github-armon- go-radix-devel, golang-github-armon-go-metrics-devel, golang-github- armon-circbuf-devel), /usr/share/gocode/src/github.com(golang- googlecode-gogoprotobuf-devel, golang-github-peterbourgon-diskv-devel, golang-github-aead-chacha20-devel, golang-github-dustin-go-humanize- devel, golang-github-pkg-term-devel, golang-github-ryszard-goskiplist- devel, golang-github-git-lfs-netrc-devel, golang-github-rainycape- memcache-devel, golang-github-shurcool-httpfs-devel, golang-github- ncw-swift-devel, golang-github-karlseguin-expect-devel, golang-github- coreos-pkg-devel, golang-github-nwaples-rardecode-devel, golang- github-akrennmair-gopcap-devel, golang-github-delve-devel, golang- github-dvsekhvalnov-jose2go-devel, golang-github-coreos-go-oidc-devel, golang-github-prometheus-procfs-devel, golang-github-DataDog-datadog- go-devel, golang-github-pelletier-go-buffruneio-devel, golang-github- thejerf-suture-devel, golang-github-gdamore-encoding-devel, golang- github-zyedidia-pty-devel, golang-github-freetype-devel, golang- github-gregjones-httpcache-devel, golang-github-SAP-go-hdb-devel, golang-github-chzyer-logex-devel, golang-github-bmizerany-perks-devel, golang-github-aws-aws-sdk-go-devel, golang-github-gorilla-websocket- devel, golang-github-yuin-gopher-lua-devel, golang-github-google- martian-devel, golang-github-garyburd-redigo-devel, golang-github-pkg- xattr-devel, golang-github-gliderlabs-ssh-devel, glide-devel, golang- github-pengsrc-shared-devel, golang-github-petar-GoLLRB-devel, golang- github-lucasb-eyer-colorful-devel, golang-github-vividcortex-ewma- devel, golang-github-census-instrumentation-opencensus-proto-devel, golang-github-smartystreets-goconvey-devel, golang-github-hashicorp- memberlist-devel, golang-github-mattn-go-runewidth-devel, golang- github-docker-go-devel, golang-github-miekg-pkcs11-devel, golang- github-fatih-color-devel, golang-github-mitchellh-reflectwalk-devel, golang-github-go-ldap-ldap-devel, golang-github-zyedidia-poller-devel, golang-github-bradfitz-gomemcache-devel, golang-github-shurcool- issues-devel, golang-github-wellington-libsass-devel, golang-github- cheggaaa-pb-devel, golang-github-mdlayher-wifi-devel, golang-github- nwidger-jsoncolor-devel, golang-github-shopspring-decimal-devel, golang-github-circonus-labs-circonusllhist-devel, golang-github-calmh- du-devel, golang-github-ncw-dropbox-sdk-unofficial-devel, golang- github-coreos-go-iptables-devel, golang-github-shurcool-reactions- devel, golang-github-cloudflare-devel, golang-github-facebookgo- atomicfile-devel, golang-github-gorilla-context-devel, golang-github- data-dog-txdb-devel, golang-github-chmduquesne-rollinghash-devel, golang-github-git-lfs-devel, golang-github-coreos-go-log-devel, golang-github-google-cmp-devel, golang-github-pquerna-cachecontrol- devel, golang-github-nicksnyder-i18n-devel, golang-github-azure- autorest-devel, golang-github-xlab-handysort-devel, golang-github- kylelemons-godebug-devel, golang-github-emicklei-go-restful-devel, golang-github-xanzy-ssh-agent-devel, golang-github-mreiferson-go- httpclient-devel, golang-github-shurcool-highlight-devel, golang- github-russross-blackfriday-devel, golang-github-jedisct1-dnsstamps- devel, golang-github-shirou-gopsutil-devel, golang-github-hashicorp- go-immutable-radix-devel, golang-github-sevlyar-daemon-devel,
[Bug 1688881] Review Request: golang-github-armon-consul-api - Golang API client for Consul
https://bugzilla.redhat.com/show_bug.cgi?id=161 --- Comment #6 from Robert-André Mauchin --- xordataexchange is abandonned as well, see https://github.com/xordataexchange/crypt/pull/20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1688881] Review Request: golang-github-armon-consul-api - Golang API client for Consul
https://bugzilla.redhat.com/show_bug.cgi?id=161 Jerry James changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|loganje...@gmail.com Flags||fedora-review? --- Comment #5 from Jerry James --- Okay, I figured it was probably something like that. I'll review it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1643996] Review Request: golang-github-eapache-xerial-snappy - Xerial-compatible Snappy framing support for golang
https://bugzilla.redhat.com/show_bug.cgi?id=1643996 Jerry James changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Jerry James --- This package is APPROVED. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Expat License", "Unknown or generated". 37 files have unknown license. Detailed output of licensecheck in /home/jamesjer/1643996 -golang-github-eapache-xerial-snappy/licensecheck.txt [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gocode/src, /usr/share/gocode [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gocode/src/github.com/eapache(golang-github-eapache-go- resiliency-devel, golang-github-eapache-queue-devel), /usr/share/gocode/src/github.com(golang-googlecode-gogoprotobuf-devel, golang-github-peterbourgon-diskv-devel, golang-github-aead- chacha20-devel, golang-github-dustin-go-humanize-devel, golang-github- pkg-term-devel, golang-github-ryszard-goskiplist-devel, golang-github- git-lfs-netrc-devel, golang-github-rainycape-memcache-devel, golang- github-shurcool-httpfs-devel, golang-github-ncw-swift-devel, golang- github-karlseguin-expect-devel, golang-github-coreos-pkg-devel, golang-github-nwaples-rardecode-devel, golang-github-akrennmair- gopcap-devel, golang-github-delve-devel, golang-github-dvsekhvalnov- jose2go-devel, golang-github-coreos-go-oidc-devel, golang-github- prometheus-procfs-devel, golang-github-DataDog-datadog-go-devel, golang-github-pelletier-go-buffruneio-devel, golang-github-thejerf- suture-devel, golang-github-gdamore-encoding-devel, golang-github- zyedidia-pty-devel, golang-github-freetype-devel, golang-github- gregjones-httpcache-devel, golang-github-SAP-go-hdb-devel, golang- github-chzyer-logex-devel, golang-github-bmizerany-perks-devel, golang-github-aws-aws-sdk-go-devel, golang-github-gorilla-websocket- devel, golang-github-yuin-gopher-lua-devel, golang-github-google- martian-devel, golang-github-garyburd-redigo-devel, golang-github-pkg- xattr-devel, golang-github-gliderlabs-ssh-devel, glide-devel, golang- github-pengsrc-shared-devel, golang-github-petar-GoLLRB-devel, golang- github-lucasb-eyer-colorful-devel, golang-github-vividcortex-ewma- devel, golang-github-census-instrumentation-opencensus-proto-devel, golang-github-smartystreets-goconvey-devel, golang-github-hashicorp- memberlist-devel, golang-github-mattn-go-runewidth-devel, golang- github-docker-go-devel, golang-github-miekg-pkcs11-devel, golang- github-fatih-color-devel, golang-github-mitchellh-reflectwalk-devel, golang-github-go-ldap-ldap-devel, golang-github-zyedidia-poller-devel, golang-github-bradfitz-gomemcache-devel, golang-github-shurcool- issues-devel, golang-github-wellington-libsass-devel, golang-github- cheggaaa-pb-devel, golang-github-mdlayher-wifi-devel, golang-github- nwidger-jsoncolor-devel, golang-github-shopspring-decimal-devel, golang-github-circonus-labs-circonusllhist-devel, golang-github-calmh- du-devel, golang-github-ncw-dropbox-sdk-unofficial-devel, golang- github-coreos-go-iptables-devel, golang-github-shurcool-reactions- devel, golang-github-cloudflare-devel, golang-github-facebookgo- atomicfile-devel, golang-github-gorilla-context-devel, golang-github- data-dog-txdb-devel, golang-github-chmduquesne-rollinghash-devel, golang-github-git-lfs-devel, golang-github-coreos-go-log-devel, golang-github-google-cmp-devel, golang-github-pquerna-cachecontrol- devel, golang-github-nicksnyder-i18n-devel, golang-github-azure- autorest-devel, golang-github-xlab-handysort-devel, golang-github- kylelemons-godebug-devel, golang-github-emicklei-go-restful-devel, golang-github-xanzy-ssh-agent-devel, golang-github-mreiferson-go- httpclient-devel, golang-github-shurcool-highlight-devel, golang- github-russross-blackfriday-devel, golang-github-jedisct1-dnsstamps- devel, golang-github-shirou-gopsutil-devel, golang-github-hashicorp- go-immutable-radix-devel, golang-github-sevlyar-daemon-devel, golang- github-AdRoll-goamz-devel, golang-github-docker-libtrust-devel, golang-github-jessevdk-go-flags-devel, golang-github-tarm-
[Bug 1643996] Review Request: golang-github-eapache-xerial-snappy - Xerial-compatible Snappy framing support for golang
https://bugzilla.redhat.com/show_bug.cgi?id=1643996 Jerry James changed: What|Removed |Added Status|NEW |ASSIGNED CC||loganje...@gmail.com Assignee|nob...@fedoraproject.org|loganje...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1688881] Review Request: golang-github-armon-consul-api - Golang API client for Consul
https://bugzilla.redhat.com/show_bug.cgi?id=161 --- Comment #4 from Robert-André Mauchin --- Sadly this is needed by github.com/xordataexchange/crypt/ which itself is needed to update golang-github-spf13-viper. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1684401] Review Request: ocaml-merlin - Context sensitive completion for OCaml in Vim and Emacs
https://bugzilla.redhat.com/show_bug.cgi?id=1684401 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- ocaml-merlin-3.2.2-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-4a34940a18 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1688881] Review Request: golang-github-armon-consul-api - Golang API client for Consul
https://bugzilla.redhat.com/show_bug.cgi?id=161 Jerry James changed: What|Removed |Added CC||loganje...@gmail.com --- Comment #3 from Jerry James --- Are you aware that this package has been deprecated in favor of the contents of the api directory in https://github.com/hashicorp/consul ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1677989] Review Request: vcglib Visualization and Computer Graphics Library
https://bugzilla.redhat.com/show_bug.cgi?id=1677989
--- Comment #25 from Petr Menšík ---
Please remove %{build}%{_includedir} and %{build}%{_datarootdir} from both
build and install sections.
rpm -E '%{build}' is not defined and expands just to the same text. That is
wrong.
Use just pkgconfig/vcglib.pc. And use %{buildroot} in %install, where that
variable is already defined. %build is not defined in any section.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1467716] Review Request: reactfx - Reactive event streams for JavaFX
https://bugzilla.redhat.com/show_bug.cgi?id=1467716
Raphael Groner changed:
What|Removed |Added
Flags|needinfo?(projects.rg@smart |
|.ms)|
--- Comment #17 from Raphael Groner ---
It seems I overlooked something here:
> ExclusiveArch: %{ix86} x86_64 noarch
> BuildArch: noarch
Sorry for the delay. There was some misunderstanding and I'm fine with the
approval.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1684401] Review Request: ocaml-merlin - Context sensitive completion for OCaml in Vim and Emacs
https://bugzilla.redhat.com/show_bug.cgi?id=1684401 --- Comment #4 from Fedora Update System --- ocaml-merlin-3.2.2-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-1a7efb679c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1684401] Review Request: ocaml-merlin - Context sensitive completion for OCaml in Vim and Emacs
https://bugzilla.redhat.com/show_bug.cgi?id=1684401 --- Comment #5 from Fedora Update System --- ocaml-merlin-3.2.2-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7eae8acee1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1684401] Review Request: ocaml-merlin - Context sensitive completion for OCaml in Vim and Emacs
https://bugzilla.redhat.com/show_bug.cgi?id=1684401 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #3 from Fedora Update System --- ocaml-merlin-3.2.2-2.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-4a34940a18 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1693987] Review Request: java-latest-openjdk - rolling release for short term support OpenJDK
https://bugzilla.redhat.com/show_bug.cgi?id=1693987 --- Comment #8 from jiri vanek --- One more idea to consult with java sig: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/ Maybe change the suffix to latest or sts? From those two I would vote latest, But only for consistency. From those three, I like rolling the most. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1467716] Review Request: reactfx - Reactive event streams for JavaFX
https://bugzilla.redhat.com/show_bug.cgi?id=1467716 Jonny Heggheim changed: What|Removed |Added CC||projects...@smart.ms Flags||needinfo?(projects.rg@smart ||.ms) --- Comment #16 from Jonny Heggheim --- Can you please reply to comment #15 Raphael Groner? I am waiting to import the package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694438] New: Review Request: ghc-parser-combinators - Lightweight package providing commonly useful parser combinators
https://bugzilla.redhat.com/show_bug.cgi?id=1694438 Bug ID: 1694438 Summary: Review Request: ghc-parser-combinators - Lightweight package providing commonly useful parser combinators Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: peter...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: http://petersen.fedorapeople.org//ghc-parser-combinators.spec SRPM URL: http://petersen.fedorapeople.org//ghc-parser-combinators-1.0.0-3.fc29.src.rpm Description: Lightweight package providing commonly useful parser combinators. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694438] Review Request: ghc-parser-combinators - Lightweight package providing commonly useful parser combinators
https://bugzilla.redhat.com/show_bug.cgi?id=1694438 --- Comment #1 from Jens Petersen --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=33849285 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1693987] Review Request: java-latest-openjdk - rolling release for short term support OpenJDK
https://bugzilla.redhat.com/show_bug.cgi?id=1693987 jiri vanek changed: What|Removed |Added Status|ASSIGNED|POST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1693987] Review Request: java-latest-openjdk - rolling release for short term support OpenJDK
https://bugzilla.redhat.com/show_bug.cgi?id=1693987 jiri vanek changed: What|Removed |Added Flags|fedora_requires_release_not |fedora_requires_release_not |e? fedora-review? |e+ fedora-review+ --- Comment #7 from jiri vanek --- Considering this is rename, and very tricky rename, the package is APPROVED Still there are several areas where java sig should look and possibly fix in PRs. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1693987] Review Request: java-latest-openjdk - rolling release for short term support OpenJDK
https://bugzilla.redhat.com/show_bug.cgi?id=1693987 --- Comment #5 from jiri vanek --- [1] Note: java-latest-openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/build-slowdebug/hotspot /variant-server/gensrc/dtracefiles/hotspot.h java-latest-openjdk- debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/build-slowdebug/hotspot /variant-server/gensrc/dtracefiles/hotspot_jni.h java-latest-openjdk- debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/build-slowdebug/hotspot /variant-server/gensrc/dtracefiles/hs_private.h java-latest-openjdk- debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/build-slowdebug/hotspot /variant-server/gensrc/jvmtifiles/jvmti.h java-latest-openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/build- slowdebug/support/modules_include/java.base/classfile_constants.h java- latest-openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/build- slowdebug/support/modules_include/java.base/jni.h java-latest-openjdk- debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/build- slowdebug/support/modules_include/java.base/jvmti.h java-latest-openjdk- debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/build- slowdebug/support/modules_include/java.base/jvmticmlr.h java-latest- openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/build- slowdebug/support/modules_include/java.base/linux/jni_md.h java-latest- openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/build/hotspot/variant- server/gensrc/dtracefiles/hotspot.h java-latest-openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/build/hotspot/variant- server/gensrc/dtracefiles/hotspot_jni.h java-latest-openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/build/hotspot/variant- server/gensrc/dtracefiles/hs_private.h java-latest-openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/build/hotspot/variant- server/gensrc/jvmtifiles/jvmti.h java-latest-openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/build/support/headers/java.base/java_net_Inet4AddressImpl.h java-latest-openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/build/support/headers/java.base/java_net_InetAddress.h java-latest-openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/build/support/headers/java.base/java_net_NetworkInterface.h java-latest-openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/build/support/modules_include/java.base/classfile_constants.h java-latest-openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/build/support/modules_include/java.base/jni.h java-latest-openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/build/support/modules_include/java.base/jvmti.h java-latest-openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/build/support/modules_include/java.base/jvmticmlr.h java-latest-openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/build/support/modules_include/java.base/linux/jni_md.h java-latest-openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/src/hotspot/cpu/x86/crc32c.h java-latest-openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/src/hotspot/share/include/cds.h java-latest-openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/src/hotspot/share/include/jmm.h java-latest-openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/src/hotspot/share/include/jvm.h java-latest-openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/src/java.base/share/native/launcher/defines.h java-latest-openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/src/java.base/share/native/libfdlibm/fdlibm.h java-latest-openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/src/java.base/share/native/libjava/io_util.h java-latest-openjdk-debugsource : /usr/src/debug/java-latest- openjdk-12.0.0.33-3.rolling.fc29.x86_64/openjdk/src/java.base/share/na
[Bug 1693987] Review Request: java-latest-openjdk - rolling release for short term support OpenJDK
https://bugzilla.redhat.com/show_bug.cgi?id=1693987
--- Comment #6 from jiri vanek ---
lease search *** for all nits
highlights:
- Package does not contain duplicates in %files.
Note: BUILDSTDERR: warning: File listed twice:
/usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/server/classes.jsa
See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
*** Please check that and fix later
- Bundled jar/class files should be removed before build
Note: Jar files in source (see attachment)
See: http://fedoraproject.org/wiki/Packaging:Java#Pre-
built_JAR_files_.2F_Other_bundled_software'
*** Those are IdealGraphVisualizer and tests. Please remove before build.
*** I'm not sure what to do with /usr/share/icons/. Had global settings changed
in since last review?
/usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64{-slowdebug}/lib
should be fixed
*** This is rename of java-openjdk package. Except reanimg, it does nothing
else.
This package can not obsolete java-openjdk, as it would obsolete
java-1.8.0-openjdk via manual provides of java-openjdk it have.
The java-openjdk package should be emptied together with this update, and
should require this new package as its implementation(thoughts?).
Thus this can be handled later out of this review.
*** Suspicious is: java-latest-openjdk-devel!!
[-]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in java-latest-openjdk, java-latest-openjdk-slowdebug
*** partial bug in review, this is not necessary for f30 and up, but please
dont forget it for f29+f28
java-latest-openjdk.src:2083: W: macro-in-%changelog %check
*** shoudl be fixed
atest-openjdk.src: W: invalid-url Source0: jdk-jdk12-jdk-12+33.tar.xz
*** the usptream do not have osurce releases, they are generated by scripts
which are in java-openjdk package
*** Petra Alice, please dont forget to importa also those files (they are not
in srpm[intentionally])
java-latest-openjdk-slowdebug.x86_64: W: undefined-non-weak-symbol
/usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64-slowdebug/lib/libawt_xawt.so
JVM_GetMethodIxLocalsCount,
java-latest-openjdk-slowdebug.x86_64: W: undefined-non-weak-symbol
/usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64-slowdebug/lib/libjawt.so
JVM_IsSameClassPackage,
java-latest-openjdk.x86_64: W: unused-direct-shlib-dependency
/usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libsplashscreen.so
libjpeg.so.62
*** I dont know how this is ok/not ok. Lets discuss java-team here.
java-latest-openjdk.x86_64: W: unstripped-binary-or-object
/usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libawt_xawt.so
*** jdk is stripped in way, it can be actually useful
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1693987] Review Request: java-latest-openjdk - rolling release for short term support OpenJDK
https://bugzilla.redhat.com/show_bug.cgi?id=1693987 --- Comment #4 from jiri vanek --- Unversioned so-files java-latest-openjdk: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libawt_xawt.so java-latest-openjdk: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libjawt.so java-latest-openjdk: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libsplashscreen.so java-latest-openjdk-slowdebug: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64-slowdebug/lib/libawt_xawt.so java-latest-openjdk-slowdebug: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64-slowdebug/lib/libjawt.so java-latest-openjdk-slowdebug: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64-slowdebug/lib/libsplashscreen.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libattach.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libawt.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libawt_headless.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libdt_socket.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libextnet.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libfontmanager.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libinstrument.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libj2gss.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libj2pcsc.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libj2pkcs11.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libjaas.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libjava.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libjavajpeg.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libjdwp.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libjimage.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libjli.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libjsig.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libjsound.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/liblcms.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libmanagement.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libmanagement_agent.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libmanagement_ext.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libmlib_image.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libnet.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libnio.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libprefs.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/librmi.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libsaproc.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libsctp.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libsunec.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libunpack.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libverify.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/libzip.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/server/libjsig.so java-latest-openjdk-headless: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/server/libjvm.so java-latest-openjdk-headless-slowdebug: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64-slowdebug/lib/libattach.so java-latest-openjdk-headless-slowdebug: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64-slowdebug/lib/libawt.so java-latest-openjdk-headless-slowdebug: /usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64-slowdebug/lib/libawt_headless.so java-late
[Bug 1693987] Review Request: java-latest-openjdk - rolling release for short term support OpenJDK
https://bugzilla.redhat.com/show_bug.cgi?id=1693987
--- Comment #3 from jiri vanek ---
This is rename of java-openjdk package. Except reanimg, it does nothing else.
This package can not obsolete java-openjdk, as it would obsolete
java-1.8.0-openjdk via manual provides of java-openjdk it have.
The java-openjdk package should be emptied together with this update, and
should require this new package as its implementation(thoughts?).
Tusu this can be handled later out of this review.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Header files in -devel subpackage, if present.
[1] all those seems to be internal headers. Public headers ar ecorreclty in
devel
- Package does not contain duplicates in %files.
Note: BUILDSTDERR: warning: File listed twice:
/usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib/server/classes.jsa
See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
*** Please check that and fix later
- This seems like a Java package, please install fedora-review-plugin-java
to get additional checks
*** Tis is java itself. In addition it is modular java itself. Not much plugin
can do here
- Bundled jar/class files should be removed before build
Note: Jar files in source (see attachment)
See: http://fedoraproject.org/wiki/Packaging:Java#Pre-
built_JAR_files_.2F_Other_bundled_software'
*** Those are IdealGraphVisualizer and tests. Please remove before build.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
Note: See rpmlint output
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Re-using old build in mock
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[!]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/icons/hicolor/24x24, /usr/share/icons/hicolor/32x32/apps,
/usr/share/icons/hicolor/24x24/apps,
/usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64-slowdebug,
/usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/16x16,
/usr/lib/jvm, /usr/share/icons/hicolor/48x48,
/usr/share/icons/hicolor/48x48/apps,
/usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/lib,
/usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64,
/usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor,
/usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64-slowdebug/lib
*** I'm not sure what to do with /usr/share/icons/. Had global settings changed
in since last review?
/usr/lib/jvm/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64{-slowdebug}/lib
should be fixed
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib/.build-
id/0d(librsvg2, libxcb, glusterfs, perl-interpreter,
libreoffice-core,...4)
*** likely bug in review - this direcotry i suse dy all native apps in fedora
with debuginfo
[x]: %build honors applicable compiler flags or justifies otherwise.
*** it honors as much as it can. Hard to mingle with it more
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
Note: Using prebuilt rpms.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: %config files are marked noreplace or the reason is justified.
Note: No (noreplace) in %config
/etc/java/java-12-openjdk/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/conf/management/jmxremote.password.template
%config
/etc/java/java-12-openjdk/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64/conf/sdp/sdp.conf.template
%config
/etc/java/java-12-openjdk/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64-slowdebug/conf/management/jmxremote.password.template
%config
/etc/java/java-12-openjdk/java-12-openjdk-12.0.0.33-3.rolling.fc29.x86_64-slowdebug/conf/sdp/sdp.conf.template
*** discussed several times,bad idea to use templates as norepalce
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %d
[Bug 1693987] Review Request: java-latest-openjdk - rolling release for short term support OpenJDK
https://bugzilla.redhat.com/show_bug.cgi?id=1693987 jiri vanek changed: What|Removed |Added Flags||fedora_requires_release_not ||e? fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
