[Bug 1711898] Review Request: zeal - Offline documentation browser inspired by Dash
https://bugzilla.redhat.com/show_bug.cgi?id=1711898
Vasiliy Glazov changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #4 from Vasiliy Glazov ---
Approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/zeal
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Naming/#_conflicting_package_names
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GPL (v3 or later)", "BSD 3-clause
"New" or "Revised" License GPL (v3 or later)", "*No copyright*
Creative Commons Attribution Public License (v4.0)", "Creative Commons
Attribution Public License (v4.0)". 278 files have unknown license.
Detailed output of licensecheck in
/home/vascom/1711898-zeal/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
fil
[Bug 1714400] Review Request: flashrom - update to 1.1-rc1
https://bugzilla.redhat.com/show_bug.cgi?id=1714400 David Hendricks changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NOTABUG Last Closed||2019-05-30 04:44:56 --- Comment #2 from David Hendricks --- Thanks, Peter! Patch pushed: https://src.fedoraproject.org/rpms/flashrom/c/8e2cf49182cca8d39193b2303133644caa2df1a8?branch=master -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1711898] Review Request: zeal - Offline documentation browser inspired by Dash
https://bugzilla.redhat.com/show_bug.cgi?id=1711898 --- Comment #3 from Lumír Balhar --- Hello, Vasiliy. Thank you very much for the review. All points solved. Spec URL: https://lbalhar.fedorapeople.org/zeal.spec SRPM URL: https://lbalhar.fedorapeople.org/zeal-0.6.1-2.fc30.src.rpm Patch to see just changes: https://lbalhar.fedorapeople.org/package-review.patch Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=35138895 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1715296] Review Request: libinsane - Cross-platform access to image scanners
https://bugzilla.redhat.com/show_bug.cgi?id=1715296 --- Comment #2 from Elliott Sales de Andrade --- Oops, I messed up %check; I've re-uploaded and here is the correct scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=35138872 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1714377] Review Request: ansible-bender - build container images using ansible playbooks
https://bugzilla.redhat.com/show_bug.cgi?id=1714377 --- Comment #11 from Gordon Messmer --- spec URL: https://bitbucket.org/gordonmessmer/ansible-bender/raw/e4b6e6b31b183acfc1c4bd748b402e07986446b9/ansible-bender.spec koji URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=35138464 I've included each of the suggested changes other than the comment regarding mock builds. Hopefully that narrows the focus of the review to just the issue of tests, for now. If you'd like, I could include two levels of conditions. --with check could be used to run the unit tests only by default and --with check --with alltests could be used to run the full set. This gets a little messy, but I have a branch in the git repo so that you can review that option. It does allow unit tests to run successfully in mock. https://bitbucket.org/gordonmessmer/ansible-bender/raw/600c993e5d74f4003675042d3be3af78d09a43f9/ansible-bender.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1715296] Review Request: libinsane - Cross-platform access to image scanners
https://bugzilla.redhat.com/show_bug.cgi?id=1715296 --- Comment #1 from Elliott Sales de Andrade --- koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=35138586 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1715296] New: Review Request: libinsane - Cross-platform access to image scanners
https://bugzilla.redhat.com/show_bug.cgi?id=1715296 Bug ID: 1715296 Summary: Review Request: libinsane - Cross-platform access to image scanners Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: quantum.anal...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://qulogic.fedorapeople.org//libinsane.spec SRPM URL: https://qulogic.fedorapeople.org//libinsane-1.0-1.fc30.src.rpm Description: Libinsane is the library to access scanners on both Linux and Windows. It's cross-platform, cross-programming languages, cross-scanners :-). It takes care of all the quirks of all the platforms and scanners. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1714377] Review Request: ansible-bender - build container images using ansible playbooks
https://bugzilla.redhat.com/show_bug.cgi?id=1714377 --- Comment #10 from Gordon Messmer --- I wasn't previously aware of the "--enable-network" flag for mock. However, that's not enough to allow the tests to run. The build log includes: Error: error running newgidmap: exit status 1: newgidmap: write to gid_map failed: Operation not permitted I'll continue to look into that for a while (unless there are known solutions for using rootless container tools in mock). I see that the mock environment includes values for mockbuild in /etc/sub[ug]id, so I'm actually surprised that this doesn't work. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1714377] Review Request: ansible-bender - build container images using ansible playbooks
https://bugzilla.redhat.com/show_bug.cgi?id=1714377
--- Comment #9 from Miro Hrončok ---
On Fedora 29, 30 and rawhide, ansible-python3 is provided by the ansible
package for backwards compatibility only. It should just need ansible.
When the tests are disabled by default, I suggest adding a comment to the spec
explaining why, something like:
# All tests require Internet access
# to test in mock use: --enable-network --with check
%bcond_with check
PYTHONPATH=%{buildroot}%{python3_sitelib}:%{buildroot}%{python3_sitearch}
the sitearch part is useless here, as the package only installs to sitelib.
pytest-%{python3_version} can be simplified to: pytest-3
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1714377] Review Request: ansible-bender - build container images using ansible playbooks
https://bugzilla.redhat.com/show_bug.cgi?id=1714377 --- Comment #8 from Gordon Messmer --- Created attachment 1575004 --> https://bugzilla.redhat.com/attachment.cgi?id=1575004&action=edit rpm build output with tests enabled, from Fedora 30 system -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1714377] Review Request: ansible-bender - build container images using ansible playbooks
https://bugzilla.redhat.com/show_bug.cgi?id=1714377 --- Comment #7 from Gordon Messmer --- So, the bad news is that all of the tests, including the unit tests, require network connectivity and cannot be run in mock. The good news is that I built an F30 VM and ran the build with tests there and got a successful run. I'll attach the build log, and hope that's suitable until tests that run in mock are available. (Tests also revealed a packaging bug: the tool requires ansible-python3.) The updated spec is here: https://bitbucket.org/gordonmessmer/ansible-bender/raw/7420961d8ad0a2727407b36a22348cce8552d8dc/ansible-bender.spec The updated koji build is here: https://koji.fedoraproject.org/koji/taskinfo?taskID=35135459 Tests are conditional, but off by default so that the build completes in koji. The release is bumped and new changelog entries added. Tests are run in parallel. Your feedback has been invaluable. Thank you both for your time. Please let me know if any other changes are needed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1714432] Review Request: golang-github-robfig-cron - Cron library for go
https://bugzilla.redhat.com/show_bug.cgi?id=1714432 --- Comment #5 from Elliott Sales de Andrade --- I tried to run fedora-review, but the tests fail: 2019/05/29 17:25:40 cron: panic running job: YOLO goroutine 23 [running]: github.com/robfig/cron.(*Cron).runWithRecovery.func1(0xcb8410) /builddir/build/BUILD/cron-b41be1df696709bb6395fe435af20370037c0b4c/_build/src/github.com/robfig/cron/cron.go:161 +0xa0 panic(0x5574fb915300, 0x5574fb949740) /usr/lib/golang/src/runtime/panic.go:522 +0x1b9 github.com/robfig/cron.TestFuncPanicRecovery.func1() /builddir/build/BUILD/cron-b41be1df696709bb6395fe435af20370037c0b4c/_build/src/github.com/robfig/cron/cron_test.go:19 +0x3b github.com/robfig/cron.FuncJob.Run(0x5574fb948ed8) /builddir/build/BUILD/cron-b41be1df696709bb6395fe435af20370037c0b4c/_build/src/github.com/robfig/cron/cron.go:92 +0x27 github.com/robfig/cron.(*Cron).runWithRecovery(0xcb8410, 0x5574fb94c0e0, 0x5574fb948ed8) /builddir/build/BUILD/cron-b41be1df696709bb6395fe435af20370037c0b4c/_build/src/github.com/robfig/cron/cron.go:165 +0x59 created by github.com/robfig/cron.(*Cron).run /builddir/build/BUILD/cron-b41be1df696709bb6395fe435af20370037c0b4c/_build/src/github.com/robfig/cron/cron.go:199 +0x74b 2019/05/29 17:25:41 cron: panic running job: YOLO goroutine 24 [running]: github.com/robfig/cron.(*Cron).runWithRecovery.func1(0xcf4000) /builddir/build/BUILD/cron-b41be1df696709bb6395fe435af20370037c0b4c/_build/src/github.com/robfig/cron/cron.go:161 +0xa0 panic(0x5574fb915300, 0x5574fb949770) /usr/lib/golang/src/runtime/panic.go:522 +0x1b9 github.com/robfig/cron.DummyJob.Run(...) /builddir/build/BUILD/cron-b41be1df696709bb6395fe435af20370037c0b4c/_build/src/github.com/robfig/cron/cron_test.go:30 github.com/robfig/cron.(*Cron).runWithRecovery(0xcf4000, 0x5574fb94c0c0, 0x5574fba4a5c0) /builddir/build/BUILD/cron-b41be1df696709bb6395fe435af20370037c0b4c/_build/src/github.com/robfig/cron/cron.go:165 +0x59 created by github.com/robfig/cron.(*Cron).run /builddir/build/BUILD/cron-b41be1df696709bb6395fe435af20370037c0b4c/_build/src/github.com/robfig/cron/cron.go:199 +0x74b --- FAIL: TestNonLocalTimezone (2.02s) cron_test.go:261: expected job fires 2 times FAIL exit status 1 FAILgithub.com/robfig/cron 25.439s -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1713767] Review Request: libnbd - NBD client library in userspace
https://bugzilla.redhat.com/show_bug.cgi?id=1713767 --- Comment #29 from Fedora Update System --- FEDORA-2019-dd6247f38d has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-dd6247f38d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1713767] Review Request: libnbd - NBD client library in userspace
https://bugzilla.redhat.com/show_bug.cgi?id=1713767 --- Comment #28 from Fedora Update System --- FEDORA-2019-c29b9bbf0d has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-c29b9bbf0d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1713852] Review Request: asdcplib - AS-DCP file access libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1713852 --- Comment #4 from Simone Caronni --- Thanks, will update! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1713767] Review Request: libnbd - NBD client library in userspace
https://bugzilla.redhat.com/show_bug.cgi?id=1713767 Richard W.M. Jones changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NEXTRELEASE Last Closed||2019-05-29 20:26:33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1416455] Review Request: python-easywatch - super simple directory monitoring
https://bugzilla.redhat.com/show_bug.cgi?id=1416455 Fabian Affolter changed: What|Removed |Added CC||m...@fabian-affolter.ch --- Comment #2 from Fabian Affolter --- 0.0.4 was released. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1316526] Review Request: jo - Command-line to create JSON objects
https://bugzilla.redhat.com/show_bug.cgi?id=1316526 Fabian Affolter changed: What|Removed |Added CC||m...@fabian-affolter.ch Flags|fedora-review? |needinfo?(knakayam@redhat.c ||om) --- Comment #5 from Fabian Affolter --- Kenjiro, can you please provide an updated SPEc file? Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1713767] Review Request: libnbd - NBD client library in userspace
https://bugzilla.redhat.com/show_bug.cgi?id=1713767 --- Comment #27 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libnbd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1692166] Review Request: gnatcoll-db - The GNAT Components Collection – database packages
https://bugzilla.redhat.com/show_bug.cgi?id=1692166 Björn Persson changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2019-05-29 16:51:11 --- Comment #15 from Björn Persson --- Thanks Richard for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1692166] Review Request: gnatcoll-db - The GNAT Components Collection – database packages
https://bugzilla.redhat.com/show_bug.cgi?id=1692166 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED --- Comment #14 from Fedora Update System --- FEDORA-2019-cfeb86a4bf has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-cfeb86a4bf -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1689552] Review Request: gnatcoll-bindings - The GNAT Components Collection – bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1689552 --- Comment #8 from Fedora Update System --- FEDORA-2019-cfeb86a4bf has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-cfeb86a4bf -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1713767] Review Request: libnbd - NBD client library in userspace
https://bugzilla.redhat.com/show_bug.cgi?id=1713767 Björn Persson changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1713767] Review Request: libnbd - NBD client library in userspace
https://bugzilla.redhat.com/show_bug.cgi?id=1713767 Björn Persson changed: What|Removed |Added Flags|fedora-review+ |fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1713767] Review Request: libnbd - NBD client library in userspace
https://bugzilla.redhat.com/show_bug.cgi?id=1713767 Björn Persson changed: What|Removed |Added Flags|needinfo?(bjorn@xn--rombobj | |rn-67a.se) | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1711898] Review Request: zeal - Offline documentation browser inspired by Dash
https://bugzilla.redhat.com/show_bug.cgi?id=1711898 Miro Hrončok changed: What|Removed |Added CC||mhron...@redhat.com --- Comment #2 from Miro Hrončok --- > This package still not retired. Unfortunately the package is technically retired and the maintainer doesn't respond to the problem: bz1701666 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1275438] Review Request: xindy - Index generator for structured documents like LaTeX or SGML
https://bugzilla.redhat.com/show_bug.cgi?id=1275438 Ankur Sinha (FranciscoD) changed: What|Removed |Added Status|NEW |CLOSED CC||sanjay.an...@gmail.com Resolution|--- |WONTFIX Last Closed||2019-05-29 15:11:11 --- Comment #10 from Ankur Sinha (FranciscoD) --- Closing this as xindy is now provided by texlive-base and should be available soon, thanks to Jerry. https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/thread/PCLDKHMHV74EXEVHO4N67BZHIN2KSKK4/#EDYQMWDTQ4USAVJGMAGH7Z7SXEV4CNTK -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1713767] Review Request: libnbd - NBD client library in userspace
https://bugzilla.redhat.com/show_bug.cgi?id=1713767 Richard W.M. Jones changed: What|Removed |Added Flags||needinfo?(bjorn@xn--rombobj ||rn-67a.se) --- Comment #26 from Richard W.M. Jones --- Sorry about this - apparently the repo can't be created if the fedora-review+ flag is set by the same person who opened the bug. Would it be possible for you to set the fedora-review+ flag again? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1667661] Review Request: python-astunparse - An AST unparser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1667661 --- Comment #12 from Miro Hrončok --- License tag fixed and clarified: Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-astunparse.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-astunparse-1.6.2-1.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1692166] Review Request: gnatcoll-db - The GNAT Components Collection – database packages
https://bugzilla.redhat.com/show_bug.cgi?id=1692166 --- Comment #13 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gnatcoll-db -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1652036] Review Request: cockpit-session-recording - Package provides session recording playback in Cockpit
https://bugzilla.redhat.com/show_bug.cgi?id=1652036 --- Comment #8 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/cockpit-session-recording -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1556913] Review Request: dhtest - A DHCP client simulation on linux
https://bugzilla.redhat.com/show_bug.cgi?id=1556913 Pavel Zhukov changed: What|Removed |Added Blocks||201449 (FE-DEADREVIEW) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1713767] Review Request: libnbd - NBD client library in userspace
https://bugzilla.redhat.com/show_bug.cgi?id=1713767 Richard W.M. Jones changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #25 from Richard W.M. Jones --- Crap, how did I manage to change the review flag? That was accidental, and I've set it back to "+" based on the review in comment 23. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1713767] Review Request: libnbd - NBD client library in userspace
https://bugzilla.redhat.com/show_bug.cgi?id=1713767 Richard W.M. Jones changed: What|Removed |Added Flags|fedora-review+ |fedora-review? --- Comment #24 from Richard W.M. Jones --- That's right. I basically copied the idea from libvirt where it works like this: https://www.berrange.com/posts/2016/11/15/new-tls-algorithm-priority-config-for-libvirt-with-gnutls-on-fedora-25/ Thanks for taking the time to carefully review this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1713232] Review Request: openhantek - Hantek USB digital signal oscilloscope
https://bugzilla.redhat.com/show_bug.cgi?id=1713232 --- Comment #5 from Vasiliy Glazov --- I asked in legal mail list. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706980] Review Request: python-smi - A Python implementation of SNMP/SMI MIB parsing and conversion library
https://bugzilla.redhat.com/show_bug.cgi?id=1706980
--- Comment #2 from Jan ONDREJ ---
Nice to see a package from an experienced packager. Your package looks very
well. Just one problem found, that check is commented out. I understand, why
you did this, but looks like currently it works well, so please enable it and
then I can approve this package.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 2-clause "Simplified" License",
"*No copyright* BSD (unspecified)". 124 files have unknown license.
Detailed output of licensecheck in /tmp/smi/1706980-python-
smi/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 10 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package sho
[Bug 1706980] Review Request: python-smi - A Python implementation of SNMP/SMI MIB parsing and conversion library
https://bugzilla.redhat.com/show_bug.cgi?id=1706980 Jan ONDREJ changed: What|Removed |Added Assignee|nob...@fedoraproject.org|ondr...@salstar.sk -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1706980] Review Request: python-smi - A Python implementation of SNMP/SMI MIB parsing and conversion library
https://bugzilla.redhat.com/show_bug.cgi?id=1706980 Jan ONDREJ changed: What|Removed |Added CC||ondr...@salstar.sk Flags||fedora-review? --- Comment #1 from Jan ONDREJ --- Taking this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1713767] Review Request: libnbd - NBD client library in userspace
https://bugzilla.redhat.com/show_bug.cgi?id=1713767 Björn Persson changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #23 from Björn Persson --- I believe I now understand the crypto policy. The system-wide policy is in effect by default, but the sysadmin can override it specifically for programs that use libnbd by creating a file named /etc/crypto-policies/local.d/gnutls-*.config with a line that begins with "LIBNBD=", and then running update-crypto-policies. This is quite reasonable. The licensing issues have been resolved in version 0.1.1. This package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1708165] Review Request: python-betamax-serializers - A set of third-party serializers for Betamax
https://bugzilla.redhat.com/show_bug.cgi?id=1708165 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED --- Comment #7 from Fedora Update System --- FEDORA-2019-5b854c3f60 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-5b854c3f60 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1713232] Review Request: openhantek - Hantek USB digital signal oscilloscope
https://bugzilla.redhat.com/show_bug.cgi?id=1713232 Peter Lemenkov changed: What|Removed |Added CC||lemen...@gmail.com --- Comment #4 from Peter Lemenkov --- (In reply to Vitaly Zaitsev from comment #2) > I already reviewed this package for RPM Fusion: > https://bugzilla.rpmfusion.org/show_bug.cgi?id=4860 > > This package contains reverse-engineered firmwares. You need approval by > Fedora Legal team. This might be a clean room RE so it could be acceptable (as it was with b43-openfwwf firmware before). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1713232] Review Request: openhantek - Hantek USB digital signal oscilloscope
https://bugzilla.redhat.com/show_bug.cgi?id=1713232 --- Comment #3 from Vitaly Zaitsev --- Additional information about this firmwares: https://github.com/OpenHantek/openhantek/issues/240#issuecomment-494361989 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1713232] Review Request: openhantek - Hantek USB digital signal oscilloscope
https://bugzilla.redhat.com/show_bug.cgi?id=1713232 Vitaly Zaitsev changed: What|Removed |Added CC||vit...@easycoding.org Blocks||182235 (FE-Legal) Assignee|nob...@fedoraproject.org|vit...@easycoding.org Flags||fedora-review? --- Comment #2 from Vitaly Zaitsev --- I already reviewed this package for RPM Fusion: https://bugzilla.rpmfusion.org/show_bug.cgi?id=4860 This package contains reverse-engineered firmwares. You need approval by Fedora Legal team. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1714432] Review Request: golang-github-robfig-cron - Cron library for go
https://bugzilla.redhat.com/show_bug.cgi?id=1714432 --- Comment #4 from Mark Goodwin --- (In reply to Elliott Sales de Andrade from comment #3) > Yes, but the v3.0.0-rc1 tag is the same as the HEAD of the v3 branch, so > it'd be the same code, just with a proper version. grafana has vendored HEAD of the master branch, which is different (newer) to HEAD of the v3 branch. That leads me to think final tagged v3.0.0 (when it happens) will be same (or close) to current master, and hence why grafana went with that rather than current v3. Regards -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1714432] Review Request: golang-github-robfig-cron - Cron library for go
https://bugzilla.redhat.com/show_bug.cgi?id=1714432 --- Comment #3 from Elliott Sales de Andrade --- Yes, but the v3.0.0-rc1 tag is the same as the HEAD of the v3 branch, so it'd be the same code, just with a proper version. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1623787] minizip-2.8.8 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1623787 Ondrej Dubaj changed: What|Removed |Added CC||upstream-release-monitoring ||@fedoraproject.org --- Comment #3 from Ondrej Dubaj --- *** Bug 1708484 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
