[Bug 1734565] Review Request: rust-fxhash - Fast, non-secure, hashing algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1734565 Igor Gnatenko changed: What|Removed |Added Status|NEW |POST CC||i.gnatenko.br...@gmail.com Assignee|nob...@fedoraproject.org|i.gnatenko.br...@gmail.com Flags||fedora-review+ --- Comment #2 from Igor Gnatenko --- > # Generated by rust2rpm 9 It seems that it was generated using v10, but somehow header is still 9? --- Anyhow, package is good. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1728373] Review Request: python-glymur - Glymur is a Python interface for JPEG 2000
https://bugzilla.redhat.com/show_bug.cgi?id=1728373 Tomas Korbar changed: What|Removed |Added Flags||needinfo?(l...@blackfile.ne ||t) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1733024] Review Request: python-vevents - VMware vSphere Events from the command-line
https://bugzilla.redhat.com/show_bug.cgi?id=1733024 --- Comment #13 from Fedora Update System --- python-vevents-0.1.0-0.1.20149631git3ff37a2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-943f92477a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1730911] Review Request: wgctrl - Control of WireGuard interfaces on multiple platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1730911 --- Comment #7 from Fedora Update System --- wgctrl-0-0.1.20190729git28f4e24.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-ad40674b22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1733024] Review Request: python-vevents - VMware vSphere Events from the command-line
https://bugzilla.redhat.com/show_bug.cgi?id=1733024 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- python-vevents-0.1.0-0.1.20149631git3ff37a2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-85639d3759 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1093521] Review Request: clingo - A bottom up grounder for logic programs
https://bugzilla.redhat.com/show_bug.cgi?id=1093521 --- Comment #5 from Fedora Update System --- clingo-5.3.0-5.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-62e94f4912 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1730911] Review Request: wgctrl - Control of WireGuard interfaces on multiple platforms
https://bugzilla.redhat.com/show_bug.cgi?id=1730911 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- wgctrl-0-0.1.20190729git28f4e24.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-e78467093e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1093521] Review Request: clingo - A bottom up grounder for logic programs
https://bugzilla.redhat.com/show_bug.cgi?id=1093521 --- Comment #4 from Fedora Update System --- clingo-5.3.0-5.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-237ce6f0dc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1733243] Review Request: gedit-control-your-tabs - Gedit plugin to switch between document tabs using
https://bugzilla.redhat.com/show_bug.cgi?id=1733243 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2019-07-31 01:04:50 --- Comment #8 from Fedora Update System --- gedit-control-your-tabs-0.3.2-7.20190225gitd594f75.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1689494] Review Request: python-xarray - N-D labeled arrays and datasets in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1689494 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-07-31 01:04:41 --- Comment #5 from Fedora Update System --- python-xarray-0.12.3-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1733190] Review Request: python34-setuptools - Easily build and distribute Python 3.4 packages
https://bugzilla.redhat.com/show_bug.cgi?id=1733190 Miro Hrončok changed: What|Removed |Added Blocks||1734572 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1734572 [Bug 1734572] Upcoming Conflict with RHEL 7.7 Python3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1733193] Review Request: python2-wheel - A built-package format for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1733193 Miro Hrončok changed: What|Removed |Added Blocks||1734572 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1734572 [Bug 1734572] Upcoming Conflict with RHEL 7.7 Python3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734445] Review Request: python2-numpy - A fast multidimensional array facility for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1734445 --- Comment #18 from Miro Hrončok --- BTW https://src.fedoraproject.org/rpms/python2-numpy already exists (for EPEL), so request unretirement via https://pagure.io/releng/issues -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734445] Review Request: python2-numpy - A fast multidimensional array facility for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1734445 Miro Hrončok changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #17 from Miro Hrončok --- Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734565] Review Request: rust-fxhash - Fast, non-secure, hashing algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1734565 --- Comment #1 from Robert-André Mauchin --- Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=36695282 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1725924] Review Request: pveclib - Library for simplified access to PowerISA vector operations
https://bugzilla.redhat.com/show_bug.cgi?id=1725924 Ankur Sinha (FranciscoD) changed: What|Removed |Added Assignee|nob...@fedoraproject.org|sanjay.an...@gmail.com --- Comment #28 from Ankur Sinha (FranciscoD) --- (In reply to Steven Jay Munroe from comment #27) > So my first attempt to request "fedpkg request-repo" was rejected because I > (no one) was not assigned to this bugzilla. Should work now. Somehow I forgot to assign the bug to myself. > > But when tried to click on the assignee link gnome mail crashed and now all > I get is "nob...@fedoraproject.org" email popup. > > Is this how this works (send email to nob...@fedoraproject.org)? I was > expecting more automation. I reckon you clicked the e-mail address which was a "mailto" link, and so it tried to open in your e-mail client. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734565] New: Review Request: rust-fxhash - Fast, non-secure, hashing algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1734565 Bug ID: 1734565 Summary: Review Request: rust-fxhash - Fast, non-secure, hashing algorithm Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: zebo...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://eclipseo.fedorapeople.org/for-review/rust-fxhash.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/rust-fxhash-0.2.1-1.fc31.src.rpm Description: Fast, non-secure, hashing algorithm derived from an internal hasher used in FireFox and Rustc. Fedora Account System Username: eclipseo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734558] New: Review Request: uberwriter - Distraction free Markdown editor for GNU/Linux made with GTK+
https://bugzilla.redhat.com/show_bug.cgi?id=1734558 Bug ID: 1734558 Summary: Review Request: uberwriter - Distraction free Markdown editor for GNU/Linux made with GTK+ Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ego.corda...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/uberwriter/fedora-30-x86_64/00989263-uberwriter/uberwriter.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/uberwriter/fedora-30-x86_64/00989263-uberwriter/uberwriter-2.1.5-1.fc30.src.rpm Description: Uberwriter is a GTK+ based distraction free Markdown editor, mainly developed by Wolf Vollprecht. It uses pandoc as backend for markdown parsing and offers a very clean and sleek user interface. Fedora Account System Username: atim Working COPR: https://copr.fedorainfracloud.org/coprs/atim/uberwriter/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734445] Review Request: python2-numpy - A fast multidimensional array facility for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1734445 --- Comment #16 from Gwyn Ciesla --- SPEC: https://fedorapeople.org/~limb/review/python2-numpy/python2-numpy.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734445] Review Request: python2-numpy - A fast multidimensional array facility for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1734445 --- Comment #15 from Miro Hrončok --- spec should be enough. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1519834] Review Request: BOUT++ - Computational fluid simulation library for curvi-linear geometries
https://bugzilla.redhat.com/show_bug.cgi?id=1519834 --- Comment #5 from Robert-André Mauchin --- There are new macros you should use: https://src.fedoraproject.org/rpms/mpich/blob/master/f/mpich.macros https://src.fedoraproject.org/rpms/openmpi/blob/master/f/macros.openmpi - Use %_mpich_load / %_mpich_unload / %_openmpi_load / %_openmpi_load - Use %bcond_with / %bcond_without for all the conditional - This is not really elegant, anyhow remove the shebangs alltogether, in %prep if possible # Fix python interpreter for libraries for f in $(find -L ${RPM_BUILD_ROOT}/%{python3_sitelib} -executable -type f) do sed -i 's|#!/usr/bin/env python|#!/usr/bin/python3|' $f sed -i 's|#!/usr/bin/env python3|#!/usr/bin/python3|' $f sed -i 's|#!/usr/bin/python|#!/usr/bin/python3|' $f # remove introduced but excessive 3's sed -i 's|#!/usr/bin/python333|#!/usr/bin/python3|' $f sed -i 's|#!/usr/bin/python33|#!/usr/bin/python3|' $f done - Take into account RHEL8/EPEL8 for your conditions, as in if epel and epel < 8 - Also but more linebreaks between sections, the SPEC is difficult to read - I'm not sure what you're trying to do here, but that's not how to include a Patch: echo "diff -Naur a/make.config b/make.config --- a/make.config 2017-05-02 23:03:57.298625399 +0100 +++ b/make.config 2017-05-02 23:04:26.460489477 +0100 @@ -23,6 +23,7 @@ SLEPC_DIR ?= SLEPC_ARCH ?= +RELEASED = %{version}-%{release} # These lines can be replaced in \"make install\" to point to install directories # They are used in the CXXFLAGS variable below rather than hard-coding the directories " | patch --no-backup-if-mismatch -p1 --fuzz=0 ${RPM_BUILD_ROOT}/%{_includedir}/${mpi}-%{_arch}/bout++/make.config Use sed in %prep on make.config.in to add your line - Why is this in check: for f in $(find -L ${RPM_BUILD_ROOT}/%{python3_sitelib}/ -type f|grep '\.pyc\$|\.pyo\$') do echo cleaning $f rm $f done - Don't be so specific in %files: %dir %{_includedir}/mpich-%{_arch}/bout++ %dir %{_includedir}/mpich-%{_arch}/bout++/bout %dir %{_includedir}/mpich-%{_arch}/bout++/bout/invert %dir %{_includedir}/mpich-%{_arch}/bout++/bout/sys %{_includedir}/mpich-%{_arch}/bout++/*.hxx %{_includedir}/mpich-%{_arch}/bout++/make.config %{_includedir}/mpich-%{_arch}/bout++/bout/*.hxx %{_includedir}/mpich-%{_arch}/bout++/bout/invert/*.hxx %{_includedir}/mpich-%{_arch}/bout++/bout/sys/*.hxx %{_includedir}/mpich-%{_arch}/bout++/pvode/*.h Just use: %{_includedir}/mpich-%{_arch}/bout++ and: %{_includedir}/openmpi-%{_arch}/bout++ Also remove the * here: %{python3_sitearch}/mpich/ %{python3_sitearch}/openmpi/ - Not needed for private libs: %post mpich -p /sbin/ldconfig %postun mpich -p /sbin/ldconfig - It is verboten to glob the whole %{python3_sitelib}/ Be more specific here: %dir %{python3_sitelib}/* %{python3_sitelib}/*/* - Man pages are not part of %doc: %doc %{_mandir}/man1/bout++* Man pages should be in the same package as the binary they describe - I'm not really fond of making a package just for licenses and doc file: %files common %doc README.md %doc CITATION.bib %doc CITATION.cff %doc CHANGELOG.md %doc CONTRIBUTING.md %license LICENSE %license LICENSE.GPL Put them in python%{python3_pkgversion}-%{name} %{name}-openmpi %{name}-mpich -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1725924] Review Request: pveclib - Library for simplified access to PowerISA vector operations
https://bugzilla.redhat.com/show_bug.cgi?id=1725924 --- Comment #27 from Steven Jay Munroe --- So my first attempt to request "fedpkg request-repo" was rejected because I (no one) was not assigned to this bugzilla. But when tried to click on the assignee link gnome mail crashed and now all I get is "nob...@fedoraproject.org" email popup. Is this how this works (send email to nob...@fedoraproject.org)? I was expecting more automation. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1733707] Review Request: multi-git-status - Show uncommitted, untracked and unpushed changes for multiple Git repos
https://bugzilla.redhat.com/show_bug.cgi?id=1733707 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/multi-git-status -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1732942] Review Request: libmodulemd1 - Module metadata manipulation library
https://bugzilla.redhat.com/show_bug.cgi?id=1732942 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #6 from Robert-André Mauchin --- LGTM, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734161] Review Request: scitokens-cpp - C++ SciTokens Library
https://bugzilla.redhat.com/show_bug.cgi?id=1734161 --- Comment #4 from Derek --- Thank you for your comments. I hope I have addressed all of the comments: - devtoolset-8 is required on EPEL6 because the package needs c++11. - We package the header-only jwt-cpp dependency. I made a note in the spec file [0] about the inclusion of jwt-cpp. But, since it's a header-only dependency, it will not be "provided" by the package at the end. - I reworked how to generate the source. Now it is simply a few different steps, git submodule update, ... It is all documented in the spec. - Now calling %make_build [0] https://raw.githubusercontent.com/scitokens/scitokens-cpp/dec05b8a8532f13d2b01371c95347efdf961a7e1/rpm/scitokens-cpp.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734445] Review Request: python2-numpy - A fast multidimensional array facility for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1734445 --- Comment #14 from Gwyn Ciesla --- You're right, there is some BSD. Fixed. Want a new SRPM? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734445] Review Request: python2-numpy - A fast multidimensional array facility for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1734445 --- Comment #13 from Miro Hrončok --- Sorry to iterate over and over, but is the docs really just ASL? Isn't the docs BSD as well (with ASL css only)? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734445] Review Request: python2-numpy - A fast multidimensional array facility for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1734445 --- Comment #12 from Gwyn Ciesla --- Oops. Tag fixed. SPEC: https://fedorapeople.org/~limb/review/python2-numpy/python2-numpy.spec SRPM: https://fedorapeople.org/~limb/review/python2-numpy/python2-numpy-1.16.4-4.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734445] Review Request: python2-numpy - A fast multidimensional array facility for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1734445 --- Comment #11 from Miro Hrončok --- # Everything is BSD except for class SafeEval in numpy/lib/utils.py which is Python License:BSD and Python and ASL 2.0 The comment is now not consistent with the tag. Apache License (v2.0) - numpy-1.16.4/doc/scipy-sphinx-theme/_theme/scipy/static/css/spc-bootstrap.css numpy-1.16.4/doc/scipy-sphinx-theme/_theme/scipy/static/less/bootstrap/bootstrap.less numpy-1.16.4/doc/scipy-sphinx-theme/_theme/scipy/static/less/bootstrap/responsive.less Those are only in python2-numpy-doc. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734445] Review Request: python2-numpy - A fast multidimensional array facility for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1734445 --- Comment #10 from Gwyn Ciesla --- Dropped static lib, fixed license tag and f2py Requires. Source 404 is due to upstream's doc publishing having moved on. Requiring gcc, though gcc-fortran requires it. SPEC: https://fedorapeople.org/~limb/review/python2-numpy/python2-numpy.spec SRPM: https://fedorapeople.org/~limb/review/python2-numpy/python2-numpy-1.16.4-4.fc30.src.rpm Also applied these fixes to the mainline numpy package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734445] Review Request: python2-numpy - A fast multidimensional array facility for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1734445 --- Comment #9 from Miro Hrončok --- Note that all of the issues, were already present before. So technically, if you wish to disregard some, let me know. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1725924] Review Request: pveclib - Library for simplified access to PowerISA vector operations
https://bugzilla.redhat.com/show_bug.cgi?id=1725924 --- Comment #26 from Ankur Sinha (FranciscoD) --- > Another round of tests on to verify I did not miss something then on to > fedora-review It is not required to run fedora-review on your spec/srpm now since the review here is complete, but please feel free to use fedora-review as a helper tool to run checks and review other's submissions. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734445] Review Request: python2-numpy - A fast multidimensional array facility for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1734445 --- Comment #8 from Miro Hrončok --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: === - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: python2-numpy. /usr/lib64/python2.7/site-packages/numpy/core/lib/libnpymath.a See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#packaging-static-libraries - Please recheck the License. - https://docs.scipy.org/doc/numpy/numpy-html-1.16.1.zip is 404 - f2py should require numpy with %_isa = MUST items = C/C++: [x]: Package does not contain kernel modules. [ ]: Package contains no static executables. There is /usr/lib64/python2.7/site-packages/numpy/core/lib/libnpymath.a [-]: Development (unversioned) .so files in -devel subpackage, if present. Not relevant. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-clause "New" or "Revised" License", "BSD 2-clause "Simplified" License", "*No copyright* BSD (unspecified)", "Expat License", "BSD (unspecified)", "Expat License BSD 3-clause "New" or "Revised" License", "zlib/libpng license", "Apache License (v2.0)", "Python Software Foundation License version 2". 1095 files have unknown license. Detailed output of licensecheck: *No copyright* BSD (unspecified) numpy-1.16.4/doc/sphinxext/setup.py Apache License (v2.0) - numpy-1.16.4/doc/scipy-sphinx-theme/_theme/scipy/static/css/spc-bootstrap.css numpy-1.16.4/doc/scipy-sphinx-theme/_theme/scipy/static/less/bootstrap/bootstrap.less numpy-1.16.4/doc/scipy-sphinx-theme/_theme/scipy/static/less/bootstrap/responsive.less BSD (unspecified) - numpy-1.16.4/doc/scipy-sphinx-theme/_theme/scipy/layout.html numpy-1.16.4/doc/scipy-sphinx-theme/_theme/scipy/static/scipy.css_t numpy-1.16.4/doc/source/_templates/defindex.html numpy-1.16.4/doc/source/_templates/searchbox.html numpy-1.16.4/numpy/random/mtrand/Python.pxi BSD 2-clause "Simplified" License - numpy-1.16.4/doc/sphinxext/LICENSE.txt numpy-1.16.4/numpy/core/src/npymath/npy_math_complex.c.src numpy-1.16.4/numpy/testing/_private/parameterized.py BSD 3-clause "New" or "Revised" License --- numpy-1.16.4/LICENSE.txt numpy-1.16.4/doc/scipy-sphinx-theme/LICENSE.txt numpy-1.16.4/doc/source/license.rst numpy-1.16.4/numpy/linalg/lapack_lite/LICENSE.txt numpy-1.16.4/numpy/ma/LICENSE numpy-1.16.4/numpy/random/mtrand/initarray.c numpy-1.16.4/tools/swig/numpy.i Expat License - numpy-1.16.4/numpy/random/mtrand/distributions.c numpy-1.16.4/numpy/random/mtrand/distributions.h numpy-1.16.4/numpy/random/mtrand/mtrand.pyx numpy-1.16.4/numpy/random/mtrand/randomkit.h numpy-1.16.4/tools/npy_tempita/license.txt Expat License BSD 3-clause "New" or "Revised" License - numpy-1.16.4/numpy/random/mtrand/randomkit.c Python Software Foundation License version 2 numpy-1.16.4/doc/scipy-sphinx-theme/_theme/scipy/static/js/copybutton.js [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo pac
[Bug 1733024] Review Request: python-vevents - VMware vSphere Events from the command-line
https://bugzilla.redhat.com/show_bug.cgi?id=1733024 --- Comment #11 from Fedora Update System --- FEDORA-2019-5a62974b12 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-5a62974b12 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1733024] Review Request: python-vevents - VMware vSphere Events from the command-line
https://bugzilla.redhat.com/show_bug.cgi?id=1733024 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #10 from Fedora Update System --- FEDORA-EPEL-2019-943f92477a has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-943f92477a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734445] Review Request: python2-numpy - A fast multidimensional array facility for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1734445 --- Comment #7 from Gwyn Ciesla --- Done. SPEC: https://fedorapeople.org/~limb/review/python2-numpy/python2-numpy.spec SRPM: https://fedorapeople.org/~limb/review/python2-numpy/python2-numpy-1.16.4-4.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734445] Review Request: python2-numpy - A fast multidimensional array facility for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1734445 --- Comment #6 from Miro Hrončok --- > I think the numpy Provides should follow python2-numpy... BTW I don't agree but won't block this review on that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734445] Review Request: python2-numpy - A fast multidimensional array facility for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1734445 --- Comment #5 from Miro Hrončok --- Post the new one please, the checks are fast. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734445] Review Request: python2-numpy - A fast multidimensional array facility for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1734445 --- Comment #4 from Gwyn Ciesla --- I've fixed most of this but will hold off posting a new SRPM until your tests finish. I think the numpy Provides should follow python2-numpy, as the python3- naming is compliant and that isn't. It also minimizes breakage for users if dependent packages have bad Requires on numpy. The duplicated docs are to prevent broken hyperlinks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734445] Review Request: python2-numpy - A fast multidimensional array facility for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1734445 --- Comment #3 from Miro Hrončok --- Also those should be in Python 3: %{_bindir}/f2py %{_bindir}/f2py.numpy -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734445] Review Request: python2-numpy - A fast multidimensional array facility for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1734445 --- Comment #2 from Miro Hrončok --- I also suggest to update the summary: > Summary:A fast multidimensional array facility for Python Summary:A fast multidimensional array facility for Python 2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734445] Review Request: python2-numpy - A fast multidimensional array facility for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1734445 --- Comment #1 from Miro Hrončok --- Running automated checks. In the meantime, here are the things that I find weird: Requires: python2-nose Why is this a runtime dependency? Provides: numpy = %{epoch}:%{version}-%{release} Provides: numpy%{?_isa} = %{epoch}:%{version}-%{release} Provides: f2py = %{epoch}:%{version}-%{release} Provides: numpy-f2py = %{epoch}:%{version}-%{release} I believe those should now be in the Python 3 package: https://fedoraproject.org/wiki/Changes/Python_means_Python3 Note that any Requires, Provides, Obsoletes bellow the %descripton are evaluated as part of that description and will not end up in the package metadata. %package -n python2-numpy-f2py -> %package f2py %package -n python2-numpy-doc -> %package doc %files -n python2-numpy -> %files %files -n python2-numpy-f2py -> %files f2py %files -n python2-numpy-doc -> %files doc %if 0%{?fedora} >= 21 || 0%{?rhel} > 7->%if 0%{?fedora} || 0%{?rhel} > 7 %if %{_arch} != s390x && %{_arch} != ppc64le -> %ifnarch s390x ppc64le %{python2_sitearch}/%{modname}-*.egg-info Add trailing slash if a directory? %files -n python2-numpy-f2py %doc docs/f2py/*.html ... %files -n python2-numpy-doc %doc docs/* Is docs/f2py/*.html in both? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1725924] Review Request: pveclib - Library for simplified access to PowerISA vector operations
https://bugzilla.redhat.com/show_bug.cgi?id=1725924 --- Comment #25 from Steven Jay Munroe --- > Please explicitly version the shared objects OK > XXX APPROVED Thanks. I bumped the pveclib tag to v1.0.3 and updated the pveclib.spec to reflect that: https://github.com/open-power-sdk/fedora/blob/master/pveclib.spec Another round of tests on to verify I did not miss something then on to fedora-review -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734445] Review Request: python2-numpy - A fast multidimensional array facility for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1734445 Miro Hrončok changed: What|Removed |Added Status|NEW |ASSIGNED CC||mhron...@redhat.com Assignee|nob...@fedoraproject.org|mhron...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734445] New: Review Request: python2-numpy - A fast multidimensional array facility for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1734445 Bug ID: 1734445 Summary: Review Request: python2-numpy - A fast multidimensional array facility for Python Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: gw...@protonmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora NOTE: this is a split from the main numpy SRPM because the latest upstream discontinues Python2 support. SPEC: https://fedorapeople.org/~limb/review/python2-numpy/python2-numpy.spec SRPM: https://fedorapeople.org/~limb/review/python2-numpy/python2-numpy-1.16.4-4.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1519834] Review Request: BOUT++ - Computational fluid simulation library for curvi-linear geometries
https://bugzilla.redhat.com/show_bug.cgi?id=1519834 --- Comment #4 from david08...@gmail.com --- Updated URLs Spec URL: https://copr-be.cloud.fedoraproject.org/results/davidsch/bout/fedora-rawhide-x86_64/00863814-bout++/bout++.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/davidsch/bout/fedora-rawhide-x86_64/00863814-bout++/bout++-4.2.2-0.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734161] Review Request: scitokens-cpp - C++ SciTokens Library
https://bugzilla.redhat.com/show_bug.cgi?id=1734161 david08...@gmail.com changed: What|Removed |Added CC||david08...@gmail.com --- Comment #3 from david08...@gmail.com --- The source contains actually 2 sources, the one is [0] and the other one jwt-cpp. The preferred way is to package both of them separately. If you decide against that, you must at least mentioned that you have bundled jwt-cpp, see [1] I don't think that the script to generate the source is acceptable, as it does not ensure that other people get the same version, that you used. You should ensure that the source is a link that ensures a specific version is returned, such as using the above link to a release or a specific git-commit. Also, you shouldn't invoke make directly, but use %make_build instead, see [2] [0] https://github.com/scitokens/scitokens-cpp/archive/v0.3.3.tar.gz [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_parallel_make -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1732942] Review Request: libmodulemd1 - Module metadata manipulation library
https://bugzilla.redhat.com/show_bug.cgi?id=1732942 --- Comment #5 from Stephen Gallagher --- OK, I just had a look and it seems like the infrastructure components still relying on libmodulemd1 are all Python 3 now, so I'll drop those subpackages. Spec URL: https://sgallagh.fedorapeople.org/packagereview/libmodulemd1/libmodulemd1.spec SRPM URL: https://sgallagh.fedorapeople.org/packagereview/libmodulemd1/libmodulemd1-1.8.15-3.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1731111] Review Request: osbuild - A build system for OS images
https://bugzilla.redhat.com/show_bug.cgi?id=173 --- Comment #10 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/osbuild -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1733024] Review Request: python-vevents - VMware vSphere Events from the command-line
https://bugzilla.redhat.com/show_bug.cgi?id=1733024 --- Comment #9 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-vevents -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1654667] Review Request: perl-Authen-U2F-Tester - FIDO/U2F Authentication Test Client
https://bugzilla.redhat.com/show_bug.cgi?id=1654667 Petr Pisar changed: What|Removed |Added CC||ppi...@redhat.com Depends On||1654664 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1654664 [Bug 1654664] Review Request: perl-Authen-U2F - Authen::U2F Perl module -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1654664] Review Request: perl-Authen-U2F - Authen::U2F Perl module
https://bugzilla.redhat.com/show_bug.cgi?id=1654664 Petr Pisar changed: What|Removed |Added Blocks||1654667 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1654667 [Bug 1654667] Review Request: perl-Authen-U2F-Tester - FIDO/U2F Authentication Test Client -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1733707] Review Request: multi-git-status - Show uncommitted, untracked and unpushed changes for multiple Git repos
https://bugzilla.redhat.com/show_bug.cgi?id=1733707 Björn 'besser82' Esser changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #5 from Björn 'besser82' Esser --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Expat License", "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/besser82/fedora/review/1733707-multi-git-status/licensecheck.txt ---> License is fine. Expat and MIT are identical licenses. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 71680 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. = EXTRA
[Bug 1709768] Review Request: anthy-unicode - Japanese character set input library for Unicode
https://bugzilla.redhat.com/show_bug.cgi?id=1709768 --- Comment #6 from fujiwara --- (In reply to Parag AN(पराग) from comment #4) > You are missing below lines in spec at respective sub-packages section > > Requires: emacs-filesystem >= %{_emacs_version} > Requires: xemacs-filesystem >= %{_xemacs_version} These lines are replaced with ?emacs(bin) >= %{_?emacs_version} -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1709768] Review Request: anthy-unicode - Japanese character set input library for Unicode
https://bugzilla.redhat.com/show_bug.cgi?id=1709768 --- Comment #5 from fujiwara --- Updated the SRPM Spec URL: https://fujiwara.fedorapeople.org/ibus/anthy-unicode/anthy-unicode.spec SRPM URL: https://fujiwara.fedorapeople.org/ibus/anthy-unicode/anthy-unicode-1.0.0.20190412-6.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1643764] Review Request: intelhex - A python library for manipulating Intel HEX file format
https://bugzilla.redhat.com/show_bug.cgi?id=1643764 --- Comment #11 from Peter Robinson --- (In reply to Raphael Groner from comment #10) > The package name should be python-intelhex to let the suffix emphasize it's > a python package. > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming > > ... See comment #6. but it has separate applications in it too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1643764] Review Request: intelhex - A python library for manipulating Intel HEX file format
https://bugzilla.redhat.com/show_bug.cgi?id=1643764 --- Comment #10 from Raphael Groner --- The package name should be python-intelhex to let the suffix emphasize it's a python package. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming ... See comment #6. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734161] Review Request: scitokens-cpp - C++ SciTokens Library
https://bugzilla.redhat.com/show_bug.cgi?id=1734161 --- Comment #2 from Antonio Trande --- %if 0%{?el6} scl enable devtoolset-8 do_build %else do_build %endif You are compiling with devtoolset-8 on EPEL6 only, not on EPEL7+. Is it what you want? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1734161] Review Request: scitokens-cpp - C++ SciTokens Library
https://bugzilla.redhat.com/show_bug.cgi?id=1734161 Antonio Trande changed: What|Removed |Added CC||anto.tra...@gmail.com Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1643764] Review Request: intelhex - A python library for manipulating Intel HEX file format
https://bugzilla.redhat.com/show_bug.cgi?id=1643764 --- Comment #9 from Peter Robinson --- SPEC: https://pbrobinson.fedorapeople.org/intelhex.spec SRPM: https://pbrobinson.fedorapeople.org/intelhex-2.2.1-2.fc30.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=36670270 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1731745] Review Request: properties-cpp - Simple convenience library for handling properties and signals in C++11Simple convenience library for handling properties and signals in C++11
https://bugzilla.redhat.com/show_bug.cgi?id=1731745 --- Comment #3 from david08...@gmail.com --- I should have used the C++ plugin, so here is that part: C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1731745] Review Request: properties-cpp - Simple convenience library for handling properties and signals in C++11Simple convenience library for handling properties and signals in C++11
https://bugzilla.redhat.com/show_bug.cgi?id=1731745 david08...@gmail.com changed: What|Removed |Added CC||david08...@gmail.com --- Comment #2 from david08...@gmail.com --- Note that this in an informal review: Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1730560 bytes in 209 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation Especially as the main library is really small, it would be nice to be able to only install the library - /usr/share/doc/properties-cpp - A package must own all directories that it creates. - https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries = MUST items = C/C++: [x]: Header files in -devel subpackage, if present. [!]: Header only library must not be noarch [!]: Header only library must provide -static subpackage Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GPL (v2 or later)", "GNU Lesser General Public License (v3)". 13 files have unknown license. Detailed output of licensecheck in /home/dave/rpmbuild/properties- cpp/1731745-properties-cpp/licensecheck.txt [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/doc/properties-cpp [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc/properties-cpp [-]: Package contains no bundled libraries without FPC exception. I think no FPC exception is required anymore, but this is anyway not the case [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translation