[Bug 1761338] Review Request: doublecmd - Cross platform open source file manager with two panels
https://bugzilla.redhat.com/show_bug.cgi?id=1761338 Vít Ondruch changed: What|Removed |Added CC||msz...@wp.pl Flags||needinfo?(msz...@wp.pl) --- Comment #17 from Vít Ondruch --- (In reply to Vasiliy Glazov from comment #15) > What if I add licensecheck file to package and comment about it to spec > instead list all files for all licenses? Not sure what is "licensecheck file", but typically it is enough to have list like: ~~~ # LGPL and GPL: components/CmdLine/* # GPLv2+: components/KASToolBar/* ~~~ So it should not be that long. (In reply to Vasiliy Glazov from comment #16) > Vit, if you want I will be happy to add you as comaintainer. Thx. Not sure if I will have the cycles, because my Copr repo is now mostly maintained by Marcin (szpak), he might be interested -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 Elliott Sales de Andrade changed: What|Removed |Added Blocks||1763145 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1763145 [Bug 1763145] Review Request: golang-bug-serial-1 - Cross-platform serial library for Golang -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763145] Review Request: golang-bug-serial-1 - Cross-platform serial library for Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1763145 Elliott Sales de Andrade changed: What|Removed |Added Blocks||1762951 Depends On||1763147 Summary|Review Request: |Review Request: |b'golang-bug-serial-1' -|golang-bug-serial-1 - |b'Cross-platform serial |Cross-platform serial |library for Golang' |library for Golang Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1762951 [Bug 1762951] tinygo-0.9.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=1763147 [Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] New: Review Request: b'golang-github-creack-goselect' - b'Select(2) implementation in Go'
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 Bug ID: 1763147 Summary: Review Request: b'golang-github-creack-goselect' - b'Select(2) implementation in Go' Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: quantum.anal...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://qulogic.fedorapeople.org//golang-github-creack-goselect.spec SRPM URL: https://qulogic.fedorapeople.org//golang-github-creack-goselect-0.1.0-1.fc30.src.rpm Description: b'\nSelect(2) implementation in Go.\n\n%gopkg' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] Review Request: b'golang-github-creack-goselect' - b'Select(2) implementation in Go'
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 --- Comment #1 from Elliott Sales de Andrade --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=38363525 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763145] New: Review Request: b'golang-bug-serial-1' - b'Cross-platform serial library for Golang'
https://bugzilla.redhat.com/show_bug.cgi?id=1763145 Bug ID: 1763145 Summary: Review Request: b'golang-bug-serial-1' - b'Cross-platform serial library for Golang' Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: quantum.anal...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://qulogic.fedorapeople.org//golang-bug-serial-1.spec SRPM URL: https://qulogic.fedorapeople.org//golang-bug-serial-1-0-0.1.20191018git5f7892a.fc30.src.rpm Description: b'\nA cross-platform serial library for Golang.\n\n%gopkg' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763128] Review Request: golang-github-google-slothfs - FUSE filesystem for light-weight, lazily-loaded, read-only Git
https://bugzilla.redhat.com/show_bug.cgi?id=1763128 Elliott Sales de Andrade changed: What|Removed |Added Blocks||1762838 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1762838 [Bug 1762838] git-lfs-2.9.0 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763128] Review Request: golang-github-google-slothfs - FUSE filesystem for light-weight, lazily-loaded, read-only Git
https://bugzilla.redhat.com/show_bug.cgi?id=1763128 Elliott Sales de Andrade changed: What|Removed |Added Summary|Review Request: |Review Request: |b'golang-github-google-slot |golang-github-google-slothf |hfs' - b'FUSE filesystem|s - FUSE filesystem for |for light-weight, |light-weight, |lazily-loaded, read-only|lazily-loaded, read-only |Git'|Git --- Comment #1 from Elliott Sales de Andrade --- koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=38363047 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763128] New: Review Request: b'golang-github-google-slothfs' - b'FUSE filesystem for light-weight, lazily-loaded, read-only Git'
https://bugzilla.redhat.com/show_bug.cgi?id=1763128 Bug ID: 1763128 Summary: Review Request: b'golang-github-google-slothfs' - b'FUSE filesystem for light-weight, lazily-loaded, read-only Git' Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: quantum.anal...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://qulogic.fedorapeople.org//golang-github-google-slothfs.spec SRPM URL: https://qulogic.fedorapeople.org//golang-github-google-slothfs-0-0.1.20191018git6b42407.fc30.src.rpm Description: b'\nSlothFS is a FUSE filesystem that provides light-weight, lazily downloaded,\nread-only checkouts of manifest-based Git projects. It is intended for use with\nAndroid.\n\n%gopkg' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1745517] Review Request: python27 - Version 2.7 of the Python interpreter
https://bugzilla.redhat.com/show_bug.cgi?id=1745517 Miro Hrončok changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2019-10-18 08:48:58 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1761338] Review Request: doublecmd - Cross platform open source file manager with two panels
https://bugzilla.redhat.com/show_bug.cgi?id=1761338 Vasiliy Glazov changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2019-10-18 08:45:40 --- Comment #16 from Vasiliy Glazov --- Review closed. All work now in https://src.fedoraproject.org/rpms/doublecmd Vit, if you want I will be happy to add you as comaintainer. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763045] Review Request: did - What did you do last week, month, year?
https://bugzilla.redhat.com/show_bug.cgi?id=1763045 --- Comment #4 from Miro Hrončok --- One more suggestion: Replace BuildRequires: git with BuildRequires: /usr/bin/git (or git-core) to save you some unneeded perl build dependencies. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763045] Review Request: did - What did you do last week, month, year?
https://bugzilla.redhat.com/show_bug.cgi?id=1763045
Miro Hrončok changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|mhron...@redhat.com
Flags||fedora-review?
--- Comment #3 from Miro Hrončok ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
Note: Package contains %{pythonX_site(lib|arch)}/* in %files
See: https://pagure.io/packaging-committee/issue/782
- In upstream, you have tests. You should run them in %check.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 3 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[-]: Binary eggs must be removed in %prep
[x]: Python eggs must not download any dependencies during the build
process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and
[Bug 1763045] Review Request: did - What did you do last week, month, year?
https://bugzilla.redhat.com/show_bug.cgi?id=1763045
Miro Hrončok changed:
What|Removed |Added
CC||mhron...@redhat.com
--- Comment #2 from Miro Hrončok ---
Spec file sane.
I'd recommend using %{url} in the Source url to make it shorter, but that is
optional.
I wonder why the hardcoded runtime requires, are the automatic requires
not working? Oh, there is no setup.py or pyproject.toml, no automatic
requires.
%{python3_sitelib}/* should not be used, use a amore specific
%{python3_sitelib}/did/ or %{python3_sitelib}/%{name}/ please.
Running automated checks.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1761338] Review Request: doublecmd - Cross platform open source file manager with two panels
https://bugzilla.redhat.com/show_bug.cgi?id=1761338 --- Comment #15 from Vasiliy Glazov --- What if I add licensecheck file to package and comment about it to spec instead list all files for all licenses? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
