[Bug 1765196] Review Request: python-aspy.yaml - Few extensions to pyyaml
https://bugzilla.redhat.com/show_bug.cgi?id=1765196 --- Comment #1 from Artem --- https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-31-x86_64/01080351-python-aspy.yaml/python-aspy.yaml.spec https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-31-x86_64/01080351-python-aspy.yaml/python-aspy.yaml-1.3.0-3.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765265] Review Request: python-identify - File identification library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1765265 --- Comment #1 from Artem --- https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-31-x86_64/01080346-python-identify/python-identify.spec https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-31-x86_64/01080346-python-identify/python-identify-1.4.7-2.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765263] Review Request: python-cfgv - Validate configuration and produce human readable error messages
https://bugzilla.redhat.com/show_bug.cgi?id=1765263 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #8 from Fedora Update System --- FEDORA-2019-a06f2a522c has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-a06f2a522c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765729] New: Review Request: gap-pkg-format - Formations of finite solvable groups
https://bugzilla.redhat.com/show_bug.cgi?id=1765729 Bug ID: 1765729 Summary: Review Request: gap-pkg-format - Formations of finite solvable groups Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: loganje...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jjames.fedorapeople.org/gap-pkg-format/gap-pkg-format.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-format/gap-pkg-format-1.4.2-1.fc32.src.rpm RPMLINTRC URL: https://jjames.fedorapeople.org/gap-pkg-format/gap-pkg-format.rpmlintrc Fedora Account System Username: jjames Description: The package contains programs for computing with formations of finite solvable groups and with various formation-theoretic subgroups. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1764271] Review Request: kitty - Cross-platform, fast, feature full, GPU based terminal emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1764271 --- Comment #19 from Fedora Update System --- kitty-0.14.6-12.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8fd0f6e877 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1764715] Review Request: python-django-health-check - Checks for various conditions and provides reports
https://bugzilla.redhat.com/show_bug.cgi?id=1764715
--- Comment #2 from Jerry James ---
No serious issues found, but I would like to offer a few comments.
1. Note that this line is not required:
Requires: python3-django
If you examine the Requires for the final binary package, you'll see:
python3-django
python3.8dist(django) >= 1.11
The first is due to the Requires line above. The second dependency is
already generated from setup.py, and is more specific than your version.
2. Note the macro-in-comment warnings from rpmlint. You should use double
percent signs, e.g., "%%check", so that rpm does not evaluate those macros.
3. The rpmlint warnings about objects.inv are, of course, wrong. You can make
rpmlint stop warning with a file named python-django-health-check.rpmlintrc
in the (not yet created) git repo containing something like the following:
addFilter(r'W: wrong-file-end-of-line-encoding .*objects.inv')
addFilter(r'W: file-not-utf8 .*objects.inv')
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package does not use a name that already exists.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[-]: Binary eggs must be removed in %prep
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager
[Bug 1764715] Review Request: python-django-health-check - Checks for various conditions and provides reports
https://bugzilla.redhat.com/show_bug.cgi?id=1764715 Jerry James changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Jerry James --- This package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759940] Review Request: htslib - C library for high-throughput sequencing data formats
https://bugzilla.redhat.com/show_bug.cgi?id=1759940
--- Comment #22 from John Marshall ---
> According to following document, so files in %files should not be listed by
> using a glob.
>
>> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files
>> Shared libraries installed directly into %{_libdir} SHOULD NOT be listed in
>> the %files section of the spec by using a glob in a way that conceals
>> important parts of the file name (e.g. libfoo.so*), since changes to the
>> SONAME also result in a changed file name in most cases.
These plugin files are not shared libraries, are not installed into libdir, do
not have SONAMEs, and the glob does not conceal parts that are important in the
way mentioned. So this paragraph does not apply. But you should do as you see
fit.
However there is a bug here. The htslib main package creates the
libexecdir/htslib directory so needs to package the directory itself so that it
will be deleted on uninstall. So what this really wants is
%files
%{_libexecdir}/%{name}
or equivalent.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1764715] Review Request: python-django-health-check - Checks for various conditions and provides reports
https://bugzilla.redhat.com/show_bug.cgi?id=1764715 Jerry James changed: What|Removed |Added Status|NEW |ASSIGNED CC||loganje...@gmail.com Assignee|nob...@fedoraproject.org|loganje...@gmail.com Flags||fedora-review? --- Comment #1 from Jerry James --- I will take this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765322] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1765322 --- Comment #4 from Felix Schwarz --- Thanks, Artem. I like your suggestions, will fix before import. (repo requested) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765727] New: Review Request: gap-pkg-circle - Adjoint groups of finite rings
https://bugzilla.redhat.com/show_bug.cgi?id=1765727 Bug ID: 1765727 Summary: Review Request: gap-pkg-circle - Adjoint groups of finite rings Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: loganje...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jjames.fedorapeople.org/gap-pkg-circle/gap-pkg-circle.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-circle/gap-pkg-circle-1.6.1-1.fc32.src.rpm RPMLINTRC URL: https://jjames.fedorapeople.org/gap-pkg-circle/gap-pkg-circle.rpmlintrc Fedora Account System Username: jjames Description: Let R be an associative ring, not necessarily with a unit element. The set of all elements of R forms a monoid with the neutral element 0 from R under the operation r*s = r + s + rs defined for all r,s from R. This operation is called 'circle multiplication'; it is also known as 'star multiplication'. The monoid of elements of R under circle multiplication is called the adjoint semigroup of R. The group of all invertible elements of this monoid is called the adjoint group of R. These notions naturally lead to a number of questions about the connection between a ring and its adjoint group, for example, how the ring properties will determine properties of the adjoint group; which groups can appear as adjoint groups of rings; which rings can have adjoint groups with prescribed properties, etc. The main objective of the GAP package 'Circle' is to extend GAP functionality for computations in adjoint groups of associative rings to make it possible to use the GAP system for the investigation of such questions. Circle provides functionality to construct circle objects that will respect circle multiplication r*s = r + s + rs, create multiplicative groups, generated by these objects, and compute groups of elements, invertible with respect to this operation, for finite radical algebras and finite associative rings without one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759940] Review Request: htslib - C library for high-throughput sequencing data formats
https://bugzilla.redhat.com/show_bug.cgi?id=1759940 --- Comment #23 from Fedora Update System --- htslib-1.9-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-36fd2ef2e1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765322] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1765322 --- Comment #7 from Felix Schwarz --- > One more thing: can we replace in this package Requires as dynamic requires? > %?python_enable_dependency_generator As far as I know this is enabled automatically for F30 (F29?) so I omitted it. Also I noticed upstream forgot to list a dependency so only tinycss2 is found automatically. I fixed the source url (I got the tarball from pypi) and also the egg-info wildcard. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765730] New: Review Request: gap-pkg-grpconst - Constructing groups of a given order
https://bugzilla.redhat.com/show_bug.cgi?id=1765730 Bug ID: 1765730 Summary: Review Request: gap-pkg-grpconst - Constructing groups of a given order Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: loganje...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jjames.fedorapeople.org/gap-pkg-grpconst/gap-pkg-grpconst.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-grpconst/gap-pkg-grpconst-2.6.1-1.fc32.src.rpm RPMLINTRC URL: https://jjames.fedorapeople.org/gap-pkg-grpconst/gap-pkg-grpconst.rpmlintrc Fedora Account System Username: jjames Description: This package contains GAP implementations of three different approaches to constructing up to isomorphism all groups of a given order. The FrattiniExtensionMethod constructs all soluble groups of a given order. On request it gives only those that are (or are not) nilpotent or supersolvable or that do (or do not) have normal Sylow subgroups for some given set of primes. The program's output may be expressed in a compact coded form, if desired. The CyclicSplitExtensionMethod constructs all (necessarily soluble) groups whose given orders are of the form p^n*q for different primes p and q and which have at least one normal Sylow subgroup. The method, which relies upon having available a list of all groups of order p^n, is often faster than the Frattini extension method for the groups to which it applies. The UpwardsExtensions method takes as its input a permutation group G and positive integer s and returns a list of permutation groups, one for each extension of G by a soluble group of order a divisor of s. Usually it is used for nonsoluble G only, since for soluble groups the above methods are more efficient. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765731] New: Review Request: gap-pkg-recog - Group recognition methods
https://bugzilla.redhat.com/show_bug.cgi?id=1765731 Bug ID: 1765731 Summary: Review Request: gap-pkg-recog - Group recognition methods Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: loganje...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jjames.fedorapeople.org/gap-pkg-recog/gap-pkg-recog.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-recog/gap-pkg-recog-1.3.2-1.fc32.src.rpm RPMLINTRC URL: https://jjames.fedorapeople.org/gap-pkg-recog/gap-pkg-recog.rpmlintrc Fedora Account System Username: jjames Description: This is a GAP package for group recognition. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765728] New: Review Request: gap-pkg-fining - Finite incidence geometry
https://bugzilla.redhat.com/show_bug.cgi?id=1765728 Bug ID: 1765728 Summary: Review Request: gap-pkg-fining - Finite incidence geometry Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: loganje...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jjames.fedorapeople.org/gap-pkg-fining/gap-pkg-fining.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-fining/gap-pkg-fining-1.4.1-1.fc32.src.rpm RPMLINTRC URL: https://jjames.fedorapeople.org/gap-pkg-fining/gap-pkg-fining.rpmlintrc Fedora Account System Username: jjames Description: This package provides functionality: - to create and explore finite incidence structures, such as finite projective spaces, finite classical polar spaces, generalized polygons, coset geometries, finite affine spaces, and many more; - to explore algebraic varieties in finite projective and finite affine spaces; - that deals with the automorphism groups of incidence structures, and functionality integrating these automorphism groups with the group theoretical capabilities of GAP; - to explore various morphisms between finite incidence structures. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1704917] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1704917 Felix Schwarz changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |DUPLICATE Last Closed||2019-10-25 19:50:03 --- Comment #14 from Felix Schwarz --- review request in bug 1765322 was approved therefore I'm closing this duplicate issue. @Eric: If you are interested ping me so I can add you as co-maintainer. *** This bug has been marked as a duplicate of bug 1765322 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765322] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1765322 Felix Schwarz changed: What|Removed |Added Blocks||1331947, 1475749 CC||space...@gmail.com --- Comment #6 from Felix Schwarz --- *** Bug 1704917 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1331947 [Bug 1331947] python-cairosvg-2.4.2 is available https://bugzilla.redhat.com/show_bug.cgi?id=1475749 [Bug 1475749] weasyprint 0.45 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765322] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1765322 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-cssselect2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759940] Review Request: htslib - C library for high-throughput sequencing data formats
https://bugzilla.redhat.com/show_bug.cgi?id=1759940 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #21 from Fedora Update System --- htslib-1.9-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-21ca0b0c3c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765263] Review Request: python-cfgv - Validate configuration and produce human readable error messages
https://bugzilla.redhat.com/show_bug.cgi?id=1765263 --- Comment #7 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-cfgv -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765322] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1765322
Artem changed:
What|Removed |Added
Status|NEW |POST
CC||ego.corda...@gmail.com
Assignee|nob...@fedoraproject.org|ego.corda...@gmail.com
QA Contact|extras...@fedoraproject.org |ego.corda...@gmail.com
Flags||fedora-review+
--- Comment #2 from Artem ---
Felix, LGTM to me. Just a few tiny things:
- Linter warned about sources hash sum and spec file differ in RHBZ and SRPM.
- The one new thing i learned just yesterday from @churchyard :)
%{python3_sitelib}/%{srcname}-%{version}-py?.?.egg-info/
to
%{python3_sitelib}/%{srcname}-%{version}-py%{python3_version}.egg-info/
Because:
> The ?.? glob would break with Python 3.10.
Please fix this minor issues before import.
---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Sources used to build the package match the upstream source, as provided
in the spec URL.
Note: Upstream MD5sum check error, diff is in /mnt/data-
linux/tmp/1765322-python-cssselect2/diff.txt
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 3-clause "New" or "Revised"
License", "*No copyright* BSD (unspecified)", "BSD (unspecified)". 23
files have unknown license. Detailed output of licensecheck in
/mnt/data-linux/tmp/1765322-python-cssselect2/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib/python3.8/site-
packages/cssselect2(C, Failed, locale,, to, defaulting, set),
/usr/lib/python3.8/site-packages/cssselect2-0.2.2-py3.8.egg-info(C,
Failed, locale,, to, defaulting, set), /usr/lib/python3.8/site-
packages/cssselect2/__pycache__(C, Failed, locale,, to, defaulting,
set), /usr/lib/python3.8/site-packages/cssselect2/tests(C, Failed,
locale,, to, defaulting, set), /usr/lib/python3.8/site-
packages/cssselect2/tests/__pycache__(C, Failed, locale,, to,
defaulting, set), /usr/share/doc/python3-cssselect2(C, Failed,
locale,, to, defaulting, set),
/usr/share/licenses/python3-cssselect2(C, Failed, locale,, to,
defaulting, set)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when
[Bug 1765322] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1765322 --- Comment #3 from Artem --- One more thing: can we replace in this package Requires as dynamic requires? %?python_enable_dependency_generator https://fedoraproject.org/wiki/Changes/EnablingPythonGenerators#How_To_Test -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1761011] Review Request: octave-brain2mesh - A fully automated high-quality brain tetrahedral mesh generation toolbox
https://bugzilla.redhat.com/show_bug.cgi?id=1761011 --- Comment #12 from Fedora Update System --- octave-brain2mesh-0.5-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765347] Review Request: python-pyhcl - HCL configuration parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1765347 --- Comment #5 from Fedora Update System --- python-hvac-0.9.5-1.el8, python-pyhcl-0.3.13-2.el8 has been pushed to the Fedora EPEL 8 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765350] Review Request: python-hvac - HashiCorp Vault API client
https://bugzilla.redhat.com/show_bug.cgi?id=1765350 --- Comment #7 from Fedora Update System --- python-hvac-0.9.5-1.el8, python-pyhcl-0.3.13-2.el8 has been pushed to the Fedora EPEL 8 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759206] Review Request: xpanes - Awesome tmux-based terminal divider
https://bugzilla.redhat.com/show_bug.cgi?id=1759206 --- Comment #12 from Fedora Update System --- xpanes-4.1.1-1.el8 has been pushed to the Fedora EPEL 8 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765263] Review Request: python-cfgv - Validate configuration and produce human readable error messages
https://bugzilla.redhat.com/show_bug.cgi?id=1765263 --- Comment #6 from Artem --- (In reply to Felix Schwarz from comment #5) > Upstream recommends https://github.com/asottile/cfgv/issues/23 ) that you use > the github tarball to get the tests. I'll fix this in next build before import. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765263] Review Request: python-cfgv - Validate configuration and produce human readable error messages
https://bugzilla.redhat.com/show_bug.cgi?id=1765263 Felix Schwarz changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Felix Schwarz --- package looks good to me, APPROVED. :-) Btw: I noticed that pypi's cfgv tarball does not contain tests - only github's release tarball has these. Upstream recommends ( https://github.com/asottile/cfgv/issues/23 ) that you use the github tarball to get the tests. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765263] Review Request: python-cfgv - Validate configuration and produce human readable error messages
https://bugzilla.redhat.com/show_bug.cgi?id=1765263 Artem changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #4 from Artem --- (In reply to Felix Schwarz from comment #2) > The package looks good but there is one important thing you must fix: > > Naming [Fedora Packaging Guidelines / Python] > > The source package for a Python library MUST be named with the python- > > prefix. > > A built package however must include the Python major version in the name, > > using > > the python3- prefix. This is accomplished by adding a subpackage. > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming Indeed! Thanks. Fixed this and few more tiny things. https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-31-x86_64/01080263-python-cfgv/python-cfgv.spec https://copr-be.cloud.fedoraproject.org/results/atim/python-packages/fedora-31-x86_64/01080263-python-cfgv/python-cfgv-2.0.1-2.fc31.src.rpm > I can review that? Would you be interested in reviewing an (equally simple) > Python package (bug 1765322)? Sure. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765350] Review Request: python-hvac - HashiCorp Vault API client
https://bugzilla.redhat.com/show_bug.cgi?id=1765350 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2019-10-25 17:01:58 --- Comment #6 from Fedora Update System --- python-hvac-0.9.5-1.fc30, python-pyhcl-0.3.13-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765347] Review Request: python-pyhcl - HCL configuration parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1765347 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2019-10-25 17:01:57 --- Comment #4 from Fedora Update System --- python-hvac-0.9.5-1.fc30, python-pyhcl-0.3.13-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765350] Review Request: python-hvac - HashiCorp Vault API client
https://bugzilla.redhat.com/show_bug.cgi?id=1765350 Bug 1765350 depends on bug 1765347, which changed state. Bug 1765347 Summary: Review Request: python-pyhcl - HCL configuration parser for Python https://bugzilla.redhat.com/show_bug.cgi?id=1765347 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1762203] Review Request: qimgv - Qt5 image viewer with optional video support
https://bugzilla.redhat.com/show_bug.cgi?id=1762203 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-10-25 17:01:07 --- Comment #16 from Fedora Update System --- qimgv-0.8.6-7.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1757256] Review Request: vim-airline - Lean & mean status/tabline for vim that's light as air
https://bugzilla.redhat.com/show_bug.cgi?id=1757256 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-10-25 17:00:25 --- Comment #16 from Fedora Update System --- vim-airline-0.10-5.20191011git297ca3d.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1751846] Review Request: python-neurodsp - Neurodsp is a package of tools to analyze and simulate neural time series
https://bugzilla.redhat.com/show_bug.cgi?id=1751846 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-10-25 17:00:16 --- Comment #14 from Fedora Update System --- python-neurodsp-2.0.0-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1761011] Review Request: octave-brain2mesh - A fully automated high-quality brain tetrahedral mesh generation toolbox
https://bugzilla.redhat.com/show_bug.cgi?id=1761011 Fedora Update System changed: What|Removed |Added Resolution|RAWHIDE |ERRATA --- Comment #11 from Fedora Update System --- octave-brain2mesh-0.5-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1751590] Review Request: bugzilla2fedmsg - Consume BZ messages over STOMP and republish to Fedora Messaging
https://bugzilla.redhat.com/show_bug.cgi?id=1751590
Adam Williamson changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #7 from Adam Williamson ---
OK, the other package is approved now, so reviewing this one (using my own
build of the stompest package to build this against):
[+]MUST: rpmlint must be run on the source rpm and all binary rpms the
build produces. The output should be posted in the review.
[adamw@adam Downloads]$ rpmlint ./bugzilla2fedmsg-1.0.0-1.fc30.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[adamw@adam Downloads]$ rpmlint
/var/lib/mock/fedora-31-x86_64/result/bugzilla2fedmsg-1.0.0-1.fc31.noarch.rpm
bugzilla2fedmsg.noarch: W: no-manual-page-for-binary bugzilla2fedmsg
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
So...arguably since the binary isn't really intended to be run by humans, it
should got /usr/libexec rather than /usr/bin . Per the FHS, /usr/bin is for
"user commands" while /usr/libexec is for "Binaries run by other programs". I'm
not going to block the review on this, though.
[+]MUST: The package must be named according to the Package Naming
Guidelines .
[+]MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[+]MUST: The package must meet the Packaging Guidelines .
[+]MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines .
[+]MUST: The License field in the package spec file must match the actual
license.
[+]MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %license.
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use sha256sum for this
task as it is used by the sources file once imported into git. If no upstream
URL can be specified for this package, please see the Source URL Guidelines for
how to deal with this.
[+]MUST: The package MUST successfully compile and build into binary rpms
on at least one primary architecture.
[NA] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+]MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[NA] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[NA] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
[+]MUST: Packages must NOT bundle copies of system libraries.
[NA] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+]MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+]MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[+]MUST: Permissions on files must be set properly. Executables should be
set with executable permissions, for example.
[+]MUST: Each package must consistently use macros.
[+]MUST: The package must contain code, or permissible content.
[NA] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[+]MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present.
[NA] MUST: Static libraries must be in a -static package.
[NA] MUST: Development files must be in a -devel package.
[NA] MUST: In the vast majority of cases, devel packages must require the
base package using a
[Bug 1751590] Review Request: bugzilla2fedmsg - Consume BZ messages over STOMP and republish to Fedora Messaging
https://bugzilla.redhat.com/show_bug.cgi?id=1751590 Adam Williamson changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1750777] Review Request: python-stompest - STOMP library for Python including a synchronous client
https://bugzilla.redhat.com/show_bug.cgi?id=1750777 Adam Williamson changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #12 from Adam Williamson --- OK, so with that let's call this approved! Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765591] New: Review Request: oval_graph - Tool for visualization of SCAP rule evaluation results
https://bugzilla.redhat.com/show_bug.cgi?id=1765591 Bug ID: 1765591 Summary: Review Request: oval_graph - Tool for visualization of SCAP rule evaluation results Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: jro...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://copr-be.cloud.fedoraproject.org/results/hony/OVAL-visualization-as-graph/fedora-30-x86_64/01080114-oval_graph/oval_graph.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/hony/OVAL-visualization-as-graph/fedora-30-x86_64/01080114-oval_graph/oval_graph-0.0.1-1.fc30.noarch.rpm Description: This project is creats a tool that displays the results of evaluating SCAP rules. In the form of a tree according to the OVAL standard. Using the arf-to-graph command, you can simply view the result of rule. Fedora Account System Username: hony -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1658153] Review Request: wdune - wdune (white_dune) is a graphical VRML97/X3D editor
https://bugzilla.redhat.com/show_bug.cgi?id=1658153 --- Comment #99 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/wdune -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1658153] Review Request: wdune - wdune (white_dune) is a graphical VRML97/X3D editor
https://bugzilla.redhat.com/show_bug.cgi?id=1658153 --- Comment #98 from J. Scheurich --- Spec URL: ftp://ftp.ourproject.org/pub/wdune/wdune.spec SRPM URL: ftp://ftp.ourproject.org/pub/wdune/wdune-1.522-3.fc31.src.rpm Description: wdune (white_dune) is a graphical VRML97/X3D editor, simple NURBS/Superformula 3D modeller, animation tool, and VRML97/X3DV commandline compiler in development. With white_dune you can create/change 3D objects and animate them (in a easy way if you choose the -4kids GUI). The result can be shown in any webgl enabled web browser or can be converted to the RIB format for movie creation. Fedora Account System Username: mufti11 Fixed opengl-examples subpackage. This application uses vcglib and OpenSubdiv, but also compiles without it. vcglib: https://bugzilla.redhat.com/show_bug.cgi?id=1677989 opensubdiv: https://bugzilla.redhat.com/show_bug.cgi?id=1762155 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1658153] Review Request: wdune - wdune (white_dune) is a graphical VRML97/X3D editor
https://bugzilla.redhat.com/show_bug.cgi?id=1658153 Jun Aruga changed: What|Removed |Added CC||jar...@redhat.com --- Comment #97 from Jun Aruga --- This ticket's fedora-review flag is already "+". So, I think next step is ``` $ fedpkg request-repo wdune 1658153 ``` See https://fedoraproject.org/wiki/Package_Review_Process > When your package pass the review, you should use the fedpkg tool to request > a git repository for it. ...snip... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 910891] Review Request: python-subprocess32 - Backport of subprocess module from Python 3.2 to Python 2.*
https://bugzilla.redhat.com/show_bug.cgi?id=910891 Dave Malcolm changed: What|Removed |Added Flags|needinfo?(dmalcolm@redhat.c | |om) | --- Comment #9 from Dave Malcolm --- (In reply to Dan Kenigsberg from comment #8) > Dave, would you be kind to build python-subprocess32 for EPEL7 ? I'm no longer able to maintain this package in Fedora (upstream GCC duties take all my time), but Looking at https://apps.fedoraproject.org/packages/python-subprocess32/builds/ it appears that this is now in EPEL 7. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1750777] Review Request: python-stompest - STOMP library for Python including a synchronous client
https://bugzilla.redhat.com/show_bug.cgi?id=1750777 --- Comment #11 from Aurelien Bompard --- Thanks, the LICENSE file is indeed in the snapshot, but it wasn't in the released tarballs. Updated. Spec URL: https://abompard.fedorapeople.org/reviews/python-stompest/python-stompest.spec SRPM URL: https://abompard.fedorapeople.org/reviews/python-stompest/python-stompest-2.3.0-1.20191018git715f358.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765263] Review Request: python-cfgv - Validate configuration and produce human readable error messages
https://bugzilla.redhat.com/show_bug.cgi?id=1765263 Felix Schwarz changed: What|Removed |Added Assignee|nob...@fedoraproject.org|fschw...@fedoraproject.org QA Contact|fschw...@fedoraproject.org |extras...@fedoraproject.org --- Comment #3 from Felix Schwarz --- fix assignee, reset QA contact -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765322] Review Request: python-cssselect2 - CSS selectors for Python ElementTree
https://bugzilla.redhat.com/show_bug.cgi?id=1765322 --- Comment #1 from Felix Schwarz --- copr build: https://copr.fedorainfracloud.org/coprs/fschwarz/python-cssselect2/build/1079276/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1765263] Review Request: python-cfgv - Validate configuration and produce human readable error messages
https://bugzilla.redhat.com/show_bug.cgi?id=1765263
--- Comment #2 from Felix Schwarz ---
The package looks good but there is one important thing you must fix:
Naming [Fedora Packaging Guidelines / Python]
> The source package for a Python library MUST be named with the python- prefix.
> A built package however must include the Python major version in the name,
> using
> the python3- prefix. This is accomplished by adding a subpackage.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[!]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Binary eggs must be removed in %prep
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[-]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms
[Bug 1765263] Review Request: python-cfgv - Validate configuration and produce human readable error messages
https://bugzilla.redhat.com/show_bug.cgi?id=1765263 Felix Schwarz changed: What|Removed |Added CC||fschw...@fedoraproject.org QA Contact|extras...@fedoraproject.org |fschw...@fedoraproject.org Flags||fedora-review? --- Comment #1 from Felix Schwarz --- I can review that? Would you be interested in reviewing an (equally simple) Python package (bug 1765322)? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
