[Bug 1767252] Review Request: transflac - transcode FLAC to lossy formats
https://bugzilla.redhat.com/show_bug.cgi?id=1767252 --- Comment #21 from Fedora Update System --- transflac-1.0.1-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-53639db3c3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1761614] Review Request: intel-mediasdk - Hardware-accelerated video processing on Intel integrated GPUs library
https://bugzilla.redhat.com/show_bug.cgi?id=1761614 Michael Cronenworth changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Michael Cronenworth --- Looks good. Let's get it in Fedora. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1761614] Review Request: intel-mediasdk - Hardware-accelerated video processing on Intel integrated GPUs library
https://bugzilla.redhat.com/show_bug.cgi?id=1761614 --- Comment #5 from Dominik 'Rathann' Mierzejewski --- Thanks for the review. Spec URL: https://rathann.fedorapeople.org/review/intel-mediasdk/intel-mediasdk.spec SRPM URL: https://rathann.fedorapeople.org/review/intel-mediasdk/intel-mediasdk-19.3.0-2.fc31.src.rpm * Sat Nov 09 2019 Dominik Mierzejewski 19.3.0-2 - Add missing Obsoletes: and Requires: - Add license text and docs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767187] Review Request: golang-github-direnv-dotenv - Go dotenv parsing library for direnv
https://bugzilla.redhat.com/show_bug.cgi?id=1767187 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- golang-github-direnv-dotenv-0-0.2.20191105git4cce6d1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-afd4e64207 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767252] Review Request: transflac - transcode FLAC to lossy formats
https://bugzilla.redhat.com/show_bug.cgi?id=1767252 --- Comment #20 from Fedora Update System --- transflac-1.0.1-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8e7a59437f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767252] Review Request: transflac - transcode FLAC to lossy formats
https://bugzilla.redhat.com/show_bug.cgi?id=1767252 --- Comment #19 from Fedora Update System --- transflac-1.0.1-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-9ebbf2f70e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767240] Review Request: podman-compose - Run docker-compose.yml using podman
https://bugzilla.redhat.com/show_bug.cgi?id=1767240 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System --- podman-compose-0.1.5-2.git20191107.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-f8612d712b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1757688] Review Request: ghc-config-ini - A library for simple INI-based configuration files
https://bugzilla.redhat.com/show_bug.cgi?id=1757688 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- ghc-config-ini-0.2.4.0-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-e82a8a24d2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1770496] Review Request: python-pandas-flavor - The easy way to write your own Pandas flavor
https://bugzilla.redhat.com/show_bug.cgi?id=1770496 Ankur Sinha (FranciscoD) changed: What|Removed |Added Blocks||1276941 (fedora-neuro), ||1731583 (python-pingouin) Whiteboard||Trivial Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug https://bugzilla.redhat.com/show_bug.cgi?id=1731583 [Bug 1731583] Review Request: python-pingouin - Statistical package for Python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1731583] Review Request: python-pingouin - Statistical package for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1731583 Ankur Sinha (FranciscoD) changed: What|Removed |Added Depends On||1770496 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1770496 [Bug 1770496] Review Request: python-pandas-flavor - The easy way to write your own Pandas flavor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1770496] New: Review Request: python-pandas-flavor - The easy way to write your own Pandas flavor
https://bugzilla.redhat.com/show_bug.cgi?id=1770496 Bug ID: 1770496 Summary: Review Request: python-pandas-flavor - The easy way to write your own Pandas flavor Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: sanjay.an...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ankursinha.fedorapeople.org/python-pandas-flavor/python-pandas-flavor.spec SRPM URL: https://ankursinha.fedorapeople.org/python-pandas-flavor/python-pandas-flavor-0.1.2-1.fc32.src.rpm Description: The easy way to write your own flavor of Pandas Pandas 0.23 added a (simple) API for registering accessors with Pandas objects. Pandas-flavor extends Pandas extension API by: - adding support for registering methods as well. - making each of these functions backwards compatible with older versions of Pandas. Fedora Account System Username: ankursinha -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767998] Review Request: mbpfan - A simple daemon to control fan speed on all MacBook/MacBook Pros
https://bugzilla.redhat.com/show_bug.cgi?id=1767998 --- Comment #5 from Andrew Gaul --- > > Also, you should run the tests > > (https://github.com/linux-on-mac/mbpfan#run-the-tests-optional) in %check > > section, if possible. > > The tests are optional and might fail if the fans are running too fast. > While installing from source, it is easy to understand to it's just a false > positive, a user using DNF won't and it'll print some scary errors. > > See https://github.com/linux-on-mac/mbpfan/issues/198 I co-maintain mbpfan and prefer not running the tests. Previously we recommended this when mbpfan worked in a more manual configuration way but we are moving towards automatically detecting everything and requiring no input from the user. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759354] Review Request: raceintospace - Race into Space game
https://bugzilla.redhat.com/show_bug.cgi?id=1759354 --- Comment #14 from Fedora Update System --- raceintospace-1.1.0-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1731583] Review Request: python-pingouin - Statistical package for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1731583 --- Comment #7 from Ankur Sinha (FranciscoD) --- The new version requires a package that's not in Fedora now: pandas-flavor :( Working on that now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1150441] Review Request: iv - InterViews graphical library
https://bugzilla.redhat.com/show_bug.cgi?id=1150441 Ankur Sinha (FranciscoD) changed: What|Removed |Added Blocks||1276941 (fedora-neuro) Summary|Review Request: iv - NEURON |Review Request: iv - |graphical interface |InterViews graphical ||library Whiteboard|NOTREADY| --- Comment #9 from Ankur Sinha (FranciscoD) --- Spec URL: https://ankursinha.fedorapeople.org/iv/iv.spec SRPM URL: https://ankursinha.fedorapeople.org/iv/iv-0-0.20191106git74f1207.fc32.src.rpm Description: The InterViews graphical library used by NEURON. FAS username: ankursinha Successful rawhide scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=38870876 This is now ready for review :D Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1762155] Review Request: opensubdiv - An Open-Source subdivision surface library
https://bugzilla.redhat.com/show_bug.cgi?id=1762155 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-11-09 21:20:44 --- Comment #18 from Fedora Update System --- YafaRay-3.3.0-25.20190819git0a182c1.fc31, alembic-1.7.12-1.fc31, blender-2.80-13.fc31, luxcorerender-2.2-6.fc31, opensubdiv-3.4.0-3.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1759354] Review Request: raceintospace - Race into Space game
https://bugzilla.redhat.com/show_bug.cgi?id=1759354 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-11-09 21:20:15 --- Comment #13 from Fedora Update System --- raceintospace-1.1.0-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1770147] Review Request: ntsclient - Golang NTS client
https://bugzilla.redhat.com/show_bug.cgi?id=1770147 --- Comment #2 from Stefan Midjich --- (In reply to Stefan Midjich from comment #1) > Requesting sponsor for this. Have introduced myself on the devel mailing > list and this is my first package submitted for review. My personal introduction on the lists: https://lists.fedoraproject.org/archives/search?mlist=devel%40lists.fedoraproject.org&q=Stefan+Midjich -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1770147] Review Request: ntsclient - Golang NTS client
https://bugzilla.redhat.com/show_bug.cgi?id=1770147 Stefan Midjich changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) --- Comment #1 from Stefan Midjich --- Requesting sponsor for this. Have introduced myself on the devel mailing list and this is my first package submitted for review. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1770278] Review Request: vimiv-qt - An image viewer with vim-like keybindings
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
--- Comment #6 from Ankur Sinha (FranciscoD) ---
- The package builds correctly on rawhide. Here's a scratch build, for example:
https://koji.fedoraproject.org/koji/taskinfo?taskID=38865749
- They aren't shared objects, they are compiled python libraries, so that
particular guidelines does not apply to them.
- The stuff in %{_datadir} are the icons, so it doesn't make sense to move them
to a subpackage.
- I removed the the documentation. We include the man page for the application,
and the docs are available online.
- I improved the description of the doc sub package to make it longer than the
summary.
The tests required pytest-bdd which is not yet in Fedora, so they can't be run
at the moment.
Spec/srpm updated in place.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767998] Review Request: mbpfan - A simple daemon to control fan speed on all MacBook/MacBook Pros
https://bugzilla.redhat.com/show_bug.cgi?id=1767998 --- Comment #4 from Lyes Saadi --- I've updated the spec file :)! And made a koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=38865485 ! I hope everything is good :D! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1677989] Review Request: vcglib Visualization and Computer Graphics Library
https://bugzilla.redhat.com/show_bug.cgi?id=1677989 Ankur Sinha (FranciscoD) changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1677989] Review Request: vcglib Visualization and Computer Graphics Library
https://bugzilla.redhat.com/show_bug.cgi?id=1677989 Ankur Sinha (FranciscoD) changed: What|Removed |Added CC||sanjay.an...@gmail.com Assignee|pemen...@redhat.com |sanjay.an...@gmail.com Flags|fedora-review+ |fedora-review? |needinfo?(space...@gmail.co | |m) | --- Comment #35 from Ankur Sinha (FranciscoD) --- Resetting flags -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767998] Review Request: mbpfan - A simple daemon to control fan speed on all MacBook/MacBook Pros
https://bugzilla.redhat.com/show_bug.cgi?id=1767998 --- Comment #3 from Lyes Saadi --- > It's a matter of preference, but I'd recommend putting each build dependency > in a separate line and sorting them alphabetically. > You can fold each mkdir+cp pair into install -Dp call to make it shorter, but > do at least use cp -p to preserve build-time timestamps. I'll do it. Thanks for the advice :D! > Please use %make_build macro unless you have a good reason not to. I don't > see Fedora-mandated compiler flags being used during build, so please try > adding %set_build_flags before calling make and if that doesn't help, you > might need to patch the Makefile. Yeah, just a little reason. The make file tries to install the systemd service in /lib instead of /usr/lib (it only creates the folder, though). So, I thought it was maybe better not to, especially that the program is pretty simple to install manually. If you think I should do otherwise, tell me, I was myself not sure if I should do it or not. > Also, you should run the tests > (https://github.com/linux-on-mac/mbpfan#run-the-tests-optional) in %check > section, if possible. The tests are optional and might fail if the fans are running too fast. While installing from source, it is easy to understand to it's just a false positive, a user using DNF won't and it'll print some scary errors. See https://github.com/linux-on-mac/mbpfan/issues/198 Thank you a lot for looking into my spec file :)! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767998] Review Request: mbpfan - A simple daemon to control fan speed on all MacBook/MacBook Pros
https://bugzilla.redhat.com/show_bug.cgi?id=1767998 --- Comment #2 from Dominik 'Rathann' Mierzejewski --- Also, you should run the tests (https://github.com/linux-on-mac/mbpfan#run-the-tests-optional) in %check section, if possible. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767998] Review Request: mbpfan - A simple daemon to control fan speed on all MacBook/MacBook Pros
https://bugzilla.redhat.com/show_bug.cgi?id=1767998 Dominik 'Rathann' Mierzejewski changed: What|Removed |Added CC||domi...@greysector.net --- Comment #1 from Dominik 'Rathann' Mierzejewski --- Some quick comments: https://gitlab.com/LyesSaadi/spec/blob/master/mbpfan/mbpfan.spec#L9 It's a matter of preference, but I'd recommend putting each build dependency in a separate line and sorting them alphabetically. https://gitlab.com/LyesSaadi/spec/blob/master/mbpfan/mbpfan.spec#L30 Please use %make_build macro unless you have a good reason not to. I don't see Fedora-mandated compiler flags being used during build, so please try adding %set_build_flags before calling make and if that doesn't help, you might need to patch the Makefile. https://gitlab.com/LyesSaadi/spec/blob/master/mbpfan/mbpfan.spec#L32 You can fold each mkdir+cp pair into install -Dp call to make it shorter, but do at least use cp -p to preserve build-time timestamps. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297 --- Comment #10 from Aniket Pradhan --- Thank you for the review, Elliot. I have made the requested changes and have updated the source files (spec and srpm) in the fedorapeople workspace. The links to the files are as follows: spec: https://major.fedorapeople.org/python-editdistance/python-editdistance.spec srpm: https://major.fedorapeople.org/python-editdistance/python-editdistance-0.5.3-1.fc31.src.rpm The links are the same as the ones posted above. I am although unsure why the difference in the URL is coming up. I have generated the srpm using `rpmbuild -bs python-editdistance.spec`. I don't think it should be any different from the one created during the build procedure. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763285] Review Request: libnma - NetworkManager GUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1763285
Matthew Krupcale changed:
What|Removed |Added
Flags||needinfo?(lkund...@v3.sk)
--- Comment #3 from Matthew Krupcale ---
A couple minor things I spotted after now building -gtk4 packages in rawhide
and a bit more discussion on some points from the last review, and then this
should be ready.
> No, libnma doesn't obsolete libnma-gtk
Okay, I suppose the network-manager-applet spec file libnm-gtk-devel package
description was incorrect then.
> I'll do that once the network-manager-applet package is updated and libnm-gtk
> is actually dropped.
It looks like libnm-gtk{,devel} was last built in F28, though. So is this not
already essentially dropped?
> No, it's the presence of %files section or lack thereof that decides whether
> a binary package is built. That is so by design.
I only meant that the subpackages should not be defined in addition to the
%files section being excluded. This was mainly just so it was clear for the
reader only looking at the %package's what was built when, consistent with the
%files. It's not a requirement as far as I can tell but only a suggestion.
> Yes. This needs to get fixed upstream first:
> https://gitlab.gnome.org/GNOME/libnma/merge_requests/5
I believe you should go ahead and update the License: field and comment in the
spec file (either around the License: field or in %files) about the shared/
license without having the COPYING.LGPL file included yet. In the next release
you can include the file (assuming it's accepted upstream), but the license
should still be correctly labeled.
> Yeah, it could be done, but it seems rather unnecessary to me at this point.
I think it is good practice for three reasons:
1. Being noarch, the package can be built and installed anywhere
2. Reduces the repository size since the docs subpackages are not duplicated
for each arch
3. Potentially reduces the download and install size for the user if docs are
optional
I don't believe this is a requirement, but I do think it's recommended,
considering the size (>1 MB) of the documentation here.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- mobile-broadband-provider-info only Required by -gtk4 but appears to be used
by libnma as well
- Spelling error in -gtk4-devel Summary: "exerimental" -> "experimental"
- License should be "GPLv2+ and LGPLv2+" due to contents in shared/
Should install COPYING.LGPLv2.1.
This should be documented in the spec file as well.
See:
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios
- -gtk4 and -gtk4-devel subpackages should only be defined when
%if %{with libnma_gtk4}
- Consider moving %{_datadir}/gtk-doc files to noarch -devel-doc subpackage
See:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation
= MUST items =
C/C++:
[-]: Provides: bundled(gnulib) in place as required.
Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obey
[Bug 1769091] Review Request: rust-chrono-tz - TimeZone implementations for rust-chrono from the IANA database
https://bugzilla.redhat.com/show_bug.cgi?id=1769091 Igor Gnatenko changed: What|Removed |Added Status|NEW |POST CC||i.gnatenko.br...@gmail.com Assignee|nob...@fedoraproject.org|i.gnatenko.br...@gmail.com Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769089] Review Request: rust-parse-zoneinfo - Parse zoneinfo files from the IANA database
https://bugzilla.redhat.com/show_bug.cgi?id=1769089 Igor Gnatenko changed: What|Removed |Added Status|NEW |POST CC||i.gnatenko.br...@gmail.com Assignee|nob...@fedoraproject.org|i.gnatenko.br...@gmail.com Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769073] Review Request: rust-i3ipc - Library for controlling i3-wm through its IPC interface
https://bugzilla.redhat.com/show_bug.cgi?id=1769073 Igor Gnatenko changed: What|Removed |Added CC||i.gnatenko.br...@gmail.com --- Comment #1 from Igor Gnatenko --- > # test result: FAILED$<2>. 6 passed; 13 failed; 0 ignored; 0 measured; 0 > filtered out Have you reported bug upstream? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769070] Review Request: rust-mailparse - Simple parser for MIME e-mail messages
https://bugzilla.redhat.com/show_bug.cgi?id=1769070 Igor Gnatenko changed: What|Removed |Added CC||i.gnatenko.br...@gmail.com --- Comment #1 from Igor Gnatenko --- > # FIXME: Upstream SPDX tag 0BSD not listed in Fedora's good licenses list. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769069] Review Request: rust-quoted_printable - Simple encoder/decoder for quoted-printable data
https://bugzilla.redhat.com/show_bug.cgi?id=1769069 Igor Gnatenko changed: What|Removed |Added CC||i.gnatenko.br...@gmail.com --- Comment #1 from Igor Gnatenko --- > # FIXME: Upstream SPDX tag 0BSD not listed in Fedora's good licenses list. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769067] Review Request: rust-charset - Thunderbird-compatible character encoding decoding for email
https://bugzilla.redhat.com/show_bug.cgi?id=1769067 Igor Gnatenko changed: What|Removed |Added Status|NEW |POST CC||i.gnatenko.br...@gmail.com Assignee|nob...@fedoraproject.org|i.gnatenko.br...@gmail.com Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1572826] Review Request: python-Pallets-Sphinx-Themes - Sphinx themes for Pallets and related projects
https://bugzilla.redhat.com/show_bug.cgi?id=1572826 --- Comment #13 from Thomas Moschny --- As you built packages for F30 and F31, could you please also submit bodhi updates (and also buildroot overrides) for F30 and F31? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1769297] Review Request: python-editdistance - Provides a fast implementation of the Levenshtein distance in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1769297
Elliott Sales de Andrade changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com
Flags||fedora-review?
--- Comment #9 from Elliott Sales de Andrade ---
Summary is too long; "in Python" is redundant since it's in the package name,
and you can drop "A ".
The description says C++ and Cython, but you don't BR python3-Cython, and
rebuild Cython sources, which is required:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_packages_using_cython
You must own %{python3_sitearch}/%{pypi_name} and
%{python3_sitearch}/%{pypi_name}/__pycache__
Make sure to update both spec and srpm.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Provides: bundled(gnulib) in place as required.
Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib64/python3.8/site-
packages/editdistance/__pycache__, /usr/lib64/python3.8/site-
packages/editdistance
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib64/python3.8/site-
packages/editdistance, /usr/lib64/python3.8/site-
packages/editdistance/__pycache__
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: P
[Bug 1723052] Review Request: python-geopy - A Python client for several popular geocoding web services
https://bugzilla.redhat.com/show_bug.cgi?id=1723052 --- Comment #7 from Fabian Affolter --- Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 Lubomir Rintel changed: What|Removed |Added Blocks||182235 (FE-Legal) --- Comment #4 from Lubomir Rintel --- Thanks for the response. (In reply to Elliott Sales de Andrade from comment #3) > That's only a recommendation of the FSF for GPL. It's not required to > annotate all source files, and just take a look at the instructions on the > sidebar for choose a license, for example: > https://choosealicense.com/licenses/mit/ > tldr legal: https://tldrlegal.com/license/mit-license "You must include the > license notice in all copies or substantial uses of the work." > or this SE answer: > https://opensource.stackexchange.com/questions/4534/how-to-apply-mit-license- > in-the-github-repo-for-fully-free-project "No, a license header is not > necessary, at least for MIT and the Unlicense. Some other licenses encourage > you to add such a header but that is not the case of these two." None of the above is what I'm talking about, or relevant at all. What is missing here is any indication by whoever owns the copyright that the LICENSE file that is shipped applies to the source files in the tarball. >> Please ask upstream to clarify this, preferrably by including a comment in >> the source files about how are they licensed. If this was unclear, please let me rephrase this: Upstream needs to clarify this somehow, because it's not clear at the moment. The best way to do this is to add a comment in the actual source files. If there's any reason upstream has to object this, they could do something else, such as adding a statement in the README file. There's might be a chance that "this software" in the MIT license text could be understood as referring to whatever is in the same directory or tarball, but I don't know whether that's universally understood and would prefer a clarification to guessing. I'm adding a FE-LEGAL blocker, to give the legal a chance to chime in about this, but I believe it would be much easier if you just asked upstream to clear up how is the software licensed. Also, one more nit here: 2.) Please add BuildRequires: go-rpm-macros You're using the macros from the package. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 --- Comment #6 from Kees de Jong --- (In reply to Elliott Sales de Andrade from comment #4) > The links you've used go to a GitHub webpage; they need to point directly to > the raw file. Use the Download button on GitHub to get it. > > In the Makefile, PREFIX is set using ?=, which means it should only be set > if undefined. So setting it on the command-line would override (or rather, > skip setting) the value from the file. But you'd need to override PREFIX for > both %build and %install to work. Perfect! Thanks for your help, it indeed works when the prefix is overridden in both stages. Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=38853301 Spec URL: https://raw.githubusercontent.com/AquaL1te/git-secrets/master/git-secrets.spec SRPM URL: https://github.com/AquaL1te/git-secrets/raw/master/git-secrets-1.3.0-1.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767918] Review Request: targetd - Revive package
https://bugzilla.redhat.com/show_bug.cgi?id=1767918 --- Comment #6 from Elliott Sales de Andrade --- The spec and the srpm don't match; make sure to update both of them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
