[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 Jens Petersen changed: What|Removed |Added Status|POST|MODIFIED Fixed In Version||hello-2.10-3.fc33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1812761] Review Request: imv - Image viewer for X11 and Wayland
https://bugzilla.redhat.com/show_bug.cgi?id=1812761 Fedora Update System changed: What|Removed |Added Resolution|RAWHIDE |ERRATA --- Comment #7 from Fedora Update System --- FEDORA-2020-6502b31d9c has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804529] Review Request: pam-cryptsetup - PAM module for updating LUKS-encrypted volumes
https://bugzilla.redhat.com/show_bug.cgi?id=1804529 --- Comment #9 from Michel Alexandre Salim --- Repo requested: https://pagure.io/releng/fedora-scm-requests/issue/24075 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804529] Review Request: pam-cryptsetup - PAM module for updating LUKS-encrypted volumes
https://bugzilla.redhat.com/show_bug.cgi?id=1804529 --- Comment #8 from Michel Alexandre Salim --- Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820391] New: Review Request: RediSearch - full-text search over Redis
https://bugzilla.redhat.com/show_bug.cgi?id=1820391 Bug ID: 1820391 Summary: Review Request: RediSearch - full-text search over Redis Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: nath...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://nathans.fedorapeople.org/RediSearch/RediSearch.spec SRPM URL: https://nathans.fedorapeople.org/RediSearch/RediSearch-1.2.2-1.fc31.src.rpm Description: RediSearch implements a search engine on top of Redis, providing three main features - full text search, secondary indexing and a suggestion (auto-completion) engine. It provides advanced search features like exact phrase matching and numeric filtering for text queries, that are not possible or efficient with traditional Redis search approaches. Fedora Account System Username: nathans -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1812855] Review Request: php-pecl-rpminfo - RPM information
https://bugzilla.redhat.com/show_bug.cgi?id=1812855 Neal Gompa changed: What|Removed |Added Flags||needinfo?(fedora@famillecol ||let.com) --- Comment #10 from Neal Gompa --- Can you please use the spec you posted for review for building the SRPM? fedora-review indicates there is significant difference (lots of SCLized stuff, etc.). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815272] Review Request: python-pytenable - Python library to interface with Tenable's products and applications
https://bugzilla.redhat.com/show_bug.cgi?id=1815272 --- Comment #2 from Fabian Affolter --- Thanks for the feedback. (In reply to Robert-André Mauchin from comment #1) > - Package is not installable: > > DEBUG util.py:621: Error: > DEBUG util.py:621: Problem: conflicting requests > DEBUG util.py:621:- nothing provides python3.8dist(ipaddress) >= 1.0.22 > needed by python3-pytenable-1.1.0-1.fc33.noarch > DEBUG util.py:623: (try to add '--skip-broken' to skip uninstallable > packages or '--nobest' to use not only best candidate packages) > > It's orphaned: https://src.fedoraproject.org/rpms/python-ipaddress It's not needed for Python 3. > - Remove this file: > > python-pytenable-doc.noarch: W: hidden-file-or-dir > /usr/share/doc/python-pytenable-doc/html/.nojekyll > python-pytenable-doc.noarch: E: zero-length > /usr/share/doc/python-pytenable-doc/html/.nojekyll File removed * Thu Apr 02 2020 Fabian Affolter - 1.1.1-1 - Remove configuration file for publishing - Remove standard library (rhbz#1815272) - Update to latest upstream release 1.1.1 Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-pytenable.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-pytenable-1.1.1-1.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1819228] Review Request: python-dateutils - Various utilities for working with date and datetime objects
https://bugzilla.redhat.com/show_bug.cgi?id=1819228 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #4 from Fedora Update System --- FEDORA-2020-6fbb97c620 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-6fbb97c620 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1786653] Review Request: androguard - Reverse engineering, mal- or goodware analysis of Android applications
https://bugzilla.redhat.com/show_bug.cgi?id=1786653 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/androguard -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803223] Review Request: golang-github-google-starlark - Starlark is a dialect of Python intended for use as a configuration language.
https://bugzilla.redhat.com/show_bug.cgi?id=1803223
--- Comment #10 from Alejandro ---
(In reply to Robert-André Mauchin from comment #9)
> - This shouldn't be necessary:
>
> %global commitdate 20190702
> %global shortcommit %(c=%{commit}; echo ${c:0:7})
>
>
> the gometa macro computes this automatically. *The date will be the date you
> upload to dist-git.*
>
> Package LGTM.
Got it. I updated the spec file:
Spec URL:
https://people.redhat.com/asaezmor/shared/golang-github-google-starlark/golang-github-google-starlark.spec
SRPM URL:
https://people.redhat.com/asaezmor/shared/golang-github-google-starlark/golang-starlark-0-0.1.20200330git32f3451.fc32.src.rpm
Thanks again for your comments.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1770946] Review Request: nodejs-pify - Promisify a callback-style function
https://bugzilla.redhat.com/show_bug.cgi?id=1770946 Jared Smith changed: What|Removed |Added Status|POST|MODIFIED --- Comment #2 from Jared Smith --- Repo requested at . -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1802370] Review Request: golang-github-francoispqt-gojay - Fastest JSON encoder/decoder with powerful stream API for Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1802370 Olivier Lemasle changed: What|Removed |Added Status|NEW |ASSIGNED CC||o.lema...@gmail.com Assignee|nob...@fedoraproject.org|o.lema...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1802362] Review Request: golang-github-viant-assertly - Arbitraty datastructure validation
https://bugzilla.redhat.com/show_bug.cgi?id=1802362 Olivier Lemasle changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #1 from Olivier Lemasle --- - The test failure (https://github.com/viant/assertly/issues/3) has been patched by the author (https://github.com/viant/assertly/commit/adf6a8c351198564771708e78169703c6c9cd021) so you should update the package to include the fix and restore "check". - Minor: there's a typo in description and summary: "arbitraty" (taken from GitHub project description) Otherwise ok, thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1796401] Review Request: python-requre - REQuest REcording your python code
https://bugzilla.redhat.com/show_bug.cgi?id=1796401 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #8 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1802360] Review Request: golang-github-viant-afs - Abstract File Storage
https://bugzilla.redhat.com/show_bug.cgi?id=1802360 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-viant-afs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1786653] Review Request: androguard - Reverse engineering, mal- or goodware analysis of Android applications
https://bugzilla.redhat.com/show_bug.cgi?id=1786653 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #3 from Robert-André Mauchin --- LGTM, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1801758] Review Request: golang-github-otiai10-copy - Golang copy directory recursively
https://bugzilla.redhat.com/show_bug.cgi?id=1801758 --- Comment #7 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-otiai10-copy -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1802360] Review Request: golang-github-viant-afs - Abstract File Storage
https://bugzilla.redhat.com/show_bug.cgi?id=1802360 --- Comment #5 from Robert-André Mauchin --- New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-viant-afs.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-viant-afs-0.16.1-1.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1801758] Review Request: golang-github-otiai10-copy - Golang copy directory recursively
https://bugzilla.redhat.com/show_bug.cgi?id=1801758 --- Comment #6 from Robert-André Mauchin --- New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-otiai10-copy.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-otiai10-copy-1.1.1-1.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1801758] Review Request: golang-github-otiai10-copy - Golang copy directory recursively
https://bugzilla.redhat.com/show_bug.cgi?id=1801758 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1801758] Review Request: golang-github-otiai10-copy - Golang copy directory recursively
https://bugzilla.redhat.com/show_bug.cgi?id=1801758 --- Comment #5 from Robert-André Mauchin --- Thanks for the review! I will update the SPEC as expected. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1802362] Review Request: golang-github-viant-assertly - Arbitraty datastructure validation
https://bugzilla.redhat.com/show_bug.cgi?id=1802362 Olivier Lemasle changed: What|Removed |Added CC||o.lema...@gmail.com Assignee|nob...@fedoraproject.org|o.lema...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1807753] Review Request: ydotool - Generic command-line automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1807753
--- Comment #11 from Artem ---
### Still recommended to do #3:
3. Add pushd/popd and & '%make_build -C %{_target_platform}' macros in %build
stage. This is important and Cmake warn even during build:
"this warning will become a fatal error in future CMake releases."
Code block:
```
%prep
%autosetup -n %{name}-%{commit}
mkdir -p %{_target_platform}
%build
pushd %{_target_platform}
%cmake ..
popd
%make_build -C %{_target_platform}
%install
%make_install -C %{_target_platform}
```
### And remove
%{_exec_prefix}/lib/systemd/
from %files section.
- Package does not contain duplicates in %files.
Note: warning: File listed twice: /usr/lib/systemd/system/ydotool.service
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_duplicate_files
### Also add zero in current date. Use 'rpmdev-bumpspec' for changelogs:
* Tue Apr 01 2020 Bob Hepple -
0.1.9-0.1.20200401git.9c3a4e7
W: incoherent-version-in-changelog 0.1.9-0.1.20200401git.9c3a4e7
['0.1.9-0.1.20200401.git.9c3a4e7.fc33', '0.1.9-0.1.20200401.git.9c3a4e7']
### And there was errors:
W: shared-lib-calls-exit /usr/lib64/libydotool.so.0.1.9 exit@GLIBC_2.2.5
E: postin-without-ldconfig /usr/lib64/libydotool.so.0.1.9
E: postun-without-ldconfig /usr/lib64/libydotool.so.0.1.9
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1819228] Review Request: python-dateutils - Various utilities for working with date and datetime objects
https://bugzilla.redhat.com/show_bug.cgi?id=1819228 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-dateutils -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 810049] Review Request: netbeans-ide - Netbeans Integrated Development Environment (IDE)
https://bugzilla.redhat.com/show_bug.cgi?id=810049 colinmunro changed: What|Removed |Added CC||colinmunro3...@gmail.com --- Comment #100 from colinmunro --- Get all the most recent data through http://www.itnewsoftechnology.com/ of IT segment which furnishes you the best arrangements with the correct data. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1809263] Review Request: wmbusmeters - Read the wireless mbus protocol to acquire utility meter readings
https://bugzilla.redhat.com/show_bug.cgi?id=1809263 --- Comment #14 from Fedora Update System --- FEDORA-2020-d3a031fbcf has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1809250] Review Request: python-sphobjinv - Sphinx objects.inv inspection/manipulation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1809250 --- Comment #7 from Fedora Update System --- FEDORA-2020-f725a47e7f has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1809537] Review Request: python-pytest-ordering - Plugin to run your pytest tests in a specific order
https://bugzilla.redhat.com/show_bug.cgi?id=1809537 --- Comment #12 from Fedora Update System --- FEDORA-2020-7b83f9153d has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1809263] Review Request: wmbusmeters - Read the wireless mbus protocol to acquire utility meter readings
https://bugzilla.redhat.com/show_bug.cgi?id=1809263 --- Comment #15 from Fedora Update System --- FEDORA-2020-462a2b0eba has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1809261] Review Request: fixedptc - Fixed point math header only library for C
https://bugzilla.redhat.com/show_bug.cgi?id=1809261 --- Comment #12 from Fedora Update System --- FEDORA-2020-7c40dbb62d has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808278] Review request: libevdevPlus - a c++ wrapper around libevdev
https://bugzilla.redhat.com/show_bug.cgi?id=1808278 --- Comment #16 from Fedora Update System --- FEDORA-2020-69b95e4c8f has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-69b95e4c8f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-69b95e4c8f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1813452] Review Request: python-pycoingecko - Python wrapper around the CoinGecko API
https://bugzilla.redhat.com/show_bug.cgi?id=1813452 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #4 from Fedora Update System --- FEDORA-2020-2ee8845d88 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-2ee8845d88 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1819148] Review Request: act - Automatic Component Toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=1819148
--- Comment #2 from Miro Hrončok ---
(In reply to Weiping from comment #1)
> Hi,
>
> this is an informal review:
Hello Weiping. Thanks for doing this.
> > Name: act
> > %global lname AutomaticComponentToolkit
> It's not recommended to use lname, please follow name guideline:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/
I don't understand. There is not a single mention of lname in that guidelines.
Nor it is said that it is not recommended.
The simple fact that it is not mentioned doesn't mean we should not do this.
> > %{?gometa}
> > %{?!gometa:BuildRequires: /usr/bin/go}
> Packages MUST have BuildRequires: go-rpm-macros.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/
> #_dependencies
On Fedora, %gometa adds that.
On EPEL 7, there is no go-rpm-macros :(
> > mkdir -p %{buildroot}%{_bindir}
> > install -m 0755 -vp act %{buildroot}%{_bindir}/
>
> Better to use these macors:
> install -m 0755 -vd %{buildroot}%{_bindir}
> install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/
> #_binary_package_installation
I found that overcomplicated and I don't have %{gobuilddir} on EPEL 7.
> Please add
> %global golicenses LICENSE.md
> %global godocs README.md
>
>
>
> There is an example, for simple binary package:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/
> #_simple_binary_package
It is, but since I don't have the devel subpackage, I think this would only
make the spec more complicated.
> fedora-review failed to build this package:
> + GO111MODULE=off
> + go build -buildmode pie -compiler gc '-tags=rpm_crashtraceback ' -ldflags
> ' -B 0x4b072daa5c63e7865a65639d9d94578a8d195116 -extldflags '\''-Wl,-z,relro
> -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld
> '\''' -a -v -x -o act Source/actutils.go Source/automaticcomponenttoolkit.go
> Source/buildbindingccpp.go Source/buildbindingcsharp.go
> Source/buildbindinggo.go Source/buildbindingnode.go
> Source/buildbindingpascal.go Source/buildbindingpython.go
> Source/buildimplementationcpp.go Source/buildimplementationpascal.go
> Source/componentdefinition.go Source/componentdiff.go Source/languagec.go
> Source/languagecpp.go Source/languagepascal.go Source/languagewriter.go
> WORK=/tmp/go-build362236170
> runtime: mlock of signal stack failed: 12
> runtime: increase the mlock limit (ulimit -l) or
> runtime: update your kernel to 5.3.15+, 5.4.2+, or 5.5+
> fatal error: mlock failed
> runtime stack:
> runtime.throw(0xa3b43e, 0xc)
> /usr/lib/golang/src/runtime/panic.go:1112 +0x72
I can build the package just fine, see the copr builds. How are you using
fedora-review?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1819968] Review Request: python-cppy - C++ headers for C extension development
https://bugzilla.redhat.com/show_bug.cgi?id=1819968
Fabian Affolter changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||m...@fabian-affolter.ch
Assignee|nob...@fedoraproject.org|m...@fabian-affolter.ch
Flags||fedora-review+
--- Comment #2 from Fabian Affolter ---
Just some minor issues. Please fix them before importing.
- Source0 can be replaced by "Source0:%{pypi_source}"
- I prefer "%{python3_sitelib}/%{srcname}/" to show that it is a directory (but
it's not necessary according the guidelines).
- Replace "%{python3_sitelib}/%{srcname}-%{version}-py?.?.egg-info" with
%{python3_sitelib}/%{srcname}%{python3_sitelib}/%{srcname}-%{version}-py*.egg-info
otherwise Python 3.10 is not covered
- rpmlint issues. Please fix those.
- python3-cppy.noarch: W: unexpanded-macro Provides
python%{__default_python3_pkgversion}-cppy = 1.1.0-1.fc33
%{__default_python3_pkgversion}
- python-cppy-doc.noarch: W: summary-not-capitalized C cppy documentation
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD 3-clause "New" or "Revised" License", "Unknown or
generated". 19 files have unknown license. Detailed output of
licensecheck in /home/fab/Documents/repos/reviews/1819968-python-
cppy/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[ ]: Python eggs must not download any dependencies during the build
process.
[ ]: A package which is used by another package via an egg interface should
provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 --- Comment #10 from Jens Petersen --- I requested unretirement to releng in https://pagure.io/releng/issue/9377 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1819228] Review Request: python-dateutils - Various utilities for working with date and datetime objects
https://bugzilla.redhat.com/show_bug.cgi?id=1819228 --- Comment #2 from Fabian Affolter --- Thanks for the review. The README file was included by upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810897] Review Request: hello - Prints a familiar, friendly greeting
https://bugzilla.redhat.com/show_bug.cgi?id=1810897 --- Comment #9 from Jens Petersen --- Spec URL: https://petersen.fedorapeople.org/reviews/hello/hello.spec SRPM URL: https://petersen.fedorapeople.org/reviews/hello/hello-2.10-3.fc32.src.rpm Thanks! I meant to post links too Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=42946656 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1809684] Review Request: git-repair - Repairs a damaged git repository
https://bugzilla.redhat.com/show_bug.cgi?id=1809684 --- Comment #6 from Fedora Update System --- FEDORA-2020-d853e0271e has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-d853e0271e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1812411] Review request: bookworm - simple, focused eBook reader
https://bugzilla.redhat.com/show_bug.cgi?id=1812411 --- Comment #10 from Fedora Update System --- FEDORA-2020-82243dd394 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-82243dd394 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
