[Bug 1827622] Review Request: python-tld - Python module to extract TLDs from URLs
https://bugzilla.redhat.com/show_bug.cgi?id=1827622 Fabian Affolter changed: What|Removed |Added CC||m...@fabian-affolter.ch --- Comment #3 from Fabian Affolter --- I would be more than happy to add you to the python-tld package. Especially as it's a dependency of one of your packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828205] Review Request: doctest - fast header-only C++ unit testing
https://bugzilla.redhat.com/show_bug.cgi?id=1828205 --- Comment #6 from Nick Black --- Actually, I see that /usr/lib is explicitly 32-bit, not "noarch". So I'm not sure how to proceed here. It almost makes me think this shouldn't actually be a noarch package? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823001] Review Request: simde - SIMD Everywhere
https://bugzilla.redhat.com/show_bug.cgi?id=1823001 --- Comment #24 from Fedora Update System --- FEDORA-EPEL-2020-129d21b52d has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828938] Review Request: rust-box_drawing - library for drawing boxes with UTF-8 characters
https://bugzilla.redhat.com/show_bug.cgi?id=1828938 Igor Gnatenko changed: What|Removed |Added CC||i.gnatenko.br...@gmail.com Assignee|nob...@fedoraproject.org|i.gnatenko.br...@gmail.com Doc Type|--- |If docs needed, set a value --- Comment #1 from Igor Gnatenko --- The %doc/%license are missing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1775443] Review Request: wlr-randr - An xrandr clone for wlroots compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1775443 --- Comment #23 from Fedora Update System --- FEDORA-2020-e4a845d02d has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-e4a845d02d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-e4a845d02d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804768] Review Request: catatonit - A signal-forwarding process manager for containers
https://bugzilla.redhat.com/show_bug.cgi?id=1804768 --- Comment #11 from Fedora Update System --- FEDORA-2020-9aeddd91c6 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-9aeddd91c6 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-9aeddd91c6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827427] Review Request: gnome-shell-extension-argos - Create GNOME Shell extensions in seconds
https://bugzilla.redhat.com/show_bug.cgi?id=1827427 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System --- FEDORA-2020-37cb00170f has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-37cb00170f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-37cb00170f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820891] Review Request: golang-github-chifflier-nfqueue - Go wrapper library for libnetfilter-queue
https://bugzilla.redhat.com/show_bug.cgi?id=1820891 --- Comment #12 from Fedora Update System --- FEDORA-2020-0e87ab1b08 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-0e87ab1b08 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-0e87ab1b08 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820849] Review Request: golang-github-malfunkt-iprange - IPv4 address parser for the nmap format
https://bugzilla.redhat.com/show_bug.cgi?id=1820849 --- Comment #7 from Fedora Update System --- FEDORA-2020-231e9aa60b has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-231e9aa60b \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-231e9aa60b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1775443] Review Request: wlr-randr - An xrandr clone for wlroots compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1775443 --- Comment #22 from Fedora Update System --- FEDORA-2020-eb7a6e160b has been pushed to the Fedora 30 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-eb7a6e160b \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-eb7a6e160b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828205] Review Request: doctest - fast header-only C++ unit testing
https://bugzilla.redhat.com/show_bug.cgi?id=1828205 --- Comment #5 from Nick Black --- OK, I've verified that if I install the CMake config files into /usr/lib/cmake (which did not exist on my system before, and my package would need create), cmake as installed picks it up, and things can build against doctest successfully. So I just need to figure out how to pass /usr/lib/ down into CMake using the cmake macro, and they ought get installed to /usr/lib/cmake, eliminating the error noarch-with-lib64. I'm not sure what to do about only-non-binary-in-usr-lib. The following paths get searched by CMake by default: /(lib/|lib*|share)/cmake/*/ /(lib/|lib*|share)/*/ /(lib/|lib*|share)/*/(cmake|CMake)/ /*/(lib/|lib*|share)/cmake/*/ /*/(lib/|lib*|share)/*/ /*/(lib/|lib*|share)/*/(cmake|CMake)/ so it doesn't seem like I'm getting out of /usr/lib easily. :/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1775443] Review Request: wlr-randr - An xrandr clone for wlroots compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1775443 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #21 from Fedora Update System --- FEDORA-2020-abe15ce02e has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-abe15ce02e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-abe15ce02e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804768] Review Request: catatonit - A signal-forwarding process manager for containers
https://bugzilla.redhat.com/show_bug.cgi?id=1804768 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- FEDORA-2020-f8f80a3c1c has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-f8f80a3c1c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f8f80a3c1c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820849] Review Request: golang-github-malfunkt-iprange - IPv4 address parser for the nmap format
https://bugzilla.redhat.com/show_bug.cgi?id=1820849 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- FEDORA-2020-425abec16a has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-425abec16a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-425abec16a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826034] Review Request: cubeb - A cross platform audio library
https://bugzilla.redhat.com/show_bug.cgi?id=1826034 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System --- FEDORA-2020-f7fb71a093 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-f7fb71a093 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f7fb71a093 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820842] Review Request: golang-github-kr-binarydist - Go implementation of the bspatch algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1820842 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System --- FEDORA-2020-e9ccbd0de1 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-e9ccbd0de1 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-e9ccbd0de1 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820891] Review Request: golang-github-chifflier-nfqueue - Go wrapper library for libnetfilter-queue
https://bugzilla.redhat.com/show_bug.cgi?id=1820891 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- FEDORA-2020-2297d64f93 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-2297d64f93 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-2297d64f93 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828205] Review Request: doctest - fast header-only C++ unit testing
https://bugzilla.redhat.com/show_bug.cgi?id=1828205 --- Comment #4 from Nick Black --- That ought have read "1 error, 1 warning", sorry -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828205] Review Request: doctest - fast header-only C++ unit testing
https://bugzilla.redhat.com/show_bug.cgi?id=1828205 Nick Black changed: What|Removed |Added Flags|needinfo?(d...@qemfd.net) | --- Comment #3 from Nick Black --- * rename to doctest-devel: done * noarch: done * drop global: done * drop doc enumeration: done * drop docdir: done * changelog: added Verified specfile with `spectool -g` Built SRPM with `rpmbuild -bs doctest.spec` Built noarch RPM with `mock -r fedora-rawhide-x srcrpm` I get four rpmlint results, 1 an error, 3 warnings: * E: noarch-with-lib64 (cmake files) * only-non-binary-in-usr-lib I don't see a place to install CMake files outside of /usr/lib64, but I'm digging into the documentation, and might have a natural fix for that shortly. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826326] Review Request: gnome-shell-extension-bubblemail - GNOME Shell indicator for new and unread mail using Bubblemail
https://bugzilla.redhat.com/show_bug.cgi?id=1826326 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-04-30 03:42:45 --- Comment #15 from Fedora Update System --- FEDORA-2020-394123e1f0 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822971] Review Request: notcurses - character graphics and TUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1822971
--- Comment #39 from Nick Black ---
Wait are you not seeing the blank lines in the spec file? I totally do:
[schwarzgerat](0) $ tail tools/*spec
%attr(0755, -, -) %{python3_sitearch}/notcurses/notcurses.py
%{python3_sitearch}/*.so
%changelog
* Sat Apr 25 2020 Nick Black - 1.3.3-1
- New upstream version, incorporate review feedback
- Build against OpenImageIO, install notcurses-view and data.
* Tue Apr 07 2020 Nick Black - 1.3.3-1
- Initial Fedora packaging
[schwarzgerat](0) $
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1819180] Review Request: ssh-chat - custom ssh server which serves a chat room instead of a shell
https://bugzilla.redhat.com/show_bug.cgi?id=1819180 --- Comment #11 from Petr Menšík --- Also, do not remove anything from postun. If keyfile would be declared %config and owned by package, at least as %ghost file, it would be removed by rpm. Such cleanup is dangerous and should not be used like this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1819180] Review Request: ssh-chat - custom ssh server which serves a chat room instead of a shell
https://bugzilla.redhat.com/show_bug.cgi?id=1819180
Petr Menšík changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||pemen...@redhat.com
Assignee|nob...@fedoraproject.org|pemen...@redhat.com
--- Comment #10 from Petr Menšík ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- systemd_post is invoked in %post, systemd_preun in %preun, and
systemd_postun in %postun for Systemd service files.
Note: Systemd service file(s) in ssh-chat
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Scriptlets/#_scriptlets
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated", "Expat
License", "BSD 3-clause "New" or "Revised" License". 83 files have
unknown license. Detailed output of licensecheck in
/home/reviewer/fedora/rawhide/1819180-ssh-chat/licensecheck.txt
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/systemd/system,
/usr/lib/systemd
[x]: %build honors applicable compiler flags or justifies otherwise.
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[?]: Macros in Summary, %description expandable at SRPM build time.
Note: Macros in: ssh-chat (description)
is %gopkg on correct place?
[-]: Package contains desktop file if it is a GUI application.
[!]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[!]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[x]: SourceX tarball generation or download is documented.
Note: Package contains tarball
[Bug 1828938] Review Request: rust-box_drawing - library for drawing boxes with UTF-8 characters
https://bugzilla.redhat.com/show_bug.cgi?id=1828938 Josh Stone changed: What|Removed |Added Blocks||1829539 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1829539 [Bug 1829539] Review Request: git-delta - Improved diff for git -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829539] Review Request: git-delta - Improved diff for git
https://bugzilla.redhat.com/show_bug.cgi?id=1829539 Josh Stone changed: What|Removed |Added CC||jist...@redhat.com Depends On||1828938 Doc Type|--- |If docs needed, set a value --- Comment #2 from Josh Stone --- (In reply to Carson Black from comment #1) > (Not sure where the Blocks field went, I don't see it.) There's a button on the right to show/hide advanced fields. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1828938 [Bug 1828938] Review Request: rust-box_drawing - library for drawing boxes with UTF-8 characters -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828813] Review Request: bashtop - Resource monitor written in bash that shows usage and stats for processor, memory, disks, network and processes
https://bugzilla.redhat.com/show_bug.cgi?id=1828813 --- Comment #10 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/bashtop -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828813] Review Request: bashtop - Resource monitor written in bash that shows usage and stats for processor, memory, disks, network and processes
https://bugzilla.redhat.com/show_bug.cgi?id=1828813 --- Comment #9 from Alessio --- (In reply to Artem from comment #8) > rpmlint says that packages requires only '/usr/bin/bash' so probably safe to > add there this packages explicitly. Also zram for example package: > https://src.fedoraproject.org/rpms/zram/blob/master/f/zram.spec#_18 Like there I also added %build # None required > Also, please, replace awk with gawk as i mentioned there > https://bugzilla.redhat.com/show_bug.cgi?id=1828813#c5 Whoops, you are right > Here is why this recommended to do: > https://bugzilla.redhat.com/show_bug.cgi?id=1694366#c14 Thanks. > This is cosmetic, but usually maintainers doing like this: > > %doc README.md > %doc CHANGELOG.md > -> > %doc README.md CHANGELOG.md Done. > Please fix this minor issues before import. Package approved. Thank you very much. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828813] Review Request: bashtop - Resource monitor written in bash that shows usage and stats for processor, memory, disks, network and processes
https://bugzilla.redhat.com/show_bug.cgi?id=1828813
Artem changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #8 from Artem ---
> Yes, I thought to include these lines. But just to learn, since they are
> "core" packages, i.e. they are provided with a default Fedora workstation
> installation, and they cannot be removed without removing critical or
> protected packages (ie. systemd, sudo, etc.) isn't "redundant" to put a
> Requires directive?
rpmlint says that packages requires only '/usr/bin/bash' so probably safe to
add there this packages explicitly. Also zram for example package:
https://src.fedoraproject.org/rpms/zram/blob/master/f/zram.spec#_18
Also, please, replace awk with gawk as i mentioned there
https://bugzilla.redhat.com/show_bug.cgi?id=1828813#c5
---
%{_datadir}/%{name}
->
%{_datadir}/%{name}/
Here is why this recommended to do:
https://bugzilla.redhat.com/show_bug.cgi?id=1694366#c14
---
This is cosmetic, but usually maintainers doing like this:
%doc README.md
%doc CHANGELOG.md
->
%doc README.md CHANGELOG.md
---
Please fix this minor issues before import. Package approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822971] Review Request: notcurses - character graphics and TUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1822971 David Cantrell changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822971] Review Request: notcurses - character graphics and TUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1822971 --- Comment #38 from David Cantrell --- Everything looks good. My only suggestion is to put a blank line between %changelog entries in the spec file, so it would look like: %changelog * Sat Apr 25 2020 Nick Black - 1.3.3-1 - New upstream version, incorporate review feedback - Build against OpenImageIO, install notcurses-view and data. * Tue Apr 07 2020 Nick Black - 1.3.3-1 - Initial Fedora packaging But that's only for readability in the spec file. RPM breaks all that out and stores it in the header differently so when you do "rpm -q --changelog" it's generating that output and not just dumping a text file. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822971] Review Request: notcurses - character graphics and TUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1822971 --- Comment #37 from David Cantrell --- Let's make this the last one... (In reply to David Cantrell from comment #36) > [ ]: Package does not contain kernel modules. It does not. > [ ]: Package contains no static executables. It does not. > [ ]: Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files in private %_libdir subdirectory (see > attachment). Verify they are not in ld path. They are. > [ ]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. Yes, Apache License 2.0 > [ ]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Unknown or generated", "Apache License (v2.0)", "*No > copyright* Apache License (v2.0)". 218 files have unknown license. > Detailed output of licensecheck in > /home/dcantrell/notcurses/licensecheck.txt Yep, ASL 2.0 which is how Fedora spells "Apache License 2.0". > [ ]: License file installed when any subpackage combination is installed. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Unknown or generated", "Apache License (v2.0)", "*No > copyright* Apache License (v2.0)". 218 files have unknown license. > Detailed output of licensecheck in > /home/dcantrell/notcurses/licensecheck.txt Yes. > [ ]: License file installed when any subpackage combination is installed. Yes. > [ ]: %build honors applicable compiler flags or justifies otherwise. Yes. > [ ]: Package contains no bundled libraries without FPC exception. It does not. > [ ]: Changelog in prescribed format. Yes. rpm does not complain. > [ ]: Sources contain only permissible code or content. Correct, using the DFSG source release. > [ ]: Package contains desktop file if it is a GUI application. It is not a desktop application. > [ ]: Development files must be in a -devel package They are. > [ ]: Package uses nothing in %doc for runtime. It does not. > [ ]: Package consistently uses macros (instead of hard-coded directory > names). Yes. > [ ]: Package is named according to the Package Naming Guidelines. It is. > [ ]: Package does not generate any conflict. Nope. > [ ]: Package obeys FHS, except libexecdir and /usr/target. It does. > [ ]: If the package is a rename of another package, proper Obsoletes and > Provides are present. N/A > [ ]: Requires correct, justified where necessary. Yes. > [ ]: Spec file is legible and written in American English. Yes. > [ ]: Package contains systemd file(s) if in need. N/A > [ ]: Useful -debuginfo package or justification otherwise. Yes. > [ ]: Package is not known to require an ExcludeArch tag. N/A > [ ]: Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 143360 bytes in 4 files. Not needed here. > [ ]: Package complies to the Packaging Guidelines Again, this is what I'm doing. > [ ]: Python eggs must not download any dependencies during the build > process. It does not. > [ ]: A package which is used by another package via an egg interface should > provide egg info. It does. > [ ]: Package meets the Packaging Guidelines::Python Yes, very much so. > [ ]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. It includes the license. > [ ]: Final provides and requires are sane (see attachments). Yes. > [ ]: Package functions as described. Yes. > [ ]: Latest version is packaged. Yes. > [ ]: Package does not include license text files separate from upstream. It does not. > [ ]: Description and summary sections in the package spec file contains > translations for supported Non-English languages, if available. N/A > [ ]: Package should compile and build into binary rpms on all supported > architectures. It does. > [ ]: %check is present and all tests pass. N/A until doctest passes package review. > [ ]: Packages should try to preserve timestamps of original installed > files. It does. But really, what is time? > [ ]: Large data in /usr/share should live in a noarch subpackage if package > is arched. > Note: Arch-ed rpms have a total of 4044800 bytes in /usr/share We're ok with this. > notcurses.x86_64: W: shared-lib-calls-exit /usr/lib64/libnotcurses.so.1.3.3 > exit@GLIBC_2.2.5 This is ok per comment #34 and comment #35. > notcurses-static.x86_64: W: no-documentation notcurses-static requires the main package which brings in documentation. > notcurses-utils-debuginfo.x86_64: W: invalid-url URL: > https://nick-black.com/dankwiki/index.php/Notcurses -2] Name or service not known> >
[Bug 1822971] Review Request: notcurses - character graphics and TUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1822971
--- Comment #36 from David Cantrell ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package does not contain duplicates in %files.
Note: warning: File listed twice: /usr/lib64/python3.8/site-
packages/notcurses/notcurses.py
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_duplicate_files
= MUST items =
C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Apache License (v2.0)", "*No
copyright* Apache License (v2.0)". 218 files have unknown license.
Detailed output of licensecheck in
/home/dcantrell/notcurses/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Apache License (v2.0)", "*No
copyright* Apache License (v2.0)". 218 files have unknown license.
Detailed output of licensecheck in
/home/dcantrell/notcurses/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 143360 bytes in 4 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: Static libraries in -static or -devel subpackage, providing -devel if
present.
Note: Package has .a files: notcurses-static.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under
[Bug 1827427] Review Request: gnome-shell-extension-argos - Create GNOME Shell extensions in seconds
https://bugzilla.redhat.com/show_bug.cgi?id=1827427 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED --- Comment #12 from Fedora Update System --- FEDORA-2020-37cb00170f has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-37cb00170f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828813] Review Request: bashtop - Resource monitor written in bash that shows usage and stats for processor, memory, disks, network and processes
https://bugzilla.redhat.com/show_bug.cgi?id=1828813 --- Comment #7 from Alessio --- New files. Spec URL: https://alciregi.fedorapeople.org/bashtop/bashtop.spec SRPM URL: https://alciregi.fedorapeople.org/bashtop/bashtop-0.8.16-1.fc32.src.rpm Thank you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828813] Review Request: bashtop - Resource monitor written in bash that shows usage and stats for processor, memory, disks, network and processes
https://bugzilla.redhat.com/show_bug.cgi?id=1828813 --- Comment #6 from Alessio --- (In reply to Artem from comment #4) > Requires: awk > Requires: coreutils > Requires: grep > Requires: procps-ng > Requires: sed > > Also need here. Yes, I thought to include these lines. But just to learn, since they are "core" packages, i.e. they are provided with a default Fedora workstation installation, and they cannot be removed without removing critical or protected packages (ie. systemd, sudo, etc.) isn't "redundant" to put a Requires directive? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824848] Review Request: jc - JSONifies the output of dozens of commands
https://bugzilla.redhat.com/show_bug.cgi?id=1824848 --- Comment #4 from Kelly Brazil --- This is very helpful, thank you! I'll dig into this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1529024] Review Request: python-tld - Extract the top level domain from the URL given
https://bugzilla.redhat.com/show_bug.cgi?id=1529024 Artur Iwicki changed: What|Removed |Added Blocks||1827587 CC||fed...@svgames.pl --- Comment #6 from Artur Iwicki --- *** Bug 1827622 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1827587 [Bug 1827587] dnstwist 20200429 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827622] Review Request: python-tld - Python module to extract TLDs from URLs
https://bugzilla.redhat.com/show_bug.cgi?id=1827622 Artur Iwicki changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed||2020-04-29 19:09:22 --- Comment #2 from Artur Iwicki --- Closing this since the package is already present in Fedora: https://src.fedoraproject.org/rpms/python-tld Funny thing is, I checked before packaging this myself. I guess I mistyped the URL and that's why pagure gave me a "404 repo not found". *** This bug has been marked as a duplicate of bug 1529024 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824848] Review Request: jc - JSONifies the output of dozens of commands
https://bugzilla.redhat.com/show_bug.cgi?id=1824848 --- Comment #3 from Artur Iwicki --- I'm far from a guru when it comes to packaging Python stuff in Fedora, but a lot of the questions you ask have been thought out throughout the years and put in the Python packaging guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ That said, if the package is pure Python (i.e. not a Python module written in C or whatever else), then packaging is quite straightforward. You can take a look at some of the python-SomeThing packages already present in Fedora: https://src.fedoraproject.org/rpms/python-whois/raw/master/f/python-whois.spec https://src.fedoraproject.org/rpms/python-rcssmin/raw/master/f/python-rcssmin.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825419] Review Request: rust-standback - New standard library, old compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1825419 Josh Stone changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-04-29 18:37:27 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1775443] Review Request: wlr-randr - An xrandr clone for wlroots compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1775443 --- Comment #20 from Fedora Update System --- FEDORA-2020-abe15ce02e has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-abe15ce02e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1775443] Review Request: wlr-randr - An xrandr clone for wlroots compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1775443 --- Comment #19 from Fedora Update System --- FEDORA-2020-eb7a6e160b has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2020-eb7a6e160b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1775443] Review Request: wlr-randr - An xrandr clone for wlroots compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1775443 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #18 from Fedora Update System --- FEDORA-2020-e4a845d02d has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-e4a845d02d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829539] Review Request: git-delta - Improved diff for git
https://bugzilla.redhat.com/show_bug.cgi?id=1829539 --- Comment #1 from Carson Black --- This package depends on https://bugzilla.redhat.com/show_bug.cgi?id=1828938 to build. (Not sure where the Blocks field went, I don't see it.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824848] Review Request: jc - JSONifies the output of dozens of commands
https://bugzilla.redhat.com/show_bug.cgi?id=1824848 --- Comment #2 from Kelly Brazil --- Ah, I see. I can provide a spec, but I think the challenge will be with a SRPM. Since this is a python3 app, typically users use pip to install it and the source-code is freely available on pypi.org and github. For a python app, can I just create an SRPM that includes the tgz distribution file that I build for pypi? Then I would expect the user to run pip to install it manually. I'm not keen on recreating pip's functionality within a SRPM, so I'm trying to find the best practice here. The examples I have seen for python apps don't seem to fit the modern way of distribution - requiring manual creation of a wrapper script to execute the application. This should be handled by pip. Should I just add `BuildRequires python3 and python3-wheel` to the spec so pip is available and can 'install' the python source? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829539] New: Review Request: git-delta - Improved diff for git
https://bugzilla.redhat.com/show_bug.cgi?id=1829539 Bug ID: 1829539 Summary: Review Request: git-delta - Improved diff for git Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: uhh...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://filebin.ca/5KoqvTzvmSp7/rust-git-delta.spec SRPM URL: https://filebin.ca/5KorMe6O4XWU/rust-git-delta-0.1.1-1.fc32.src.rpm Description: A syntax-highlighter for git and diff output Fedora Account System Username: appadeia -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824156] Review Request: exfatprogs - Userspace utilities for exFAT filesystems
https://bugzilla.redhat.com/show_bug.cgi?id=1824156 --- Comment #16 from Simone Caronni --- (In reply to Eric Sandeen from comment #15) > I have no strong preferences or opinions re: > conflicts/provides/obsoletes/whatever, that's not my strong point at all. > So please don't take anything I said there as an imperative. Absolutely, no worries. Any input is valuable! Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829523] New: Review Request: python-pysam - reading, manipulating and writing genomic data sets
https://bugzilla.redhat.com/show_bug.cgi?id=1829523 Bug ID: 1829523 Summary: Review Request: python-pysam - reading, manipulating and writing genomic data sets Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: david08...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/davidsch/testing/fedora-rawhide-x86_64/01356445-python-pysam/python-pysam.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/davidsch/testing/fedora-rawhide-x86_64/01356445-python-pysam/python-pysam-0.15.4-1.fc33.src.rpm Description: pysam - a python module for reading, manipulating and writing genomic data sets. pysam is a lightweight wrapper of the htslib C-API and provides facilities to read and write SAM/BAM/VCF/BCF/BED/GFF/GTF/FASTA/FASTQ files as well as access to the command line functionality of the samtools and bcftools packages. The module supports compression and random access through indexing. This module provides a low-level wrapper around the htslib C-API as using cython and a high-level API for convenient access to the data within standard genomic file formats. See: http://www.htslib.org https://github.com/pysam-developers/pysam http://pysam.readthedocs.org/en/stable Fedora Account System Username: davidsch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828813] Review Request: bashtop - Resource monitor written in bash that shows usage and stats for processor, memory, disks, network and processes
https://bugzilla.redhat.com/show_bug.cgi?id=1828813 --- Comment #4 from Artem --- Requires: awk Requires: coreutils Requires: grep Requires: procps-ng Requires: sed Also need here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828813] Review Request: bashtop - Resource monitor written in bash that shows usage and stats for processor, memory, disks, network and processes
https://bugzilla.redhat.com/show_bug.cgi?id=1828813 --- Comment #3 from Artem --- Also you can add weak deps: Recommends: lm-sensors Recommends: curl -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828813] Review Request: bashtop - Resource monitor written in bash that shows usage and stats for processor, memory, disks, network and processes
https://bugzilla.redhat.com/show_bug.cgi?id=1828813
Artem changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|ego.corda...@gmail.com
Flags||fedora-review?
--- Comment #2 from Artem ---
1. License should be 'ASL 2.0'.
2. Source0:
https://github.com/aristocratos/%{name}/archive/v%{version}/%{name}-v%{version}.tar.gz
->
Source0:
%{url}/%{name}/archive/v%{version}/%{name}-v%{version}.tar.gz
3. Use upstream summary:
Linux resource monitor
4. Description is to long. Limit it at 80 symbols and add dot in the end.
5. %autosetup -n %{name}-%{version}
->
%autosetup
6. Add also 'CHANGELOG.md' to %doc
7. Use macros consistenly in %files
%{_bindir}/%{name]
8. Own whole directory
%{_datadir}/%{name}/themes
->
%{_datadir}/%{name}/
9. Update to 0.8.16 version.
---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Apache License 2.0". 23 files have
unknown license. Detailed output of licensecheck in /mnt/data-
linux/tmp/review/1828813-bashtop/licensecheck.txt
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/bashtop
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/bashtop
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[?]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[?]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API
https://bugzilla.redhat.com/show_bug.cgi?id=1773720 --- Comment #17 from Brandon Perkins --- Upstream has fixed the issue with: https://github.com/haproxytech/dataplaneapi/pull/86 but there is not a release for it yet. This is blocked until a new version is released. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804768] Review Request: catatonit - A signal-forwarding process manager for containers
https://bugzilla.redhat.com/show_bug.cgi?id=1804768 --- Comment #9 from Fedora Update System --- FEDORA-2020-9aeddd91c6 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-9aeddd91c6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804768] Review Request: catatonit - A signal-forwarding process manager for containers
https://bugzilla.redhat.com/show_bug.cgi?id=1804768 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #8 from Fedora Update System --- FEDORA-2020-f8f80a3c1c has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f8f80a3c1c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828813] Review Request: bashtop - Resource monitor written in bash that shows usage and stats for processor, memory, disks, network and processes
https://bugzilla.redhat.com/show_bug.cgi?id=1828813
Fabian Affolter changed:
What|Removed |Added
CC||m...@fabian-affolter.ch
Doc Type|--- |If docs needed, set a value
--- Comment #1 from Fabian Affolter ---
Just some quick comments:
- Source0: could be replaced with
%{url}/archive/v%{version}/%{name}-v%{version}.tar.gz
- %description should end with a period
The shebang is "#!/usr/bin/env bash". Wouldn't this need "Requires: bash"?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 956210] Review Request: glite-info-provider-ldap - Information provider to query LDAP sources
https://bugzilla.redhat.com/show_bug.cgi?id=956210 Laurence Field changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed||2020-04-29 13:40:28 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 956243] Review Request: glite-info-provider-service - GLUE service information provider
https://bugzilla.redhat.com/show_bug.cgi?id=956243 Laurence Field changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed||2020-04-29 13:40:51 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1775443] Review Request: wlr-randr - An xrandr clone for wlroots compositors
https://bugzilla.redhat.com/show_bug.cgi?id=1775443 --- Comment #17 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/wlr-randr -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804768] Review Request: catatonit - A signal-forwarding process manager for containers
https://bugzilla.redhat.com/show_bug.cgi?id=1804768 --- Comment #7 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/catatonit -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827925] Review Request: rust-vmw_backdoor - Pure-Rust library for VMware host-guest protocol ("VMXh backdoor")
https://bugzilla.redhat.com/show_bug.cgi?id=1827925 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-vmw_backdoor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826034] Review Request: cubeb - A cross platform audio library
https://bugzilla.redhat.com/show_bug.cgi?id=1826034 --- Comment #12 from Jeremy Newton --- Thanks Gwyn! This has been pushed to rawhide, update for f32 incoming. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826034] Review Request: cubeb - A cross platform audio library
https://bugzilla.redhat.com/show_bug.cgi?id=1826034 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #13 from Fedora Update System --- FEDORA-2020-f7fb71a093 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f7fb71a093 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820915] Review Request: bettercap - Tool for 802.11, BLE/Ethernet reconnaissance and MITM attacks
https://bugzilla.redhat.com/show_bug.cgi?id=1820915 --- Comment #4 from Germano Massullo --- Hi Fabian, if you upload new spec / srpm, as soon all dependencies will be built on Koji I will download them and do the bettercap review even before the dependencies will reach stable repository -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820842] Review Request: golang-github-kr-binarydist - Go implementation of the bspatch algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1820842 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #4 from Fedora Update System --- FEDORA-2020-e9ccbd0de1 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-e9ccbd0de1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826998] Review Request: python-language-server - Python Language Server for the Language Server Protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1826998 --- Comment #9 from Mukundan Ragavan --- Updated SPEC URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/pyls/rnd1/python-language-server.spec Updated SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/pyls/rnd1/python-language-server-0.31.10-2.fc32.src.rpm Package builds fine on mock and all tests pass (Thanks to openSUSE specfile). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820849] Review Request: golang-github-malfunkt-iprange - IPv4 address parser for the nmap format
https://bugzilla.redhat.com/show_bug.cgi?id=1820849 --- Comment #5 from Fedora Update System --- FEDORA-2020-231e9aa60b has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-231e9aa60b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820849] Review Request: golang-github-malfunkt-iprange - IPv4 address parser for the nmap format
https://bugzilla.redhat.com/show_bug.cgi?id=1820849 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #4 from Fedora Update System --- FEDORA-2020-425abec16a has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-425abec16a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820891] Review Request: golang-github-chifflier-nfqueue - Go wrapper library for libnetfilter-queue
https://bugzilla.redhat.com/show_bug.cgi?id=1820891 --- Comment #10 from Fedora Update System --- FEDORA-2020-0e87ab1b08 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-0e87ab1b08 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820891] Review Request: golang-github-chifflier-nfqueue - Go wrapper library for libnetfilter-queue
https://bugzilla.redhat.com/show_bug.cgi?id=1820891 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #9 from Fedora Update System --- FEDORA-2020-2297d64f93 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-2297d64f93 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1774713] Review Request: virt-v2v - Convert a virtual machine to run on KVM
https://bugzilla.redhat.com/show_bug.cgi?id=1774713 Richard W.M. Jones changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed|2019-11-27 14:16:19 |2020-04-29 12:15:11 --- Comment #26 from Richard W.M. Jones --- There have been a number of successful builds since December, eg: https://koji.fedoraproject.org/koji/buildinfo?buildID=1494574 so I'm closing this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829340] Review Request: python3-Pebble - Threading and multiprocessing eye-candy for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1829340 Miro Hrončok changed: What|Removed |Added Status|NEW |ASSIGNED CC||mhron...@redhat.com Assignee|nob...@fedoraproject.org|mhron...@redhat.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829334] Review Request: 3mux - Terminal multiplexer
https://bugzilla.redhat.com/show_bug.cgi?id=1829334 Fabian Affolter changed: What|Removed |Added Depends On||1829337 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1829337 [Bug 1829337] Review Request: golang-github-burntsushi-xdg - Reader for the XDG Base Directory specification -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829340] New: Review Request: python3-Pebble - Threading and multiprocessing eye-candy for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1829340 Bug ID: 1829340 Summary: Review Request: python3-Pebble - Threading and multiprocessing eye-candy for Python Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: mli...@suse.cz QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://raw.githubusercontent.com/marxin/fedora-Pebble/master/python-Pebble.spec SRPM URL: https://github.com/marxin/fedora-Pebble/raw/master/python3-Pebble-4.5.1-0.src.rpm Description: Threading and multiprocessing eye-candy for Python Fedora Account System Username: marxin -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829337] Review Request: golang-github-burntsushi-xdg - Reader for the XDG Base Directory specification
https://bugzilla.redhat.com/show_bug.cgi?id=1829337 Fabian Affolter changed: What|Removed |Added Blocks||1829334 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1829334 [Bug 1829334] Review Request: 3mux - Terminal multiplexer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829337] New: Review Request: golang-github-burntsushi-xdg - Reader for the XDG Base Directory specification
https://bugzilla.redhat.com/show_bug.cgi?id=1829337 Bug ID: 1829337 Summary: Review Request: golang-github-burntsushi-xdg - Reader for the XDG Base Directory specification Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-burntsushi-xdg.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-burntsushi-xdg-0-0.1.20200429gite80d344.fc31.src.rpm Project URL: https://github.com/BurntSushi/xdg Description: A Go package for reading config and data files according to the XDG Base Directory specification. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=43895333 rpmlint output: $ rpmlint golang-github-burntsushi-xdg-0-0.1.20200429gite80d344.fc31.src.rpm golang-github-burntsushi-xdg.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint golang-github-burntsushi-xdg-devel-0-0.1.20200429gite80d344.fc31.noarch.rpm golang-github-burntsushi-xdg-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/BurntSushi/xdg/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829334] New: Review Request: 3mux - Terminal multiplexer
https://bugzilla.redhat.com/show_bug.cgi?id=1829334 Bug ID: 1829334 Summary: Review Request: 3mux - Terminal multiplexer Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/3mux.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/3mux-0.3.0-1.fc31.src.rpm Project URL: https://github.com/aaronjanse/3mux Description: A terminal multiplexer inspired by i3. Koji scratch build: Fails due to missing dependency. rpmlint output: $ rpmlint 3mux-0.3.0-1.fc31.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint 3mux* 3mux.x86_64: W: no-manual-page-for-binary 3mux 3mux.x86_64: W: no-manual-page-for-binary fuzz 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827622] Review Request: python-tld - Python module to extract TLDs from URLs
https://bugzilla.redhat.com/show_bug.cgi?id=1827622 Artur Iwicki changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from Artur Iwicki --- Updated to v.0.12.1. spec: https://svgames.pl/fedora/python-tld-0.12.1-1/python-tld.spec srpm: https://svgames.pl/fedora/python-tld-0.12.1-1/python-tld-0.12.1-1.fc31.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=43894725 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 810049] Review Request: netbeans-ide - Netbeans Integrated Development Environment (IDE)
https://bugzilla.redhat.com/show_bug.cgi?id=810049 code kit changed: What|Removed |Added CC||codekit...@gmail.com --- Comment #111 from code kit --- (In reply to gil cattaneo from comment #0) > Spec URL: http://gil.fedorapeople.org/netbeans.spec > SRPM URL: http://gil.fedorapeople.org/netbeans-7.1.1-1.fc16.src.rpm > Description: NetBeans IDE is an Integrated Development Environment (IDE) for > Java/JavaFX, > C/C++, Ruby, PHP, etc. The NetBeans IDE is oriented on wide audience of > developers from beginners up to experts. A developer can find useful set of > the development tools that are embedded in the IDE or can be integrated > with. > The NetBeans IDE is the modular system and it can be configured according to > user needs. Please, visit http://www.netbeans.org/ for more information > about > this open-source project. https://www.maalsell.com/-online shopping https://easypractice.in/-online government exam preparation https://udaipurmirror.com/-udaipur news http://code-kit.com/ Target page for Udaipur -https://udaipurcallgirlsandescort.com Target page for Jaipur - https://udaipurcallgirlsandescort.com/jaipur-escorts.html Target page for jaisalmer - https://udaipurcallgirlsandescort.com/jaisalmer-escorts.html Target page for jodhpur - https://udaipurcallgirlsandescort.com/jodhpur-escorts-service.html Target for mount Abu - https://udaipurcallgirlsandescort.com/mount-abu-escorts.html http://hotescortsudaipur.com -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804768] Review Request: catatonit - A signal-forwarding process manager for containers
https://bugzilla.redhat.com/show_bug.cgi?id=1804768 Jindrich Novy changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Jindrich Novy --- LGTM. Thanks Lokesh! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1812435] Review Request: python-beautifultable - Print ASCII tables for terminals
https://bugzilla.redhat.com/show_bug.cgi?id=1812435 --- Comment #3 from Fabian Affolter --- * Thu Apr 23 2020 Fabian Affolter - 0.8.0-2 - Add missing BR for tests (rhbz#1812435) Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=43893083 Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-beautifultable.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-beautifultable-0.8.0-2.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826439] Review Request: libvma - LD_PRELOAD-able library with standard BSD sockets API
https://bugzilla.redhat.com/show_bug.cgi?id=1826439
Artur Iwicki changed:
What|Removed |Added
CC||fed...@svgames.pl
--- Comment #1 from Artur Iwicki ---
>Group: System Environment/Libraries
This tag is not used in Fedora and not in EPEL. Please remove those instead of
hiding them behind %if.
>BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XX)
>Prefix: %{_prefix}
>...
>%install
>[ "${RPM_BUILD_ROOT}" != "/" -a -d ${RPM_BUILD_ROOT} ] && rm -rf
>${RPM_BUILD_ROOT}
>...
>%clean
The tags are not used in Fedora; the buildroot should not be deleted at start
of %install.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections
>ExclusiveArch: x86_64 ppc64le ppc64 aarch64
Add a comment explaining why this is needed.
>%files
>%{_libdir}/%{name}.so
The un-versioned .so typically goes into -devel.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804768] Review Request: catatonit - A signal-forwarding process manager for containers
https://bugzilla.redhat.com/show_bug.cgi?id=1804768 --- Comment #5 from Lokesh Mandvekar --- Spec URL: https://pagure.io/catatonit/blob/master/f/catatonit.spec SRPM URL: https://pagure.io/catatonit/blob/master/f/SRPMS/catatonit-0.1.5-2.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1809303] Review Request: alsa-sof-firmware - Sound Open Firmware binary files
https://bugzilla.redhat.com/show_bug.cgi?id=1809303 Peter Robinson changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2020-04-29 10:09:20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 810049] Review Request: netbeans-ide - Netbeans Integrated Development Environment (IDE)
https://bugzilla.redhat.com/show_bug.cgi?id=810049 Madhu Tomar changed: What|Removed |Added CC||mohitkuma...@gmail.com --- Comment #110 from Madhu Tomar --- http://www.madhu-mumbaiescorts.com/ http://www.madhu-mumbaiescorts.com/ahmedabad.html http://www.madhu-mumbaiescorts.com/kolkata.html http://www.madhu-mumbaiescorts.com/hyderabad.html http://www.mumbaimood.com/ http://no1bangaloreescorts.com https://www.komalshety.com http://www.mumbaimood.com/andheri.html http://www.mumbaimood.com/juhu.html http://www.mumbaimood.com/wadala.html http://www.mumbaimood.com/vashi.html http://www.mumbaimood.com/thane.html http://www.mumbaimood.com/mulund.html http://www.mumbaimood.com/goregaon.html http://www.mumbaimood.com/ghatkopar.html http://www.mumbaimood.com/chembur.html http://www.mumbaimood.com/bandra.html http://www.mumbaimood.com/kurla.html http://ankitamumbaiescorts.co.in/thane-east.html -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825657] Review Request: lazpaint - Simple image editor
https://bugzilla.redhat.com/show_bug.cgi?id=1825657 Artur Iwicki changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from Artur Iwicki --- Updated to v.7.1.2 and made some minor improvements to the spec. spec: https://svgames.pl/fedora/lazpaint-7.1.2-1/lazpaint.spec srpm: https://svgames.pl/fedora/lazpaint-7.1.2-1/lazpaint-7.1.2-1.fc32.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=43891885 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804768] Review Request: catatonit - A signal-forwarding process manager for containers
https://bugzilla.redhat.com/show_bug.cgi?id=1804768 Lokesh Mandvekar changed: What|Removed |Added Flags|needinfo?(l...@redhat.com) | --- Comment #4 from Lokesh Mandvekar --- Spec URL: https://pagure.io/catatonit/blob/master/f/catatonit.spec SRPM URL: https://pagure.io/catatonit/blob/master/f/SRPMS/catatonit-0.1.5-1.fc32.src.rpm Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=43891594 Jindrich, I'll post the SRPM somewhere else if this still doesn't work. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829070] Review Request: multiwatch - Forks and watches multiple instances of a program in the same context
https://bugzilla.redhat.com/show_bug.cgi?id=1829070 Benjamin Lefoul changed: What|Removed |Added CC||l...@fedoraproject.org Assignee|nob...@fedoraproject.org|l...@fedoraproject.org Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1814682] Review Request: rshim - rshim driver for Mellanox BlueField SoC
https://bugzilla.redhat.com/show_bug.cgi?id=1814682
Honggang LI changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #54 from Honggang LI ---
I had run basic functional tests for rshim. Confirmed it works as expected and
the
output of fedora-review tool looks good for me.
Set the 'fedora-review+' flag. Michal, please add lsun into packager group.
=
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[ ]: Package does not contain kernel modules.
PASS
[ ]: Package contains no static executables.
PASS
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
PASS
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* GPL (v2)", "Unknown or generated", "GPL (v2)".
23 files have unknown license. Detailed output of licensecheck in
/home/honli/review/1814682-rshim/licensecheck.txt
PASS. It is a review tool issue, as those files have "SPDX-License-Identifier:
GPL-2.0-only" tag.
[ ]: License file installed when any subpackage combination is installed.
PASS.
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/systemd,
/usr/lib/systemd/system
PASS
[ ]: %build honors applicable compiler flags or justifies otherwise.
PASS
[ ]: Package contains no bundled libraries without FPC exception.
PASS
[ ]: Changelog in prescribed format.
PASS
[ ]: Sources contain only permissible code or content.
PASS
[ ]: Package contains desktop file if it is a GUI application.
PASS. It is not a GUI application.
[ ]: Development files must be in a -devel package
PASS. no devel
[ ]: Package uses nothing in %doc for runtime.
PASS
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
PASS
[ ]: Package is named according to the Package Naming Guidelines.
PASS
[ ]: Package does not generate any conflict.
PASS
[ ]: Package obeys FHS, except libexecdir and /usr/target.
PASS
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
PASS
[ ]: Requires correct, justified where necessary.
PASS
[ ]: Spec file is legible and written in American English.
PASS
[ ]: Package contains systemd file(s) if in need.
PASS. start/stop rshim service confirmed the systemd service file works.
[ ]: Useful -debuginfo package or justification otherwise.
PASS
[ ]: Package is not known to require an ExcludeArch tag.
PASS
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
PASS
[ ]: Package complies to the Packaging Guidelines
PASS
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: systemd_post is invoked in %post, systemd_preun in %preun, and
systemd_postun in %postun for Systemd service files.
Note:
[Bug 1814682] Review Request: rshim - rshim driver for Mellanox BlueField SoC
https://bugzilla.redhat.com/show_bug.cgi?id=1814682 --- Comment #53 from Honggang LI --- (In reply to lsun from comment #49) > > Why does the rshim.service use killall in the first place? There is: > > > KillMode=process > > > > Why this mode? Do you need child processes to be left running in the cgroup > > after the service is stopped? > > If yes, commenting on it in the unit file would be nice. > > It's a copy/paste error. I would like to stop all processes when service > stops. > > > > > > ExecStop=/usr/bin/killall -SIGKILL rshim > > > > Referencing processes to kill by name is not good. It would kill unrelated > > processes with the same name. > > Is none of systemd's kill modes suitable for stopping the service without > > additional help? > > And why SIGKILL? Does it not stop on SIGTERM? > > Will update in next posted version with the following: > - Remove the "Requires: psmisc" > - Remove "ExecStop". > - Use "KillMode=control-group" > - Support SIGTERM > > [Service] > Restart=always > Type=forking > ExecStart=-/usr/sbin/rshim $OPTIONS > KillMode=control-group Confirmed rshim.service start/stop works with the new systemd service file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
