[Bug 1826270] Review Request: perl-B-COW - Additional B helpers to check Copy On Write status
https://bugzilla.redhat.com/show_bug.cgi?id=1826270 --- Comment #17 from Fedora Update System --- FEDORA-2020-b40431c7f0 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829539] Review Request: rust-git-delta - Syntax-highlighting pager for git
https://bugzilla.redhat.com/show_bug.cgi?id=1829539 --- Comment #9 from Fedora Update System --- FEDORA-2020-2441d8c17d has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829539] Review Request: rust-git-delta - Syntax-highlighting pager for git
https://bugzilla.redhat.com/show_bug.cgi?id=1829539 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2020-05-03 04:54:18 --- Comment #8 from Fedora Update System --- FEDORA-2020-7d10a3490d has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826270] Review Request: perl-B-COW - Additional B helpers to check Copy On Write status
https://bugzilla.redhat.com/show_bug.cgi?id=1826270 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-05-03 04:54:02 --- Comment #16 from Fedora Update System --- FEDORA-2020-d31ca621ea has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773382] Review Request: home-assistant-cli - Command-line tool for Home Assistant
https://bugzilla.redhat.com/show_bug.cgi?id=1773382 --- Comment #16 from Fedora Update System --- FEDORA-2020-c3d522a9b3 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821120] Review Request: wlogout - wayland based logout menu
https://bugzilla.redhat.com/show_bug.cgi?id=1821120 --- Comment #17 from Fedora Update System --- FEDORA-2020-105f9d6381 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1808552] Review Request: python-numpoly - Numpoly is a generic library for creating, manipulating and evaluating arrays of polynomials.
https://bugzilla.redhat.com/show_bug.cgi?id=1808552 --- Comment #16 from Fedora Update System --- FEDORA-2020-b1370a85f0 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815810] Review Request: python-pg8000 - Pure Python PostgreSQL Driver
https://bugzilla.redhat.com/show_bug.cgi?id=1815810 --- Comment #24 from Fedora Update System --- FEDORA-2020-8bd55aa329 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824467] Review Request: freeopcua - Open Source C++ OPC-UA Server and Client Library
https://bugzilla.redhat.com/show_bug.cgi?id=1824467 --- Comment #22 from Fedora Update System --- FEDORA-2020-fcd729be00 has been pushed to the Fedora 30 stable repository. If problem still persists, please make note of it in this bug report. --- Comment #23 from Fedora Update System --- FEDORA-2020-de6cd5519f has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824848] Review Request: jc - JSONifies the output of dozens of commands
https://bugzilla.redhat.com/show_bug.cgi?id=1824848 --- Comment #10 from Kelly Brazil --- Thanks for the feedback! It looks like this works: https://github.com/kellyjonbrazil/jc-packaging/blob/master/rpmbuild/SPEC/python-jc.spec $ rpm -q -i -p python3-jc-1.10.7-1.fc32.noarch.rpm Name: python3-jc Version : 1.10.7 Release : 1.fc32 Architecture: noarch Install Date: (not installed) Group : Unspecified Size: 17702993 License : MIT Signature : (none) Source RPM : python-jc-1.10.7-1.fc32.src.rpm Build Date : Sat 02 May 2020 10:42:16 AM PDT Build Host : localhost URL : https://github.com/kellyjonbrazil/jc Summary : Serialize the output of command line tools and filetypes to structured JSON Description : JSON CLI output utility. JC is used to JSONify the output of many standard linux CLI tools and file types for easier parsing in scripts. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830539] New: Review Request: mdns-scan - Scan for mDNS/DNS-SD services published on the local network
https://bugzilla.redhat.com/show_bug.cgi?id=1830539 Bug ID: 1830539 Summary: Review Request: mdns-scan - Scan for mDNS/DNS-SD services published on the local network Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: redhat-bugzi...@linuxnetz.de QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://labs.linuxnetz.de/bugzilla/mdns-scan.spec SRPM URL: https://labs.linuxnetz.de/bugzilla/mdns-scan-0.5-1.src.rpm Description: mdns-scan is a tool for scanning for mDNS/DNS-SD services published on the local network. It works by issuing a mDNS PTR query to the special RR _services._dns-sd._udp.local for retrieving a list of all currently registered services on the local link. Fedora Account System Username: robert -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824848] Review Request: jc - JSONifies the output of dozens of commands
https://bugzilla.redhat.com/show_bug.cgi?id=1824848
--- Comment #9 from Artur Iwicki ---
The binary RPM link is not needed. The spec should be provided as a link,
instead of being pasted here.
Either way, here's my nitpicking:
>Summary:This tool serializes the output of popular command line tools
>and filetypes to structured JSON output
The summary text should be no longer than 80 characters. Maybe "Serialize the
output of command line tools and filetypes to structured JSON"?
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description
>%description
>JSON CLI output utilityjc is used to JSONify the output of many standard linux
>cli tools and file types for easier parsing in scripts.
>...
>%description -n python3-%{pypi_name}
>JSON CLI output utilityjc is used to JSONify the output of many standard linux
>cli tools and file types for easier parsing in scripts.
1. "utilityjc" - missing space
2. "cli tools" - please use "CLI"
3. Consider putting the description into a macro (i.e. %global macro_name
macro_body), so you don't have to repeat this text in the spec and just use the
macro instead.
>%{?python_provide:%python_provide python3-%{pypi_name}}
I believe this is not needed; it will get auto-generated.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_automatic_provides_with_a_standardized_name
>Requires: python3dist(pygments) >= 2.4.2
>Requires: python3dist(ruamel.yaml) >= 0.15
>Requires: python3dist(setuptools)
>Requires: python3dist(xmltodict) >= 0.12
Again, these are not needed; the automatic Python dependency generator should
pick these up for you.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_automatically_generated_dependencies
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828205] Review Request: doctest - fast header-only C++ unit testing
https://bugzilla.redhat.com/show_bug.cgi?id=1828205
Nick Black changed:
What|Removed |Added
Flags|needinfo?(d...@qemfd.net) |
--- Comment #10 from Nick Black ---
> *sigh*
you and me both, buddy
Yeah, I was expecting /usr/share/cmake/Modules to work, as there are a bunch of
other .cmake files in there. I expected it enough that I went and verified in
the CMake source that, yes, it is looking for particular shipped files there,
and doing searches for find_package() only in the directories enumerated above.
Sorry :/.
On the "plus" side, this is the right thing to do anyway, because those cmake
files have /usr/lib64 references in them as installed. So this was never
properly a noarch package.
I don't see any means to disable particular warnings like Lintian, alas.
> That means dropping the noarch thing and adding back the %global to disable
> debuginfo generation. Put the %global at the top of the spec file. And
> then just use %{_libdir} since that expands correctly to /usr/lib or
> /usr/lib64.
Done.
Validated specfile and grabbed sources with `spectool -g`
Built SRPM with `rpmbuild -bs`
Built RPM+SRPM with `mock -r fedora-rawhide-x86_64 --rebuild`
Installed `doctest-devel` x86_64 RPM, verified that doctest was discovered by
CMake
Removed `doctest-devel`, verified that all residue was clean
rpmlint complains: W: only-non-binary-in-usr-lib
[vps](0) $ sha256sum *doctest*
2f478adeb87cf8444fffdb01ab4de54e64c12b807842275cf2325dc4c8512f9f
doctest-devel-2.3.7-1.fc33.src.rpm
9667ee059437b8fe84ac1a8aab3b4a38e832c8528dfd50e02793cb6a3af718da
doctest-devel-2.3.7-1.fc33.x86_64.rpm
[vps](0) $
https://www.dsscaw.com/repos/dnf/doctest-devel-2.3.7-1.fc33.src.rpm
PTAL
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830529] New: Re-Review Request: seahorse-adventures - Retro side-scrolling platformer game
https://bugzilla.redhat.com/show_bug.cgi?id=1830529 Bug ID: 1830529 Summary: Re-Review Request: seahorse-adventures - Retro side-scrolling platformer game Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@svgames.pl QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora spec: https://svgames.pl/fedora/seahorse-adventures-1.1-3.20200502git0f342d34/seahorse-adventures.spec srpm: https://svgames.pl/fedora/seahorse-adventures-1.1-3.20200502git0f342d34/seahorse-adventures-1.1-3.20200502git0f342d34.fc32.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=44034044 Description: Help barbie the seahorse float on bubbles to the moon. Includes original soundtrack, graphics, and 15 levels! Fedora Account System Username: suve This a re-review request for seahorse-adventures, which was previously packaged for Fedora (it is, in fact, still available for F30 and F31). It was dropped from F32+ due to being python2-only. A python3 fork as appeared recently (https://github.com/dulsi/seahorse-adventures) and that's what's being packaged here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829539] Review Request: rust-git-delta - Syntax-highlighting pager for git
https://bugzilla.redhat.com/show_bug.cgi?id=1829539 --- Comment #7 from Fedora Update System --- FEDORA-2020-7d10a3490d has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-7d10a3490d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820805] Review Request: golang-github-bettercap-gatt - Go package for building Bluetooth Low Energy peripherals
https://bugzilla.redhat.com/show_bug.cgi?id=1820805 --- Comment #4 from Fabian Affolter --- (In reply to Jakub Čajka from comment #3) > Thanks for adding bringing it up in upstream. I don't want to be overly > pedantic, but could you add breakdown in the comment near license section > that those libs are under MIT/expat license for the distribution build. > Otherwise looks good. Approved. Sure, I will add it before the import. Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1811777] Review Request: rubygem-puppet-resource_api - This library provides a simple way to write new native resources for puppet
https://bugzilla.redhat.com/show_bug.cgi?id=1811777 Terje Røsten changed: What|Removed |Added CC||terje...@phys.ntnu.no --- Comment #3 from Terje Røsten --- 1.8.13 is on rubygems.org now. Is the requires correct? In /usr/share/gems/gems/puppet-resource_api-1.8.12/lib/puppet/resource_api.rb there is: require 'puppet/type' what package provides this? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820915] Review Request: bettercap - Tool for 802.11, BLE/Ethernet reconnaissance and MITM attacks
https://bugzilla.redhat.com/show_bug.cgi?id=1820915 Germano Massullo changed: What|Removed |Added Flags||needinfo?(mail@fabian-affol ||ter.ch) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1811775] Review Request: rubygem-semantic_puppet - Useful tools for working with Semantic Versions
https://bugzilla.redhat.com/show_bug.cgi?id=1811775
Terje Røsten changed:
What|Removed |Added
CC||terje...@phys.ntnu.no
Assignee|nob...@fedoraproject.org|terje...@phys.ntnu.no
--- Comment #7 from Terje Røsten ---
Summary:
fix changelog and consider name change, the rest is fine.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[?]: Changelog in prescribed format.
Please fix this.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros
[?]: Package is named according to the Package Naming Guidelines.
For RPMS it's normal to us - over _, switch to rubygem-semantic-puppet ?
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: Avoid bundling fonts in non-fonts packages.
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
[-]: Description and summary sections in the package spec file contains
[x]: Package should compile and build into binary rpms on all supported
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
= EXTRA items =
Generic:
[x]: When checking ruby code, install the ruby plugin.
[x]: Rpmlint is run on all installed packages.
[x]: Spec file according to URL is the same as in SRPM.
[Bug 1823599] Review Request: gjots2 - A heirarchical note jotter. Organise your ideas, notes, facts in a tree
https://bugzilla.redhat.com/show_bug.cgi?id=1823599 --- Comment #19 from Alexander Ploumistos --- Hello Bob, Good job with all the changes! (In reply to Bob Hepple from comment #16) > Alexander - I can't replicate your block icon problem on my system. Do you > have anything in your ~/.gjotsfile ?? What is your locale? Mine is > LC_ALL=en_AU.utf8 and LANG=C. I don't have LANG defined, but everything else is en_US.UTF-8 and the .gjotsfile was empty. In the meantime I've moved to Fedora 32 and with your latest changes, I didn't get these blocks, so we can chalk it off as gremlins I guess. When I tried to launch gjots2 in F32 I noticed that I was getting the generic executable icon and not the png in /usr/share/pixmaps. In the desktop file you have "Icon=gjots2", but the file is called gjots.png. According to the specification, it shouldn't have worked before and I don't know why it did, but you should rename the image to gjots2.png. When I renamed the file I did get the right icon. My bad, I didn't think twice about that when I saw it before. By the way, with HiDPI/4K displays becoming commonplace (I still don't have one) graphics are growing huge these days. If you ever need any help creating a higher resolution icon, I'm sure that you can ask on the design team's mailing list and someone should be able to help you - there are a lot of talented people working on Fedora. Just add the trailing slash, rename the icon file and we're good to go. Thanks again Miro! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1811774] Review Request: rubygem-puppetserver-ca - A simple CLI tool for interacting with Puppet Server's Certificate Authority
https://bugzilla.redhat.com/show_bug.cgi?id=1811774 Terje Røsten changed: What|Removed |Added CC||terje...@phys.ntnu.no --- Comment #3 from Terje Røsten --- Can you please add proper changelog in package? 1.7.0 has just: %changelog * Wed Dec 18 2019 Breno Brand Fernandes - 1.7.0-1 - First build which seems wrong. If you include proper changelog and (increase release version on each update) it will be much simpler to follow changes and do review. Building + installing package works fine, however after install I get: $ /usr/bin/puppetserver-ca Traceback (most recent call last): 1: from /usr/bin/puppetserver-ca:23:in `' /usr/bin/puppetserver-ca:23:in `load': cannot load such file -- /usr/share/gems/gems/puppetserver-ca-1.7.0/exe/puppetserver-ca (LoadError) Can you please look into that? (Tested on Fedora 32). If you could provide koji scratch build for rawhide it would help too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829539] Review Request: rust-git-delta - Syntax-highlighting pager for git
https://bugzilla.redhat.com/show_bug.cgi?id=1829539 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #6 from Fedora Update System --- FEDORA-2020-2441d8c17d has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-2441d8c17d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803059] Review Request: hfg-gmuend-openmoji-color-fonts - Emojis with a line-drawn style
https://bugzilla.redhat.com/show_bug.cgi?id=1803059
--- Comment #6 from Nicolas Mailhot ---
Right, not font packages build on rawhide right now, because it has emerged rpm
4.15 stealthily changed Source/Patches evaluation rules, making existing
templates unsafe. The fix is coded by it is waiting for the common part to be
merged in redhat-rpm-config.
https://src.fedoraproject.org/rpms/redhat-rpm-config/pull-request/83#comment-42999
Sadly no one wanted to look at the problem seriously rpm or redhat-rpm-config
side before I pushed a macro build to koji that showed things were not so
simple.
*After* breaking rawhide builds people had to look at it and it has emerged it
is possible to evade the rpm change consequences by using %sourcelist and
%patchlist, and adding a wrapper around Name:/%package to workaround the fact
%{name} is "special".
You have an example of the new templates and of converted packages in
https://copr.fedorainfracloud.org/coprs/nim/workaround-rpm-commit-93604e2-effects/builds/
I did everything I could to adapt the macro code to rpm changes with as little
spec changes as possible. (you can not use those before the common part is
merged in redhat-rpm-config)
@eclipseo: Go specs will need the same kind of adjustment, because they use the
same basic spec structure, I'm waiting to get the fonts part done to be sure
there is no problem left before moving to the Go part.
@peter
So, it will mostly be transparent font spec side, except Sources will move to a
new rpm section and you will lose the ability to set the index of a fontconfig
file in sources.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829539] Review Request: rust-git-delta - Syntax-highlighting pager for git
https://bugzilla.redhat.com/show_bug.cgi?id=1829539 --- Comment #5 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-git-delta -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829539] Review Request: rust-git-delta - Syntax-highlighting pager for git
https://bugzilla.redhat.com/show_bug.cgi?id=1829539 Igor Gnatenko changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|i.gnatenko.br...@gmail.com Flags||fedora-review+ --- Comment #4 from Igor Gnatenko --- There were bunch of issues in the spec, so I just fixed all of them :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829539] Review Request: rust-git-delta - Syntax-highlighting pager for git
https://bugzilla.redhat.com/show_bug.cgi?id=1829539 --- Comment #3 from Igor Gnatenko --- New Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-git-delta.spec New SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-git-delta-0.1.1-1.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829539] Review Request: git-delta - Improved diff for git
https://bugzilla.redhat.com/show_bug.cgi?id=1829539 Igor Gnatenko changed: What|Removed |Added CC||i.gnatenko.br...@gmail.com Alias||rust-git-delta -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829539] Review Request: rust-git-delta - Syntax-highlighting pager for git
https://bugzilla.redhat.com/show_bug.cgi?id=1829539 Igor Gnatenko changed: What|Removed |Added Summary|Review Request: git-delta - |Review Request: |Improved diff for git |rust-git-delta - ||Syntax-highlighting pager ||for git -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829539] Review Request: git-delta - Improved diff for git
https://bugzilla.redhat.com/show_bug.cgi?id=1829539 Bug 1829539 depends on bug 1828938, which changed state. Bug 1828938 Summary: Review Request: rust-box_drawing - Very simple library for drawing boxes with UTF-8 characters https://bugzilla.redhat.com/show_bug.cgi?id=1828938 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828938] Review Request: rust-box_drawing - Very simple library for drawing boxes with UTF-8 characters
https://bugzilla.redhat.com/show_bug.cgi?id=1828938 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-05-02 08:46:42 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823599] Review Request: gjots2 - A heirarchical note jotter. Organise your ideas, notes, facts in a tree
https://bugzilla.redhat.com/show_bug.cgi?id=1823599
--- Comment #18 from Miro Hrončok ---
%{python3_sitelib}/%{name}-%{version}-py%{python3_version}.egg-info/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828938] Review Request: rust-box_drawing - Very simple library for drawing boxes with UTF-8 characters
https://bugzilla.redhat.com/show_bug.cgi?id=1828938 --- Comment #4 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-box_drawing -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828938] Review Request: rust-box_drawing - Very simple library for drawing boxes with UTF-8 characters
https://bugzilla.redhat.com/show_bug.cgi?id=1828938 Igor Gnatenko changed: What|Removed |Added Status|NEW |POST Flags||fedora-review+ --- Comment #3 from Igor Gnatenko --- Since the change is just about one line, I have fixed it for you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828938] Review Request: rust-box_drawing - Very simple library for drawing boxes with UTF-8 characters
https://bugzilla.redhat.com/show_bug.cgi?id=1828938 --- Comment #2 from Igor Gnatenko --- New Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-box_drawing.spec New SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-box_drawing-0.1.2-1.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828938] Review Request: rust-box_drawing - Very simple library for drawing boxes with UTF-8 characters
https://bugzilla.redhat.com/show_bug.cgi?id=1828938 Igor Gnatenko changed: What|Removed |Added Alias||rust-box_drawing -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828938] Review Request: rust-box_drawing - Very simple library for drawing boxes with UTF-8 characters
https://bugzilla.redhat.com/show_bug.cgi?id=1828938 Igor Gnatenko changed: What|Removed |Added Summary|Review Request: |Review Request: |rust-box_drawing - library |rust-box_drawing - Very |for drawing boxes with |simple library for drawing |UTF-8 characters|boxes with UTF-8 characters -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823599] Review Request: gjots2 - A heirarchical note jotter. Organise your ideas, notes, facts in a tree
https://bugzilla.redhat.com/show_bug.cgi?id=1823599
--- Comment #17 from Bob Hepple ---
Oh! Miro - sorry, I didn't quite understand this one:
> %{python3_sitelib}/%{name}-%{version}-py%{python3_version}.egg-info
> Consider adding leading slash to ensure this remains a directory.
%{python3_sitelib} expands to /usr/lib/python3.7/site-packages - surely it
always has a leading slash?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823599] Review Request: gjots2 - A heirarchical note jotter. Organise your ideas, notes, facts in a tree
https://bugzilla.redhat.com/show_bug.cgi?id=1823599 --- Comment #16 from Bob Hepple --- Hello again! Having dug out from the immediate real life time sinks I've been able to pick this up again. New build below addressing all the points raised so far (I believe). Alexander - I can't replicate your block icon problem on my system. Do you have anything in your ~/.gjotsfile ?? What is your locale? Mine is LC_ALL=en_AU.utf8 and LANG=C. SPEC URL: https://download.copr.fedorainfracloud.org/results/wef/gjots2/fedora-31-x86_64/01362427-gjots2/gjots2.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/wef/gjots2/fedora-31-x86_64/01362427-gjots2/gjots2-3.1.5-1.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
