[Bug 1835591] New: Review Request: rust-sxd-document - Rust XML DOM library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835591

Bug ID: 1835591
   Summary: Review Request: rust-sxd-document - Rust XML DOM
library
   Product: Fedora
   Version: rawhide
Status: NEW
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: igor.ra...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-sxd-document.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-sxd-document-0.3.2-1.fc33.src.rpm
Description:
Rust XML DOM library.
Fedora Account System Username: ignatenkobrain


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835590] New: Review Request: rust-rust-embed-impl - Custom Derive Macro which loads files into the rust binary

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835590

Bug ID: 1835590
   Summary: Review Request: rust-rust-embed-impl - Custom Derive
Macro which loads files into the rust binary
   Product: Fedora
   Version: rawhide
Status: NEW
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: igor.ra...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-rust-embed-impl.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-rust-embed-impl-5.5.1-1.fc33.src.rpm
Description:
Rust Custom Derive Macro which loads files into the rust binary at compile time
during release and loads the file from the fs during dev.
Fedora Account System Username: ignatenkobrain


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835588] New: Review Request: rust-log4rs - Highly configurable multi-output logging implementation for the `log` facade

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835588

Bug ID: 1835588
   Summary: Review Request: rust-log4rs - Highly configurable
multi-output logging implementation for the `log`
facade
   Product: Fedora
   Version: rawhide
Status: NEW
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: igor.ra...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-log4rs.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-log4rs-0.12.0-1.fc33.src.rpm
Description:
Highly configurable multi-output logging implementation for the `log` facade.
Fedora Account System Username: ignatenkobrain


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835587] New: Review Request: rust-des - DES and Triple DES (3DES, TDES) block ciphers implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835587

Bug ID: 1835587
   Summary: Review Request: rust-des - DES and Triple DES (3DES,
TDES) block ciphers implementation
   Product: Fedora
   Version: rawhide
Status: NEW
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: igor.ra...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-des.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-des-0.3.0-1.fc33.src.rpm
Description:
DES and Triple DES (3DES, TDES) block ciphers implementation.
Fedora Account System Username: ignatenkobrain


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835585] New: Review Request: rust-crc-any - Compute CRC values

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835585

Bug ID: 1835585
   Summary: Review Request: rust-crc-any - Compute CRC values
   Product: Fedora
   Version: rawhide
Status: NEW
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: igor.ra...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-crc-any.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/rust-crc-any-2.3.0-1.fc33.src.rpm
Description:
To compute CRC values by providing the length of bits, expression, reflection,
an initial value and a final xor value. It has many built-in CRC functions.
Fedora Account System Username: ignatenkobrain


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835458] Review Request: recapp - User friendly Open Source screencaster for Linux written in GTK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835458



--- Comment #10 from Fedora Update System  ---
FEDORA-2020-09b8e00ab3 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2020-09b8e00ab3 \*`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-09b8e00ab3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1829070] Review Request: multiwatch - Forks and watches multiple instances of a program in the same context

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1829070



--- Comment #10 from Fedora Update System  ---
FEDORA-2020-6dc849e66d has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2020-6dc849e66d \*`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-6dc849e66d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1821393] Review Request: pagure-cli - Pagure client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1821393



--- Comment #10 from Fedora Update System  ---
FEDORA-2020-d9b35f39b2 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2020-d9b35f39b2 \*`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-d9b35f39b2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834977] Review Request: python-cchardet - High speed universal character encoding detector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834977



--- Comment #1 from Carl George  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST fix =

[!]: License field in the package spec file matches the actual license.

The COPYING file contains the MPLv1.1, the GPLv2, and the LGPLv2.  The
setup.py file also lists all three of these licenses.  Include them all in
the License field.

-License:MPLv1.1
+License:MPLv1.1 or GPLv2 or LGPLv2


= SHOULD fix =

[!]: %check is present and all tests pass.

There is an upstream test suite and it passes, but running it would build
require a deprecated package (python3-nose).  I only bring it up to
encourage you to engage upstream about removing that dependency, and link to
the upstream discussion in a comment in the spec file.  They only thing they
are using specifically from nose is nose.tools.eq_.

https://github.com/PyYoshi/cChardet/blob/2.1.6/src/tests/test.py#L6
https://nose.readthedocs.io/en/latest/testing_tools.html#nose.tools.eq_


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
 BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Pa

[Bug 1829070] Review Request: multiwatch - Forks and watches multiple instances of a program in the same context

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1829070

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
FEDORA-2020-6aa8872251 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2020-6aa8872251 \*`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-6aa8872251

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1821393] Review Request: pagure-cli - Pagure client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1821393

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
FEDORA-2020-58665e3dee has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2020-58665e3dee \*`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-58665e3dee

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834977] Review Request: python-cchardet - High speed universal character encoding detector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834977

Carl George  changed:

   What|Removed |Added

 CC||c...@redhat.com
   Assignee|nob...@fedoraproject.org|c...@redhat.com
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1821172] Review Request: wl-gammactl - Small GTK GUI application to set contrast, brightness and gamma for wayland compositors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1821172



--- Comment #16 from Fedora Update System  ---
FEDORA-2020-9ffbca5825 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1823599] Review Request: gjots2 - A heirarchical note jotter. Organise your ideas, notes, facts in a tree

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1823599



--- Comment #32 from Fedora Update System  ---
FEDORA-2020-19e53d3ab0 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835458] Review Request: recapp - User friendly Open Source screencaster for Linux written in GTK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835458

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |ERRATA
Last Closed||2020-05-14 02:36:19



--- Comment #9 from Fedora Update System  ---
FEDORA-2020-c598d11bbb has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1831308] Review Request: python-sshtunnel - Pure python SSH tunnels

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1831308

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2020-05-14 02:35:32



--- Comment #6 from Fedora Update System  ---
FEDORA-2020-7029a187e9 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1823599] Review Request: gjots2 - A heirarchical note jotter. Organise your ideas, notes, facts in a tree

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1823599

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2020-05-14 02:28:46



--- Comment #31 from Fedora Update System  ---
FEDORA-2020-e75c278601 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1821172] Review Request: wl-gammactl - Small GTK GUI application to set contrast, brightness and gamma for wayland compositors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1821172

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2020-05-14 02:28:48



--- Comment #15 from Fedora Update System  ---
FEDORA-2020-4875486129 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1826439] Review Request: libvma - LD_PRELOAD-able library with standard BSD sockets API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1826439



--- Comment #4 from Honggang LI  ---
 1  %{!?configure_options: %global configure_options %{nil}}
 2  %{!?use_extralib: %global use_extralib 0}
 3  
 4  %global pmake %{__make} %{?_smp_mflags} %{?mflags} V=1

%make_build

 5  %global use_systemd %(if ( test -d "%{_unitdir}" > /dev/null); then
echo -n '1'; else echo -n '0'; fi)

always be true

 6  
 7  Name: libvma
 8  Version: 9.0.2
 9  Release: 1%{?dist}
10  Summary: A library for boosting TCP and UDP traffic (over RDMA
hardware)
11  
12  License: GPLv2 or BSD
13  Url: https://github.com/Mellanox/%{name}

Please use full path https://github.com/Mellanox/libvma 

14  Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz

Again. Use
https://github.com/Mellanox/libvma/archive/%{version}/%{name}-%{version}.tar.gz
Fedora upstream mointor tool will automaticlly try to build new package when
new release
available in upstream. An working source URL is necessary.

15  
16  # libvma currently supports only the following architectures
17  ExclusiveArch: x86_64 ppc64le ppc64 aarch64
18  
19  BuildRequires: pkgconfig
20  BuildRequires: automake
21  BuildRequires: autoconf
22  BuildRequires: libtool
23  BuildRequires: gcc-c++
24  BuildRequires: libibverbs-devel
25  BuildRequires: librdmacm-devel
26  %if 0%{?rhel} >= 7 || 0%{?fedora} >= 24 || 0%{?suse_version} >= 1500

line 26 is always true for Fedora and RHEL release in today. Please remove
anything
related to suse for Fedora spec file. So, please delete line 26 and line 28.

27  BuildRequires: libnl3-devel
28  %endif
29  
30  %description
31  libvma is a LD_PRELOAD-able library that boosts performance of TCP and
32  UDP traffic. It allows application written over standard socket API to
33  handle fast path data traffic from user space over Ethernet and/or
34  Infiniband with full network stack bypass and get better throughput,
35  latency and packets/sec rate.
36  .

Unwanted dot in line 36, please delete it.

37  No application binary change is required for that.
38  libvma is supported by RDMA capable devices that support "verbs"
39  IBV_QPT_RAW_PACKET QP for Ethernet and/or IBV_QPT_UD QP for IPoIB.
40  .

Again. Unwanted dot in line 36, please delete it.   

41  This package includes headers for building programs with libvma's
interface
42  directly, as opposed to loading it dynamically with LD_PRELOAD.
43  
44  %package devel
45  Summary: Header files and link required to develop with Libvma
46  Requires: %{name}%{?_isa} = %{version}-%{release}
47  
48  %description devel
49  This package includes headers for building programs with libvma's
50  interfaces.
51  
52  %package utils
53  Summary: Libvma utilities
54  Requires: %{name}%{?_isa} = %{version}-%{release}
55  
56  %description utils
57  This package contains the tool vma_stats for collecting and
58  analyzing Libvma statistic.
59  
60  %prep
61  %setup -q
62  
63  %build
64  export revision=1
65  [ -f configure ] || ./autogen.sh

Maybe, we should remove the test of file configure . As automake, autoconf
and libtool are required as BuildRequires.

66  
67  # Debug binary with extra output verbosity
68  %if "%{use_extralib}" == "1"
69  %configure --enable-opt-log=none \
70 %{?configure_options}
71  %{pmake}

please replace %{pmake} with %make_build

72  cp -f src/vma/.libs/%{name}.so %{name}-debug.so

It is better to replace 'cp' with 'install'. And it seems duplicated of line
95.

73  %{pmake} clean
please replace %{pmake} with %make_build


74  %endif
75  
76  # Primary installation set
77  %configure --docdir=%{_docdir}/%{name}-%{version} \
  ^^
Please don't install doc in versioned dir. See 
https://fedoraproject.org//wiki/Changes/UnversionedDocdirs


78 %{?configure_options}
79  %{pmake}
please replace %{pmake} with %make_build
80  
81  %install
82  mkdir -p $RPM_BUILD_ROOT%{_includedir}/mellanox
83  mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}
84  mkdir -p $RPM_BUILD_ROOT%{_libdir}

line 83 and 84 is redundance, should be removed.

85  
86  %{pmake} DESTDIR=${RPM_BUILD_ROOT} install
87  
88  rm -f $RPM_BUILD_ROOT%{_libdir}/*.la

find $RPM_BUILD_ROOT -f -name '*.la' -delete

89  
90  install -m 644 src/vma/vma_extra.h
$RPM_BUILD_ROOT/%{_includedir}/mellanox/vma_extra.h
91  install -m 644 src/vma/util/libvma.conf $RPM_BUILD_ROOT/%{_sysconfdir}/
92  install -s -m 755 src/stats/vma_stats
$RPM_BUILD_ROOT/%{_bindir}/vma_stats
93  install -s -m 755 tools/daemon/vmad $RPM_BUILD_ROOT/%{_sbindir}/vmad
94  %if "%{use_extralib}" == "1"
95  install -m 755 ./

[Bug 1833473] Review Request: ocaml-ppxlib - Base library and tools for ppx rewriters

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1833473



--- Comment #7 from Jerry James  ---
Thank you for the review!

(In reply to Richard W.M. Jones from comment #3)
> Manual inspection of the spec file shows that it looks sensible.  Literally
> the only thing I could nitpick is that it would be nice to know if the two
> patches are upstream/going upstream/never upstream.

I would like to know that myself.  Well, upstream is aware of both issues and
will hopefully take action at some point.

(In reply to Richard W.M. Jones from comment #5)
> rjones: f-r says the package doesn't install, but I was able
> to install it just fine locally so I think we can ignore this.

Hmmm, the same thing happened when I did the review for you.  I just installed
manually and fixed up the report.  Apparently fedora-review is having issues
with installing.  I'll try to squeeze out some time to look into that.

> rjones: licensecheck is all over the place here, but most files lack
> any license information in the file.  It seems as if upstream intend
> this to be some kind of MIT license.  It would be good to encourage
> upstream to add a license to every file.

Okay, I'll talk to upstream about it.

> rjones: licensecheck is wrong here.  I manually checked the license
> and it is correct.

licensecheck always calls MIT-licensed files "Expat".  They're basically the
same license, so I guess that's okay, but it can be confusing.

> Ocaml:
> [x]: This should never happen
> 
> rjones: ?

That seems to come from /usr/share/fedora-review/plugins/ocaml.py, which says:

class OcamlCheckStaticLibs(OcamlCheckBase):
""" Disable static lib checking, ocaml has an exception. """

def __init__(self, checks):
OcamlCheckBase.__init__(self, checks)
self.automatic = True
self.text = "This should never happen"
self.deprecates.append("CheckStaticLibs")

def run_on_applicable(self):
self.set_passed(self.PASS)

I don't know "This should never happen" winds up in the report, though.

> rjones: I built it using rpmbuild.  It doesn't build in _my_ mock but
> it seems to be because my local mock is broken in some way.

FWIW, it builds fine in mock on my system.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835458] Review Request: recapp - User friendly Open Source screencaster for Linux written in GTK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835458



--- Comment #8 from Fedora Update System  ---
FEDORA-2020-687e4caaef has been submitted as an update to Fedora 30.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-687e4caaef


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1826621] Review Request: RMD - Resource Manager Deamon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1826621

Neil Horman  changed:

   What|Removed |Added

  Flags||needinfo?(arunprabhu.vijaya
   ||n...@intel.com)



--- Comment #12 from Neil Horman  ---
Thank you for your quick reply. In response:

>[Arun] 
>1. Sure. We will add all packages present in fedora as BuildRequires and drop 
>from go.mod file & other packages as bundled exception in go.mod file.
Perfect, thank you!
>2. We will also add BuildRequires : git-core & BuildRequires : go-rpm-macros. 
Excellent

>Note: In my fedora machine,am getting this error if I add go-rpm-macros. Can 
>you please let me why I'm getting this error?
>
>[root]# dnf install go-rpm-macros
>Last metadata expiration check: 3:07:12 ago on Wed 13 May 2020 00:52:11 IST.
>No match for argument: go-rpm-macros
>Error: Unable to find a match: go-rpm-macros
Hmm...odd, what Fedora release are you running on?  I managed to install it on
my F32 system just fine.  I wonder if you're using an older fedora release that
doesn't have those macros packaged yet?

>> >1.rmd.x86_64: W: pem-certificate /usr/local/etc/rmd/acl/roles/admin/cert.pem
>> >This is not fixed as these files are only used for testing.
>> I'm not sure I follow here.  What testing are you referring to?  I don't see
>> any %check script in your spec file, so I'm not sure what testing you are
>> doing.  As such, why not just not package the pem certificates at all?

>[Arun] PEM certificates can be used as reference by System Admin to configure. 
>So, it is more like reference files or fast and easy check of functionality.. 
>Sorry for mentioning it as used for testing >purposes.
>https://github.com/intel/rmd/blob/master/etc/rmd/rmd.toml  has reference usage 
>in [default] section. Please refer to it.
Hmm, ok, I see the need, but I'll need to check a little bit on what the policy
is here.  I would hate to have people use this with a default certificate in
your name.  I expect we can mark those in the file manafest with a %conf, and
make a note in the documentation and the config file that production systems
should generate their own cert, but I'll check and confirm.

>> >2. Below error is not fixed as our SW needs to copy config files to 
>> >/usr/local/etc/
>> > rmd.x86_64: E: dir-or-file-in-usr-local /usr/local/etc/rmd/policy.toml
>> >A file in the package is located in /usr/local. It's not permitted for
>> >packages to install files in this directory.
>> >Added exception in rpmlint --> addFilter("E: dir-or-file-in-usr-local") in 
>> >/etc/rpmlint/config
>> Why?  It looks to me like the rmd utility allows you to specify the location
>> of a config file on the command line, so I don't understand why the config
>> files can't be placed in the appropriate directory (%_sysconfdir}/etc) here.
>> Note also that, if you add a systemd unit file as noted in comment 5, you
>> can set the config directory there without having to modify the source
>> defaults.

>[Arun] If all config files need to be moved to /etc/, we will move them from 
>/usr/local/etc/ folder. We also have some install related scripts which needs 
>to be moved from /usr/local/etc/rmd to /etc/rmd. >Please let us know if it is 
>OK?
Yes, that is exactly correct.  You are completely permitted to create
subdirectories under /etc to store your config files in, it just all needs to
be rooted in /etc (or more specifically %{_sysconfdir}, which currently expands
to /etc)

>> The review of the package itself looks ok, though you didn't address the
>> following items from comment 5:
>> [!]: %config files are marked noreplace or the reason is justified.
>>  Note: No (noreplace) in %config(missingok) /usr/bin/scripts
>>  %config(missingok) /usr/bin/etc>
>
>[Arun] This was removed from the latest spec file as we corrected in the spec 
>file by installing directly from the SPEC file in the correct path instead of 
>running script from /usr/bin directory which will >copy these files to 
>/usr/local/etc/. 
Understood, thank you!

>> [!]: Package contains systemd file(s) if in need.  <= you probably want to
>> add a systemd unit to start rmd
>
>[Arun] We will discuss internally and get back if its needed to keep the 
>systemd file for this release.
I'm sorry, I'm not sure I understand.  I didn't see a systemd unit file
previously (hence the error).  I presume you want to run rmd as a daemon,
correct?  If so, I would strongly recommend that you add one, so you have a
good user experience when the package is installed.


>> [!]: Package is not known to require an ExcludeArch tag. <= It should be
>> buildable on non-x86 platforms, you either need to allow that, or document
>> the fact that rmd only operates on data found in x86 systems
>> 
>[Arun] RMD addresses Resource Management for Intel X86 architectures. HW 
>support is documented in 
>

[Bug 1835458] Review Request: recapp - User friendly Open Source screencaster for Linux written in GTK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835458



--- Comment #7 from Fedora Update System  ---
FEDORA-2020-09b8e00ab3 has been submitted as an update to Fedora 31.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-09b8e00ab3


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834964] Review Request: honggfuzz - General-purpose, easy-to-use fuzzer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834964

Jerry James  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #10 from Jerry James  ---
Looks good.  This package is APPROVED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835458] Review Request: recapp - User friendly Open Source screencaster for Linux written in GTK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835458

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #6 from Fedora Update System  ---
FEDORA-2020-c598d11bbb has been submitted as an update to Fedora 32.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-c598d11bbb


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835458] Review Request: recapp - User friendly Open Source screencaster for Linux written in GTK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835458



--- Comment #5 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/recapp


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834964] Review Request: honggfuzz - General-purpose, easy-to-use fuzzer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834964



--- Comment #9 from Richard W.M. Jones  ---
Spec URL: http://oirase.annexia.org/reviews/honggfuzz/honggfuzz.spec
SRPM URL:
http://oirase.annexia.org/reviews/honggfuzz/honggfuzz-2.2-0.1.20200511gita299f3f.fc33.src.rpm
Description: General-purpose, easy-to-use fuzzer
Fedora Account System Username: rjones

I believe this fixes all items revealed by the review.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834731



--- Comment #3 from Oleg Girko  ---
I was packaging a Dash client for Fedora for quite some time. Dash was
originally a fork of Bitcoin, and now it still synchronises its codebase with
newer versions of Bitcoin. Hence, Dash is not different than Bitcoin from
packaging point of view, only some file names and TCP port numbers are
different.
You can take a look at spec and other files I use to build Dash here:
https://obs.infoserver.lv/package/show/cryptocurrency/dash-core
If you find any ideas from this useful, feel free to use them. :-)

My spec file was originally based on spec file that was in Bitcoin source's
contrib subdirectory (it was removed from there since then), but significantly
evolved.

It has provisions for building with depends system, making deterministic build
closer to the one used for binary distribution by vendor (but not exactly the
same: still using compiler and some system libraries from Fedora). In order to
be suitable for building in isolated environment without network connectivity,
all sources needed for building are added as "SourceN:" directives in
autogenerated section of spec file, and "update-sources.sh" script has to be
run to update these sources every time you change the version number. This
feature is not suitable for official Fedora package because it essentially
bundles various libraries, so it's disabled by default.

Also, functional tests in "%check" section are run in parallel, and temporary
directory is placed in "/var/tmp" for them, because "/tmp" is sometimes tmpfs
in isolated build environment. and some tests require 8 gigabytes of space in
tmpdir.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834964] Review Request: honggfuzz - General-purpose, easy-to-use fuzzer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834964



--- Comment #8 from Richard W.M. Jones  ---
Here's the upstream lzma issue:
https://github.com/google/honggfuzz/issues/332

> honggfuzz.src: W: strange-permission generate-tarball.sh 775
> Maybe it wants the permission to be 755?

Yes that fixed it.

> [!]: %check is present and all tests pass.

This is a "should" item, but in any case I've checked upstream
again and I can't see any tests.  In AFL I made up a simple %check
section:

https://src.fedoraproject.org/rpms/american-fuzzy-lop/blob/master/f/american-fuzzy-lop.spec#_156

so I'll add something similar for this one.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835458] Review Request: recapp - User friendly Open Source screencaster for Linux written in GTK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835458



--- Comment #4 from Artem  ---
Thanks a lot!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835458] Review Request: recapp - User friendly Open Source screencaster for Linux written in GTK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835458

Vasiliy Glazov  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Vasiliy Glazov  ---
Approved.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "GPL (v3 or later)". 26 files have
 unknown license. Detailed output of licensecheck in
 /home/vascom/1835458-recapp/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
 publishes signatures.
 Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.

[Bug 1835458] Review Request: recapp - User friendly Open Source screencaster for Linux written in GTK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835458



--- Comment #2 from Artem  ---
https://download.copr.fedorainfracloud.org/results/atim/rec-app/fedora-32-x86_64/01382164-recapp/recapp.spec

https://download.copr.fedorainfracloud.org/results/atim/rec-app/fedora-32-x86_64/01382164-recapp/recapp-1.0.1-2.fc32.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835458] Review Request: recapp - User friendly Open Source screencaster for Linux written in GTK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835458

Vasiliy Glazov  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||vasc...@gmail.com
   Assignee|nob...@fedoraproject.org|vasc...@gmail.com
   Doc Type|--- |If docs needed, set a value
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835458] New: Review Request: recapp - User friendly Open Source screencaster for Linux written in GTK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835458

Bug ID: 1835458
   Summary: Review Request: recapp - User friendly Open Source
screencaster for Linux written in GTK
   Product: Fedora
   Version: rawhide
Status: NEW
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: ego.corda...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://atim.fedorapeople.org//recapp.spec
SRPM URL: https://atim.fedorapeople.org//recapp-1.0.1-1.fc32.src.rpm

Description:
User friendly Open Source screencaster for Linux written in GTK. Using free
GStreamer modules and not depend on FFmpeg.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835458] Review Request: recapp - User friendly Open Source screencaster for Linux written in GTK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835458



--- Comment #1 from Artem  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=44462901


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834964] Review Request: honggfuzz - General-purpose, easy-to-use fuzzer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834964



--- Comment #7 from Jerry James  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

= Issues =

- Remove "rm -rf $RPM_BUILD_ROOT" from the start of %install.  See bullet 3:
  https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

- Add %{?_isa} to the devel subpackage R on the main package; i.e.,
  Requires:  %{name}%{?_isa} = %{version}-%{release}
  See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package

- After making you add a BR on xz-devel to satisfy -llzma passed to the linker
  by the Makefile, it turns out that liblzma is not actually needed by
anything.
  If you wish to trim the BRs back down, you can remove -llzma from Makefile.

- See the incoherent-version-in-changelog warning from rpmlint.  The most
recent
  changelog entry should read:
  * Tue May 12 2020 Richard W.M. Jones 
2.2-0.1.20200511gita299f3f

- This is a non-issue: rpmlint issues a missing-call-to-setgroups-before-setuid
  warning due to the call to setresuid in nsEnter (libhfcommon/ns.c).  The code
  is actually okay, but is written in a way that rpmlint does not understand.

- Rpmlint says:
  honggfuzz.src: W: strange-permission generate-tarball.sh 775
  Maybe it wants the permission to be 755?

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
 BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "Apache License 2.0", "*No copyright*
 Apache License 2.0". 12953 files have unknown license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
 It does in fact require an ExcludeArch tag, and has it.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 61440 bytes in 7 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the 

[Bug 1835452] New: Review Request: mlxbf-bootctl - Bootloader control for Mellanox BlueField

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835452

Bug ID: 1835452
   Summary: Review Request: mlxbf-bootctl - Bootloader control for
Mellanox BlueField
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: spen...@mellanox.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://download.copr.fedorainfracloud.org/results/slingard/mlxbf-bootctl/fedora-rawhide-aarch64/01381236-mlxbf-bootctl/mlxbf-bootctl.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/slingard/mlxbf-bootctl/fedora-rawhide-aarch64/01381236-mlxbf-bootctl/mlxbf-bootctl-1.1-3.fc33.src.rpm
Scratch Koji URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=44462386
Source Repository: https://github.com/Mellanox/mlxbf-bootctl
Fedora Account System Username: slingard

Description: This program controls bootloader features on Mellanox BlueField
hardware, such as installing UEFI/ATF to the chip, activating watchdog timers,
and which of the redundant bootloader partitions is active.

Note: This is my first package, and require a sponsor.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835263] Review Request: perl-Crypt-PWSafe3 - Read and write Passwordsafe v3 files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835263



--- Comment #3 from Charles R. Anderson  ---
License: Artistic 2.0

License statement from README and all the files in the source distribution:

COPYRIGHT
   Crypt::PWSafe3
   Copyright (c) 2011-2016 by T.v.Dein 

LICENSE

   This program is free software; you can redistribute it
   and/or modify it under the same terms of the Artistic
   License 2.0, see: L


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835258] Review Request: perl-Crypt-ECB - Encrypt Data using ECB Mode

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835258



--- Comment #2 from Charles R. Anderson  ---
License statement from the README in the source distribution:

COPYING

Crypt-ECB is Copyright (C) 2000, 2005, 2008, 2016 by Christoph Appel.

This module is distributed using the same terms as Perl itself. It is free
software; you can redistribute it and/or modify it under the terms of either:

a) the GNU General Public License as published by the Free Software
Foundation; either version 1, or (at your option) any later version, or

b) the "Artistic License".


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1822971] Review Request: notcurses - character graphics and TUI library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1822971

Nick Black  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2020-05-13 18:38:44



--- Comment #51 from Nick Black  ---
https://src.fedoraproject.org/rpms/notcurses/c/665f391c097e8106769f3caa46adee02e9b2b50f?branch=master

Checked in. Closing. Thanks everybody!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835421] Review Request: python-sgmllib3k - Py3k port of sgmllib

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835421

Luis Bazan  changed:

   What|Removed |Added

  Alias||python-sgmllib3k




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835421] New: Review Request: python-sgmllib3k - Py3k port of sgmllib

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835421

Bug ID: 1835421
   Summary: Review Request: python-sgmllib3k - Py3k port of
sgmllib
   Product: Fedora
   Version: rawhide
Status: NEW
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: bazanlui...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Hi team
FAS:lbazan

Description:
sgmllib3k -- Py3k port of the old stdlib module sgmllib was dropped in Python
3. For those depending on it, that's somewhat infortunate. This is a quick and
dirty port of this old module. I just ran 2to3 on it and published it. I don't
indend to maintain it, so it might be a good idea to eventually think about
finding another module to use.

SPEC:https://lbazan.fedorapeople.org/python-sgmllib3k.spec
SRPM:https://lbazan.fedorapeople.org/python-sgmllib3k-1.0.0-1.fc32.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835421] Review Request: python-sgmllib3k - Py3k port of sgmllib

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835421

Luis Bazan  changed:

   What|Removed |Added

 Blocks||1831883
   Doc Type|--- |If docs needed, set a value





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1831883
[Bug 1831883] Can't update archmage-0.3.1-4 to 0.4.2.1-1
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1821393] Review Request: pagure-cli - Pagure client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1821393



--- Comment #8 from Fedora Update System  ---
FEDORA-2020-d9b35f39b2 has been submitted as an update to Fedora 31.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-d9b35f39b2


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835142] Review Request: rust-feed-rs - Simple feed parser (RSS 2.0, ATOM, RSS 1.0)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835142

Igor Raits  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2020-05-13 18:02:49




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1822971] Review Request: notcurses - character graphics and TUI library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1822971



--- Comment #50 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/notcurses


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1821393] Review Request: pagure-cli - Pagure client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1821393



--- Comment #7 from Fedora Update System  ---
FEDORA-2020-58665e3dee has been submitted as an update to Fedora 32.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-58665e3dee


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835142] Review Request: rust-feed-rs - Simple feed parser (RSS 2.0, ATOM, RSS 1.0)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835142



--- Comment #2 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-feed-rs


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835367] Review Request: python-chm - Python package for CHM files handling

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835367

Luis Bazan  changed:

   What|Removed |Added

  Alias||python-chm
   Doc Type|--- |If docs needed, set a value




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835367] Review Request: python-chm - Python package for CHM files handling

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835367

Luis Bazan  changed:

   What|Removed |Added

 Blocks||1831883





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1831883
[Bug 1831883] Can't update archmage-0.3.1-4 to 0.4.2.1-1
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835142] Review Request: rust-feed-rs - Simple feed parser (RSS 2.0, ATOM, RSS 1.0)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835142

Neal Gompa  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
   Doc Type|--- |If docs needed, set a value
  Flags||fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835367] New: Review Request: python-chm - Python package for CHM files handling

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835367

Bug ID: 1835367
   Summary: Review Request: python-chm - Python package for CHM
files handling
   Product: Fedora
   Version: rawhide
Status: NEW
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: bazanlui...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Hi team 

We need unretire this packages in rawhide and f32.
FAS: lbazan

Description:
The python chm package provides three modules, chm, chmlib and extra,\
which provide access to the API implemented by the C library chmlib\
and some additional classes and functions. They are used to access\
MS-ITSS encoded files - Compressed Html Help files (.chm).

SPEC: https://lbazan.fedorapeople.org/python-chm.spec
SRPM: https://lbazan.fedorapeople.org/python-chm-0.8.6-1.fc32.src.rpm

Cheers,


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1823117] Review Request: opensurge - 2D retro platformer inspired by Sonic games

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1823117



--- Comment #17 from Artur Iwicki  ---
Thanks, Tom.

My mind is playing tricks on me now, as I can swear I've seen something like
"don't use intermediaries like Google Fonts and use upstream sources" in the
Fonts Packaging policy, but I can't find it now - and looking at the git
history, there newer was anything like that in the document. I'll get around to
packaging the font somewhen over the weekend.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835350] Review Request: openjfx8 - Rich client application platform for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835350

Nicolas De Amicis  changed:

   What|Removed |Added

Comment|0   |updated



--- Comment #0 has been edited ---

Spec URL: https://deamn.fedorapeople.org/openjfx8.spec
SRPM URL: https://deamn.fedorapeople.org/openjfx8-8.0.202-20.b07.fc32.src.rpm
Description: JavaFX/OpenJFX is a set of graphics and media APIs that enables
Java
developers to design, create, test, debug, and deploy rich client
applications that operate consistently across diverse platforms.
The media and web module have been removed due to missing dependencies.

It's the same package that openjfx. I create this PR because I would use the
package openjfx for openjfx 11 and future LTS version and create a specific
package for openjfx8. Please see
https://bugzilla.redhat.com/show_bug.cgi?id=1801580
Fedora Account System Username: deamn

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835350] New: Review Request: openjfx8 - Rich client application platform for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835350

Bug ID: 1835350
   Summary: Review Request: openjfx8 - Rich client application
platform for Java
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: deami...@bluewin.ch
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://deamn.fedorapeople.org/openjfx8.spec
SRPM URL: https://deamn.fedorapeople.org/openjfx8-8.0.202-20.b07.fc32.src.rpm
Description: JavaFX/OpenJFX is a set of graphics and media APIs that enables
Java
developers to design, create, test, debug, and deploy rich client
applications that operate consistently across diverse platforms.
The media and web module have been removed due to missing dependencies.

It's the same package that openjfx. I create this PR because I would use the
package openjfx for openjfx 11 and future LTS version and create a specific
package for openjfx8. Please see
https://bugzilla.redhat.com/show_bug.cgi?id=1801580
Fedora Account System Username: deamn


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1823117] Review Request: opensurge - 2D retro platformer inspired by Sonic games

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1823117



--- Comment #16 from Antonio T. (sagitter)  ---
Thank you very much Tom.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835340] New: Review Request: python-pytest-black - A pytest plugin to enable format checking with black

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835340

Bug ID: 1835340
   Summary: Review Request: python-pytest-black - A pytest plugin
to enable format checking with black
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: cstra...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://cstratak.fedorapeople.org/python-pytest-black.spec

SRPM URL:
https://cstratak.fedorapeople.org/python-pytest-black-0.3.9-1.fc31.src.rpm

Description: A pytest plugin to enable format checking with black

Fedora Account System Username: cstratak


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835340] Review Request: python-pytest-black - A pytest plugin to enable format checking with black

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835340

Charalampos Stratakis  changed:

   What|Removed |Added

 Blocks||1755042





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1755042
[Bug 1755042] python-twine-3.1.1 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1829070] Review Request: multiwatch - Forks and watches multiple instances of a program in the same context

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1829070



--- Comment #8 from Fedora Update System  ---
FEDORA-2020-6aa8872251 has been submitted as an update to Fedora 32.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-6aa8872251


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1829070] Review Request: multiwatch - Forks and watches multiple instances of a program in the same context

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1829070



--- Comment #7 from Fedora Update System  ---
FEDORA-2020-6dc849e66d has been submitted as an update to Fedora 31.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-6dc849e66d


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1829070] Review Request: multiwatch - Forks and watches multiple instances of a program in the same context

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1829070

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



--- Comment #6 from Fedora Update System  ---
FEDORA-EPEL-2020-cfef250ad5 has been submitted as an update to Fedora EPEL 8.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-cfef250ad5


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835323] Review Request: python-tox-venv - Use Python 3 venvs for Python 3 tox testenvs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835323

Charalampos Stratakis  changed:

   What|Removed |Added

 Blocks||1755042





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1755042
[Bug 1755042] python-twine-3.1.1 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835323] New: Review Request: python-tox-venv - Use Python 3 venvs for Python 3 tox testenvs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835323

Bug ID: 1835323
   Summary: Review Request: python-tox-venv - Use Python 3 venvs
for Python 3 tox testenvs
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: cstra...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://cstratak.fedorapeople.org/python-tox-venv.spec

SRPM URL:
https://cstratak.fedorapeople.org/python-tox-venv-0.4.0-1.20200513git3bdcc27.fc31.src.rpm

Description: tox-venv is a plugin that uses Python 3’s builtin venv module for
creating
test environments, instead of creating them with the virtualenv package.

Fedora Account System Username: cstratak


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835192] Review Request: rust-tiger-digest - Tiger implementation following the Rust Digest Traits

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835192

Igor Raits  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2020-05-13 15:17:13




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835113] Review Request: rust-color-backtrace - Colorful panic backtraces

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835113

Igor Raits  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2020-05-13 15:17:34




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1829070] Review Request: multiwatch - Forks and watches multiple instances of a program in the same context

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1829070



--- Comment #4 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/multiwatch


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835143] Review Request: rust-debug-helper - Declarative macros to help you implement the `Debug` trait manually

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835143

Igor Raits  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2020-05-13 15:16:47




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834905] Review Request: rust-dotenv - `dotenv` implementation for Rust

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834905

Igor Raits  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2020-05-13 15:16:19




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834884] Review Request: rust-javascriptcore-rs-sys - Sys functions for the Rust bindings of the javacriptcore library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834884

Igor Raits  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2020-05-13 15:15:34




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834885] Review Request: rust-peresil - Simple and simplistic string parsing library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834885

Igor Raits  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2020-05-13 15:15:55




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834882] Review Request: rust-log-mdc - Mapped diagnostic context (MDC) for use with the `log` crate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834882

Igor Raits  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2020-05-13 15:15:11




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834868] Review Request: rust-serde-value - Serialization value trees

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834868

Igor Raits  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2020-05-13 15:14:49




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834902] Review Request: rust-diesel_derives - Internal crate to Diesel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834902

Igor Raits  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2020-05-13 15:14:17




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834894] Review Request: rust-feedly_api - Rust implementation of the feedly REST API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834894

Igor Raits  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2020-05-13 15:13:09




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834879] Review Request: rust-escaper - Library for HTML entity encoding and decoding

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834879

Igor Raits  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2020-05-13 15:13:31




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834872] Review Request: rust-rust-embed-utils - Utilities for rust-embed

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834872

Igor Raits  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2020-05-13 15:13:53




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1830306] Review Request: git-revise - Efficiently update, split, and rearrange git commits

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1830306



--- Comment #3 from Ian McInerney  ---
Updated spec file:
https://download.copr.fedorainfracloud.org/results/imcinerney/git-revise/fedora-32-x86_64/01381895-git-revise/git-revise.spec
Updated SRPM:
https://download.copr.fedorainfracloud.org/results/imcinerney/git-revise/fedora-32-x86_64/01381895-git-revise/git-revise-0.5.1-2.fc32.src.rpm

> The checksum of the tarball in the SRPM and upstream doesn't match. Please 
> make sure the SRPM is updated.

Apparently it was still using the PyPi version that I initially made the spec
using (but then modified to use the non-PyPi version). Fixed now.

> You might want to rename the tarball using the Source URL as:  
> https://github.com/mystor/git-revise/archive/%{version}/%{name}-%{version}.tar.gz
  but that's up to you.

Fixed.

> Why does it require setuptools? It should be a BuildRequires only.

That was added in by the pypi2rpm generator when I first ran it, so I guess it
thought it was needed. I agree, it shouldn't be there though.

> Please, open a bug report upstream with the included patch and reference it 
> in the spec file.

Done.

> This should also be "BuildArch: noarch", which will remove the need for 
> disabling debuginfo subpackage.

I already had it as noarch in the spec, it's just I was concerned by the line
+ /usr/lib/rpm/find-debuginfo.sh -j12 --strict-build-id -m -i
--build-id-seed 0.5.1-2.fc32 --unique-debug-suffix -0.5.1-2.fc32.x86_64
--unique-debug-src-base git-revise-0.5.1-2.fc32.x86_64 --run-dwz
--dwz-low-mem-die-limit 1000 --dwz-max-die-limit 11000 -S
debugsourcefiles.list /builddir/build/BUILD/git-revise-0.5.1
find: 'debug': No such file or directory" when running a mock build.
I have removed that line now.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835302] Review Request: nodejs-pg-protocol - The postgres client/server binary protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835302



--- Comment #1 from Tom Hughes  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=44450368


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835302] Review Request: nodejs-pg-protocol - The postgres client/server binary protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835302

Tom Hughes  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews),
   ||1835288
   Doc Type|--- |If docs needed, set a value





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1835288
[Bug 1835288] nodejs-pg-8.2.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835302] New: Review Request: nodejs-pg-protocol - The postgres client/server binary protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835302

Bug ID: 1835302
   Summary: Review Request: nodejs-pg-protocol - The postgres
client/server binary protocol
   Product: Fedora
   Version: rawhide
Status: NEW
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: t...@compton.nu
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://tomh.fedorapeople.org//nodejs-pg-protocol.spec
SRPM URL:
https://tomh.fedorapeople.org//nodejs-pg-protocol-1.2.3-1.fc32.src.rpm

Description:
The postgres client/server binary protocol, implemented in TypeScript.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835239] Review Request: kiwi-boxed-plugin - KIWI - Boxed Build Plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835239



--- Comment #2 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/kiwi-boxed-plugin


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835192] Review Request: rust-tiger-digest - Tiger implementation following the Rust Digest Traits

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835192



--- Comment #2 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-tiger-digest


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835113] Review Request: rust-color-backtrace - Colorful panic backtraces

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835113



--- Comment #2 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-color-backtrace


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835143] Review Request: rust-debug-helper - Declarative macros to help you implement the `Debug` trait manually

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835143



--- Comment #2 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-debug-helper


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834905] Review Request: rust-dotenv - `dotenv` implementation for Rust

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834905



--- Comment #5 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-dotenv


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834885] Review Request: rust-peresil - Simple and simplistic string parsing library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834885



--- Comment #2 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-peresil


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834868] Review Request: rust-serde-value - Serialization value trees

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834868



--- Comment #2 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-serde-value


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834902] Review Request: rust-diesel_derives - Internal crate to Diesel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834902



--- Comment #3 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-diesel_derives


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834884] Review Request: rust-javascriptcore-rs-sys - Sys functions for the Rust bindings of the javacriptcore library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834884



--- Comment #2 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-javascriptcore-rs-sys


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834872] Review Request: rust-rust-embed-utils - Utilities for rust-embed

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834872



--- Comment #2 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-rust-embed-utils


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834879] Review Request: rust-escaper - Library for HTML entity encoding and decoding

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834879



--- Comment #2 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-escaper


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1823117] Review Request: opensurge - 2D retro platformer inspired by Sonic games

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1823117

Tom "spot" Callaway  changed:

   What|Removed |Added

 CC||tcall...@redhat.com
 Blocks|182235 (FE-Legal)   |



--- Comment #15 from Tom "spot" Callaway  ---
Hi folks. The font in question here is the Gothic A1 font family, produced by
the HanYang I&C Co font foundry.

As noted, this font is listed on Google Fonts as being under the SIL Open Font
License (henceforth referred to as OFL):
https://fonts.google.com/specimen/Gothic+A1

When we look at the font files themselves (I looked at Google's copy), we see
in the font metadata that the License is marked as:

License (English US): This Font Software is licensed under the SIL Open Font
License, Version 1.1. This license is available with a FAQ at:
http://scripts.sil.org/OFL

I happen to know the maintainer for Google Fonts and I confirmed with him that
this licensing is correct, as they worked directly with the font foundry to get
this font under this license. :)

Lifting FE-Legal



Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834863] Review Request: rust-libxml - Rust wrapper for libxml2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834863



--- Comment #3 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-libxml


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834894] Review Request: rust-feedly_api - Rust implementation of the feedly REST API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834894



--- Comment #2 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-feedly_api


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835113] Review Request: rust-color-backtrace - Colorful panic backtraces

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835113

Neal Gompa  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
   Doc Type|--- |If docs needed, set a value
  Flags||fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835192] Review Request: rust-tiger-digest - Tiger implementation following the Rust Digest Traits

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835192

Neal Gompa  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
   Doc Type|--- |If docs needed, set a value
  Flags||fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835143] Review Request: rust-debug-helper - Declarative macros to help you implement the `Debug` trait manually

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835143

Neal Gompa  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
   Doc Type|--- |If docs needed, set a value
  Flags||fedora-review+



--- Comment #1 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1834905] Review Request: rust-dotenv - `dotenv` implementation for Rust

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1834905

Neal Gompa  changed:

   What|Removed |Added

 Status|NEW |POST
  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Neal Gompa  ---
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- only sources installed

PACKAGE APPROVED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835239] Review Request: kiwi-boxed-plugin - KIWI - Boxed Build Plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835239

Igor Raits  changed:

   What|Removed |Added

 Status|NEW |POST
  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Igor Raits  ---
> # Enable Python dependency generation
> %{?python_enable_dependency_generator}
This is not necessary for any supported Fedora targets or EPEL8.

Other than that, everything is fine.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1835239] Review Request: kiwi-boxed-plugin - KIWI - Boxed Build Plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1835239

Igor Raits  changed:

   What|Removed |Added

 CC||igor.ra...@gmail.com
   Assignee|nob...@fedoraproject.org|igor.ra...@gmail.com
   Doc Type|--- |If docs needed, set a value
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org