[Bug 1834947] Review Request: rust-desed - sed script debugger
https://bugzilla.redhat.com/show_bug.cgi?id=1834947 --- Comment #10 from Fedora Update System --- FEDORA-2020-6d9330c5d6 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-6d9330c5d6` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-6d9330c5d6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1834947] Review Request: rust-desed - sed script debugger
https://bugzilla.redhat.com/show_bug.cgi?id=1834947 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- FEDORA-2020-f0df69576c has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-f0df69576c` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f0df69576c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824348] Review Request: bowtie2 - A read aligner for genome sequencing
https://bugzilla.redhat.com/show_bug.cgi?id=1824348 --- Comment #25 from Fedora Update System --- FEDORA-2020-c540172327 has been pushed to the Fedora 30 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830323] Review Request: gap-pkg-images - Minimal and canonical images in permutation groups
https://bugzilla.redhat.com/show_bug.cgi?id=1830323 Bug 1830323 depends on bug 1830322, which changed state. Bug 1830322 Summary: Review Request: gap-pkg-ferret - Backtracking search in permutation groups https://bugzilla.redhat.com/show_bug.cgi?id=1830322 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830322] Review Request: gap-pkg-ferret - Backtracking search in permutation groups
https://bugzilla.redhat.com/show_bug.cgi?id=1830322 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-05-16 03:39:14 --- Comment #9 from Fedora Update System --- FEDORA-2020-d484f75f5c has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828079] Review Request: jneuroml-core - The NeuroML 2 Schema and ComponentType definitions in LEMS
https://bugzilla.redhat.com/show_bug.cgi?id=1828079 --- Comment #10 from Fedora Update System --- FEDORA-2020-d80eb2cbc0 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824348] Review Request: bowtie2 - A read aligner for genome sequencing
https://bugzilla.redhat.com/show_bug.cgi?id=1824348 --- Comment #24 from Fedora Update System --- FEDORA-2020-a2ce0fa73b has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822509] Review Request: lavalauncher - a simple launcher for Wayland
https://bugzilla.redhat.com/show_bug.cgi?id=1822509 --- Comment #14 from Fedora Update System --- FEDORA-2020-436a359c2c has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1831981] Review Request: xdg-desktop-portal-wlr - xdg-desktop-portal backend for wlroots
https://bugzilla.redhat.com/show_bug.cgi?id=1831981 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-05-16 03:39:02 --- Comment #11 from Fedora Update System --- FEDORA-2020-770c779368 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827957] Review Request: python-sciunit - Framework for test-driven validation of scientific models
https://bugzilla.redhat.com/show_bug.cgi?id=1827957 --- Comment #11 from Fedora Update System --- FEDORA-2020-ccfa271e67 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822509] Review Request: lavalauncher - a simple launcher for Wayland
https://bugzilla.redhat.com/show_bug.cgi?id=1822509 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-05-16 03:10:43 --- Comment #13 from Fedora Update System --- FEDORA-2020-096560024d has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1828079] Review Request: jneuroml-core - The NeuroML 2 Schema and ComponentType definitions in LEMS
https://bugzilla.redhat.com/show_bug.cgi?id=1828079 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-05-16 03:10:41 --- Comment #9 from Fedora Update System --- FEDORA-2020-4872e40cf0 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824348] Review Request: bowtie2 - A read aligner for genome sequencing
https://bugzilla.redhat.com/show_bug.cgi?id=1824348 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-05-16 03:10:36 --- Comment #23 from Fedora Update System --- FEDORA-2020-fbd101aa06 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827957] Review Request: python-sciunit - Framework for test-driven validation of scientific models
https://bugzilla.redhat.com/show_bug.cgi?id=1827957 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-05-16 03:10:39 --- Comment #10 from Fedora Update System --- FEDORA-2020-4505478011 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836468] New: Review Request: rust-diesel_migrations - Migration management for diesel
https://bugzilla.redhat.com/show_bug.cgi?id=1836468 Bug ID: 1836468 Summary: Review Request: rust-diesel_migrations - Migration management for diesel Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: igor.ra...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-diesel_migrations.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-diesel_migrations-1.4.0-1.fc33.src.rpm Description: Migration management for diesel. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836286] Review Request: rust-migrations_macros - Codegeneration macros for diesels embedded migrations
https://bugzilla.redhat.com/show_bug.cgi?id=1836286 Igor Raits changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-05-16 02:49:16 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836341] Review Request: rust-rust-embed - Rust Custom Derive Macro which loads files into the rust binary
https://bugzilla.redhat.com/show_bug.cgi?id=1836341 Igor Raits changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-05-16 02:39:49 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836293] Review Request: rust-webkit2gtk-sys - Rust binding for webkit-gtk library
https://bugzilla.redhat.com/show_bug.cgi?id=1836293 Igor Raits changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-05-16 02:31:12 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836341] Review Request: rust-rust-embed - Rust Custom Derive Macro which loads files into the rust binary
https://bugzilla.redhat.com/show_bug.cgi?id=1836341 --- Comment #2 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rust-embed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836286] Review Request: rust-migrations_macros - Codegeneration macros for diesels embedded migrations
https://bugzilla.redhat.com/show_bug.cgi?id=1836286 --- Comment #2 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-migrations_macros -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836293] Review Request: rust-webkit2gtk-sys - Rust binding for webkit-gtk library
https://bugzilla.redhat.com/show_bug.cgi?id=1836293 --- Comment #2 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-webkit2gtk-sys -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1832632] Review Request: python-authres - RFC 8601 Authentication-Results Headers generation and parsing
https://bugzilla.redhat.com/show_bug.cgi?id=1832632
--- Comment #10 from Michel Alexandre Salim ---
Sorry for the delay! The package mostly looks good, but:
- please rename the spec to python-authres.spec - see
https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_spec_file_naming
- for %check, please don't hardcode python3:
python3 -m authres
should be
%{python3} -m authres
see: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 810049] Review Request: netbeans-ide - Netbeans Integrated Development Environment (IDE)
https://bugzilla.redhat.com/show_bug.cgi?id=810049 sandysharma changed: What|Removed |Added CC||sandysharma2...@gmail.com --- Comment #118 from sandysharma --- Tutorial Solutions. At the end of many NetBeans IDE tutorials, you usually create an application. Download a complete solution to the tutorial you are reading! https://www.rankdeckseo.in/ https://www.rankdeckseo.in/outsource-seo/ https://www.rankdeckseo.in/web-design-development-company/ https://www.rankdeckseo.in/seo-company-delhi/ https://www.rankdeckseo.in/seo-expert/ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836341] Review Request: rust-rust-embed - Rust Custom Derive Macro which loads files into the rust binary
https://bugzilla.redhat.com/show_bug.cgi?id=1836341 Neal Gompa changed: What|Removed |Added Status|NEW |POST CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Neal Gompa --- Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836286] Review Request: rust-migrations_macros - Codegeneration macros for diesels embedded migrations
https://bugzilla.redhat.com/show_bug.cgi?id=1836286 Neal Gompa changed: What|Removed |Added Status|NEW |POST CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Neal Gompa --- Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836293] Review Request: rust-webkit2gtk-sys - Rust binding for webkit-gtk library
https://bugzilla.redhat.com/show_bug.cgi?id=1836293 Neal Gompa changed: What|Removed |Added Status|NEW |POST CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Neal Gompa --- Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824848] Review Request: jc - JSONifies the output of dozens of commands
https://bugzilla.redhat.com/show_bug.cgi?id=1824848 --- Comment #28 from Kelly Brazil --- Thank you very much! Appreciate your guidance through this process. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824848] Review Request: jc - JSONifies the output of dozens of commands
https://bugzilla.redhat.com/show_bug.cgi?id=1824848 Artur Iwicki changed: What|Removed |Added Status|ASSIGNED|NEW CC||zebo...@gmail.com Assignee|fed...@svgames.pl |nob...@fedoraproject.org Flags|fedora-review? |fedora-review+ --- Comment #27 from Artur Iwicki --- Looks good to me! I'm marking the package as *approved*, though you'll still need to find a sponsor who will accept your Fedora Account into the "packagers" group. I'll take the liberty and page Robert-André Mauchin, who's a member of the "sponsors" group and who reviewed some of my Python packages in the past. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836341] New: Review Request: rust-rust-embed - Rust Custom Derive Macro which loads files into the rust binary
https://bugzilla.redhat.com/show_bug.cgi?id=1836341 Bug ID: 1836341 Summary: Review Request: rust-rust-embed - Rust Custom Derive Macro which loads files into the rust binary Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: igor.ra...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-rust-embed.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-rust-embed-5.5.1-1.fc33.src.rpm Description: Rust Custom Derive Macro which loads files into the rust binary at compile time during release and loads the file from the fs during dev. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1744132] Review Request: grafana-pcp - Performance Co-Pilot App for Grafana
https://bugzilla.redhat.com/show_bug.cgi?id=1744132 Andreas Gerstmayr changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |ERRATA Last Closed||2020-05-15 16:18:14 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822971] Review Request: notcurses - character graphics and TUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1822971 --- Comment #63 from Miro Hrončok --- > In that situation isn't the .egg-info not being a directory caught by this > line in %files... Yes it is. But not all packages use it :( -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836319] Review Request: hanyang-gothic-a1-fonts - Elegant Korean and Latin font family
https://bugzilla.redhat.com/show_bug.cgi?id=1836319 Artur Iwicki changed: What|Removed |Added Blocks||1823117 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1823117 [Bug 1823117] Review Request: opensurge - 2D retro platformer inspired by Sonic games -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823117] Review Request: opensurge - 2D retro platformer inspired by Sonic games
https://bugzilla.redhat.com/show_bug.cgi?id=1823117 Artur Iwicki changed: What|Removed |Added Depends On||1836319 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1836319 [Bug 1836319] Review Request: hanyang-gothic-a1-fonts - Elegant Korean and Latin font family -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836319] New: Review Request: hanyang-gothic-a1-fonts - Elegant Korean and Latin font family
https://bugzilla.redhat.com/show_bug.cgi?id=1836319
Bug ID: 1836319
Summary: Review Request: hanyang-gothic-a1-fonts - Elegant
Korean and Latin font family
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nob...@fedoraproject.org
Reporter: fed...@svgames.pl
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
spec:
https://svgames.pl/fedora/hanyang-gothic-a1-fonts-163840-1.20180313git16680f86/hanyang-gothic-a1-fonts.spec
srpm:
https://svgames.pl/fedora/hanyang-gothic-a1-fonts-163840-1.20180313git16680f86/hanyang-gothic-a1-fonts-163840-1.20180313git16680f86.fc32.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=44536203
Description: HanYang I&C Co's Gothic A1 is an elegant Korean and Latin font,
available in 9 weights.
Fedora Account System Username: suve
NOTE: The linked koji build fails. The package built fine on my F32 install. I
took a look at fonts-{,s}rpm-macros and noticed that the version in Rawhide is
3.0.3, while F32 has v2.0.3, so my guess is that it may be caused by some
changes to the macros. This is my first time packaging fonts, so any help will
be appreciated.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822971] Review Request: notcurses - character graphics and TUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1822971
--- Comment #62 from David Cantrell ---
In that situation isn't the .egg-info not being a directory caught by this line
in %files:
%{python3_sitearch}/*egg-info/
The trailing slash tells RPM that it expects that glob to be a directory. I
just tried it out locally where I did:
echo "testing file" > %{buildroot}%{python3_sitearch}/blurfle
And put this in %files:
%{python3_sitearch}/blurfle/
An 'rpmbuild -ba' gave me:
RPM build errors:
Not a directory:
/home/dcantrell/rpmbuild/BUILDROOT/notcurses-1.3.0-1.fc31.x86_64/usr/lib64/python3.7/site-packages/blurfle
With an exit code of 1.
We have both the recommendation for "BuildRequires: python3-setuptools" as well
as the %files entry for the egg-info directory in the Fedora packaging guide.
Even without setuptools as a BR, the %files entry still guards the build.
Good point and worth noting for other language ecosystems that have package
managers and module systems of their own.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836309] New: Review Request: ghc-time-manager - Scalable timer
https://bugzilla.redhat.com/show_bug.cgi?id=1836309 Bug ID: 1836309 Summary: Review Request: ghc-time-manager - Scalable timer Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: tdeca...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://tdecacqu.fedorapeople.org/reviews/ghc-time-manager/ghc-time-manager.spec SRPM URL: https://tdecacqu.fedorapeople.org/reviews/ghc-time-manager/ghc-time-manager-0.0.0-1.fc33.src.rpm Description: Scalable timer functions provided by a timer manager. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=44534647 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822971] Review Request: notcurses - character graphics and TUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1822971 --- Comment #61 from Miro Hrončok --- (In reply to David Cantrell from comment #60) > Regarding the hypothetical you described... I would actually rather see the > builds fail that did not explicitly list python3-setuptools. For several > reasons. First, it keeps package maintainers aware of overall dependency > changes (i.e., people building Python packages should probably be generally > aware of the Python packaging practices in effect). Second, it keeps the > project aware of what is actually still in use by users. A bunch of build > failures may cause some things to show up as just things we can safely > remove. Third, it presents package maintainers or other contributors with > opportunities to go and clean things up in spec files from time to time as > we continually revise and refine recommendations. That is very correct for situations where the missing dependency makes the package fail to build. In the setuptools case, we cannot do this, some Python projects have: try: from setuptools import setup except ImportError: from distutils.core import setup And as a result, when setuptools is present, the build succeeds and .egg-info is created as a directory (that's what setuptools does). When setuptools is not present, the build still succeeds, but .egg-info is created as a text file (that's what distutils does). When users upgrade to the newly built package, RPM fails with https://docs.fedoraproject.org/en-US/packaging-guidelines/Directory_Replacement/ So we will actually need to go and add the setuptools requirement to all packages that use setuptools in this way. Might be easier to add it to all packages that use setuptools in any way -- including this one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836293] New: Review Request: rust-webkit2gtk-sys - Rust binding for webkit-gtk library
https://bugzilla.redhat.com/show_bug.cgi?id=1836293 Bug ID: 1836293 Summary: Review Request: rust-webkit2gtk-sys - Rust binding for webkit-gtk library Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: igor.ra...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-webkit2gtk-sys.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-webkit2gtk-sys-0.11.0-1.fc33.src.rpm Description: Rust binding for webkit-gtk library. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822971] Review Request: notcurses - character graphics and TUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1822971 --- Comment #60 from David Cantrell --- (In reply to Miro Hrončok from comment #59) > > No amount of futureproofing here is going to avoid having to continue to > > maintain the spec file. > > Fair. I don't want to argue about this, I just assumed the dependency was > removed in error. Sorry, I'm not trying to argue. Was not removed in error, just my standard practice of keeping BuildRequires lists short. Regarding the hypothetical you described... I would actually rather see the builds fail that did not explicitly list python3-setuptools. For several reasons. First, it keeps package maintainers aware of overall dependency changes (i.e., people building Python packages should probably be generally aware of the Python packaging practices in effect). Second, it keeps the project aware of what is actually still in use by users. A bunch of build failures may cause some things to show up as just things we can safely remove. Third, it presents package maintainers or other contributors with opportunities to go and clean things up in spec files from time to time as we continually revise and refine recommendations. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836242] Review Request: python-sphinx-last-updated-by-git - Get the "last updated" time for each Sphinx page from Git
https://bugzilla.redhat.com/show_bug.cgi?id=1836242 --- Comment #2 from Charalampos Stratakis --- License amended. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836242] Review Request: python-sphinx-last-updated-by-git - Get the "last updated" time for each Sphinx page from Git
https://bugzilla.redhat.com/show_bug.cgi?id=1836242
--- Comment #1 from thrnc...@redhat.com ---
There is no BSD-2-clause license listed in allowed licenses
(https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing), please replace it
with BSD or BSD (2-clause) as short name for BSD License (two clause).
Otherwise looks good to me.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD 2-clause "Simplified" License", "Unknown or generated",
"*No copyright* BSD 2-clause "Simplified" License". 12 files have
unknown license. Detailed output of licensecheck in
/home/thrnciar/fedreview/python-sphinx-last-updated-by-
git/1836242-python-sphinx-last-updated-by-git/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Sources are verified with gpgverify first in %prep if upstream
publishes
[Bug 1836286] New: Review Request: rust-migrations_macros - Codegeneration macros for diesels embedded migrations
https://bugzilla.redhat.com/show_bug.cgi?id=1836286 Bug ID: 1836286 Summary: Review Request: rust-migrations_macros - Codegeneration macros for diesels embedded migrations Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: igor.ra...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-migrations_macros.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-migrations_macros-1.4.2-1.fc33.src.rpm Description: Codegeneration macros for diesels embedded migrations. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822971] Review Request: notcurses - character graphics and TUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1822971 --- Comment #59 from Miro Hrončok --- > No amount of futureproofing here is going to avoid having to continue to > maintain the spec file. Fair. I don't want to argue about this, I just assumed the dependency was removed in error. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822971] Review Request: notcurses - character graphics and TUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1822971 --- Comment #58 from David Cantrell --- I think this comes down to style. What you're describing is just the nature of package maintenance. No amount of futureproofing here is going to avoid having to continue to maintain the spec file. But, I would say this is just a matter of style. List it or don't. The main objective here is that the build completes and is reproducible and the built packages comply with policy. The maintainer will pick up ways that make that easier as time goes on and learn various tips as time goes on. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836085] Review Request: rust-migrations_internals - Internal implementation of diesels migration mechanism
https://bugzilla.redhat.com/show_bug.cgi?id=1836085 Igor Raits changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-05-15 14:31:38 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822971] Review Request: notcurses - character graphics and TUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1822971 --- Comment #57 from Miro Hrončok --- > My default has been to always minimize the BuildRequires listings for easier > maintenance. Since he needed python3-cffi he could get two for one there. > It doesn't really matter to me whether it's listed explicitly or not, but > I've always liked the shorter BuildRequires listings. I consider this approach error prone: in the future, cffi or Python might no longer need setuptools and the dependency will be removed, suddenly, this package will fail to build. Since this package uses setuptools directly (and not trough cffi), I think that listing the build dependency explicitly is the right thing to do. In fact, we want to get rid of the current "python3-devel requires python3-setuptools" thing, but many packages don't list setuptools explicitly, that makes it hard for us. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822971] Review Request: notcurses - character graphics and TUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1822971 --- Comment #56 from David Cantrell --- (In reply to Miro Hrončok from comment #53) > (In reply to David Cantrell from comment #9) > > This package fails to build as-is. I made some changes to the spec file to > > get it to build: > > > > --- notcurses-1.3.0-1.fc32.src/notcurses.spec 2020-04-12 > > 01:26:33.0 -0400 > > +++ rpmbuild/SPECS/notcurses.spec 2020-04-15 11:55:45.080414210 -0400 > > @@ -13,7 +13,7 @@ > > BuildRequires: gcc-c++ > > BuildRequires: pandoc > > BuildRequires: python3-devel > > -BuildRequires: python3-setuptools > > +BuildRequires: python3-cffi > > > David, I don't understand why you removed setuptools here. It is used and > should be specified explicitly. > > notcurses-1.3.3/python/setup.py > 1:from setuptools import setup > > The fact that setuptools is dragged in as a transitive dependency of other > packages is not to be relied upon. My default has been to always minimize the BuildRequires listings for easier maintenance. Since he needed python3-cffi he could get two for one there. It doesn't really matter to me whether it's listed explicitly or not, but I've always liked the shorter BuildRequires listings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822971] Review Request: notcurses - character graphics and TUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1822971 --- Comment #55 from David Cantrell --- (In reply to Miro Hrončok from comment #52) > Nick, I see you have committed and pushed the source tarball to git. > > We put tarballs to the "lookaside cache". See "fedpkg new-sources" in > https://fedoraproject.org/wiki/ > Package_maintenance_guide#Common_fedpkg_commands I noticed this too and pointed it out yesterday. He said he was fixing it up. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836097] Review Request: rust-javascriptcore-rs - Rust bindings for the javacriptcore library
https://bugzilla.redhat.com/show_bug.cgi?id=1836097 Igor Raits changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-05-15 13:51:24 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836144] Review Request: rust-soup-sys - Soup FFI crate for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1836144 Igor Raits changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-05-15 13:49:48 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836101] Review Request: rust-magic-crypt - Library to encrypt/decrpyt strings, files, or data, using DES or AES
https://bugzilla.redhat.com/show_bug.cgi?id=1836101 Igor Raits changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-05-15 13:49:02 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836144] Review Request: rust-soup-sys - Soup FFI crate for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1836144 --- Comment #2 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-soup-sys -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836097] Review Request: rust-javascriptcore-rs - Rust bindings for the javacriptcore library
https://bugzilla.redhat.com/show_bug.cgi?id=1836097 --- Comment #2 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-javascriptcore-rs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836085] Review Request: rust-migrations_internals - Internal implementation of diesels migration mechanism
https://bugzilla.redhat.com/show_bug.cgi?id=1836085 --- Comment #2 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-migrations_internals -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836101] Review Request: rust-magic-crypt - Library to encrypt/decrpyt strings, files, or data, using DES or AES
https://bugzilla.redhat.com/show_bug.cgi?id=1836101 --- Comment #2 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-magic-crypt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1834947] Review Request: rust-desed - sed script debugger
https://bugzilla.redhat.com/show_bug.cgi?id=1834947 --- Comment #8 from Fedora Update System --- FEDORA-2020-6d9330c5d6 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-6d9330c5d6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1834947] Review Request: rust-desed - sed script debugger
https://bugzilla.redhat.com/show_bug.cgi?id=1834947 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #7 from Fedora Update System --- FEDORA-2020-f0df69576c has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f0df69576c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836097] Review Request: rust-javascriptcore-rs - Rust bindings for the javacriptcore library
https://bugzilla.redhat.com/show_bug.cgi?id=1836097 Neal Gompa changed: What|Removed |Added Status|NEW |POST CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Neal Gompa --- Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836101] Review Request: rust-magic-crypt - Library to encrypt/decrpyt strings, files, or data, using DES or AES
https://bugzilla.redhat.com/show_bug.cgi?id=1836101 Neal Gompa changed: What|Removed |Added Status|NEW |POST CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Neal Gompa --- Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836085] Review Request: rust-migrations_internals - Internal implementation of diesels migration mechanism
https://bugzilla.redhat.com/show_bug.cgi?id=1836085 Neal Gompa changed: What|Removed |Added Status|NEW |POST CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Neal Gompa --- Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836144] Review Request: rust-soup-sys - Soup FFI crate for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1836144 Neal Gompa changed: What|Removed |Added Status|NEW |POST CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Neal Gompa --- Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836242] Review Request: python-sphinx-last-updated-by-git - Get the "last updated" time for each Sphinx page from Git
https://bugzilla.redhat.com/show_bug.cgi?id=1836242 thrnc...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||thrnc...@redhat.com Assignee|nob...@fedoraproject.org|thrnc...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836242] Review Request: python-sphinx-last-updated-by-git - Get the "last updated" time for each Sphinx page from Git
https://bugzilla.redhat.com/show_bug.cgi?id=1836242 Charalampos Stratakis changed: What|Removed |Added Blocks||1757082 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1757082 [Bug 1757082] python-nbsphinx-0.7.0 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836242] New: Review Request: python-sphinx-last-updated-by-git - Get the "last updated" time for each Sphinx page from Git
https://bugzilla.redhat.com/show_bug.cgi?id=1836242 Bug ID: 1836242 Summary: Review Request: python-sphinx-last-updated-by-git - Get the "last updated" time for each Sphinx page from Git Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: cstra...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://cstratak.fedorapeople.org/python-sphinx-last-updated-by-git-0.2.1-1.fc31.src.rpm SRPM URL: https://cstratak.fedorapeople.org/python-sphinx-last-updated-by-git.spec Description: Get the "last updated" time for each Sphinx page from Git. This is a little Sphinx_ extension that does exactly that.It also checks for included files and other dependencies. Fedora Account System Username: cstratak -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1835258] Review Request: perl-Crypt-ECB - Encrypt Data using ECB Mode
https://bugzilla.redhat.com/show_bug.cgi?id=1835258 Charles R. Anderson changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-05-15 11:50:11 --- Comment #7 from Charles R. Anderson --- Built for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=44524400 and f32: https://koji.fedoraproject.org/koji/taskinfo?taskID=44526226 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1835263] Review Request: perl-Crypt-PWSafe3 - Read and write Passwordsafe v3 files
https://bugzilla.redhat.com/show_bug.cgi?id=1835263 Bug 1835263 depends on bug 1835258, which changed state. Bug 1835258 Summary: Review Request: perl-Crypt-ECB - Encrypt Data using ECB Mode https://bugzilla.redhat.com/show_bug.cgi?id=1835258 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830306] Review Request: git-revise - Efficiently update, split, and rearrange git commits
https://bugzilla.redhat.com/show_bug.cgi?id=1830306 --- Comment #4 from Juan Orti Alcaine --- A few more things: - There's documentation that you can build with sphinx in the doc directory. It'll probably need to go to a doc subpackage. - If possible, you should run the included tests in the %check section. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823132] Review Request: gearhead1 - Roguelike mecha role-playing game
https://bugzilla.redhat.com/show_bug.cgi?id=1823132 --- Comment #3 from aegor...@redhat.com --- I'll review this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823132] Review Request: gearhead1 - Roguelike mecha role-playing game
https://bugzilla.redhat.com/show_bug.cgi?id=1823132 Pavel Zhukov changed: What|Removed |Added CC||pzhu...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822971] Review Request: notcurses - character graphics and TUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1822971 --- Comment #53 from Miro Hrončok --- (In reply to David Cantrell from comment #9) > This package fails to build as-is. I made some changes to the spec file to > get it to build: > > --- notcurses-1.3.0-1.fc32.src/notcurses.spec 2020-04-12 > 01:26:33.0 -0400 > +++ rpmbuild/SPECS/notcurses.spec 2020-04-15 11:55:45.080414210 -0400 > @@ -13,7 +13,7 @@ > BuildRequires: gcc-c++ > BuildRequires: pandoc > BuildRequires: python3-devel > -BuildRequires: python3-setuptools > +BuildRequires: python3-cffi David, I don't understand why you removed setuptools here. It is used and should be specified explicitly. notcurses-1.3.3/python/setup.py 1:from setuptools import setup The fact that setuptools is dragged in as a transitive dependency of other packages is not to be relied upon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823132] Review Request: gearhead1 - Roguelike mecha role-playing game
https://bugzilla.redhat.com/show_bug.cgi?id=1823132 aegor...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||aegor...@redhat.com Assignee|nob...@fedoraproject.org|aegor...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1822971] Review Request: notcurses - character graphics and TUI library
https://bugzilla.redhat.com/show_bug.cgi?id=1822971 Miro Hrončok changed: What|Removed |Added CC||mhron...@redhat.com --- Comment #52 from Miro Hrončok --- Nick, I see you have committed and pushed the source tarball to git. We put tarballs to the "lookaside cache". See "fedpkg new-sources" in https://fedoraproject.org/wiki/Package_maintenance_guide#Common_fedpkg_commands -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1834964] Review Request: honggfuzz - General-purpose, easy-to-use fuzzer
https://bugzilla.redhat.com/show_bug.cgi?id=1834964 --- Comment #14 from Richard W.M. Jones --- ExcludeArch bug: https://bugzilla.redhat.com/show_bug.cgi?id=1836163 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829340] Review Request: python-pebble - Threading and multiprocessing eye-candy for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1829340 --- Comment #33 from Martin Liška --- All right, I regenerated them in Fedora container: SRPM: https://github.com/marxin/fedora-Pebble/raw/master/python-pebble-4.5.1-1.fc31.src.rpm SPEC: https://raw.githubusercontent.com/marxin/fedora-Pebble/master/python-pebble.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836144] New: Review Request: rust-soup-sys - Soup FFI crate for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1836144 Bug ID: 1836144 Summary: Review Request: rust-soup-sys - Soup FFI crate for Rust Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: igor.ra...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-soup-sys.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-soup-sys-0.9.0-1.fc33.src.rpm Description: Soup FFI crate for Rust. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829340] Review Request: python-pebble - Threading and multiprocessing eye-candy for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1829340 --- Comment #32 from Miro Hrončok --- Into the environment you are in: $ sudo dnf build-dep xxx.spec I personally use mock to have more reproducible setups and to avoid installing everything to my machine. Many packagers do as well. https://github.com/rpm-software-management/mock/wiki If you have something new for me to review, please recreate the SRPM and post new links. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1807365] Review Request: nuspell - Free and open source C++ spell checking library
https://bugzilla.redhat.com/show_bug.cgi?id=1807365
--- Comment #14 from Pander ---
Thanks for the changes. They were good, until we changed the description
recently. Sorry for that. If you can, please change
Summary:
C++ spelling checking library and command-line tool
Requires: has one tab character too many after it
%description
Nuspell is a fast and safe spelling checker software program. It is designed
for languages with rich morphology and complex word compounding. Nuspell is
written in modern C++ and it supports Hunspell dictionaries.
%package devel
Summary:Development tools for %{name}
(make sure there is no whitespace at the end of the line for Summary)
The latest release is here:
https://github.com/nuspell/nuspell/releases/tag/v3.1.1
Please upgrade the spec file for this too. Thanks.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836101] New: Review Request: rust-magic-crypt - Library to encrypt/decrpyt strings, files, or data, using DES or AES
https://bugzilla.redhat.com/show_bug.cgi?id=1836101 Bug ID: 1836101 Summary: Review Request: rust-magic-crypt - Library to encrypt/decrpyt strings, files, or data, using DES or AES Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: igor.ra...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-magic-crypt.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-magic-crypt-3.0.0-1.fc33.src.rpm Description: MagicCrypt is a Java/PHP/NodeJS/Rust library to encrypt/decrpyt strings, files, or data, using Data Encryption Standard(DES) or Advanced Encryption Standard(AES) algorithms. It supports CBC block cipher mode, PKCS5 padding and 64, 128, 192 or 256-bits key length. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836097] New: Review Request: rust-javascriptcore-rs - Rust bindings for the javacriptcore library
https://bugzilla.redhat.com/show_bug.cgi?id=1836097 Bug ID: 1836097 Summary: Review Request: rust-javascriptcore-rs - Rust bindings for the javacriptcore library Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: igor.ra...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-javascriptcore-rs.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-javascriptcore-rs-0.9.0-1.fc33.src.rpm Description: Rust bindings for the javacriptcore library. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1829340] Review Request: python-pebble - Threading and multiprocessing eye-candy for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1829340 --- Comment #31 from Martin Liška --- Yep, I should have done it earlier. Ok, right now I built the package with podman. I've just added build dependency on python3-pytest. Btw. do you have a way how to install all BuildRequires packages before you run rpmbuild? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
