[Bug 1828101] Review Request: gnome-shell-extension-emoji-selector - GNOME Shell extension for copying emojis to the clipboard
https://bugzilla.redhat.com/show_bug.cgi?id=1828101 Carl George 鸞 changed: What|Removed |Added Flags|needinfo?(c...@redhat.com) | --- Comment #6 from Carl George 鸞 --- Thanks for the sleuthing on convenience.js. I've updated the license field as requested, along with a comment explaining the license breakdown. Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01427033-gnome-shell-extension-emoji-selector/gnome-shell-extension-emoji-selector.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01427033-gnome-shell-extension-emoji-selector/gnome-shell-extension-emoji-selector-19-2.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839259] Review Request: rust-wayland-scanner - Wayland Scanner for generating rust APIs from XML wayland protocol files
https://bugzilla.redhat.com/show_bug.cgi?id=1839259 Michel Alexandre Salim changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-06-05 04:49:35 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839260] Review Request: rust-wayland-client - Bindings to the standard C implementation of the wayland protocol, client side
https://bugzilla.redhat.com/show_bug.cgi?id=1839260 Bug 1839260 depends on bug 1839259, which changed state. Bug 1839259 Summary: Review Request: rust-wayland-scanner - Wayland Scanner for generating rust APIs from XML wayland protocol files https://bugzilla.redhat.com/show_bug.cgi?id=1839259 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839266] Review Request: rust-wayland-server - Bindings to the standard C implementation of the wayland protocol, server side
https://bugzilla.redhat.com/show_bug.cgi?id=1839266 Bug 1839266 depends on bug 1839257, which changed state. Bug 1839257 Summary: Review Request: rust-wayland-sys - FFI bindings to the various libwayland-*.so libraries https://bugzilla.redhat.com/show_bug.cgi?id=1839257 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839258] Review Request: rust-wayland-commons - Common types and structures used by wayland-client and wayland-server
https://bugzilla.redhat.com/show_bug.cgi?id=1839258 Bug 1839258 depends on bug 1839257, which changed state. Bug 1839257 Summary: Review Request: rust-wayland-sys - FFI bindings to the various libwayland-*.so libraries https://bugzilla.redhat.com/show_bug.cgi?id=1839257 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839257] Review Request: rust-wayland-sys - FFI bindings to the various libwayland-*.so libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1839257 Michel Alexandre Salim changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-06-05 04:48:42 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844313] Review Request: python-daphne - Django ASGI (HTTP/WebSocket) server
https://bugzilla.redhat.com/show_bug.cgi?id=1844313 Carl George 鸞 changed: What|Removed |Added Blocks||1793129 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1793129 [Bug 1793129] python-falcon fails to build with Python 3.9: TypeError: can't set attributes of built-in/extension type 'str' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844308] Review Request: python-uvicorn - The lightning-fast ASGI server
https://bugzilla.redhat.com/show_bug.cgi?id=1844308 Carl George 鸞 changed: What|Removed |Added Blocks||1793129 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1793129 [Bug 1793129] python-falcon fails to build with Python 3.9: TypeError: can't set attributes of built-in/extension type 'str' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844313] New: Review Request: python-daphne - Django ASGI (HTTP/WebSocket) server
https://bugzilla.redhat.com/show_bug.cgi?id=1844313 Bug ID: 1844313 Summary: Review Request: python-daphne - Django ASGI (HTTP/WebSocket) server Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: c...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01426998-python-daphne/python-daphne.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01426998-python-daphne/python-daphne-2.5.0-1.fc33.src.rpm Description: Daphne is a HTTP, HTTP2 and WebSocket protocol server for ASGI and ASGI-HTTP, developed to power Django Channels. It supports automatic negotiation of protocols; there’s no need for URL prefixing to determine WebSocket endpoints versus HTTP endpoints. Fedora Account System Username: carlwgeorge -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833741] Review Request: python-colcon-lcov-result - Extension for colcon to provide test results using LCOV
https://bugzilla.redhat.com/show_bug.cgi?id=1833741 --- Comment #11 from Fedora Update System --- FEDORA-EPEL-2020-8ac7fd1c04 has been pushed to the Fedora EPEL 7 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1834496] Review Request: python-colcon-coveragepy-result - Extension for colcon to collect coverage.py results
https://bugzilla.redhat.com/show_bug.cgi?id=1834496 --- Comment #11 from Fedora Update System --- FEDORA-EPEL-2020-6beba110a6 has been pushed to the Fedora EPEL 7 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1833745] Review Request: python-colcon-ed - Extension for colcon to edit a file within a package
https://bugzilla.redhat.com/show_bug.cgi?id=1833745 --- Comment #11 from Fedora Update System --- FEDORA-EPEL-2020-e0db4e4fcc has been pushed to the Fedora EPEL 7 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844308] New: Review Request: python-uvicorn - The lightning-fast ASGI server
https://bugzilla.redhat.com/show_bug.cgi?id=1844308 Bug ID: 1844308 Summary: Review Request: python-uvicorn - The lightning-fast ASGI server Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: c...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01426991-python-uvicorn/python-uvicorn.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01426991-python-uvicorn/python-uvicorn-0.11.5-1.fc33.src.rpm Description: Uvicorn is a lightning-fast ASGI server implementation, using uvloop and httptools. Until recently Python has lacked a minimal low-level server/application interface for asyncio frameworks. The ASGI specification fills this gap, and means we are now able to start building a common set of tooling usable across all asyncio frameworks. Uvicorn currently supports HTTP/1.1 and WebSockets. Support for HTTP/2 is planned. Fedora Account System Username: carlwgeorge One of this package's build requirements is python-watchgod, so please review bug 1844303 first. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844308] Review Request: python-uvicorn - The lightning-fast ASGI server
https://bugzilla.redhat.com/show_bug.cgi?id=1844308 Carl George 鸞 changed: What|Removed |Added Depends On||1844303 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1844303 [Bug 1844303] Review Request: python-watchgod - Simple, modern file watching and code reload -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844303] Review Request: python-watchgod - Simple, modern file watching and code reload
https://bugzilla.redhat.com/show_bug.cgi?id=1844303 Carl George 鸞 changed: What|Removed |Added Blocks||1844308 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1844308 [Bug 1844308] Review Request: python-uvicorn - The lightning-fast ASGI server -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827880] Review Request: fswatch - A cross-platform file change monitor
https://bugzilla.redhat.com/show_bug.cgi?id=1827880 Darryl T. Agostinelli changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-06-05 03:31:33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1843426] Review Request: perl-Test2 - Framework for writing test tools that all work together
https://bugzilla.redhat.com/show_bug.cgi?id=1843426 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #4 from Fedora Update System --- FEDORA-EPEL-2020-1e6db211d2 has been pushed to the Fedora EPEL 7 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-1e6db211d2 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844303] New: Review Request: python-watchgod - Simple, modern file watching and code reload
https://bugzilla.redhat.com/show_bug.cgi?id=1844303 Bug ID: 1844303 Summary: Review Request: python-watchgod - Simple, modern file watching and code reload Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: c...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01426981-python-watchgod/python-watchgod.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01426981-python-watchgod/python-watchgod-0.6-1.fc33.src.rpm Description: Simple, modern file watching and code reload in python. watchgod is inspired by watchdog, hence the name, but tries to fix some of the frustrations found with watchdog. Fedora Account System Username: carlwgeorge -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1812435] Review Request: python-beautifultable - Print ASCII tables for terminals
https://bugzilla.redhat.com/show_bug.cgi?id=1812435 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- FEDORA-2020-e0c4437267 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-e0c4437267 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-e0c4437267 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821171] Review Request: golang-github-masterzen-simplexml - Go library to generate XML content from a naive DOM
https://bugzilla.redhat.com/show_bug.cgi?id=1821171 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System --- FEDORA-2020-27a5bdb473 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-27a5bdb473 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-27a5bdb473 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840377] Review Request: socialscan - CLI and library for usage checking of user names and email addresses
https://bugzilla.redhat.com/show_bug.cgi?id=1840377 Lyes Saadi changed: What|Removed |Added CC||fed...@lyes.eu --- Comment #1 from Lyes Saadi --- Cool package! Could you please not execute tests? The test suite need an internet connection. Mock, though, cannot connect to the internet ;)! So the build will systematically fail... ``` === short test summary info FAILED tests/test_socialscan.py::test_usernames[usernames0-assert_available-GitHub] FAILED tests/test_socialscan.py::test_usernames[usernames0-assert_available-GitLab] FAILED tests/test_socialscan.py::test_usernames[usernames0-assert_available-Lastfm] FAILED tests/test_socialscan.py::test_usernames[usernames0-assert_available-Pastebin] FAILED tests/test_socialscan.py::test_usernames[usernames0-assert_available-Reddit] FAILED tests/test_socialscan.py::test_usernames[usernames0-assert_available-Snapchat] FAILED tests/test_socialscan.py::test_usernames[usernames0-assert_available-Twitter] FAILED tests/test_socialscan.py::test_usernames[usernames0-assert_available-Tumblr] FAILED tests/test_socialscan.py::test_usernames[usernames0-assert_available-Yahoo] FAILED tests/test_socialscan.py::test_usernames[usernames1-assert_unavailable-GitHub] FAILED tests/test_socialscan.py::test_usernames[usernames1-assert_unavailable-GitLab] FAILED tests/test_socialscan.py::test_usernames[usernames1-assert_unavailable-Lastfm] FAILED tests/test_socialscan.py::test_usernames[usernames1-assert_unavailable-Pastebin] FAILED tests/test_socialscan.py::test_usernames[usernames1-assert_unavailable-Reddit] FAILED tests/test_socialscan.py::test_usernames[usernames1-assert_unavailable-Snapchat] FAILED tests/test_socialscan.py::test_usernames[usernames1-assert_unavailable-Twitter] FAILED tests/test_socialscan.py::test_usernames[usernames1-assert_unavailable-Tumblr] FAILED tests/test_socialscan.py::test_usernames[usernames1-assert_unavailable-Yahoo] FAILED tests/test_socialscan.py::test_usernames[usernames2-assert_invalid-GitHub] FAILED tests/test_socialscan.py::test_usernames[usernames2-assert_invalid-Lastfm] FAILED tests/test_socialscan.py::test_usernames[usernames2-assert_invalid-Pastebin] FAILED tests/test_socialscan.py::test_usernames[usernames2-assert_invalid-Reddit] FAILED tests/test_socialscan.py::test_usernames[usernames2-assert_invalid-Snapchat] FAILED tests/test_socialscan.py::test_usernames[usernames2-assert_invalid-Twitter] FAILED tests/test_socialscan.py::test_usernames[usernames2-assert_invalid-Tumblr] FAILED tests/test_socialscan.py::test_usernames[usernames2-assert_invalid-Yahoo] FAILED tests/test_socialscan.py::test_emails[emails0-assert_available-GitHub] FAILED tests/test_socialscan.py::test_emails[emails0-assert_available-Lastfm] FAILED tests/test_socialscan.py::test_emails[emails0-assert_available-Pastebin] FAILED tests/test_socialscan.py::test_emails[emails0-assert_available-Pinterest] FAILED tests/test_socialscan.py::test_emails[emails0-assert_available-Spotify] FAILED tests/test_socialscan.py::test_emails[emails0-assert_available-Twitter] FAILED tests/test_socialscan.py::test_emails[emails0-assert_available-Tumblr] FAILED tests/test_socialscan.py::test_emails[emails1-assert_unavailable-GitHub] FAILED tests/test_socialscan.py::test_emails[emails1-assert_unavailable-Lastfm] FAILED tests/test_socialscan.py::test_emails[emails1-assert_unavailable-Pastebin] FAILED tests/test_socialscan.py::test_emails[emails1-assert_unavailable-Pinterest] FAILED tests/test_socialscan.py::test_emails[emails1-assert_unavailable-Spotify] FAILED tests/test_socialscan.py::test_emails[emails1-assert_unavailable-Twitter] FAILED tests/test_socialscan.py::test_emails[emails1-assert_unavailable-Tumblr] === 40 failed, 1 passed, 5 deselected, 81 warnings in 0.58s ``` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826439] Review Request: libvma - LD_PRELOAD-able library with standard BSD sockets API
https://bugzilla.redhat.com/show_bug.cgi?id=1826439 Honggang LI changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826439] Review Request: libvma - LD_PRELOAD-able library with standard BSD sockets API
https://bugzilla.redhat.com/show_bug.cgi?id=1826439 Honggang LI changed: What|Removed |Added Flags||needinfo?(igor.ivanov.va@gm ||ail.com) --- Comment #15 from Honggang LI --- Please tell me your FSA account. I searched 'igor.ivanov.va' in https://src.fedoraproject.org/users , but did not get a match. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1636111] Review Request: glyr - Glyr is a music related metadata searchengine
https://bugzilla.redhat.com/show_bug.cgi?id=1636111 Mukundan Ragavan changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |ERRATA Last Closed||2020-06-04 23:50:55 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821171] Review Request: golang-github-masterzen-simplexml - Go library to generate XML content from a naive DOM
https://bugzilla.redhat.com/show_bug.cgi?id=1821171 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #4 from Fedora Update System --- FEDORA-2020-27a5bdb473 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-27a5bdb473 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773717] Review Request: golang-github-haproxytech-models - HAProxy Go structs for API
https://bugzilla.redhat.com/show_bug.cgi?id=1773717 --- Comment #12 from Mohan Boddu --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-haproxytech-models -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773718] Review Request: golang-github-haproxytech-config-parser - HAProxy configuration parser
https://bugzilla.redhat.com/show_bug.cgi?id=1773718 --- Comment #11 from Mohan Boddu --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-haproxytech-config-parser -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1773716 --- Comment #14 from Mohan Boddu --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-gehirninc-crypt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1842579] Review Request: golang-github-acobaugh-osrelease - Golang package to read and parse /etc/os-release
https://bugzilla.redhat.com/show_bug.cgi?id=1842579 Fabiano Fidêncio changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840870] Review Request: golang-github-HarryMichal-go-version - Version normalizer and comparison library for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1840870 --- Comment #2 from Ondřej Míchal --- Thank you, Fabiano, for the review! I updated the name of the specfile to "golang-github-harrymichal-version.spec" as the review suggested. Apart from this everything should be ok. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823117] Review Request: opensurge - 2D retro platformer inspired by Sonic games
https://bugzilla.redhat.com/show_bug.cgi?id=1823117 --- Comment #21 from Artur Iwicki --- You'll need to reassign the ticket to yourself since the Assignee and flag:fedora-review+ user don't match. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840870] Review Request: golang-github-HarryMichal-go-version - Version normalizer and comparison library for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1840870 Ondřej Míchal changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- Spec URL: https://harrymichal.fedorapeople.org/golang-github-HarryMichal-go-version.spec SRPM URL: https://harrymichal.fedorapeople.org/golang-github-harrymichal-version-1.0.0-1.fc33.src.rpm Description: Version normalizer and comparison library for Go Fedora Account System Username: harrymichal -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1842579] Review Request: golang-github-acobaugh-osrelease - Golang package to read and parse /etc/os-release
https://bugzilla.redhat.com/show_bug.cgi?id=1842579 --- Comment #2 from Ondřej Míchal --- Thank you, Fabiano, for the review! I fixed the license field and updated both files. Should be good to go now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844225] New: Review Request: python-sphinx-pyreverse - A simple sphinx extension to generate UML diagrams with pyreverse
https://bugzilla.redhat.com/show_bug.cgi?id=1844225 Bug ID: 1844225 Summary: Review Request: python-sphinx-pyreverse - A simple sphinx extension to generate UML diagrams with pyreverse Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: sumuk...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://github.com/sumantro93/python-sphinx-pyreverse/blob/master/python-sphinx-pyreverse.spec SRPM URL: https://github.com/sumantro93/python-sphinx-pyreverse/blob/master/python-sphinx-pyreverse-0.0.13-1.fc32.src.rpm Description: A simple sphinx extension to generate UML diagrams with pyreverse Fedora Account System Username: sumantrom Koji Scratch Build : https://koji.fedoraproject.org/koji/taskinfo?taskID=45421515 I am not yet in the packager group and I am looking forward to a sponsor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #3 from Vasiliy Glazov --- 7. Change Summary: to something more usefull without repeating name. 8. Line length in description must be 80 symbols maximum. Correct it. 9. I think Obsoletes: Jamulus <= 3.5.3-3 should be removed because wi not contain it in repos before. 10. Add license and doc files to %files section. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #2 from Vasiliy Glazov --- 6. Why do you use commit if release available by direct URL? https://github.com/corrados/jamulus/archive/r3_5_5.tar.gz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120
--- Comment #1 from Vasiliy Glazov ---
1. Remove Group tag.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections
2. Change
%setup -qn jamulus-%{commit0}
to
%autosetup -n jamulus-%{commit0}
3. Don't use macro for "install" command
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros
4. Correct desktop file install
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage
5. Remove %post, %postun and %posttrans sections. Scriptlets for desktop file
and mime not needed now.
After that I will see at build flags and why you change them.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837019] Review Request: theme-switcher - Switch dark/light GTK theme automatically during day/night
https://bugzilla.redhat.com/show_bug.cgi?id=1837019
--- Comment #8 from Artem ---
(In reply to Fabio Valentini from comment #5)
> (In reply to Artem from comment #3)
> > Hello! Thanks! Added both, %{?systemd_requires} and systemd scriplets. They
> > was already before but i removed them due some weird behavior and unit was
> > always activated, but this was before 2.0 version, seems fine now. We will
> > drop entirely systemd units in future probably.
>
> Maybe the "fixed" systemd user unit behavior is caused by this fedora 32
> Change?
> https://fedoraproject.org/wiki/Changes/Systemd_presets_for_user_units
Exactly this. Now i understand from where was problem comes. Thanks a lot Fabio
and thanks a lot Lyes. Sorry for some delay here, i'll update SPEC tomorrow and
try to test all this.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840870] Review Request: golang-github-HarryMichal-go-version - Version normalizer and comparison library for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1840870 Fabiano Fidêncio changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840870] Review Request: golang-github-HarryMichal-go-version - Version normalizer and comparison library for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1840870
Fabiano Fidêncio changed:
What|Removed |Added
CC||fiden...@redhat.com
--- Comment #1 from Fabiano Fidêncio ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Spec file name must match the spec package %{name}, in the format
%{name}.spec.
Note: golang-github-HarryMichal-go-version.spec should be golang-github-
harrymichal-version.spec
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_spec_file_naming
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package does not own files or directories owned by other packages.
Note: Doesn't explicitly own, but relies on:
/usr/share/gocode/src/github.com
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary
[Bug 1842579] Review Request: golang-github-acobaugh-osrelease - Golang package to read and parse /etc/os-release
https://bugzilla.redhat.com/show_bug.cgi?id=1842579 Fabiano Fidêncio changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1842579] Review Request: golang-github-acobaugh-osrelease - Golang package to read and parse /etc/os-release
https://bugzilla.redhat.com/show_bug.cgi?id=1842579
Fabiano Fidêncio changed:
What|Removed |Added
CC||fiden...@redhat.com
Doc Type|--- |If docs needed, set a value
--- Comment #1 from Fabiano Fidêncio ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
NOTE: This must be fixed, basically: s/-3-Clause//.
Please, check:
https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses
[x]: Package does not own files or directories owned by other packages.
Note: Doesn't explicitly own, but relies on:
/usr/share/gocode/src/github.com
[x]: %build honors applicable compiler flags or justifies otherwise.
[x: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[-]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
Note: Please, check the "Requires" section down below.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[-]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[-]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[-]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[-]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[-]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in
[Bug 1812435] Review Request: python-beautifultable - Print ASCII tables for terminals
https://bugzilla.redhat.com/show_bug.cgi?id=1812435 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #7 from Fedora Update System --- FEDORA-2020-e0c4437267 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-e0c4437267 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 Vasiliy Glazov changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|vasc...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] Review Request: Jamulus - A tool for live rehearsale acroos the internet
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 ycollet changed: What|Removed |Added Summary|Review Request: -|acroos the internet -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821174] Review Request: golang-github-azure-ntlmssp - NTLM/Negotiate authentication over HTTP
https://bugzilla.redhat.com/show_bug.cgi?id=1821174 Fabian Affolter changed: What|Removed |Added Blocks||1844114 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1844114 [Bug 1844114] Review Request: golang-github-masterzen-winrm - Command-line tool and library for Windows remote command execution -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844119] Review Request: shellz - Utility to tracking and controlling shells and tunnels
https://bugzilla.redhat.com/show_bug.cgi?id=1844119 Fabian Affolter changed: What|Removed |Added Blocks||563471 (FE-SECLAB) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=563471 [Bug 563471] Tracker: Review Requests for Fedora Security Lab related packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821171] Review Request: golang-github-masterzen-simplexml - Go library to generate XML content from a naive DOM
https://bugzilla.redhat.com/show_bug.cgi?id=1821171 Fabian Affolter changed: What|Removed |Added Blocks||1844114 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1844114 [Bug 1844114] Review Request: golang-github-masterzen-winrm - Command-line tool and library for Windows remote command execution -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844114] Review Request: golang-github-masterzen-winrm - Command-line tool and library for Windows remote command execution
https://bugzilla.redhat.com/show_bug.cgi?id=1844114 Fabian Affolter changed: What|Removed |Added Depends On||1821174, 1821171 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1821171 [Bug 1821171] Review Request: golang-github-masterzen-simplexml - Go library to generate XML content from a naive DOM https://bugzilla.redhat.com/show_bug.cgi?id=1821174 [Bug 1821174] Review Request: golang-github-azure-ntlmssp - NTLM/Negotiate authentication over HTTP -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844120] New: Review Request: -
https://bugzilla.redhat.com/show_bug.cgi?id=1844120 Bug ID: 1844120 Summary: Review Request: - Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: ycollette.nos...@free.fr QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://raw.githubusercontent.com/ycollet/fedora-spec/master/jamulus/jamulus.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ycollet/linuxmao/fedora-32-x86_64/01417638-jamulus/jamulus-3.5.5-4.fc32.src.rpm Description: Jamulus is a tool which allows to perform live rehearsal across the internet with a veroy low audio latency. You must start a Jamulus server on a side and each member of the group connect to the server. Fedora Account System Username: ycollet -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844114] Review Request: golang-github-masterzen-winrm - Command-line tool and library for Windows remote command execution
https://bugzilla.redhat.com/show_bug.cgi?id=1844114 Fabian Affolter changed: What|Removed |Added Blocks||1844119 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1844119 [Bug 1844119] Review Request: shellz - Utility to tracking and controlling shells and tunnels -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821159] Review Request: golang-github-reiver-telnet - Telnet(s) client and server implementations
https://bugzilla.redhat.com/show_bug.cgi?id=1821159 Fabian Affolter changed: What|Removed |Added Blocks||1844119 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1844119 [Bug 1844119] Review Request: shellz - Utility to tracking and controlling shells and tunnels -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844119] Review Request: shellz - Utility to tracking and controlling shells and tunnels
https://bugzilla.redhat.com/show_bug.cgi?id=1844119 Fabian Affolter changed: What|Removed |Added Depends On||1844114, 1821159 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1821159 [Bug 1821159] Review Request: golang-github-reiver-telnet - Telnet(s) client and server implementations https://bugzilla.redhat.com/show_bug.cgi?id=1844114 [Bug 1844114] Review Request: golang-github-masterzen-winrm - Command-line tool and library for Windows remote command execution -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844119] New: Review Request: shellz - Utility to tracking and controlling shells and tunnels
https://bugzilla.redhat.com/show_bug.cgi?id=1844119 Bug ID: 1844119 Summary: Review Request: shellz - Utility to tracking and controlling shells and tunnels Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/shellz.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/shellz-1.5.0-1.fc31.src.rpm Project URL: https://github.com/evilsocket/shellz Description: Shellz is a small utility to track and control your ssh, telnet, web and custom shells and tunnels. Koji scratch build: missing dependencies rpmlint output: $ rpmlint shellz-1.5.0-1.fc31.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint shellz-* shellz.x86_64: W: no-manual-page-for-binary shellz 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844113] Review Request: golang-github-christrenkamp-goxpath - XPath 1.0 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1844113 Fabian Affolter changed: What|Removed |Added Blocks||1844114 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1844114 [Bug 1844114] Review Request: golang-github-masterzen-winrm - Command-line tool and library for Windows remote command execution -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844114] Review Request: golang-github-masterzen-winrm - Command-line tool and library for Windows remote command execution
https://bugzilla.redhat.com/show_bug.cgi?id=1844114 Fabian Affolter changed: What|Removed |Added Depends On||1844113 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1844113 [Bug 1844113] Review Request: golang-github-christrenkamp-goxpath - XPath 1.0 implementation -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844114] New: Review Request: golang-github-masterzen-winrm - Command-line tool and library for Windows remote command execution
https://bugzilla.redhat.com/show_bug.cgi?id=1844114 Bug ID: 1844114 Summary: Review Request: golang-github-masterzen-winrm - Command-line tool and library for Windows remote command execution Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-masterzen-winrm.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-masterzen-winrm-0-0.1.20200604git1d17eaf.fc31.src.rpm Project URL: https://github.com/masterzen/winrm Description: Command-line tool and library for Windows remote command execution in Go. Koji scratch build: missing dependencies rpmlint output: $ rpmlint golang-github-masterzen-winrm-0-0.1.20200604git1d17eaf.fc31.src.rpm golang-github-masterzen-winrm.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint golang-github-masterzen-winrm-devel-0-0.1.20200604git1d17eaf.fc31.noarch.rpm golang-github-masterzen-winrm-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/masterzen/winrm/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844113] New: Review Request: golang-github-christrenkamp-goxpath - XPath 1.0 implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1844113 Bug ID: 1844113 Summary: Review Request: golang-github-christrenkamp-goxpath - XPath 1.0 implementation Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-christrenkamp-goxpath.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-christrenkamp-goxpath-0-0.1.20200604gitc5096ec.fc31.src.rpm Project URL: https://github.com/ChrisTrenkamp/goxpath Description: An XPath 1.0 implementation written in the Go programming language. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=45418610 rpmlint output: $ rpmlint golang-github-christrenkamp-goxpath-0-0.1.20200604gitc5096ec.fc31.src.rpm golang-github-christrenkamp-goxpath.src: W: spelling-error Summary(en_US) XPath -> X Path, Path 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint golang-github-christrenkamp-goxpath-devel-0-0.1.20200604gitc5096ec.fc31.noarch.rpm golang-github-christrenkamp-goxpath-devel.noarch: W: spelling-error Summary(en_US) XPath -> X Path, Path golang-github-christrenkamp-goxpath-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/ChrisTrenkamp/goxpath/.goipath 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1812435] Review Request: python-beautifultable - Print ASCII tables for terminals
https://bugzilla.redhat.com/show_bug.cgi?id=1812435 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-beautifultable -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839477] Review Request: python-google-api-core - Core Library for Google Client Libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1839477 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-google-api-core -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839259] Review Request: rust-wayland-scanner - Wayland Scanner for generating rust APIs from XML wayland protocol files
https://bugzilla.redhat.com/show_bug.cgi?id=1839259 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-wayland-scanner -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1842475] Review Request: python-publicsuffix2 - Get a public suffix for a domain name using the Public Suffix List
https://bugzilla.redhat.com/show_bug.cgi?id=1842475 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-publicsuffix2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1842328] Review Request: python-zstandard - Zstandard bindings for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1842328 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-zstandard -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839257] Review Request: rust-wayland-sys - FFI bindings to the various libwayland-*.so libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1839257 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-wayland-sys -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1843273] Review Request: python-jaraco-envs - Classes for orchestrating Python (virtual) environments
https://bugzilla.redhat.com/show_bug.cgi?id=1843273 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-jaraco-envs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839887] Review Request: python-cle - A Python interface for analyzing binary formats
https://bugzilla.redhat.com/show_bug.cgi?id=1839887 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-cle -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821171] Review Request: golang-github-masterzen-simplexml - Go library to generate XML content from a naive DOM
https://bugzilla.redhat.com/show_bug.cgi?id=1821171 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-masterzen-simplexml -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821174] Review Request: golang-github-azure-ntlmssp - NTLM/Negotiate authentication over HTTP
https://bugzilla.redhat.com/show_bug.cgi?id=1821174 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-azure-ntlmssp -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1123645] Review Request: mingw-libgee - GObject collection library
https://bugzilla.redhat.com/show_bug.cgi?id=1123645 Mattia Verga changed: What|Removed |Added Status|ASSIGNED|CLOSED Blocks||201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Flags|needinfo?(mattia.verga@prot | |onmail.com) | Last Closed||2020-06-04 15:21:34 --- Comment #5 from Mattia Verga --- Just checking old review tickets that seems staled. I'm going to close this one, since you don't want to proceed with it. Thanks. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1835421] Review Request: python-sgmllib3k - Py3k port of sgmllib
https://bugzilla.redhat.com/show_bug.cgi?id=1835421 --- Comment #2 from Luis Bazan --- working on it! Cheers, -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826439] Review Request: libvma - LD_PRELOAD-able library with standard BSD sockets API
https://bugzilla.redhat.com/show_bug.cgi?id=1826439 --- Comment #14 from igor.ivanov...@gmail.com --- The patch is a part of master as https://github.com/Mellanox/libvma/commit/b9aabc058b0524aadff9c756abaf57b660cec63b Thanks, Igor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824848] Review Request: jc - JSONifies the output of dozens of commands
https://bugzilla.redhat.com/show_bug.cgi?id=1824848 Fabian Affolter changed: What|Removed |Added CC||m...@fabian-affolter.ch --- Comment #36 from Fabian Affolter --- I can do the review. Artur, could you please open a new review request and mark this as a duplicate? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1843988] Review Request: python-intreehooks - Load a PEP 517 backend from inside the source tree
https://bugzilla.redhat.com/show_bug.cgi?id=1843988 Miro Hrončok changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG Last Closed||2020-06-04 14:44:32 --- Comment #1 from Miro Hrončok --- Oh: intreehooks is largely obsolete now, as PEP 517 gained a standard mechanism (backend-path) which can achieve the same result without an external package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1843988] New: Review Request: python-intreehooks - Load a PEP 517 backend from inside the source tree
https://bugzilla.redhat.com/show_bug.cgi?id=1843988
Bug ID: 1843988
Summary: Review Request: python-intreehooks - Load a PEP 517
backend from inside the source tree
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nob...@fedoraproject.org
Reporter: mhron...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-intreehooks.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/python-intreehooks-1.0-1.fc32.src.rpm
Description:
In PEP 517, package building backends are not loaded from the source of the
package being built. This prevents accidentally shadowing your build system,
but some packages, like build tools, want to act as their own backend.
%{pypi_name} is a shim to work around this, so that a source tree can be built
by itself.
Fedora Account System Username: churchyard
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821171] Review Request: golang-github-masterzen-simplexml - Go library to generate XML content from a naive DOM
https://bugzilla.redhat.com/show_bug.cgi?id=1821171 --- Comment #2 from Fabian Affolter --- Thank you for reviewing this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821174] Review Request: golang-github-azure-ntlmssp - NTLM/Negotiate authentication over HTTP
https://bugzilla.redhat.com/show_bug.cgi?id=1821174 --- Comment #2 from Fabian Affolter --- Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820843] Review Request: golang-github-bettercap-recording - Allows reading and writing bettercap's session recordings
https://bugzilla.redhat.com/show_bug.cgi?id=1820843 Fabian Affolter changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-06-04 13:59:13 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820915] Review Request: bettercap - Tool for 802.11, BLE/Ethernet reconnaissance and MITM attacks
https://bugzilla.redhat.com/show_bug.cgi?id=1820915 Bug 1820915 depends on bug 1820843, which changed state. Bug 1820843 Summary: Review Request: golang-github-bettercap-recording - Allows reading and writing bettercap's session recordings https://bugzilla.redhat.com/show_bug.cgi?id=1820843 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837019] Review Request: theme-switcher - Switch dark/light GTK theme automatically during day/night
https://bugzilla.redhat.com/show_bug.cgi?id=1837019 --- Comment #7 from Fabio Valentini --- If you want to include this on fedora 31 as well, I think skipping those scriptlets would be a workaround, yes. An alternative would be to include a custom user unit preset file to disable the service by default, but that's more complicated. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837019] Review Request: theme-switcher - Switch dark/light GTK theme automatically during day/night
https://bugzilla.redhat.com/show_bug.cgi?id=1837019
--- Comment #6 from Lyes Saadi ---
So something like this should be done to avoid reproducing the behaviour with
Fedora 31?
%if 0%{?fedora} >= 32
%post
%systemd_user_post %{name}-auto.service
%preun
%systemd_user_preun %{name}-auto.service
%endif
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837019] Review Request: theme-switcher - Switch dark/light GTK theme automatically during day/night
https://bugzilla.redhat.com/show_bug.cgi?id=1837019
Fabio Valentini changed:
What|Removed |Added
CC||decatho...@gmail.com
--- Comment #5 from Fabio Valentini ---
(In reply to Artem from comment #3)
> Hello! Thanks! Added both, %{?systemd_requires} and systemd scriplets. They
> was already before but i removed them due some weird behavior and unit was
> always activated, but this was before 2.0 version, seems fine now. We will
> drop entirely systemd units in future probably.
Maybe the "fixed" systemd user unit behavior is caused by this fedora 32
Change?
https://fedoraproject.org/wiki/Changes/Systemd_presets_for_user_units
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1842042] Review Request: repo2module - A tool to take a yum repository and turn it into a Fedora module stream
https://bugzilla.redhat.com/show_bug.cgi?id=1842042
Fabio Valentini changed:
What|Removed |Added
CC||decatho...@gmail.com
--- Comment #4 from Fabio Valentini ---
(In reply to Jakub Kadlčík from comment #3)
> > repo2module.x86_64: E: no-binary
> >
> > Hmm. no idea what this means :( I am going to ignore this.
>
> Me neither, there definitely is a binary
Please, do not ignore this. It's a valid error. There's no binaries in this
package, only "test files" / scripts.
Since this is a pure-python package, so it should have "BuildArch: noarch", and
then you can - and must - also remove "%global debug_package %{nil}".
I assume you added "%global debug_package %{nil}" because rpmbuild complained
about an empty debug package. This is fixed by marking the package as noarch.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1842042] Review Request: repo2module - A tool to take a yum repository and turn it into a Fedora module stream
https://bugzilla.redhat.com/show_bug.cgi?id=1842042 --- Comment #3 from Jakub Kadlčík --- > repo2module.x86_64: W: spelling-error %description -l en_US yaml -> yam, > yams, yawl > > This should be YAML The problem is that the yaml is a part of filename - modules.yaml . I cannot uppercase it. > repo2module.x86_64: E: no-binary > > Hmm. no idea what this means :( I am going to ignore this. Me neither, there definitely is a binary > repo2module.x86_64: E: non-executable-script > /usr/lib/python3.9/site-packages/repo2module/cli.py 644 /usr/bin/python3 > > remove the executable bit please. Actually there is no executable bit. There is a shebang in the cli.py file but it is not executable. I already created a PR removing it - https://github.com/sgallagher/repo2module/pull/2 Therefore the error will disappear on a new release. Is it good enough? (IMHO it is) or should I request a new upstream release before finishing the package review? > repo2module.x86_64: W: no-manual-page-for-binary repo2module > > This would be nice to have, but I will not block a review on this. Agreed, we will add some in the future. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1708161] Review Request: python-testfixtures - A collection of helpers and mock objects for unit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1708161 --- Comment #12 from Fabian Affolter --- Thanks for the review. (In reply to Mohamed El Morabity from comment #11) > NOTE: you should drop the bundled *.egg-info directory in %prep, as you > recommended me ;). It's always easier to spot the errors which other people are making than my own. ;-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1812435] Review Request: python-beautifultable - Print ASCII tables for terminals
https://bugzilla.redhat.com/show_bug.cgi?id=1812435 --- Comment #5 from Fabian Affolter --- Thanks for the review. (In reply to Mohamed El Morabity from comment #4) > NOTES: > - no significant difference the spec URL and the one in the src.rpm file I will upload a new SRPM. Looks like that I added the bug after the upload. > - you should maybe use a macro for package description, to avoid text > duplication I don't like it as it's additional work if you want to re-use the description outside of the spec file. Also, some day we can get hopefully get rid of the underlaying issue. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1795526] Review Request: ghc-cborg - Concise Binary Object Representation
https://bugzilla.redhat.com/show_bug.cgi?id=1795526 --- Comment #16 from Jens Petersen --- Spec URL: https://petersen.fedorapeople.org/reviews/ghc-cborg/ghc-cborg.spec SRPM URL: https://petersen.fedorapeople.org/reviews/ghc-cborg/ghc-cborg-0.2.2.1-2.fc32.src.rpm fix permissions of ChangeLog.md (#1795526) Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=45406627 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1795526] Review Request: ghc-cborg - Concise Binary Object Representation
https://bugzilla.redhat.com/show_bug.cgi?id=1795526
--- Comment #15 from Jens Petersen ---
Hi Elliot, thanks for updating the review:
(In reply to Elliott Sales de Andrade from comment #14)
> These two should be fixed:
>
> [!]: Package must own all directories that it creates.
> Note: Directories without known owners:
> /usr/share/doc/ghc/html/libraries, /usr/share/doc/ghc/html,
> /usr/share/doc/ghc
Good catch, thanks!
I have fixed this in ghc-rpm-macros-2.0.9-1.fc33 .
> ghc-cborg-devel.x86_64: W: spurious-executable-perm
> /usr/share/doc/ghc-cborg-devel/ChangeLog.md
Yes, thanks, fixing - I worked around this cabal-install bug recently in
cabal-rpm.
> and I'm not sure about this one:
>
> [?]: Fully versioned dependency in subpackages if applicable.
> Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ghc-
> cborg-prof
ghc-cborg-prof has
Requires: %{name}-devel%{?_isa} = %{version}-%{release}
which in turn has
Requires: %{name}%{?_isa} = %{version}-%{release}
So I think that is okay.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1835367] Review Request: python-chm - Python package for CHM files handling
https://bugzilla.redhat.com/show_bug.cgi?id=1835367 Fabian Affolter changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #8 from Fabian Affolter --- Issues were addressed, package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823117] Review Request: opensurge - 2D retro platformer inspired by Sonic games
https://bugzilla.redhat.com/show_bug.cgi?id=1823117
Antonio T. sagitter changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #20 from Antonio T. sagitter ---
Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file LICENSE-GothicA1.ttf.txt is not marked as %license
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/LicensingGuidelines/#_license_text
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GPL (v3 or later)", "SIL Open Font
License 1.1", "Expat License", "*No copyright* Public domain", "*No
copyright* Do What The Fuck You Want To Public License, Version 2",
"GNU Lesser General Public License (v2.1 or later)". 537 files have
unknown license. Detailed output of licensecheck in
/home/sagitter/1823117-opensurge/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Avoid bundling fonts in non-fonts packages.
Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
file from upstream,
[Bug 1823117] Review Request: opensurge - 2D retro platformer inspired by Sonic games
https://bugzilla.redhat.com/show_bug.cgi?id=1823117 Antonio T. sagitter changed: What|Removed |Added CC||trp...@rocketmail.com --- Comment #19 from Antonio T. sagitter --- I'm reviewing again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824848] Review Request: jc - JSONifies the output of dozens of commands
https://bugzilla.redhat.com/show_bug.cgi?id=1824848 --- Comment #35 from Artur Iwicki --- There's nothing in Fedora policies preventing upstream developers from being package maintainers for their own software in Fedora, and there's quite a few packages where the maintainer is upstream. I could take this, but I guess that would require someone to do a re-review, since otherwise I'd be reviewing and approving my own package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815670] Review Request: python-claripy - An abstraction layer for constraint solvers
https://bugzilla.redhat.com/show_bug.cgi?id=1815670 --- Comment #6 from Mohamed El Morabity --- Version 8.20.6.1 is available ;) In the .spec file: > # Remove installation requirement. Fedora is using a different name, see above > sed -i -e '19d' setup.py I understand the need to modify the setup.py file to fix automatic Requires. However you shouldn't use an hard-coded line number to delete the z3-solver requirement. Using a pattern may be better, especially if setup.py grows in further updates: sed -i -e '/z3-solver/d' setup.py -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820895] Review Request: cxxopts - Lightweight C++ command line option parser
https://bugzilla.redhat.com/show_bug.cgi?id=1820895 Vitaly Zaitsev changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2020-06-04 08:39:44 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1824848] Review Request: jc - JSONifies the output of dozens of commands
https://bugzilla.redhat.com/show_bug.cgi?id=1824848 --- Comment #34 from Petr Pisar --- A package maintainer does not have the author of the software. You can ask someone else to maintain this package in Fedora. (But don't count on me. I already look after another thousand packages.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815670] Review Request: python-claripy - An abstraction layer for constraint solvers
https://bugzilla.redhat.com/show_bug.cgi?id=1815670 Mohamed El Morabity changed: What|Removed |Added CC||pikachu.2...@gmail.com Assignee|nob...@fedoraproject.org|pikachu.2...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1123645] Review Request: mingw-libgee - GObject collection library
https://bugzilla.redhat.com/show_bug.cgi?id=1123645 Marc-Andre Lureau changed: What|Removed |Added Flags|needinfo?(marcandre.lureau@ |needinfo?(mattia.verga@prot |redhat.com) |onmail.com) --- Comment #4 from Marc-Andre Lureau --- Hi Martin, I have no interest anymore. Would you like to pick it up, or should we close this bug? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1843426] Review Request: perl-Test2 - Framework for writing test tools that all work together
https://bugzilla.redhat.com/show_bug.cgi?id=1843426 --- Comment #3 from Fedora Update System --- FEDORA-EPEL-2020-1e6db211d2 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-1e6db211d2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1843426] Review Request: perl-Test2 - Framework for writing test tools that all work together
https://bugzilla.redhat.com/show_bug.cgi?id=1843426 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|MODIFIED Fixed In Version||perl-Test2-0.44-3.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1812435] Review Request: python-beautifultable - Print ASCII tables for terminals
https://bugzilla.redhat.com/show_bug.cgi?id=1812435
Mohamed El Morabity changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #4 from Mohamed El Morabity ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License", "*No copyright* Expat
License". 31 files have unknown license. Detailed output of
licensecheck in /home/mohamed/Documents/1812435-python-
beautifultable/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python3-beautifultable
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files
[Bug 1812435] Review Request: python-beautifultable - Print ASCII tables for terminals
https://bugzilla.redhat.com/show_bug.cgi?id=1812435 Mohamed El Morabity changed: What|Removed |Added Status|NEW |ASSIGNED CC||pikachu.2...@gmail.com Assignee|nob...@fedoraproject.org|pikachu.2...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
