[Bug 1835452] Review Request: mlxbf-bootctl - Bootloader control for Mellanox BlueField
https://bugzilla.redhat.com/show_bug.cgi?id=1835452 Honggang LI changed: What|Removed |Added Assignee|nob...@fedoraproject.org|ho...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1835452] Review Request: mlxbf-bootctl - Bootloader control for Mellanox BlueField
https://bugzilla.redhat.com/show_bug.cgi?id=1835452 Honggang LI changed: What|Removed |Added Flags||needinfo?(mschmidt@redhat.c ||om) --- Comment #8 from Honggang LI --- (In reply to Spencer Lingard from comment #6) > Spec URL: > https://download.copr.fedorainfracloud.org/results/slingard/mlxbf-bootctl/ > fedora-rawhide-aarch64/01476093-mlxbf-bootctl/mlxbf-bootctl.spec 27 %build 28 %make_build Need to setup the CFLAGS. Please insert %set_build_flags between line 27 and 28. see https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md https://kojipkgs.fedoraproject.org//work/tasks/5292/45835292/build.log + cd mlxbf-bootctl-1.1 + /usr/bin/make -O -j5 V=1 VERBOSE=1 cc -O2 -g -std=gnu99 -Werror -Wall -Wshadow -Wuninitialized -Wstrict-overflow -Wundef -Wold-style-definition -Wwrite-strings -MD -MP -c -o mlxbf-bootctl.o mlxbf-bootctl.c cc -Wl,--fatal-warnings -o mlxbf-bootctl mlxbf-bootctl.o @Michal Could you please have a look? I'm almost OK with the spec file. I had checked 'fedora-review' result for this request. It looks almost good. If you are OK with the spec file. I will set the 'fedora-review+' flag, and post the fedora-review result.txt. Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848205] Review Request: rust-cargo-insta - Review tool for the insta snapshot testing library for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1848205 Igor Raits changed: What|Removed |Added Status|NEW |POST CC||igor.ra...@gmail.com Assignee|nob...@fedoraproject.org|igor.ra...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Igor Raits --- Please fix license of the the binary subpackage during the import. https://pagure.io/fedora-rust/rust2rpm/blob/master/f/tools/fedora-helper.py should help with that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848204] Review Request: rust-insta - Snapshot testing library for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1848204 Igor Raits changed: What|Removed |Added Status|NEW |POST CC||igor.ra...@gmail.com Assignee|nob...@fedoraproject.org|igor.ra...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #2 from Igor Raits --- > # thread 'runtime::test_format_rust_expression' panicked at 'snapshot > assertion > # for 'format_rust_expression' failed in line 90', src/runtime.rs:995:9 Please report to upstream and put a link here too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1835452] Review Request: mlxbf-bootctl - Bootloader control for Mellanox BlueField
https://bugzilla.redhat.com/show_bug.cgi?id=1835452 --- Comment #7 from Honggang LI --- Confirmed all issues found by Coverity had been fixed in https://download.copr.fedorainfracloud.org/results/slingard/mlxbf-bootctl/fedora-rawhide-aarch64/01476093-mlxbf-bootctl/mlxbf-bootctl-1.1-5.fc33.src.rpm . Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456 lnie changed: What|Removed |Added Flags|needinfo?(l...@redhat.com) | --- Comment #16 from lnie --- Hi Richard, (In reply to Richard W.M. Jones from comment #15) > I was chatting with Miro on IRC and he thinks the Requires: /usr/bin/python > which is generated may be incorrect. (I don't really know). > > 17:25 < mhroncok> rwmjones: the /usr/bin/python require is generated by the > "template" files > 17:26 < mhroncok> rwmjones: hence I suppose the runtime requirement should > not be generated by them, as they will not be executed on the system where > the package is installed > 17:27 < mhroncok> rwmjones: the filter will make them be not considered when > generating the requires > > There is a way to filter out the require, but I'm not very clear if > someone installing libvirt-test-api would require /usr/bin/python > in order to use the package at all, or if it's optional. /usr/bin/python requires is generated by jenkins.py and virtlab.py in excute dir. jenkins.py is used by virt-QE to work with libvirt-ci,and virt-QE also use virtlab.py frequently. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821902] Review Request: golang-github-dgryski-farm - Farmhash implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1821902 Hirotaka Wakabayashi changed: What|Removed |Added Status|NEW |ASSIGNED CC||hiw...@yahoo.com Assignee|nob...@fedoraproject.org|hiw...@yahoo.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821864] Review Request: golang-github-dennwc-base - Common Go interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1821864
Hirotaka Wakabayashi changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #1 from Hirotaka Wakabayashi ---
Hello Fabian,
Upstream doesn't provide tests but could you ask upstream to add test cases
for the user stability and peace? Because unit tests are must in Golang
Guidelines because API breakages are frequent in Go especially when upstream
doesn't choses semantic versioning. Please see:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_testing
Package approved.
Thanks in advance,
Hirotaka Wakabayashi
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package does not own files or directories owned by other packages.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags
[Bug 1848072] Review Request: rust-ssh-key-dir - sshd AuthorizedKeysCommand to read ~/.ssh/authorized_keys.d
https://bugzilla.redhat.com/show_bug.cgi?id=1848072 --- Comment #4 from Benjamin Gilbert --- The behavior we want is: SIGHUP sshd on initial install, SIGHUP on upgrades, and SIGHUP on removal. We use systemctl try-reload-or-restart because we want the try- behavior (don't fail if sshd isn't running); systemctl doesn't have a try-reload. %systemd_postun_with_restart does a restart rather than reload, and %systemd_post isn't useful because we don't need any presets applied. I've updated the spec to avoid reloading twice on package upgrades, and also to correctly associate the scriptlets with the subpackage. :-/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821864] Review Request: golang-github-dennwc-base - Common Go interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1821864 Hirotaka Wakabayashi changed: What|Removed |Added Status|NEW |ASSIGNED CC||hiw...@yahoo.com Assignee|nob...@fedoraproject.org|hiw...@yahoo.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821809] Review Request: golang-github-sourcemap - Source maps consumer
https://bugzilla.redhat.com/show_bug.cgi?id=1821809 --- Comment #1 from Hirotaka Wakabayashi --- Hello Fabian, I'm not sure, but no tests seem not to have run in %check. The spec file looks good. If you know anything, please tell me. Here is an excerpt of my rpmbuild log. ``` Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.Z0UYtg + umask 022 + cd /home/vagrant/rpmbuild/BUILD + cd sourcemap-2.1.3 + LDFLAGS='-X github.com/go-sourcemap/sourcemap/version=2.1.3' + GO_TEST_FLAGS='-buildmode pie -compiler gc' + GO_TEST_EXT_LD_FLAGS='-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld ' + go-rpm-integration check -i github.com/go-sourcemap/sourcemap -b /home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/_build/bin -s /home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/_build -V 2.1.3-1.fc33 -p /home/vagrant/rpmbuild/BUILDROOT/golang-github-sourcemap-2.1.3-1.fc33.x86_64 -g /usr/share/gocode -r '.*example.*' Testingin: /home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/_build/src PATH: /home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/_build/bin:/home/vagrant/.local/bin:/home/vagrant/bin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin GOPATH: /home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/_build:/usr/share/gocode GO111MODULE: off command: go test -buildmode pie -compiler gc -ldflags "-X github.com/go-sourcemap/sourcemap/version=2.1.3 -extldflags '-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '" testing: github.com/go-sourcemap/sourcemap + RPM_EC=0 ++ jobs -p + exit 0 ``` I find this upstream prepares tests and I could run. ``` [vagrant@localhost sourcemap-2.1.3]$ export GOPATH=/home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/_build:/usr/share/gocode [vagrant@localhost sourcemap-2.1.3]$ make go test ./... ok _/home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3 0.315s ok _/home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/internal/base64vlq 0.002s go test ./... -short -race ok _/home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3 0.373s ok _/home/vagrant/rpmbuild/BUILD/sourcemap-2.1.3/internal/base64vlq 0.029s go vet ``` Thanks in advance, Hirotaka Wakabayashi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848049] Review Request: python-pysignals - a signal dispatcher for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1848049 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #5 from Fedora Update System --- FEDORA-2020-da6e2e377e has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-da6e2e377e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848205] New: Review Request: rust-cargo-insta - Review tool for the insta snapshot testing library for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1848205 Bug ID: 1848205 Summary: Review Request: rust-cargo-insta - Review tool for the insta snapshot testing library for Rust Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: ego.corda...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://atim.fedorapeople.org//rust-cargo-insta.spec SRPM URL: https://atim.fedorapeople.org//rust-cargo-insta-0.16.0-1.fc33.src.rpm Description: Review tool for the insta snapshot testing library for Rust. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848204] Review Request: rust-insta - Snapshot testing library for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1848204 --- Comment #1 from Artem --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=45839490 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848204] New: Review Request: rust-insta - Snapshot testing library for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1848204 Bug ID: 1848204 Summary: Review Request: rust-insta - Snapshot testing library for Rust Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: ego.corda...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://atim.fedorapeople.org//rust-insta.spec SRPM URL: https://atim.fedorapeople.org//rust-insta-0.16.0-1.fc33.src.rpm Description: Snapshot testing library for Rust. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 --- Comment #19 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/antimicroX -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839480] Review Request: python-opentelemetry - The OpenTelemetry Python client
https://bugzilla.redhat.com/show_bug.cgi?id=1839480 --- Comment #1 from Mohamed El Morabity --- Update to 0.8.0: Spec URL: https://download.copr.fedorainfracloud.org/results/melmorabity/python-azure-sdk-5/fedora-rawhide-x86_64/01477220-python-opentelemetry/python-opentelemetry.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/melmorabity/python-azure-sdk-5/fedora-rawhide-x86_64/01477220-python-opentelemetry/python-opentelemetry-0.8.0-1.fc33.src.rpm Note: this is not the latest release available (0.9.0), which strictly requires gprc >= 1.27. Only gcpr 1.26 is available at the moment in Fedora (Rawhide and stable releases). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839479] Review Request: python-opencensus - A stats collection and distributed tracing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1839479 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #4 from Fedora Update System --- FEDORA-2020-8a0be5567f has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-8a0be5567f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1820915] Review Request: bettercap - Tool for 802.11, BLE/Ethernet reconnaissance and MITM attacks
https://bugzilla.redhat.com/show_bug.cgi?id=1820915 --- Comment #8 from Germano Massullo --- any news? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848072] Review Request: rust-ssh-key-dir - sshd AuthorizedKeysCommand to read ~/.ssh/authorized_keys.d
https://bugzilla.redhat.com/show_bug.cgi?id=1848072 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com --- Comment #3 from Neal Gompa --- %systemd_postun_with_restart should do what you want for postun, which would happen on every upgrade. %systemd_post would run on initial install to preset. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848072] Review Request: rust-ssh-key-dir - sshd AuthorizedKeysCommand to read ~/.ssh/authorized_keys.d
https://bugzilla.redhat.com/show_bug.cgi?id=1848072 --- Comment #2 from Benjamin Gilbert --- Updated. Added post/postun dependencies on systemd and openssh-server, updated install flags, and unconditionalized invocation of systemctl. > What about %systemd_post sshd.service? The %systemd_* macros don't do what we need here; in particular, %systemd_post activates a preset. Since we're adding/updating/removing an sshd_config.d fragment, we need to reload sshd to pick up the changes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1835452] Review Request: mlxbf-bootctl - Bootloader control for Mellanox BlueField
https://bugzilla.redhat.com/show_bug.cgi?id=1835452
Spencer Lingard changed:
What|Removed |Added
Flags|needinfo?(spencer@mellanox. |
|com)|
--- Comment #6 from Spencer Lingard ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/slingard/mlxbf-bootctl/fedora-rawhide-aarch64/01476093-mlxbf-bootctl/mlxbf-bootctl.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/slingard/mlxbf-bootctl/fedora-rawhide-aarch64/01476093-mlxbf-bootctl/mlxbf-bootctl-1.1-5.fc33.src.rpm
Scratch Koji URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=45835273
New version for review.
(In reply to Honggang LI from comment #2)
> 1Name: mlxbf-bootctl
> 2Version: 1.1
> 3%{!?_release: %define _release 4}
> 4Release: %{_release}%{?dist}
> Please delete line 3, and replace "%{_release}" with 4 for line 4.
Done.
>
> 5Summary: Mellanox BlueField boot partition management utility
> 6
> 7License: BSD
> 8Url: https://github.com/Mellanox/mlxbf-bootctl
> 9Source: mlxbf-bootctl-1.1.tar.gz
> 10
> 11ExclusiveArch: aarch64
>
> Need a comment for "ExclusiveArch", see
> https://fedoraproject.org/wiki/Packaging:ReviewGuidelines
Done.
>
> 12
> 13BuildRequires: binutils
> 14BuildRequires: gcc
>
> line 13 should be deleted, as gcc requires binutils.
>
> $ rpm -qR gcc | grep binutils
> binutils >= 2.31
Done.
>
> 15
> 16%description
> 17Access to all the boot partition management is via a program
> shipped
> 18with the BlueField software called "mlxbf-bootctl".
>
> I have no idea what is main function or feature of this package after read
> this
> '%description' section. Please improve it.
Done.
>
> 19
> 20%prep
> 21%setup -q -n mlxbf-bootctl-1.1
>
> "%setup -q" should be enough, in case
> 1) top directory name was in format "%{name}-%{version}/"
> 2) tarball name was in format "%{name}-%{version}.XXX"
This spec file is generated by rpkg
(https://github.com/Mellanox/mlxbf-bootctl/blob/master/mlxbf-bootctl.spec.rpkg).
As far as I can tell, I can't change the way rpkg generates the %setup macro.
>
> 22
> 23%build
> 24%make_build
> 25
> 26%install
> 27%make_install
> 28%{__install} -d %{buildroot}%{_mandir}/man8
> 29%{__install} -m 0644 mlxbf-bootctl.8 %{buildroot}%{_mandir}/man8
> 30
> 31%files
> 32%defattr(-, root, root)
> line 32 is unnecessary, please remove it.
Done.
>
> 33/sbin/*
> should install programs in %{_sbindir}, and use %{_sbindir}/XXX, XXX is the
> program name.
Done.
>
> 34%{_mandir}/man8/mlxbf-bootctl.8.gz
> 35
> 36%license LICENSE
> 37%doc mlxbf-bootctl.txt
> 38
> 39%changelog
> 40* Wed Jun 10 2020 Spencer Lingard 1.1-4
> 41(none)
> 42
> 43* Tue May 12 2020 Spencer Lingard 1.1-3
> 44(none)
>
> line 41 and 44 are unnecessary, should be deleted.
Changed them to be more detailed.
(In reply to Honggang LI from comment #3)
> Task URL: https://cov01.lab.eng.brq.redhat.com/covscanhub/task/175416/
> Comment: None
>
>
> All defects
>
> CHECKED_RETURN1
> CLANG_WARNING 1
> CPPCHECK_WARNING 1
>
> ==
> mlxbf-bootctl-1.1-4.fc31
> List of Defects
>
> Error: CPPCHECK_WARNING (CWE-664): [#def1]
> mlxbf-bootctl-1.1/mlxbf-bootctl.c:60: error[va_end_missing]: va_list 'ap'
> was opened but not closed by va_end().
> # 58| putc('\n', stderr);
> # 59| exit(1);
> # 60|-> }
> # 61|
> # 62| #ifndef OUTPUT_ONLY
Fixed.
>
> Error: CLANG_WARNING: [#def2]
> mlxbf-bootctl-1.1/mlxbf-bootctl.c:545:5: warning: Null pointer passed to 1st
> parameter expecting 'nonnull'
> #memset(buf + seg_size, 0, pad_size);
> #^
This is a false positive. The tool assumes that (buf == NULL) at line 524, but
if buf == NULL, the program will die with an error message rather than
continuing. See the note below.
> mlxbf-bootctl-1.1/mlxbf-bootctl.c:644:10: note: Assuming the condition is
> true
> # while ((opt = getopt_long(argc, argv, short_options, long_options, NULL))
> # ^~
> mlxbf-bootctl-1.1/mlxbf-bootctl.c:644:3: note: Loop condition is true.
> Entering loop body
> # while ((opt = getopt_long(argc, argv, short_options, long_options, NULL))
> # ^
> mlxbf-bootctl-1.1/mlxbf-bootctl.c:647:5:
[Bug 1847743] Review Request: R-BiocFileCache - Manage Files Across Sessions
https://bugzilla.redhat.com/show_bug.cgi?id=1847743 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-BiocFileCache -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848049] Review Request: python-pysignals - a signal dispatcher for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1848049 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pysignals -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848072] Review Request: rust-ssh-key-dir - sshd AuthorizedKeysCommand to read ~/.ssh/authorized_keys.d
https://bugzilla.redhat.com/show_bug.cgi?id=1848072
--- Comment #1 from Igor Raits ---
Two small comments:
> install -D -m 644 -t %{buildroot}%{_sysconfdir}/ssh/sshd_config.d
> conf/40-ssh-key-dir.conf
install -Dpm0644 -t %{buildroot}%{_sysconfdir}/ssh/sshd_config.d
conf/40-ssh-key-dir.conf
> if [ -x /usr/bin/systemctl ]; then
> /usr/bin/systemctl try-reload-or-restart sshd.service
> fi
Not really happy about this one... What about %systemd_post sshd.service?
Also you'll need to have Requires(post): openssh-server Probably for postun
too, but not sure.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848072] Review Request: rust-ssh-key-dir - sshd AuthorizedKeysCommand to read ~/.ssh/authorized_keys.d
https://bugzilla.redhat.com/show_bug.cgi?id=1848072 Igor Raits changed: What|Removed |Added CC||igor.ra...@gmail.com Summary|Review Request: ssh-key-dir |Review Request: |- sshd |rust-ssh-key-dir - sshd |AuthorizedKeysCommand to|AuthorizedKeysCommand to |read|read |~/.ssh/authorized_keys.d|~/.ssh/authorized_keys.d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837107] Review Request: 7kaa - Seven Kingdoms: Ancient Adversaries (claiming ownership of package)
https://bugzilla.redhat.com/show_bug.cgi?id=1837107 --- Comment #15 from Andy Mender --- So far I haven't received any news from RPMFusion. Meanwhile, I removed the use of licensed music files from the spec file. Latest spec and build logs are available here: Spec URL: https://github.com/AndyMender/7kaa-rpm/blob/f32/7kaa.spec CORP builds: https://copr.fedorainfracloud.org/coprs/andymenderunix/7kaa/build/1475177/ Is there anything I should still change? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 --- Comment #18 from Gergely Gombos --- Will do, thanks for reviewing! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850
Alexander Ploumistos changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #17 from Alexander Ploumistos ---
Three little things left to do before the first build, mentioned in detail in
the template text:
1. Requires: shared-mime-info
2. %license in antimicroX-libantilib-devel
3. File a blocking bug for the ExcludeArch
Everything else seems fine, package is approved!
Nicely done Gergely!
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[!]: License file installed when any subpackage combination is installed.
Since antimicroX-libantilib-devel requires antimicroX-libantilib, you can just
add it to the antimicroX-libantilib %files section:
%files %{libname}
%license LICENSE
%{_libdir}/%{libname}.so.1
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/mime/packages,
/usr/share/mime
Add "Requires: shared-mime-info"
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[!]: Package is not known to require an ExcludeArch tag.
You need to file a bug once the package is approved and also mark it as
blocking
https://bugzilla.redhat.com/show_bug.cgi?id=F-ExcludeArch-ARM
Once that bug is files, add the bug number to the spec file in a comment next
to the ExcludeArch tag.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 61440 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 --- Comment #16 from Alexander Ploumistos --- Finally made it home, I'm currently running a local build. In the meantime, you can add a Requires: shared-mime-info if you feel that I'm running late, but I don't think there's anything else left to do, you can add it when you make the "official" build. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839242] Review Request: python-ouimeaux - Open source control for Belkin WeMo devices
https://bugzilla.redhat.com/show_bug.cgi?id=1839242 --- Comment #13 from Andrew Bauer --- And the fun never stops... I just discovered a custom subclass, called StateChange, which was added to the bundled pysignals, but is not part of the upstream pysignals project. I've opened an issue with the author here to decide how to proceed: https://github.com/iancmcc/ouimeaux/issues/205 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456 Richard W.M. Jones changed: What|Removed |Added Flags||needinfo?(l...@redhat.com) --- Comment #15 from Richard W.M. Jones --- I was chatting with Miro on IRC and he thinks the Requires: /usr/bin/python which is generated may be incorrect. (I don't really know). 17:25 < mhroncok> rwmjones: the /usr/bin/python require is generated by the "template" files 17:26 < mhroncok> rwmjones: hence I suppose the runtime requirement should not be generated by them, as they will not be executed on the system where the package is installed 17:27 < mhroncok> rwmjones: the filter will make them be not considered when generating the requires There is a way to filter out the require, but I'm not very clear if someone installing libvirt-test-api would require /usr/bin/python in order to use the package at all, or if it's optional. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847743] Review Request: R-BiocFileCache - Manage Files Across Sessions
https://bugzilla.redhat.com/show_bug.cgi?id=1847743 Tom "spot" Callaway changed: What|Removed |Added Assignee|nob...@fedoraproject.org|i.uca...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848074] Review Request: rust-pq-sys - Auto-generated rust bindings for libpq
https://bugzilla.redhat.com/show_bug.cgi?id=1848074 Igor Raits changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-06-17 16:24:47 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848067] Review Request: rust-dns-lookup - Simple dns resolving api, much like rust's unstable api
https://bugzilla.redhat.com/show_bug.cgi?id=1848067 Igor Raits changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-06-17 16:19:20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848071] Review Request: rust-fake - Easy to use library for generating fake data
https://bugzilla.redhat.com/show_bug.cgi?id=1848071 Igor Raits changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-06-17 16:19:15 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839242] Review Request: python-ouimeaux - Open source control for Belkin WeMo devices
https://bugzilla.redhat.com/show_bug.cgi?id=1839242 --- Comment #12 from Andrew Bauer --- All action items have been completed. UPDATE SPECFILE URL: https://raw.githubusercontent.com/knight-of-ni/specfiles/master/python-ouimeaux.spec UPDATED SRPM URL: https://download.copr.fedorainfracloud.org/results/kni/ouimeaux-fedora/fedora-rawhide-x86_64/01470047-python-ouimeaux/python-ouimeaux-0.8.2-6.fc33.src.rpm NOTE: I will add a build override for recently approved pysignals package as soon as I am able. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848074] Review Request: rust-pq-sys - Auto-generated rust bindings for libpq
https://bugzilla.redhat.com/show_bug.cgi?id=1848074 --- Comment #2 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pq-sys -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848067] Review Request: rust-dns-lookup - Simple dns resolving api, much like rust's unstable api
https://bugzilla.redhat.com/show_bug.cgi?id=1848067 --- Comment #2 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-dns-lookup -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848049] Review Request: python-pysignals - a signal dispatcher for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1848049 --- Comment #3 from Andrew Bauer --- https://pagure.io/releng/fedora-scm-requests/issue/25795 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848071] Review Request: rust-fake - Easy to use library for generating fake data
https://bugzilla.redhat.com/show_bug.cgi?id=1848071 --- Comment #2 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-fake -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848049] Review Request: python-pysignals - a signal dispatcher for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1848049 --- Comment #2 from Andrew Bauer --- Done, and thank you. UPDATED SPECFILE URL: https://raw.githubusercontent.com/knight-of-ni/specfiles/master/python-pysignals.spec UPDATED SRPM URL: https://download.copr.fedorainfracloud.org/results/kni/ouimeaux-fedora/fedora-rawhide-x86_64/01470186-python-pysignals/python-pysignals-0.1.2-2.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836568] Review Request: python-graphql-relay - Relay library for graphql-core-next
https://bugzilla.redhat.com/show_bug.cgi?id=1836568 --- Comment #9 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-graphql-relay -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844837] Review Request: asnip - ASN detail retriever
https://bugzilla.redhat.com/show_bug.cgi?id=1844837 --- Comment #2 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/asnip -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 --- Comment #15 from Gergely Gombos --- Added it! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821808] Review Request: golang-github-badgerodon-peg - Parsing Expression Grammer Parser
https://bugzilla.redhat.com/show_bug.cgi?id=1821808 --- Comment #3 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-badgerodon-peg -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848074] Review Request: rust-pq-sys - Auto-generated rust bindings for libpq
https://bugzilla.redhat.com/show_bug.cgi?id=1848074 Neal Gompa changed: What|Removed |Added Status|NEW |POST CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Neal Gompa --- Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848071] Review Request: rust-fake - Easy to use library for generating fake data
https://bugzilla.redhat.com/show_bug.cgi?id=1848071 Neal Gompa changed: What|Removed |Added Status|NEW |POST CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Neal Gompa --- Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848067] Review Request: rust-dns-lookup - Simple dns resolving api, much like rust's unstable api
https://bugzilla.redhat.com/show_bug.cgi?id=1848067 Neal Gompa changed: What|Removed |Added Status|NEW |POST CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Neal Gompa --- Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848074] New: Review Request: rust-pq-sys - Auto-generated rust bindings for libpq
https://bugzilla.redhat.com/show_bug.cgi?id=1848074 Bug ID: 1848074 Summary: Review Request: rust-pq-sys - Auto-generated rust bindings for libpq Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: igor.ra...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-pq-sys.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-pq-sys-0.4.6-1.fc33.src.rpm Description: Auto-generated rust bindings for libpq. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848072] New: Review Request: ssh-key-dir - sshd AuthorizedKeysCommand to read ~/.ssh/authorized_keys.d
https://bugzilla.redhat.com/show_bug.cgi?id=1848072 Bug ID: 1848072 Summary: Review Request: ssh-key-dir - sshd AuthorizedKeysCommand to read ~/.ssh/authorized_keys.d Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: bgilb...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fedorapeople.org/~bgilbert/ssh-key-dir/rust-ssh-key-dir.spec SRPM URL: https://fedorapeople.org/~bgilbert/ssh-key-dir/rust-ssh-key-dir-0.1.1-1.fc31.src.rpm Description: sshd AuthorizedKeysCommand to read key files from ~/.ssh/authorized_keys.d. Fedora Account System Username: bgilbert -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848049] Review Request: python-pysignals - a signal dispatcher for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1848049
Fabian Affolter changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Fabian Affolter ---
- LICENSE file is available in the upstream repo. Please download it as
"Source1:" and add it a %license.
Please add the license file before the import.
Package APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 10 files have unknown license. Detailed
output of licensecheck in
/home/fab/Documents/repos/reviews/1848049-python-
pysignals/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[!]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are
[Bug 1848049] Review Request: python-pysignals - a signal dispatcher for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1848049 Fabian Affolter changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@fabian-affolter.ch Assignee|nob...@fedoraproject.org|m...@fabian-affolter.ch Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848071] New: Review Request: rust-fake - Easy to use library for generating fake data
https://bugzilla.redhat.com/show_bug.cgi?id=1848071 Bug ID: 1848071 Summary: Review Request: rust-fake - Easy to use library for generating fake data Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: igor.ra...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-fake.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-fake-2.2.2-1.fc33.src.rpm Description: Easy to use library for generating fake data like name, number, address, lorem, dates, etc. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848067] New: Review Request: rust-dns-lookup - Simple dns resolving api, much like rust's unstable api
https://bugzilla.redhat.com/show_bug.cgi?id=1848067 Bug ID: 1848067 Summary: Review Request: rust-dns-lookup - Simple dns resolving api, much like rust's unstable api Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: igor.ra...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-dns-lookup.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-dns-lookup-1.0.3-1.fc33.src.rpm Description: Simple dns resolving api, much like rust's unstable api. Also includes getaddrinfo and getnameinfo wrappers for libc variants. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836568] Review Request: python-graphql-relay - Relay library for graphql-core-next
https://bugzilla.redhat.com/show_bug.cgi?id=1836568 --- Comment #8 from Fabian Affolter --- Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848027] Review Request: perl-SQL-Abstract-Classic - Generate SQL from Perl data structures
https://bugzilla.redhat.com/show_bug.cgi?id=1848027 Petr Pisar changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar --- The Url and Source0 addresses are Ok. A Source0 archive (SHA-256: 4e3d1dfd095b2123268586bb06b86929ea571388d4e941acccbdcda1e108ef28) is original. Ok. Summary verified from lib/SQL/Abstract/Classic.pm. Ok. Description verified from lib/SQL/Abstract/Classic.pm. Ok. License verified from lib/SQL/Abstract/Classic.pm and Makefile.PL. Ok. No XS code, noarch BuildArch is Ok. Test::Deep is not used. Ok. MRO::Compat is not used with recent perl. Ok. All tests pass. Ok. $ rpmlint perl-SQL-Abstract-Classic.spec ../SRPMS/perl-SQL-Abstract-Classic-1.91-1.fc33.src.rpm ../RPMS/noarch/perl-SQL-Abstract-Classic-1.91-1.fc33.noarch.rpm sh: /usr/bin/python2: No such file or directory 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-SQL-Abstract-Classic-1.91-1.fc33.noarch.rpm drwxr-xr-x2 root root0 Jun 17 17:17 /usr/share/doc/perl-SQL-Abstract-Classic -rw-r--r--1 root root16163 Oct 17 2019 /usr/share/doc/perl-SQL-Abstract-Classic/Changes -rw-r--r--1 root root17109 Jun 17 17:16 /usr/share/man/man3/SQL::Abstract::Classic.3pm.gz -rw-r--r--1 root root 2284 Jun 17 17:16 /usr/share/man/man3/SQL::Abstract::Util.3pm.gz drwxr-xr-x2 root root0 Jun 17 17:16 /usr/share/perl5/vendor_perl/SQL drwxr-xr-x2 root root0 Jun 17 17:16 /usr/share/perl5/vendor_perl/SQL/Abstract -rw-r--r--1 root root89689 Oct 17 2019 /usr/share/perl5/vendor_perl/SQL/Abstract/Classic.pm -rw-r--r--1 root root 4985 Oct 17 2019 /usr/share/perl5/vendor_perl/SQL/Abstract/Util.pm The file permissions and a layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-SQL-Abstract-Classic-1.91-1.fc33.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.30.3) 1 perl(Carp) 1 perl(Exporter) >= 5.57 1 perl(List::Util) 1 perl(mro) 1 perl(Scalar::Util) 1 perl(SQL::Abstract) >= 1.79 1 perl(SQL::Abstract::Util) 1 perl(strict) 1 perl(Text::Balanced) >= 2.00 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 FIX: Drop a run-time dependency on SQL::Abstract. It's not used anywhere. Probably a remnant of forking from SQL::Abstract. I can see that it's there because of a version of SQL::Abstract::Test. But SQL::Abstract::Test is used only when the tests are performed. $ rpm -q --provides -p ../RPMS/noarch/perl-SQL-Abstract-Classic-1.91-1.fc33.noarch.rpm | sort -f | uniq -c 1 perl(SQL::Abstract::Classic) = 1.91 1 perl(SQL::Abstract::Util) 1 perl-SQL-Abstract-Classic = 1.91-1.fc33 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-SQL-Abstract-Classic-1.91-1.fc33.noarch.rpm Binary dependencies are resolvable. Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the 'FIX' item before building the package. Resolution: Package APPROVED. The package builds in Fedora 33 (https://koji.fedoraproject.org/koji/taskinfo?taskID=45828264). OK. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836568] Review Request: python-graphql-relay - Relay library for graphql-core-next
https://bugzilla.redhat.com/show_bug.cgi?id=1836568
Javier Peña changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags||fedora-review+
--- Comment #7 from Javier Peña ---
Thanks for the changes. Here is the fedora-review output.
Review notes:
- The fedora-review complaint about the package not being able to install
properly are caused because python3-graphql-core is not yet available from the
Fedora Rawhide repos (it is available on the buildroot, though). I have
manually tested installation of the package together with
python3-graphql-core-3.1.1-1.fc33.noarch.rpm and it works correctly.
- Fedora-review is mistakenly recognizing the license as Expat, when it is MIT
(correctly identified in the spec file).
The package is APPROVED, please go on with the SCM request.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License". 54 files have unknown
license. Detailed output of licensecheck in /tmp/1836568-python-
graphql-relay/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[Bug 1839242] Review Request: python-ouimeaux - Open source control for Belkin WeMo devices
https://bugzilla.redhat.com/show_bug.cgi?id=1839242 Andrew Bauer changed: What|Removed |Added Depends On||1848049 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1848049 [Bug 1848049] Review Request: python-pysignals - a signal dispatcher for Python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848049] Review Request: python-pysignals - a signal dispatcher for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1848049 Andrew Bauer changed: What|Removed |Added Blocks||1839242 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1839242 [Bug 1839242] Review Request: python-ouimeaux - Open source control for Belkin WeMo devices -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848027] Review Request: perl-SQL-Abstract-Classic - Generate SQL from Perl data structures
https://bugzilla.redhat.com/show_bug.cgi?id=1848027 Petr Pisar changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com Assignee|nob...@fedoraproject.org|ppi...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839242] Review Request: python-ouimeaux - Open source control for Belkin WeMo devices
https://bugzilla.redhat.com/show_bug.cgi?id=1839242 --- Comment #11 from Andrew Bauer --- python-pysignals package review is up: https://bugzilla.redhat.com/show_bug.cgi?id=1848049 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848049] New: Review Request: python-pysignals - a signal dispatcher for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1848049 Bug ID: 1848049 Summary: Review Request: python-pysignals - a signal dispatcher for Python Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: zonexpertconsult...@outlook.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://raw.githubusercontent.com/knight-of-ni/specfiles/master/python-pysignals.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/kni/ouimeaux-fedora/fedora-rawhide-x86_64/01469907-python-pysignals/python-pysignals-0.1.2-1.fc33.src.rpm Fedora Account System Username: kni Description: PySignals is a signal dispatcher for Python, extracted from “django.dispatch” in the Django framework so it can be used in applications without requiring the entire Django framework to be installed. RPMLint output: > $ rpmlint /var/lib/mock/fedora-32-x86_64/result/*.rpm > python3-pysignals.noarch: W: spelling-error %description -l en_US django -> > fandango > python-pysignals.src: W: spelling-error %description -l en_US django -> > fandango > 2 packages and 0 specfiles checked; 0 errors, 2 warnings. This review blocks https://bugzilla.redhat.com/show_bug.cgi?id=1839242 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848047] Review Request: xtb - Semiempirical Extended Tight-Binding Program Package
https://bugzilla.redhat.com/show_bug.cgi?id=1848047 Susi Lehtola changed: What|Removed |Added Blocks||505154 (FE-SCITECH) Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=505154 [Bug 505154] Tracker: Review Requests for Science and Technology related packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848047] Review Request: xtb - Semiempirical Extended Tight-Binding Program Package
https://bugzilla.redhat.com/show_bug.cgi?id=1848047 Susi Lehtola changed: What|Removed |Added Alias||xtb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 505154] Tracker: Review Requests for Science and Technology related packages
https://bugzilla.redhat.com/show_bug.cgi?id=505154 Susi Lehtola changed: What|Removed |Added Depends On||1848047 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1848047 [Bug 1848047] Review Request: xtb - Semiempirical Extended Tight-Binding Program Package -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848047] New: Review Request: xtb - Semiempirical Extended Tight-Binding Program Package
https://bugzilla.redhat.com/show_bug.cgi?id=1848047 Bug ID: 1848047 Summary: Review Request: xtb - Semiempirical Extended Tight-Binding Program Package Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: susi.leht...@iki.fi QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jussilehtola.fedorapeople.org/xtb.spec SRPM URL: https://jussilehtola.fedorapeople.org/xtb-6.3.1-1.src.rpm Fedora Account System Username: jussilehtola Description: The xtb program package developed by the Grimme group in Bonn. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848027] Review Request: perl-SQL-Abstract-Classic - Generate SQL from Perl data structures
https://bugzilla.redhat.com/show_bug.cgi?id=1848027 Jitka Plesnikova changed: What|Removed |Added Blocks||1847730 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1847730 [Bug 1847730] perl-DBIx-Class-0.082842 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1848027] New: Review Request: perl-SQL-Abstract-Classic - Generate SQL from Perl data structures
https://bugzilla.redhat.com/show_bug.cgi?id=1848027 Bug ID: 1848027 Summary: Review Request: perl-SQL-Abstract-Classic - Generate SQL from Perl data structures Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jples...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jplesnik.fedorapeople.org/perl-SQL-Abstract-Classic/perl-SQL-Abstract-Classic.spec SRPM URL: https://jplesnik.fedorapeople.org/perl-SQL-Abstract-Classic/perl-SQL-Abstract-Classic-1.91-1.fc33.src.rpm Description: This module was inspired by the excellent DBIx::Abstract. However, in using that module I found that what I really wanted to do was generate SQL, but still retain complete control over my statement handles and use the DBI interface. So, I set out to create an abstract SQL generation module. Fedora Account System Username: jples...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847772] Review Request: ocaml-psmt2-frontend - Parser and typechecker for an extension of SMT-LIB 2
https://bugzilla.redhat.com/show_bug.cgi?id=1847772 --- Comment #1 from Jerry James --- I need to downgrade to version 0.1. It turns out that the latest free version of alt-ergo needs version 0.1, and will NOT work with version 0.2 (at least not without a significant amount of patching). New URLs: Spec URL: https://jjames.fedorapeople.org/ocaml-psmt2-frontend/ocaml-psmt2-frontend.spec SRPM URL: https://jjames.fedorapeople.org/ocaml-psmt2-frontend/ocaml-psmt2-frontend-0.1-1.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456 --- Comment #14 from lnie --- Hi Richard, > (4) You said in your answer to Miro here: > https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/message/IVTYKIOMCQPMW5SJZZ7LKUQ5SMVIULEM/ > that you would update the doc. Does this package include the updated > documentation with this change? yes:) Here are the links of the new built: Spec URL:https://download.copr.fedorainfracloud.org/results/lnie/libvirt-test-API/fedora-32-x86_64/01469834-libvirt-test-api/libvirt-test-api.spec SRPM URL:https://download.copr.fedorainfracloud.org/results/lnie/libvirt-test-API/fedora-32-x86_64/01469834-libvirt-test-api/libvirt-test-api-1.1-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 --- Comment #14 from Alexander Ploumistos --- Got it, you need to add Requires: hicolor-icon-theme -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 --- Comment #13 from Alexander Ploumistos --- My bad, there's a dependency on kde-filesystem. That's _somewhere_ in the packaging guidelines, but I can't find it right now, I'll have to check my bookmarks when I get home. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1835452] Review Request: mlxbf-bootctl - Bootloader control for Mellanox BlueField
https://bugzilla.redhat.com/show_bug.cgi?id=1835452 Alaa Hleihel (Mellanox) changed: What|Removed |Added Flags|needinfo?(ahleihel@redhat.c | |om) | --- Comment #5 from Alaa Hleihel (Mellanox) --- (In reply to Honggang LI from comment #4) > Hi, Alaa > Do we have hardware to test this package? Thanks Hi, Honggang. Yes, we can use the existing BlueField card in the lab; the same one we used for reviewing the rshim package. Regards, Alaa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1835452] Review Request: mlxbf-bootctl - Bootloader control for Mellanox BlueField
https://bugzilla.redhat.com/show_bug.cgi?id=1835452 Honggang LI changed: What|Removed |Added Flags||needinfo?(ahleihel@redhat.c ||om) --- Comment #4 from Honggang LI --- Hi, Alaa Do we have hardware to test this package? Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836568] Review Request: python-graphql-relay - Relay library for graphql-core-next
https://bugzilla.redhat.com/show_bug.cgi?id=1836568 --- Comment #6 from Fabian Affolter --- (In reply to Javier Peña from comment #5) > Now that python-graphql-core is built for Rawhide, we can move on with this. > Could you fix the spec to add pytest as a build requirement? Added. %changelog * Mon Jun 08 2020 Fabian Affolter - 3.0.0-3 - Add missing BRs Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-graphql-relay.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-graphql-relay-3.0.0-3.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 Alexander Ploumistos changed: What|Removed |Added Flags|needinfo?(alex.ploumistos@g | |mail.com) | --- Comment #12 from Alexander Ploumistos --- (In reply to Gergely Gombos from comment #11) > Because directory ownership is defined by %dir AFAIK. No, you can also just declare a path. > At least, fedora-review generates the same note, too, when I tried your > suggestion. That's odd, that was taken from one of the packages I've inherited and it was like that when it passed its review (a long time ago). I haven't seen an error in the automated tests for updates either. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847902] Review Request: rust-enumflags2 - Enum-based bit flags
https://bugzilla.redhat.com/show_bug.cgi?id=1847902 Peter Robinson changed: What|Removed |Added CC||pbrobin...@gmail.com Blocks||1269538 (IoT) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1269538 [Bug 1269538] Tracker for IoT on Fedora -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847906] Review Request: rust-tss-esapi - Wrapper around TSS 2.0 Enhanced System API
https://bugzilla.redhat.com/show_bug.cgi?id=1847906 Peter Robinson changed: What|Removed |Added CC||pbrobin...@gmail.com Blocks||1269538 (IoT) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1269538 [Bug 1269538] Tracker for IoT on Fedora -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836567] Review Request: python-graphql-core - GraphQL implementation for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1836567 --- Comment #9 from Fabian Affolter --- Yes, should be available now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839477] Review Request: python-google-api-core - Core Library for Google Client Libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1839477 --- Comment #14 from Fabian Affolter --- (In reply to Jerry James from comment #10) > Fabian, do NOT approve packages that depend on deprecated packages. You > MUST require the package submitter to remove the dependency before approving > the package. Please visit the indicated URL and read about it. It's a rpmlint issue. See https://lists.fedoraproject.org/archives/list/python-de...@lists.fedoraproject.org/thread/ZZTI6MJJBTPST35DZG22YIUC4JBMCJXN/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1727505] Review Request: python-bluepyopt - Bluebrain Python Optimisation Library (bluepyopt)
https://bugzilla.redhat.com/show_bug.cgi?id=1727505 --- Comment #15 from Anil Tuncel --- Basically this spec file below builds the rpm from PyPi and it can successfully run the bluepyopt examples after the installation on a Fedora system. spec file: https://github.com/anilbey/bluepyopt-rpm/blob/master/python-bluepyopt.spec corresponding rpm: https://github.com/anilbey/bluepyopt-rpm/blob/master/python-bluepyopt-1.9.48-1.fc32.noarch.rpm Are these good to start the review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821808] Review Request: golang-github-badgerodon-peg - Parsing Expression Grammer Parser
https://bugzilla.redhat.com/show_bug.cgi?id=1821808 --- Comment #2 from Fabian Affolter --- Thank you for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850
--- Comment #11 from Gergely Gombos ---
Thanks! I don't think that the
%{_datadir}/icons/hicolor/*/apps/%{name}.*
syntax is any different from the current
%{_datadir}/icons/hicolor/*/apps/*
Because directory ownership is defined by %dir AFAIK.
At least, fedora-review generates the same note, too, when I tried your
suggestion.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847902] Review Request: rust-enumflags2 - Enum-based bit flags
https://bugzilla.redhat.com/show_bug.cgi?id=1847902 Igor Raits changed: What|Removed |Added Blocks||1847906 (rust-tss-esapi) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1847906 [Bug 1847906] Review Request: rust-tss-esapi - Wrapper around TSS 2.0 Enhanced System API -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847899] Review Request: rust-bitfield - Macros to generate bitfield-like struct
https://bugzilla.redhat.com/show_bug.cgi?id=1847899 Igor Raits changed: What|Removed |Added Blocks||1847906 (rust-tss-esapi) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1847906 [Bug 1847906] Review Request: rust-tss-esapi - Wrapper around TSS 2.0 Enhanced System API -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847906] Review Request: rust-tss-esapi - Wrapper around TSS 2.0 Enhanced System API
https://bugzilla.redhat.com/show_bug.cgi?id=1847906 Igor Raits changed: What|Removed |Added Depends On||1847903 (rust-mbox), ||1847902 (rust-enumflags2), ||1847899 (rust-bitfield) Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1847899 [Bug 1847899] Review Request: rust-bitfield - Macros to generate bitfield-like struct https://bugzilla.redhat.com/show_bug.cgi?id=1847902 [Bug 1847902] Review Request: rust-enumflags2 - Enum-based bit flags https://bugzilla.redhat.com/show_bug.cgi?id=1847903 [Bug 1847903] Review Request: rust-mbox - Malloc-based box -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847903] Review Request: rust-mbox - Malloc-based box
https://bugzilla.redhat.com/show_bug.cgi?id=1847903 Igor Raits changed: What|Removed |Added Blocks||1847906 (rust-tss-esapi) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1847906 [Bug 1847906] Review Request: rust-tss-esapi - Wrapper around TSS 2.0 Enhanced System API -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847906] New: Review Request: rust-tss-esapi - Wrapper around TSS 2.0 Enhanced System API
https://bugzilla.redhat.com/show_bug.cgi?id=1847906 Bug ID: 1847906 Summary: Review Request: rust-tss-esapi - Wrapper around TSS 2.0 Enhanced System API Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: igor.ra...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-tss-esapi.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-tss-esapi-4.0.3~alpha.1-1.fc33.src.rpm Description: Wrapper around TSS 2.0 Enhanced System API. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 810049] Review Request: netbeans-ide - Netbeans Integrated Development Environment (IDE)
https://bugzilla.redhat.com/show_bug.cgi?id=810049 simmi07 changed: What|Removed |Added CC||jaatramesh5...@gmail.com --- Comment #125 from simmi07 --- I will show you that Jaipur Escorts are famous in Jaipur city if you want to join choose call girls in jaipur. If you want to join our another branches in Jaipur Escorts or call girls in jaipur visit our official website. Jaipur Escorts are good in Jaipur or call girls in jaipur are perfect. https://thejaipurescorts.in https://riya-mavi.com/jaipur-escorts.html https://jaipurgirlsescorts.com/guwahati-escorts.html https://riya-mavi.com/kota-escorts.html https://jaipurgirlsescorts.com -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847903] New: Review Request: rust-mbox - Malloc-based box
https://bugzilla.redhat.com/show_bug.cgi?id=1847903 Bug ID: 1847903 Summary: Review Request: rust-mbox - Malloc-based box Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: igor.ra...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-mbox.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-mbox-0.5.0-1.fc33.src.rpm Description: Malloc-based box. Supports wrapping pointers or null-terminated strings returned from malloc as a Rust type, which will be free'd on drop. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847902] New: Review Request: rust-enumflags2 - Enum-based bit flags
https://bugzilla.redhat.com/show_bug.cgi?id=1847902 Bug ID: 1847902 Summary: Review Request: rust-enumflags2 - Enum-based bit flags Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: igor.ra...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-enumflags2.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-enumflags2-0.6.4-1.fc33.src.rpm Description: Enum-based bit flags. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847900] Review Request: rust-enumflags2_derive - Do not use directly, use the reexport in the `enumflags2` crate
https://bugzilla.redhat.com/show_bug.cgi?id=1847900 Igor Raits changed: What|Removed |Added Blocks||1847902 (rust-enumflags2) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1847902 [Bug 1847902] Review Request: rust-enumflags2 - Enum-based bit flags -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847902] Review Request: rust-enumflags2 - Enum-based bit flags
https://bugzilla.redhat.com/show_bug.cgi?id=1847902 Igor Raits changed: What|Removed |Added Depends On||1847900 ||(rust-enumflags2_derive) Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1847900 [Bug 1847900] Review Request: rust-enumflags2_derive - Do not use directly, use the reexport in the `enumflags2` crate -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847900] New: Review Request: rust-enumflags2_derive - Do not use directly, use the reexport in the `enumflags2` crate
https://bugzilla.redhat.com/show_bug.cgi?id=1847900 Bug ID: 1847900 Summary: Review Request: rust-enumflags2_derive - Do not use directly, use the reexport in the `enumflags2` crate Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: igor.ra...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-enumflags2_derive.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-enumflags2_derive-0.6.4-1.fc33.src.rpm Description: Do not use directly, use the reexport in the `enumflags2` crate. This allows for better compatibility across versions. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1847899] New: Review Request: rust-bitfield - Macros to generate bitfield-like struct
https://bugzilla.redhat.com/show_bug.cgi?id=1847899 Bug ID: 1847899 Summary: Review Request: rust-bitfield - Macros to generate bitfield-like struct Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: igor.ra...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-bitfield.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-bitfield-0.13.2-1.fc33.src.rpm Description: Macros to generate bitfield-like struct. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850
--- Comment #10 from Alexander Ploumistos ---
Hi Gergely,
I'm at work now, I will check the changes tonight.
(In reply to Gergely Gombos from comment #9)
> I think we shouldn't own these directories:
> /usr/share/icons/hicolor/24x24/apps,
> /usr/share/icons/hicolor/32x32,
> /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/64x64,
> /usr/share/icons/hicolor/48x48,
> /usr/share/icons/hicolor, /usr/share/icons/hicolor/16x16,
> /usr/share/mime, /usr/share/icons/hicolor/24x24,
> /usr/share/icons/hicolor/32x32/apps, /usr/share/mime/packages,
> /usr/share/icons/hicolor/64x64/apps,
> /usr/share/icons/hicolor/16x16/apps
>
> Because they are owned by some very basic packages e.g. shared-mime-info,
> filesystem, hicolor-icon-theme.
> I don't see them being owned by other GUI packages either, but let me know
> if you think it would be better to own them.
We shouldn't own them. If you use something like this
%{_datadir}/icons/hicolor/*/apps/%{name}.*
you don't own the directories, just the files that antimicroX places in each of
them. Adjust "%{name}.*" to your file names.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844850] Review request: antimicroX - Graphical program used to map keyboard buttons and mouse controls to a gamepad
https://bugzilla.redhat.com/show_bug.cgi?id=1844850 Gergely Gombos changed: What|Removed |Added Flags||needinfo?(alex.ploumistos@g ||mail.com) --- Comment #9 from Gergely Gombos --- Fixed review issues. Spec URL: https://gombosg.fedorapeople.org/antimicrox/antimicroX.spec SRPM URL: https://gombosg.fedorapeople.org/antimicrox/antimicroX-3.0-1.20200617gitc6d79.fc32.src.rpm I think we shouldn't own these directories: /usr/share/icons/hicolor/24x24/apps, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/64x64, /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor, /usr/share/icons/hicolor/16x16, /usr/share/mime, /usr/share/icons/hicolor/24x24, /usr/share/icons/hicolor/32x32/apps, /usr/share/mime/packages, /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/16x16/apps Because they are owned by some very basic packages e.g. shared-mime-info, filesystem, hicolor-icon-theme. I don't see them being owned by other GUI packages either, but let me know if you think it would be better to own them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1836568] Review Request: python-graphql-relay - Relay library for graphql-core-next
https://bugzilla.redhat.com/show_bug.cgi?id=1836568 --- Comment #5 from Javier Peña --- Now that python-graphql-core is built for Rawhide, we can move on with this. Could you fix the spec to add pytest as a build requirement? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1825456] Review Request: libvirt-test-API - Python based regression tests for libvirt API
https://bugzilla.redhat.com/show_bug.cgi?id=1825456 --- Comment #13 from Richard W.M. Jones --- Nearly there, we're getting into nitpicking now: (1) Please fix the whitespace in: Requires:libvirt-python (2) BuildRequires: mock is listed twice. (3) It would be nice if the %check section came after the %install section. This reflects the order in which rpmbuild runs the sections: %prep -> %build -> %install -> %check (4) You said in your answer to Miro here: https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/message/IVTYKIOMCQPMW5SJZZ7LKUQ5SMVIULEM/ that you would update the doc. Does this package include the updated documentation with this change? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
